Re: [drlvm][launcher] performance issue when loading property (was Re: [launcher] Patch is available for "harmonyvm.properties" parsing)

2006-09-26 Thread Evgueni Brevnov
Sure! On 9/26/06, Geir Magnusson Jr. <[EMAIL PROTECTED]> wrote: can you do it in the new thread I started? On Sep 26, 2006, at 9:26 AM, Evgueni Brevnov wrote: > There are some comments from Alexey Varlamov in JIRA. I'm answering > his question now > > On 9/26/06, Geir Magnusson Jr. <[EMAIL

Re: [drlvm][launcher] performance issue when loading property (was Re: [launcher] Patch is available for "harmonyvm.properties" parsing)

2006-09-26 Thread Geir Magnusson Jr.
can you do it in the new thread I started? On Sep 26, 2006, at 9:26 AM, Evgueni Brevnov wrote: There are some comments from Alexey Varlamov in JIRA. I'm answering his question now On 9/26/06, Geir Magnusson Jr. <[EMAIL PROTECTED]> wrote: You did say you wanted comments :) It's been there

Re: [drlvm][launcher] performance issue when loading property (was Re: [launcher] Patch is available for "harmonyvm.properties" parsing)

2006-09-26 Thread Evgueni Brevnov
There are some comments from Alexey Varlamov in JIRA. I'm answering his question now On 9/26/06, Geir Magnusson Jr. <[EMAIL PROTECTED]> wrote: You did say you wanted comments :) It's been there for 6 hours :) Any comments? geir On Sep 26, 2006, at 8:28 AM, Evgueni Brevnov wrote: > Unfor

Re: [drlvm][launcher] performance issue when loading property (was Re: [launcher] Patch is available for "harmonyvm.properties" parsing)

2006-09-26 Thread Evgueni Brevnov
Unfortunately I can't commit it by myself :-( So waiting for Geir... :-) On 9/25/06, Alexey Varlamov <[EMAIL PROTECTED]> wrote: Sure. I just hope Evgueni will submit complete Invocation API very soon - so we would not interfere in initialization code. If not - I'm going to fix this in a day. 20

Re: [drlvm][launcher] performance issue when loading property (was Re: [launcher] Patch is available for "harmonyvm.properties" parsing)

2006-09-26 Thread Geir Magnusson Jr.
You did say you wanted comments :) It's been there for 6 hours :) Any comments? geir On Sep 26, 2006, at 8:28 AM, Evgueni Brevnov wrote: Unfortunately I can't commit it by myself :-( So waiting for Geir... :-) On 9/25/06, Alexey Varlamov <[EMAIL PROTECTED]> wrote: Sure. I just hope Evgue

Re: [drlvm][launcher] performance issue when loading property (was Re: [launcher] Patch is available for "harmonyvm.properties" parsing)

2006-09-25 Thread Alexey Varlamov
Sure. I just hope Evgueni will submit complete Invocation API very soon - so we would not interfere in initialization code. If not - I'm going to fix this in a day. 2006/9/25, Ivan Volosyuk <[EMAIL PROTECTED]>: Alexey, would you create JIRA for this? Looks you have more information about the pro

[drlvm][launcher] performance issue when loading property (was Re: [launcher] Patch is available for "harmonyvm.properties" parsing)

2006-09-25 Thread Ivan Volosyuk
Alexey, would you create JIRA for this? Looks you have more information about the problem? -- Ivan On 9/23/06, Geir Magnusson Jr. <[EMAIL PROTECTED]> wrote: Please... On Sep 23, 2006, at 7:58 AM, Alexey Varlamov wrote: > Ha! This is apr_file_gets() who does this! > > So this is DRLVM specific

Re: [launcher] Patch is available for "harmonyvm.properties" parsing

2006-09-23 Thread Geir Magnusson Jr.
Please... On Sep 23, 2006, at 7:58 AM, Alexey Varlamov wrote: Ha! This is apr_file_gets() who does this! So this is DRLVM specific and duplicates classlib's efforts. We should get rid of this. 2006/9/23, Ivan Volosyuk <[EMAIL PROTECTED]>: You are right. It is different property file: $JRE/

Re: [launcher] Patch is available for "harmonyvm.properties" parsing

2006-09-23 Thread Alexey Varlamov
2006/9/23, Geir Magnusson Jr. <[EMAIL PROTECTED]>: On Sep 23, 2006, at 6:59 AM, Alexey Varlamov wrote: > I reattached the patch. > Thanks, I saw that. > Not sure this was the case Ivan talked about - launcher was trying to > read() the whole file at once - but anyway now file contents is > mm

Re: [launcher] Patch is available for "harmonyvm.properties" parsing

2006-09-23 Thread Alexey Varlamov
Ha! This is apr_file_gets() who does this! So this is DRLVM specific and duplicates classlib's efforts. We should get rid of this. 2006/9/23, Ivan Volosyuk <[EMAIL PROTECTED]>: You are right. It is different property file: $JRE/lib/boot/bootclasspath.properties (6kbyte) The strace looks lik

Re: [launcher] Patch is available for "harmonyvm.properties" parsing

2006-09-23 Thread Geir Magnusson Jr.
On Sep 23, 2006, at 6:59 AM, Alexey Varlamov wrote: I reattached the patch. Thanks, I saw that. Not sure this was the case Ivan talked about - launcher was trying to read() the whole file at once - but anyway now file contents is mmapped for parsing. Do you have any portability concerns

Re: [launcher] Patch is available for "harmonyvm.properties" parsing

2006-09-23 Thread Ivan Volosyuk
You are right. It is different property file: $JRE/lib/boot/bootclasspath.properties (6kbyte) The strace looks like following. Not quite effective. The number of syscalls is greater then all others at the startup of VM. I would like to file a performance JIRA for the issue, but I don't quite u

Re: [launcher] Patch is available for "harmonyvm.properties" parsing

2006-09-23 Thread Alexey Varlamov
I reattached the patch. Not sure this was the case Ivan talked about - launcher was trying to read() the whole file at once - but anyway now file contents is mmapped for parsing. -- Alexey 2006/9/23, Geir Magnusson Jr. <[EMAIL PROTECTED]>: Hopefully we'll know when we get the actual patch. ge

Re: [launcher] Patch is available for "harmonyvm.properties" parsing

2006-09-22 Thread Geir Magnusson Jr.
Hopefully we'll know when we get the actual patch. geir On Sep 22, 2006, at 1:39 PM, Ivan Volosyuk wrote: When 'stracing' loading of VM I saw quite inefficient way to load a file from disk. Reading one byte at a time by read() call. If I'm not mistaken it was this property file. Is this issue

Re: [launcher] Patch is available for "harmonyvm.properties" parsing

2006-09-22 Thread Ivan Volosyuk
When 'stracing' loading of VM I saw quite inefficient way to load a file from disk. Reading one byte at a time by read() call. If I'm not mistaken it was this property file. Is this issue fixed in the JIRA? (Just curious) -- Ivan On 9/22/06, Alexey Varlamov <[EMAIL PROTECTED]> wrote: Dear comitt

Re: [launcher] Patch is available for "harmonyvm.properties" parsing

2006-09-22 Thread Geir Magnusson Jr.
not yet - I grabbed the JIRA but didn't get to it yet... On Sep 22, 2006, at 10:33 AM, Tim Ellison wrote: That patch file doesn't download properly for me. Anyone else have that problem? Regards, Tim Alexey Varlamov wrote: Dear comitters, Please find the patch attached to HARMONY-1376 whic

Re: [launcher] Patch is available for "harmonyvm.properties" parsing

2006-09-22 Thread Artem Aliev
Alexey, Could you please put the patch again. I got following error when try to access it. HTTP Status 404 - Could not find specified attachment: /usr/local/tomcat/tomcat-jira/attachments/HARMONY/HARMONY-1376/12341371_H-1376.diff (No such file or directory) Thanks Artem On 9/22/06, Geir Magnu

Re: [launcher] Patch is available for "harmonyvm.properties" parsing

2006-09-22 Thread Tim Ellison
That patch file doesn't download properly for me. Anyone else have that problem? Regards, Tim Alexey Varlamov wrote: > Dear comitters, > > Please find the patch attached to HARMONY-1376 which fixes number of > issues with "harmonyvm.properties": > 1) Robust file parsing with any EOLs; > 2) The

Re: [launcher] Patch is available for "harmonyvm.properties" parsing

2006-09-22 Thread Geir Magnusson Jr.
Ahh, thanks! :) On Sep 22, 2006, at 5:55 AM, Alexey Varlamov wrote: Dear comitters, Please find the patch attached to HARMONY-1376 which fixes number of issues with "harmonyvm.properties": 1) Robust file parsing with any EOLs; 2) The buffer overflow; 3) Added support for %VM_DIR% tokens, now

[launcher] Patch is available for "harmonyvm.properties" parsing

2006-09-22 Thread Alexey Varlamov
Dear comitters, Please find the patch attached to HARMONY-1376 which fixes number of issues with "harmonyvm.properties": 1) Robust file parsing with any EOLs; 2) The buffer overflow; 3) Added support for %VM_DIR% tokens, now easy to add any others; 4) Command-line "-Xbootclasspath:" option now re