Re: Code review every commit (was Re: GNU diff)

2011-01-28 Thread David Cantrell
On Fri, Jan 28, 2011 at 09:58:14AM +, Nicholas Clark wrote: > On Fri, Jan 28, 2011 at 10:33:22AM +1000, Michael G Schwern wrote: > > And I've used Aegis. I've CHAMPIONED Aegis. This was version control > > DESIGNED around code reviews. You could not make a commit unless it built > > ok, > >

Re: Code review every commit (was Re: GNU diff)

2011-01-28 Thread Martin Ebourne
On Fri, 2011-01-28 at 09:58 +, Nicholas Clark wrote: > On Fri, Jan 28, 2011 at 10:33:22AM +1000, Michael G Schwern wrote: > > > And I've used Aegis. I've CHAMPIONED Aegis. This was version control > > DESIGNED around code reviews. You could not make a commit unless it built > > ok, > > add

Re: Code review every commit (was Re: GNU diff)

2011-01-28 Thread Nicholas Clark
On Fri, Jan 28, 2011 at 10:33:22AM +1000, Michael G Schwern wrote: > And I've used Aegis. I've CHAMPIONED Aegis. This was version control > DESIGNED around code reviews. You could not make a commit unless it built ok, > added tests, passed tests and the previous revision failed the new tests.

Re: Code review every commit (was Re: GNU diff)

2011-01-28 Thread Michael G Schwern
On 2011.1.28 3:10 PM, Marco Von Ballmoos wrote: > (2) I think it's great that you wrote it, though, because it's quite nice > and says what needs to be said for those still stuck in an older mindset. > Your fervor (and perhaps my more hesitant one) for the new mindset will > only backfire on you if

Code review every commit (was Re: GNU diff)

2011-01-27 Thread Michael G Schwern
On 2011.1.28 4:22 AM, Marco Von Ballmoos wrote: > We also use code reviews, so rolling back committed changes never really came > up. > Usually, problems were discovered only after several other commits had been > made > whereupon it was just easier to fix the fix and check in the new change rath