[jira] [Commented] (HDFS-4346) Refactor INodeId and GenerationStamp

2013-01-02 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542068#comment-13542068 ] Hadoop QA commented on HDFS-4346: - {color:green}+1 overall{color}. Here are the results of

[jira] [Updated] (HDFS-4337) Backport HDFS-4240 to branch-1: Make sure nodes are avoided to place replica if some replica are already under the same nodegroup.

2013-01-02 Thread Tsz Wo (Nicholas), SZE (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo (Nicholas), SZE updated HDFS-4337: - Hadoop Flags: Reviewed +1 patch looks good. Backport HDFS-4240

[jira] [Updated] (HDFS-4337) Backport HDFS-4240 to branch-1: Make sure nodes are avoided to place replica if some replica are already under the same nodegroup.

2013-01-02 Thread Tsz Wo (Nicholas), SZE (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo (Nicholas), SZE updated HDFS-4337: - Resolution: Fixed Fix Version/s: 1-win 1.2.0

[jira] [Commented] (HDFS-4297) Port datanode concurrent reading and writing fixes to trunk-win

2013-01-02 Thread Arpit Agarwal (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542402#comment-13542402 ] Arpit Agarwal commented on HDFS-4297: - [~chuanliu] Could you please review the patch?

[jira] [Commented] (HDFS-347) DFS read performance suboptimal when client co-located on nodes with data

2013-01-02 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542435#comment-13542435 ] Todd Lipcon commented on HDFS-347: -- For those following along, my review comments on patch

[jira] [Updated] (HDFS-4351) Fix BlockPlacementPolicyDefault#chooseTarget when avoiding stale nodes

2013-01-02 Thread Andrew Wang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Wang updated HDFS-4351: -- Attachment: hdfs-4351-3.patch Thanks for the review Jing! I addressed your comment on the test case in

[jira] [Commented] (HDFS-1451) Extend the pluggable block placement policy interface to handle/allow file-level intelligence

2013-01-02 Thread Lohit Vijayarenu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542495#comment-13542495 ] Lohit Vijayarenu commented on HDFS-1451: This would be useful. With this kind of

[jira] [Commented] (HDFS-4346) Refactor INodeId and GenerationStamp

2013-01-02 Thread Brandon Li (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542497#comment-13542497 ] Brandon Li commented on HDFS-4346: -- +1. The patch looks good. Refactor

[jira] [Commented] (HDFS-4330) Support snapshots up to the snapshot limit

2013-01-02 Thread Aaron T. Myers (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542498#comment-13542498 ] Aaron T. Myers commented on HDFS-4330: -- Looks good to me as well. Thanks a lot,

[jira] [Commented] (HDFS-4351) Fix BlockPlacementPolicyDefault#chooseTarget when avoiding stale nodes

2013-01-02 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542499#comment-13542499 ] Jing Zhao commented on HDFS-4351: - bq. Regarding numOfReplicas, my reading is that it's the

[jira] [Updated] (HDFS-4351) Fix BlockPlacementPolicyDefault#chooseTarget when avoiding stale nodes

2013-01-02 Thread Andrew Wang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Wang updated HDFS-4351: -- Attachment: hdfs-4351-4.patch Looking at it again, you're right on totalReplicasExpected. Patch now

[jira] [Commented] (HDFS-1451) Extend the pluggable block placement policy interface to handle/allow file-level intelligence

2013-01-02 Thread Harsh J (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542510#comment-13542510 ] Harsh J commented on HDFS-1451: --- Different policy per namespace would solve the same need,

[jira] [Commented] (HDFS-4351) Fix BlockPlacementPolicyDefault#chooseTarget when avoiding stale nodes

2013-01-02 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542514#comment-13542514 ] Jing Zhao commented on HDFS-4351: - Thanks Andrew! +1 pending Jenkins. Fix

[jira] [Commented] (HDFS-4351) Fix BlockPlacementPolicyDefault#chooseTarget when avoiding stale nodes

2013-01-02 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542543#comment-13542543 ] Hadoop QA commented on HDFS-4351: - {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-4346) Refactor INodeId and GenerationStamp

2013-01-02 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542571#comment-13542571 ] Hadoop QA commented on HDFS-4346: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-4350) Make enabling of stale marking on read and write paths independent

2013-01-02 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542576#comment-13542576 ] Hadoop QA commented on HDFS-4350: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-4297) Port datanode concurrent reading and writing fixes to trunk-win

2013-01-02 Thread Chuan Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542590#comment-13542590 ] Chuan Liu commented on HDFS-4297: - +1 Thanks for porting the change!

[jira] [Commented] (HDFS-4351) Fix BlockPlacementPolicyDefault#chooseTarget when avoiding stale nodes

2013-01-02 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542645#comment-13542645 ] Hadoop QA commented on HDFS-4351: - {color:green}+1 overall{color}. Here are the results of

[jira] [Updated] (HDFS-4333) Using right default value for creating files in HDFS

2013-01-02 Thread Colin Patrick McCabe (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin Patrick McCabe updated HDFS-4333: --- Issue Type: Improvement (was: Bug) I'm re-classifying this as an improvement, since

[jira] [Commented] (HDFS-4338) TestNameNodeMetrics#testCorruptBlock is flaky

2013-01-02 Thread Aaron T. Myers (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542664#comment-13542664 ] Aaron T. Myers commented on HDFS-4338: -- +1, the patch looks good to me. Good

[jira] [Updated] (HDFS-4338) TestNameNodeMetrics#testCorruptBlock is flaky

2013-01-02 Thread Aaron T. Myers (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aaron T. Myers updated HDFS-4338: - Resolution: Fixed Fix Version/s: 3.0.0 Target Version/s: 3.0.0 Hadoop

[jira] [Commented] (HDFS-4306) PBHelper.convertLocatedBlock miss convert BlockToken

2013-01-02 Thread Aaron T. Myers (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542676#comment-13542676 ] Aaron T. Myers commented on HDFS-4306: -- Hi Binglin, the patch looks functionally fine

[jira] [Commented] (HDFS-4338) TestNameNodeMetrics#testCorruptBlock is flaky

2013-01-02 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542679#comment-13542679 ] Hudson commented on HDFS-4338: -- Integrated in Hadoop-trunk-Commit #3164 (See

[jira] [Commented] (HDFS-4227) Document dfs.namenode.resource.*

2013-01-02 Thread Aaron T. Myers (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542680#comment-13542680 ] Aaron T. Myers commented on HDFS-4227: -- Hi Daisuke/Mark, the latest patch looks pretty

[jira] [Updated] (HDFS-4346) Refactor INodeId and GenerationStamp

2013-01-02 Thread Tsz Wo (Nicholas), SZE (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo (Nicholas), SZE updated HDFS-4346: - Resolution: Fixed Fix Version/s: 3.0.0 Hadoop Flags: Reviewed

[jira] [Commented] (HDFS-4351) Fix BlockPlacementPolicyDefault#chooseTarget when avoiding stale nodes

2013-01-02 Thread Tsz Wo (Nicholas), SZE (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542724#comment-13542724 ] Tsz Wo (Nicholas), SZE commented on HDFS-4351: -- Hi Andrew, could you also post

[jira] [Commented] (HDFS-4346) Refactor INodeId and GenerationStamp

2013-01-02 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542728#comment-13542728 ] Hudson commented on HDFS-4346: -- Integrated in Hadoop-trunk-Commit #3165 (See