[
https://issues.apache.org/jira/browse/HDFS-5225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13778534#comment-13778534
]
Junping Du commented on HDFS-5225:
--
Hi [~ozawa], thanks for the patch! Besides fixing test
[
https://issues.apache.org/jira/browse/HDFS-4988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13778537#comment-13778537
]
Tsz Wo (Nicholas), SZE commented on HDFS-4988:
--
{quote}
> In new FsVolumeSpi.g
[
https://issues.apache.org/jira/browse/HDFS-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13778650#comment-13778650
]
Hudson commented on HDFS-5041:
--
FAILURE: Integrated in Hadoop-Yarn-trunk #344 (See
[https://b
[
https://issues.apache.org/jira/browse/HDFS-5246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13778654#comment-13778654
]
Hudson commented on HDFS-5246:
--
FAILURE: Integrated in Hadoop-Yarn-trunk #344 (See
[https://b
[
https://issues.apache.org/jira/browse/HDFS-5246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13778757#comment-13778757
]
Hudson commented on HDFS-5246:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk #1560 (See
[htt
[
https://issues.apache.org/jira/browse/HDFS-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13778753#comment-13778753
]
Hudson commented on HDFS-5041:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk #1560 (See
[htt
[
https://issues.apache.org/jira/browse/HDFS-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13778767#comment-13778767
]
Hudson commented on HDFS-5041:
--
SUCCESS: Integrated in Hadoop-Hdfs-trunk #1534 (See
[https://
[
https://issues.apache.org/jira/browse/HDFS-5246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13778771#comment-13778771
]
Hudson commented on HDFS-5246:
--
SUCCESS: Integrated in Hadoop-Hdfs-trunk #1534 (See
[https://
[
https://issues.apache.org/jira/browse/HDFS-5225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13778879#comment-13778879
]
Kihwal Lee commented on HDFS-5225:
--
I am seeing cases of repeated logging of "Verification
[
https://issues.apache.org/jira/browse/HDFS-5258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Nauroth updated HDFS-5258:
Target Version/s: 3.0.0, 2.1.2-beta (was: 3.0.0, 2.3.0)
> Skip tests in TestHDFSCLI that are no
[
https://issues.apache.org/jira/browse/HDFS-5186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Nauroth updated HDFS-5186:
Target Version/s: 3.0.0, 2.1.2-beta (was: 3.0.0, 2.3.0)
> TestFileJournalManager fails on Windo
[
https://issues.apache.org/jira/browse/HDFS-5258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Nauroth updated HDFS-5258:
Resolution: Fixed
Fix Version/s: 2.1.2-beta
3.0.0
Status: Resolv
[
https://issues.apache.org/jira/browse/HDFS-5258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13779001#comment-13779001
]
Hudson commented on HDFS-5258:
--
SUCCESS: Integrated in Hadoop-trunk-Commit #4474 (See
[https:
[
https://issues.apache.org/jira/browse/HDFS-5186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Nauroth updated HDFS-5186:
Resolution: Fixed
Fix Version/s: 2.1.2-beta
3.0.0
Status: Resolv
[
https://issues.apache.org/jira/browse/HDFS-5260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Nauroth updated HDFS-5260:
Status: Open (was: Patch Available)
I'll review the new warnings, patch them on the HDFS-4949 featu
Haohui Mai created HDFS-5265:
Summary: Namenode fails to start when dfs.https.port is unspecified
Key: HDFS-5265
URL: https://issues.apache.org/jira/browse/HDFS-5265
Project: Hadoop HDFS
Issue Ty
[
https://issues.apache.org/jira/browse/HDFS-5265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Haohui Mai updated HDFS-5265:
-
Attachment: HDFS-5265.000.patch
> Namenode fails to start when dfs.https.port is unspecified
> ---
[
https://issues.apache.org/jira/browse/HDFS-5265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Haohui Mai updated HDFS-5265:
-
Status: Patch Available (was: Open)
> Namenode fails to start when dfs.https.port is unspecified
> --
[
https://issues.apache.org/jira/browse/HDFS-5186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13779009#comment-13779009
]
Hudson commented on HDFS-5186:
--
SUCCESS: Integrated in Hadoop-trunk-Commit #4475 (See
[https:
[
https://issues.apache.org/jira/browse/HDFS-5265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13779015#comment-13779015
]
Jing Zhao commented on HDFS-5265:
-
Good catch [~wheat9]! Since you're in this area, maybe y
[
https://issues.apache.org/jira/browse/HDFS-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13779018#comment-13779018
]
Hadoop QA commented on HDFS-5217:
-
{color:red}-1 overall{color}. Here are the results of t
[
https://issues.apache.org/jira/browse/HDFS-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Haohui Mai updated HDFS-5256:
-
Attachment: HDFS-5256.001.patch
Address Jing's comment + plus a little bit of formatting.
[
https://issues.apache.org/jira/browse/HDFS-5265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Haohui Mai updated HDFS-5265:
-
Attachment: HDFS-5256.001.patch
> Namenode fails to start when dfs.https.port is unspecified
> ---
[
https://issues.apache.org/jira/browse/HDFS-5265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Haohui Mai updated HDFS-5265:
-
Attachment: HDFS-5256.001.patch
Address Jing's comments + a little bit of formatting.
> N
[
https://issues.apache.org/jira/browse/HDFS-5265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Haohui Mai updated HDFS-5265:
-
Attachment: (was: HDFS-5265.000.patch)
> Namenode fails to start when dfs.https.port is unspecifie
[
https://issues.apache.org/jira/browse/HDFS-5265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Haohui Mai updated HDFS-5265:
-
Attachment: (was: HDFS-5256.001.patch)
> Namenode fails to start when dfs.https.port is unspecifie
[
https://issues.apache.org/jira/browse/HDFS-5265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Haohui Mai updated HDFS-5265:
-
Attachment: (was: HDFS-5256.001.patch)
> Namenode fails to start when dfs.https.port is unspecifie
[
https://issues.apache.org/jira/browse/HDFS-5265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Haohui Mai updated HDFS-5265:
-
Attachment: HDFS-5265.001.patch
> Namenode fails to start when dfs.https.port is unspecified
> ---
[
https://issues.apache.org/jira/browse/HDFS-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Haohui Mai updated HDFS-5256:
-
Attachment: (was: HDFS-5256.001.patch)
> Use guava LoadingCache to implement DFSClientCache
>
[
https://issues.apache.org/jira/browse/HDFS-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Haohui Mai updated HDFS-5256:
-
Attachment: HDFS-5256.001.patch
> Use guava LoadingCache to implement DFSClientCache
> ---
[
https://issues.apache.org/jira/browse/HDFS-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13779100#comment-13779100
]
Haohui Mai commented on HDFS-5256:
--
Address Brandon's comments. More comprehensive unit te
[
https://issues.apache.org/jira/browse/HDFS-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13779129#comment-13779129
]
Hadoop QA commented on HDFS-5256:
-
{color:green}+1 overall{color}. Here are the results of
Chris Nauroth created HDFS-5266:
---
Summary: ElasticByteBufferPool#Key does not implement equals.
Key: HDFS-5266
URL: https://issues.apache.org/jira/browse/HDFS-5266
Project: Hadoop HDFS
Issue Ty
[
https://issues.apache.org/jira/browse/HDFS-5260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13779086#comment-13779086
]
Colin Patrick McCabe commented on HDFS-5260:
thanks, will review shortly
[
https://issues.apache.org/jira/browse/HDFS-5266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Nauroth updated HDFS-5266:
Attachment: HDFS-5266.1.patch
This was found by Findbugs on the merge patch in HDFS-5260. Here is a
[
https://issues.apache.org/jira/browse/HDFS-5266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13779141#comment-13779141
]
Chris Nauroth commented on HDFS-5266:
-
[~cmccabe] or [~andrew.wang], how does this patc
[
https://issues.apache.org/jira/browse/HDFS-5266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HDFS-5266 started by Chris Nauroth.
> ElasticByteBufferPool#Key does not implement equals.
>
>
>
[
https://issues.apache.org/jira/browse/HDFS-3983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13779145#comment-13779145
]
Arpit Agarwal commented on HDFS-3983:
-
Is this a dup of HDFS-3699? If so we can resolve
[
https://issues.apache.org/jira/browse/HDFS-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Haohui Mai updated HDFS-5256:
-
Attachment: HDFS-5256.002.patch
> Use guava LoadingCache to implement DFSClientCache
> ---
[
https://issues.apache.org/jira/browse/HDFS-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13779161#comment-13779161
]
Brandon Li commented on HDFS-5256:
--
Thanks Haohui for adding unit test. More ideas for bet
[
https://issues.apache.org/jira/browse/HDFS-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Haohui Mai updated HDFS-5256:
-
Attachment: HDFS-5256.003.patch
> Use guava LoadingCache to implement DFSClientCache
> ---
[
https://issues.apache.org/jira/browse/HDFS-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13779172#comment-13779172
]
Haohui Mai commented on HDFS-5256:
--
Addressed Brandon's comments.
> Use g
[
https://issues.apache.org/jira/browse/HDFS-5266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13779176#comment-13779176
]
Andrew Wang commented on HDFS-5266:
---
+1 thanks Chris. Since it's a final class, ok to use
[
https://issues.apache.org/jira/browse/HDFS-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13779180#comment-13779180
]
Hadoop QA commented on HDFS-5256:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-5223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13779177#comment-13779177
]
Nathan Roberts commented on HDFS-5223:
--
Thanks Aaron and Todd for bringing this up.
I
[
https://issues.apache.org/jira/browse/HDFS-5266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Nauroth resolved HDFS-5266.
-
Resolution: Fixed
Fix Version/s: HDFS-4949
Hadoop Flags: Reviewed
Thanks for the revie
[
https://issues.apache.org/jira/browse/HDFS-5260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Nauroth updated HDFS-5260:
Attachment: HDFS-5260.2.patch
Here is a new merge patch that also incorporates HDFS-5266 to correct
[
https://issues.apache.org/jira/browse/HDFS-4988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arpit Agarwal updated HDFS-4988:
Attachment: HDFS-4988.09.patch
{quote}
So, for the newly added datanodeID/storageID, I suggest to us
[
https://issues.apache.org/jira/browse/HDFS-5260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Nauroth updated HDFS-5260:
Status: Patch Available (was: Open)
> Merge zero-copy memory-mapped HDFS client reads to trunk
[
https://issues.apache.org/jira/browse/HDFS-5225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13779200#comment-13779200
]
Kihwal Lee commented on HDFS-5225:
--
I took a heap dump of a data node with this problem. I
[
https://issues.apache.org/jira/browse/HDFS-5265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13779214#comment-13779214
]
Hadoop QA commented on HDFS-5265:
-
{color:red}-1 overall{color}. Here are the results of t
[
https://issues.apache.org/jira/browse/HDFS-5266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13779216#comment-13779216
]
Colin Patrick McCabe commented on HDFS-5266:
I'm pretty sure FindBugs' next com
[
https://issues.apache.org/jira/browse/HDFS-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13779245#comment-13779245
]
Hadoop QA commented on HDFS-5256:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-5225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13779241#comment-13779241
]
Kihwal Lee commented on HDFS-5225:
--
The scan spins because getEarliestScanTime() will retu
[
https://issues.apache.org/jira/browse/HDFS-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13779297#comment-13779297
]
Brandon Li commented on HDFS-5256:
--
Haohui, let's remove the TTL since the cache entry usa
[
https://issues.apache.org/jira/browse/HDFS-5260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13779306#comment-13779306
]
Colin Patrick McCabe commented on HDFS-5260:
+1 pending Jenkins. Thanks, Chris
[
https://issues.apache.org/jira/browse/HDFS-5260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13779414#comment-13779414
]
Chris Nauroth commented on HDFS-5260:
-
I've also performed some additional manual testi
[
https://issues.apache.org/jira/browse/HDFS-5260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13779446#comment-13779446
]
Hadoop QA commented on HDFS-5260:
-
{color:red}-1 overall{color}. Here are the results of t
[
https://issues.apache.org/jira/browse/HDFS-5223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13779511#comment-13779511
]
Todd Lipcon commented on HDFS-5223:
---
bq. I love the flexibility of feature bits however I
[
https://issues.apache.org/jira/browse/HDFS-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Haohui Mai updated HDFS-5230:
-
Attachment: HDFS-5230.005.patch
Credits to [~brandonli] to pinpoint some more bugs. Address his comments.
[
https://issues.apache.org/jira/browse/HDFS-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Haohui Mai updated HDFS-5256:
-
Attachment: HDFS-5256.004.patch
Thanks [~brandonli] for the comments. Address the comments.
[
https://issues.apache.org/jira/browse/HDFS-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13779661#comment-13779661
]
Hadoop QA commented on HDFS-5230:
-
{color:red}-1 overall{color}. Here are the results of t
[
https://issues.apache.org/jira/browse/HDFS-5265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Haohui Mai updated HDFS-5265:
-
Attachment: HDFS-5265.002.patch
> Namenode fails to start when dfs.https.port is unspecified
> ---
[
https://issues.apache.org/jira/browse/HDFS-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Haohui Mai updated HDFS-5230:
-
Attachment: HDFS-5230.006.patch
Rebased.
> Introduce RpcInfo to decouple XDR classes from
[
https://issues.apache.org/jira/browse/HDFS-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13779669#comment-13779669
]
Hadoop QA commented on HDFS-5256:
-
{color:red}-1 overall{color}. Here are the results of t
[
https://issues.apache.org/jira/browse/HDFS-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13779671#comment-13779671
]
Hadoop QA commented on HDFS-5230:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-5266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Nauroth reopened HDFS-5266:
-
> ElasticByteBufferPool#Key does not implement equals.
> -
[
https://issues.apache.org/jira/browse/HDFS-5266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Nauroth updated HDFS-5266:
Attachment: HDFS-5266.addendum.patch
Right you are, Colin. Do you mind if I tack an addendum on thi
[
https://issues.apache.org/jira/browse/HDFS-5260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Nauroth updated HDFS-5260:
Attachment: HDFS-5260.3.patch
I'm attaching version 3 of the merge patch, which incorporates the add
[
https://issues.apache.org/jira/browse/HDFS-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13779687#comment-13779687
]
Brandon Li commented on HDFS-5256:
--
+1. Thank you, Haohui, for refining the patch's detail
[
https://issues.apache.org/jira/browse/HDFS-5267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Junping Du moved HADOOP-9980 to HDFS-5267:
--
Component/s: (was: util)
Fix Version/s: (was: 2.3.0)
[
https://issues.apache.org/jira/browse/HDFS-5267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Junping Du updated HDFS-5267:
-
Summary: Modification field in LightWeightHashSet and LightWeightLinkedSet
should't be volatile to get rid
[
https://issues.apache.org/jira/browse/HDFS-5267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Junping Du updated HDFS-5267:
-
Summary: Modification field in LightWeightHashSet and LightWeightLinkedSet
should't be volatile which caus
[
https://issues.apache.org/jira/browse/HDFS-5267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Junping Du updated HDFS-5267:
-
Attachment: HDFS-5276.patch
> Modification field in LightWeightHashSet and LightWeightLinkedSet should
[
https://issues.apache.org/jira/browse/HDFS-5267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13779719#comment-13779719
]
Junping Du commented on HDFS-5267:
--
Thanks Chris for confirmation. Already move to HDFS an
[
https://issues.apache.org/jira/browse/HDFS-4988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13779728#comment-13779728
]
Tsz Wo (Nicholas), SZE commented on HDFS-4988:
--
+1 the new patch looks good.
[
https://issues.apache.org/jira/browse/HDFS-4988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13779730#comment-13779730
]
Junping Du commented on HDFS-4988:
--
Thanks Arpit for addressing comments in new patch. +1
77 matches
Mail list logo