[jira] [Commented] (HDFS-3306) fuse_dfs: don't lock release operations

2012-04-19 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13258009#comment-13258009 ] Eli Collins commented on HDFS-3306: --- Agree with your logic, and the change looks good.

[jira] [Commented] (HDFS-3263) HttpFS should read HDFS config from Hadoop site.xml files

2012-04-18 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13256786#comment-13256786 ] Eli Collins commented on HDFS-3263: --- bq. TUCU: No we cannot, the current mechanism relies

[jira] [Commented] (HDFS-3282) Expose getFileLength API.

2012-04-18 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13256952#comment-13256952 ] Eli Collins commented on HDFS-3282: --- If you're going to punt on the javadoc warnings this

[jira] [Commented] (HDFS-3282) Expose getFileLength API.

2012-04-18 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13256958#comment-13256958 ] Eli Collins commented on HDFS-3282: --- Oops, misread javac warnings for javadocs warnings,

[jira] [Commented] (HDFS-3206) Miscellaneous xml cleanups for OEV

2012-04-18 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257149#comment-13257149 ] Eli Collins commented on HDFS-3206: --- I've committed this and merged to branch-2. Thanks

[jira] [Commented] (HDFS-2799) Trim fs.checkpoint.dir values

2012-04-13 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253758#comment-13253758 ] Eli Collins commented on HDFS-2799: --- +1 looks good. Two small nits: the first line of the

[jira] [Commented] (HDFS-3258) Test for HADOOP-8144 (pseudoSortByDistance in NetworkTopology for first rack local node)

2012-04-12 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252236#comment-13252236 ] Eli Collins commented on HDFS-3258: --- Hey Junping, That was my initial thought but

[jira] [Commented] (HDFS-3258) Test for HADOOP-8144 (pseudoSortByDistance in NetworkTopology for first rack local node)

2012-04-12 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252513#comment-13252513 ] Eli Collins commented on HDFS-3258: --- Ah, that explains it, so the order here in the test

[jira] [Commented] (HDFS-3258) Test for HADOOP-8144 (pseudoSortByDistance in NetworkTopology for first rack local node)

2012-04-12 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252561#comment-13252561 ] Eli Collins commented on HDFS-3258: --- I've committed HADOOP-8144, when you update the

[jira] [Commented] (HDFS-3259) NameNode#initializeSharedEdits should populate shared edits dir with edit log segments

2012-04-12 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252683#comment-13252683 ] Eli Collins commented on HDFS-3259: --- ATM, aside from Todd's comments: - I'd pull the

[jira] [Commented] (HDFS-3259) NameNode#initializeSharedEdits should populate shared edits dir with edit log segments

2012-04-12 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252723#comment-13252723 ] Eli Collins commented on HDFS-3259: --- +1 looks great

[jira] [Commented] (HDFS-3159) Document NN auto-failover setup and configuration

2012-04-12 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252798#comment-13252798 ] Eli Collins commented on HDFS-3159: --- Looks good Todd, minor comments: - Instructions say

[jira] [Commented] (HDFS-3159) Document NN auto-failover setup and configuration

2012-04-12 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252854#comment-13252854 ] Eli Collins commented on HDFS-3159: --- +1 looks great Document NN

[jira] [Commented] (HDFS-2799) Trim fs.checkpoint.dir values

2012-04-11 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252023#comment-13252023 ] Eli Collins commented on HDFS-2799: --- - Both getCheckpointEditsDirs and getCheckpointDirs

[jira] [Commented] (HDFS-3260) TestDatanodeRegistration should set minimum DN version in addition to minimum NN version

2012-04-11 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252189#comment-13252189 ] Eli Collins commented on HDFS-3260: --- +1 TestDatanodeRegistration should

[jira] [Commented] (HDFS-2696) fuse-dfs build problems

2012-04-10 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13250964#comment-13250964 ] Eli Collins commented on HDFS-2696: --- Let's have the new directory structure be

[jira] [Commented] (HDFS-2696) fuse-dfs build problems

2012-04-10 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13251242#comment-13251242 ] Eli Collins commented on HDFS-2696: --- +1 looks great. I tested that fuse-dfs now build

[jira] [Commented] (HDFS-3004) Implement Recovery Mode

2012-04-09 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13250104#comment-13250104 ] Eli Collins commented on HDFS-3004: --- +1 diff'd latest patch against the previous,

[jira] [Commented] (HDFS-3148) The client should be able to use multiple local interfaces for data transfer

2012-04-06 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13248513#comment-13248513 ] Eli Collins commented on HDFS-3148: --- I ended up creating an HDFS-3148 branch. HDFS-3218

[jira] [Commented] (HDFS-3148) The client should be able to use multiple local interfaces for data transfer

2012-04-06 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13248514#comment-13248514 ] Eli Collins commented on HDFS-3148: --- Oops, meant to say HDFS-3140 branch.

[jira] [Commented] (HDFS-2288) Replicas awaiting recovery should return a full visible length

2012-04-06 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13248540#comment-13248540 ] Eli Collins commented on HDFS-2288: --- Filed HDFS-3219 for this. Replicas

[jira] [Commented] (HDFS-3219) Disambiguate visible length in the code and docs

2012-04-06 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13248599#comment-13248599 ] Eli Collins commented on HDFS-3219: --- visible length #1 is a dynamic property (the # bytes

[jira] [Commented] (HDFS-3219) Disambiguate visible length in the code and docs

2012-04-06 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13248617#comment-13248617 ] Eli Collins commented on HDFS-3219: --- But per #1 visible length is per replica not per

[jira] [Commented] (HDFS-3226) Allow GetConf tool to print arbitrary keys

2012-04-06 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13248895#comment-13248895 ] Eli Collins commented on HDFS-3226: --- +1 pending jenkins Allow GetConf

[jira] [Commented] (HDFS-3223) Auto HA: add zkfc to hadoop-daemon.sh script

2012-04-06 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13248897#comment-13248897 ] Eli Collins commented on HDFS-3223: --- +1 Auto HA: add zkfc to

[jira] [Commented] (HDFS-3224) Bug in check for DN re-registration with different storage ID

2012-04-06 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13249008#comment-13249008 ] Eli Collins commented on HDFS-3224: --- Btw here was the code before HDFS-3144.

[jira] [Commented] (HDFS-3150) Add option for clients to contact DNs via hostname in branch-1

2012-04-05 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13247362#comment-13247362 ] Eli Collins commented on HDFS-3150: --- @Suresh, @Nicholas - if you have a specific

[jira] [Commented] (HDFS-3140) Support multiple network interfaces

2012-04-05 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13247909#comment-13247909 ] Eli Collins commented on HDFS-3140: --- I created a HDFS-3140 branch for the remaining work

[jira] [Commented] (HDFS-2983) Relax the build version check to permit rolling upgrades within a release

2012-04-05 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13248002#comment-13248002 ] Eli Collins commented on HDFS-2983: --- There's no reason we should have to upgrade the

[jira] [Commented] (HDFS-3150) Add option for clients to contact DNs via hostname in branch-1

2012-04-05 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13248014#comment-13248014 ] Eli Collins commented on HDFS-3150: --- Nicholas, this was a simple misunderstanding, Todd

[jira] [Commented] (HDFS-3084) FenceMethod.tryFence() and ShellCommandFencer should pass namenodeId as well as host:port

2012-04-04 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246086#comment-13246086 ] Eli Collins commented on HDFS-3084: --- +1 looks good

[jira] [Commented] (HDFS-3195) Compilation error in FSNamesystem

2012-04-04 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246397#comment-13246397 ] Eli Collins commented on HDFS-3195: --- Actually, it looks like HDFS-3168 removed the throws

[jira] [Commented] (HDFS-3195) Compilation error in FSNamesystem

2012-04-04 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246422#comment-13246422 ] Eli Collins commented on HDFS-3195: --- ATM had a better idea, fixing this by merging

[jira] [Commented] (HDFS-3102) Add CLI tool to initialize the shared-edits dir

2012-04-04 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246501#comment-13246501 ] Eli Collins commented on HDFS-3102: --- Two minor comments, otherwise looks excellent -

[jira] [Commented] (HDFS-3102) Add CLI tool to initialize the shared-edits dir

2012-04-04 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246542#comment-13246542 ] Eli Collins commented on HDFS-3102: --- +1 looks good Add CLI tool to

[jira] [Commented] (HDFS-2696) fuse-dfs build problems

2012-04-04 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246794#comment-13246794 ] Eli Collins commented on HDFS-2696: --- Hey Bruno, Can you generate one patch that applies

[jira] [Commented] (HDFS-3199) TestValidateConfigurationSettings is failing

2012-04-04 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246979#comment-13246979 ] Eli Collins commented on HDFS-3199: --- +1 looks good

[jira] [Commented] (HDFS-3199) TestValidateConfigurationSettings is failing

2012-04-04 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13247016#comment-13247016 ] Eli Collins commented on HDFS-3199: --- Google hdfs TestValidateConfigurationSettings, turns

[jira] [Commented] (HDFS-3148) The client should be able to use multiple local interfaces for data transfer

2012-04-03 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13245686#comment-13245686 ] Eli Collins commented on HDFS-3148: --- Hey Suresh, This feature is actually independent of

[jira] [Commented] (HDFS-3187) Upgrade guava to 11.0.2

2012-04-03 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13245817#comment-13245817 ] Eli Collins commented on HDFS-3187: --- +1 looks good Upgrade guava to

[jira] [Commented] (HDFS-3120) Enable hsync and hflush by default

2012-04-02 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13244248#comment-13244248 ] Eli Collins commented on HDFS-3120: --- The TestFileAppend4 timeout is unrelated.

[jira] [Commented] (HDFS-3148) The client should be able to use multiple local interfaces for data transfer

2012-04-02 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13244264#comment-13244264 ] Eli Collins commented on HDFS-3148: --- Yes, tested on a machine with 4 interfaces, that

[jira] [Commented] (HDFS-3148) The client should be able to use multiple local interfaces for data transfer

2012-04-02 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13244408#comment-13244408 ] Eli Collins commented on HDFS-3148: --- Yes, per my comment above, if all interfaces are on

[jira] [Commented] (HDFS-3120) Enable hsync and hflush by default

2012-04-02 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13244873#comment-13244873 ] Eli Collins commented on HDFS-3120: --- Test failure is due to port in use, unrelated.

[jira] [Commented] (HDFS-3094) add -nonInteractive and -force option to namenode -format command

2012-04-01 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243931#comment-13243931 ] Eli Collins commented on HDFS-3094: --- Test failure is HDFS-3174, posted a patch for it.

[jira] [Commented] (HDFS-3070) HDFS balancer doesn't ensure that hdfs-site.xml is loaded

2012-03-31 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243201#comment-13243201 ] Eli Collins commented on HDFS-3070: --- +1 to HDFS-3070.patch, looks good

[jira] [Commented] (HDFS-3164) Move DatanodeInfo#hostName to DatanodeID

2012-03-31 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243231#comment-13243231 ] Eli Collins commented on HDFS-3164: --- DFS_NAMENODE_UPGRADE_PERMISSION_KEY is still used by

[jira] [Commented] (HDFS-3000) Add a public API for setting quotas

2012-03-31 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243251#comment-13243251 ] Eli Collins commented on HDFS-3000: --- - Mind chiming in on the rationale of the setQuota

[jira] [Commented] (HDFS-3000) Add a public API for setting quotas

2012-03-31 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243279#comment-13243279 ] Eli Collins commented on HDFS-3000: --- +1 looks good Add a public API for

[jira] [Commented] (HDFS-3171) The DatanodeID name field is overloaded

2012-03-31 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243624#comment-13243624 ] Eli Collins commented on HDFS-3171: --- I realized I can also simplify the includes/excludes

[jira] [Commented] (HDFS-3171) The DatanodeID name field is overloaded

2012-03-31 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243640#comment-13243640 ] Eli Collins commented on HDFS-3171: --- Thanks ATM! #1 Updated the comment to just indicate

[jira] [Commented] (HDFS-3044) fsck move should be non-destructive by default

2012-03-30 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13242909#comment-13242909 ] Eli Collins commented on HDFS-3044: --- +1 updated patch looks great fsck

[jira] [Commented] (HDFS-3044) fsck move should be non-destructive by default

2012-03-30 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13242912#comment-13242912 ] Eli Collins commented on HDFS-3044: --- I've committed it to branch-1 fsck

[jira] [Commented] (HDFS-3120) Provide ability to enable sync without append

2012-03-29 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13241422#comment-13241422 ] Eli Collins commented on HDFS-3120: --- @Nicholas, mid air collision! What do you think of

[jira] [Commented] (HDFS-3120) Provide ability to enable sync without append

2012-03-29 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13241439#comment-13241439 ] Eli Collins commented on HDFS-3120: --- @Nicholas, I'm OK always enabling the sync paths on

[jira] [Commented] (HDFS-3120) Provide ability to enable sync without append

2012-03-29 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13241465#comment-13241465 ] Eli Collins commented on HDFS-3120: --- Forgot to mention, given that we know there are data

[jira] [Commented] (HDFS-3120) Provide ability to enable sync without append

2012-03-29 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13241469#comment-13241469 ] Eli Collins commented on HDFS-3120: --- This obviously only pertains to Hadoop 1.x btw.

[jira] [Commented] (HDFS-3044) fsck move should be non-destructive by default

2012-03-29 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13241854#comment-13241854 ] Eli Collins commented on HDFS-3044: --- Oops, I ran the test for sanity and looks like we

[jira] [Commented] (HDFS-3120) Provide ability to enable sync without append

2012-03-29 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13241903#comment-13241903 ] Eli Collins commented on HDFS-3120: --- Latest proposal: For 1.x: - Always enable the sync

[jira] [Commented] (HDFS-3137) Bump LAST_UPGRADABLE_LAYOUT_VERSION

2012-03-29 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13241941#comment-13241941 ] Eli Collins commented on HDFS-3137: --- Thanks Nicholas! Btw I verified an upgrade from a

[jira] [Commented] (HDFS-3158) LiveNodes member of NameNodeMXBean should list non-DFS used space and capacity per DN

2012-03-28 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13240771#comment-13240771 ] Eli Collins commented on HDFS-3158: --- +1 lgtm LiveNodes member of

[jira] [Commented] (HDFS-3000) Add a public API for setting quotas

2012-03-28 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13240825#comment-13240825 ] Eli Collins commented on HDFS-3000: --- On one hand quotas are not HDFS-specific, so fine

[jira] [Commented] (HDFS-3000) Add a public API for setting quotas

2012-03-28 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13240853#comment-13240853 ] Eli Collins commented on HDFS-3000: --- ATM has a point wrt the asymmetry, does it make

[jira] [Commented] (HDFS-3160) httpfs should exec catalina instead of forking it

2012-03-28 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13240871#comment-13240871 ] Eli Collins commented on HDFS-3160: --- Forgot to mention, the test failure is unrelated

[jira] [Commented] (HDFS-3137) Bump LAST_UPGRADABLE_LAYOUT_VERSION

2012-03-28 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13240948#comment-13240948 ] Eli Collins commented on HDFS-3137: --- For sanity I'll upgrade from a 0.18 install to a

[jira] [Commented] (HDFS-2617) Replaced Kerberized SSL for image transfer and fsck with SPNEGO-based solution

2012-03-27 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13240010#comment-13240010 ] Eli Collins commented on HDFS-2617: --- In the meantime can you answer Alejandro's question

[jira] [Commented] (HDFS-3050) refactor OEV to share more code with the NameNode

2012-03-26 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238788#comment-13238788 ] Eli Collins commented on HDFS-3050: --- Another patch for the TestOfflineEditsViewer

[jira] [Commented] (HDFS-2038) Update test to handle relative paths with globs

2012-03-24 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13237718#comment-13237718 ] Eli Collins commented on HDFS-2038: --- The following is still in the code, it can be

[jira] [Commented] (HDFS-3139) Minor Datanode logging improvement

2012-03-24 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13237719#comment-13237719 ] Eli Collins commented on HDFS-3139: --- Looking into TestDFSAddressConfig, the other two

[jira] [Commented] (HDFS-3128) TestResolveHdfsSymlink#testFcResolveAfs shouldn't use /tmp

2012-03-23 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13236876#comment-13236876 ] Eli Collins commented on HDFS-3128: --- Yea, we should scrub all those. Great if whoever

[jira] [Commented] (HDFS-3050) refactor OEV to share more code with the NameNode

2012-03-22 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13235825#comment-13235825 ] Eli Collins commented on HDFS-3050: --- The latest patch looks good to go. Jenkins can't

[jira] [Commented] (HDFS-3044) fsck move should be non-destructive by default

2012-03-22 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13235841#comment-13235841 ] Eli Collins commented on HDFS-3044: --- +1 pending jenkins (I'll kick it)

[jira] [Commented] (HDFS-3050) refactor OEV to share more code with the NameNode

2012-03-22 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13235904#comment-13235904 ] Eli Collins commented on HDFS-3050: --- Jenkins will test the patch either way (if it's in

[jira] [Commented] (HDFS-3050) refactor OEV to share more code with the NameNode

2012-03-22 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13235906#comment-13235906 ] Eli Collins commented on HDFS-3050: --- Er I mean in hdfs not common. I'm fine with a

[jira] [Commented] (HDFS-3128) TestResolveHdfsSymlink#testFcResolveAfs shouldn't use /tmp

2012-03-22 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13236017#comment-13236017 ] Eli Collins commented on HDFS-3128: --- Here's the full stacktrace: {noformat}

[jira] [Commented] (HDFS-3129) NetworkTopology: add test that getLeaf should check for invalid topologies

2012-03-22 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13236143#comment-13236143 ] Eli Collins commented on HDFS-3129: --- +1 (I reviewed this in HADOOP-8159) Kicking

[jira] [Commented] (HDFS-2288) Replicas awaiting recovery should return a full visible length

2012-03-22 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13236220#comment-13236220 ] Eli Collins commented on HDFS-2288: --- There's two definition of visible length, or rather

[jira] [Commented] (HDFS-3050) refactor OEV to share more code with the NameNode

2012-03-20 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13233578#comment-13233578 ] Eli Collins commented on HDFS-3050: --- Think you need to regenerate the diff, this one

[jira] [Commented] (HDFS-3044) fsck move should be non-destructive by default

2012-03-20 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13233591#comment-13233591 ] Eli Collins commented on HDFS-3044: --- - Still needs a test the new behavior of fsck move,

[jira] [Commented] (HDFS-2617) Replaced Kerberized SSL for image transfer and fsck with SPNEGO-based solution

2012-03-20 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13233651#comment-13233651 ] Eli Collins commented on HDFS-2617: --- Cool, sometime soon? Replaced

[jira] [Commented] (HDFS-3107) HDFS truncate

2012-03-20 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13233816#comment-13233816 ] Eli Collins commented on HDFS-3107: --- bq. Since appends were enabled very recently, only

[jira] [Commented] (HDFS-3004) Implement Recovery Mode

2012-03-16 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231699#comment-13231699 ] Eli Collins commented on HDFS-3004: --- Feedback on the earlier version: - Why is the

[jira] [Commented] (HDFS-3004) Implement Recovery Mode

2012-03-16 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231709#comment-13231709 ] Eli Collins commented on HDFS-3004: --- Forgot to mention, JournalStream is removed but

[jira] [Commented] (HDFS-3102) Add CLI tool to initialize the shared-edits dir

2012-03-15 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13230897#comment-13230897 ] Eli Collins commented on HDFS-3102: --- Can't we re-use bootstrapStandby (HDFS-2731)?

[jira] [Commented] (HDFS-3093) TestAllowFormat is trying to be interactive

2012-03-14 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229615#comment-13229615 ] Eli Collins commented on HDFS-3093: --- +1 TestAllowFormat is trying to be

[jira] [Commented] (HDFS-3077) Quorum-based protocol for reading and writing edit logs

2012-03-14 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229628#comment-13229628 ] Eli Collins commented on HDFS-3077: --- Flavio, Ivan, BK has two of the same main issues

[jira] [Commented] (HDFS-3075) Backport HADOOP-4885 to branch-1

2012-03-14 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229767#comment-13229767 ] Eli Collins commented on HDFS-3075: --- Sorry, posted to the wrong jira!

[jira] [Commented] (HDFS-3070) hdfs balancer doesn't balance blocks between datanodes

2012-03-12 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228068#comment-13228068 ] Eli Collins commented on HDFS-3070: --- Yea sounds like a bug in the method the balancer

[jira] [Commented] (HDFS-2303) jsvc needs to be recompilable

2012-03-12 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228169#comment-13228169 ] Eli Collins commented on HDFS-2303: --- bq. -1 core tests. The patch failed the unit tests

[jira] [Commented] (HDFS-3004) Implement Recovery Mode

2012-03-12 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228186#comment-13228186 ] Eli Collins commented on HDFS-3004: --- bq. The first choice isn't always skip-- sometimes

[jira] [Commented] (HDFS-1623) High Availability Framework for HDFS NN

2012-03-09 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13226273#comment-13226273 ] Eli Collins commented on HDFS-1623: --- +1 branch 23 patch looks good to me

[jira] [Commented] (HDFS-3004) Implement Recovery Mode

2012-03-09 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13226378#comment-13226378 ] Eli Collins commented on HDFS-3004: --- Your comments above make sense, thanks for the

[jira] [Commented] (HDFS-2303) jsvc needs to be recompilable

2012-03-09 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13226395#comment-13226395 ] Eli Collins commented on HDFS-2303: --- +1 Latest patch (HDFS-2303-5-trunk.patch) looks

[jira] [Commented] (HDFS-3066) cap space usage of default log4j rolling policy (hdfs specific changes)

2012-03-09 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13226399#comment-13226399 ] Eli Collins commented on HDFS-3066: --- +1 pending jenkins cap space usage

[jira] [Commented] (HDFS-3004) Implement Recovery Mode

2012-03-09 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13226583#comment-13226583 ] Eli Collins commented on HDFS-3004: --- HDFS-3004.008.patch has a bunch of other stuff in

[jira] [Commented] (HDFS-3070) hdfs balancer doesn't balance blocks between datanodes

2012-03-09 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13226599#comment-13226599 ] Eli Collins commented on HDFS-3070: --- Stephen, What are dfs.namenode.rpc-address and

[jira] [Commented] (HDFS-3050) refactor OEV to share more code with the NameNode

2012-03-09 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13226624#comment-13226624 ] Eli Collins commented on HDFS-3050: --- Hey Colin, Agree that #4 is good approach, can punt

[jira] [Commented] (HDFS-3044) fsck move should be non-destructive by default

2012-03-09 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13226646#comment-13226646 ] Eli Collins commented on HDFS-3044: --- - The new boolean destructive is unused -

[jira] [Commented] (HDFS-3045) fsck move should bail on a file if it can't create a block file

2012-03-09 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13226655#comment-13226655 ] Eli Collins commented on HDFS-3045: --- Looks good. This doesn't unwind the directory

[jira] [Commented] (HDFS-2303) jsvc needs to be recompilable

2012-03-08 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13225327#comment-13225327 ] Eli Collins commented on HDFS-2303: --- Mingjie, - Have you verified you can set JSVC_HOME

  1   2   3   4   >