[jira] [Commented] (HDFS-14017) ObserverReadProxyProviderWithIPFailover should work with HA configuration

2018-11-15 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688316#comment-16688316 ] Erik Krogen commented on HDFS-14017: Hey [~vagarychen], I think the new approach looks great! My

[jira] [Commented] (HDFS-14067) Allow manual failover between standby and observer

2018-11-13 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685901#comment-16685901 ] Erik Krogen commented on HDFS-14067: {quote} In our case, I do see some potential inconsistency.

[jira] [Commented] (HDFS-14035) NN status discovery does not leverage delegation token

2018-11-13 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685679#comment-16685679 ] Erik Krogen commented on HDFS-14035: v014 patch LGTM. Is the {{MagicConstant}} warning that you

[jira] [Commented] (HDFS-14017) ObserverReadProxyProviderWithIPFailover should work with HA configuration

2018-11-13 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685603#comment-16685603 ] Erik Krogen commented on HDFS-14017: Hey [~vagarychen], v009 patch LGTM as long as we have a

[jira] [Commented] (HDFS-14045) Use different metrics in DataNode to better measure latency of heartbeat/blockReports/incrementalBlockReports of Active/Standby NN

2018-11-13 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685451#comment-16685451 ] Erik Krogen commented on HDFS-14045: The new changes look good to me, thanks for all of your work

[jira] [Commented] (HDFS-14067) Allow manual failover between standby and observer

2018-11-12 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684545#comment-16684545 ] Erik Krogen commented on HDFS-14067: {quote} Is the concern about that the states could be cached

[jira] [Commented] (HDFS-14067) Allow manual failover between standby and observer

2018-11-12 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684354#comment-16684354 ] Erik Krogen commented on HDFS-14067: Hey [~csun], I'm not too familiar with automatic failover so not

[jira] [Commented] (HDFS-14045) Use different metrics in DataNode to better measure latency of heartbeat/blockReports/incrementalBlockReports of Active/Standby NN

2018-11-09 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681592#comment-16681592 ] Erik Krogen commented on HDFS-14045: Cool, the new changes LGTM. A few additional comments: * Can we

[jira] [Commented] (HDFS-14017) ObserverReadProxyProviderWithIPFailover should work with HA configuration

2018-11-08 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680534#comment-16680534 ] Erik Krogen commented on HDFS-14017: {quote}Probably should be based on different fs.defaultFS, which

[jira] [Commented] (HDFS-14017) ObserverReadProxyProviderWithIPFailover should work with HA configuration

2018-11-07 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678626#comment-16678626 ] Erik Krogen commented on HDFS-14017: {quote} What did you by a non-default FS? I meant the config

[jira] [Work started] (HDFS-12533) NNThroughputBenchmark threads get stuck on UGI.getCurrentUser()

2018-11-07 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HDFS-12533 started by Erik Krogen. -- > NNThroughputBenchmark threads get stuck on UGI.getCurrentUser() >

[jira] [Commented] (HDFS-12533) NNThroughputBenchmark threads get stuck on UGI.getCurrentUser()

2018-11-07 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678603#comment-16678603 ] Erik Krogen commented on HDFS-12533: Just an update on this, I tried running the same experiments I

[jira] [Assigned] (HDFS-12533) NNThroughputBenchmark threads get stuck on UGI.getCurrentUser()

2018-11-07 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik Krogen reassigned HDFS-12533: -- Assignee: Erik Krogen > NNThroughputBenchmark threads get stuck on UGI.getCurrentUser() >

[jira] [Commented] (HDFS-14017) ObserverReadProxyProviderWithIPFailover should work with HA configuration

2018-11-07 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678570#comment-16678570 ] Erik Krogen commented on HDFS-14017: Interesting... I see the issue now. I did not notice previously

[jira] [Commented] (HDFS-14035) NN status discovery does not leverage delegation token

2018-11-07 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678579#comment-16678579 ] Erik Krogen commented on HDFS-14035: Changes LGTM, it does seem we need to fix some tests though. I

[jira] [Commented] (HDFS-14045) Use different metrics in DataNode to better measure latency of heartbeat/blockReports/incrementalBlockReports of Active/Standby NN

2018-11-07 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678463#comment-16678463 ] Erik Krogen commented on HDFS-14045: {quote} but I think grouping metrics by role of NN is more

[jira] [Comment Edited] (HDFS-14017) ObserverReadProxyProviderWithIPFailover should work with HA configuration

2018-11-06 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677392#comment-16677392 ] Erik Krogen edited comment on HDFS-14017 at 11/6/18 11:08 PM: -- Cool, I like

[jira] [Comment Edited] (HDFS-14017) ObserverReadProxyProviderWithIPFailover should work with HA configuration

2018-11-06 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677392#comment-16677392 ] Erik Krogen edited comment on HDFS-14017 at 11/6/18 11:07 PM: -- Cool, I like

[jira] [Commented] (HDFS-14017) ObserverReadProxyProviderWithIPFailover should work with HA configuration

2018-11-06 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677392#comment-16677392 ] Erik Krogen commented on HDFS-14017: * Can we extend the Javadoc of

[jira] [Comment Edited] (HDFS-14035) NN status discovery does not leverage delegation token

2018-11-06 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677380#comment-16677380 ] Erik Krogen edited comment on HDFS-14035 at 11/6/18 10:50 PM: -- This approach

[jira] [Commented] (HDFS-14035) NN status discovery does not leverage delegation token

2018-11-06 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677380#comment-16677380 ] Erik Krogen commented on HDFS-14035: This approach LGTM, thanks [~vagarychen]! A few comments: *

[jira] [Commented] (HDFS-14048) DFSOutputStream close() throws exception on subsequent call after DataNode restart

2018-11-06 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677268#comment-16677268 ] Erik Krogen commented on HDFS-14048: Fantastic, thanks [~elgoiri]! Really appreciate the fast

[jira] [Updated] (HDFS-14048) DFSOutputStream close() throws exception on subsequent call after DataNode restart

2018-11-06 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik Krogen updated HDFS-14048: --- Attachment: HDFS-14048-branch-2.000.patch > DFSOutputStream close() throws exception on subsequent

[jira] [Reopened] (HDFS-14048) DFSOutputStream close() throws exception on subsequent call after DataNode restart

2018-11-06 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik Krogen reopened HDFS-14048: Re-opening for branch-2 commit. Sorry for the trouble [~elgoiri], I have just attached the branch-2

[jira] [Commented] (HDFS-14045) Use different metrics in DataNode to better measure latency of heartbeat/blockReports/incrementalBlockReports of Active/Standby NN

2018-11-06 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677179#comment-16677179 ] Erik Krogen commented on HDFS-14045: Hey folks, I think the current patch is an improvement, but I

[jira] [Commented] (HDFS-14048) DFSOutputStream close() throws exception on subsequent call after DataNode restart

2018-11-06 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677172#comment-16677172 ] Erik Krogen commented on HDFS-14048: Thank you [~jojochuang] / [~elgoiri]! {{trunk}} ~ {{branch-2.9}}

[jira] [Commented] (HDFS-14017) ObserverReadProxyProviderWithIPFailover should work with HA configuration

2018-11-02 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673720#comment-16673720 ] Erik Krogen commented on HDFS-14017: Okay, gotcha. I think I was confused by the mismatch of what

[jira] [Commented] (HDFS-14048) DFSOutputStream close() throws exception on subsequent call after DataNode restart

2018-11-02 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673672#comment-16673672 ] Erik Krogen commented on HDFS-14048: I was a little worried that {{TestPipelinesFailover}} might be

[jira] [Commented] (HDFS-14017) ObserverReadProxyProviderWithIPFailover should work with HA configuration

2018-11-02 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673670#comment-16673670 ] Erik Krogen commented on HDFS-14017: So the way I see it, ObserverReadProxyProvider has two

[jira] [Commented] (HDFS-14045) Use different metrics in DataNode to better measure latency of heartbeat/blockReports/incrementalBlockReports of Active/Standby NN

2018-11-02 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673515#comment-16673515 ] Erik Krogen commented on HDFS-14045: +1 this makes sense to me. Thanks for the ping [~elgoiri] > Use

[jira] [Commented] (HDFS-14048) DFSOutputStream close() throws exception on subsequent call after DataNode restart

2018-11-02 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673446#comment-16673446 ] Erik Krogen commented on HDFS-14048: Thanks for taking a look [~jojochuang]! Actually, the

[jira] [Comment Edited] (HDFS-14048) DFSOutputStream close() throws exception on subsequent call after DataNode restart

2018-11-02 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673446#comment-16673446 ] Erik Krogen edited comment on HDFS-14048 at 11/2/18 5:22 PM: - Thanks for

[jira] [Commented] (HDFS-14017) ObserverReadProxyProviderWithIPFailover should work with HA configuration

2018-11-02 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673267#comment-16673267 ] Erik Krogen commented on HDFS-14017: Hey [~vagarychen], as I understand it, this patch essentially

[jira] [Commented] (HDFS-14048) DFSOutputStream close() throws exception on subsequent call after DataNode restart

2018-11-02 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673168#comment-16673168 ] Erik Krogen commented on HDFS-14048: The fix is simple: when clearing the exception state, also do a

[jira] [Updated] (HDFS-14048) DFSOutputStream close() throws exception on subsequent call after DataNode restart

2018-11-02 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik Krogen updated HDFS-14048: --- Status: Patch Available (was: In Progress) > DFSOutputStream close() throws exception on subsequent

[jira] [Updated] (HDFS-14048) DFSOutputStream close() throws exception on subsequent call after DataNode restart

2018-11-02 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik Krogen updated HDFS-14048: --- Attachment: HDFS-14048.000.patch > DFSOutputStream close() throws exception on subsequent call after

[jira] [Work started] (HDFS-14048) DFSOutputStream close() throws exception on subsequent call after DataNode restart

2018-11-02 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HDFS-14048 started by Erik Krogen. -- > DFSOutputStream close() throws exception on subsequent call after DataNode >

[jira] [Created] (HDFS-14048) DFSOutputStream close() throws exception on subsequent call after DataNode restart

2018-11-02 Thread Erik Krogen (JIRA)
Erik Krogen created HDFS-14048: -- Summary: DFSOutputStream close() throws exception on subsequent call after DataNode restart Key: HDFS-14048 URL: https://issues.apache.org/jira/browse/HDFS-14048

[jira] [Commented] (HDFS-14035) NN status discovery does not leverage delegation token

2018-10-31 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670627#comment-16670627 ] Erik Krogen commented on HDFS-14035: {quote} Specifically, introduce a new RPC call such as

[jira] [Created] (HDFS-14034) Support getQuotaUsage API in WebHDFS

2018-10-29 Thread Erik Krogen (JIRA)
Erik Krogen created HDFS-14034: -- Summary: Support getQuotaUsage API in WebHDFS Key: HDFS-14034 URL: https://issues.apache.org/jira/browse/HDFS-14034 Project: Hadoop HDFS Issue Type: Improvement

[jira] [Updated] (HDFS-13946) Log longest FSN write/read lock held stack trace

2018-10-25 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik Krogen updated HDFS-13946: --- Attachment: HDFS-13946.007.patch > Log longest FSN write/read lock held stack trace >

[jira] [Commented] (HDFS-13946) Log longest FSN write/read lock held stack trace

2018-10-25 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16664002#comment-16664002 ] Erik Krogen commented on HDFS-13946: I looked more closely at the test and I see where my confusion

[jira] [Commented] (HDFS-13924) Handle BlockMissingException when reading from observer

2018-10-24 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16662404#comment-16662404 ] Erik Krogen commented on HDFS-13924: Great, thanks [~csun]! > Handle BlockMissingException when

[jira] [Updated] (HDFS-13924) Handle BlockMissingException when reading from observer

2018-10-23 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik Krogen updated HDFS-13924: --- Attachment: HDFS-13924-HDFS-12943.004.patch > Handle BlockMissingException when reading from

[jira] [Commented] (HDFS-13924) Handle BlockMissingException when reading from observer

2018-10-23 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16661333#comment-16661333 ] Erik Krogen commented on HDFS-13924: v003 looks great, +1. Agreed that FindBugs is not related, and

[jira] [Commented] (HDFS-13946) Log longest FSN write/read lock held stack trace

2018-10-19 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16656973#comment-16656973 ] Erik Krogen commented on HDFS-13946: I think you've made the test weaker... Previously it verified

[jira] [Commented] (HDFS-13924) Handle BlockMissingException when reading from observer

2018-10-18 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16655480#comment-16655480 ] Erik Krogen commented on HDFS-13924: Hey [~csun], this is great stuff, thanks for doing this. I have

[jira] [Commented] (HDFS-13946) Log longest FSN write/read lock held stack trace

2018-10-18 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16655424#comment-16655424 ] Erik Krogen commented on HDFS-13946: Great stuff [~yiwang], I think v003 looks pretty good once the

[jira] [Commented] (HDFS-13946) Log longest FSN write/read lock held stack trace

2018-10-17 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653760#comment-16653760 ] Erik Krogen commented on HDFS-13946: For the read lock the logic looks good, a few minor style nits:

[jira] [Comment Edited] (HDFS-13946) Log longest FSN write/read lock held stack trace

2018-10-17 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643707#comment-16643707 ] Erik Krogen edited comment on HDFS-13946 at 10/17/18 3:39 PM: -- Hey

[jira] [Comment Edited] (HDFS-13946) Log longest FSN write/read lock held stack trace

2018-10-09 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643707#comment-16643707 ] Erik Krogen edited comment on HDFS-13946 at 10/9/18 4:31 PM: - Hey

[jira] [Commented] (HDFS-13946) Log longest FSN write/read lock held stack trace

2018-10-09 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643707#comment-16643707 ] Erik Krogen commented on HDFS-13946: Hey [~linyiqun], thanks for the ping. The idea makes sense to

[jira] [Created] (HDFS-13977) NameNode can kill itself if it tries to send too many txns to a QJM simultaneously

2018-10-08 Thread Erik Krogen (JIRA)
Erik Krogen created HDFS-13977: -- Summary: NameNode can kill itself if it tries to send too many txns to a QJM simultaneously Key: HDFS-13977 URL: https://issues.apache.org/jira/browse/HDFS-13977

[jira] [Commented] (HDFS-13791) Limit logging frequency of edit tail related statements

2018-09-27 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16630767#comment-16630767 ] Erik Krogen commented on HDFS-13791: Thanks [~vagarychen]! > Limit logging frequency of edit tail

[jira] [Updated] (HDFS-13791) Limit logging frequency of edit tail related statements

2018-09-24 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik Krogen updated HDFS-13791: --- Attachment: HDFS-13791-HDFS-12943.006.patch > Limit logging frequency of edit tail related

[jira] [Commented] (HDFS-13791) Limit logging frequency of edit tail related statements

2018-09-24 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626257#comment-16626257 ] Erik Krogen commented on HDFS-13791: Attached v006 addressing the last checkstlye issue. Not sure why

[jira] [Assigned] (HDFS-13930) Fix crlf line endings in HDFS-12943 branch

2018-09-24 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik Krogen reassigned HDFS-13930: -- Assignee: Konstantin Shvachko (was: Erik Krogen) > Fix crlf line endings in HDFS-12943

[jira] [Commented] (HDFS-13930) Fix crlf line endings in HDFS-12943 branch

2018-09-24 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626182#comment-16626182 ] Erik Krogen commented on HDFS-13930: Great, thanks [~shv]. Agreed that rewriting the history makes

[jira] [Resolved] (HDFS-13930) Fix crlf line endings in HDFS-12943 branch

2018-09-24 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik Krogen resolved HDFS-13930. Resolution: Fixed > Fix crlf line endings in HDFS-12943 branch >

[jira] [Comment Edited] (HDFS-13898) Throw retriable exception for getBlockLocations when ObserverNameNode is in safemode

2018-09-21 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624249#comment-16624249 ] Erik Krogen edited comment on HDFS-13898 at 9/21/18 10:15 PM: -- v004 LGTM!

[jira] [Updated] (HDFS-13898) Throw retriable exception for getBlockLocations when ObserverNameNode is in safemode

2018-09-21 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik Krogen updated HDFS-13898: --- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: HDFS-12943 Status:

[jira] [Commented] (HDFS-13898) Throw retriable exception for getBlockLocations when ObserverNameNode is in safemode

2018-09-21 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624249#comment-16624249 ] Erik Krogen commented on HDFS-13898: v004 LGTM! The unit test failures all seem to be just flakiness.

[jira] [Commented] (HDFS-13930) Fix crlf line endings in HDFS-12943 branch

2018-09-21 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624243#comment-16624243 ] Erik Krogen commented on HDFS-13930: Attached a v000 patch. I'm not sure if it will apply

[jira] [Comment Edited] (HDFS-13930) Fix crlf line endings in HDFS-12943 branch

2018-09-21 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624243#comment-16624243 ] Erik Krogen edited comment on HDFS-13930 at 9/21/18 10:06 PM: -- Attached a

[jira] [Updated] (HDFS-13930) Fix crlf line endings in HDFS-12943 branch

2018-09-21 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik Krogen updated HDFS-13930: --- Attachment: HDFS-13930-HDFS-12943.000.patch > Fix crlf line endings in HDFS-12943 branch >

[jira] [Updated] (HDFS-13930) Fix crlf line endings in HDFS-12943 branch

2018-09-21 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik Krogen updated HDFS-13930: --- Status: Patch Available (was: In Progress) > Fix crlf line endings in HDFS-12943 branch >

[jira] [Work started] (HDFS-13930) Fix crlf line endings in HDFS-12943 branch

2018-09-21 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HDFS-13930 started by Erik Krogen. -- > Fix crlf line endings in HDFS-12943 branch >

[jira] [Commented] (HDFS-13791) Limit logging frequency of edit tail related statements

2018-09-21 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624230#comment-16624230 ] Erik Krogen commented on HDFS-13791: Attached a v005 patch which adds in a decent unit test for the

[jira] [Updated] (HDFS-13791) Limit logging frequency of edit tail related statements

2018-09-21 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik Krogen updated HDFS-13791: --- Attachment: HDFS-13791-HDFS-12943.005.patch > Limit logging frequency of edit tail related

[jira] [Commented] (HDFS-13898) Throw retriable exception for getBlockLocations when ObserverNameNode is in safemode

2018-09-21 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624014#comment-16624014 ] Erik Krogen commented on HDFS-13898: Last nit is that the {{@Test}} annotation should go after the

[jira] [Commented] (HDFS-13791) Limit logging frequency of edit tail related statements

2018-09-20 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622819#comment-16622819 ] Erik Krogen commented on HDFS-13791: Just attached v004 patch rebasing on top of the changes in

[jira] [Updated] (HDFS-13791) Limit logging frequency of edit tail related statements

2018-09-20 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik Krogen updated HDFS-13791: --- Attachment: HDFS-13791-HDFS-12943.004.patch > Limit logging frequency of edit tail related

[jira] [Commented] (HDFS-13930) Fix crlf line endings in HDFS-12943 branch

2018-09-20 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622801#comment-16622801 ] Erik Krogen commented on HDFS-13930: That was the commit that was merged, but as far as I can tell,

[jira] [Created] (HDFS-13930) Fix crlf line endings in HDFS-12943 branch

2018-09-20 Thread Erik Krogen (JIRA)
Erik Krogen created HDFS-13930: -- Summary: Fix crlf line endings in HDFS-12943 branch Key: HDFS-13930 URL: https://issues.apache.org/jira/browse/HDFS-13930 Project: Hadoop HDFS Issue Type:

[jira] [Updated] (HDFS-13749) Use getServiceStatus to discover observer namenodes

2018-09-20 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik Krogen updated HDFS-13749: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Use getServiceStatus to

[jira] [Updated] (HDFS-13749) Use getServiceStatus to discover observer namenodes

2018-09-20 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik Krogen updated HDFS-13749: --- Hadoop Flags: Reviewed Fix Version/s: HDFS-12943 > Use getServiceStatus to discover observer

[jira] [Commented] (HDFS-13749) Use getServiceStatus to discover observer namenodes

2018-09-20 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622666#comment-16622666 ] Erik Krogen commented on HDFS-13749: Funny that my v007 precommit beat your v006 to posting :)

[jira] [Updated] (HDFS-13749) Use getServiceStatus to discover observer namenodes

2018-09-20 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik Krogen updated HDFS-13749: --- Attachment: HDFS-13749-HDFS-12943.007.patch > Use getServiceStatus to discover observer namenodes >

[jira] [Commented] (HDFS-13749) Use getServiceStatus to discover observer namenodes

2018-09-20 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622389#comment-16622389 ] Erik Krogen commented on HDFS-13749: So for the checkstyle {code} proxyProvider = new

[jira] [Commented] (HDFS-13898) Throw retriable exception for getBlockLocations when ObserverNameNode is in safemode

2018-09-20 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622255#comment-16622255 ] Erik Krogen commented on HDFS-13898: {quote} Why it has to scan all of the observers - wouldn't it

[jira] [Commented] (HDFS-13898) Throw retriable exception for getBlockLocations when ObserverNameNode is in safemode

2018-09-18 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16619418#comment-16619418 ] Erik Krogen commented on HDFS-13898: Hey [~csun], I realized a potential issue with this approach.

[jira] [Commented] (HDFS-13749) Use getServiceStatus to discover observer namenodes

2018-09-14 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615391#comment-16615391 ] Erik Krogen commented on HDFS-13749: Nice, v003 looks good to me [~csun]. A few minor nits: * There

[jira] [Commented] (HDFS-13898) Throw retriable exception for getBlockLocations when ObserverNameNode is in safemode

2018-09-14 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615283#comment-16615283 ] Erik Krogen commented on HDFS-13898: I explored for a while how to do this without a mock

[jira] [Comment Edited] (HDFS-13898) Throw retriable exception for getBlockLocations when ObserverNameNode is in safemode

2018-09-11 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611150#comment-16611150 ] Erik Krogen edited comment on HDFS-13898 at 9/11/18 7:47 PM: - Nice find

[jira] [Commented] (HDFS-13898) Throw retriable exception for getBlockLocations when ObserverNameNode is in safemode

2018-09-11 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611150#comment-16611150 ] Erik Krogen commented on HDFS-13898: Nice find [~csun]! The change to production code LGTM. For the

[jira] [Comment Edited] (HDFS-13880) Add mechanism to allow certain RPC calls to bypass sync

2018-09-10 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609387#comment-16609387 ] Erik Krogen edited comment on HDFS-13880 at 9/10/18 3:27 PM: - [~vagarychen] -

[jira] [Commented] (HDFS-13880) Add mechanism to allow certain RPC calls to bypass sync

2018-09-10 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609387#comment-16609387 ] Erik Krogen commented on HDFS-13880: [~vagarychen] - {quote} The original thought was that,

[jira] [Comment Edited] (HDFS-13904) ContentSummary does not always respect processing limit, resulting in long lock acquisitions

2018-09-07 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607707#comment-16607707 ] Erik Krogen edited comment on HDFS-13904 at 9/7/18 9:57 PM: Thanks

[jira] [Comment Edited] (HDFS-13904) ContentSummary does not always respect processing limit, resulting in long lock acquisitions

2018-09-07 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607707#comment-16607707 ] Erik Krogen edited comment on HDFS-13904 at 9/7/18 9:55 PM: Thanks

[jira] [Commented] (HDFS-13904) ContentSummary does not always respect processing limit, resulting in long lock acquisitions

2018-09-07 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607707#comment-16607707 ] Erik Krogen commented on HDFS-13904: Thanks [~arpitagarwal] and [~kihwal] for taking a look! {quote}

[jira] [Created] (HDFS-13904) ContentSummary does not always respect processing limit, resulting in long lock acquisitions

2018-09-07 Thread Erik Krogen (JIRA)
Erik Krogen created HDFS-13904: -- Summary: ContentSummary does not always respect processing limit, resulting in long lock acquisitions Key: HDFS-13904 URL: https://issues.apache.org/jira/browse/HDFS-13904

[jira] [Commented] (HDFS-13791) Limit logging frequency of edit tail related statements

2018-09-07 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607350#comment-16607350 ] Erik Krogen commented on HDFS-13791: Just posted the relevant portions to HADOOP-15726. I'll hold off

[jira] [Commented] (HDFS-13749) Use getServiceStatus to discover observer namenodes

2018-09-07 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607294#comment-16607294 ] Erik Krogen commented on HDFS-13749: Nice, I think this looks great, [~csun]! I see one small issue

[jira] [Commented] (HDFS-13791) Limit logging frequency of edit tail related statements

2018-09-06 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606533#comment-16606533 ] Erik Krogen commented on HDFS-13791: Attached v003 fixing the broken {{FSNamesystemLock}} test,

[jira] [Updated] (HDFS-13791) Limit logging frequency of edit tail related statements

2018-09-06 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik Krogen updated HDFS-13791: --- Attachment: HDFS-13791-HDFS-12943.003.patch > Limit logging frequency of edit tail related

[jira] [Resolved] (HDFS-13872) Only some protocol methods should perform msync wait

2018-09-06 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik Krogen resolved HDFS-13872. Resolution: Duplicate Closing in favor of HDFS-13880 > Only some protocol methods should perform

[jira] [Commented] (HDFS-13880) Add mechanism to allow certain RPC calls to bypass sync

2018-09-06 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606386#comment-16606386 ] Erik Krogen commented on HDFS-13880: Hey [~vagarychen], v002 looks really great! * In the Javadoc

[jira] [Commented] (HDFS-13749) Use getServiceStatus to discover observer namenodes

2018-09-06 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606286#comment-16606286 ] Erik Krogen commented on HDFS-13749: Thanks for looking into the proxy initialization, I appreciate

[jira] [Commented] (HDFS-13791) Limit logging frequency of edit tail related statements

2018-09-06 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606248#comment-16606248 ] Erik Krogen commented on HDFS-13791: Thanks [~csun], I think your idea about "named" log statements

[jira] [Updated] (HDFS-13791) Limit logging frequency of edit tail related statements

2018-09-06 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik Krogen updated HDFS-13791: --- Attachment: HDFS-13791-HDFS-12943.002.patch > Limit logging frequency of edit tail related

<    4   5   6   7   8   9   10   11   12   13   >