[
https://issues.apache.org/jira/browse/HDDS-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16799446#comment-16799446
]
Bharat Viswanadham commented on HDDS-918:
-
Thank You [~swagle] for the contribution
[
https://issues.apache.org/jira/browse/HDDS-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16799447#comment-16799447
]
Hudson commented on HDDS-918:
-
FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #16271
[
https://issues.apache.org/jira/browse/HDDS-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16799441#comment-16799441
]
Bharat Viswanadham commented on HDDS-918:
-
In this yetus run most of the tests fail
[
https://issues.apache.org/jira/browse/HDDS-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16799308#comment-16799308
]
Hadoop QA commented on HDDS-918:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Su
[
https://issues.apache.org/jira/browse/HDDS-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16799252#comment-16799252
]
Siddharth Wagle commented on HDDS-918:
--
10 => findbugs fix.
> Expose SCMMXBean as a
[
https://issues.apache.org/jira/browse/HDDS-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16799212#comment-16799212
]
Hadoop QA commented on HDDS-918:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Su
[
https://issues.apache.org/jira/browse/HDDS-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16799153#comment-16799153
]
Siddharth Wagle commented on HDDS-918:
--
09 => Rebased patch with the latest trunk.
>
[
https://issues.apache.org/jira/browse/HDDS-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16793765#comment-16793765
]
Bharat Viswanadham commented on HDDS-918:
-
+1 LGTM.
I will commit this by tomorrow
[
https://issues.apache.org/jira/browse/HDDS-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792307#comment-16792307
]
Hadoop QA commented on HDDS-918:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Su
[
https://issues.apache.org/jira/browse/HDDS-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792266#comment-16792266
]
Siddharth Wagle commented on HDDS-918:
--
[~bharatviswa] Made the requested changes in 0
[
https://issues.apache.org/jira/browse/HDDS-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792198#comment-16792198
]
Bharat Viswanadham commented on HDDS-918:
-
+1 LGTM.
One question, I see import cha
[
https://issues.apache.org/jira/browse/HDDS-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16791079#comment-16791079
]
Hadoop QA commented on HDDS-918:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Su
[
https://issues.apache.org/jira/browse/HDDS-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16791039#comment-16791039
]
Siddharth Wagle commented on HDDS-918:
--
07 => checkstyle fixes.
> Expose SCMMXBean as
[
https://issues.apache.org/jira/browse/HDDS-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16791034#comment-16791034
]
Hadoop QA commented on HDDS-918:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Su
[
https://issues.apache.org/jira/browse/HDDS-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16790989#comment-16790989
]
Siddharth Wagle commented on HDDS-918:
--
[~elek] / [~arpitagarwal] New patch with optim
[
https://issues.apache.org/jira/browse/HDDS-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16790812#comment-16790812
]
Siddharth Wagle commented on HDDS-918:
--
[~elek] / [~arpitagarwal] ignore the last patc
[
https://issues.apache.org/jira/browse/HDDS-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16790250#comment-16790250
]
Hadoop QA commented on HDDS-918:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Su
[
https://issues.apache.org/jira/browse/HDDS-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16790248#comment-16790248
]
Hadoop QA commented on HDDS-918:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Su
[
https://issues.apache.org/jira/browse/HDDS-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16790242#comment-16790242
]
Hadoop QA commented on HDDS-918:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Su
[
https://issues.apache.org/jira/browse/HDDS-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16790216#comment-16790216
]
Siddharth Wagle commented on HDDS-918:
--
[~elek] / [~arpitagarwal] patch.05 with the pr
[
https://issues.apache.org/jira/browse/HDDS-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16790034#comment-16790034
]
Siddharth Wagle commented on HDDS-918:
--
Thanks for the review [~elek].
[~arpitagarwal
[
https://issues.apache.org/jira/browse/HDDS-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16789960#comment-16789960
]
Arpit Agarwal commented on HDDS-918:
We cannot iterate the container list while holding
[
https://issues.apache.org/jira/browse/HDDS-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16789450#comment-16789450
]
Elek, Marton commented on HDDS-918:
---
Thanks the patch [~swagle]. Short-term I have no big
[
https://issues.apache.org/jira/browse/HDDS-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16788364#comment-16788364
]
Hadoop QA commented on HDDS-918:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Su
[
https://issues.apache.org/jira/browse/HDDS-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16788326#comment-16788326
]
Siddharth Wagle commented on HDDS-918:
--
04 => rebased version.
> Expose SCMMXBean
> -
[
https://issues.apache.org/jira/browse/HDDS-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16788269#comment-16788269
]
Hadoop QA commented on HDDS-918:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Su
[
https://issues.apache.org/jira/browse/HDDS-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16788210#comment-16788210
]
Siddharth Wagle commented on HDDS-918:
--
03 => more check style fixes. [~bharatviswa] C
[
https://issues.apache.org/jira/browse/HDDS-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16787724#comment-16787724
]
Hadoop QA commented on HDDS-918:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Su
[
https://issues.apache.org/jira/browse/HDDS-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16787664#comment-16787664
]
Siddharth Wagle commented on HDDS-918:
--
02 => checkstyle fixes.
> Expose SCMMXBean
>
[
https://issues.apache.org/jira/browse/HDDS-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16787641#comment-16787641
]
Hadoop QA commented on HDDS-918:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Su
30 matches
Mail list logo