[jira] [Commented] (HDFS-13192) Change the code order in getFileEncryptionInfo to avoid unnecessary call of assignment

2018-02-28 Thread LiXin Ge (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381570#comment-16381570 ] LiXin Ge commented on HDFS-13192: - [~elgoiri] Thanks for review and commit this! > Change the code order

[jira] [Commented] (HDFS-13192) Change the code order in getFileEncryptionInfo to avoid unnecessary call of assignment

2018-02-27 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378979#comment-16378979 ] Hudson commented on HDFS-13192: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13726 (See

[jira] [Commented] (HDFS-13192) change the code order in getFileEncryptionInfo to avoid unnecessary call of assignment

2018-02-26 Thread JIRA
[ https://issues.apache.org/jira/browse/HDFS-13192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378107#comment-16378107 ] Íñigo Goiri commented on HDFS-13192: [~GeLiXin] thanks for checking the unit test, it also runs that

[jira] [Commented] (HDFS-13192) change the code order in getFileEncryptionInfo to avoid unnecessary call of assignment

2018-02-26 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378098#comment-16378098 ] genericqa commented on HDFS-13192: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13192) change the code order in getFileEncryptionInfo to avoid unnecessary call of assignment

2018-02-26 Thread LiXin Ge (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377948#comment-16377948 ] LiXin Ge commented on HDFS-13192: - Hi [~elgoiri], Thanks for your review. {quote}The log doesn't seem to

[jira] [Commented] (HDFS-13192) change the code order in getFileEncryptionInfo to avoid unnecessary call of assignment

2018-02-26 Thread JIRA
[ https://issues.apache.org/jira/browse/HDFS-13192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377220#comment-16377220 ] Íñigo Goiri commented on HDFS-13192: The new unit test was executed

[jira] [Commented] (HDFS-13192) change the code order in getFileEncryptionInfo to avoid unnecessary call of assignment

2018-02-26 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376993#comment-16376993 ] genericqa commented on HDFS-13192: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13192) change the code order in getFileEncryptionInfo to avoid unnecessary call of assignment

2018-02-26 Thread LiXin Ge (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376531#comment-16376531 ] LiXin Ge commented on HDFS-13192: - [~elgoiri] thanks for your quick review. bq. Could you point to the

[jira] [Commented] (HDFS-13192) change the code order in getFileEncryptionInfo to avoid unnecessary call of assignment

2018-02-25 Thread JIRA
[ https://issues.apache.org/jira/browse/HDFS-13192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376194#comment-16376194 ] Íñigo Goiri commented on HDFS-13192: [^HDFS-13192.001.patch] LGTM and it makes sense to avoid those

[jira] [Commented] (HDFS-13192) change the code order in getFileEncryptionInfo to avoid unnecessary call of assignment

2018-02-24 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375490#comment-16375490 ] genericqa commented on HDFS-13192: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||