[
https://issues.apache.org/jira/browse/HDFS-13204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415061#comment-16415061
]
liuhongtong commented on HDFS-13204:
Thanks [~elgoiri] [~ywskycn] [~tartarus] [~striver.wang]
[
https://issues.apache.org/jira/browse/HDFS-13204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414116#comment-16414116
]
Íñigo Goiri commented on HDFS-13204:
Thanks [~liuhongtong] for working on this and [~ywskycn] for the
[
https://issues.apache.org/jira/browse/HDFS-13204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414117#comment-16414117
]
Hudson commented on HDFS-13204:
---
FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #13876 (See
[
https://issues.apache.org/jira/browse/HDFS-13204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413350#comment-16413350
]
Wei Yan commented on HDFS-13204:
LGTM, +1
> RBF: Optimize name service safe mode icon
>
[
https://issues.apache.org/jira/browse/HDFS-13204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413312#comment-16413312
]
Íñigo Goiri commented on HDFS-13204:
[^HDFS-13204.008.patch] looks even better.
+1 waiting on
[
https://issues.apache.org/jira/browse/HDFS-13204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413310#comment-16413310
]
genericqa commented on HDFS-13204:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413289#comment-16413289
]
liuhongtong commented on HDFS-13204:
[~elgoiri] Thanks for your comments.
The last line of
[
https://issues.apache.org/jira/browse/HDFS-13204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413116#comment-16413116
]
Íñigo Goiri commented on HDFS-13204:
The import approach for the CSS in [^HDFS-13204.007.patch] looks
[
https://issues.apache.org/jira/browse/HDFS-13204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16412910#comment-16412910
]
genericqa commented on HDFS-13204:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16412894#comment-16412894
]
genericqa commented on HDFS-13204:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16412878#comment-16412878
]
liuhongtong commented on HDFS-13204:
[~elgoiri] Thx. I have modified rbf.css.
> RBF: Optimize name
[
https://issues.apache.org/jira/browse/HDFS-13204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411754#comment-16411754
]
Íñigo Goiri commented on HDFS-13204:
I would keep the reference to the old hadoop.css and rbf.css just
[
https://issues.apache.org/jira/browse/HDFS-13204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411140#comment-16411140
]
liuhongtong commented on HDFS-13204:
[~ywskycn] I have added two new css icon, which may not be very
[
https://issues.apache.org/jira/browse/HDFS-13204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408809#comment-16408809
]
Íñigo Goiri commented on HDFS-13204:
OK, let's create a rbf.css file with the new icons and reference
[
https://issues.apache.org/jira/browse/HDFS-13204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408779#comment-16408779
]
Wei Yan commented on HDFS-13204:
[~liuhongtong], thanks for the patch. [^HDFS-13204.004.patch] LGTM, and I
[
https://issues.apache.org/jira/browse/HDFS-13204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407812#comment-16407812
]
genericqa commented on HDFS-13204:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407581#comment-16407581
]
liuhongtong commented on HDFS-13204:
Waiting for new comments, I will be pleased to make this commit
[
https://issues.apache.org/jira/browse/HDFS-13204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407411#comment-16407411
]
genericqa commented on HDFS-13204:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407399#comment-16407399
]
Íñigo Goiri commented on HDFS-13204:
I think there is no need to add the hadoop.css changes related to
[
https://issues.apache.org/jira/browse/HDFS-13204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406693#comment-16406693
]
Íñigo Goiri commented on HDFS-13204:
Looks good.
Do you mind giving a rebased patch?
We moved
[
https://issues.apache.org/jira/browse/HDFS-13204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405868#comment-16405868
]
liuhongtong commented on HDFS-13204:
[~elgoiri] I have attached new screenshots.
!Subclusters.png!
[
https://issues.apache.org/jira/browse/HDFS-13204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404121#comment-16404121
]
Íñigo Goiri commented on HDFS-13204:
The proposal in [^HDFS-13204.002.patch] looks good.
We have to
[
https://issues.apache.org/jira/browse/HDFS-13204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404044#comment-16404044
]
genericqa commented on HDFS-13204:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404035#comment-16404035
]
liuhongtong commented on HDFS-13204:
What a busy week. Sorry for waiting me a long time.
I have
[
https://issues.apache.org/jira/browse/HDFS-13204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394552#comment-16394552
]
maobaolong commented on HDFS-13204:
---
[~elgoiri] Make sense very mush, and [~liuhongtong], would you like
[
https://issues.apache.org/jira/browse/HDFS-13204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393921#comment-16393921
]
Íñigo Goiri commented on HDFS-13204:
I thought the agreement was to create a new set of icons in the
[
https://issues.apache.org/jira/browse/HDFS-13204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393823#comment-16393823
]
maobaolong commented on HDFS-13204:
---
[~elgoiri] Maybe we can specify some icon now, and i think we can
[
https://issues.apache.org/jira/browse/HDFS-13204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387249#comment-16387249
]
maobaolong commented on HDFS-13204:
---
[~elgoiri] Okay, may be we can have more choice about
[
https://issues.apache.org/jira/browse/HDFS-13204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386370#comment-16386370
]
Íñigo Goiri commented on HDFS-13204:
bq. Yeah i mean to add federationdfshealth-router-* to
[
https://issues.apache.org/jira/browse/HDFS-13204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385627#comment-16385627
]
maobaolong commented on HDFS-13204:
---
[~liuhongtong] [~elgoiri] Yeah i mean to add
[
https://issues.apache.org/jira/browse/HDFS-13204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385602#comment-16385602
]
Íñigo Goiri commented on HDFS-13204:
bq. Íñigo Goiri i guess maobaolong means rbf should own private
[
https://issues.apache.org/jira/browse/HDFS-13204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385537#comment-16385537
]
liuhongtong commented on HDFS-13204:
[~elgoiri] i guess [~maobaolong] means rbf should own private css
[
https://issues.apache.org/jira/browse/HDFS-13204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383076#comment-16383076
]
Íñigo Goiri commented on HDFS-13204:
What would {{federationdfshealth-router-safemode}} be?
> RBF:
[
https://issues.apache.org/jira/browse/HDFS-13204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383039#comment-16383039
]
maobaolong commented on HDFS-13204:
---
[~elgoiri] Do you think the following make sense?
- Routers
-
[
https://issues.apache.org/jira/browse/HDFS-13204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382371#comment-16382371
]
Íñigo Goiri commented on HDFS-13204:
[~raviprak], can you provide some feedback?
My proposal currently
[
https://issues.apache.org/jira/browse/HDFS-13204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381403#comment-16381403
]
wangzhiyuan commented on HDFS-13204:
Good catch, state icons should be stay the same, furthermore,
[
https://issues.apache.org/jira/browse/HDFS-13204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381385#comment-16381385
]
maobaolong commented on HDFS-13204:
---
I think the icon can be replace to others, but it is another thing
[
https://issues.apache.org/jira/browse/HDFS-13204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381057#comment-16381057
]
Íñigo Goiri commented on HDFS-13204:
A nameservice would also have those 4 states:
* Active, when one
[
https://issues.apache.org/jira/browse/HDFS-13204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380851#comment-16380851
]
Wei Yan commented on HDFS-13204:
The "Safe Mode" icon under tab "Subclusters" --> "Nameservice
[
https://issues.apache.org/jira/browse/HDFS-13204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380685#comment-16380685
]
Íñigo Goiri commented on HDFS-13204:
Thanks [~liuhongtong] for opening this.
I think it makes sense to
[
https://issues.apache.org/jira/browse/HDFS-13204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380162#comment-16380162
]
genericqa commented on HDFS-13204:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380156#comment-16380156
]
tartarus commented on HDFS-13204:
-
LGTM
> RBF: optimize name service safe mode icon
>
42 matches
Mail list logo
