[
https://issues.apache.org/jira/browse/HDFS-13750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586206#comment-16586206
]
Takanobu Asanuma commented on HDFS-13750:
-
Thanks a lot for your help and the commit, [~linyiqun]
[
https://issues.apache.org/jira/browse/HDFS-13750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586082#comment-16586082
]
Hudson commented on HDFS-13750:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14803 (See
[
https://issues.apache.org/jira/browse/HDFS-13750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586048#comment-16586048
]
Yiqun Lin commented on HDFS-13750:
--
LGTM, +1. Commit this shortly as [~elgoiri] also gives his +1.
>
[
https://issues.apache.org/jira/browse/HDFS-13750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586010#comment-16586010
]
genericqa commented on HDFS-13750:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585919#comment-16585919
]
Yiqun Lin commented on HDFS-13750:
--
Attach the same patch to re-trigger Jenkins.
> RBF: Router ID in
[
https://issues.apache.org/jira/browse/HDFS-13750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585731#comment-16585731
]
Takanobu Asanuma commented on HDFS-13750:
-
Thanks for the reviews, [~linyiqun] and [~elgoiri]!
[
https://issues.apache.org/jira/browse/HDFS-13750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16583501#comment-16583501
]
Íñigo Goiri commented on HDFS-13750:
Other than [~linyiqun]'s comments, +1 from my side.
> RBF:
[
https://issues.apache.org/jira/browse/HDFS-13750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16582155#comment-16582155
]
Yiqun Lin commented on HDFS-13750:
--
Thanks [~tasanuma0829] for fixing this. Two comments from me:
*
[
https://issues.apache.org/jira/browse/HDFS-13750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16579284#comment-16579284
]
genericqa commented on HDFS-13750:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16579240#comment-16579240
]
Takanobu Asanuma commented on HDFS-13750:
-
Thanks [~elgoiri] for your review. Uploaded the 4th
[
https://issues.apache.org/jira/browse/HDFS-13750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576326#comment-16576326
]
Íñigo Goiri commented on HDFS-13750:
Thanks [~tasanuma0829] for [^HDFS-13750.3.patch].
A minor nit:
[
https://issues.apache.org/jira/browse/HDFS-13750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16551512#comment-16551512
]
genericqa commented on HDFS-13750:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16551493#comment-16551493
]
Takanobu Asanuma commented on HDFS-13750:
-
The unit test in the 2nd patch is wrong. Uploaded the
[
https://issues.apache.org/jira/browse/HDFS-13750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16551465#comment-16551465
]
genericqa commented on HDFS-13750:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16551425#comment-16551425
]
Takanobu Asanuma commented on HDFS-13750:
-
Thanks for the review, [~elgoiri]! Uploaded the 2nd
[
https://issues.apache.org/jira/browse/HDFS-13750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16551049#comment-16551049
]
Íñigo Goiri commented on HDFS-13750:
Thanks [~tasanuma0829], I've noticed the bug lately.
I'm not
[
https://issues.apache.org/jira/browse/HDFS-13750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16550598#comment-16550598
]
genericqa commented on HDFS-13750:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16550497#comment-16550497
]
Takanobu Asanuma commented on HDFS-13750:
-
Uploaded the 1st patch.
> RBF: Router ID in
18 matches
Mail list logo