[jira] [Commented] (HDFS-14050) Use parameterized logging construct in NamenodeFsck class

2018-11-20 Thread Kitti Nanasi (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693002#comment-16693002 ] Kitti Nanasi commented on HDFS-14050: - Thanks [~hgadre] for the new patch! +1 (non binding) pending

[jira] [Commented] (HDFS-14050) Use parameterized logging construct in NamenodeFsck class

2018-11-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688981#comment-16688981 ] Hadoop QA commented on HDFS-14050: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14050) Use parameterized logging construct in NamenodeFsck class

2018-11-09 Thread Hrishikesh Gadre (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681844#comment-16681844 ] Hrishikesh Gadre commented on HDFS-14050: - ah...i didn't know that [~knanasi] ! I verified that

[jira] [Commented] (HDFS-14050) Use parameterized logging construct in NamenodeFsck class

2018-11-09 Thread Kitti Nanasi (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681122#comment-16681122 ] Kitti Nanasi commented on HDFS-14050: - I think slf4j 1.7.x (in trunk it is 1.7.25) handles throwables

[jira] [Commented] (HDFS-14050) Use parameterized logging construct in NamenodeFsck class

2018-11-08 Thread Hrishikesh Gadre (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680550#comment-16680550 ] Hrishikesh Gadre commented on HDFS-14050: - [~xiaochen] thanks for the review. {quote}In

[jira] [Commented] (HDFS-14050) Use parameterized logging construct in NamenodeFsck class

2018-11-08 Thread Xiao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680425#comment-16680425 ] Xiao Chen commented on HDFS-14050: -- Thanks [~hgadre] for the patch here. +1 pending: - In NamenodeFsck

[jira] [Commented] (HDFS-14050) Use parameterized logging construct in NamenodeFsck class

2018-11-08 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680474#comment-16680474 ] Hadoop QA commented on HDFS-14050: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14050) Use parameterized logging construct in NamenodeFsck class

2018-11-08 Thread Hrishikesh Gadre (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680218#comment-16680218 ] Hrishikesh Gadre commented on HDFS-14050: - [~knanasi] thanks a lot for the review :) I have

[jira] [Commented] (HDFS-14050) Use parameterized logging construct in NamenodeFsck class

2018-11-07 Thread Kitti Nanasi (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678386#comment-16678386 ] Kitti Nanasi commented on HDFS-14050: - Thanks [~hgadre] for working on this! It looks good, I only

[jira] [Commented] (HDFS-14050) Use parameterized logging construct in NamenodeFsck class

2018-11-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677467#comment-16677467 ] Hadoop QA commented on HDFS-14050: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14050) Use parameterized logging construct in NamenodeFsck class

2018-11-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677389#comment-16677389 ] Hadoop QA commented on HDFS-14050: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||