[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17414003#comment-17414003
]
Max Xie commented on HDFS-14353:
-
branch-3.2.2 doesn't include this Jira +1. cc [~ayushtkn]
>
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242857#comment-17242857
]
Takanobu Asanuma commented on HDFS-14353:
-
Seems 3.3.0 doesn't include this jira. Fixed Fix
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186763#comment-17186763
]
Andras Bokor commented on HDFS-14353:
-
For git greppers: The commit misses the JIRA id so you can
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098437#comment-17098437
]
Ayush Saxena commented on HDFS-14353:
-
Committed to trunk, branch-3.3,branch-3.2 and branch-3.1
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17096345#comment-17096345
]
Ayush Saxena commented on HDFS-14353:
-
Thanx [~elgoiri] and [~touchida] for fixing this.
+1 for the
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095760#comment-17095760
]
Íñigo Goiri commented on HDFS-14353:
[~ayushtkn], as you raised the issue that triggered the revert,
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095315#comment-17095315
]
Toshihiko Uchida commented on HDFS-14353:
-
[~elgoiri] Thanks for your review and support!
FYI: We
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17094760#comment-17094760
]
Íñigo Goiri commented on HDFS-14353:
Let's file a JIRA for TestReconstructStripedFile (and make that
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092527#comment-17092527
]
Toshihiko Uchida commented on HDFS-14353:
-
Some of the failed tests are already reported to fail
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092524#comment-17092524
]
Toshihiko Uchida commented on HDFS-14353:
-
The stack traces of the failed tests in Build #29187.
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092522#comment-17092522
]
Toshihiko Uchida commented on HDFS-14353:
-
The stack traces of the failed tests in Build #29186.
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092521#comment-17092521
]
Toshihiko Uchida commented on HDFS-14353:
-
I tested exactly the same patch twice (Build #29186
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090929#comment-17090929
]
Hadoop QA commented on HDFS-14353:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090891#comment-17090891
]
Hadoop QA commented on HDFS-14353:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090748#comment-17090748
]
Toshihiko Uchida commented on HDFS-14353:
-
[~ayushtkn] Thanks!
> what I remember the
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090556#comment-17090556
]
Ayush Saxena commented on HDFS-14353:
-
[~touchida] I have added you as contributors, you may be able
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090513#comment-17090513
]
Toshihiko Uchida commented on HDFS-14353:
-
[~elgoiri]
I wonder if you could grant me the role to
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089754#comment-17089754
]
Íñigo Goiri commented on HDFS-14353:
[~touchida] good catch.
Can anybody update the patch?
> Erasure
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089524#comment-17089524
]
Toshihiko Uchida commented on HDFS-14353:
-
Looks curDn.getXceiverCount() > 1 should be negated in
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847767#comment-16847767
]
Hudson commented on HDFS-14353:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #16601 (See
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847740#comment-16847740
]
Íñigo Goiri commented on HDFS-14353:
[~maobaolong] can you take a look?
It looks like the new wait
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847616#comment-16847616
]
Ayush Saxena commented on HDFS-14353:
-
The test changed in the patch
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844421#comment-16844421
]
Hudson commented on HDFS-14353:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #16576 (See
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844412#comment-16844412
]
Íñigo Goiri commented on HDFS-14353:
The failed unit tests are unrelated.
+1 on
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16842846#comment-16842846
]
Hadoop QA commented on HDFS-14353:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16842801#comment-16842801
]
maobaolong commented on HDFS-14353:
---
[~elgoiri] Thanking for remind me, i have corrected it. PTAL.
>
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841787#comment-16841787
]
Íñigo Goiri commented on HDFS-14353:
Do you mind taking care of the checkstyle?
> Erasure Coding:
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840969#comment-16840969
]
Hadoop QA commented on HDFS-14353:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840906#comment-16840906
]
maobaolong commented on HDFS-14353:
---
[~elgoiri] Thank you for the code you given, i use it to replace
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16839642#comment-16839642
]
Íñigo Goiri commented on HDFS-14353:
As this is trunk, we can use lambdas:
{code}
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16839556#comment-16839556
]
Hadoop QA commented on HDFS-14353:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16839371#comment-16839371
]
maobaolong commented on HDFS-14353:
---
[~elgoiri] Thank you for your advice, it's really a good idea, i
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838787#comment-16838787
]
Íñigo Goiri commented on HDFS-14353:
[~maobaolong] can we use GenericTestUtils#waitFor() in the test
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16833312#comment-16833312
]
Hadoop QA commented on HDFS-14353:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16833254#comment-16833254
]
maobaolong commented on HDFS-14353:
---
[~elgoiri] Thank you for your advice, i've put a comment to the
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830520#comment-16830520
]
Íñigo Goiri commented on HDFS-14353:
Can we tyr somebody else involved in EC?
Otherwise, let's just
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829882#comment-16829882
]
maobaolong commented on HDFS-14353:
---
[~elgoiri] I guess he will not reply you these day, because i find
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829816#comment-16829816
]
maobaolong commented on HDFS-14353:
---
[~elgoiri] This issue is caused by HDFS-12482. [~eddyxu] Please
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829435#comment-16829435
]
Íñigo Goiri commented on HDFS-14353:
[~Lei Xu], can you take a look?
Any proposal for the comment?
>
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827786#comment-16827786
]
maobaolong commented on HDFS-14353:
---
[~elgoiri] Thank you to point this. but, i am sorry to tell you
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825702#comment-16825702
]
Hadoop QA commented on HDFS-14353:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825657#comment-16825657
]
Íñigo Goiri commented on HDFS-14353:
It would be good to give a high level reason on why it has to be
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825640#comment-16825640
]
maobaolong commented on HDFS-14353:
---
[~elgoiri] Thank you for your advise. The following is new diff
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16824315#comment-16824315
]
Íñigo Goiri commented on HDFS-14353:
BTW, the following:
{code}
int xmitsSubmitted = Math.max((int)
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16824311#comment-16824311
]
Íñigo Goiri commented on HDFS-14353:
Thanks [~maobaolong] for the update.
Instead of the while loop
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16824093#comment-16824093
]
Hadoop QA commented on HDFS-14353:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823673#comment-16823673
]
Hadoop QA commented on HDFS-14353:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823615#comment-16823615
]
maobaolong commented on HDFS-14353:
---
[~elgoiri] Of curse, thank you for remind me, i upload a new
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823205#comment-16823205
]
Íñigo Goiri commented on HDFS-14353:
Do you mind fixing the checkstyle warnings?
> Erasure Coding:
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16822599#comment-16822599
]
maobaolong commented on HDFS-14353:
---
[~elgoiri] [~knanasi] These failed tests relates to NameNode, but
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16822331#comment-16822331
]
Hadoop QA commented on HDFS-14353:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16822293#comment-16822293
]
maobaolong commented on HDFS-14353:
---
[~elgoiri] [~knanasi] Thank you for watching my patch. I see the
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817679#comment-16817679
]
Kitti Nanasi commented on HDFS-14353:
-
Thanks [~maobaolong] for reporting this issue and providing a
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817173#comment-16817173
]
Hadoop QA commented on HDFS-14353:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817098#comment-16817098
]
Íñigo Goiri commented on HDFS-14353:
Can you name the patch as ".patch"?
Can we also add unit tests?
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816966#comment-16816966
]
maobaolong commented on HDFS-14353:
---
[~elgoiri] Would you like to help me to review this patch? i think
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794038#comment-16794038
]
maobaolong commented on HDFS-14353:
---
[~ayushtkn]Please take a look at this issue, maybe it can lead
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790129#comment-16790129
]
maobaolong commented on HDFS-14353:
---
[~linyiqun] Would you like to take a look at this patch?. After we
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16789889#comment-16789889
]
Hadoop QA commented on HDFS-14353:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16789445#comment-16789445
]
maobaolong commented on HDFS-14353:
---
[~eddyxu] Please take a look. I think the
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16789407#comment-16789407
]
maobaolong commented on HDFS-14353:
---
I think the problem caused by the following logic:
increase:
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16789208#comment-16789208
]
maobaolong commented on HDFS-14353:
---
The suspect code i think is around the class ErasureCodingWorker
[
https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16789194#comment-16789194
]
maobaolong commented on HDFS-14353:
---
!screenshot-1.png!
> Erasure Coding: metrics xmitsInProgress
63 matches
Mail list logo
