[jira] [Commented] (HDFS-14406) Add per user RPC Processing time

2019-04-22 Thread Chao Sun (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16823227#comment-16823227 ] Chao Sun commented on HDFS-14406: - [~xuel1]: I'm still in favor of reusing the existing {

[jira] [Commented] (HDFS-14406) Add per user RPC Processing time

2019-04-19 Thread Xue Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822267#comment-16822267 ] Xue Liu commented on HDFS-14406: [~xkrogen] Makes sense to me, I will go back to per user

[jira] [Commented] (HDFS-14406) Add per user RPC Processing time

2019-04-19 Thread Chao Sun (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822258#comment-16822258 ] Chao Sun commented on HDFS-14406: - Thanks [~xuel1] for the update. Instead of adding a ne

[jira] [Commented] (HDFS-14406) Add per user RPC Processing time

2019-04-19 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822257#comment-16822257 ] Erik Krogen commented on HDFS-14406: I don't have time to take a full look at the pat

[jira] [Commented] (HDFS-14406) Add per user RPC Processing time

2019-04-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822253#comment-16822253 ] Hadoop QA commented on HDFS-14406: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-14406) Add per user RPC Processing time

2019-04-19 Thread Xue Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822235#comment-16822235 ] Xue Liu commented on HDFS-14406:   Hi guys thanks for the comments! Reflected on [~xkrog

[jira] [Commented] (HDFS-14406) Add per user RPC Processing time

2019-04-18 Thread Chao Sun (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16821319#comment-16821319 ] Chao Sun commented on HDFS-14406: - Thanks [~xuel1]. A few comments beside the above menti

[jira] [Commented] (HDFS-14406) Add per user RPC Processing time

2019-04-17 Thread Yiqun Lin (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16820646#comment-16820646 ] Yiqun Lin commented on HDFS-14406: -- Almost looks great now, [~xuel1]. {quote}RpcUserMetr

[jira] [Commented] (HDFS-14406) Add per user RPC Processing time

2019-04-17 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16820632#comment-16820632 ] Hadoop QA commented on HDFS-14406: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-14406) Add per user RPC Processing time

2019-04-17 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16820537#comment-16820537 ] Erik Krogen commented on HDFS-14406: Thanks for the ping, [~elgoiri]. I do have some

[jira] [Commented] (HDFS-14406) Add per user RPC Processing time

2019-04-17 Thread JIRA
[ https://issues.apache.org/jira/browse/HDFS-14406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16820522#comment-16820522 ] Íñigo Goiri commented on HDFS-14406: [^HDFS-14406.004.patch] LGTM. +1 I'll give a cou

[jira] [Commented] (HDFS-14406) Add per user RPC Processing time

2019-04-15 Thread Xue Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16818463#comment-16818463 ] Xue Liu commented on HDFS-14406: [~linyiqun] Thanks for the comment! Checkstyles and othe

[jira] [Commented] (HDFS-14406) Add per user RPC Processing time

2019-04-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16818446#comment-16818446 ] Hadoop QA commented on HDFS-14406: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HDFS-14406) Add per user RPC Processing time

2019-04-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16818355#comment-16818355 ] Hadoop QA commented on HDFS-14406: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-14406) Add per user RPC Processing time

2019-04-11 Thread Yiqun Lin (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16815918#comment-16815918 ] Yiqun Lin commented on HDFS-14406: -- This idea makes sense to me, although here the proce

[jira] [Commented] (HDFS-14406) Add per user RPC Processing time

2019-04-11 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16815868#comment-16815868 ] Hadoop QA commented on HDFS-14406: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-14406) Add per user RPC Processing time

2019-04-11 Thread Xue Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16815829#comment-16815829 ] Xue Liu commented on HDFS-14406: Fixed some checkstyles. Some is left unfixed, such as: {

[jira] [Commented] (HDFS-14406) Add per user RPC Processing time

2019-04-10 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814977#comment-16814977 ] Hadoop QA commented on HDFS-14406: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-14406) Add per user RPC Processing time

2019-04-10 Thread Xue Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814938#comment-16814938 ] Xue Liu commented on HDFS-14406: Thanks for the comments and suggestions! New patch avai

[jira] [Commented] (HDFS-14406) Add per user RPC Processing time

2019-04-08 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16812511#comment-16812511 ] Erik Krogen commented on HDFS-14406: I'd like to echo [~daryn]'s sentiment that this

[jira] [Commented] (HDFS-14406) Add per user RPC Processing time

2019-04-08 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16812451#comment-16812451 ] Daryn Sharp commented on HDFS-14406: I'd also prefer this be optional.  The overhead

[jira] [Commented] (HDFS-14406) Add per user RPC Processing time

2019-04-05 Thread JIRA
[ https://issues.apache.org/jira/browse/HDFS-14406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16811457#comment-16811457 ] Íñigo Goiri commented on HDFS-14406: A +1 from Yetus, impressive. Let's fix the check

[jira] [Commented] (HDFS-14406) Add per user RPC Processing time

2019-04-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16811434#comment-16811434 ] Hadoop QA commented on HDFS-14406: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HDFS-14406) Add per user RPC Processing time

2019-04-05 Thread Xue Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16811341#comment-16811341 ] Xue Liu commented on HDFS-14406: Patch available. Just want to say being a new contributo