[
https://issues.apache.org/jira/browse/HDFS-15355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115289#comment-17115289
]
Hudson commented on HDFS-15355:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #18293 (See
[
https://issues.apache.org/jira/browse/HDFS-15355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115283#comment-17115283
]
Ayush Saxena commented on HDFS-15355:
-
Committed to trunk.
Thanx [~hadoop_yangyun] for the
[
https://issues.apache.org/jira/browse/HDFS-15355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115282#comment-17115282
]
Ayush Saxena commented on HDFS-15355:
-
v013 LGTM +1
> Make the default block storage policy ID
[
https://issues.apache.org/jira/browse/HDFS-15355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115156#comment-17115156
]
Hadoop QA commented on HDFS-15355:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115078#comment-17115078
]
Yang Yun commented on HDFS-15355:
-
Thanks [~ayushtkn] for the review.
Updated to HDFS-15355.013.patch to
[
https://issues.apache.org/jira/browse/HDFS-15355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115068#comment-17115068
]
Ayush Saxena commented on HDFS-15355:
-
Thanx [~hadoop_yangyun] for the patch, Minor nit :
[
https://issues.apache.org/jira/browse/HDFS-15355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114885#comment-17114885
]
Íñigo Goiri commented on HDFS-15355:
There are a few tests consistently failing (e.g.,
[
https://issues.apache.org/jira/browse/HDFS-15355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114500#comment-17114500
]
Hadoop QA commented on HDFS-15355:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114436#comment-17114436
]
Yang Yun commented on HDFS-15355:
-
Thanks [~elgoiri] for the review.
Updated to HDFS-15355.012.patch,
[
https://issues.apache.org/jira/browse/HDFS-15355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114224#comment-17114224
]
Íñigo Goiri commented on HDFS-15355:
In the md, the first change is not needed as it is code related
[
https://issues.apache.org/jira/browse/HDFS-15355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17113774#comment-17113774
]
Hadoop QA commented on HDFS-15355:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17113699#comment-17113699
]
Yang Yun commented on HDFS-15355:
-
Thanks [~elgoiri] for the reivew.
Updated to HDFS-15355.011.patch
[
https://issues.apache.org/jira/browse/HDFS-15355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17113398#comment-17113398
]
Íñigo Goiri commented on HDFS-15355:
Can we update ArchivalStorage.md and related too?
> Make the
[
https://issues.apache.org/jira/browse/HDFS-15355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17111763#comment-17111763
]
Yang Yun commented on HDFS-15355:
-
Thanks [~elgoiri] for the review.
Updated to HDFS-15355.010.patch
[
https://issues.apache.org/jira/browse/HDFS-15355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17111391#comment-17111391
]
Hadoop QA commented on HDFS-15355:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17111252#comment-17111252
]
Íñigo Goiri commented on HDFS-15355:
Thanks [~hadoop_yangyun] for the update, this looks way more
[
https://issues.apache.org/jira/browse/HDFS-15355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1796#comment-1796
]
Yang Yun commented on HDFS-15355:
-
Updated to HDFS-15355.009.patch for unit test issues.
> Make the
[
https://issues.apache.org/jira/browse/HDFS-15355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110850#comment-17110850
]
Hadoop QA commented on HDFS-15355:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110795#comment-17110795
]
Yang Yun commented on HDFS-15355:
-
Thanks [~elgoiri] and [~ayushtkn] for the review.
Updated to
[
https://issues.apache.org/jira/browse/HDFS-15355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110434#comment-17110434
]
Íñigo Goiri commented on HDFS-15355:
[~ayushtkn], I think we cannot just remove the old values; we
[
https://issues.apache.org/jira/browse/HDFS-15355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17109844#comment-17109844
]
Ayush Saxena commented on HDFS-15355:
-
Bunch of test failures seems related.
> Make the default
[
https://issues.apache.org/jira/browse/HDFS-15355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17109543#comment-17109543
]
Hadoop QA commented on HDFS-15355:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17109476#comment-17109476
]
Yang Yun commented on HDFS-15355:
-
[~ayushtkn], I'm sorry, I uploaded a wrong file. HDFS-15355.007.patch
[
https://issues.apache.org/jira/browse/HDFS-15355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17109456#comment-17109456
]
Hadoop QA commented on HDFS-15355:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17109454#comment-17109454
]
Ayush Saxena commented on HDFS-15355:
-
[~hadoop_yangyun] seems you haven't uploaded the v007 patch?
[
https://issues.apache.org/jira/browse/HDFS-15355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17109403#comment-17109403
]
Yang Yun commented on HDFS-15355:
-
Update to HDFS-15355.007.patch for checkstyle issues.
Current truck
[
https://issues.apache.org/jira/browse/HDFS-15355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17109385#comment-17109385
]
Ayush Saxena commented on HDFS-15355:
-
Can you give a check to the test failures and checkstyle
[
https://issues.apache.org/jira/browse/HDFS-15355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17109141#comment-17109141
]
Hadoop QA commented on HDFS-15355:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17109087#comment-17109087
]
Yang Yun commented on HDFS-15355:
-
Thanks [~elgoiri] and [~ayushtkn] for the suggestion.
Updated to
[
https://issues.apache.org/jira/browse/HDFS-15355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108997#comment-17108997
]
Ayush Saxena commented on HDFS-15355:
-
I guess doing that would require changes to multiple places.
[
https://issues.apache.org/jira/browse/HDFS-15355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108645#comment-17108645
]
Íñigo Goiri commented on HDFS-15355:
Kind of sad that HdfsConstants doesn't have these values as an
[
https://issues.apache.org/jira/browse/HDFS-15355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108534#comment-17108534
]
Ayush Saxena commented on HDFS-15355:
-
Thanx [~hadoop_yangyun] for the patch. Should be all if the
[
https://issues.apache.org/jira/browse/HDFS-15355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108272#comment-17108272
]
Hadoop QA commented on HDFS-15355:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108268#comment-17108268
]
Yang Yun commented on HDFS-15355:
-
Thanks [~ayushtkn] for the review.
Yes, it will never be true with
[
https://issues.apache.org/jira/browse/HDFS-15355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108190#comment-17108190
]
Ayush Saxena commented on HDFS-15355:
-
when this will be true?
{code:java}
+ if (defaultPolicy
[
https://issues.apache.org/jira/browse/HDFS-15355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108139#comment-17108139
]
Yang Yun commented on HDFS-15355:
-
Thanks [~ayushtkn] for the review.
Update to HDFS-15355.004.patch
[
https://issues.apache.org/jira/browse/HDFS-15355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108080#comment-17108080
]
Ayush Saxena commented on HDFS-15355:
-
Thanx [~hadoop_yangyun] for the patch.
{code:java}+ public
[
https://issues.apache.org/jira/browse/HDFS-15355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107276#comment-17107276
]
Hadoop QA commented on HDFS-15355:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107172#comment-17107172
]
Yang Yun commented on HDFS-15355:
-
Thanks [~ayushtkn] for the review.
Update to HDFS-15355.003.patch
[
https://issues.apache.org/jira/browse/HDFS-15355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107137#comment-17107137
]
Hadoop QA commented on HDFS-15355:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107113#comment-17107113
]
Ayush Saxena commented on HDFS-15355:
-
Would be better if we allow the policy name in the
[
https://issues.apache.org/jira/browse/HDFS-15355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106936#comment-17106936
]
Hadoop QA commented on HDFS-15355:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106851#comment-17106851
]
Yang Yun commented on HDFS-15355:
-
Thanks [~ayushtkn] for the review.
Yes, set the sotrage policy on
[
https://issues.apache.org/jira/browse/HDFS-15355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106842#comment-17106842
]
Ayush Saxena commented on HDFS-15355:
-
We can set the storage policy on root, and it will behave same
44 matches
Mail list logo
