[jira] [Commented] (HDFS-3920) libwebdhfs code cleanup: string processing and using strerror consistently to handle all errors

2012-10-29 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486027#comment-13486027 ] Hudson commented on HDFS-3920: -- Integrated in Hadoop-Mapreduce-trunk #1240 (See [https://buil

[jira] [Commented] (HDFS-3920) libwebdhfs code cleanup: string processing and using strerror consistently to handle all errors

2012-10-29 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485999#comment-13485999 ] Hudson commented on HDFS-3920: -- Integrated in Hadoop-Hdfs-trunk #1210 (See [https://builds.ap

[jira] [Commented] (HDFS-3920) libwebdhfs code cleanup: string processing and using strerror consistently to handle all errors

2012-10-29 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485950#comment-13485950 ] Hudson commented on HDFS-3920: -- Integrated in Hadoop-Yarn-trunk #20 (See [https://builds.apac

[jira] [Commented] (HDFS-3920) libwebdhfs code cleanup: string processing and using strerror consistently to handle all errors

2012-10-28 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485849#comment-13485849 ] Hudson commented on HDFS-3920: -- Integrated in Hadoop-trunk-Commit #2938 (See [https://builds.

[jira] [Commented] (HDFS-3920) libwebdhfs code cleanup: string processing and using strerror consistently to handle all errors

2012-10-28 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485848#comment-13485848 ] Hadoop QA commented on HDFS-3920: - {color:red}-1 overall{color}. Here are the results of t

[jira] [Commented] (HDFS-3920) libwebdhfs code cleanup: string processing and using strerror consistently to handle all errors

2012-10-28 Thread Colin Patrick McCabe (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485804#comment-13485804 ] Colin Patrick McCabe commented on HDFS-3920: It looks good to me. Thanks for w

[jira] [Commented] (HDFS-3920) libwebdhfs code cleanup: string processing and using strerror consistently to handle all errors

2012-10-28 Thread Suresh Srinivas (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485694#comment-13485694 ] Suresh Srinivas commented on HDFS-3920: --- [~cmccabe]Thanks you for the review so far.

[jira] [Commented] (HDFS-3920) libwebdhfs code cleanup: string processing and using strerror consistently to handle all errors

2012-10-16 Thread Colin Patrick McCabe (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13477167#comment-13477167 ] Colin Patrick McCabe commented on HDFS-3920: Oh, also, you have a bunch of warn

[jira] [Commented] (HDFS-3920) libwebdhfs code cleanup: string processing and using strerror consistently to handle all errors

2012-10-16 Thread Colin Patrick McCabe (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13477160#comment-13477160 ] Colin Patrick McCabe commented on HDFS-3920: Thanks, Jing. This is a big impro

[jira] [Commented] (HDFS-3920) libwebdhfs code cleanup: string processing and using strerror consistently to handle all errors

2012-10-04 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469968#comment-13469968 ] Jing Zhao commented on HDFS-3920: - Colin and Andy, thank you so much for the review and com

[jira] [Commented] (HDFS-3920) libwebdhfs code cleanup: string processing and using strerror consistently to handle all errors

2012-10-04 Thread Colin Patrick McCabe (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469944#comment-13469944 ] Colin Patrick McCabe commented on HDFS-3920: Oh yeah, I was going to mention, b

[jira] [Commented] (HDFS-3920) libwebdhfs code cleanup: string processing and using strerror consistently to handle all errors

2012-10-04 Thread Andy Isaacson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469928#comment-13469928 ] Andy Isaacson commented on HDFS-3920: - Overall, looking good. A few more improvements:

[jira] [Commented] (HDFS-3920) libwebdhfs code cleanup: string processing and using strerror consistently to handle all errors

2012-10-04 Thread Colin Patrick McCabe (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469578#comment-13469578 ] Colin Patrick McCabe commented on HDFS-3920: This patch didn't quite apply for

[jira] [Commented] (HDFS-3920) libwebdhfs code cleanup: string processing and using strerror consistently to handle all errors

2012-09-18 Thread Colin Patrick McCabe (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458275#comment-13458275 ] Colin Patrick McCabe commented on HDFS-3920: Looks reasonable overall. I guess

[jira] [Commented] (HDFS-3920) libwebdhfs code cleanup: string processing and using strerror consistently to handle all errors

2012-09-18 Thread Andy Isaacson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458150#comment-13458150 ] Andy Isaacson commented on HDFS-3920: - When uploading a new patch, increase the sequenc

[jira] [Commented] (HDFS-3920) libwebdhfs code cleanup: string processing and using strerror consistently to handle all errors

2012-09-17 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457450#comment-13457450 ] Jing Zhao commented on HDFS-3920: - Ah, I see. That's my bad. I included another patch from

[jira] [Commented] (HDFS-3920) libwebdhfs code cleanup: string processing and using strerror consistently to handle all errors

2012-09-17 Thread Andy Isaacson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457446#comment-13457446 ] Andy Isaacson commented on HDFS-3920: - Hmmm, now I'm confused. I saw this hunk in the

[jira] [Commented] (HDFS-3920) libwebdhfs code cleanup: string processing and using strerror consistently to handle all errors

2012-09-17 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457425#comment-13457425 ] Jing Zhao commented on HDFS-3920: - Thanks for the comments Andy! I will try to push to gith

[jira] [Commented] (HDFS-3920) libwebdhfs code cleanup: string processing and using strerror consistently to handle all errors

2012-09-17 Thread Andy Isaacson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457400#comment-13457400 ] Andy Isaacson commented on HDFS-3920: - Since you're using git, and this change will con

[jira] [Commented] (HDFS-3920) libwebdhfs code cleanup: string processing and using strerror consistently to handle all errors

2012-09-17 Thread Andy Isaacson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457392#comment-13457392 ] Andy Isaacson commented on HDFS-3920: - The -001.patch reverts several recent changes, c

[jira] [Commented] (HDFS-3920) libwebdhfs code cleanup: string processing and using strerror consistently to handle all errors

2012-09-17 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457308#comment-13457308 ] Jing Zhao commented on HDFS-3920: - By the way, have not addressed Colin's comment in strerr

[jira] [Commented] (HDFS-3920) libwebdhfs code cleanup: string processing and using strerror consistently to handle all errors

2012-09-11 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453514#comment-13453514 ] Jing Zhao commented on HDFS-3920: - Thanks for the comments Colin! I will pay attention to t

[jira] [Commented] (HDFS-3920) libwebdhfs code cleanup: string processing and using strerror consistently to handle all errors

2012-09-11 Thread Colin Patrick McCabe (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453503#comment-13453503 ] Colin Patrick McCabe commented on HDFS-3920: note: strerror itself isn't thread