[
https://issues.apache.org/jira/browse/HDFS-5121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13758117#comment-13758117
]
Colin Patrick McCabe commented on HDFS-5121:
Ah, looks like I committed the wro
[
https://issues.apache.org/jira/browse/HDFS-5121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13757496#comment-13757496
]
Andrew Wang commented on HDFS-5121:
---
Hey Colin, could you take a look at the v3 patch I p
[
https://issues.apache.org/jira/browse/HDFS-5121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13757024#comment-13757024
]
Colin Patrick McCabe commented on HDFS-5121:
bq. Missing @throws annotations on
[
https://issues.apache.org/jira/browse/HDFS-5121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13755202#comment-13755202
]
Aaron T. Myers commented on HDFS-5121:
--
Patch looks pretty good to me. A few small com
[
https://issues.apache.org/jira/browse/HDFS-5121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13749200#comment-13749200
]
Colin Patrick McCabe commented on HDFS-5121:
* added Nonnull annotation to Cach
[
https://issues.apache.org/jira/browse/HDFS-5121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13749164#comment-13749164
]
Andrew Wang commented on HDFS-5121:
---
Neato patch, some comments:
Nitty things:
- Batched
[
https://issues.apache.org/jira/browse/HDFS-5121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13746927#comment-13746927
]
Colin Patrick McCabe commented on HDFS-5121:
adding new RPCs seems more like a
[
https://issues.apache.org/jira/browse/HDFS-5121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13746854#comment-13746854
]
Suresh Srinivas commented on HDFS-5121:
---
bq. We should add RPCs for creating and mani
