[
https://issues.apache.org/jira/browse/HDFS-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13777963#comment-13777963
]
Chris Nauroth commented on HDFS-5191:
-
I created HDFS-5260 to track the merge to trunk
[
https://issues.apache.org/jira/browse/HDFS-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13776536#comment-13776536
]
Colin Patrick McCabe commented on HDFS-5191:
bq. [import-only changes in
[
https://issues.apache.org/jira/browse/HDFS-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13776560#comment-13776560
]
Chris Nauroth commented on HDFS-5191:
-
Great, thank you for incorporating the feedback.
[
https://issues.apache.org/jira/browse/HDFS-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13776619#comment-13776619
]
Chris Nauroth commented on HDFS-5191:
-
I forgot one more thing. There is still an
[
https://issues.apache.org/jira/browse/HDFS-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13776686#comment-13776686
]
Colin Patrick McCabe commented on HDFS-5191:
bq. Change readZeroOptionsFree to
[
https://issues.apache.org/jira/browse/HDFS-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13776899#comment-13776899
]
Suresh Srinivas commented on HDFS-5191:
---
[~cmccabe], given that this is an enabler
[
https://issues.apache.org/jira/browse/HDFS-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13777026#comment-13777026
]
Colin Patrick McCabe commented on HDFS-5191:
bq. can this be committed to trunk
[
https://issues.apache.org/jira/browse/HDFS-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13775611#comment-13775611
]
Chris Nauroth commented on HDFS-5191:
-
It looks like there are still some import-only
[
https://issues.apache.org/jira/browse/HDFS-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13774757#comment-13774757
]
Colin Patrick McCabe commented on HDFS-5191:
I decided to test
[
https://issues.apache.org/jira/browse/HDFS-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13775753#comment-13775753
]
Colin Patrick McCabe commented on HDFS-5191:
re: test timouts, I like to add
[
https://issues.apache.org/jira/browse/HDFS-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13775765#comment-13775765
]
Chris Nauroth commented on HDFS-5191:
-
bq. In other words, we have a load factor of
[
https://issues.apache.org/jira/browse/HDFS-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13774292#comment-13774292
]
Chris Nauroth commented on HDFS-5191:
-
I think this is mostly looking really good. I
[
https://issues.apache.org/jira/browse/HDFS-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13771624#comment-13771624
]
Chris Nauroth commented on HDFS-5191:
-
Passing null to mean don't create fallback
[
https://issues.apache.org/jira/browse/HDFS-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13771369#comment-13771369
]
Chris Nauroth commented on HDFS-5191:
-
I reviewed the current API and caught up on all
[
https://issues.apache.org/jira/browse/HDFS-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13771412#comment-13771412
]
Colin Patrick McCabe commented on HDFS-5191:
My feeling is that we should
[
https://issues.apache.org/jira/browse/HDFS-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13770411#comment-13770411
]
Andrew Wang commented on HDFS-5191:
---
Could someone else take a hack at reviewing this
[
https://issues.apache.org/jira/browse/HDFS-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13770435#comment-13770435
]
Chris Nauroth commented on HDFS-5191:
-
I am planning to review tomorrow.
[
https://issues.apache.org/jira/browse/HDFS-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13765705#comment-13765705
]
Luke Lu commented on HDFS-5191:
---
The overhead of using varargs seems excessive (up to 30x
[
https://issues.apache.org/jira/browse/HDFS-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13765498#comment-13765498
]
Colin Patrick McCabe commented on HDFS-5191:
I would propose changing read to
[
https://issues.apache.org/jira/browse/HDFS-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13765494#comment-13765494
]
Colin Patrick McCabe commented on HDFS-5191:
The current proposal looks like
[
https://issues.apache.org/jira/browse/HDFS-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13765720#comment-13765720
]
Suresh Srinivas commented on HDFS-5191:
---
bq. The overhead of using varargs seems
[
https://issues.apache.org/jira/browse/HDFS-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13765773#comment-13765773
]
Colin Patrick McCabe commented on HDFS-5191:
Good point... I think EnumSet is a
[
https://issues.apache.org/jira/browse/HDFS-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13766009#comment-13766009
]
Owen O'Malley commented on HDFS-5191:
-
+1 for EnumSet
revisit
23 matches
Mail list logo
