[jira] [Commented] (HDFS-10893) Refactor TestDFSShell by setting up MiniDFSCluser once for all commands test

2016-09-29 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15535145#comment-15535145 ] Mingliang Liu commented on HDFS-10893: -- [~jnp] would you like review this? Thanks. >

[jira] [Commented] (HDFS-10934) TestDFSShell.testStat fails intermittently

2016-09-30 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15537011#comment-15537011 ] Mingliang Liu commented on HDFS-10934: -- [~ebadger], it's a nice catch! I think the pa

[jira] [Updated] (HDFS-10934) TestDFSShell.testStat fails intermittently

2016-09-30 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-10934: - Issue Type: Sub-task (was: Bug) Parent: HDFS-10891 > TestDFSShell.testStat fails intermit

[jira] [Updated] (HDFS-10934) TestDFSShell.testStat fails intermittently

2016-09-30 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-10934: - Target Version/s: 2.8.0 Component/s: test > TestDFSShell.testStat fails intermittently >

[jira] [Updated] (HDFS-10891) Über-jira: Test Improvement by adding missing test cases for existing code

2016-09-30 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-10891: - Target Version/s: 2.8.0 (was: 3.0.0-alpha2) > Über-jira: Test Improvement by adding missing test

[jira] [Commented] (HDFS-10934) TestDFSShell.testStat fails intermittently

2016-09-30 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15537088#comment-15537088 ] Mingliang Liu commented on HDFS-10934: -- Changing the status2 from {{testDir1}} to {{t

[jira] [Commented] (HDFS-10893) Refactor TestDFSShell by setting up MiniDFSCluser once for all commands test

2016-09-30 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15537096#comment-15537096 ] Mingliang Liu commented on HDFS-10893: -- V1 patch rebased from {{trunk}} branch. > Re

[jira] [Updated] (HDFS-10893) Refactor TestDFSShell by setting up MiniDFSCluser once for all commands test

2016-09-30 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-10893: - Attachment: HDFS-10893.001.patch > Refactor TestDFSShell by setting up MiniDFSCluser once for all

[jira] [Updated] (HDFS-10893) Refactor TestDFSShell by setting up MiniDFSCluser once for all commands test

2016-09-30 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-10893: - Attachment: HDFS-10893-branch-2.001.patch > Refactor TestDFSShell by setting up MiniDFSCluser once

[jira] [Commented] (HDFS-10934) TestDFSShell.testStat fails intermittently

2016-09-30 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15537138#comment-15537138 ] Mingliang Liu commented on HDFS-10934: -- What I proposed is some code snippet liket: {

[jira] [Commented] (HDFS-10810) Setreplication removing block from underconstrcution temporarily when batch IBR is enabled.

2016-10-02 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15541446#comment-15541446 ] Mingliang Liu commented on HDFS-10810: -- [~brahmareddy], can you confirm that the bran

[jira] [Updated] (HDFS-10810) Setreplication removing block from underconstrcution temporarily when batch IBR is enabled.

2016-10-03 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-10810: - Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available)

[jira] [Updated] (HDFS-10810) Setreplication removing block from underconstrcution temporarily when batch IBR is enabled.

2016-10-03 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-10810: - Component/s: namenode > Setreplication removing block from underconstrcution temporarily when bat

[jira] [Updated] (HDFS-10810) Setreplication removing block from underconstrcution temporarily when batch IBR is enabled.

2016-10-03 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-10810: - Fix Version/s: 3.0.0-alpha2 2.8.0 > Setreplication removing block from underco

[jira] [Updated] (HDFS-10934) TestDFSShell.testStat fails intermittently

2016-10-03 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-10934: - Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 3.0.0-alpha2

[jira] [Updated] (HDFS-10893) Refactor TestDFSShell by setting up MiniDFSCluser once for all commands test

2016-10-03 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-10893: - Attachment: HDFS-10893.002.patch > Refactor TestDFSShell by setting up MiniDFSCluser once for all

[jira] [Updated] (HDFS-10893) Refactor TestDFSShell by setting up MiniDFSCluser once for all commands test

2016-10-03 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-10893: - Attachment: HDFS-10893-branch-2.002.patch Rebased from {{trunk}} and {{branch-2}} branches for res

[jira] [Updated] (HDFS-10893) Refactor TestDFSShell by setting up MiniDFSCluser once for all commands test

2016-10-05 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-10893: - Attachment: HDFS-10893-branch-2.002.patch > Refactor TestDFSShell by setting up MiniDFSCluser once

[jira] [Updated] (HDFS-10893) Refactor TestDFSShell by setting up MiniDFSCluser once for all commands test

2016-10-06 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-10893: - Target Version/s: 2.9.0 (was: 2.8.0) > Refactor TestDFSShell by setting up MiniDFSCluser once for

[jira] [Updated] (HDFS-10893) Refactor TestDFSShell by setting up MiniDFSCluser once for all commands test

2016-10-06 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-10893: - Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 2.9.0 Status: Resolv

[jira] [Commented] (HDFS-10903) Replace config key literal strings with config key names II: hadoop hdfs

2016-10-06 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15552909#comment-15552909 ] Mingliang Liu commented on HDFS-10903: -- {{dfs.namenode.fslock.fair}} is being tracked

[jira] [Commented] (HDFS-10903) Replace config key literal strings with config key names II: hadoop hdfs

2016-10-06 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15552912#comment-15552912 ] Mingliang Liu commented on HDFS-10903: -- +1 pending on Jenkins. > Replace config key

[jira] [Commented] (HDFS-10972) Add unit test for HDFS command 'dfsadmin -getDatanodeInfo'

2016-10-06 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15553388#comment-15553388 ] Mingliang Liu commented on HDFS-10972: -- Thanks for the patch. I think this UT is usef

[jira] [Commented] (HDFS-10965) Add unit test for HDFS command 'dfsadmin -printTopology'

2016-10-06 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15553400#comment-15553400 ] Mingliang Liu commented on HDFS-10965: -- Thanks for the patch, [~xiaobingo]. Can you u

[jira] [Updated] (HDFS-10893) Refactor TestDFSShell by setting up MiniDFSCluser once for all commands test

2016-10-06 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-10893: - Fix Version/s: 3.0.0-alpha2 > Refactor TestDFSShell by setting up MiniDFSCluser once for all comma

[jira] [Commented] (HDFS-10972) Add unit test for HDFS command 'dfsadmin -getDatanodeInfo'

2016-10-06 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15553439#comment-15553439 ] Mingliang Liu commented on HDFS-10972: -- I found most of my comments can be addressed

[jira] [Commented] (HDFS-10903) Replace config key literal strings with config key names II: hadoop hdfs

2016-10-06 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15553665#comment-15553665 ] Mingliang Liu commented on HDFS-10903: -- Test failure {{hadoop.tools.TestHdfsConfigFie

[jira] [Commented] (HDFS-10972) Add unit test for HDFS command 'dfsadmin -getDatanodeInfo'

2016-10-07 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1885#comment-1885 ] Mingliang Liu commented on HDFS-10972: -- Can you add a failing case (e.g. no arguments

[jira] [Updated] (HDFS-10985) o.a.h.ha.TestZKFailoverController#testGracefulFailoverMultipleZKfcs fails intermittently

2016-10-07 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-10985: - Component/s: test > o.a.h.ha.TestZKFailoverController#testGracefulFailoverMultipleZKfcs fails > i

[jira] [Created] (HDFS-10985) o.a.h.ha.TestZKFailoverController#testGracefulFailoverMultipleZKfcs fails intermittently

2016-10-07 Thread Mingliang Liu (JIRA)
Mingliang Liu created HDFS-10985: Summary: o.a.h.ha.TestZKFailoverController#testGracefulFailoverMultipleZKfcs fails intermittently Key: HDFS-10985 URL: https://issues.apache.org/jira/browse/HDFS-10985

[jira] [Updated] (HDFS-10985) o.a.h.ha.TestZKFailoverController#testGracefulFailoverMultipleZKfcs fails intermittently

2016-10-07 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-10985: - Attachment: HDFS-10985.000.patch [~ste...@apache.org] and [~atm], does this makes sense to you? >

[jira] [Updated] (HDFS-10985) o.a.h.ha.TestZKFailoverController#testGracefulFailoverMultipleZKfcs fails intermittently

2016-10-07 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-10985: - Status: Patch Available (was: Open) > o.a.h.ha.TestZKFailoverController#testGracefulFailoverMulti

[jira] [Updated] (HDFS-10985) o.a.h.ha.TestZKFailoverController#testGracefulFailoverMultipleZKfcs fails intermittently

2016-10-07 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-10985: - Description: {{TestZKFailoverController#testGracefulFailoverMultipleZKfcs}} uses fixed time sleep

[jira] [Updated] (HDFS-10985) o.a.h.ha.TestZKFailoverController#testGracefulFailoverMultipleZKfcs should not use fixed time sleep before assertsions

2016-10-07 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-10985: - Summary: o.a.h.ha.TestZKFailoverController#testGracefulFailoverMultipleZKfcs should not use fixed

[jira] [Updated] (HDFS-10985) o.a.h.ha.TestZKFailoverController#testGracefulFailoverMultipleZKfcs should not use fixed time sleep before assertsions

2016-10-07 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-10985: - Priority: Minor (was: Major) > o.a.h.ha.TestZKFailoverController#testGracefulFailoverMultipleZKfc

[jira] [Updated] (HDFS-10985) o.a.h.ha.TestZKFailoverController should not use fixed time sleep before assertsions

2016-10-07 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-10985: - Summary: o.a.h.ha.TestZKFailoverController should not use fixed time sleep before assertsions (wa

[jira] [Updated] (HDFS-10985) o.a.h.ha.TestZKFailoverController should not use fixed time sleep before assertsions

2016-10-07 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-10985: - Description: {{TestZKFailoverController#testGracefulFailoverMultipleZKfcs}} uses fixed time sleep

[jira] [Commented] (HDFS-10972) Add unit test for HDFS command 'dfsadmin -getDatanodeInfo'

2016-10-07 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15556745#comment-15556745 ] Mingliang Liu commented on HDFS-10972: -- # We don't have to call {{restoreStream()}} i

[jira] [Created] (HDFS-10986) DFSAdmin should show detailed error message if any

2016-10-07 Thread Mingliang Liu (JIRA)
Mingliang Liu created HDFS-10986: Summary: DFSAdmin should show detailed error message if any Key: HDFS-10986 URL: https://issues.apache.org/jira/browse/HDFS-10986 Project: Hadoop HDFS Issue

[jira] [Updated] (HDFS-10986) DFSAdmin should show detailed error message if any

2016-10-07 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-10986: - Description: There are some subcommands in {{DFSAdmin}} that swallow IOException and give very li

[jira] [Updated] (HDFS-10986) DFSAdmin should show detailed error message if any

2016-10-07 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-10986: - Description: There are some subcommands in {{DFSAdmin}} that swallow IOException and give very li

[jira] [Updated] (HDFS-10986) DFSAdmin should log detailed error message if any

2016-10-07 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-10986: - Affects Version/s: (was: 2.8.0) Target Version/s: 3.0.0-alpha2 Description: The

[jira] [Updated] (HDFS-10986) DFSAdmin should log detailed error message if any

2016-10-07 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-10986: - Description: There are some subcommands in {{DFSAdmin}} that swallow IOException and give very li

[jira] [Updated] (HDFS-10986) DFSAdmin should log detailed error message if any

2016-10-07 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-10986: - Status: Patch Available (was: Open) > DFSAdmin should log detailed error message if any > ---

[jira] [Updated] (HDFS-10986) DFSAdmin should log detailed error message if any

2016-10-07 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-10986: - Attachment: HDFS-10986.000.patch > DFSAdmin should log detailed error message if any > ---

[jira] [Commented] (HDFS-10986) DFSAdmin should log detailed error message if any

2016-10-07 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15556967#comment-15556967 ] Mingliang Liu commented on HDFS-10986: -- [~kihwal] and [~brahmareddy] does this make s

[jira] [Updated] (HDFS-10985) o.a.h.ha.TestZKFailoverController should not use fixed time sleep before assertsions

2016-10-10 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-10985: - Attachment: HDFS-10985.001.patch The v1 patch also fixed the {{testGracefulFailover}} test case.

[jira] [Updated] (HDFS-10985) o.a.h.ha.TestZKFailoverController should not use fixed time sleep before assertions

2016-10-10 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-10985: - Description: {{TestZKFailoverController#testGracefulFailoverMultipleZKfcs}} uses fixed time sleep

[jira] [Updated] (HDFS-10985) o.a.h.ha.TestZKFailoverController should not use fixed time sleep before assertions

2016-10-10 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-10985: - Attachment: HDFS-10985-branch-2.8.001.patch Thank you [~ste...@apache.org] for your review. Can yo

[jira] [Commented] (HDFS-10972) Add unit test for HDFS command 'dfsadmin -getDatanodeInfo'

2016-10-10 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15563084#comment-15563084 ] Mingliang Liu commented on HDFS-10972: -- +1 Will commit shortly. > Add unit test for

[jira] [Commented] (HDFS-10972) Add unit test for HDFS command 'dfsadmin -getDatanodeInfo'

2016-10-10 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15563086#comment-15563086 ] Mingliang Liu commented on HDFS-10972: -- Test failures are not related. > Add unit te

[jira] [Commented] (HDFS-10988) Refactor TestBalancerBandwidth

2016-10-10 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15563108#comment-15563108 ] Mingliang Liu commented on HDFS-10988: -- +1 Will commit shortly. > Refactor TestBalan

[jira] [Commented] (HDFS-10988) Refactor TestBalancerBandwidth

2016-10-10 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15563109#comment-15563109 ] Mingliang Liu commented on HDFS-10988: -- Test failure is not related. > Refactor Test

[jira] [Commented] (HDFS-10972) Add unit test for HDFS command 'dfsadmin -getDatanodeInfo'

2016-10-10 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15563140#comment-15563140 ] Mingliang Liu commented on HDFS-10972: -- Committed to {{trunk}} and {{branch-2}}. Can

[jira] [Updated] (HDFS-10972) Add unit test for HDFS command 'dfsadmin -getDatanodeInfo'

2016-10-10 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-10972: - Fix Version/s: 3.0.0-alpha2 > Add unit test for HDFS command 'dfsadmin -getDatanodeInfo' > ---

[jira] [Updated] (HDFS-10988) Refactor TestBalancerBandwidth

2016-10-10 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-10988: - Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 3.0.0-alpha2

[jira] [Updated] (HDFS-10988) Refactor TestBalancerBandwidth

2016-10-10 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-10988: - Component/s: balancer & mover > Refactor TestBalancerBandwidth > -- >

[jira] [Updated] (HDFS-10985) o.a.h.ha.TestZKFailoverController should not use fixed time sleep before assertions

2016-10-10 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-10985: - Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 3.0.0-alpha2

[jira] [Commented] (HDFS-10972) Add unit test for HDFS command 'dfsadmin -getDatanodeInfo'

2016-10-10 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15563538#comment-15563538 ] Mingliang Liu commented on HDFS-10972: -- +1 pending on Jenkins. > Add unit test for H

[jira] [Updated] (HDFS-10985) o.a.h.ha.TestZKFailoverController should not use fixed time sleep before assertions

2016-10-10 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-10985: - Description: {{TestZKFailoverController#testGracefulFailoverMultipleZKfcs}} uses fixed time sleep

[jira] [Commented] (HDFS-10965) Add unit test for HDFS command 'dfsadmin -printTopology'

2016-10-10 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15563889#comment-15563889 ] Mingliang Liu commented on HDFS-10965: -- {code} 384 /* init reused vars */ 3

[jira] [Updated] (HDFS-10986) DFSAdmin should log detailed error message if any

2016-10-10 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-10986: - Description: There are some subcommands in {{DFSAdmin}} that swallow IOException and give very li

[jira] [Commented] (HDFS-10903) Replace config key literal strings with config key names II: hadoop hdfs

2016-10-10 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15564009#comment-15564009 ] Mingliang Liu commented on HDFS-10903: -- {{ipc.client.connect.max.retries}} is used in

[jira] [Updated] (HDFS-10986) DFSAdmin should log detailed error message if any

2016-10-10 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-10986: - Attachment: HDFS-10986.001.patch Thanks for your review, [~brahmareddy]. The v1 patch is to addres

[jira] [Comment Edited] (HDFS-10965) Add unit test for HDFS command 'dfsadmin -printTopology'

2016-10-10 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15563889#comment-15563889 ] Mingliang Liu edited comment on HDFS-10965 at 10/11/16 12:43 AM: ---

[jira] [Updated] (HDFS-10972) Add unit test for HDFS command 'dfsadmin -getDatanodeInfo'

2016-10-10 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-10972: - Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 2.8.0 Status: Resolv

[jira] [Updated] (HDFS-10986) DFSAdmin should log detailed error message if any

2016-10-10 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-10986: - Target Version/s: 2.8.0 (was: 3.0.0-alpha2) > DFSAdmin should log detailed error message if any >

[jira] [Updated] (HDFS-10986) DFSAdmin should log detailed error message if any

2016-10-10 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-10986: - Attachment: HDFS-10986.002.patch > DFSAdmin should log detailed error message if any > ---

[jira] [Updated] (HDFS-10986) DFSAdmin should log detailed error message if any

2016-10-10 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-10986: - Attachment: HDFS-10986-branch-2.8.002.patch > DFSAdmin should log detailed error message if any >

[jira] [Updated] (HDFS-10986) DFSAdmin should log detailed error message if any

2016-10-11 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-10986: - Attachment: HDFS-10986.003.patch > DFSAdmin should log detailed error message if any > ---

[jira] [Updated] (HDFS-10986) DFSAdmin should log detailed error message if any

2016-10-11 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-10986: - Attachment: HDFS-10986-branch-2.8.003.patch > DFSAdmin should log detailed error message if any >

[jira] [Commented] (HDFS-10986) DFSAdmin should log detailed error message if any

2016-10-11 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15566678#comment-15566678 ] Mingliang Liu commented on HDFS-10986: -- Thanks for the review, [~xiaobingo]. {quote}

[jira] [Commented] (HDFS-10965) Add unit test for HDFS command 'dfsadmin -printTopology'

2016-10-11 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15566714#comment-15566714 ] Mingliang Liu commented on HDFS-10965: -- {code} baseDir.mkdirs(); {code} This is n

[jira] [Commented] (HDFS-10965) Add unit test for HDFS command 'dfsadmin -printTopology'

2016-10-11 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15566884#comment-15566884 ] Mingliang Liu commented on HDFS-10965: -- +1 pending on Jenkins > Add unit test for HD

[jira] [Commented] (HDFS-10903) Replace config key literal strings with config key names II: hadoop hdfs

2016-10-11 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15566966#comment-15566966 ] Mingliang Liu commented on HDFS-10903: -- Committed to {{trunk}} branch. Can you also p

[jira] [Commented] (HDFS-10903) Replace config key literal strings with config key names II: hadoop hdfs

2016-10-11 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15566967#comment-15566967 ] Mingliang Liu commented on HDFS-10903: -- +1 > Replace config key literal strings with

[jira] [Commented] (HDFS-10986) DFSAdmin should log detailed error message if any

2016-10-11 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15566970#comment-15566970 ] Mingliang Liu commented on HDFS-10986: -- [~brahmareddy] Can you review the v3 patch? T

[jira] [Updated] (HDFS-10533) Make DistCpOptions class immutable

2016-10-11 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-10533: - Attachment: HDFS-10533.005.patch The v5 version rebased from {{trunk}} branch and resolved minor c

[jira] [Updated] (HDFS-10965) Add unit test for HDFS command 'dfsadmin -printTopology'

2016-10-11 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-10965: - Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 3.0.0-alpha2

[jira] [Created] (HDFS-11002) Fix broken attr(5) link in ExtendedAttributes.md

2016-10-12 Thread Mingliang Liu (JIRA)
Mingliang Liu created HDFS-11002: Summary: Fix broken attr(5) link in ExtendedAttributes.md Key: HDFS-11002 URL: https://issues.apache.org/jira/browse/HDFS-11002 Project: Hadoop HDFS Issue Ty

[jira] [Updated] (HDFS-11002) Fix broken attr/getfattr/setfattr links in ExtendedAttributes.md

2016-10-12 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-11002: - Summary: Fix broken attr/getfattr/setfattr links in ExtendedAttributes.md (was: Fix broken attr(5

[jira] [Updated] (HDFS-11002) Fix broken attr/getfattr/setfattr links in ExtendedAttributes.md

2016-10-12 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-11002: - Attachment: HDFS-11002.000.patch Kindly review. > Fix broken attr/getfattr/setfattr links in Exte

[jira] [Updated] (HDFS-11002) Fix broken attr/getfattr/setfattr links in ExtendedAttributes.md

2016-10-12 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-11002: - Status: Patch Available (was: Open) > Fix broken attr/getfattr/setfattr links in ExtendedAttribut

[jira] [Updated] (HDFS-10903) Replace config key literal strings with config key names II: hadoop hdfs

2016-10-12 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-10903: - Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available)

[jira] [Updated] (HDFS-11002) Fix broken attr/getfattr/setfattr links in ExtendedAttributes.md

2016-10-12 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-11002: - Attachment: HDFS-11002.001.patch Thank you [~ajisakaa] for your prompt review! {quote} Recently a

[jira] [Commented] (HDFS-11002) Fix broken attr/getfattr/setfattr links in ExtendedAttributes.md

2016-10-12 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15570918#comment-15570918 ] Mingliang Liu commented on HDFS-11002: -- Thank you for your review and commit! > Fix

[jira] [Commented] (HDFS-10986) DFSAdmin should log detailed error message if any

2016-10-13 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15573305#comment-15573305 ] Mingliang Liu commented on HDFS-10986: -- Thank you for taking care of this, [~brahmare

[jira] [Created] (HDFS-11007) AliyunOSSInputStream#read() should update read bytes stat correctly

2016-10-13 Thread Mingliang Liu (JIRA)
Mingliang Liu created HDFS-11007: Summary: AliyunOSSInputStream#read() should update read bytes stat correctly Key: HDFS-11007 URL: https://issues.apache.org/jira/browse/HDFS-11007 Project: Hadoop HDF

[jira] [Updated] (HDFS-11007) AliyunOSSInputStream#read() should update read bytes stat correctly

2016-10-13 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-11007: - Status: Patch Available (was: Open) > AliyunOSSInputStream#read() should update read bytes stat c

[jira] [Updated] (HDFS-11007) AliyunOSSInputStream#read() should update read bytes stat correctly

2016-10-13 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-11007: - Attachment: HDFS-11007.000.patch I reviewed (sorry for coming late) other places that update the f

[jira] [Created] (HDFS-11008) Add unit test for parsing "-source" parameter in Balancer tool

2016-10-13 Thread Mingliang Liu (JIRA)
Mingliang Liu created HDFS-11008: Summary: Add unit test for parsing "-source" parameter in Balancer tool Key: HDFS-11008 URL: https://issues.apache.org/jira/browse/HDFS-11008 Project: Hadoop HDFS

[jira] [Updated] (HDFS-11008) Add unit test for parsing "-source" parameter in Balancer tool

2016-10-13 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-11008: - Attachment: HDFS-11008.000.patch [~szetszwo] Could you kindly review? Thanks. > Add unit test for

[jira] [Updated] (HDFS-11008) Add unit test for parsing "-source" parameter in Balancer tool

2016-10-13 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-11008: - Description: [HDFS-8826] added an option to specify the source node list so that balancer only se

[jira] [Updated] (HDFS-11008) Add unit test for parsing "-source" parameter in Balancer tool

2016-10-13 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-11008: - Status: Patch Available (was: Open) > Add unit test for parsing "-source" parameter in Balancer t

[jira] [Updated] (HDFS-11008) Add unit test for parsing "-source" parameter in Balancer tool

2016-10-13 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-11008: - Description: [HDFS-8826] added an option {{-source}} to specify the source node list so that bala

[jira] [Updated] (HDFS-11008) Add unit test for parsing "-source" parameter in Balancer tool

2016-10-13 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-11008: - Component/s: tools > Add unit test for parsing "-source" parameter in Balancer tool >

[jira] [Updated] (HDFS-11011) Add unit test for HDFS command 'dfsadmin -set/clearSpaceQuota'

2016-10-13 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-11011: - Status: Patch Available (was: Open) > Add unit test for HDFS command 'dfsadmin -set/clearSpaceQuo

[jira] [Commented] (HDFS-11008) Add unit test for parsing "-source" parameter in Balancer tool

2016-10-13 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15574262#comment-15574262 ] Mingliang Liu commented on HDFS-11008: -- Testing failures are not related. > Add unit

[jira] [Updated] (HDFS-11008) Change unit test for testing parsing "-source" parameter in Balancer CLI

2016-10-14 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-11008: - Resolution: Fixed Fix Version/s: 3.0.0-alpha2 2.8.0 Status: Re

[jira] [Commented] (HDFS-11011) Add unit tests for HDFS command 'dfsadmin -set/clrSpaceQuota'

2016-10-14 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15576620#comment-15576620 ] Mingliang Liu commented on HDFS-11011: -- Hi Xiaobing, before reviewing the patch, I ha

<    8   9   10   11   12   13   14   15   16   17   >