[hibernate-dev] HCANN evolution

2020-10-22 Thread Sanne Grinovero
Hi all, While investigating a case of too much memory being held after boot, I noticed Hibernate Commons Annotations's old design and patterns are a strong contributor to the problem. We talked many times about getting rid of it, yet we know it's not easy as we have a high level of coupling - but

[hibernate-dev] Re: HCANN evolution

2020-10-22 Thread Yoann Rodiere
Hi, Looks good to me, but please ping me when you submit the PR. HCANN is used in Hibernate Search as well, and not just the ORM module. If we ever need to have two ORM modules in Hibernate Search (one for ORM 5 and one for ORM 6), I'll need to be sure that Hibernate Search can switch from HCANN 5

[hibernate-dev] Re: HCANN evolution

2020-10-22 Thread Sanne Grinovero
Sure, I'll do that. Regarding Validator, I believe it doesn't use it? On Thu, 22 Oct 2020 at 14:02, Yoann Rodiere wrote: > > Hi, > > Looks good to me, but please ping me when you submit the PR. HCANN is used in > Hibernate Search as well, and not just the ORM module. > If we ever need to have t

[hibernate-dev] Re: HCANN evolution

2020-10-22 Thread Sanne Grinovero
On Thu, 22 Oct 2020 at 14:36, Guillaume Smet wrote: > > On Thu, Oct 22, 2020 at 3:30 PM Sanne Grinovero wrote: >> >> Sure, I'll do that. >> >> Regarding Validator, I believe it doesn't use it? > > No, it doesn't! Great! thanks ___ hibernate-dev mailing

[hibernate-dev] Re: HCANN evolution

2020-10-22 Thread Steve Ebersole
Sounds good, I'll take a look. Longer term, the best option from the perspective of ORM is to simply drop HCANN altogether in favor of Jandex + JAXB. In fact, I am considering playing with that on top of your work. It would be awesome to start dropping the things that hold us to including dom4j

[hibernate-dev] Re: HCANN evolution

2020-10-22 Thread Sanne Grinovero
On Thu, 22 Oct 2020 at 14:50, Steve Ebersole wrote: > > Sounds good, I'll take a look. Thanks, here is a draft PR for ORM master: - https://github.com/hibernate/hibernate-orm/pull/3608 > > Longer term, the best option from the perspective of ORM is to simply drop > HCANN altogether in favor of

[hibernate-dev] Re: HCANN evolution

2020-10-22 Thread Steve Ebersole
On Thu, Oct 22, 2020 at 9:00 AM Sanne Grinovero wrote: > On Thu, 22 Oct 2020 at 14:50, Steve Ebersole wrote: > > N.B. I'm considering these steps as a preparation step, I didn't yet > address the core of the memory retention issue - I'll get to that > next, having simplified the problem first. >