[Hugin-devs] [Bug 1892420] Re: levmar uses BLAS when built with LAPACK, but Hugin does not link against BLAS

2020-08-22 Thread Dennis Schridde
> Our own FindLAPACK and also CMake FindLAPACK include both the BLAS library in the LAPACK_LIBRARIES (both tested!) Interesting. I also see that in /usr/share/cmake/Modules/FindLAPACK.cmake:231-502: if(BLAS_FOUND) [...] else() message(STATUS "LAPACK requires BLAS") endif() For me the output

[Hugin-devs] [Bug 1892420] Re: levmar uses BLAS when built with LAPACK, but Hugin does not link against BLAS

2020-08-22 Thread Dennis Schridde
Thank you for taking a look. Gentoo's package manager removes that file in favour of the one provided by CMake itself: ❯ q file -v /usr/share/cmake/Modules/FindLAPACK.cmake dev-util/cmake-3.18.1: /usr/share/cmake/Modules/FindLAPACK.cmake Now one might argue that CMake is correct in having the LA

[Hugin-devs] [Bug 1892420] Re: levmar uses BLAS when built with LAPACK, but Hugin does not link against BLAS

2020-08-22 Thread Dennis Schridde
> Also before applying the patch I would be interested in a comparison between self-contained levmar and levmar+LAPACK. [...] If there is no improvement of using LAPACK then maybe the LAPACK detection should be removed. If the benefits of this build-system feature of Hugin are unknown, I agree i

[Hugin-devs] [Bug 1892420] Re: levmar uses BLAS when built with LAPACK, but Hugin does not link against BLAS

2020-08-22 Thread Dennis Schridde
> What is the error the build system report without the patch? cd /tmp/portage/media-gfx/hugin-2019.2.0/work/hugin-2019.2.0_build/src/tools && /usr/bin/cmake -E cmake_link_script CMakeFiles/cpclean.dir/link.txt --verbose=1 /usr/sbin/x86_64-pc-linux-gnu-g++ -pipe -O2 -march=znver1 -Wl,-O1 -Wl,--a

[Hugin-devs] [Bug 1892420] [NEW] levmar uses BLAS when built with LAPACK, but Hugin does not link against BLAS

2020-08-20 Thread Dennis Schridde
Public bug reported: ``` hugin-2019.2.0/src/foreign/levmar/misc_core.c:45:#define GEMM LM_MK_BLAS_NAME(gemm) ``` This function is a BLAS function: https://en.wikipedia.org/wiki/Basic_Linear_Algebra_Subprograms#Level_3 Thus, since levmar is built as a static library, Hugin itself should call `fi