Re: [hwloc-devel] hwloc.m4: minor english fixes

2017-02-08 Thread Jeff Squyres (jsquyres)
On Feb 8, 2017, at 10:28 AM, Samuel Thibault wrote: > >> 1. You reverted an actual grammar fix: "support" -> "supported". > > Oops, I missed that part, sorry. Cool -- you just put that back; thanks. > No, but as of now there is just no way that binding can be supported > without knowing anythi

Re: [hwloc-devel] hwloc.m4: minor english fixes

2017-02-08 Thread Samuel Thibault
Jeff Squyres (jsquyres), on Wed 08 Feb 2017 15:19:58 +, wrote: > 1. You reverted an actual grammar fix: "support" -> "supported". Oops, I missed that part, sorry. > 2. I don't think that "likely" is bad to have. Like I said above, the test > itself is just a switch/case test based on a hard

Re: [hwloc-devel] hwloc.m4: minor english fixes

2017-02-08 Thread Jeff Squyres (jsquyres)
The email script doesn't run on GitHub. We have a GitHub web hook that fires out to the Open MPI hostgator instance (our web hosting provider). That fires up a PHP script (i.e., GitHub calls https://...open-mpi.org/...php) and funnels it the information about the commits that were just pushed t

Re: [hwloc-devel] hwloc.m4: minor english fixes

2017-02-08 Thread Brice Goglin
FWIW, I didn't get the commit email either, and I am pretty sure it's not the first time it happens. There are no archives for this ML, do we have a way to see the logs of the emailing script that runs on github ? Brice Le 08/02/2017 16:19, Jeff Squyres (jsquyres) a écrit : > On Feb 7, 2017, at

Re: [hwloc-devel] hwloc.m4: minor english fixes

2017-02-08 Thread Jeff Squyres (jsquyres)
On Feb 7, 2017, at 12:12 PM, Jeff Squyres (jsquyres) wrote: > > Fair enough, but the test itself is just a switch/case statement -- it's not > an actual test to see if the system supports binding or not. Hence, hedging > the warning message a little seemed reasonable. I see you actually rever

Re: [hwloc-devel] hwloc.m4: minor english fixes

2017-02-07 Thread Jeff Squyres (jsquyres)
On Feb 7, 2017, at 11:48 AM, Samuel Thibault wrote: > >> -AC_MSG_WARN([*** and binding will not be support.]) >> +AC_MSG_WARN([*** and binding will likely not be supported.]) > > Well, it's not really "likely": unsupported systems really won't have > binding support. For getting

Re: [hwloc-devel] hwloc.m4: minor english fixes

2017-02-07 Thread Samuel Thibault
git...@open-mpi.org, on Tue 07 Feb 2017 09:15:01 -0600, wrote: > commit 96a1a1b4d9f4d34e6b26ed4a665a739fd449131a > Author: Jeff Squyres > Date: Tue Feb 7 10:13:27 2017 -0500 > > hwloc.m4: minor english fixes > > Signed-off-by: Jeff Squyres > > @@ -262,7 +262,7 @@ EOF]) >