Re: [ibm-acpi-devel] thinkpad_acpi unhandled HKEY events

2013-03-06 Thread Henrique de Moraes Holschuh
Hi Samuel! On Fri, 15 Feb 2013, Samuel Groß wrote: > 0x6020 - happens when the small button on the screen above the power > button is pressed (toggles screen auto rotation under windows) I'd have to add special handling for this. > 0x60b0 and > 0x60b1 - both show up in the logs regularily, I'm n

Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: fix potential suspend blocking issue

2013-03-06 Thread Maciej Rutecki
On wtorek, 5 marca 2013 o 18:34:43 Mandeep Singh Baines wrote: > Fixes the following lockdep error: > > [ BUG: ktpacpi_nvramd/446 still has locks held! ] > > hotkey_kthread() calls set_freezable() after acquiring the > hotkey_kthread_mutex(). set_freezable() calls try_to_freeze(). > This could bl

[ibm-acpi-devel] x230: unhandled HKEY event 0x6050

2013-03-06 Thread Borislav Petkov
Hi all, I get this in dmesg with 3.9-rc1: [ 12.951434] thinkpad_acpi: unhandled HKEY event 0x6050 [ 12.951438] thinkpad_acpi: please report the conditions when this event happened to ibm-acpi-devel@lists.sourceforge.net [ 13.516752] thinkpad_acpi: unknown possible thermal alarm or keyboard

Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: fix potential suspend blocking issue

2013-03-06 Thread Oleg Nesterov
On 03/05, Andrew Morton wrote: > > Basically the same as > http://ozlabs.org/~akpm/mmots/broken-out/drivers-platform-x86-thinkpad_acpic-move-hotkey_thread_mutex-lock-after-set_freezable.patch. > I think Artem's patch is a little better. There doesn't appear to be > any locking protocol for tpacpi

Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: fix potential suspend blocking issue

2013-03-06 Thread Artem Savkov
On Wed, Mar 06, 2013 at 04:50:39PM +0100, Oleg Nesterov wrote: > On 03/05, Andrew Morton wrote: > > > > Basically the same as > > http://ozlabs.org/~akpm/mmots/broken-out/drivers-platform-x86-thinkpad_acpic-move-hotkey_thread_mutex-lock-after-set_freezable.patch. > > I think Artem's patch is a lit

[ibm-acpi-devel] [REGRESSION] [3.9-rc1] BUG: ktpacpi_nvramd/446 still has locks held!

2013-03-06 Thread Maciej Rutecki
Last known good: 3.8.0 Bad version: 3.9-rc1 [6.116492] = [6.116614] [ BUG: ktpacpi_nvramd/446 still has locks held! ] [6.116737] 3.9.0-rc1 #1 Not tainted [6.116821] - [6.116900] 1 lock held by ktpacpi_nvram

Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: fix potential suspend blocking issue

2013-03-06 Thread Mandeep Singh Baines
On Tue, Mar 5, 2013 at 10:05 AM, Oleg Nesterov wrote: > On 03/05, Mandeep Singh Baines wrote: >> >> On Tue, Mar 5, 2013 at 9:48 AM, Oleg Nesterov wrote: >> > On 03/05, Mandeep Singh Baines wrote: >> >> >> >> @@ -2462,13 +2462,13 @@ static int hotkey_kthread(void *data) >> >> unsigned int po

Re: [ibm-acpi-devel] [REGRESSION] [3.9-rc1] BUG: ktpacpi_nvramd/446 still has locks held!

2013-03-06 Thread Aaron Lu
On 03/05/2013 03:55 AM, Maciej Rutecki wrote: > Last known good: 3.8.0 > Bad version: 3.9-rc1 > > [6.116492] = > [6.116614] [ BUG: ktpacpi_nvramd/446 still has locks held! ] > [6.116737] 3.9.0-rc1 #1 Not tainted > [6.116821] -

Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: fix potential suspend blocking issue

2013-03-06 Thread Mandeep Singh Baines
On Tue, Mar 5, 2013 at 9:48 AM, Oleg Nesterov wrote: > On 03/05, Mandeep Singh Baines wrote: >> >> @@ -2462,13 +2462,13 @@ static int hotkey_kthread(void *data) >> unsigned int poll_freq; >> bool was_frozen; >> >> + set_freezable(); >> + >> mutex_lock(&hotkey_thread_mutex); >

Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: fix potential suspend blocking issue

2013-03-06 Thread Oleg Nesterov
On 03/05, Mandeep Singh Baines wrote: > > On Tue, Mar 5, 2013 at 9:48 AM, Oleg Nesterov wrote: > > On 03/05, Mandeep Singh Baines wrote: > >> > >> @@ -2462,13 +2462,13 @@ static int hotkey_kthread(void *data) > >> unsigned int poll_freq; > >> bool was_frozen; > >> > >> + set_freeza

Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: fix potential suspend blocking issue

2013-03-06 Thread Oleg Nesterov
On 03/05, Mandeep Singh Baines wrote: > > @@ -2462,13 +2462,13 @@ static int hotkey_kthread(void *data) > unsigned int poll_freq; > bool was_frozen; > > + set_freezable(); > + > mutex_lock(&hotkey_thread_mutex); > > if (tpacpi_lifecycle == TPACPI_LIFE_EXITING) >

[ibm-acpi-devel] [PATCH] thinkpad-acpi: fix potential suspend blocking issue

2013-03-06 Thread Mandeep Singh Baines
Fixes the following lockdep error: [ BUG: ktpacpi_nvramd/446 still has locks held! ] hotkey_kthread() calls set_freezable() after acquiring the hotkey_kthread_mutex(). set_freezable() calls try_to_freeze(). This could block suspend if we were to freeze at this point and another task were to block

Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: fix potential suspend blocking issue

2013-03-06 Thread Oleg Nesterov
On 03/05, Henrique de Moraes Holschuh wrote: > > On Tue, 05 Mar 2013, Mandeep Singh Baines wrote: > > This mutex seems wrong. Its held the entire time the kthread is > > running. I think its used to synchronize on the exit of the kthread. A > > completion would more appropriate in that case. > > Fr

Re: [ibm-acpi-devel] [REGRESSION] [3.9-rc1] BUG: ktpacpi_nvramd/446 still has locks held!

2013-03-06 Thread Mandeep Singh Baines
On Mon, Mar 4, 2013 at 11:28 PM, Aaron Lu wrote: > On 03/05/2013 03:55 AM, Maciej Rutecki wrote: >> Last known good: 3.8.0 >> Bad version: 3.9-rc1 >> >> [6.116492] = >> [6.116614] [ BUG: ktpacpi_nvramd/446 still has locks held! ] >> [6.116737] 3.9.0-

Re: [ibm-acpi-devel] x230: unhandled HKEY event 0x6050

2013-03-06 Thread Henrique de Moraes Holschuh
On Mon, 04 Mar 2013, Borislav Petkov wrote: > I get this in dmesg with 3.9-rc1: > > [ 12.951434] thinkpad_acpi: unhandled HKEY event 0x6050 > [ 12.951438] thinkpad_acpi: please report the conditions when this event > happened to ibm-acpi-devel@lists.sourceforge.net > [ 13.516752] thinkpad_a

Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: fix potential suspend blocking issue

2013-03-06 Thread Henrique de Moraes Holschuh
On Wed, 06 Mar 2013, Oleg Nesterov wrote: > On 03/05, Henrique de Moraes Holschuh wrote: > > On Tue, 05 Mar 2013, Mandeep Singh Baines wrote: > > > This mutex seems wrong. Its held the entire time the kthread is > > > running. I think its used to synchronize on the exit of the kthread. A > > > comp