On Mon, 2015-02-23 at 14:00 -0300, Henrique de Moraes Holschuh wrote:
> On Fri, Feb 20, 2015, at 02:28, Darren Hart wrote:
> > On Wed, Feb 18, 2015 at 09:53:44PM +0100, Bastien Nocera wrote:
> >
> > Commit message please.
> >
> > > Signed-off-by: Bastien Nocera
> > > ---
> > > drivers/platform/
On Fri, Feb 20, 2015, at 02:28, Darren Hart wrote:
> On Wed, Feb 18, 2015 at 09:53:44PM +0100, Bastien Nocera wrote:
>
> Commit message please.
>
> > Signed-off-by: Bastien Nocera
> > ---
> > drivers/platform/x86/thinkpad_acpi.c | 71
> > +++-
> > 1 file changed
On Mon, Feb 23, 2015, at 08:41, Bastien Nocera wrote:
> > You could opt to change some of those keypresses dinamically into
> > driver-specific
> > ACPI events, by setting the keymap entry to KEY_RESERVED. The driver
> > will
> > issue HKEY events in that case. That will be an viable alternative f
On Mon, 2015-02-23 at 07:49 -0300, Henrique de Moraes Holschuh wrote:
> On Mon, Feb 23, 2015, at 07:15, Bastien Nocera wrote:
> > On Wed, 2015-02-18 at 21:34 -0200, Henrique de Moraes Holschuh wrote:
> > > On Wed, 18 Feb 2015, Bastien Nocera wrote:
> > > > Signed-off-by: Bastien Nocera
> > >
> >
On Mon, Feb 23, 2015, at 07:15, Bastien Nocera wrote:
> On Wed, 2015-02-18 at 21:34 -0200, Henrique de Moraes Holschuh wrote:
> > On Wed, 18 Feb 2015, Bastien Nocera wrote:
> > > Signed-off-by: Bastien Nocera
> >
> > This one requires an ACK from the input maintainers, or no go...
>
> Any commen
On Mon, 2015-02-23 at 07:25 -0300, Henrique de Moraes Holschuh wrote:
> On Fri, Feb 20, 2015, at 11:44, Bastien Nocera wrote:
> > Use the DEVICE_ATTR_RW macro to reduce boiler plate
>
> So far, so good, but you also used the DEVICE_ATTR_RO macro...
>
> > and move the attribute declaration to get
On Fri, Feb 20, 2015, at 12:20, Mika Westerberg wrote:
> On Fri, Feb 20, 2015 at 03:44:22PM +0100, Bastien Nocera wrote:
> > Add a sysfs attribute to allow privileged users to change the keyboard
> > mode. This could be used by desktop environments to change the keyboard
> > mode depending on the a
On Fri, Feb 20, 2015, at 11:44, Bastien Nocera wrote:
> Use the DEVICE_ATTR_RW macro to reduce boiler plate
So far, so good, but you also used the DEVICE_ATTR_RO macro...
> and move the attribute declaration to get rid of function signatures.
I didn't see any "move the attribute declaration" don
On Wed, 2015-02-18 at 21:34 -0200, Henrique de Moraes Holschuh wrote:
> On Wed, 18 Feb 2015, Bastien Nocera wrote:
> > Signed-off-by: Bastien Nocera
>
> This one requires an ACK from the input maintainers, or no go...
Any comments about the other patches?
--
On Fri, 2015-02-20 at 11:27 -0800, Andy Lutomirski wrote:
> On 02/20/2015 06:44 AM, Bastien Nocera wrote:
> > + KEY_MICCANCEL_MODE, /* Microphone cancellation */
>
> What's this? We already have KEY_MICMUTE. Is this different? If so,
> can you improve the comment a bit?
I don't thi
10 matches
Mail list logo
