- Original Message -
> Hello Bastien
>
> >-Original Message-----
> >From: Bastien Nocera
>
> >- Original Message -
> >> Newer Lenovo Thinkpad platforms have support to identify whether the
> >> system is on-lap or n
ed by userspace for thermal mode and WWAN
> functionality
>
> Co-developed-by: Nitin Joshi
> Signed-off-by: Nitin Joshi
> Reviewed-by: Sugumaran
> Signed-off-by: Mark Pearson
You can add my:
Reviewed-by: Bastien Nocera
Cheers
__
hotkey to the new
> KEY_SELECTIVE_SCREENSHOT key-code.
>
> Signed-off-by: Hans de Goede
Added 5 years ago for the Carbon X1 2014, and finally getting
a keycode ;)
Reviewed-by: Bastien Nocera
> ---
> drivers/platform/x86/thinkpad_acpi.c | 2 +-
> 1 file changed, 1 insertion
On Tue, 2016-04-19 at 14:42 +0200, Bjørn Mork wrote:
> Bastien Nocera writes:
>
> >
> > From: Shuduo Sang
> >
> > The Thinkpad X1 Carbon 2nd generation (2014) ships with BIOS that
> > will
> > return HKEY interface version 0x200. It needs thinkpad-ac
From: Shuduo Sang
The Thinkpad X1 Carbon 2nd generation (2014) ships with BIOS that will
return HKEY interface version 0x200. It needs thinkpad-acpi support
otherwise it will be routed to wrong branch and the hotkey mask will
be wrong.
https://bugzilla.kernel.org/show_bug.cgi?id=114731
Signed-o
EY interface: 0x200
>
> Those are known harmless conditions, and HKEY 0x200 interface *is* the
> adaptative keyboard version of the HKEY event interface, but it is only
> "partially" known...
>
> And as you can see, it apparently still has some rough edges ;-)
>
>
084 ('thinkpad_acpi: Add support for more adaptive
> kbd buttons')
> Signed-off-by: Dan Carpenter
Acked-By: Bastien Nocera
> diff --git a/drivers/platform/x86/thinkpad_acpi.c
> b/drivers/platform/x86/thinkpad_acpi.c
> index 024861d..7769575 100644
> --- a/drivers/platf
On Wed, 2015-03-11 at 12:34 +0300, Dan Carpenter wrote:
> This needs to be signed for the error handling to work. Valid modes
> are small positive integers.
>
> Fixes: b790ceeb0fd9 ('thinkpad_acpi: Add adaptive_kbd_mode sysfs
> attr') Signed-off-by: Dan Carpenter
Use the DEVICE_ATTR_* macros to reduce boiler plate.
Signed-off-by: Bastien Nocera
---
drivers/platform/x86/thinkpad_acpi.c | 72 ++--
1 file changed, 20 insertions(+), 52 deletions(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c
b/drivers/platform/x86
Rather than checking on each suspend and resume whether the laptop
has an adaptive keyboard, check when the driver is initialised.
Signed-off-by: Bastien Nocera
---
drivers/platform/x86/thinkpad_acpi.c | 37 ++--
1 file changed, 18 insertions(+), 19 deletions
Add a sysfs attribute to allow privileged users to change the keyboard
mode. This could be used by desktop environments to change the keyboard
mode depending on the application focused, as the Windows application
does.
Signed-off-by: Bastien Nocera
---
Documentation/laptops/thinkpad-acpi.txt
This commit adds new elements to the ThinkPad keymaps, and
will send key events for keys for which an input.h declaration
exists.
Signed-off-by: Bastien Nocera
---
drivers/platform/x86/thinkpad_acpi.c | 80 +++-
1 file changed, 79 insertions(+), 1 deletion
Move the getting/setting of the adaptive keyboard mode to separate
functions, so that we can reuse them later through sysfs attributes.
Signed-off-by: Bastien Nocera
---
drivers/platform/x86/thinkpad_acpi.c | 61 ++--
1 file changed, 38 insertions(+), 23
On Wed, 2015-02-25 at 22:18 -0800, Darren Hart wrote:
> On Fri, Feb 20, 2015 at 03:44:10PM +0100, Bastien Nocera wrote:
> > Rather than checking on each suspend and resume whether the laptop
> > has an adaptive keyboard, check when the driver is initialised.
>
> Bastien,
On Fri, 2015-02-20 at 19:54 +0100, Bastien Nocera wrote:
> Hey Dmitry,
>
> On Fri, 2015-02-20 at 10:40 -0800, Dmitry Torokhov wrote:
> > On Fri, Feb 20, 2015 at 10:04:04AM -0500, Benjamin Tissoires wrote:
> > > On Fri, Feb 20, 2015 at 9:44 AM, Bastien Nocera wrote:
> &
On Mon, 2015-02-23 at 14:00 -0300, Henrique de Moraes Holschuh wrote:
> On Fri, Feb 20, 2015, at 02:28, Darren Hart wrote:
> > On Wed, Feb 18, 2015 at 09:53:44PM +0100, Bastien Nocera wrote:
> >
> > Commit message please.
> >
> > > Signed-off-by: Bastien Nocer
On Mon, 2015-02-23 at 07:49 -0300, Henrique de Moraes Holschuh wrote:
> On Mon, Feb 23, 2015, at 07:15, Bastien Nocera wrote:
> > On Wed, 2015-02-18 at 21:34 -0200, Henrique de Moraes Holschuh wrote:
> > > On Wed, 18 Feb 2015, Bastien Nocera wrote:
> > > >
On Mon, 2015-02-23 at 07:25 -0300, Henrique de Moraes Holschuh wrote:
> On Fri, Feb 20, 2015, at 11:44, Bastien Nocera wrote:
> > Use the DEVICE_ATTR_RW macro to reduce boiler plate
>
> So far, so good, but you also used the DEVICE_ATTR_RO macro...
>
> > and move the attr
On Wed, 2015-02-18 at 21:34 -0200, Henrique de Moraes Holschuh wrote:
> On Wed, 18 Feb 2015, Bastien Nocera wrote:
> > Signed-off-by: Bastien Nocera
>
> This one requires an ACK from the input maintainers, or no go...
Any comments about th
On Fri, 2015-02-20 at 11:27 -0800, Andy Lutomirski wrote:
> On 02/20/2015 06:44 AM, Bastien Nocera wrote:
> > + KEY_MICCANCEL_MODE, /* Microphone cancellation */
>
> What's this? We already have KEY_MICMUTE. Is this different? If so,
> can you improve the
Hey Dmitry,
On Fri, 2015-02-20 at 10:40 -0800, Dmitry Torokhov wrote:
> On Fri, Feb 20, 2015 at 10:04:04AM -0500, Benjamin Tissoires wrote:
> > On Fri, Feb 20, 2015 at 9:44 AM, Bastien Nocera wrote:
> > > Signed-off-by: Bastien Nocera
> > > ---
> > &
On Thu, 2015-02-19 at 21:35 -0800, Darren Hart wrote:
> On Wed, Feb 18, 2015 at 09:53:48PM +0100, Bastien Nocera wrote:
> > This commit adds new elements to the ThinkPad keymaps, and
> > will send key events for keys for which an input.h declaration
> > exists.
> >
Move the getting/setting of the adaptive keyboard mode to separate
functions, so that we can reuse them later through sysfs attributes.
Signed-off-by: Bastien Nocera
---
drivers/platform/x86/thinkpad_acpi.c | 61 ++--
1 file changed, 38 insertions(+), 23
Rather than checking on each suspend and resume whether the laptop
has an adaptive keyboard, check when the driver is initialised.
Signed-off-by: Bastien Nocera
---
drivers/platform/x86/thinkpad_acpi.c | 37 ++--
1 file changed, 18 insertions(+), 19 deletions
On Fri, 2015-02-20 at 17:27 +0200, Mika Westerberg wrote:
> On Fri, Feb 20, 2015 at 04:22:07PM +0100, Bastien Nocera wrote:
> > On Fri, 2015-02-20 at 17:20 +0200, Mika Westerberg wrote:
> > > On Fri, Feb 20, 2015 at 03:44:22PM +0100, Bastien Nocera wrote:
> > > >
On Fri, 2015-02-20 at 17:20 +0200, Mika Westerberg wrote:
> On Fri, Feb 20, 2015 at 03:44:22PM +0100, Bastien Nocera wrote:
> > Add a sysfs attribute to allow privileged users to change the keyboard
> > mode. This could be used by desktop environments to change the keyboard
> &
Signed-off-by: Bastien Nocera
---
include/uapi/linux/input.h | 10 ++
1 file changed, 10 insertions(+)
diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h
index b0a8130..affe40e 100644
--- a/include/uapi/linux/input.h
+++ b/include/uapi/linux/input.h
@@ -740,6 +740,16
Use the DEVICE_ATTR_RW macro to reduce boiler plate and move the
attribute declaration to get rid of function signatures.
Signed-off-by: Bastien Nocera
---
drivers/platform/x86/thinkpad_acpi.c | 72 ++--
1 file changed, 20 insertions(+), 52 deletions(-)
diff
This commit adds new elements to the ThinkPad keymaps, and
will send key events for keys for which an input.h declaration
exists.
Signed-off-by: Bastien Nocera
---
drivers/platform/x86/thinkpad_acpi.c | 80 +++-
1 file changed, 79 insertions(+), 1 deletion
Add support for newly added evdev keycodes.
Signed-off-by: Bastien Nocera
---
drivers/platform/x86/thinkpad_acpi.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c
b/drivers/platform/x86/thinkpad_acpi.c
index 57130a1
Add a sysfs attribute to allow privileged users to change the keyboard
mode. This could be used by desktop environments to change the keyboard
mode depending on the application focused, as the Windows application
does.
Signed-off-by: Bastien Nocera
---
drivers/platform/x86/thinkpad_acpi.c | 69
On Thu, 2015-02-19 at 21:28 -0800, Darren Hart wrote:
> On Wed, Feb 18, 2015 at 09:53:44PM +0100, Bastien Nocera wrote:
>
> Commit message please.
Added.
> > Signed-off-by: Bastien Nocera
> > ---
> > drivers/platform/x86/thinkpad_acpi.c | 71
> > ++
On Thu, 2015-02-19 at 21:22 -0800, Darren Hart wrote:
> On Wed, Feb 18, 2015 at 09:53:35PM +0100, Bastien Nocera wrote:
>
> Please provide a commit message. There is always something to say beyond what
> is
> in the subject. In this case, I suggest the motivation and justifica
On Thu, 2015-02-19 at 21:08 -0800, Darren Hart wrote:
> On Wed, Feb 18, 2015 at 09:53:28PM +0100, Bastien Nocera wrote:
> > Rather than checking on each suspend and resume whether the laptop
> > has an adaptive keyboard, check when the driver is initialised.
>
> Reasonable.
&
Signed-off-by: Bastien Nocera
---
drivers/platform/x86/thinkpad_acpi.c | 61 ++--
1 file changed, 38 insertions(+), 23 deletions(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c
b/drivers/platform/x86/thinkpad_acpi.c
index 80db3ce..a6dd017 100644
--- a
Signed-off-by: Bastien Nocera
---
include/uapi/linux/input.h | 10 ++
1 file changed, 10 insertions(+)
diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h
index b0a8130..affe40e 100644
--- a/include/uapi/linux/input.h
+++ b/include/uapi/linux/input.h
@@ -740,6 +740,16
Rather than checking on each suspend and resume whether the laptop
has an adaptive keyboard, check when the driver is initialised.
Signed-off-by: Bastien Nocera
---
drivers/platform/x86/thinkpad_acpi.c | 38 ++--
1 file changed, 19 insertions(+), 19 deletions
Signed-off-by: Bastien Nocera
---
drivers/platform/x86/thinkpad_acpi.c | 71 +++-
1 file changed, 62 insertions(+), 9 deletions(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c
b/drivers/platform/x86/thinkpad_acpi.c
index a6dd017..562d958 100644
--- a
This commit adds new elements to the ThinkPad keymaps, and
will send key events for keys for which an input.h declaration
exists.
Signed-off-by: Bastien Nocera
---
drivers/platform/x86/thinkpad_acpi.c | 80 +++-
1 file changed, 79 insertions(+), 1 deletion
Add support for newly added evdev keycodes.
Signed-off-by: Bastien Nocera
---
drivers/platform/x86/thinkpad_acpi.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c
b/drivers/platform/x86/thinkpad_acpi.c
index a47a56a
Hey,
I'm currently working on adding support for the extra "adaptive" keys
for the X1 Carbon 2014 (2nd gen).
Below is the (non-working) patch to add support for some of those keys.
I'm working with Benjamin Tissoires to add the necessary, missing, Linux
keycodes.
A couple of questions though:
-
Heya,
With Matthew Garrett's help, I've been able to detect and change the
keyboard backlight on my laptop using software only.
The laptop has 3 levels of backlight (with one of them being 'off') and
can, under Linux, only be controlled using Fn+Space key combination. I
wanted to control the keyb
On Tue, 2007-05-29 at 18:45 -0300, Henrique de Moraes Holschuh wrote:
> On Tue, 29 May 2007, Richard Hughes wrote:
> > On Tue, 2007-05-29 at 22:11 +0100, Bastien Nocera wrote:
> > > > Please review, and make sure I'm on the right lines. I also can't
> > >
rack in the builtin ALSA device instead? And
then we'd get feedback from that one...
--
Bastien Nocera <[EMAIL PROTECTED]>
-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE ve
ocess the relevant event* device to get the events...
>
> Yes, I found that KEY_POWER would be routed, but KEY_FN_F1 would not be.
> I suspect something is filtering these keys.
X probably doesn't know about those keys, thus doesn't pass them on. We
need to use the proper ke
ould be
> to get new keys if needed. It seems crazy we are using infrastructure,
> if the infrastructure can't cope with the new demands. I'll see what i
> can do.
It's new keys added to the input layer's input.h, nothing to do with
user-space.
Which keys would nee
46 matches
Mail list logo
