Hi,
On 6/2/24 10:58 AM, Andy Shevchenko wrote:
> Use 2-argument strscpy(), which is not only shorter but also provides
> an additional check that destination buffer is an array.
>
> Signed-off-by: Andy Shevchenko
Since the code being modified only exists on the fixes branch I've merged
this as
Hi,
On 6/2/24 10:57 AM, Andy Shevchenko wrote:
> Use 2-argument strscpy(), which is not only shorter but also provides
> an additional check that destination buffer is an array.
>
> Signed-off-by: Andy Shevchenko
Thanks, the entire series looks good to me:
Reviewed-by: H
Hi Vlastimil,
On 5/22/24 1:50 PM, Vlastimil Babka wrote:
> On 4/24/24 2:28 PM, Hans de Goede wrote:
>> Switch the hotkey keymap handling over to the sparse-keymap helpers,
>> there should be no functional changes from this.
>>
>> Note all the mappings to KE
Hi All,
On 4/24/24 2:28 PM, Hans de Goede wrote:
> Hi All,
>
> Here is v2 of my patch-series to refactor thinkpad_acpi's hotkey handling
> and to add support for some new hotkeys on new models.
>
> Changes in v2:
> - Some small code style tweaks in response to reviews
>
Hi Mark,
On 4/24/24 8:19 PM, Mark Pearson wrote:
> Hi Hans,
>
> On Wed, Apr 24, 2024, at 8:28 AM, Hans de Goede wrote:
>> From: Mark Pearson
>>
>> Lenovo trackpoints are adding the ability to generate a doubletap event.
>> This handles the doubletap ev
Hi Ilpo,
Thank you for reviewing this series.
On 4/25/24 11:14 AM, Ilpo Järvinen wrote:
> On Wed, 24 Apr 2024, Hans de Goede wrote:
>
>> Change the hotkey_reserved_mask initialization to hardcode the list
>> of reserved keys. There are only a few reserved keys and the code
Hi,
On 4/25/24 9:13 AM, Ilpo Järvinen wrote:
> On Wed, 24 Apr 2024, Hans de Goede wrote:
>
>> Setting ignore_acpi_ev to true has the same result as setting
>> send_acpi_ev to false, so there is no need to have both.
>>
>> Drop ignore_acpi_ev.
>>
>> Teste
Hi Mark,
On 4/24/24 4:17 PM, Mark Pearson wrote:
> Hi Hans,
>
> On Wed, Apr 24, 2024, at 8:28 AM, Hans de Goede wrote:
>> Change the hotkey_reserved_mask initialization to hardcode the list
>> of reserved keys. There are only a few reserved keys and the code to
>&
[hdego...@redhat.com: Adjust for switch to sparse-keymap keymaps]
[hdego...@redhat.com: Do not log unknown event msg for doubletap when disabled]
Tested-by: Mark Pearson
Signed-off-by: Hans de Goede
---
drivers/platform/x86/thinkpad_acpi.c | 12 +++-
1 file changed, 11 insertions(+), 1
Signed-off-by: Hans de Goede
---
drivers/platform/x86/thinkpad_acpi.c | 18 --
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c
b/drivers/platform/x86/thinkpad_acpi.c
index 89931bb980be..6a136d124cab 100644
--- a/drivers/platform
From: Mark Pearson
Modify how known_ev event is handled in preparation for adding new hkey
event range.
Signed-off-by: Mark Pearson
Link: https://lore.kernel.org/r/20240417173124.9953-1-mpearson-len...@squebb.ca
Reviewed-by: Hans de Goede
Tested-by: Mark Pearson
Signed-off-by: Hans de Goede
Pearson
Signed-off-by: Hans de Goede
---
drivers/platform/x86/thinkpad_acpi.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/drivers/platform/x86/thinkpad_acpi.c
b/drivers/platform/x86/thinkpad_acpi.c
index a53b00fecf1a..b6d6466215e1 100644
--- a/drivers/platform/x86
depend on these.
Tested-by: Mark Pearson
Signed-off-by: Hans de Goede
---
drivers/platform/x86/thinkpad_acpi.c | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c
b/drivers/platform/x86/thinkpad_acpi.c
index 9b38770412ab
-off-by: Mark Pearson
Signed-off-by: Nitin Joshi
Link: https://lore.kernel.org/r/20240417173124.9953-3-mpearson-len...@squebb.ca
[hdego...@redhat.com: Adjust for switch to sparse-keymap keymaps]
Tested-by: Mark Pearson
Signed-off-by: Hans de Goede
---
drivers/platform/x86/thinkpad_acpi.c | 1 +
1
drop hotkey_unmap() it was only used to dynamically map the brightness
keys to KEY_RESERVED and after removing that it has no remaining users.
Tested-by: Mark Pearson
Signed-off-by: Hans de Goede
---
drivers/platform/x86/thinkpad_acpi.c | 45 +---
1 file changed, 21
Change the hotkey_reserved_mask initialization to hardcode the list
of reserved keys. There are only a few reserved keys and the code to
iterate over the keymap will be removed when moving to sparse-keymaps.
Tested-by: Mark Pearson
Signed-off-by: Hans de Goede
---
drivers/platform/x86
Both are only 1 / 2 lines and both only have 1 caller fold the contents
into tpacpi_hotkey_send_key() which is their single caller.
Tested-by: Mark Pearson
Signed-off-by: Hans de Goede
---
drivers/platform/x86/thinkpad_acpi.c | 16 ++--
1 file changed, 2 insertions(+), 14 deletions
changes to the keymaps since
the contents of that comment are mostly obsolete.
Tested-by: Mark Pearson
Signed-off-by: Hans de Goede
---
Changes in v2:
- Use proper multi-line comment style
---
drivers/platform/x86/thinkpad_acpi.c | 404 ++-
1 file changed, 145 insertions
ch made me think of file syncing,
or file transfer which has let me to pick KEY_XFER for this.
Note this is based on looking at a picture of the adaptive top row
in Home mode and has not been tested on an actual adaptive keyboard.
Tested-by: Mark Pearson
Signed-off-by: Hans de Goede
---
drivers/pl
call it unconditionally and check the return value.
Tested-by: Mark Pearson
Signed-off-by: Hans de Goede
---
drivers/platform/x86/thinkpad_acpi.c | 115 ++-
1 file changed, 61 insertions(+), 54 deletions(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c
b/drivers
Move hotkey_user_mask check to tpacpi_input_send_key(), this is
a preparation patch for further refactoring.
Tested-by: Mark Pearson
Signed-off-by: Hans de Goede
---
drivers/platform/x86/thinkpad_acpi.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/platform
already do. This is not a bug but
a feature.
Reviewed-by: Ilpo Järvinen
Tested-by: Mark Pearson
Signed-off-by: Hans de Goede
---
drivers/platform/x86/thinkpad_acpi.c | 16 ++--
1 file changed, 2 insertions(+), 14 deletions(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c
b/drivers
ot; inside tpacpi_input_send_key()
never happens when called from tpacpi_hotkey_send_key() so behavior does
not change.
Tested-by: Mark Pearson
Signed-off-by: Hans de Goede
---
drivers/platform/x86/thinkpad_acpi.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/pl
being logged about the hkey event being
unknown, which is wrong as the event is not unknown.
Reviewed-by: Mark Pearson
Tested-by: Mark Pearson
Signed-off-by: Hans de Goede
---
drivers/platform/x86/thinkpad_acpi.c | 86 +++-
1 file changed, 46 insertions(+), 40 deletions
.
Tested-by: Mark Pearson
Signed-off-by: Hans de Goede
---
drivers/platform/x86/thinkpad_acpi.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c
b/drivers/platform/x86/thinkpad_acpi.c
index 05c1a562f6a1..25758d252f27 100644
Move the mapping of hkey events to scancodes to tpacpi_input_send_key(),
this results in a nice cleanup and prepares things for adding sparse-keymap
support.
Tested-by: Mark Pearson
Signed-off-by: Hans de Goede
---
drivers/platform/x86/thinkpad_acpi.c | 81 +---
1 file
hecks fail causing WARN() backtraces in
dmesg due to missing locking in hotkey_exit(), fix this.
Fixes: 38831eaf7d4c ("platform/x86: thinkpad_acpi: use lockdep annotations")
Tested-by: Mark Pearson
Signed-off-by: Hans de Goede
---
drivers/platform/x86/thinkpad_acpi.c | 5 +++--
1 file c
Move the special handling (send_acpi_ev = false, hotkey_source_mask check)
for original hotkeys out of the switch-case in hotkey_notify_hotkey().
This is a preparation patch for further refactoring.
Tested-by: Mark Pearson
Signed-off-by: Hans de Goede
---
drivers/platform/x86/thinkpad_acpi.c
a bit cleaner and
this patch prepares things for moving to sparse-keymaps.
Tested-by: Mark Pearson
Signed-off-by: Hans de Goede
---
drivers/platform/x86/thinkpad_acpi.c | 71 ++--
1 file changed, 36 insertions(+), 35 deletions(-)
diff --git a/drivers/platform/x86/thinkpad_acpi
send_acpi_ev and ignore_acpi_ev are already initialized to true and false
respectively by hotkey_notify() before calling the various helpers. Drop
the needless re-initialization from the helpers.
Reviewed-by: Ilpo Järvinen
Tested-by: Mark Pearson
Signed-off-by: Hans de Goede
---
drivers
Setting ignore_acpi_ev to true has the same result as setting
send_acpi_ev to false, so there is no need to have both.
Drop ignore_acpi_ev.
Tested-by: Mark Pearson
Signed-off-by: Hans de Goede
---
drivers/platform/x86/thinkpad_acpi.c | 56 +---
1 file changed, 17
Provide a hotkey_poll_stop_sync() dummy implementation when
CONFIG_THINKPAD_ACPI_HOTKEY_POLL, so that the #ifdef-ery around
hotkey_poll_stop_sync() can be removed from hotkey_exit().
Tested-by: Mark Pearson
Signed-off-by: Hans de Goede
---
drivers/platform/x86/thinkpad_acpi.c | 5 +++--
1 file
doubletap slightly reworked to use
the new sparse-keymap.
Regards,
Hans
Hans de Goede (20):
platform/x86: thinkpad_acpi: Take hotkey_mutex during hotkey_exit()
platform/x86: thinkpad_acpi: Provide hotkey_poll_stop_sync() dummy
platform/x86: thinkpad_acpi: Drop setting send_/ignore_acpi_ev
Hi,
On 4/21/24 9:11 PM, Andy Shevchenko wrote:
> On Sun, Apr 21, 2024 at 6:45 PM Hans de Goede wrote:
>>
>> Change the default keymap to report the correct keycodes for the volume and
>> brightness keys. Reporting key events for these is already filtered out by
>> the
Hi,
On 4/22/24 10:29 AM, Ilpo Järvinen wrote:
> On Sun, 21 Apr 2024, Hans de Goede wrote:
>
>> Factor out the adaptive kbd non hotkey event handling into
>> adaptive_keyboard_change_row() and adaptive_keyboard_s_quickview_row()
>> helpers and move the handling of T
Hi,
On 4/22/24 10:07 AM, Ilpo Järvinen wrote:
> On Sun, 21 Apr 2024, Hans de Goede wrote:
>
>> send_acpi_ev, ignore_acpi_ev are already initialized to true resp. false by
>
> Wording here is odd (but I'm not native so could be I just don't
> understand what "tru
Hi Mark,
On 4/23/24 2:15 PM, Mark Pearson wrote:
> Hi Hans
>
> On Tue, Apr 23, 2024, at 4:35 AM, Hans de Goede wrote:
>> Hi Mark,
>>
>> On 4/22/24 9:27 PM, Mark Pearson wrote:
>>> Hi Hans,
>>>
>>> On Sun, Apr 21, 2024, at 11:45 AM, Hans de Go
Hi Mark,
On 4/22/24 9:27 PM, Mark Pearson wrote:
> Hi Hans,
>
> On Sun, Apr 21, 2024, at 11:45 AM, Hans de Goede wrote:
>> Factor out the adaptive kbd non hotkey event handling into
>> adaptive_keyboard_change_row() and adaptive_keyboard_s_quickview_row()
>> he
_STRING_ATTR_RO().
>
> No functional change intended.
>
> Signed-off-by: Lukas Wunner
Thanks, patch looks good to me:
Acked-by: Hans de Goede
Feel free to upstream this though whatever git tree is convenient.
Regards,
Hans
> ---
> drivers/platform/x86/asus-wmi.c | 62 ++
changes to the keymaps since
the contents of that comment are mostly obsolete.
Signed-off-by: Hans de Goede
---
drivers/platform/x86/thinkpad_acpi.c | 400 ++-
1 file changed, 141 insertions(+), 259 deletions(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c
b/drivers
ch made me think of file syncing,
or file transfer which has let me to pick KEY_XFER for this.
Note this is based on looking at a picture of the adaptive top row
in Home mode and has not been tested on an actual adaptive keyboard.
Signed-off-by: Hans de Goede
---
drivers/platform/x86/thinkpad_
Change the hotkey_reserved_mask initialization to hardcode the list
of reserved keys. There are only a few reserved keys and the code to
iterate over the keymap will be removed when moving to sparse-keymaps.
Signed-off-by: Hans de Goede
---
drivers/platform/x86/thinkpad_acpi.c | 21
-off-by: Mark Pearson
Signed-off-by: Nitin Joshi
Link: https://lore.kernel.org/r/20240417173124.9953-3-mpearson-len...@squebb.ca
[hdego...@redhat.com: Adjust for switch to sparse-keymap keymaps]
Signed-off-by: Hans de Goede
---
drivers/platform/x86/thinkpad_acpi.c | 1 +
1 file changed, 1
Move the mapping of hkey events to scancodes to tpacpi_input_send_key(),
this results in a nice cleanup and prepares things for adding sparse-keymap
support.
Signed-off-by: Hans de Goede
---
drivers/platform/x86/thinkpad_acpi.c | 81 +---
1 file changed, 24 insertions
drop hotkey_unmap() it was only used to dynamically map the brightness
keys to KEY_RESERVED and after removing that it has no remaining users.
Signed-off-by: Hans de Goede
---
drivers/platform/x86/thinkpad_acpi.c | 45 +---
1 file changed, 21 insertions(+), 24 deletions
-by: Hans de Goede
---
drivers/platform/x86/thinkpad_acpi.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/drivers/platform/x86/thinkpad_acpi.c
b/drivers/platform/x86/thinkpad_acpi.c
index cd54a2455ac8..c7e2e85944ac 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b
[hdego...@redhat.com: Adjust for switch to sparse-keymap keymaps]
[hdego...@redhat.com: Do not log unknown event msg for doubletap when disabled]
Signed-off-by: Hans de Goede
---
drivers/platform/x86/thinkpad_acpi.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git
From: Mark Pearson
Modify how known_ev event is handled in preparation for adding new hkey
event range.
Signed-off-by: Mark Pearson
Link: https://lore.kernel.org/r/20240417173124.9953-1-mpearson-len...@squebb.ca
Reviewed-by: Hans de Goede
Signed-off-by: Hans de Goede
---
drivers/platform
these 2 changes make tpacpi_input_send_key() behave the same as
sparse_keymap_report_event().
The goal of this patch is to have a separate commit with
the slightly different behavior from sparse_keymap_report_event()
before switching over to using the sparse-keymap helpers.
Signed-off-by: Hans de
Move hotkey_user_mask check to tpacpi_input_send_key(), this is
a preparation patch for further refactoring.
Signed-off-by: Hans de Goede
---
drivers/platform/x86/thinkpad_acpi.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c
b
depend on these.
Signed-off-by: Hans de Goede
---
drivers/platform/x86/thinkpad_acpi.c | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c
b/drivers/platform/x86/thinkpad_acpi.c
index bed66dd54920..ace615752c93 100644
--- a/drivers
which do not emit
a key press event together in tpacpi_driver_event().
This is a preparation patch for moving to sparse-keymaps.
Signed-off-by: Hans de Goede
---
drivers/platform/x86/thinkpad_acpi.c | 85 +++-
1 file changed, 45 insertions(+), 40 deletions(-)
diff --git
Both are only 1 / 2 lines and both only have 1 caller fold the contents
into tpacpi_hotkey_send_key() which is their single caller.
Signed-off-by: Hans de Goede
---
drivers/platform/x86/thinkpad_acpi.c | 16 ++--
1 file changed, 2 insertions(+), 14 deletions(-)
diff --git a/drivers
ot; inside tpacpi_input_send_key()
never happens when called from tpacpi_hotkey_send_key() so behavior does
not change.
Signed-off-by: Hans de Goede
---
drivers/platform/x86/thinkpad_acpi.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c
a bit cleaner and
this patch prepares things for moving to sparse-keymaps.
Signed-off-by: Hans de Goede
---
drivers/platform/x86/thinkpad_acpi.c | 71 ++--
1 file changed, 36 insertions(+), 35 deletions(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c
b/drivers/platform/x86/th
call it unconditionally and check the return value.
Signed-off-by: Hans de Goede
---
drivers/platform/x86/thinkpad_acpi.c | 115 ++-
1 file changed, 61 insertions(+), 54 deletions(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c
b/drivers/platform/x86/thinkpad_acpi.c
.
Signed-off-by: Hans de Goede
---
drivers/platform/x86/thinkpad_acpi.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c
b/drivers/platform/x86/thinkpad_acpi.c
index 3a5c4dca5c1b..acd2c7e0dea6 100644
--- a/drivers/platform/x86
send_acpi_ev, ignore_acpi_ev are already initialized to true resp. false by
hotkey_notify() before calling the various helpers. Drop the needless
re-initialization from the helpers.
Signed-off-by: Hans de Goede
---
drivers/platform/x86/thinkpad_acpi.c | 24 +---
1 file
already do. This is not a bug but
a feature.
Signed-off-by: Hans de Goede
---
drivers/platform/x86/thinkpad_acpi.c | 16 ++--
1 file changed, 2 insertions(+), 14 deletions(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c
b/drivers/platform/x86/thinkpad_acpi.c
index bb6b880a5b50
Provide a hotkey_poll_stop_sync() dummy implementation when
CONFIG_THINKPAD_ACPI_HOTKEY_POLL, so that the #ifdef-ery around
hotkey_poll_stop_sync() can be removed from hotkey_exit().
Signed-off-by: Hans de Goede
---
drivers/platform/x86/thinkpad_acpi.c | 5 +++--
1 file changed, 3 insertions
Move the special handling (send_acpi_ev = false, hotkey_source_mask check)
for original hotkeys out of the switch-case in hotkey_notify_hotkey().
This is a preparation patch for further refactoring.
Signed-off-by: Hans de Goede
---
drivers/platform/x86/thinkpad_acpi.c | 14 ++
1
hecks fail causing WARN() backtraces in
dmesg due to missing locking in hotkey_exit(), fix this.
Fixes: 38831eaf7d4c ("platform/x86: thinkpad_acpi: use lockdep annotations")
Signed-off-by: Hans de Goede
---
drivers/platform/x86/thinkpad_acpi.c | 5 +++--
1 file changed, 3 insertions(+),
Setting ignore_acpi_ev to true has the same result as setting
send_acpi_ev to false, so there is no need to have both.
Drop ignore_acpi_ev.
Signed-off-by: Hans de Goede
---
drivers/platform/x86/thinkpad_acpi.c | 56 +---
1 file changed, 17 insertions(+), 39 deletions
to review patches 1-20 that would be great.
Regards,
Hans
Hans de Goede (20):
platform/x86: thinkpad_acpi: Take hotkey_mutex during hotkey_exit()
platform/x86: thinkpad_acpi: Provide hotkey_poll_stop_sync() dummy
platform/x86: thinkpad_acpi: Drop setting send_/ignore_acpi_ev
defa
Hi,
On 4/18/24 2:24 PM, Mark Pearson wrote:
> Hi Hans,
>
> On Thu, Apr 18, 2024, at 7:34 AM, Hans de Goede wrote:
>> Hi Mark,
>>
>> On 4/18/24 1:57 AM, Mark Pearson wrote:
>>> Hi Hans,
>>>
>>> On Wed, Apr 17, 2024, at 4:06 PM, Hans de Goede w
Hi Mark,
On 4/18/24 1:57 AM, Mark Pearson wrote:
> Hi Hans,
>
> On Wed, Apr 17, 2024, at 4:06 PM, Hans de Goede wrote:
>> Hi Mark,
>>
>> On 4/17/24 9:39 PM, Hans de Goede wrote:
>>> Hi Mark,
>>>
>>> Thank you for the new version of this serie
Hi Mark,
On 4/17/24 9:39 PM, Hans de Goede wrote:
> Hi Mark,
>
> Thank you for the new version of this series, overall this looks good,
> one small remark below.
>
> On 4/17/24 7:31 PM, Mark Pearson wrote:
>> Lenovo trackpoints are adding the ability to ge
Hi Mark,
Thank you for the new version of this series, overall this looks good,
one small remark below.
On 4/17/24 7:31 PM, Mark Pearson wrote:
> Lenovo trackpoints are adding the ability to generate a doubletap event.
> This handles the doubletap event and sends the KEY_PROG1 event to
>
Hi,
On 4/16/24 2:48 PM, Mark Pearson wrote:
> Hi Hans
>
> On Tue, Apr 16, 2024, at 4:33 AM, Hans de Goede wrote:
>> Hi Mark,
>>
>> On 4/16/24 1:57 AM, Mark Pearson wrote:
>>> Hi Dmitry,
>>>
>>> On Mon, Apr 15, 2024, at 6:54 PM, Dmitry Torokho
Hi,
On 4/15/24 9:58 PM, Dmitry Torokhov wrote:
> On Mon, Apr 15, 2024 at 09:50:37PM +0200, Hans de Goede wrote:
>> Hi,
>>
>> On 4/15/24 9:40 PM, Dmitry Torokhov wrote:
>>> On Wed, Apr 10, 2024 at 10:48:10PM -0400, Mark Pearson wrote:
>>>>
wrote:
>>>> On Mon, Apr 15, 2024 at 09:50:37PM +0200, Hans de Goede wrote:
>>>>> Hi,
>>>>>
>>>>> On 4/15/24 9:40 PM, Dmitry Torokhov wrote:
>>>>>> On Wed, Apr 10, 2024 at 10:48:10PM -0400, Mark Pearson wrote:
>>>>&
Hi,
On 4/15/24 9:40 PM, Dmitry Torokhov wrote:
> On Wed, Apr 10, 2024 at 10:48:10PM -0400, Mark Pearson wrote:
>>
>> I have a stronger preference to keep the KEY_DOUBLECLICK - that one seems
>> less controversial as a genuine new input event.
>
> Please see my response to Peter's letter. I
Hi,
On 4/15/24 9:35 PM, Dmitry Torokhov wrote:
> On Thu, Apr 11, 2024 at 02:30:35PM +0200, Hans de Goede wrote:
>> Hi Dmitry,
>>
>> On 4/11/24 2:02 AM, Dmitry Torokhov wrote:
>>> On Tue, Apr 09, 2024 at 10:17:05PM -0400, Mark Pearson wrote:
>>>> Hi Dmitry
Hi Dmitry,
On 4/11/24 2:02 AM, Dmitry Torokhov wrote:
> On Tue, Apr 09, 2024 at 10:17:05PM -0400, Mark Pearson wrote:
>> Hi Dmitry
>>
>> On Tue, Apr 9, 2024, at 9:20 PM, Dmitry Torokhov wrote:
>>> On Tue, Apr 09, 2024 at 02:47:05PM -0700, Dmitry Torokhov wrote:
On Tue, Apr 09, 2024 at
Hi Dmitry,
On 4/9/24 2:00 AM, Mark Pearson wrote:
> Hi Dmitry
>
> On Mon, Apr 8, 2024, at 7:31 PM, Dmitry Torokhov wrote:
>> Hi Mark,
>>
>> On Sun, Mar 24, 2024 at 05:07:58PM -0400, Mark Pearson wrote:
>>> Add support for new input events on Lenovo laptops that need exporting to
>>> user space.
Hi Gergo,
On 4/6/24 2:01 AM, Gergo Koteles wrote:
> Some laptops have a key to switch platform profiles.
>
> Add a platform_profile_cycle() function to cycle between the enabled
> profiles.
>
> Signed-off-by: Gergo Koteles
Thank you for your patch, 1 small remark below,
otherwise this looks
input_report_key(tpacpi_inputdev,
> KEY_DOUBLECLICK, 0);
> + input_sync(tpacpi_inputdev);
> +
> mutex_unlock(_inputdev_send_mutex);
> + }
> break
Hi,
On 3/24/24 10:08 PM, Mark Pearson wrote:
> New Lenovo platforms are adding the FN+N key to generate system debug
> details that support can use for collecting important details on any
> customer cases for Windows.
> Add the infrastructure so we can do the same on Linux by generating a
>
Hi Mark,
On 3/24/24 10:07 PM, Mark Pearson wrote:
> Lenovo trackpoints are adding the ability to generate a doubletap event.
> This handles the doubletap event and sends the KEY_DOUBLECLICK event to
> userspace.
>
> Signed-off-by: Mark Pearson
> Signed-off-by: Vishnu Sankar
> ---
>
-by: Vishnu Sankar
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede
Dmitry, can I have your ack for merging this change through the pdx86
tree (since the first driver using these is a pdx86 driver) ?
Regards,
Hans
> ---
> include/uapi/linux/input-event-codes.h | 2 ++
here.
Regards,
Hans
> wt., 23 sty 2024, 11:02 użytkownik Hans de Goede <mailto:hdego...@redhat.com>> napisał:
>
> Hi,
>
> On 1/23/24 02:22, Rafal Lalik wrote:
> > Hi,
> >
> > I am experiencing issues with tpacpi module. It st
Hi,
On 1/23/24 02:22, Rafal Lalik wrote:
> Hi,
>
> I am experiencing issues with tpacpi module. It started with one of the
> kernel-6 versions, but cannot pin point exact version. It stated with being
> unable to hibernate the system. I figured out it was due to one of the
> udev-worker
fig dependencies related to the audio LED trigger
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
> ---
> drivers/platform/x86/Kconfig | 6 --
> drivers/platform/x86/asus-wmi.c | 1 -
> drivers/platform/x86/dell/Kconfig
Hi Heiner
On 1/13/24 18:03, Heiner Kallweit wrote:
> Since 64f67b5240db ("leds: trigger: audio: Add an activate callback to
> ensure the initial brightness is set") the audio triggers have an
> activate callback which sets the LED brightness as soon as the
> (default) trigger is bound to the LED
Ian King
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
> ---
> drivers/platform/x86/thinkpad_acpi.c | 8 +++-
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/platform/x86/thinkpad_acpi.c
> b/drivers/platform/
Hi Mark,
On 1/4/24 01:37, Mark Pearson wrote:
> Looking for feedback if this is a good idea or not, and if I've missed
> anything important.
>
> Over the holidays it was raining and I was bored so I was toying with the
> idea of moving some of the thinkpad_acpi functionality out of the file
>
tring when copying auxiliary
> mac address value.
> Changes in v2:
> - Added documentation.
> - All handling of the auxmac value is done in the _init function.
Thanks, this looks good to me now:
Reviewed-by: Hans de Goede
Regards,
Hans
> ---
> .../admin-guide/laptops/thinkp
minated repeated code. If
> everything is ok, I prefer it this way.
If you prefer the 2 goto solution from v5 then keeping it as is is fine.
Regards,
Hans
> ________
> From: Hans de Goede
> Sent: Tuesday, September 26, 2023 7:23 AM
> To: Fernan
Hi,
It looks like I just reviewed an old version, reviewing this version now ...
On 9/25/23 20:41, Fernando Eckhardt Valle wrote:
> Newer Thinkpads have a feature called MAC Address Pass-through.
> This patch provides a sysfs interface that userspace can use
> to get this auxiliary mac address.
Hi,
On 9/21/23 16:36, Fernando Eckhardt Valle wrote:
> Newer Thinkpads have a feature called MAC Address Pass-through.
> This patch provides a sysfs interface that userspace can use
> to get this auxiliary mac address.
>
> Signed-off-by: Fernando Eckhardt Valle
> ---
> Changes in v4:
> -
+Cc Mark Pearson for thinkpad_acpi dytc support
Jiri,
On 9/25/23 09:38, Jiri Slaby wrote:
> On 25. 09. 23, 9:19, Jiri Slaby wrote:
>> But convert_dytc_to_profile() doesn't handle this at all. Do I have a newer
>> DYTC interface? Or a broken one?
>
> Case (0x00)
>
Hi,
On 9/15/23 18:18, Ilpo Järvinen wrote:
> On Fri, 15 Sep 2023, Fernando Eckhardt Valle wrote:
>> +goto auxmacinvalid;
>> +}
>> +
>> +if (strncmp(obj->string.pointer + 0x8, "#", 1) != 0 ||
>> +strncmp(obj->string.pointer + 0x15, "#", 1) != 0) {
>
> Why use
Hi Mark, Fernando,
On 9/13/23 18:41, Mark Pearson wrote:
>
>
> On Wed, Sep 13, 2023, at 11:58 AM, Hans de Goede wrote:
>> Hi Fernando,
>>
>> On 9/6/23 21:52, Fernando Eckhardt Valle wrote:
>>> Newer Thinkpads have a feature called Mac Address Passthro
Hi Fernando,
On 9/6/23 21:52, Fernando Eckhardt Valle wrote:
> Newer Thinkpads have a feature called Mac Address Passthrough.
> This patch provides a sysfs interface that userspace can use
> to get this auxiliary mac address.
>
> Signed-off-by: Fernando Eckhardt Valle
Thank you for your patch.
Hi,
On 8/10/23 14:20, Ruan Jinjie wrote:
> Use memdup_user_nul() helper instead of open-coding to simplify the code.
>
> Signed-off-by: Ruan Jinjie
Thank you for your patch, I've applied this patch to my review-hans
branch:
Hi,
On 7/4/23 23:03, Thomas Weißschuh wrote:
> Validate locking requirements in thinkpad_acpi through lockdep.
>
> Signed-off-by: Thomas Weißschuh
Thank you for your patch-series, I've applied the series to my
review-hans branch:
Hi,
On 4/18/23 15:16, Mark Pearson wrote:
>> Subject: [External] Re: [ibm-acpi-devel] [PATCH] platform/x86:
>> thinkpad_acpi: Fix Embedded Controller access on X380 Yoga
>>
>> Hi,
>>
>> On 4/15/23 16:22, Daniel Bertalan wrote:
>>> Hi,
>>>
>
Hi,
On 4/14/23 20:02, Daniel Bertalan wrote:
> On the X380 Yoga, the `ECRD` and `ECWR` ACPI objects cannot be used for
> accessing the Embedded Controller: instead of a method that reads from
> the EC's memory, `ECRD` is the name of a location in high memory. This
> meant that trying to call them
Hi,
On 4/15/23 16:22, Daniel Bertalan wrote:
> Hi,
>
> On Saturday, April 15th, 2023 at 15:30, Hans de Goede
> wrote:
>
>> Hi,
>>
>> On 4/15/23 15:24, Liav Albani wrote:
>>
>>> On 4/15/23 13:12, Hans de Goede wrote:
>>>
&
Hi,
On 4/15/23 15:24, Liav Albani wrote:
>
> On 4/15/23 13:12, Hans de Goede wrote:
>> Hi,
>>
>> On 4/14/23 20:02, Daniel Bertalan wrote:
>>> On the X380 Yoga, the `ECRD` and `ECWR` ACPI objects cannot be used for
>>> accessing the Embedded Contr
1 - 100 of 328 matches
Mail list logo
