Re: [ibm-acpi-devel] [GIT PATCH] thinkpad-acpi fixes for 2.6.32-rc2

2009-12-26 Thread Len Brown
applied to acpi-test thanks, Len Brown, Intel Open Source Technology Center On Sat, 26 Dec 2009, Henrique de Moraes Holschuh wrote: > Len, > > This patchset fixes a few problems that have been reported, > including the annoying build problem reported by Ingo. > > It most

Re: [ibm-acpi-devel] [GIT PATCH] thinkpad-acpi second set of changes for 2.6.33

2009-12-15 Thread Len Brown
applied to acpi-test thanks, Len Brown, Intel Open Source Technology Center -- This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development supp

Re: [ibm-acpi-devel] [GIT PATCH v2] thinkpad-acpi first set of changes for 2.6.33 (v2)

2009-12-09 Thread Len Brown
1-9 applied to acpi-test thanks, Len Brown, Intel Open Source Technology Center -- Return on Information: Google Enterprise Search pays you back Get the facts. http://p.sf.net/sfu/google-dev2dev

Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: should error return be nagative?

2009-11-24 Thread Len Brown
applied thanks, Len Brown, Intel Open Source Technology Center -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus

Re: [ibm-acpi-devel] thinkpad-acpi: fix CONFIG_THINKPAD_ACPI_HOTKEY_POLL build problem

2009-09-26 Thread Len Brown
applied thanks, Len Brown, Intel Open Source Technology Center -- Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing

Re: [ibm-acpi-devel] [GIT PATCH] thinkpad-acpi patches for the merge window

2009-09-19 Thread Len Brown
series applied. thanks, Len Brown, Intel Open Source Technology Center -- Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your

Re: [ibm-acpi-devel] [PATCH 3/4] thinkpad-acpi: Avoid heap buffer overrun

2009-08-01 Thread Len Brown
applied w/ simplified check-in commment thanks, Len Brown, Intel Open Source Technology Center -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design

Re: [ibm-acpi-devel] [PATCH 4/4] thinkpad-acpi: fix incorrect use of TPACPI_BRGHT_MODE_ECNVRAM

2009-08-01 Thread Len Brown
applied thanks, Len Brown, Intel Open Source Technology Center -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus

Re: [ibm-acpi-devel] [PATCH 2/4] thinkpad-acpi: remove dock and bay subdrivers

2009-08-01 Thread Len Brown
applied thanks, Len Brown, Intel Open Source Technology Center -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus

Re: [ibm-acpi-devel] [PATCH 1/4] thinkpad-acpi: disable broken bay and dock subdrivers

2009-08-01 Thread Len Brown
applied thanks, Len Brown, Intel Open Source Technology Center -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus

Re: [ibm-acpi-devel] [PATCH 2/2] thinkpad-acpi: support the second fan on the X61

2009-06-18 Thread Len Brown
applied thanks, Len Brown, Intel Open Source Technology Center -- Crystal Reports - New Free Runtime and 30 Day Trial Check out the new simplified licensing option that enables unlimited royalty-free distribution of the

Re: [ibm-acpi-devel] [PATCH 1/2] thinkpad-acpi: forbid the use of HBRV on Lenovo ThinkPads

2009-06-17 Thread Len Brown
applied thanks, Len Brown, Intel Open Source Technology Center -- Crystal Reports - New Free Runtime and 30 Day Trial Check out the new simplified licensing option that enables unlimited royalty-free distribution of the

Re: [ibm-acpi-devel] [GIT PATCH] thinkpad-acpi queue for 2.6.31

2009-06-17 Thread Len Brown
applied thanks, Len Brown, Intel Open Source Technology Center On Sat, 30 May 2009, Henrique de Moraes Holschuh wrote: > Len, > > This patchset has some changes for thinkpad-acpi that I would like to see > merged for 2.6.31. I will likely have a few more during the me

Re: [ibm-acpi-devel] [GIT PATCH] thinkpad-acpi late queue

2009-04-17 Thread Len Brown
applied thanks, Len Brown, Intel Open Source Technology Center -- Stay on top of everything new and different, both inside and around Java (TM) technology - register by April 22, and save $200 on the JavaOne (SM

Re: [ibm-acpi-devel] [GIT PATCH] thinkpad-acpi queue for 2.6.30

2009-04-04 Thread Len Brown
applied thanks, Len Brown, Intel Open Source Technology Center On Sat, 4 Apr 2009, Henrique de Moraes Holschuh wrote: > Len, > > This patchset has the changes for thinkpad-acpi that I would like to > see merged for 2.6.30 (while the window is still open). > > It contains th

Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: fix module autoloading for older models

2009-03-15 Thread Len Brown
t I was (not) thinking about when I did it. > > Thanks for noticing this, and the revised patch looks good. revised patch (with commit log from 1st patch) applied. thanks, Len Brown, Intel Open Source Technology Center

Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: fix module autoloading for older models

2009-03-15 Thread Len Brown
applied thanks, Len Brown, Intel Open Source Technology Center On Sun, 15 Feb 2009, Henrique de Moraes Holschuh wrote: > From: Mathieu Chouquet-Stringer > > Looking at the source, there seems to be a missing * to match my DMI > string. I mean for newer IBM and Lenovo's

Re: [ibm-acpi-devel] [PATCH 05/13] ACPI: thinkpad-acpi: preserve radio state across shutdown

2009-01-15 Thread Len Brown
Interesting. So an ACPI method is writing the radio state to NVRAM and you pick it back up on boot (or resume). Very nice -- to bad we don't have this method for all laptops. Len Brown, Intel Open Source Technology Center On Sun, 11 Jan 2009, Henrique de Moraes Holschuh wrote: >

Re: [ibm-acpi-devel] [GIT PATCH][REPOST] thinkpad-acpi queue for 2.6.29

2009-01-15 Thread Len Brown
> Len, > > This is a repost of the thinkpad-acpi queue. I sent it to you on > 2008-11-22, but apparently it fell through the cracks... > > The patchset was rebased to apply on top of 2.6.29-rc1. Hmmm, I remember searching for patches from you Henrique, but I'm sure went back only as far as Than

Re: [ibm-acpi-devel] [PATCH 09/13] ACPI: thinkpad-acpi: handle HKEY thermal and battery alarms

2009-01-15 Thread Len Brown
the platform specific driver on Windows knows what to do, or knows what not to do... I suppose we'll figure out what to do when we see these actually happen w/ any frequency on test machines -- which quite possibly will never. Len Brown, Intel Open Source Technology Center On Sun, 11 Jan

Re: [ibm-acpi-devel] [PATCH] : ACPI : Use RSDT instead of XSDT by adding boot option of "acpi=rsdt"

2009-01-09 Thread Len Brown
> > >In such case the boot option of "acpi=rsdt" is provided so that > > > RSDT is tried instead of XSDT table when the system can't work well. > > Great, now we still need a dmi blacklist with machines which are known > broken. Then we are at the patchset I posted about a year ago -> scnr.

Re: [ibm-acpi-devel] [PATCH] ACPI: thinkpad-acpi: fix fan sleep/resume path

2008-11-11 Thread Len Brown
applied. thanks, -Len On Sun, 9 Nov 2008, Henrique de Moraes Holschuh wrote: > This fixes a regression from v2.6.27, caused by commit > 5814f737e1cd2cfa2893badd62189acae3e1e1fd, "ACPI: thinkpad-acpi: > attempt to preserve fan state on resume". > > It is possible for fan_suspend() to fail to pro

Re: [ibm-acpi-devel] [GIT PATCH] thinkpad-acpi late changes for the merge window

2008-10-22 Thread Len Brown
1-4 applied. (bugzilla version of "attempt to preserve fan state on resume" replaced) thanks, -Len On Sat, 18 Oct 2008, Henrique de Moraes Holschuh wrote: > > Len, > > This patchset has the changes for thinkpad-acpi that I would like to see > merged > for 2.6.28 (while the window is still op

Re: [ibm-acpi-devel] [PATCH 3/3] ACPI: thinkpad-acpi: fix LED handling on older ThinkPads

2008-06-03 Thread Len Brown
oh i see -- i had a conflict b/c i applied this to a branch which didn't have the recent upstream const patch. applied. thanks, -len - Check out the new SourceForge.net Marketplace. It's the best place to buy or sell servi

Re: [ibm-acpi-devel] [PATCH 3/3] ACPI: thinkpad-acpi: fix LED handling on older ThinkPads

2008-06-03 Thread Len Brown
this one didn't apply on top of the other two? On Tue, 3 Jun 2008, Henrique de Moraes Holschuh wrote: > The less tested codepaths for LED handling, used on ThinkPads 570, 600e/x, > 770e, 770x, A21e, A2xm/p, T20-22, X20 and maybe a few others, would write > data to kernel memory it had no business

Re: [ibm-acpi-devel] [GIT PATCH] thinkpad-acpi queue for the 2.6.26 merge window (v2)

2008-04-29 Thread Len Brown
Wups, looks like I still have v1 in my tree -- will fix. -Len On Saturday 26 April 2008, Henrique de Moraes Holschuh wrote: > Len, > > This patchset has my current thinkpad-acpi queue. The target is 2.6.26's > merge window. > > Some of the thinkpad-acpi patches require patches from Richard Pur

Re: [ibm-acpi-devel] [GIT PATCH] thinkpad-acpi queue for the 2.6.26 merge window

2008-04-10 Thread Len Brown
On Thursday 10 April 2008, Henrique de Moraes Holschuh wrote: > On Thu, 10 Apr 2008, Len Brown wrote: > > hmmm, if we drop this series as-is into acpi-test then it will fail due to > > no "brightness_get"... > > Yeah. How do you want to handle this? Defer

Re: [ibm-acpi-devel] [GIT PATCH] thinkpad-acpi queue for the 2.6.26 merge window

2008-04-09 Thread Len Brown
On Wednesday 09 April 2008, Henrique de Moraes Holschuh wrote: > > Len, > > This patchset has my current thinkpad-acpi queue. The target is 2.6.26's > merge window. > > Some of the thinkpad-acpi patches require patches from Richard Purdie's LED > tree that are already in -mm. As far as I know,

Re: [ibm-acpi-devel] [PATCH 5/9] ACPI: thinkpad-acpi: make the video output feature optional

2008-02-15 Thread Len Brown
On Friday 15 February 2008 23:17, Henrique de Moraes Holschuh wrote: > The video output port control feature is not very useful on many ThinkPads > (especially when a X server is running), and lately userspace is getting > better and better at it, so it makes sense to allow users to stripe out the

Re: [ibm-acpi-devel] [PATCH][drivers/misc/thinkpad_acpi.c] duplicate test if (level & TP_EC_FAN_FULLSPEED)

2008-02-06 Thread Len Brown
Applied. thanks, -Len On Monday 04 February 2008 18:24, Roel Kluin wrote: > Roland Dreier wrote: > > > /* safety net should the EC not support AUTO > > > * or FULLSPEED mode bits and just ignore them */ > > > if (level & TP_EC_FAN_FULLSPEED) > >

Re: [ibm-acpi-devel] [GIT PATCH] thinkpad-acpi patches for 2.6.25 (replaces batch 1)

2008-02-01 Thread Len Brown
On Friday 25 January 2008 14:20, Henrique de Moraes Holschuh wrote: > Len, > > Given that there are four cleanup patches in the batch, I didn't even > attempt to bother with checkpatch on anything before the "some checkpatch > fluff" patch. There are, for example, no tab/space problems in the fin

Re: [ibm-acpi-devel] [GIT PATCH] thinkpad-acpi patches for 2.6.25 (replaces batch 1)

2008-01-23 Thread Len Brown
scripts/checkpatch.pl WARNING: line over 80 characters #1569: FILE: drivers/misc/thinkpad_acpi.c:1280: + dbg_printk(TPACPI_DBG_EXIT, "restoring original hot key mask\n"); WARNING: line over 80 characters #1573: FILE: drivers/misc/thinkpad_acpi.c:1284: + printk(

Re: [ibm-acpi-devel] [PATCH 1/1] ACPI: thinkpad-acpi: fix lenovo keymap for brightness

2007-12-13 Thread Len Brown
Applied. thanks, -Len On Thursday 13 December 2007 09:14, Henrique de Moraes Holschuh wrote: > Several reports from X60 users complained that the default Lenovo keymap > issuing EV_KEY KEY_BRIGHTNESS_UP/DOWN input events caused major issues when > the proper brightness support through ACPI video.

Re: [ibm-acpi-devel] [PATCH 01/15] ACPI: thinkpad-acpi: refactor hotkey_get and hotkey_set

2007-11-19 Thread Len Brown
> I now have to decide whether I should follow my heart (indent levels with > tabs, everything else with spaces), or just decide that the kernel > hopelessly chained to tabs-as-8-spaces-only land and pipe thinkpad-acpi > entirely through unexpand to get rid of a huge ammount of checkpatch.pl > nag

Re: [ibm-acpi-devel] [PATCH] ACPI: thinkpad-acpi: fix oops when a module parameter has no value

2007-11-19 Thread Len Brown
applied thanks, -len On Sunday 18 November 2007 06:18, Henrique de Moraes Holschuh wrote: > set_ibm_param() could OOPS with a NULL pointer derreference if one did not > give > any values for a module parameter it handles. This would, of course, cause > all > sort of trouble for future modprobi

Re: [ibm-acpi-devel] [PATCH 01/15] ACPI: thinkpad-acpi: refactor hotkey_get and hotkey_set

2007-11-15 Thread Len Brown
> This patch: a nit to prove that I read this before dumping it into my test branch... the "perfect patch" never refers to itself as a patch in its check-in comments -- since by the time it is checked in, it is sort of self-evident it is a patch:-) http://www.zip.com.au/~akpm/linux/patches/stuf

Re: [ibm-acpi-devel] [GIT PATCH] thinkpad-acpi patches for 2.6.24-rc

2007-11-05 Thread Len Brown
I agree that these look post1rc1 worthy, lets see if the boss thinks so too. applied. thanks, -Len On Tuesday 30 October 2007 15:46, Henrique de Moraes Holschuh wrote: > Len, > > Here is a bunch of thinkpad-acpi changes that fixes some bugs and add key > thinkpad models support that should, if

Re: [ibm-acpi-devel] [PATCH] ACPI: thinkpad-acpi: use a separate platform device for hwmon and name it (v2)

2007-09-25 Thread Len Brown
On Tuesday 25 September 2007 05:38, Henrique de Moraes Holschuh wrote: > Use a separate platform device and driver ("thinkpad_hwmon") to attach > hwmon attributes and class, and add a name attribute of "thinkpad" to > it, which defines the hwmon device name for libsensors4. > > This makes thinkpad

Re: [ibm-acpi-devel] [PATCH 6/7] ACPI: thinkpad-acpi: dequeue all pending hot key events at once

2007-09-23 Thread Len Brown
On Friday 21 September 2007 09:53, Henrique de Moraes Holschuh wrote: > On Thu, 20 Sep 2007, Len Brown wrote: > > On Thursday 20 September 2007 09:50, Henrique de Moraes Holschuh wrote: > > > Receive all pending hot key events at once from a single notification, and > >

Re: [ibm-acpi-devel] [GIT PATCH v3.1] thinkpad-acpi changes for the merge window (part 1)

2007-09-23 Thread Len Brown
Okay, previous series replaced with this one. thanks, -Len On Sunday 23 September 2007 10:38, Henrique de Moraes Holschuh wrote: > Len, > > Here is the third version (fixed) of the first batch of changes for > thinkpad-acpi, targetted at the next merge window. They're mostly > non-critical fi

Re: [ibm-acpi-devel] [PATCH 6/7] ACPI: thinkpad-acpi: dequeue all pending hot key events at once

2007-09-20 Thread Len Brown
On Thursday 20 September 2007 09:50, Henrique de Moraes Holschuh wrote: > Receive all pending hot key events at once from a single notification, and > don't complain if the queue is empty. > > Signed-off-by: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> > --- > drivers/misc/thinkpad_acpi.c |

Re: [ibm-acpi-devel] [GIT PATCH] thinkpad-acpi changes targeted at 2.6.23-rc6 (v2)

2007-09-04 Thread Len Brown
On Tuesday 04 September 2007 10:13, you wrote: > > Len, > > Here is a new version of the patches for thinkpad-acpi that I'd like to > see merged in mainline before 2.6.23-rc6 is out. There were *no* code > chages since the last version. I have updated the patch comments and > title as you sugge

Re: [ibm-acpi-devel] [PATCH] ACPI: thinkpad-acpi: always enable input layer, add hotkey_report_mode

2007-09-03 Thread Len Brown
Henrique, I may be seriously jet-lagged right now, but I'm having trouble parsing this check-in comment and the the Documentation update, so I'm not clear on what you're trying to do with this code. It should basically say: hotkeys are reported through the input layer, and /proc/acpi/event when C

Re: [ibm-acpi-devel] ACPI: thinkpad-acpi: change thinkpad-acpi input default and kconfig help

2007-08-07 Thread Len Brown
Applied. thanks, -Len On Sunday 05 August 2007 14:20, Henrique de Moraes Holschuh wrote: > The current kconfig help text was misleading users. Also, the default for > an input-layer-optimized support caused way too many problems without > up-to-date userspace in place. > > So, rework the help t

Re: [ibm-acpi-devel] [GIT PULL] thinkpad-acpi queue for 2.6.23 (v3)

2007-07-21 Thread Len Brown
Applied. thanks, -Len On Wednesday 18 July 2007 22:45, Henrique de Moraes Holschuh wrote: > > Len, > > Please pull from: > > git://repo.or.cz/linux-2.6/linux-acp

Re: [ibm-acpi-devel] [PATCH] ACPI: thinkpad-acpi: do not use named sysfs groups

2007-05-31 Thread Len Brown
Applied. thanks, -Len On Wednesday 30 May 2007 19:50, Henrique de Moraes Holschuh wrote: > The initial version of the thinkpad-acpi sysfs interface (not yet released > in any stable mainline kernel) made liberal use of named sysfs groups, in > order to get the attributes more organized. > > This

Re: [ibm-acpi-devel] [2.6.20-rc4 regression] ibm-acpi: bay support disabled

2007-01-11 Thread Len Brown
Reverted. thanks, -Len On Tuesday 09 January 2007 13:54, Henrique de Moraes Holschuh wrote: > On Tue, 09 Jan 2007, Adrian Bunk wrote: > > > diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig > > > index 1639998..34cc8d5 100644 > > > --- a/drivers/acpi/Kconfig > > > +++ b/drivers/acpi/Kconfi

Re: [ibm-acpi-devel] [PATCH] ACPI: ibm_acpi: allow clean removal

2006-12-19 Thread Len Brown
ned-off-by: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> > Signed-off-by: Len Brown <[EMAIL PROTECTED]> > --- > > drivers/acpi/ibm_acpi.c |3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/drivers/acpi/ibm_acpi.c b/drivers/acpi/

Re: [ibm-acpi-devel] [PATCH 00/21] ACPI: ibm-acpi: cleanups, extended fan/thermal support

2006-12-17 Thread Len Brown
applied, with this update to play with Linux-2.6.20-rc1 thanks, -Len commit 25c68a33b7b74b37793b1250007e5e21d621a7fc Author: Len Brown <[EMAIL PROTECTED]> Date: Fri Dec 8 04:43:41 2006 -0500 ACPI: ibm_acpi: respond to workqueue update Signed-off-by: Len Brown <[EMAIL

Re: [ibm-acpi-devel] [PATCH 00/21] ACPI: ibm-acpi: cleanups, extended fan/thermal support

2006-12-06 Thread Len Brown
On Saturday 25 November 2006 15:41, Henrique de Moraes Holschuh wrote: > git://repo.or.cz/linux-2.6/linux-acpi-2.6/ibm-acpi-2.6.git > for-upstream/acpi-test Henrique, FYI, A pull of this branch will take everything included underneath it. In this case, it will take all the contents of acpi-test t