Re: [ibm-acpi-devel] [PATCH] support thinkpad HKEY interface version 0x200

2014-04-11 Thread Matthew Garrett
On Fri, 2014-04-11 at 21:10 +0800, Shuduo Sang wrote: > Hi Matthew, > > This patch is not in your recent for_linus branch. Why? I'm sorry, I'd somehow missed it. I'll get it in the next pull. -- Matthew Garrett --

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Add mappings for F9 - F12 hotkeys on T440s

2014-02-18 Thread Matthew Garrett
y 1280x1024 display". Is this the most appropriate key? -- Matthew Garrett -- Managing the Performance of Cloud-Based Applications Take advantage of what the Cloud has to offer - Avoid Common Pitfalls. Read the

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Fix inconsistent mute LED after resume

2014-02-12 Thread Matthew Garrett
On Wed, 2014-02-12 at 16:32 +0100, Takashi Iwai wrote: > The mute LED states have to be restored after resume. Hm. Is this something that should be done in the class code rather than in individual drivers? -- Matthew Garr

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Fix inconsistent mute LED after resume

2014-02-12 Thread Matthew Garrett
On Wed, 2014-02-12 at 16:32 +0100, Takashi Iwai wrote: > The mute LED states have to be restored after resume. Oh, never mind, we're not doing this through the LED class, are we? -- Matthew Garrett -- Android

Re: [ibm-acpi-devel] [PATCH] video: backlight: Remove backlight sysfs uevent

2013-11-23 Thread Matthew Garrett
On Sat, Nov 23, 2013 at 10:40:15PM -0200, Henrique de Moraes Holschuh wrote: > On Fri, 22 Nov 2013, Matthew Garrett wrote: > > We have userspace that relies on uevents of type > > BACKLIGHT_UPDATE_HOTKEY. I don't know that we have userspace that relies &g

Re: [ibm-acpi-devel] [PATCH] video: backlight: Remove backlight sysfs uevent

2013-11-22 Thread Matthew Garrett
On Fri, Nov 22, 2013 at 09:36:01AM -0200, Henrique de Moraes Holschuh wrote: > On Thu, 21 Nov 2013, Matthew Garrett wrote: > > The uevent support was initially added to handle systems where pressing > > a hotkey generates an event (good) but the firmware automatically > > c

Re: [ibm-acpi-devel] [PATCH] video: backlight: Remove backlight sysfs uevent

2013-11-21 Thread Matthew Garrett
otkey generates an event (good) but the firmware automatically changes the brightness (bad). I have absolutely no idea why I added BACKLIGHT_UPDATE_SYSFS - BACKLIGHT_UPDATE_HOTKEY solves the problem I was trying to solve. I'm not aware of any userspace that relies on BACKLIGHT_UPDATE_SYSFS. -

Re: [ibm-acpi-devel] [PATCH 6/8] platform:x86: Remove OOM message after input_allocate_device

2013-11-20 Thread Matthew Garrett
Applied, thanks. -- Matthew Garrett -- Shape the Mobile Experience: Free Subscription Software experts and developers: Be at the forefront of tech innovation. Intel(R) Software Adrenaline delivers strategic insight and

Re: [ibm-acpi-devel] [PATCH] video: backlight: Remove backlight sysfs uevent

2013-11-20 Thread Matthew Garrett
otherwise adding an attribute that > backlight devices should set when they need to supress change events? It looks like this is just to force synchronisation to sysfs when using the /proc interface? In which case we should probably ju

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Fix build error when CONFIG_SND_MAX_CARDS > 32

2013-11-20 Thread Matthew Garrett
Applied, thanks. -- Matthew Garrett -- Shape the Mobile Experience: Free Subscription Software experts and developers: Be at the forefront of tech innovation. Intel(R) Software Adrenaline delivers strategic insight and

Re: [ibm-acpi-devel] [PATCH 0/2] add sysfs for acpi interfaces of thinkpad hardware mute

2013-08-14 Thread Matthew Garrett
On Wed, 2013-08-14 at 22:59 +0200, David Henningsson wrote: > On 08/14/2013 10:38 PM, Matthew Garrett wrote: > > The user hit the mute key. Why would they expect *anything* to be > > unmuted? > > > > Why should the userspace application, who just wants to lit a LED, ha

Re: [ibm-acpi-devel] [PATCH 0/2] add sysfs for acpi interfaces of thinkpad hardware mute

2013-08-14 Thread Matthew Garrett
care > about, i e, the selected one. The user hit the mute key. Why would they expect *anything* to be unmuted? -- Matthew Garrett -- Get 100% visibility into Java/.NET code with AppDynamics Lite! It's a free tro

Re: [ibm-acpi-devel] [PATCH 0/2] add sysfs for acpi interfaces of thinkpad hardware mute

2013-08-14 Thread Matthew Garrett
On Wed, 2013-08-14 at 21:53 +0200, David Henningsson wrote: > On 08/14/2013 04:57 PM, Matthew Garrett wrote: > > On Wed, 2013-08-14 at 11:27 +0200, David Henningsson wrote: > > > >> The privacy issue is interesting, but I don't see a practical way of > >> imp

Re: [ibm-acpi-devel] [PATCH 0/2] add sysfs for acpi interfaces of thinkpad hardware mute

2013-08-14 Thread Matthew Garrett
On Wed, 2013-08-14 at 11:27 +0200, David Henningsson wrote: > The privacy issue is interesting, but I don't see a practical way of > implementing things that would protect us against compromised userspaces. That's pretty easy - just tie the LED control to the HDA device in-kern

Re: [ibm-acpi-devel] [PATCH 0/2] add sysfs for acpi interfaces of thinkpad hardware mute

2013-08-14 Thread Matthew Garrett
LED, I think any exposed LED would have to be either under kernel control. Having a compromised component of a user session be able to record audio while leaving the LED lit would be a problem. -- Matthew Garrett -- Ge

Re: [ibm-acpi-devel] [PATCH 0/2] add sysfs for acpi interfaces of thinkpad hardware mute

2013-08-14 Thread Matthew Garrett
te. Have the HDA driver call that trigger whenever the mute state changes. -- Matthew Garrett -- Get 100% visibility into Java/.NET code with AppDynamics Lite! It's a free troubleshooting tool designed for produc

Re: [ibm-acpi-devel] [PATCH 0/2] add sysfs for acpi interfaces of thinkpad hardware mute

2013-08-13 Thread Matthew Garrett
be fixed in-kernel as well. Having an application to make the LED work isn't a terribly generic solution. -- Matthew Garrett -- Get 100% visibility into Java/.NET code with AppDynamics Lite! It's a free troubleshoot

Re: [ibm-acpi-devel] [PATCH 0/2] add sysfs for acpi interfaces of thinkpad hardware mute

2013-08-13 Thread Matthew Garrett
ace to > enable it; when it is unloaded it can disable it. Is there any reason you'd want this rather than just having it generate a scancode and be under userspace control? -- Matthew Garrett -- Get 100% visibilit

Re: [ibm-acpi-devel] [PATCH 0/2] add sysfs for acpi interfaces of thinkpad hardware mute

2013-08-13 Thread Matthew Garrett
. What's expected to use this interface? If it's supposed to be some system wide configuration at boot time, we should just add a config option to the kernel and let it be overridden by module parameter. -- Matthew Garrett ---

Re: [ibm-acpi-devel] [PATCH 2/3] ACPI: Remove old /proc/acpi/event interface

2013-07-04 Thread Matthew Garrett
On Thu, 2013-07-04 at 14:37 +0200, Rafael J. Wysocki wrote: > I can take [2/3] and [3/3] for 3.12 if Matthew has no objections. Matthew? ACK. -- Matthew Garrett | mj...@srcf.ucam.org -- This SF.net email is sponso

Re: [ibm-acpi-devel] [PATCH 3/3] thinkpad_acpi: add LED quirks of models which don't have EC controllable LEDs

2013-06-20 Thread Matthew Garrett
very time Lenovo release a new machine, which isn't really going to work. -- Matthew Garrett | mj...@srcf.ucam.org -- This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.ne

Re: [ibm-acpi-devel] / is remounted when the power cable is plugged in/out

2013-01-18 Thread Matthew Garrett
On Mon, Jan 14, 2013 at 10:26:13PM +0100, Toralf Förster wrote: > b/c of the unknown event 0x6040 the ibm acpi list is Cc'ed, but what makes me > really wondering is > why / is remounted. Because something in your userspace is changing the filesystem commit interval. -- Matthe

Re: [ibm-acpi-devel] Patch to correct battery capacity values on Thinkpads (repost)

2012-11-14 Thread Matthew Garrett
On Wed, Nov 14, 2012 at 10:58:57AM +0100, Peter Stuge wrote: > Matthew Garrett wrote: > > > My guess is that this problem has been around ever since those machines > > > have been released, but because the most common Thinkpad batteries are > > > rated at 10.8V, the e

Re: [ibm-acpi-devel] Patch to correct battery capacity values on Thinkpads (repost)

2012-11-13 Thread Matthew Garrett
n > noticed or at least nobody could be bothered to look into it. Yeah, the DSDT simply multiples the values by 10 when it's in this state. But the issue is purely cosmetic, right? I can't see any reason anything would be using the design voltage in calculations. -- Matthew Ga

Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: fix issuing duplicated key events for brightness up/down

2012-05-03 Thread Matthew Garrett
Merged for -next, thanks -- Matthew Garrett | mj...@srcf.ucam.org -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT man

Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: recognize Lenovo as version string in newer V-series BIOS

2012-03-20 Thread Matthew Garrett
On Tue, Mar 13, 2012 at 05:07:45PM -0300, Henrique de Moraes Holschuh wrote: > Matthew, can you please pick it? Done. -- Matthew Garrett | mj...@srcf.ucam.org -- This SF email is sponsosred by: Try Windows Azure f

Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: Enable microphone mute LED

2011-05-27 Thread Matthew Garrett
On Fri, May 27, 2011 at 02:22:26PM -0400, Andrew Lutomirski wrote: > On Fri, May 27, 2011 at 12:48 PM, Matthew Garrett wrote: > > Hm. That makes things kind of tricky. While it's easy to just expose the > > LED, really we want to do it in such a way that userspace knows whic

Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: Enable microphone mute LED

2011-05-27 Thread Matthew Garrett
going on. Hm. That makes things kind of tricky. While it's easy to just expose the LED, really we want to do it in such a way that userspace knows which LEDs it should be toggling while setting the microphone mute. -- Matthew Garrett | mj...@srcf.ucam.org --

Re: [ibm-acpi-devel] [PATCH] Add KEY_MICMUTE and enable it on Lenovo X220

2011-05-27 Thread Matthew Garrett
On Tue, May 24, 2011 at 03:16:43PM -0400, Andy Lutomirski wrote: > I suspect that this works on T410. Dmitry? -- Matthew Garrett | mj...@srcf.ucam.org -- vRanger cuts backup time in half-while increasing security. W

Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: Enable microphone mute LED

2011-05-27 Thread Matthew Garrett
in a similar way to the mute LED? -- Matthew Garrett | mj...@srcf.ucam.org -- vRanger cuts backup time in half-while increasing security. With the market-leading solution for virtual backup and recovery, you ge

Re: [ibm-acpi-devel] [PATCH v3] thinkpad-acpi: Improve hardware volume controls

2011-05-14 Thread Matthew Garrett
ake sense for userspace? "none" sounds like it'd be fine, except that the LED wouldn't work on new machines. So should we just be setting "toggle" in all cases? The optimal situation would be that we d

Re: [ibm-acpi-devel] [RFC PATCH] thinkpad-acpi: Improve hardware volume controls

2011-05-12 Thread Matthew Garrett
On Thu, May 12, 2011 at 10:24:10AM -0400, Andrew Lutomirski wrote: > On Thu, May 12, 2011 at 9:48 AM, Matthew Garrett wrote: > > It looks like SAUM was introduced with the *61 machines, and it's > > identical from then on. > > I wonder the machines with SAUM are the sam

Re: [ibm-acpi-devel] [RFC PATCH] thinkpad-acpi: Improve hardware volume controls

2011-05-12 Thread Matthew Garrett
On Mon, May 09, 2011 at 06:18:46PM -0400, Andy Lutomirski wrote: > Henrique, do you know of anywhere to find AML dumps from different models? > It would be nice to see what SAUM looks like. It looks like SAUM was introduced with the *61 machines, and it's identical from then on.

Re: [ibm-acpi-devel] [RFC] Controlling the ThinkPad battery charger

2011-05-09 Thread Matthew Garrett
smapi and provide a hook to detach the ACPI driver, but that would potentially mean a certain amount of code duplication. -- Matthew Garrett | mj...@srcf.ucam.org -- WhatsUp Gold - Download Free Network Management S

Re: [ibm-acpi-devel] [PATCH 00/23] drivers/platform/x86: Remove warnings and use pr_

2011-04-01 Thread Matthew Garrett
Applied to -next, thanks. -- Matthew Garrett | mj...@srcf.ucam.org -- Create and publish websites with WebMatrix Use the most popular FREE web apps or write code yourself; WebMatrix provides all the features you need

Re: [ibm-acpi-devel] ThinkPad T400 : should kernel option "reboot=pci" be hard coded ?

2011-03-01 Thread Matthew Garrett
On Tue, Mar 01, 2011 at 09:40:13AM +0100, Toralf Förster wrote: > I'd like to point to this after a half year of lthe last email. Shouldn't it > be hard coded ? Windows appears to have exactly the same behaviour, so it seems that this is working like designed. -- Matt

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Always report scancodes for hotkeys

2011-02-21 Thread Matthew Garrett
Applied, thanks. -- Matthew Garrett | mj...@srcf.ucam.org -- Index, Search & Analyze Logs and other IT data in Real-Time with Splunk Collect, index and harness all the fast moving IT data generated by

Re: [ibm-acpi-devel] [PATCH] ACPI Thinkpad: We must always call va_end() after va_start() but do not do so in thinkpad_acpi.c::acpi_evalf()

2011-01-07 Thread Matthew Garrett
Applied, thanks. -- Matthew Garrett | mj...@srcf.ucam.org -- Gaining the trust of online customers is vital for the success of any company that requires sensitive data to be transmitted over the Web. Learn how to

Re: [ibm-acpi-devel] [PATCH 19/44] drivers/platform/x86: Remove unnecessary semicolons

2010-11-24 Thread Matthew Garrett
Applied, thanks. -- Matthew Garrett | mj...@srcf.ucam.org -- Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! Tap into the largest installed PC base & get more eyes on your game by optimi

Re: [ibm-acpi-devel] [PATCH 8/14] drivers/platform/x86/thinkpad_acpi.c: delete double assignment

2010-11-24 Thread Matthew Garrett
Applied, thanks. -- Matthew Garrett | mj...@srcf.ucam.org -- Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! Tap into the largest installed PC base & get more eyes on your game by optimi

Re: [ibm-acpi-devel] unhandled HKEY event 0x4010 and 0x4011

2010-09-16 Thread Matthew Garrett
On Thu, Sep 16, 2010 at 07:18:58PM -0300, Henrique de Moraes Holschuh wrote: > On Thu, 16 Sep 2010, Matthew Garrett wrote: > > Hm. We may want to create a proper dock class in the kernel to handle > > this. HPs do something similar. > > If all the state we need to c

Re: [ibm-acpi-devel] unhandled HKEY event 0x4010 and 0x4011

2010-09-16 Thread Matthew Garrett
> event which can be used to trigger things like re-configuring the displays. Hm. We may want to create a proper dock class in the kernel to handle this. HPs do something similar. -- Matthew Garrett | mj...@srcf.ucam.org --

Re: [ibm-acpi-devel] [GIT PATCH] thinkpad-acpi patches for merge window

2010-08-16 Thread Matthew Garrett
Thanks, merged. -- Matthew Garrett | mj...@srcf.ucam.org -- This SF.net email is sponsored by Make an app they can't live without Enter the BlackBerry Developer Challenge http://p.sf.net/sfu/RIM-de

Re: [ibm-acpi-devel] [PATCH] Remove 9 second reboot delay on Lenovo T400/T500

2010-07-16 Thread Matthew Garrett
, since it's a function of the chipset. The ACPI one would act instantly (it's the PCI one, in this case) but it's marked as unsupported. However, the PCI one is poorly standardised - Windows never uses it, different chips have subtly different requirements and so on. -- Matthew

Re: [ibm-acpi-devel] [PATCH] Remove 9 second reboot delay on Lenovo T400/T500

2010-07-16 Thread Matthew Garrett
Ok. 1) The ACPI reboot vector reboots these machines instantly, but the flag that indicates we should use it isn't set. 2) Windows takes 9 seconds to reboot on the same hardware. It just sounds like broken firmware. -- Matthew Garrett | mj...@srcf.uca

Re: [ibm-acpi-devel] [PATCH] Remove 9 second reboot delay on Lenovo T400/T500

2010-07-15 Thread Matthew Garrett
ge on our way down to reboot. One thing that would be worth checking is whether performing the keyboard controller writes from userspace with a minimal kernel and init=/bin/bash shows the 9-second pause or not - and then, ideally, see whether the same is also true under DOS. -- Matthew Garrett

Re: [ibm-acpi-devel] [PATCH] Remove 9 second reboot delay on Lenovo T400/T500

2010-07-15 Thread Matthew Garrett
ows implements reboots (XP, Vista and 7). It appears to use the ACPI reboot vector, the keyboard controller, the ACPI reboot vector again, the keyboard controller again and then hangs. I'll try implementing equivalent behaviour in Linux and see whether it makes any difference. -- M

Re: [ibm-acpi-devel] [PATCH] Remove 9 second reboot delay on Lenovo T400/T500

2010-07-14 Thread Matthew Garrett
rmware is broken and the 9-second delay is always going to be there. In that case we should try to use the ACPI reboot vector first. 2) We're doing something wrong in our shutdown sequence which then triggers this problem as a result. Either way, I think this patch is wr

Re: [ibm-acpi-devel] ThinkPad T400 : should kernel option "reboot=pci" be hard coded ?

2010-06-07 Thread Matthew Garrett
ring whether this option > should > be hard coded in the kernel sources b/c it seems to be necessary for current > kernels too. No, the best thing to do would be to figure out what changed to require the extra 9 seconds. Are you able to work out which the last kernel release without this

[ibm-acpi-devel] [PATCH 1/2] acpi: Provide interface for driver notification on method call

2010-05-22 Thread Matthew Garrett
It's sometimes useful for a driver to receive notifications in response to an ACPI event even if there's no explicit notification in the bytecode. Add an interface to allow drivers to register for callbacks when a given method is executed. Signed-off-by: Matthew Garrett --- drivers/a

[ibm-acpi-devel] [PATCH 2/2] thinkpad_acpi: Hook volume events

2010-05-22 Thread Matthew Garrett
Not all Thinkpads generate events for volume hotkeys, so hook into the CMOS update and generate events from there without polling. This should let Pulseaudio do something sensible with the mute state. Signed-off-by: Matthew Garrett --- drivers/platform/x86/thinkpad_acpi.c | 32

Re: [ibm-acpi-devel] [PATCH 2/2] thinkpad_acpi: Hook volume events

2010-05-06 Thread Matthew Garrett
more code involved). > > I really would rather not enable it on boxes where it isn't required. And > we know which ones are those: IBM thinkpads where the all-available-hotkeys > mask has the bits for the volume hotkeys set. Ok, that's easy enough to do. I'll r

Re: [ibm-acpi-devel] [PATCH 2/2] thinkpad_acpi: Hook volume events

2010-05-05 Thread Matthew Garrett
w whether this happens, but that detail is not clear from > the description. The call is made after executing the original method, yes. -- Matthew Garrett | mj...@srcf.ucam.org --

Re: [ibm-acpi-devel] x100e support

2010-03-15 Thread Matthew Garrett
0c09 rather than hardcoding the location? The same ought to be true of the HKEY handle. -- Matthew Garrett | mj...@srcf.ucam.org -- Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling

Re: [ibm-acpi-devel] ALSA mixer volume control

2009-05-03 Thread Matthew Garrett
moved the writable option and made it the default. I'm not entirely sure why we'd want to expose a read-only mixer, but I can add it back if it actually helps anyone. -- Matthew Garrett | mj...@srcf.ucam.org diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thi

[ibm-acpi-devel] Fn+F5 not doing anything on T61 even when handled by firmware?

2009-04-24 Thread Matthew Garrett
e front of the laptop does toggle the state. Is this expected behaviour? [1] But generates KEY_WLAN, which means that rfkill-input won't do anything with the bluetooth or wwan radios. Presumably there should be a KEY_RFKILL_ALL to complement SW_RFKILL_ALL? -- Matthew Garrett | mj..

Re: [ibm-acpi-devel] [PATCH 09/13] ACPI: thinkpad-acpi: handle HKEY thermal and battery alarms

2009-01-15 Thread Matthew Garrett
. Even if most hardware doesn't generate them, the ability to pop up a notification telling the user that the firmware thinks their system is too hot is useful. -- Matthew Garrett | mj...@srcf.ucam.org -- This S

Re: [ibm-acpi-devel] [PATCH] : ACPI : Use RSDT instead of XSDT by adding boot option of "acpi=rsdt"

2009-01-12 Thread Matthew Garrett
On Mon, Jan 12, 2009 at 11:17:07PM +0100, Thomas Renninger wrote: > On Monday 12 January 2009 03:16:55 pm Matthew Garrett wrote: > > On Mon, Jan 12, 2009 at 03:13:04PM +0100, Thomas Renninger wrote: > > > 99.998% of all machines work fine with the current, spec conform &g

Re: [ibm-acpi-devel] [PATCH] : ACPI : Use RSDT instead of XSDT by adding boot option of "acpi=rsdt"

2009-01-12 Thread Matthew Garrett
On Mon, Jan 12, 2009 at 03:13:04PM +0100, Thomas Renninger wrote: > On Friday 09 January 2009 13:34:16 Matthew Garrett wrote: > > If you know of any machines that behave this way, I'd be > > impressed - and it'll be far easier to dmi whitelist them than the other > >

Re: [ibm-acpi-devel] [PATCH] : ACPI : Use RSDT instead of XSDT by adding boot option of "acpi=rsdt"

2009-01-09 Thread Matthew Garrett
ogrammed correctly and the 32-bit ones containing a valid but not-working set is tiny. If you know of any machines that behave this way, I'd be impressed - and it'll be far easier to dmi whitelist them than the other way around. -- Matt

Re: [ibm-acpi-devel] Upcoming changes to thinkpad-acpi (your chance to comment on them)

2008-10-18 Thread Matthew Garrett
after all that, should the HAL people be bothered... I'd recommend getting the HAL people involved in any kind of kernel/userspace interface design discussion. It's best to avoid accidently ending up with something that's awkward to deal with in userspace but has already been

Re: [ibm-acpi-devel] Upcoming changes to thinkpad-acpi (your chance to comment on them)

2008-10-18 Thread Matthew Garrett
ical and either do a hibernation or clean shutdown. The wakeup event is bonus information. -- Matthew Garrett | [EMAIL PROTECTED] - This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the co

Re: [ibm-acpi-devel] x60s: problems with brightness keys (again)

2008-10-18 Thread Matthew Garrett
support. The DRM code has landed - sorry about not having the Thinkpad code included, but the opregion code has been bounced between multiple trees in a way that made me lose track of what was going on and when. -- Matthew Garrett | [E

Re: [ibm-acpi-devel] 2.6.26.[1-3] + x61 tablet + x6ultrabase: no resume after undocking

2008-09-01 Thread Matthew Garrett
bata ACPI calls on resume in that case, and it would explain why I haven't seen this on my T-series (there's no bay in the dock :) ). Unfortunately all the other docks I have present the bay as USB mass storage, so I don't have anything to test here. I'll look into this tomorrow.

Re: [ibm-acpi-devel] 2.6.26.[1-3] + x61 tablet + x6ultrabase: no resume after undocking

2008-09-01 Thread Matthew Garrett
that (it > certainly removes all USB devices and detaches ata4 (which is the bay in > the docking station). There's no interaction required, but userspace can optionally take responsibility for the docking control. Assuming lack of bugs,

Re: [ibm-acpi-devel] Avoid critical temp shutdowns on specific ThinkPad T4x(p) and R50p

2008-08-12 Thread Matthew Garrett
been changed. Do we know > what that is? > If it's really an regression then we need a low-risk fix for .27. The two choices would either seem to be that the system is now running hotter, or that we're getting spurious temperature readings. --

Re: [ibm-acpi-devel] Avoid critical temp shutdowns on specific ThinkPad T4x(p) and R50p

2008-08-11 Thread Matthew Garrett
e. I posted them, got a small amount of feedback and no further acks. I can push them again. -- Matthew Garrett | [EMAIL PROTECTED] - This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build t

Re: [ibm-acpi-devel] Avoid critical temp shutdowns on specific ThinkPad T4x(p) and R50p

2008-08-11 Thread Matthew Garrett
therwise I will start over on this one. Probably beginning > with a cleanup patch to use long for get_temp and get_trip_temp functions > instead of using char* in struct thermal_zone_device_ops {...}. > Zhang: Would that be ok or have I overseen

Re: [ibm-acpi-devel] [PATCH 1/1] Recent Lenovo ThinkPads define a dummy grahpics device, find it and ignore it

2007-10-16 Thread Matthew Garrett
tain of that. To make things more entertaining, Dell tend to implement a video extension for both the 00:02.0 and 00:02.1 devices on Intel systems. We need to be smarter about this, but I don't think simply looking for a physical device is the solution. -- Matthew Garrett | [EMAIL PROTE

Re: [ibm-acpi-devel] [PATCH] Untested proposal patch: Store video capabilities of BIOS globally at ACPI parse time and export it.

2007-10-15 Thread Matthew Garrett
s us having copy and pasted code in all of the hardware-specific drivers) -- Matthew Garrett | [EMAIL PROTECTED] - This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search l

Re: [ibm-acpi-devel] [PATCH 1/2] Export a func to find the corresponding PCI bus:seg.func of an ACPI device

2007-10-15 Thread Matthew Garrett
Why not just call acpi_get_pyhsical_device() on the appropriate handle and look at the struct device you get back? Remember to put_device() it once you're done. -- Matthew Garrett | [EMAIL PROTECTED] - This SF.net

Re: [ibm-acpi-devel] [PATCH 3/4] ACPI: thinkpad-acpi: disable backlight handler if ACPI generic could do it

2007-10-09 Thread Matthew Garrett
isn't used. I'm not sure I understand. The video driver works fine on Thinkpads, including for backlight control on recent ones. -- Matthew Garrett | [EMAIL PROTECTED] - This SF.net email is sponsored by: Splunk

Re: [ibm-acpi-devel] [PATCH 3/4] ACPI: thinkpad-acpi: disable backlight handler if ACPI generic could do it

2007-10-09 Thread Matthew Garrett
to match if backlight control is implemented. There are plenty of Thinkpads that implement a subset of the video extension but still need backlight control to be handled via the Thinkpad-specific routes. -- Matthew Garrett | [EMAIL PROTECTED] -

Re: [ibm-acpi-devel] [PATCH 3/4] ACPI: thinkpad-acpi: disable backlight handler if ACPI generic could do it

2007-10-09 Thread Matthew Garrett
f it can be controlled through the standard mechanism instead. -- Matthew Garrett | [EMAIL PROTECTED] - This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log

Re: [ibm-acpi-devel] [PATCH 3/4] ACPI: thinkpad-acpi: disable backlight handler if ACPI generic could do it

2007-10-09 Thread Matthew Garrett
On Tue, Oct 09, 2007 at 10:25:51AM +0200, Thomas Renninger wrote: > On Tue, 2007-10-09 at 08:59 +0100, Matthew Garrett wrote: > > On Tue, Oct 09, 2007 at 08:21:14AM +0200, Thomas Renninger wrote: > > > > > IMO a config variable that compiles out brightness control totall

Re: [ibm-acpi-devel] [PATCH 3/4] ACPI: thinkpad-acpi: disable backlight handler if ACPI generic could do it

2007-10-09 Thread Matthew Garrett
ads don't implement the video extension. It needs to be handled at runtime. -- Matthew Garrett | [EMAIL PROTECTED] - This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? St

Re: [ibm-acpi-devel] Brightness not quite tracked on X60s, thinkpad-acpi-0.15-20070815_v2.6.22.2.patch

2007-10-01 Thread Matthew Garrett
). The ACPI video driver does AND, so I think you want _BCL AND _BCM AND (_BCQ OR _BQC) to check that the video driver will bind and create the backlight class device, and then refuse to do so in the Thinkpad driver. -- Matthew Garrett | [EMA

Re: [ibm-acpi-devel] Brightness not quite tracked on X60s, thinkpad-acpi-0.15-20070815_v2.6.22.2.patch

2007-10-01 Thread Matthew Garrett
ff on new Thinkpads is just to leave it up to the video extension. Just check if _BCL, _BCM and _BQC are implemented and then refuse to create the backlight? -- Matthew Garrett | [EMAIL PROTECTED] - This SF.net emai

Re: [ibm-acpi-devel] ACPI: thinkpad-acpi: add input device support to hotkey subdriver

2007-07-16 Thread Matthew Garrett
e can be notified and controlled through an > ALSA mixer. It won't be a nice poll-less thing, but I can trap the ACPI hot > key events as a hint to update the mixer state, and if ALSA lets me do it, > issue mixer ch

Re: [ibm-acpi-devel] ACPI: thinkpad-acpi: add input device support to hotkey subdriver

2007-07-16 Thread Matthew Garrett
hat > card's volume? This is absolutely possible. In that case I'd expect the hotkeys to start controlling the card mixer's volume, but that's a policy decision that would have to be taken in userspace by an application aware of everything that's ha

Re: [ibm-acpi-devel] ACPI: thinkpad-acpi: make the input event mode the default

2007-07-15 Thread Matthew Garrett
On Sun, Jul 15, 2007 at 09:12:40PM -0300, Henrique de Moraes Holschuh wrote: > On Sun, 15 Jul 2007, Matthew Garrett wrote: > > No, it doesn't. It interacts in a way that you may not consider to be > > ideal - the vast majority of our users appear to prefer it to the > &

Re: [ibm-acpi-devel] ACPI: thinkpad-acpi: make the input event mode the default

2007-07-15 Thread Matthew Garrett
On Sun, Jul 15, 2007 at 07:08:01PM -0300, Henrique de Moraes Holschuh wrote: > On Sun, 15 Jul 2007, Matthew Garrett wrote: > > Right now, the hotkey functionality of the driver is not terribly useful > > without (bleeding-edge) userspace. This is inconsistent with the > &

Re: [ibm-acpi-devel] ACPI: thinkpad-acpi: add input device support to hotkey subdriver

2007-07-15 Thread Matthew Garrett
On Sun, Jul 15, 2007 at 06:54:53PM -0300, Henrique de Moraes Holschuh wrote: > On Sun, 15 Jul 2007, Matthew Garrett wrote: > > Hal is the only piece of userspace that knows how to speak to more than > > one type of backlight in any useful way, which makes it the de-facto > &

Re: [ibm-acpi-devel] ACPI: thinkpad-acpi: rename pci HID constant

2007-07-15 Thread Matthew Garrett
utterly wrong here, please ignore me :) -- Matthew Garrett | [EMAIL PROTECTED] - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits.

Re: [ibm-acpi-devel] ACPI: thinkpad-acpi: make the input event mode the default

2007-07-15 Thread Matthew Garrett
On Sun, Jul 15, 2007 at 06:14:21PM -0300, Henrique de Moraes Holschuh wrote: > On Sun, 15 Jul 2007, Matthew Garrett wrote: > > We already have in-kernel drivers that do this properly, so I'd suspect > > that whoever told you that was wrong. > > I got tired of being

Re: [ibm-acpi-devel] ACPI: thinkpad-acpi: add input device support to hotkey subdriver

2007-07-15 Thread Matthew Garrett
e solution to that would be to avoid ever sending these keycodes, but that would make having them defined in the first place a bit silly. Since they /are/ there, it makes sense to use them. -- Matthew Garrett | [EMAIL PROTECTED] ---

Re: [ibm-acpi-devel] ACPI: thinkpad-acpi: react to Lenovo ThinkPad differences in hot key

2007-07-15 Thread Matthew Garrett
in /sys/class/backlight, on others calling out to X. There's no way to automatically make that decision, so it's fine to insist that they also take into account whether it's active or passive. -- Matthew Garrett | [EMAIL PROTECTED] -

Re: [ibm-acpi-devel] ACPI: thinkpad-acpi: make the input event mode the default

2007-07-15 Thread Matthew Garrett
On Sun, Jul 15, 2007 at 05:09:48PM -0300, Henrique de Moraes Holschuh wrote: > On Sun, 15 Jul 2007, Matthew Garrett wrote: > > But we're able to differentiate between the models. > > Yes. And I was told to not do it in the kernel when possible, so I will map > by default

Re: [ibm-acpi-devel] ACPI: thinkpad-acpi: add input device support to hotkey subdriver

2007-07-15 Thread Matthew Garrett
of generating events that are to be handled in > a passive way, by default. That's simply not true. Userspace already interprets the brightness keys differently depending on the hardware type. -- Matthew Garrett | [EMAIL PROTECTED] --

Re: [ibm-acpi-devel] ACPI: thinkpad-acpi: make the input event mode the default

2007-07-15 Thread Matthew Garrett
On Sun, Jul 15, 2007 at 03:05:29PM -0300, Henrique de Moraes Holschuh wrote: > On Sat, 14 Jul 2007, Matthew Garrett wrote: > > Again, we have keycodes for most of these and we have the ability to > > make the driver choose the correct one by default. Why make things more

Re: [ibm-acpi-devel] ACPI: thinkpad-acpi: rename pci HID constant

2007-07-15 Thread Matthew Garrett
On Sun, Jul 15, 2007 at 03:02:46PM -0300, Henrique de Moraes Holschuh wrote: > On Sat, 14 Jul 2007, Matthew Garrett wrote: > > On Sat, Jul 14, 2007 at 11:12:04AM -0300, Henrique de Moraes Holschuh wrote: > > > - .hid = IBM_PCI_HID, > > > + /* THIS ONE MUST NEVER BE

Re: [ibm-acpi-devel] ACPI: thinkpad-acpi: add input device support to hotkey subdriver

2007-07-15 Thread Matthew Garrett
On Sun, Jul 15, 2007 at 03:12:33PM -0300, Henrique de Moraes Holschuh wrote: > On Sat, 14 Jul 2007, Matthew Garrett wrote: > > KEY_BRIGHTNESSUP > > Only if I start filtering it out when disabled by the mask. This key is not > to be sent to userspace unless explicitly conf

Re: [ibm-acpi-devel] ACPI: thinkpad-acpi: react to Lenovo ThinkPad differences in hot key

2007-07-15 Thread Matthew Garrett
On Sun, Jul 15, 2007 at 02:59:22PM -0300, Henrique de Moraes Holschuh wrote: > On Sat, 14 Jul 2007, Matthew Garrett wrote: > > > On Sat, Jul 14, 2007 at 11:12:09AM -0300, Henrique de Moraes Holschuh wrote: > > > > Ah, I see this one fixes some

Re: [ibm-acpi-devel] ACPI: thinkpad-acpi: react to Lenovo ThinkPad differences in hot key

2007-07-14 Thread Matthew Garrett
hy this difference? -- Matthew Garrett | [EMAIL PROTECTED] - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click t

Re: [ibm-acpi-devel] ACPI: thinkpad-acpi: rename pci HID constant

2007-07-14 Thread Matthew Garrett
On Sat, Jul 14, 2007 at 11:12:04AM -0300, Henrique de Moraes Holschuh wrote: > - .hid = IBM_PCI_HID, > + /* THIS ONE MUST NEVER BE USED FOR DRIVER AUTOLOADING. Some rationale here would be good. There are no known devices where loading ibm-acpi is harmful. -- Matthew Garrett |

Re: [ibm-acpi-devel] ACPI: thinkpad-acpi: make the input event mode the default

2007-07-14 Thread Matthew Garrett
t. Why make things more difficult? -- Matthew Garrett | [EMAIL PROTECTED] - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just

Re: [ibm-acpi-devel] ACPI: thinkpad-acpi: add input device support to hotkey subdriver

2007-07-14 Thread Matthew Garrett
; + KEY_UNKNOWN,/* 0x12: FN+PGDOWN */ > + KEY_ZOOM, /* 0x13: FN+SPACE (zoom) */ > + KEY_RESERVED, /* 0x14: VOLUME UP */ KEY_VOLUMEUP > + KEY_RESERVED, /* 0x15: VOLUME DOWN */ KEY_VOLUMEDOWN > + KEY_RESERVED, /* 0x16: MUTE */ KEY_MUTE Why aren'

Re: [ibm-acpi-devel] nvram polling for hardware mixer

2007-06-15 Thread Matthew Garrett
ndow. I think tracking the keypresses is probably a great deal easier. -- Matthew Garrett | [EMAIL PROTECTED] - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take co

Re: [ibm-acpi-devel] nvram polling for hardware mixer

2007-06-15 Thread Matthew Garrett
On Fri, Jun 15, 2007 at 10:44:26AM -0300, Henrique de Moraes Holschuh wrote: > On Fri, 15 Jun 2007, Matthew Garrett wrote: > > This problem already has to be dealt with in brightness control, so I'd > > just send the keys. FWIW, it turns out that slaving the volume keys to &

Re: [ibm-acpi-devel] nvram polling for hardware mixer

2007-06-15 Thread Matthew Garrett
x27;s not "correct", but it's pretty close to the expected behaviour for the user. Sending the keys means it's easy to add information to hal and then update the existing code to take advantage of that, and d

  1   2   >