Re: [ibm-acpi-devel] [PATCH 6/7] thinkpad_acpi: More Carbon X1 2014 keys

2015-02-27 Thread Andy Lutomirski
On Mon, Feb 23, 2015 at 2:09 AM, Bastien Nocera wrote: > On Fri, 2015-02-20 at 11:27 -0800, Andy Lutomirski wrote: >> On 02/20/2015 06:44 AM, Bastien Nocera wrote: >> > + KEY_MICCANCEL_MODE, /* Microphone cancellation */ >> >> What's this? We already have KEY_MICMUTE. Is this differen

Re: [ibm-acpi-devel] [PATCH 6/7] thinkpad_acpi: More Carbon X1 2014 keys

2015-02-27 Thread Andy Lutomirski
On 02/20/2015 06:44 AM, Bastien Nocera wrote: > + KEY_MICCANCEL_MODE, /* Microphone cancellation */ What's this? We already have KEY_MICMUTE. Is this different? If so, can you improve the comment a bit? The answer may be obvious to anyone who has an awful X1 carbon gen 2 keyboar

Re: [ibm-acpi-devel] [PATCH 6/7] thinkpad_acpi: More Carbon X1 2014 keys

2015-02-23 Thread Bastien Nocera
On Fri, 2015-02-20 at 11:27 -0800, Andy Lutomirski wrote: > On 02/20/2015 06:44 AM, Bastien Nocera wrote: > > + KEY_MICCANCEL_MODE, /* Microphone cancellation */ > > What's this? We already have KEY_MICMUTE. Is this different? If so, > can you improve the comment a bit? I don't thi

[ibm-acpi-devel] [PATCH 6/7] thinkpad_acpi: More Carbon X1 2014 keys

2015-02-20 Thread Bastien Nocera
Add support for newly added evdev keycodes. Signed-off-by: Bastien Nocera --- drivers/platform/x86/thinkpad_acpi.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c index 57130a1..53