Re: [ibm-acpi-devel] [RFC PATCH] thinkpad-acpi: Improve hardware volume controls

2011-05-12 Thread Henrique de Moraes Holschuh
On Thu, 12 May 2011, Andrew Lutomirski wrote: > Still, someone who has an older laptop should test it, because all I > can do is pretend I carefully inspected all the possible code paths. Will do, will do. Please be patient. I will have thinkpad-acpi time this weekend :-) As you all noticed by

Re: [ibm-acpi-devel] [RFC PATCH] thinkpad-acpi: Improve hardware volume controls

2011-05-12 Thread Dmitry Torokhov
On Thu, May 12, 2011 at 03:33:54PM -0400, Andrew Lutomirski wrote: > On Thu, May 12, 2011 at 11:39 AM, Dmitry Torokhov > wrote: > > Hi Andrew, > > > > On Thu, May 12, 2011 at 10:50:54AM -0400, Andrew Lutomirski wrote: > >> > >> I do, however, have a question for the input people.  Dmitry: Lenovo >

Re: [ibm-acpi-devel] [RFC PATCH] thinkpad-acpi: Improve hardware volume controls

2011-05-12 Thread Andrew Lutomirski
On Thu, May 12, 2011 at 11:39 AM, Dmitry Torokhov wrote: > Hi Andrew, > > On Thu, May 12, 2011 at 10:50:54AM -0400, Andrew Lutomirski wrote: >> >> I do, however, have a question for the input people.  Dmitry: Lenovo >> makes laptops which are kind enough to tell us that the volume changed >> by se

Re: [ibm-acpi-devel] [RFC PATCH] thinkpad-acpi: Improve hardware volume controls

2011-05-12 Thread Andrew Lutomirski
On Thu, May 12, 2011 at 12:11 PM, Bruce Hill wrote: > On Thu, May 12, 2011 at 11:55:50AM -0400, Andrew Lutomirski wrote: >> >> Beats me.  I used cp to copy it, and it works here.  I don't see why >> rsync should be any different. >> >> --Andy > > Narry a day passeth but that some new learning expe

Re: [ibm-acpi-devel] [RFC PATCH] thinkpad-acpi: Improve hardware volume controls

2011-05-12 Thread Bruce Hill
On Thu, May 12, 2011 at 11:55:50AM -0400, Andrew Lutomirski wrote: > > Beats me. I used cp to copy it, and it works here. I don't see why > rsync should be any different. > > --Andy Narry a day passeth but that some new learning experience is pressed upon me: root@jeremiah /home/mingdao # rm

Re: [ibm-acpi-devel] [RFC PATCH] thinkpad-acpi: Improve hardware volume controls

2011-05-12 Thread Bruce Hill
On Thu, May 12, 2011 at 11:34:07AM -0400, Andrew Lutomirski wrote: > On Thu, May 12, 2011 at 11:30 AM, Bruce Hill wrote: > > On Thu, May 12, 2011 at 10:16:12AM -0400, Andrew Lutomirski wrote: > >> It's /sys/firmware/acpi/tables/DSDT > >> > >> If you're feeling fancy you can copy it somewhere and r

Re: [ibm-acpi-devel] [RFC PATCH] thinkpad-acpi: Improve hardware volume controls

2011-05-12 Thread Dmitry Torokhov
Hi Andrew, On Thu, May 12, 2011 at 10:50:54AM -0400, Andrew Lutomirski wrote: > > I do, however, have a question for the input people. Dmitry: Lenovo > makes laptops which are kind enough to tell us that the volume changed > by sending a keystroke over the atkbd-based keyboard. (wtf!) I've > m

Re: [ibm-acpi-devel] [RFC PATCH] thinkpad-acpi: Improve hardware volume controls

2011-05-12 Thread Andrew Lutomirski
On Thu, May 12, 2011 at 11:30 AM, Bruce Hill wrote: > On Thu, May 12, 2011 at 10:16:12AM -0400, Andrew Lutomirski wrote: >> It's /sys/firmware/acpi/tables/DSDT >> >> If you're feeling fancy you can copy it somewhere and run iasl -d on >> it, but the binary version will do. >> >> --Andy > > root@je

Re: [ibm-acpi-devel] [RFC PATCH] thinkpad-acpi: Improve hardware volume controls

2011-05-12 Thread Bruce Hill
On Thu, May 12, 2011 at 10:16:12AM -0400, Andrew Lutomirski wrote: > It's /sys/firmware/acpi/tables/DSDT > > If you're feeling fancy you can copy it somewhere and run iasl -d on > it, but the binary version will do. > > --Andy And btw ... I'm no the list. If you are, also, we can stop Cc'ing ;)

Re: [ibm-acpi-devel] [RFC PATCH] thinkpad-acpi: Improve hardware volume controls

2011-05-12 Thread Bruce Hill
On Thu, May 12, 2011 at 10:16:12AM -0400, Andrew Lutomirski wrote: > It's /sys/firmware/acpi/tables/DSDT > > If you're feeling fancy you can copy it somewhere and run iasl -d on > it, but the binary version will do. > > --Andy root@jeremiah ~ # iasl -d /sys/firmware/acpi/tables/DSDT Intel ACPI

Re: [ibm-acpi-devel] [RFC PATCH] thinkpad-acpi: Improve hardware volume controls

2011-05-12 Thread Andrew Lutomirski
[Hi, Dmitry -- there's an input layer question in here for you] On Thu, May 12, 2011 at 10:39 AM, Matthew Garrett wrote: > On Thu, May 12, 2011 at 10:24:10AM -0400, Andrew Lutomirski wrote: >> On Thu, May 12, 2011 at 9:48 AM, Matthew Garrett wrote: >> > It looks like SAUM was introduced with the

Re: [ibm-acpi-devel] [RFC PATCH] thinkpad-acpi: Improve hardware volume controls

2011-05-12 Thread Matthew Garrett
On Thu, May 12, 2011 at 10:24:10AM -0400, Andrew Lutomirski wrote: > On Thu, May 12, 2011 at 9:48 AM, Matthew Garrett wrote: > > It looks like SAUM was introduced with the *61 machines, and it's > > identical from then on. > > I wonder the machines with SAUM are the same as the machines on which

Re: [ibm-acpi-devel] [RFC PATCH] thinkpad-acpi: Improve hardware volume controls

2011-05-12 Thread Andrew Lutomirski
On Thu, May 12, 2011 at 9:48 AM, Matthew Garrett wrote: > On Mon, May 09, 2011 at 06:18:46PM -0400, Andy Lutomirski wrote: > >> Henrique, do you know of anywhere to find AML dumps from different models? >> It would be nice to see what SAUM looks like. > > It looks like SAUM was introduced with the

Re: [ibm-acpi-devel] [RFC PATCH] thinkpad-acpi: Improve hardware volume controls

2011-05-12 Thread Andrew Lutomirski
It's /sys/firmware/acpi/tables/DSDT If you're feeling fancy you can copy it somewhere and run iasl -d on it, but the binary version will do. --Andy On Thu, May 12, 2011 at 9:52 AM, Bruce Hill wrote: > On Thu, May 12, 2011 at 02:48:27PM +0100, Matthew Garrett wrote: >> On Mon, May 09, 2011 at 06

Re: [ibm-acpi-devel] [RFC PATCH] thinkpad-acpi: Improve hardware volume controls

2011-05-12 Thread Bruce Hill
On Thu, May 12, 2011 at 02:48:27PM +0100, Matthew Garrett wrote: > On Mon, May 09, 2011 at 06:18:46PM -0400, Andy Lutomirski wrote: > > > Henrique, do you know of anywhere to find AML dumps from different models? > > It would be nice to see what SAUM looks like. > > It looks like SAUM was introdu

Re: [ibm-acpi-devel] [RFC PATCH] thinkpad-acpi: Improve hardware volume controls

2011-05-12 Thread Matthew Garrett
On Mon, May 09, 2011 at 06:18:46PM -0400, Andy Lutomirski wrote: > Henrique, do you know of anywhere to find AML dumps from different models? > It would be nice to see what SAUM looks like. It looks like SAUM was introduced with the *61 machines, and it's identical from then on. -- Matthew Gar

Re: [ibm-acpi-devel] [RFC PATCH] thinkpad-acpi: Improve hardware volume controls

2011-05-10 Thread Andrew Lutomirski
On Tue, May 10, 2011 at 6:27 AM, Henrique de Moraes Holschuh wrote: > On Mon, 09 May 2011, Andrew Lutomirski wrote: >> I read some more of the spec.  It looks like the EC sends query 43 >> when the mute status changes. >> >> The problem is that _Q43 just calls _UCMS, which issues an SMI but >> doe

Re: [ibm-acpi-devel] [RFC PATCH] thinkpad-acpi: Improve hardware volume controls

2011-05-10 Thread Henrique de Moraes Holschuh
On Mon, 09 May 2011, Andrew Lutomirski wrote: > I read some more of the spec. It looks like the EC sends query 43 > when the mute status changes. > > The problem is that _Q43 just calls _UCMS, which issues an SMI but > does nothing else. So we don't get notified. And unless we change > acpi_ec_

Re: [ibm-acpi-devel] [RFC PATCH] thinkpad-acpi: Improve hardware volume controls

2011-05-10 Thread Henrique de Moraes Holschuh
On Mon, 09 May 2011, Andrew Lutomirski wrote: > > Don't we get an HKEY notification for mute presses in the X220? > > I just meant to figure out what's going on. We're not getting an HKEY > event, I think, but something's happening and a bit of acpi debug > fiddling says that _Q43 is getting call

Re: [ibm-acpi-devel] [RFC PATCH] thinkpad-acpi: Improve hardware volume controls

2011-05-09 Thread Andrew Lutomirski
On Mon, May 9, 2011 at 10:36 PM, Andrew Lutomirski wrote: > On Mon, May 9, 2011 at 9:04 PM, Henrique de Moraes Holschuh > wrote: >> On Mon, 09 May 2011, Andrew Lutomirski wrote: >>> FWIW, this patch (other than having the wrong default on X220) makes >>> Linux better than Windows :) >> >> Please

Re: [ibm-acpi-devel] [RFC PATCH] thinkpad-acpi: Improve hardware volume controls

2011-05-09 Thread Andrew Lutomirski
On Mon, May 9, 2011 at 9:04 PM, Henrique de Moraes Holschuh wrote: > On Mon, 09 May 2011, Andrew Lutomirski wrote: >> FWIW, this patch (other than having the wrong default on X220) makes >> Linux better than Windows :) > > Please expand on that, especially the "wrong default on X220"... > >> Do yo

Re: [ibm-acpi-devel] [RFC PATCH] thinkpad-acpi: Improve hardware volume controls

2011-05-09 Thread Henrique de Moraes Holschuh
On Mon, 09 May 2011, Andrew Lutomirski wrote: > FWIW, this patch (other than having the wrong default on X220) makes > Linux better than Windows :) Please expand on that, especially the "wrong default on X220"... > Do you know how to read a field from the EC by name? I think I can If it is in t

Re: [ibm-acpi-devel] [RFC PATCH] thinkpad-acpi: Improve hardware volume controls

2011-05-09 Thread Andrew Lutomirski
On Mon, May 9, 2011 at 7:53 PM, Henrique de Moraes Holschuh wrote: > Interesting.  Let me test it on my T43, it has hardware volume and seems to > cover a class of box you couldn't test. > > I like the idea, but I might have some questions to ask you about it.  More > on this after I test the patc

Re: [ibm-acpi-devel] [RFC PATCH] thinkpad-acpi: Improve hardware volume controls

2011-05-09 Thread Henrique de Moraes Holschuh
Interesting. Let me test it on my T43, it has hardware volume and seems to cover a class of box you couldn't test. I like the idea, but I might have some questions to ask you about it. More on this after I test the patch in the next few days. -- "One disk to rule them all, One disk to find t

[ibm-acpi-devel] [RFC PATCH] thinkpad-acpi: Improve hardware volume controls

2011-05-09 Thread Andy Lutomirski
ThinkPads have hardware volume controls and three buttons to control them. (These are separate from the standard mixer.) By default, the buttons are: - Mute: Mutes the hardware volume control and generates KEY_MUTE. - Up: Unmutes, generates KEY_VOLUMEUP, and increases volume if applicable.