Re: [infinispan-dev] Feedback and requests on clustered and remote listeners

2014-10-20 Thread Galder Zamarreño
Hi all, Thanks Will for implementing this. I’ve created [1] to investigate whether any changes would be required for Hot Rod remote listeners to take advantage of this. Cheers, [1] https://issues.jboss.org/browse/ISPN-4857 On 30 Sep 2014, at 18:13, William Burns mudokon...@gmail.com wrote:

Re: [infinispan-dev] Feedback and requests on clustered and remote listeners

2014-10-15 Thread Emmanuel Bernard
Sorry for the long delay. I looked at your PR early last week and it looked good to me. I think it might be slighly more efficient to offer a single contract that do both the filtering and the conversion (esp when one consider reading the value in raw protobuf and do the parsing once). But your

Re: [infinispan-dev] Feedback and requests on clustered and remote listeners

2014-10-15 Thread William Burns
On Wed, Oct 15, 2014 at 7:54 AM, Emmanuel Bernard emman...@hibernate.org wrote: Sorry for the long delay. I looked at your PR early last week and it looked good to me. I think it might be slighly more efficient to offer a single contract that do both the filtering and the conversion (esp when

Re: [infinispan-dev] Feedback and requests on clustered and remote listeners

2014-09-30 Thread William Burns
I have put it on a branch on github and you can try it out and let me know what you think. I still have a few things I may want to change though: 1. I don't like how pre events are yet as they don't give you the previous value and new value as post events do 2. The enum to tell the type has

Re: [infinispan-dev] Feedback and requests on clustered and remote listeners

2014-09-26 Thread Emmanuel Bernard
You lost me at actually ;) but if you have some code or even a gist showing how a user would use and interact with these changes, I can give you some feedback on the use cases I had in mind and if they fit. On 25 sept. 2014, at 15:20, William Burns mudokon...@gmail.com wrote: Actually

Re: [infinispan-dev] Feedback and requests on clustered and remote listeners

2014-09-24 Thread Galder Zamarreño
On 23 Sep 2014, at 19:02, William Burns mudokon...@gmail.com wrote: On Tue, Sep 23, 2014 at 12:20 PM, Galder Zamarreño gal...@redhat.com wrote: On 23 Sep 2014, at 14:53, Mircea Markus mmar...@redhat.com wrote: On Sep 23, 2014, at 15:18, Emmanuel Bernard emman...@hibernate.org wrote: I

Re: [infinispan-dev] Feedback and requests on clustered and remote listeners

2014-09-24 Thread Emmanuel Bernard
On 23 sept. 2014, at 18:17, Galder Zamarreño gal...@redhat.com wrote: On 18 Sep 2014, at 18:24, Emmanuel Bernard emman...@hibernate.org wrote: Hi all, I have had a good exchange on how someone would use clustered / remote listeners to do custom continuous query features. I have

Re: [infinispan-dev] Feedback and requests on clustered and remote listeners

2014-09-24 Thread Galder Zamarreño
On 23 Sep 2014, at 18:22, Galder Zamarreño gal...@redhat.com wrote: Hi Emmanuel, Apologies for the delay getting back on the topic. Replies below from the remote listeners POV... /snip Alternatively, could we pass the raw protobuf data to the KeyValueFilter and Converter? They

Re: [infinispan-dev] Feedback and requests on clustered and remote listeners

2014-09-23 Thread Emmanuel Bernard
On 22 sept. 2014, at 19:23, William Burns mudokon...@gmail.com wrote: On Fri, Sep 19, 2014 at 12:39 PM, Emmanuel Bernard emman...@hibernate.org wrote: On 19 Sep 2014, at 17:09, William Burns mudokon...@gmail.com wrote: Comments regarding embedded usage are inline. I am not quite

Re: [infinispan-dev] Feedback and requests on clustered and remote listeners

2014-09-23 Thread Mircea Markus
On Sep 23, 2014, at 16:27, Emmanuel Bernard emman...@hibernate.org wrote: On 23 Sep 2014, at 14:53, Mircea Markus mmar...@redhat.com wrote: On Sep 23, 2014, at 15:18, Emmanuel Bernard emman...@hibernate.org wrote: I am not sold on this as it seems pretty trivial to decipher which

Re: [infinispan-dev] Feedback and requests on clustered and remote listeners

2014-09-23 Thread Emmanuel Bernard
On 23 Sep 2014, at 15:42, William Burns mudokon...@gmail.com wrote: Reread the other email again and actually it could be used to show different permutations like the retry case (eq RETRIED_CREATE), but it seems like the code in that one method would get pretty complex pretty fast having to

Re: [infinispan-dev] Feedback and requests on clustered and remote listeners

2014-09-23 Thread Galder Zamarreño
On 22 Sep 2014, at 19:23, William Burns mudokon...@gmail.com wrote: On Fri, Sep 19, 2014 at 12:39 PM, Emmanuel Bernard emman...@hibernate.org wrote: On 19 Sep 2014, at 17:09, William Burns mudokon...@gmail.com wrote: /snip At any rate the programming model becomes quite awkward and

Re: [infinispan-dev] Feedback and requests on clustered and remote listeners

2014-09-23 Thread William Burns
On Tue, Sep 23, 2014 at 12:12 PM, Galder Zamarreño gal...@redhat.com wrote: On 22 Sep 2014, at 19:23, William Burns mudokon...@gmail.com wrote: On Fri, Sep 19, 2014 at 12:39 PM, Emmanuel Bernard emman...@hibernate.org wrote: On 19 Sep 2014, at 17:09, William Burns mudokon...@gmail.com

Re: [infinispan-dev] Feedback and requests on clustered and remote listeners

2014-09-22 Thread William Burns
On Fri, Sep 19, 2014 at 12:39 PM, Emmanuel Bernard emman...@hibernate.org wrote: On 19 Sep 2014, at 17:09, William Burns mudokon...@gmail.com wrote: Comments regarding embedded usage are inline. I am not quite sure on the hot rod client ones. On Thu, Sep 18, 2014 at 12:24 PM, Emmanuel

[infinispan-dev] Feedback and requests on clustered and remote listeners

2014-09-18 Thread Emmanuel Bernard
Hi all, I have had a good exchange on how someone would use clustered / remote listeners to do custom continuous query features. I have a few questions and requests to make this fully and easily doable ## Value as bytes or as objects Assuming a Hot Rod based usage and protobuf as the