On Tue, May 05, 2015 at 10:11:09AM +0200, David Caro wrote:
On 05/05, Max Kovgan wrote:
hi, Dan.
makes sense to me to focus on 2 use cases:
- pre-commit hook running everything jenkins is running - locally
Maybe pre-push instead, that will leverage a bit the local work
- pros:
On 05/05, Dan Kenigsberg wrote:
On Tue, May 05, 2015 at 10:11:09AM +0200, David Caro wrote:
On 05/05, Max Kovgan wrote:
hi, Dan.
makes sense to me to focus on 2 use cases:
- pre-commit hook running everything jenkins is running - locally
Maybe pre-push instead, that will leverage a
On 05/05, Max Kovgan wrote:
hi, Dan.
makes sense to me to focus on 2 use cases:
- pre-commit hook running everything jenkins is running - locally
Maybe pre-push instead, that will leverage a bit the local work
- pros:
- nearly identical checks/tests jenkins would running
-
On Tue, May 05, 2015 at 05:18:00PM +0200, David Caro wrote:
On 05/05, Dan Kenigsberg wrote:
On Tue, May 05, 2015 at 10:11:09AM +0200, David Caro wrote:
On 05/05, Max Kovgan wrote:
hi, Dan.
makes sense to me to focus on 2 use cases:
- pre-commit hook running everything jenkins is
hi, Dan.
makes sense to me to focus on 2 use cases:
- pre-commit hook running everything jenkins is running - locally
- pros:
- nearly identical checks/tests jenkins would running
- doesn't care about IDE/editor
- cons:
- slower
- can be annoying to commit (locally)
patch https://gerrit.ovirt.org/#/c/40346/ broke oVirt vdsm
jobs
On Wed, Apr 29, 2015 at 11:16:37AM -0400, Barak Korren wrote:
Patch does not pass pyflakes:
./tests/samplingTests.py:30: 'libvirtconnection' imported but unused
./tests/samplingTests.py:36: 'MonkeyPatch' imported but unused
On Wed, Apr 29, 2015 at 11:16:37AM -0400, Barak Korren wrote:
Patch does not pass pyflakes:
./tests/samplingTests.py:30: 'libvirtconnection' imported but unused
./tests/samplingTests.py:36: 'MonkeyPatch' imported but unused
make: *** [pyflakes] Error 1
You could clearly see that the tests
