Please review: MBS platform definition for EPEL8

2019-09-10 Thread Merlin Mathesius
Please review the attached patch to add a new file to https://infrastructure.fedoraproject.org/cgit/ansible.git/. This patch provides a new platform:el8 default module definition so fm-orchestrator knows about EPEL8. Some review and discussion has already taken place at https://pagure.io/Fedora-In

Re: Please review: MBS platform definition for EPEL8

2019-09-10 Thread Troy Dawson
On Tue, Sep 10, 2019 at 1:59 PM Merlin Mathesius wrote: > > Please review the attached patch to add a new file to > https://infrastructure.fedoraproject.org/cgit/ansible.git/. > > This patch provides a new platform:el8 default module definition so > fm-orchestrator knows about EPEL8. Some review

Re: Please review: MBS platform definition for EPEL8

2019-09-11 Thread Kevin Fenzi
On 9/10/19 1:57 PM, Merlin Mathesius wrote: > Please review the attached patch to add a new file to > https://infrastructure.fedoraproject.org/cgit/ansible.git/. > > This patch provides a new platform:el8 default module definition so > fm-orchestrator knows about EPEL8. Some review and discussion

Re: Please review: MBS platform definition for EPEL8

2019-09-20 Thread Stephen Gallagher
On Wed, Sep 11, 2019 at 1:38 PM Kevin Fenzi wrote: > > On 9/10/19 1:57 PM, Merlin Mathesius wrote: > > Please review the attached patch to add a new file to > > https://infrastructure.fedoraproject.org/cgit/ansible.git/. > > > > This patch provides a new platform:el8 default module definition so >

Re: Please review: MBS platform definition for EPEL8

2019-09-20 Thread Merlin Mathesius
On Fri, Sep 20, 2019 at 11:28 AM Stephen Gallagher wrote: > On Wed, Sep 11, 2019 at 1:38 PM Kevin Fenzi wrote: > > > > On 9/10/19 1:57 PM, Merlin Mathesius wrote: > > > Please review the attached patch to add a new file to > > > https://infrastructure.fedoraproject.org/cgit/ansible.git/. > > > >

Re: Please review: MBS platform definition for EPEL8

2019-09-30 Thread Merlin Mathesius
On Fri, Sep 20, 2019 at 12:01 PM Merlin Mathesius wrote: > > > On Fri, Sep 20, 2019 at 11:28 AM Stephen Gallagher > wrote: > >> On Wed, Sep 11, 2019 at 1:38 PM Kevin Fenzi wrote: >> > >> > On 9/10/19 1:57 PM, Merlin Mathesius wrote: >> > > Please review the attached patch to add a new file to >

Re: Please review: MBS platform definition for EPEL8

2019-10-01 Thread Kevin Fenzi
On Mon, Sep 30, 2019 at 02:14:14PM -0500, Merlin Mathesius wrote: > Hi, all, > > Since folks seem to be happy with the el8 platform virtual module > definitions, can they be merged and deployed to staging--or does something > else need to happen first? (Of course, any module builds based on > plat

Re: Please review: MBS platform definition for EPEL8

2019-10-02 Thread Merlin Mathesius
Hi, Matt, Jan, Could one of you provide some input here? We're looking to add the virtual platform module definitions for EPEL-8 to Fedora staging MBS. Is there anything specific that needs to happen before merging and deploying them? If you'd like to review the definitions, the patches are re-a

Re: Please review: MBS platform definition for EPEL8

2019-10-02 Thread Matt Prahl
Hi Merlin, I can't think of anything that you need to do before merging and deploying them as long as the Koji tags mentioned in the modulemd files are all set. On Wed, Oct 2, 2019 at 12:12 PM Merlin Mathesius wrote: > Hi, Matt, Jan, > > Could one of you provide some input here? > > We're lookin

Re: Please review: MBS platform definition for EPEL8

2019-10-02 Thread Merlin Mathesius
On Wed, Oct 2, 2019 at 12:41 PM Matt Prahl wrote: > Hi Merlin, > I can't think of anything that you need to do before merging and deploying > them as long as the Koji tags mentioned in the modulemd files are all set. > Of course. We need the module-el8-build and module-el8-playground-build tags.

Re: Please review: MBS platform definition for EPEL8

2019-10-24 Thread Merlin Mathesius
Now that the build tags have been created (thanks, Mohan!), we should be ready to add the virtual platform module definitions for EPEL-8 to Fedora staging MBS. I have attached a revised patch that includes both the el8 and el8-playground definitions in a single patch file. Aside from the combined

Re: Please review: MBS platform definition for EPEL8

2019-10-24 Thread Mohan Boddu
Hi, I created the tags as module-epel8-build and module-epel8-playground-build just to be consistent with the naming, so you need to change the config for koji_tag part. And may be also change the "stream" in the yaml file to epel8 and epel8-playground and change the name of the platform to platf

Re: Please review: MBS platform definition for EPEL8

2019-10-24 Thread Merlin Mathesius
On Thu, Oct 24, 2019 at 3:32 PM Mohan Boddu wrote: > Hi, > > I created the tags as module-epel8-build and > module-epel8-playground-build just to be consistent with the naming, so you > need to change the config for koji_tag part. > > And may be also change the "stream" in the yaml file to epel8

Re: Please review: MBS platform definition for EPEL8

2019-10-24 Thread Mohan Boddu
Thanks for the info, I renamed the tags and updated the tickets. Why is naming so hard? On Thu, Oct 24, 2019 at 4:58 PM Merlin Mathesius wrote: > > > On Thu, Oct 24, 2019 at 3:32 PM Mohan Boddu wrote: > >> Hi, >> >> I created the tags as module-epel8-build and >> module-epel8-playground-build

Re: Please review: MBS platform definition for EPEL8

2019-10-24 Thread Merlin Mathesius
On Thu, Oct 24, 2019 at 4:51 PM Mohan Boddu wrote: > Thanks for the info, I renamed the tags and updated the tickets. > Thank you for noticing the discrepancy and making the corrections. Now we should definitely be good to import the virtual module definitions. Why is naming so hard? > Becaus