[Intel-gfx] [PATCH] drm/i915: Add a dual link lvds quirk for MacBook Pro 8, 2

2012-03-27 Thread Daniel Vetter
When booting with EFI, Apple botched this one up. Tested-by: Austin Lund Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=42842 Signed-Off-by: Daniel Vetter --- drivers/gpu/drm/i915/intel_display.c | 22 ++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --git

Re: [Intel-gfx] [PATCH v2 3/3] tests: rc6 residency test

2012-03-27 Thread Daniel Vetter
On Mon, Mar 26, 2012 at 02:54:35PM -0700, Ben Widawsky wrote: > On Mon, 26 Mar 2012 11:40:55 +0200 > Daniel Vetter wrote: > > > On Mon, Mar 26, 2012 at 11:37:13AM +0200, Daniel Vetter wrote: > > > On Sun, Mar 25, 2012 at 05:33:32PM -0700, Ben Widawsky wrote: > > > > This is meant to test the sysf

[Intel-gfx] [PATCH] drm/i915: apply CS reg readback trick against missed IRQ on snb

2012-03-27 Thread Daniel Vetter
Ben Widawsky reported missed IRQ issues and this patch here helps. We have one other missed IRQ report still left on snb, reported by QA: https://bugs.freedesktop.org/show_bug.cgi?id=46145 This is _not_ a regression due to the forcewake voodoo though, it started showing up before that was applie

Re: [Intel-gfx] [PATCH v2 3/3] tests: rc6 residency test

2012-03-27 Thread Daniel Vetter
On Sun, Mar 25, 2012 at 05:33:32PM -0700, Ben Widawsky wrote: > +int main(int argc, char *argv[]) > +{ > + const int device = drm_get_card(0); > + char *path, *pathp, *pathpp; > + int fd, ret; > + unsigned int value1, value1p, value1pp, value2, value2p, value2pp; > + int diff; >

Re: [Intel-gfx] i915_driver_irq_handler: irq 42: nobody cared

2012-03-27 Thread Daniel Vetter
On Tue, Mar 27, 2012 at 10:40:03AM +0200, Jiri Slaby wrote: > Hi, > > I'm getting spurious interrupts leading to disabling the interrupt: > 42:19168532471662 PCI-MSI-edge i915@pci::00:02.0 > > The message: > irq 42: nobody cared (try booting with the "irqpoll" option) > Pid: 2

Re: [Intel-gfx] [PATCH] drm/i915: reinstate GM45 TV detection fix

2012-03-27 Thread Daniel Vetter
On Tue, Mar 27, 2012 at 12:03:29PM +0100, Peter Clifton wrote: > On Mon, 2012-03-26 at 15:57 -0300, Rodrigo Vivi wrote: > > The GM45 with tv-out is so rare machine that I never found one to test > > if this really cause regression and complete disable tv-out on gm45 so > > I'm in favor of apply thi

Re: [Intel-gfx] [PATCH 2/3] drm/i915: the intel gtt is _not_ an agp bridge!

2012-03-27 Thread Daniel Vetter
On Mon, Mar 26, 2012 at 09:49:36AM +0100, Chris Wilson wrote: > On Mon, 26 Mar 2012 09:45:41 +0200, Daniel Vetter > wrote: > > So don't call it like that. > > > > Also rip out a confusing comment and instead explain what's really > > going on. > > > > Signed-Off-by: Daniel Vetter > > --- > > +

Re: [Intel-gfx] [PATCH] drm/i915: Avoid using mappable space for relocation processing through the CPU

2012-03-27 Thread Daniel Vetter
On Mon, Mar 26, 2012 at 09:32:52AM +0100, Chris Wilson wrote: > On Mon, 26 Mar 2012 10:10:27 +0200, Daniel Vetter > wrote: > > From: Chris Wilson > > > > We try to avoid writing the relocations through the uncached GTT, if the > > buffer is currently in the CPU write domain and so will be flush

Re: [Intel-gfx] [PATCH] drm/i915: reinstate GM45 TV detection fix

2012-03-27 Thread Peter Clifton
On Mon, 2012-03-26 at 15:57 -0300, Rodrigo Vivi wrote: > The GM45 with tv-out is so rare machine that I never found one to test > if this really cause regression and complete disable tv-out on gm45 so > I'm in favor of apply this and when we find some one with gm45 > complaining about the tv-out no

Re: [Intel-gfx] [PATCH] mm: extend prefault helpers to fault in more than PAGE_SIZE

2012-03-27 Thread Daniel Vetter
On Thu, Mar 01, 2012 at 12:15:57PM -0800, Andrew Morton wrote: > On Thu, 1 Mar 2012 20:22:59 +0100 > Daniel Vetter wrote: > > > drm/i915 wants to read/write more than one page in its fastpath > > and hence needs to prefault more than PAGE_SIZE bytes. > > > > Add new functions in filemap.h to ma

Re: [Intel-gfx] [PATCH 16/16] drm/i915: mark pwrite/pread slowpaths with unlikely

2012-03-27 Thread Daniel Vetter
On Mon, Mar 26, 2012 at 10:09:41AM +0100, Chris Wilson wrote: > On Sun, 25 Mar 2012 19:47:43 +0200, Daniel Vetter > wrote: > > Beside helping the compiler untangle this maze they double-up as > > documentation for which a parts aren't performance-critical but just > > around to keep old (but alre

Re: [Intel-gfx] [PATCH 11/37] drm/i915: add definition of DDI buffer translations regs

2012-03-27 Thread Daniel Vetter
On Wed, Mar 21, 2012 at 10:09:46PM -0300, Eugeni Dodonov wrote: > Those registers are used to train DDI buffer translations for each link > type. > > Signed-off-by: Eugeni Dodonov some quick private discussion releaved that the A-E in these defines are also per-port. So I think we also need to r

[Intel-gfx] [RFC] algorithm for handling bad cachelines

2012-03-27 Thread Ben Widawsky
I wanted to run this by folks before I start doing any actual work. This is primarily for GPGPU, or perhaps *really* accurate rendering requirements. IVB+ has an interrupt to tell us when a cacheline seems to be going bad. There is also a mechanism to remap the bad cachelines. The implementation

Re: [Intel-gfx] [RFC] algorithm for handling bad cachelines

2012-03-27 Thread Chris Wilson
On Tue, 27 Mar 2012 07:19:43 -0700, Ben Widawsky wrote: > Any feedback is highly appreciated. I couldn't really find much > precedent for doing this in other drivers, so pointers to similar > things would also be highly welcome. badblocks and badram (memmap) both seem to be similar situations. A

Re: [Intel-gfx] [RFC] algorithm for handling bad cachelines

2012-03-27 Thread Daniel Vetter
On Tue, Mar 27, 2012 at 07:19:43AM -0700, Ben Widawsky wrote: > I wanted to run this by folks before I start doing any actual work. > > This is primarily for GPGPU, or perhaps *really* accurate rendering > requirements. > > IVB+ has an interrupt to tell us when a cacheline seems to be going bad.

Re: [Intel-gfx] [RFC] algorithm for handling bad cachelines

2012-03-27 Thread Ben Widawsky
On Tue, 27 Mar 2012 16:50:39 +0200 Daniel Vetter wrote: > On Tue, Mar 27, 2012 at 07:19:43AM -0700, Ben Widawsky wrote: > > I wanted to run this by folks before I start doing any actual work. > > > > This is primarily for GPGPU, or perhaps *really* accurate rendering > > requirements. > > > > I

Re: [Intel-gfx] [RFC] algorithm for handling bad cachelines

2012-03-27 Thread Daniel Vetter
On Tue, Mar 27, 2012 at 08:09:31AM -0700, Ben Widawsky wrote: > On Tue, 27 Mar 2012 16:50:39 +0200 > Daniel Vetter wrote: > > > On Tue, Mar 27, 2012 at 07:19:43AM -0700, Ben Widawsky wrote: > > > I wanted to run this by folks before I start doing any actual work. > > > > > > This is primarily fo

Re: [Intel-gfx] [PATCH] drm/i915: Initialise GTT MTRR to -1

2012-03-27 Thread Ben Widawsky
On Fri, 23 Mar 2012 11:45:57 -0700 Ben Widawsky wrote: > On Fri, 23 Mar 2012 17:38:49 + > Chris Wilson wrote: > > > Fixes a regression from 9e984bc1 (drm/i915: Don't do MTRR setup if > > PAT is enabled) where we left the MTRR as 0 and so tried to free a > > MTRR we did not own during unload

[Intel-gfx] [PATCH 1/2] drm/i915: add rc6 residency times to debugfs

2012-03-27 Thread Ben Widawsky
RC6 residency should be in intervals of 1.28us, and the counter wraps. Here is an example using awk to get the various RC6 and RC6+ residency times in seconds, since boot. cat /sys/kernel/debug/dri/0/i915_drpc_info | grep residency | awk -F':' -F' ' '{print $5 * 1.28 / 100}' This is primar

[Intel-gfx] [PATCH 2/2] drm/i915: rc6 in sysfs

2012-03-27 Thread Ben Widawsky
Merge rc6 information into the power group for our device. Until now the i915 driver has not had any sysfs entries (aside from the connector stuff enabled by drm core). Since it seems like we're likely to have more in the future I created a new file for sysfs stubs, as well as the rc6 sysfs functio

[Intel-gfx] [PATCH 1/3] build: make sure we have asprintf

2012-03-27 Thread Ben Widawsky
Signed-off-by: Ben Widawsky --- configure.ac |2 ++ 1 file changed, 2 insertions(+) diff --git a/configure.ac b/configure.ac index f778a9a..567f10d 100644 --- a/configure.ac +++ b/configure.ac @@ -32,6 +32,7 @@ AC_CONFIG_MACRO_DIR([m4]) AC_CONFIG_AUX_DIR([build-aux]) AC_USE_SYSTEM_EXTENSIO

[Intel-gfx] [PATCH 2/3] drm/i915: extract card getting

2012-03-27 Thread Ben Widawsky
Signed-off-by: Ben Widawsky --- lib/drmtest.c | 122 +++-- 1 file changed, 83 insertions(+), 39 deletions(-) diff --git a/lib/drmtest.c b/lib/drmtest.c index f9b7a6f..063b5c5 100644 --- a/lib/drmtest.c +++ b/lib/drmtest.c @@ -26,6 +26,8 @@ *

[Intel-gfx] [PATCH] tests: rc6 residency test

2012-03-27 Thread Ben Widawsky
This is meant to test the sysfs entry for showing rc6 residency in milliseconds. Remember, sysfs is a permanent interface. v2: use new get_card interface to try "all" devices check rc6p and rc6pp in addition to rc6 v3: rename rc6_residency.c to sysfs_rc6_residency.c print better error messages sk

Re: [Intel-gfx] [PATCH] drm/i915: properly restore the ppgtt page directory on resume

2012-03-27 Thread Ben Widawsky
On Thu, 22 Mar 2012 00:14:43 +0100 Daniel Vetter wrote: > The ppgtt page directory lives in a snatched part of the gtt pte > range. Which naturally gets cleared on hibernate when we pull the > power. Suspend to ram (which is what I've tested) works because > despite the fact that this is a mmio r

Re: [Intel-gfx] [PATCH] tests: rc6 residency test

2012-03-27 Thread Ben Widawsky
On Tue, 27 Mar 2012 18:59:42 -0700 Ben Widawsky wrote: > This is meant to test the sysfs entry for showing rc6 residency in > milliseconds. Remember, sysfs is a permanent interface. > > v2: use new get_card interface to try "all" devices > check rc6p and rc6pp in addition to rc6 > > v3: rename