Re: [Intel-gfx] Updated -next

2012-03-29 Thread Sun, Yi
Hi all, We finished new round Kernel testing. We covered both mobile and desktop machines on platforms IVB, SNB, ILK, GM965 and PNV. The Kernel the latest on -testing branch Daniel's tree: commit 0028cac2e9e91961384ac15aae4196eee0faf4f6 Merge: 121d527 b250da7 Author: Daniel Vetter

Re: [Intel-gfx] [PATCH 02/18] drm/i915: preliminary context support

2012-03-29 Thread Daniel Vetter
On Wed, Mar 28, 2012 at 03:59:17PM -0700, Ben Widawsky wrote: On Thu, 29 Mar 2012 00:43:00 +0200 Daniel Vetter dan...@ffwll.ch wrote: On Sun, Mar 18, 2012 at 01:39:42PM -0700, Ben Widawsky wrote: Very basic code for context setup/destruction in the driver. There are 4 entry points

Re: [Intel-gfx] [PATCH 04/18] drm/i915: add context information to objects

2012-03-29 Thread Daniel Vetter
On Wed, Mar 28, 2012 at 05:20:11PM -0700, Ben Widawsky wrote: On Thu, 29 Mar 2012 00:36:21 +0200 Daniel Vetter dan...@ffwll.ch wrote: On Sun, Mar 18, 2012 at 01:39:44PM -0700, Ben Widawsky wrote: Handy mostly for assertions. Signed-off-by: Ben Widawsky b...@bwidawsk.net I

Re: [Intel-gfx] [PATCH 0/2] semaphorify the pageflip BO (if possible)

2012-03-29 Thread Daniel Vetter
On Wed, Mar 28, 2012 at 05:23:08PM -0700, Ben Widawsky wrote: Daniel, how do you want to handle this? It's somewhere on my list of things to do. I'd like to play around with this on my ivb first just to see what's going on, but otherwise nothing to complain about here. Yours, Daniel On Wed,

Re: [Intel-gfx] ValleyView patches

2012-03-29 Thread Daniel Vetter
On Wed, Mar 28, 2012 at 01:39:20PM -0700, Jesse Barnes wrote: Updated patchset addressing comments. I dropped some: - display reg offset (we're going to fix this up differently) - cache handling (not needed) along with the ones Daniel has already queued. Hopefully these ones look ok to

Re: [Intel-gfx] Broken LVDS output at mode changes

2012-03-29 Thread Daniel Vetter
On Wed, Mar 28, 2012 at 03:29:04PM +0200, Takashi Iwai wrote: Hi, we've encountered a broken LVDS output on some IVY/SNB machines when the mode is changed (from/to native resolution). When this happens, the whole laptop panel gets half white and half black. This doesn't recover until the

Re: [Intel-gfx] Broken LVDS output at mode changes

2012-03-29 Thread Chris Wilson
On Thu, 29 Mar 2012 14:16:38 +0200, Daniel Vetter dan...@ffwll.ch wrote: On Wed, Mar 28, 2012 at 03:29:04PM +0200, Takashi Iwai wrote: Hi, we've encountered a broken LVDS output on some IVY/SNB machines when the mode is changed (from/to native resolution). When this happens, the whole

Re: [Intel-gfx] Broken LVDS output at mode changes

2012-03-29 Thread Daniel Vetter
On Thu, Mar 29, 2012 at 01:44:28PM +0100, Chris Wilson wrote: On Thu, 29 Mar 2012 14:16:38 +0200, Daniel Vetter dan...@ffwll.ch wrote: On Wed, Mar 28, 2012 at 03:29:04PM +0200, Takashi Iwai wrote: Hi, we've encountered a broken LVDS output on some IVY/SNB machines when the mode is

Re: [Intel-gfx] OpenGL Extension support on IVY Bridge

2012-03-29 Thread Cheah, Douglas
Thanks Kenneth. There isn't a specific extension that I am looking at now. I was hoping for reference list to check what the extension details on what has been accelerated, punted to fallback or like the GetGraphicResetStatus() case implemented as a noop on Ivy Bridge. Right now my best

Re: [Intel-gfx] Broken LVDS output at mode changes

2012-03-29 Thread Takashi Iwai
At Thu, 29 Mar 2012 14:51:32 +0200, Daniel Vetter wrote: On Thu, Mar 29, 2012 at 01:44:28PM +0100, Chris Wilson wrote: On Thu, 29 Mar 2012 14:16:38 +0200, Daniel Vetter dan...@ffwll.ch wrote: On Wed, Mar 28, 2012 at 03:29:04PM +0200, Takashi Iwai wrote: Hi, we've encountered a

Re: [Intel-gfx] Broken LVDS output at mode changes

2012-03-29 Thread Keith Packard
#part sign=pgpmime On Thu, 29 Mar 2012 13:44:28 +0100, Chris Wilson ch...@chris-wilson.co.uk wrote: In conjunction with bits Power Sequence Progress field and Power Cycle Delay Active, this bit set to a one indicates that the panel is currently powered up or is currently in the power down

[Intel-gfx] [PATCH 00/41] [RFC] Haswell v2

2012-03-29 Thread Eugeni Dodonov
This is an updated set of patches for Haswell enablement. I tried to address all the comments, and re-diffed the patches to simplify their inclusion into Daniel's tree. I have also split the PCI IDs definitions and their hook-up into the binding tables as well. But I think we should wait on

[Intel-gfx] [PATCH 01/41] drm/i915: transform HAS_PCH_SPLIT in a feature check

2012-03-29 Thread Eugeni Dodonov
The macro is becoming too complex and with VLV upon us it can lead to confusion. So transforming this into a feature check instead. Signed-off-by: Eugeni Dodonov eugeni.dodo...@intel.com --- drivers/gpu/drm/i915/i915_drv.c |6 ++ drivers/gpu/drm/i915/i915_drv.h |3 ++- 2 files

[Intel-gfx] [PATCH 02/41] drm/i915: add Haswell devices and their PCI IDs

2012-03-29 Thread Eugeni Dodonov
This adds product definitions for desktop, mobile and server boards. v2: split into a separate patch, add .has_pch_split feature. Signed-off-by: Eugeni Dodonov eugeni.dodo...@intel.com --- drivers/char/agp/intel-agp.h| 11 +++ drivers/char/agp/intel-gtt.c| 14 ++

[Intel-gfx] [PATCH 03/41] drm/i915: hook Haswell devices in place

2012-03-29 Thread Eugeni Dodonov
This patch enabled i915 driver to handle Haswell devices. It should go in last, when things are working stable enough. Signed-off-by: Eugeni Dodonov eugeni.dodo...@intel.com --- drivers/char/agp/intel-agp.c|4 drivers/gpu/drm/i915/i915_drv.c |7 +++ 2 files changed, 11

[Intel-gfx] [PATCH 04/41] drm/i915: add support for LynxPoint PCH

2012-03-29 Thread Eugeni Dodonov
Reviewed-by: Rodrigo Vivi rodrigo.v...@intel.com Signed-off-by: Eugeni Dodonov eugeni.dodo...@intel.com --- drivers/gpu/drm/i915/i915_drv.c |4 drivers/gpu/drm/i915/i915_drv.h |2 ++ 2 files changed, 6 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_drv.c

[Intel-gfx] [PATCH 05/41] drm/i915: add support for power wells

2012-03-29 Thread Eugeni Dodonov
This defines the registers used by different power wells. Reviewed-by: Rodrigo Vivi rodrigo.v...@intel.com Signed-off-by: Eugeni Dodonov eugeni.dodo...@intel.com --- drivers/gpu/drm/i915/i915_reg.h | 13 + 1 file changed, 13 insertions(+) diff --git

[Intel-gfx] [PATCH 06/41] drm/i915: add enumeration for DDI ports

2012-03-29 Thread Eugeni Dodonov
There are 5 DDI ports on Haswell. Port A is always enabled, and is the one connected to eDP, and Port E is the one that can be connected to the PCH using FDI protocol. Ports B, C, D and E can be used for digital outputs. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch Signed-off-by: Eugeni

[Intel-gfx] [PATCH 07/41] drm/i915: add DDI registers

2012-03-29 Thread Eugeni Dodonov
There is one set of such registers for each pipe (A/B/C/EDP). v2: update to use DDI PORTS enum v1 Reviewed-by: Rodrigo Vivi rodrigo.v...@intel.com Signed-off-by: Eugeni Dodonov eugeni.dodo...@intel.com --- drivers/gpu/drm/i915/i915_reg.h | 26 ++ 1 file changed, 26

[Intel-gfx] [PATCH 08/41] drm/i915: add DP_TP_CTL registers

2012-03-29 Thread Eugeni Dodonov
This is one set of those registers for each pipe. v2: use port enum to access individual registers Signed-off-by: Eugeni Dodonov eugeni.dodo...@intel.com --- drivers/gpu/drm/i915/i915_reg.h | 16 1 file changed, 16 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h

[Intel-gfx] [PATCH 09/41] drm/i915: add DP_TP_STATUS registers

2012-03-29 Thread Eugeni Dodonov
There is one set of those registers for each port. Signed-off-by: Eugeni Dodonov eugeni.dodo...@intel.com --- drivers/gpu/drm/i915/i915_reg.h |8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 627e52d..666e319

Re: [Intel-gfx] [PATCH 04/18] drm/i915: add context information to objects

2012-03-29 Thread Ben Widawsky
On Thu, 29 Mar 2012 10:47:56 +0200 Daniel Vetter dan...@ffwll.ch wrote: On Wed, Mar 28, 2012 at 05:20:11PM -0700, Ben Widawsky wrote: On Thu, 29 Mar 2012 00:36:21 +0200 Daniel Vetter dan...@ffwll.ch wrote: On Sun, Mar 18, 2012 at 01:39:44PM -0700, Ben Widawsky wrote: Handy mostly

[Intel-gfx] [PATCH 26/41] drm/i915: reuse Ivybridge interrupts code for Haswell

2012-03-29 Thread Eugeni Dodonov
v2: prevent possible conflicts with VLV. v1 Reviewed-by: Rodrigo Vivi rodrigo.v...@gmail.com Signed-off-by: Eugeni Dodonov eugeni.dodo...@intel.com --- drivers/gpu/drm/i915/i915_irq.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c

[Intel-gfx] [PATCH 24/41] drm/i915: share forcewaking code between IVB and HSW

2012-03-29 Thread Eugeni Dodonov
Reviewed-by: Rodrigo Vivi rodrigo.v...@gmail.com Signed-off-by: Eugeni Dodonov eugeni.dodo...@intel.com --- drivers/gpu/drm/i915/intel_display.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c

[Intel-gfx] [PATCH 14/41] drm/i915: add support for SBI ops

2012-03-29 Thread Eugeni Dodonov
With Lynx Point, we need to use SBI to communicate with the display clock control. This commit adds helper functions to access the registers via SBI. v2: de-inline the function and address changes in bits names v1 Reviewed-by: Rodrigo Vivi rodrigo.v...@gmail.com Signed-off-by: Eugeni Dodonov

[Intel-gfx] [PATCH 29/41] drm/i915: show unknown sdvox registers on hdmi init

2012-03-29 Thread Eugeni Dodonov
Signed-off-by: Eugeni Dodonov eugeni.dodo...@intel.com --- drivers/gpu/drm/i915/intel_hdmi.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c index cae3e5f..de54c01 100644 --- a/drivers/gpu/drm/i915/intel_hdmi.c +++

[Intel-gfx] [PATCH 40/41] drm/i915: prepare HDMI link for Haswell

2012-03-29 Thread Eugeni Dodonov
On Haswell, we need to properly train the DDI buffers prior to enabling HDMI. Note that we do enable the DDI Function for the corresponding pipe, in a similar fashion as we do with FDI. This ensures that the pipe DDI transport is left in a almost-ready state, and we only need to enable the pipe

[Intel-gfx] [PATCH 35/41] drm/i915: disable pipe DDI function when disabling pipe

2012-03-29 Thread Eugeni Dodonov
Signed-off-by: Eugeni Dodonov eugeni.dodo...@intel.com --- drivers/gpu/drm/i915/intel_display.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 09c18f8..0324250 100644 ---

[Intel-gfx] [PATCH 39/41] drm/i915: add support for DDI-controlled digital outputs

2012-03-29 Thread Eugeni Dodonov
Those are driven by DDIs on Haswell architecture, so we need to keep track of which DDI is being used on each output. Signed-off-by: Eugeni Dodonov eugeni.dodo...@intel.com --- drivers/gpu/drm/i915/intel_hdmi.c | 19 +++ 1 file changed, 19 insertions(+) diff --git

[Intel-gfx] [PATCH 23/41] drm/i915: calculate same watermarks on Haswell as on Ivy Bridge

2012-03-29 Thread Eugeni Dodonov
Signed-off-by: Eugeni Dodonov eugeni.dodo...@intel.com --- drivers/gpu/drm/i915/intel_display.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 8e5f5be..5e226ad 100644 ---

[Intel-gfx] [PATCH 31/41] drm/i915: disable rc6 on haswell for now

2012-03-29 Thread Eugeni Dodonov
This needs proper enablement to avoid machine hangs, so let's just avoid it for now. Reviewed-by: Rodrigo Vivi rodrigo.v...@gmail.com Signed-off-by: Eugeni Dodonov eugeni.dodo...@intel.com --- drivers/gpu/drm/i915/intel_display.c |4 1 file changed, 4 insertions(+) diff --git

[Intel-gfx] [PATCH 36/41] drm/i915: do not use fdi_normal_train on haswell

2012-03-29 Thread Eugeni Dodonov
This should be already configured when FDI auto-negotiation is done. Reviewed-by: Rodrigo Vivi rodrigo.v...@gmail.com Signed-off-by: Eugeni Dodonov eugeni.dodo...@intel.com --- drivers/gpu/drm/i915/intel_display.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[Intel-gfx] [PATCH 30/41] drm/i915: enable power wells on haswell init

2012-03-29 Thread Eugeni Dodonov
This attempts to enable all the available power wells during the initialization. Those power wells can be enabled in parallel or on-demand, and disabled when no longer needed, but this is out of scope of this initial enablement. Proper tracking of who uses which power well will require a

[Intel-gfx] [PATCH 12/41] drm/i915: add definition of LPT FDI port width registers

2012-03-29 Thread Eugeni Dodonov
Reviewed-by: Rodrigo Vivi rodrigo.v...@intel.com Signed-off-by: Eugeni Dodonov eugeni.dodo...@intel.com --- drivers/gpu/drm/i915/i915_reg.h |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 880c4f7..58fcfae 100644 ---

[Intel-gfx] [PATCH 32/41] drm/i915: program WM_LINETIME on Haswell

2012-03-29 Thread Eugeni Dodonov
The line time can be programmed according to the number of horizontal pixels vs effective pixel rate ratio. v2: improve comment as per Chris Wilson suggestion Signed-off-by: Eugeni Dodonov eugeni.dodo...@intel.com --- drivers/gpu/drm/i915/intel_display.c | 13 + 1 file changed, 13

[Intel-gfx] [PATCH 38/41] drm/i915: detect digital outputs on Haswell

2012-03-29 Thread Eugeni Dodonov
Digital port detection on Haswell is indicated by the presence of a bit in DDI_BUF_CTL for port A, and by a different register for ports B, C and D. So we check for those bits during the initialization time and let the hdmi function know about those. Note that this bit does not indicates whether

[Intel-gfx] [PATCH 11/41] drm/i915: add definition of DDI buffer translations regs

2012-03-29 Thread Eugeni Dodonov
Those registers are used to train DDI buffer translations for each link type. v2: access each port registers through the DDI_BUF_TRANS macro Signed-off-by: Eugeni Dodonov eugeni.dodo...@intel.com --- drivers/gpu/drm/i915/i915_reg.h |7 +++ 1 file changed, 7 insertions(+) diff --git

[Intel-gfx] [PATCH 25/41] drm/i915: haswell has 3 pipes as well

2012-03-29 Thread Eugeni Dodonov
They work differently, but the count is the same. Reviewed-by: Rodrigo Vivi rodrigo.v...@gmail.com Signed-off-by: Eugeni Dodonov eugeni.dodo...@intel.com --- drivers/gpu/drm/i915/i915_dma.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_dma.c

[Intel-gfx] [PATCH 21/41] drm/i915: add WM_LINETIME registers

2012-03-29 Thread Eugeni Dodonov
Watermark line time registers for display low power watermark. v2: improve bit names as suggested by Chris Wilson Signed-off-by: Eugeni Dodonov eugeni.dodo...@intel.com --- drivers/gpu/drm/i915/i915_reg.h | 10 ++ 1 file changed, 10 insertions(+) diff --git

[Intel-gfx] [PATCH 20/41] drm/i915: add WRPLL clocks

2012-03-29 Thread Eugeni Dodonov
The WR PLL can drive the DDI ports at fixed frequencies for HDMI, DVI, DP and FDI. Signed-off-by: Eugeni Dodonov eugeni.dodo...@intel.com --- drivers/gpu/drm/i915/i915_reg.h |8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h

[Intel-gfx] [PATCH 41/41] drm/i915: add debugging bits for haswell modesetting

2012-03-29 Thread Eugeni Dodonov
-- THIS PATCH IS NOT INTENDED FOR MERGING. IT IS MERELY HERE TO SIMPLIFY THE DEBUGGING -- This patch is here for make debugging and log tracing easier, it should go away in the future, when we'll stop hitting those code paths. v2: cope with changes in bit names Signed-off-by: Eugeni Dodonov

[Intel-gfx] [PATCH 10/41] drm/i915: add definitions for DDI_BUF_CTL registers

2012-03-29 Thread Eugeni Dodonov
There is one instance of those registers for each DDI port. v2: access registers via the DDI_BUF_CTL() macro Reviewed-by: Rodrigo Vivi rodrigo.v...@intel.com Signed-off-by: Eugeni Dodonov eugeni.dodo...@intel.com --- drivers/gpu/drm/i915/i915_reg.h | 23 +++ 1 file

[Intel-gfx] [PATCH 16/41] drm/i915: add S PLL control

2012-03-29 Thread Eugeni Dodonov
This PLL control can drive DDI ports at desired frequencies for DisplayPort and FDI connections. Reviewed-by: Rodrigo Vivi rodrigo.v...@gmail.com Signed-off-by: Eugeni Dodonov eugeni.dodo...@intel.com --- drivers/gpu/drm/i915/i915_reg.h |8 1 file changed, 8 insertions(+) diff

[Intel-gfx] [PATCH 37/41] drm/i915: program iCLKIP on Lynx Point

2012-03-29 Thread Eugeni Dodonov
The iCLKIP clock is used to drive the VGA pixel clock on the PCH. In order to do so, it must be programmed to properly do the clock ticks according to the divisor, phase direction, phase increments and a special auxiliary divisor for 20MHz clock. Those values can be programmed individually, by

[Intel-gfx] [PATCH 15/41] drm/i915: add PIXCLK_GATE register

2012-03-29 Thread Eugeni Dodonov
Pixel clock gating control for Lynx point. Reviewed-by: Rodrigo Vivi rodrigo.v...@gmail.com Signed-off-by: Eugeni Dodonov eugeni.dodo...@intel.com --- drivers/gpu/drm/i915/i915_reg.h |6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h

[Intel-gfx] [PATCH 18/41] drm/i915: add SSC offsets for SBI access

2012-03-29 Thread Eugeni Dodonov
Different registers are identified by their target id and offset. To simplify their programming, they are called as RegisterNameTargetId. For example, SSCCTL register accessed through SBI at target id 6 and offset 0c is called SBI_SSCCTL6. Reviewed-by: Rodrigo Vivi rodrigo.v...@gmail.com

[Intel-gfx] [PATCH 27/41] drm/i915: share pipe count handling with Ivybridge

2012-03-29 Thread Eugeni Dodonov
Reviewed-by: Rodrigo Vivi rodrigo.v...@gmail.com Signed-off-by: Eugeni Dodonov eugeni.dodo...@intel.com --- drivers/gpu/drm/i915/intel_display.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c

[Intel-gfx] [PATCH 19/41] drm/i915: add LCPLL control registers

2012-03-29 Thread Eugeni Dodonov
Those are used to control the display core clock. v2: change the enable bit setting, spotted by Rodrigo Vivi. Reviewed-by: Rodrigo Vivi rodrigo.v...@intel.com Signed-off-by: Eugeni Dodonov eugeni.dodo...@intel.com --- drivers/gpu/drm/i915/i915_reg.h |7 +++ 1 file changed, 7

[Intel-gfx] [PATCH 33/41] drm/i915: initialize DDI buffer translations

2012-03-29 Thread Eugeni Dodonov
Buffer translations for DDI links must be initialized prior to enablement. For FDI and DP, first 9 pairs of values are used to select the connection parameters. HDMI uses the last pair of values and ignores the first 9 pairs. So we program HDMI values in both cases, which allows HDMI to work over

[Intel-gfx] [PATCH 34/41] drm/i915: perform Haswell DDI link training in FDI mode

2012-03-29 Thread Eugeni Dodonov
This patch attempts at following the modeset sequence closely, retrying with different voltages if the DP_TP_STATUS reports a failed training. For training, we add a table of recommended settings for FDI, HDMI and DP connections. For FDI and DP modes, we also add the HDMI buffer translation as

[Intel-gfx] [PATCH 13/41] drm/i915: add SBI registers

2012-03-29 Thread Eugeni Dodonov
Those are responsible for the Sideband Interface programming. v2: rename SBI bits to better reflect their meaning Reviewed-by: Rodrigo Vivi rodrigo.v...@intel.com Signed-off-by: Eugeni Dodonov eugeni.dodo...@intel.com --- drivers/gpu/drm/i915/i915_reg.h | 12 1 file changed, 12

Re: [Intel-gfx] Broken LVDS output at mode changes

2012-03-29 Thread Takashi Iwai
At Thu, 29 Mar 2012 08:07:05 -0700, Keith Packard wrote: On Thu, 29 Mar 2012 13:44:28 +0100, Chris Wilson ch...@chris-wilson.co.uk wrote: In conjunction with bits Power Sequence Progress field and Power Cycle Delay Active, this bit set to a one indicates that the panel is currently

Re: [Intel-gfx] Broken LVDS output at mode changes

2012-03-29 Thread Keith Packard
#part sign=pgpmime On Thu, 29 Mar 2012 18:12:56 +0200, Takashi Iwai ti...@suse.de wrote: The strange thing is that, although you can recover the display by turning off LVDS and on again once when the problem happens, but then the display starts flickering. And, the flickering continues even

Re: [Intel-gfx] Broken LVDS output at mode changes

2012-03-29 Thread Takashi Iwai
At Thu, 29 Mar 2012 09:57:41 -0700, Keith Packard wrote: #part sign=pgpmime On Thu, 29 Mar 2012 18:12:56 +0200, Takashi Iwai ti...@suse.de wrote: The strange thing is that, although you can recover the display by turning off LVDS and on again once when the problem happens, but then the

Re: [Intel-gfx] [PATCH 05/18] drm/i915: context switch implementation

2012-03-29 Thread Daniel Vetter
On Sun, Mar 18, 2012 at 01:39:45PM -0700, Ben Widawsky wrote: Implement the context switch code as well as the interfaces to do the context switch. This patch also doesn't match 1:1 with the RFC patches. The main difference is that from Daniel's responses the last context object is now stored

Re: [Intel-gfx] [PATCH 05/18] drm/i915: context switch implementation

2012-03-29 Thread Ben Widawsky
On Thu, 29 Mar 2012 20:24:11 +0200 Daniel Vetter dan...@ffwll.ch wrote: On Sun, Mar 18, 2012 at 01:39:45PM -0700, Ben Widawsky wrote: Implement the context switch code as well as the interfaces to do the context switch. This patch also doesn't match 1:1 with the RFC patches. The main

Re: [Intel-gfx] [PATCH 05/18] drm/i915: context switch implementation

2012-03-29 Thread Daniel Vetter
On Sun, Mar 18, 2012 at 01:39:45PM -0700, Ben Widawsky wrote: Implement the context switch code as well as the interfaces to do the context switch. This patch also doesn't match 1:1 with the RFC patches. The main difference is that from Daniel's responses the last context object is now stored

Re: [Intel-gfx] [PATCH 05/18] drm/i915: context switch implementation

2012-03-29 Thread Daniel Vetter
On Thu, Mar 29, 2012 at 11:43:12AM -0700, Ben Widawsky wrote: On Thu, 29 Mar 2012 20:24:11 +0200 Daniel Vetter dan...@ffwll.ch wrote: On Sun, Mar 18, 2012 at 01:39:45PM -0700, Ben Widawsky wrote: Implement the context switch code as well as the interfaces to do the context switch. This

Re: [Intel-gfx] [PATCH 09/18] drm/i915: possibly invalidate TLB before context switch

2012-03-29 Thread Daniel Vetter
On Sun, Mar 18, 2012 at 01:39:49PM -0700, Ben Widawsky wrote: From http://intellinuxgraphics.org/documentation/SNB/IHD_OS_Vol1_Part3.pdf [DevSNB] If Flush TLB invalidation Mode is enabled it’s the driver’s responsibility to invalidate the TLBs at least once after the previous context switch

Re: [Intel-gfx] [PATCH 11/18] drm/i915: switch to default context on idle

2012-03-29 Thread Daniel Vetter
On Sun, Mar 18, 2012 at 01:39:51PM -0700, Ben Widawsky wrote: To keep things as sane as possible, switch to the default context before idling. This should help free context objects, as well as put things in a more well defined state before suspending. Signed-off-by: Ben Widawsky

[Intel-gfx] [RFC] drm/i915: opencode get/put irq for gen6+

2012-03-29 Thread Ben Widawsky
Before Chris get's all mad and complains that I did the opposite with semaphores - semaphores did have a bit of logic which many had found confusing and it was greatly simplified by abstracting it. Anyhow, this removes a few lines that really didn't serve much purpose. It also seems I can

Re: [Intel-gfx] [PATCH 12/18] drm/i915: try to reset the gpu before unload

2012-03-29 Thread Daniel Vetter
On Sun, Mar 18, 2012 at 01:39:52PM -0700, Ben Widawsky wrote: paranoia For context support the HW expects the default context to always be available as there is no way to shut off HW contexts once turned on (afaics). This is problematic when unloading the driver as we have no way to prevent

Re: [Intel-gfx] [PATCH 13/18] drm/i915/context: create destroy ioctls

2012-03-29 Thread Daniel Vetter
On Sun, Mar 18, 2012 at 01:39:53PM -0700, Ben Widawsky wrote: Add the interfaces to allow user space to create and destroy contexts. Contexts are destroyed automatically if the file descriptor for the dri device is closed. Signed-off-by: Ben Widawsky b...@bwidawsk.net ---

Re: [Intel-gfx] [PATCH 14/18] drm/i915/context: switch contexts with execbuf2

2012-03-29 Thread Daniel Vetter
On Sun, Mar 18, 2012 at 01:39:54PM -0700, Ben Widawsky wrote: Use the rsvd1 field in execbuf2 to specify the context ID associated with the workload. This will allow the driver to do the proper context switch when/if needed. Signed-off-by: Ben Widawsky b...@bwidawsk.net ---

Re: [Intel-gfx] [PATCH 16/18] drm/i915/context: anonymous context interfaces

2012-03-29 Thread Daniel Vetter
On Sun, Mar 18, 2012 at 01:39:56PM -0700, Ben Widawsky wrote: Ironlake RC6 needs to allocate a power context object which the hardware can automatically switch to. Since the new context code nicely handles contexts, create some interfaces so we can hook up the existing code to the new code.

Re: [Intel-gfx] [PATCH 17/18] drm/i915: Ironlake rc6 can use context interfaces

2012-03-29 Thread Daniel Vetter
On Sun, Mar 18, 2012 at 01:39:57PM -0700, Ben Widawsky wrote: Use the context interfaces to create the power context. Assuming we have a default context, there should be no need to switch to the render context anymore as the default context should already serve this purpose. As a double

Re: [Intel-gfx] [PATCH 00/18] i915 HW Context Support

2012-03-29 Thread Daniel Vetter
On Mon, Mar 19, 2012 at 11:14:32AM +0100, Daniel Vetter wrote: On Sun, Mar 18, 2012 at 01:39:40PM -0700, Ben Widawsky wrote: The patches have changed quite a bit since the RFC, and therefore I didn't feel comfortable trying to do v2 information. I didn't feel comfortable taking the few r-bs

Re: [Intel-gfx] [PATCH 12/41] drm/i915: add definition of LPT FDI port width registers

2012-03-29 Thread Daniel Vetter
On Thu, Mar 29, 2012 at 12:32:28PM -0300, Eugeni Dodonov wrote: Reviewed-by: Rodrigo Vivi rodrigo.v...@intel.com Signed-off-by: Eugeni Dodonov eugeni.dodo...@intel.com --- drivers/gpu/drm/i915/i915_reg.h |3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [Intel-gfx] [PATCH 14/41] drm/i915: add support for SBI ops

2012-03-29 Thread Daniel Vetter
On Thu, Mar 29, 2012 at 12:32:30PM -0300, Eugeni Dodonov wrote: With Lynx Point, we need to use SBI to communicate with the display clock control. This commit adds helper functions to access the registers via SBI. v2: de-inline the function and address changes in bits names v1

Re: [Intel-gfx] [PATCH 11/18] drm/i915: switch to default context on idle

2012-03-29 Thread Chris Wilson
On Thu, 29 Mar 2012 21:29:05 +0200, Daniel Vetter dan...@ffwll.ch wrote: On Sun, Mar 18, 2012 at 01:39:51PM -0700, Ben Widawsky wrote: To keep things as sane as possible, switch to the default context before idling. This should help free context objects, as well as put things in a more well

Re: [Intel-gfx] [RFC] drm/i915: opencode get/put irq for gen6+

2012-03-29 Thread Chris Wilson
On Thu, 29 Mar 2012 12:26:49 -0700, Ben Widawsky b...@bwidawsk.net wrote: Before Chris get's all mad and complains that I did the opposite with semaphores - semaphores did have a bit of logic which many had found confusing and it was greatly simplified by abstracting it. Anyhow, this removes

Re: [Intel-gfx] [PATCH 22/41] drm/i915: add SFUSE_STRAP registers for digital port detection

2012-03-29 Thread Daniel Vetter
On Thu, Mar 29, 2012 at 12:32:38PM -0300, Eugeni Dodonov wrote: DDIA is detected via the DDI_BUF_CTL registers bit 0, but for DDIB, DDIC and DDID we need to consult SFUSE_STRAP values. Signed-off-by: Eugeni Dodonov eugeni.dodo...@intel.com --- drivers/gpu/drm/i915/i915_reg.h |7 +++

[Intel-gfx] [PATCH 1/1] drm/i915: add Ivy Bridge GT2 Server entries

2012-03-29 Thread Eugeni Dodonov
This adds PCI ID for IVB GT2 server variant which we were missing. Signed-off-by: Eugeni Dodonov eugeni.dodo...@intel.com --- drivers/char/agp/intel-agp.h|1 + drivers/char/agp/intel-gtt.c|2 ++ drivers/gpu/drm/i915/i915_drv.c |1 + 3 files changed, 4 insertions(+) diff

[Intel-gfx] [PATCH 1/1] intel: add Ivy Bridge GT2 server variant

2012-03-29 Thread Eugeni Dodonov
From: Eugeni Dodonov eug...@dodonov.net We were missing this one and it is being used by Bromolow. Signed-off-by: Eugeni Dodonov eug...@dodonov.net --- intel/intel_chipset.h |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/intel/intel_chipset.h b/intel/intel_chipset.h

[Intel-gfx] [PATCH 1/1] intel_driver: add support for Ivy Bridge GT2 Server chipset

2012-03-29 Thread Eugeni Dodonov
This is the GT2 variant of Ivy Bridge server chip. Signed-off-by: Eugeni Dodonov eugeni.dodo...@intel.com --- src/intel_driver.h |1 + src/intel_module.c |2 ++ 2 files changed, 3 insertions(+) diff --git a/src/intel_driver.h b/src/intel_driver.h index e9d6d9e..98973e5 100644 ---

[Intel-gfx] [PATCH 2/2] drm/i915: open code gen6+ ring irqs

2012-03-29 Thread Ben Widawsky
We can now open-code the get/put irq functions as they were just abstracting single register definitions. It would be nice to merge this in with the IRQ handling code... but that is too much work for me at present. In addition I could probably collapse this in to a lot of the Ironlake stuff, but

[Intel-gfx] [PATCH 1/2] drm/i915: ring irq cleanups

2012-03-29 Thread Ben Widawsky
- gen6 put/get only need one argument rflags and gflags are always the same (see above explanation) - remove a couple redundantly defined IRQs - reordered some lines to make things go in descending order Every ring has its own interrupts, enables, masks, and status bits that are fed into the

Re: [Intel-gfx] Broken LVDS output at mode changes

2012-03-29 Thread Keith Packard
#part sign=pgpmime On Thu, 29 Mar 2012 20:02:01 +0200, Takashi Iwai ti...@suse.de wrote: Sure, that'd be a preferred option. If you have any easy test in mind, let me know. The way I'd love to see it tested would be to capture signal traces on the LVDS link across mode set and see what