[Intel-gfx] [PATCH 6/6] drm/i915: eliminate vm->insert_entries()

2013-09-14 Thread Ben Widawsky
From: Ben Widawsky With bind/unbind function pointers in place, we no longer need insert_entries. We could, and want, to remove clear_range, however it's not totally easy at this point. Since it's used in a couple of place still that don't only deal in objects: setup, ppgtt init, and restore gtt

[Intel-gfx] [PATCH 4/6] drm/i915: Add bind/unbind object functions to VM

2013-09-14 Thread Ben Widawsky
From: Ben Widawsky As we plumb the code with more VM information, it has become more obvious that the easiest way to deal with bind and unbind is to simply put the function pointers in the vm, and let those choose the correct way to handle the page table updates. This change allows many places in

[Intel-gfx] [PATCH 5/6] drm/i915: Use the new vm [un]bind functions

2013-09-14 Thread Ben Widawsky
From: Ben Widawsky Building on the last patch which created the new function pointers in the VM for bind/unbind, here we actually put those new function pointers to use. Split out as a separate patch to aid in review. I'm fine with squashing into the previous patch if people request it. v2: Upd

[Intel-gfx] [PATCH 3/6] drm/i915: Convert active API to VMA

2013-09-14 Thread Ben Widawsky
From: Ben Widawsky Even though we track object activity and not VMA, because we have the active_list be based on the VM, it makes the most sense to use VMAs in the APIs. NOTE: Daniel intends to eventually rip out active/inactive LRUs, but for now, leave them be. v2: Remove leftover hunk from th

[Intel-gfx] [PATCH 2/6] drm/i915: Provide a cheap ggtt vma lookup

2013-09-14 Thread Ben Widawsky
"We do fairly often lookup the ggtt vma for an obj." - Chris Wilson. As such, provide a function to offer slightly cheaper access to the vma. Not performance tested. By my quick estimation it saves at least 3 pointer dereferences from the existing mechanism. This patch mostly matches code from Chr

[Intel-gfx] [PATCH 1/6] drm/i915: trace vm eviction instead of everything

2013-09-14 Thread Ben Widawsky
Tracing vm eviction is really the event we care about. For the cases we evict everything, we still will get the trace. v2: Add the drm device to the trace since we might not be the only device in the system. (Chris) Signed-off-by: Ben Widawsky --- drivers/gpu/drm/i915/i915_gem_evict.c | 2 ++

Re: [Intel-gfx] 3.11.0+ Laptop screen goes blank during kernelboot

2013-09-14 Thread Hans de Bruin
On 09/13/2013 09:36 PM, Daniel Vetter wrote: On Fri, Sep 13, 2013 at 7:43 PM, Hans de Bruin wrote: On 09/12/2013 10:49 PM, Daniel Vetter wrote: On Thu, Sep 12, 2013 at 10:45:10PM +0200, Hans de Bruin wrote: On 09/10/2013 01:00 PM, Jani Nikula wrote: Hi Hans - On Sat, 07 Sep 2013, Hans d

Re: [Intel-gfx] [PATCH] Revert "drm/i915: Move Valleyview DP DPLL divisor calc to intel_dp_set_clock v2"

2013-09-14 Thread Jesse Barnes
Yeah, haven't looked too hard at the changes, hopefully the fixed numbers can work across all out BYT SKUs. I'll test more when I get my new platform next week. Jesse Barnes, Intel Open Source Technology Center Original message From: Daniel Vetter Date: 14/09/2013 4:28 AM

Re: [Intel-gfx] [PATCH 7/8] drm/i915: Use the new vm [un]bind functions

2013-09-14 Thread Chris Wilson
On Fri, Sep 13, 2013 at 06:08:17PM -0700, Ben Widawsky wrote: > On Wed, Sep 11, 2013 at 11:39:30PM +0100, Chris Wilson wrote: > > On Wed, Sep 11, 2013 at 02:57:54PM -0700, Ben Widawsky wrote: > > > @@ -464,11 +465,12 @@ i915_gem_execbuffer_reserve_vma(struct i915_vma > > > *vma, > > >

Re: [Intel-gfx] [PATCH] Revert "drm/i915: Move Valleyview DP DPLL divisor calc to intel_dp_set_clock v2"

2013-09-14 Thread Daniel Vetter
On Sat, Sep 14, 2013 at 2:29 AM, Jesse Barnes wrote: > On Fri, 13 Sep 2013 17:27:54 -0700 > Jesse Barnes wrote: > >> This reverts commit 65ce4bf5a15fcd4d15898be47795d0550eb2325c. > > Found this was breaking eDP for me with -nightly as of today on Baley > Bay boards. > > Chris, can you verify this