Re: [Intel-gfx] [PATCH 1/2] drm: share drm_add_fake_info_node

2014-01-15 Thread Daniel Vetter
On Wed, Jan 15, 2014 at 12:40 AM, Russell King - ARM Linux wrote: > On Wed, Jan 15, 2014 at 12:25:10AM +0100, Daniel Vetter wrote: >> On Tue, Jan 14, 2014 at 06:14:06AM -0800, Ben Widawsky wrote: >> > Both i915 and Armada had the exact same implementation. For an upcoming >> > patch, I'd like to c

Re: [Intel-gfx] [PATCH 1/2] drm: share drm_add_fake_info_node

2014-01-15 Thread Daniel Vetter
On Wed, Jan 15, 2014 at 9:39 AM, Daniel Vetter wrote: > On Wed, Jan 15, 2014 at 12:40 AM, Russell King - ARM Linux > wrote: >> On Wed, Jan 15, 2014 at 12:25:10AM +0100, Daniel Vetter wrote: >>> On Tue, Jan 14, 2014 at 06:14:06AM -0800, Ben Widawsky wrote: >>> > Both i915 and Armada had the exact

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Move pipecrc debug functions to new file

2014-01-15 Thread Daniel Vetter
On Wed, Jan 15, 2014 at 2:22 AM, Damien Lespiau wrote: > On Tue, Jan 14, 2014 at 06:14:07AM -0800, Ben Widawsky wrote: >> +#include >> +#include >> +#include >> +#include >> +#include >> +#if 0 >> +#include >> +#include >> +#endif > > Could remove that #if > > Last time I remember we talked

Re: [Intel-gfx] [PATCH v2] i915: send D1 opregion notification

2014-01-15 Thread Daniel Vetter
On Tue, Jan 14, 2014 at 03:36:15PM -0800, Kristen Carlson Accardi wrote: > The opregion notification for runtime suspend is currently D1, not D3. > > Signed-off-by: Kristen Carlson Accardi Queued for -next, thanks for the patch. -Daniel > --- > drivers/gpu/drm/i915/i915_drv.c | 10 +- >

Re: [Intel-gfx] [PATCH v3 3/4] drm/dp: Add DisplayPort link helpers

2014-01-15 Thread Thierry Reding
On Tue, Jan 14, 2014 at 10:52:55AM -0500, Alex Deucher wrote: > On Tue, Jan 14, 2014 at 9:55 AM, Thierry Reding > wrote: [...] > > +/** > > + * drm_dp_link_configure() - configure a DisplayPort link > > + * @aux: DisplayPort AUX cahnnel > > + * @link: pointer to a structure containing the link co

[Intel-gfx] IEGD to xf86-video-intel

2014-01-15 Thread Dragoș Carp
Hi all, I'm trying to update an old linux board Advantech PCM-9361 (Intel Atom N270+ 945GSE+ ICH7M) Linux 2.6.32 + IEGD to the newest opensuse 13.1: Linux 3.11.6 + xf86-video-intel 2.99.906. The IEGD driver has some settings (Port Attributes) that cannot be set in xf86-video-intel. Is it possibl

[Intel-gfx] [PATCH] drm/i915: Introduce mapping of user pages into video memory (userptr) ioctl

2014-01-15 Thread Chris Wilson
By exporting the ability to map user address and inserting PTEs representing their backing pages into the GTT, we can exploit UMA in order to utilize normal application data as a texture source or even as a render target (depending upon the capabilities of the chipset). This has a number of uses, w

[Intel-gfx] [PATCH] drm/i915: Clean up display pipe register accesses

2014-01-15 Thread Antti Koskipaa
RFCv2: Reorganize array indexing so that full offsets can be used as is. It makes grepping for registers in i915_reg.h much easier. Also move offset arrays to intel_device_info. PATCHv1: Fixed offsets for VLV, proper eDP handling Upcoming hardware will not have the various display pipe register r

Re: [Intel-gfx] [PATCH v2] drm/i915: Propagate errors on failed PPGTT

2014-01-15 Thread Rodrigo Vivi
fyi: I got a conflict here when trying to merge to -collector seemed like it was partially applied already. On Tue, Dec 3, 2013 at 11:27 PM, Ben Widawsky wrote: > Clean up the return values/error handling so it's obvious what is going > on. This was tripped over in the PPGTT branch where code was

[Intel-gfx] IEGD to xf86-video-intel

2014-01-15 Thread Dragoș Carp
Hi all, I'm trying to update an old linux board Advantech PCM-9361 (Intel Atom N270+ 945GSE+ ICH7M) Linux 2.6.32 + IEGD to the newest opensuse 13.1: Linux 3.11.6 + xf86-video-intel 2.99.906. The IEGD driver has some settings (Port Attributes) that cannot be set in xf86-video-intel. Is it possible

Re: [Intel-gfx] [PATCH 3/6] drm/i915: reset eDP timestamps on resume

2014-01-15 Thread Jesse Barnes
On Fri, 3 Jan 2014 17:46:40 -0200 Paulo Zanoni wrote: > From: Paulo Zanoni > > The eDP code records a few timestamps containing the last time we took > some actions, because we need to wait before doing some other actions. > The problem is that if we store a timestamp when suspending and then

Re: [Intel-gfx] [PATCH 3/3] drm/i915: remove the vblank_wait hack from HSW+

2014-01-15 Thread Jesse Barnes
On Thu, 19 Dec 2013 19:12:31 -0200 Paulo Zanoni wrote: > From: Paulo Zanoni > > When I forked haswell_crtc_enable I copied all the code from > ironlake_crtc_enable. The last piece of the function contains a big > comment with a call to intel_wait_for_vblank. After this fork, we > rearranged the

Re: [Intel-gfx] [PATCH 2/3] drm/i915: don't wait for vblank after enabling pipe on HSW

2014-01-15 Thread Jesse Barnes
On Thu, 19 Dec 2013 19:12:30 -0200 Paulo Zanoni wrote: > From: Paulo Zanoni > > Because on Haswell, the pipe is never running at this point, so we hit > the 50ms timeout waiting for nothing. We already have two other places > where we wait for vblanks on haswell_crtc_enable, so we're safe. > >

Re: [Intel-gfx] [PATCH 1/3] drm/i915: add wait_for_vblank argument to intel_enable_pipe

2014-01-15 Thread Jesse Barnes
On Thu, 19 Dec 2013 19:12:29 -0200 Paulo Zanoni wrote: > From: Paulo Zanoni > > Depending on the HW gen and the connector type, the pipe won't start > running right after we call intel_enable_pipe, so that > intel_wait_for_vblank call we currently have will just sit there for > the full 50ms ti

[Intel-gfx] [PATCH] tests/kms_psr_sink_crc: Create test to test PSR by checking panel CRC.

2014-01-15 Thread Rodrigo Vivi
Signed-off-by: Rodrigo Vivi --- tests/Android.mk | 1 + tests/Makefile.sources | 1 + tests/kms_psr_sink_crc.c | 475 +++ 3 files changed, 477 insertions(+) create mode 100644 tests/kms_psr_sink_crc.c diff --git a/tests/Android.mk b/test

Re: [Intel-gfx] [PATCH] tests/kms_psr_sink_crc: Create test to test PSR by checking panel CRC.

2014-01-15 Thread Rodrigo Vivi
Hi Ville and Daniel, Ville, since this is heavily based on your kms_fbc_psr I'd appreciate your comments here please. Mainly regarding the page_flip+mmaps which I'm not sure how usefull they are on this psr case. Or my implementation is so wrong that they aren't being useful at all. Daniel, is th

[Intel-gfx] [PATCH 1/2] drm/i915: Only use read-back pipe config

2014-01-15 Thread Rodrigo Vivi
From: Daniel Vetter This way we'll catch bugs in our code where we depend upon pipe config state not (yet) read out much quicker, through a simple dpms on/off cycle. This will blow up all over the place for now, hence just a quick idea to toss out there. Signed-off-by: Daniel Vetter Signed-off

[Intel-gfx] [PATCH 0/2] drm-intel-collector - update

2014-01-15 Thread Rodrigo Vivi
This is another drm-intel-collector updated notice: http://cgit.freedesktop.org/~vivijim/drm-intel/log/?h=drm-intel-collector Here goes the update list in order for better reviewers assignment: Patch drm/i915: Only use read-back pipe config - Reviewer: Patch drm/i915: Dump the contents o

[Intel-gfx] [PATCH 2/2] drm/i915: Dump the contents of the GTT

2014-01-15 Thread Rodrigo Vivi
From: Chris Wilson Chasing wild speculation that we may be writing the wrong addresses into the GTT for stolen objects, I would like to inspect those values. Also to aide debugging ENOSPC issues with fragmentation, order the object list by ascending GTT order so that holes are more easily seen.

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Move pipecrc debug functions to new file

2014-01-15 Thread Ben Widawsky
On Wed, Jan 15, 2014 at 01:22:00AM +, Damien Lespiau wrote: > On Tue, Jan 14, 2014 at 06:14:07AM -0800, Ben Widawsky wrote: > > +#include > > +#include > > +#include > > +#include > > +#include > > +#if 0 > > +#include > > +#include > > +#endif > > Could remove that #if > Thanks, I lef

Re: [Intel-gfx] [PATCH 1/2] drm: share drm_add_fake_info_node

2014-01-15 Thread Ben Widawsky
On Wed, Jan 15, 2014 at 09:45:28AM +0100, Daniel Vetter wrote: > On Wed, Jan 15, 2014 at 9:39 AM, Daniel Vetter wrote: > > On Wed, Jan 15, 2014 at 12:40 AM, Russell King - ARM Linux > > wrote: > >> On Wed, Jan 15, 2014 at 12:25:10AM +0100, Daniel Vetter wrote: > >>> On Tue, Jan 14, 2014 at 06:14:

Re: [Intel-gfx] IEGD to xf86-video-intel

2014-01-15 Thread Dragoș Carp
I noticed that when LVDS1 output is activated (xrand --output LVDS1 --auto) the i915 driver crashes with the backtrace (drm.debug=0xe) bellow: Is this a bug in i915 driver? Thanks, Dragos [ 3101.097541] [drm:i915_irq_handler], pipe B underrun [ 3101.102081] [drm:intel_release_load_detect_pipe],

[Intel-gfx] IGT conventions

2014-01-15 Thread Jeff McGee
I have a few questions about conventions observed in writing IGT tests. I don't see any standard wrapper for logging other than the logging that goes with certain igt_ control flow functions. Is it recommended to limit logging to just these? I see some different approaches to supporting verbose mo

Re: [Intel-gfx] [PATCH 3/6] drm/i915: reset eDP timestamps on resume

2014-01-15 Thread Daniel Vetter
On Wed, Jan 15, 2014 at 10:21:56AM -0800, Jesse Barnes wrote: > On Fri, 3 Jan 2014 17:46:40 -0200 > Paulo Zanoni wrote: > > > From: Paulo Zanoni > > > > The eDP code records a few timestamps containing the last time we took > > some actions, because we need to wait before doing some other acti

Re: [Intel-gfx] [PATCH 1/3] drm/i915: add wait_for_vblank argument to intel_enable_pipe

2014-01-15 Thread Daniel Vetter
On Wed, Jan 15, 2014 at 10:25:13AM -0800, Jesse Barnes wrote: > On Thu, 19 Dec 2013 19:12:29 -0200 > Paulo Zanoni wrote: > > > From: Paulo Zanoni > > > > Depending on the HW gen and the connector type, the pipe won't start > > running right after we call intel_enable_pipe, so that > > intel_wai

Re: [Intel-gfx] [PATCH 1/2] drm: share drm_add_fake_info_node

2014-01-15 Thread Daniel Vetter
On Wed, Jan 15, 2014 at 12:08:19PM -0800, Ben Widawsky wrote: > On Wed, Jan 15, 2014 at 09:45:28AM +0100, Daniel Vetter wrote: > > On Wed, Jan 15, 2014 at 9:39 AM, Daniel Vetter wrote: > > > On Wed, Jan 15, 2014 at 12:40 AM, Russell King - ARM Linux > > > wrote: > > >> On Wed, Jan 15, 2014 at 12:

Re: [Intel-gfx] IGT conventions

2014-01-15 Thread Daniel Vetter
On Wed, Jan 15, 2014 at 05:26:28PM -0600, Jeff McGee wrote: > I have a few questions about conventions observed in writing IGT tests. > > I don't see any standard wrapper for logging other than the logging that goes > with certain igt_ control flow functions. Is it recommended to limit logging >

Re: [Intel-gfx] [PATCH v3 1/3] drm/i915: Disable/Enable PM Intrrupts based on the current freq.

2014-01-15 Thread S, Deepak
>Please use the symbolic constants in i915_reg.h, we can reuse the ones below >GEN6_PMIER. Also Chris had some comment to move this code around, but I didn't >really understand what he wants. Chris, can you please clarify? Hi Chris, Can you please clarify on this? Thanks Deepak -Original