Re: [Intel-gfx] [PATCH 07/16] drm/i915: remove an indirection level on PC8 functions

2014-03-11 Thread Chris Wilson
On Fri, Mar 07, 2014 at 08:08:10PM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > After the latest changes, the indirection is useless. > > Reviewed-by: Jesse Barnes > Signed-off-by: Paulo Zanoni > --- > drivers/gpu/drm/i915/intel_display.c | 16 ++-- > 1 file changed, 2 inse

Re: [Intel-gfx] [PATCH 06/20] drm/i915: properly clear IIR at irq_uninstall on Gen5+

2014-03-11 Thread Chris Wilson
On Fri, Mar 07, 2014 at 08:10:22PM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > The IRQ_INIT and IRQ_FINI macros are basically the same thing, with > the exception that IRQ_FINI doesn't properly clear IIR twice and > doesn't have as many POSTING_READs as IRQ_INIT. So rename the macro to >

Re: [Intel-gfx] agp/intel: can't ioremap flush page - no chipset flushing

2014-03-11 Thread Paul Bolle
Bjorn Helgaas schreef op ma 10-03-2014 om 20:07 [-0600]: > On Mon, Mar 10, 2014 at 6:15 PM, Paul Bolle wrote: > > On Mon, 2014-03-10 at 18:07 -0600, Bjorn Helgaas wrote: > >> On Mon, Mar 10, 2014 at 5:45 PM, Paul Bolle wrote: > >> > A bit of doubt is caused by two new boot time messages: > >> >

[Intel-gfx] [PATCH v6 1/1] Documentation: drm: describing drm properties exposed by various drivers

2014-03-11 Thread sagar . a . kamble
From: Sagar Kamble Started documenting drm properties for drm drivers. This patch provides information about properties in drm, i915, psb and cdv/gma-500. Information about other properties can be added on top of these. v2: Added description of drm properties in armada, exynos, i2c/ch7006, novea

[Intel-gfx] [PATCH 2/2] drm/i915: Fix scanline counter fixup on BDW

2014-03-11 Thread ville . syrjala
From: Ville Syrjälä The display interrupts changed on BDW, so the current ILK-HSW specific code in ilk_pipe_in_vblank_locked() doesn't work there. Add the required bits for BDW, and while at it, change the existing code to use nicer looking vblank status bit macros. Also remove the now stale __r

[Intel-gfx] [PATCH v2 1/2] drm/i915: Add a workaround for HSW scanline counter weirdness

2014-03-11 Thread ville . syrjala
From: Ville Syrjälä On HSW the scanline counter seems to behave differently depending on the output type. eDP on port A does what you would expect an the normal +1 fixup is sufficient to cover it. But on HDMI outputs we seem to need a +2 fixup. Just assume we always need the +2 fixup and accept t

Re: [Intel-gfx] [PATCH v6 1/1] Documentation: drm: describing drm properties exposed by various drivers

2014-03-11 Thread Laurent Pinchart
Hi Sagar, Thank you for the patch. On Tuesday 11 March 2014 16:07:35 sagar.a.kam...@intel.com wrote: > From: Sagar Kamble > > Started documenting drm properties for drm drivers. This patch provides > information about properties in drm, i915, psb and cdv/gma-500. Information > about other prope

[Intel-gfx] [RFC] Documentation requirements for drm/i915 feature work

2014-03-11 Thread Daniel Vetter
Hi all, So I guess people have seen the writing on the wall since a while ;-) So with my latest drm kerneldoc series we'll have fairly nice interface docs for most of the still relevant drm core subsystems. Which means we can finally start to look at our own driver. I've already started with a ve

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Fix scanline counter fixup on BDW

2014-03-11 Thread Daniel Vetter
On Tue, Mar 11, 2014 at 12:58:46PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > The display interrupts changed on BDW, so the current ILK-HSW specific > code in ilk_pipe_in_vblank_locked() doesn't work there. Add the required > bits for BDW, and while at it, change the ex

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Fix scanline counter fixup on BDW

2014-03-11 Thread Ville Syrjälä
On Tue, Mar 11, 2014 at 12:38:10PM +0100, Daniel Vetter wrote: > On Tue, Mar 11, 2014 at 12:58:46PM +0200, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > The display interrupts changed on BDW, so the current ILK-HSW specific > > code in ilk_pipe_in_vblank_locked() doesn't wo

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Correct PPGTT total size

2014-03-11 Thread Chris Wilson
On Sat, Mar 08, 2014 at 11:58:17AM -0800, Ben Widawsky wrote: > Our code allows have a PPGTT that is smaller than the maximum size for > GEN6-GEN7. Though I don't think this actually ever occurs, the code may > as well work properly and more importantly look correct by using the > variable size ins

Re: [Intel-gfx] [PATCH 1/2] drm/i915/bdw: Use scratch page table for GEN8 PPGTT

2014-03-11 Thread Chris Wilson
On Sat, Mar 08, 2014 at 11:59:42AM -0800, Ben Widawsky wrote: > On Sat, Mar 08, 2014 at 11:58:16AM -0800, Ben Widawsky wrote: > > I'm not clear if the hardware is still subject to the same prefetching > > issues that made us use a scratch page in the first place. In either > > case, we're using gar

Re: [Intel-gfx] [PATCH 00/13] Gen7 batch buffer command parser

2014-03-11 Thread Jani Nikula
Hi Bradley - I've now rather meticulously reviewed what *is* in the command and register tables, and didn't spot any obvious errors. There is still the review of what is *not* in the command and register tables, but perhaps should be. This is important for two reasons: 1) Any command that shoul

[Intel-gfx] [PATCH 1/3] drm/i915: Initialized 'set_property' fn pointer field of intel_crtc_funcs structure

2014-03-11 Thread akash . goel
From: Akash Goel This patch defines a new function & assigns that to the 'set_property' function pointer field of the 'intel_crtc_funcs' structure. Signed-off-by: Akash Goel --- drivers/gpu/drm/i915/intel_display.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/i9

[Intel-gfx] [PATCH v2 2/3] drm/i915: New drm crtc property for varying the Pipe Src size

2014-03-11 Thread akash . goel
From: Akash Goel This patch adds a new drm crtc property for varying the Pipe Src size or the Panel fitter input size. Pipe Src controls the size that is scaled from. This will allow to dynamically flip (without modeset) the frame buffers of different resolutions v2: Added a check to fail the se

[Intel-gfx] [PATCH v2 0/3] Two new drm crtc properties

2014-03-11 Thread akash . goel
From: Akash Goel Added 2 new drm crtc properties. One property provides control to vary the PIPESRC value. With this the size of Pipe's output or Panel fitter input can be varied. The other property provides control to vary the size of horizontal & vertical borders. With this the size of the Pane

[Intel-gfx] [PATCH v2 3/3] drm/i915: New drm crtc property for varying the size of borders

2014-03-11 Thread akash . goel
From: Akash Goel This patch adds a new drm crtc property for varying the size of the horizontal & vertical borers of the output/display window. This will control the output of Panel fitter. v2: Added a new check for the invalid border size input Testcase: igt/kms_panel_fitter_test Signed-off-b

[Intel-gfx] [PATCH] tests/kms_panel_fitter: Test to verify the 2 new drm crtc properties

2014-03-11 Thread akash . goel
From: Akash Goel This test is a derivative of kms_setmode. This will verify the 2 new drm crtc properties, added to control the Panel fitter's input & output. Signed-off-by: Akash Goel Tested-by: Akash Goel --- tests/Makefile.sources |1 + tests/kms_panel_fitter.c | 1185 +++

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Fix scanline counter fixup on BDW

2014-03-11 Thread Mika Kuoppala
ville.syrj...@linux.intel.com writes: > From: Ville Syrjälä > > The display interrupts changed on BDW, so the current ILK-HSW specific > code in ilk_pipe_in_vblank_locked() doesn't work there. Add the required > bits for BDW, and while at it, change the existing code to use nicer > looking vblank

Re: [Intel-gfx] [PATCH v6 1/1] Documentation: drm: describing drm properties exposed by various drivers

2014-03-11 Thread Sagar Arun Kamble
On Tue, 2014-03-11 at 13:13 +, Deucher, Alexander wrote: > > > -Original Message- > > From: sagar.a.kam...@intel.com [mailto:sagar.a.kam...@intel.com] > > Sent: Tuesday, March 11, 2014 6:38 AM > > To: intel-gfx@lists.freedesktop.org > > Cc: Sagar Kamble; Rob Landley; Dave Airlie; Danie

[Intel-gfx] [PATCH v7 1/1] Documentation: drm: describing drm properties exposed by various drivers

2014-03-11 Thread sagar . a . kamble
From: Sagar Kamble Started documenting drm properties for drm drivers. This patch provides information about properties in drm, i915, psb and cdv/gma-500. Information about other properties can be added on top of these. v2: Added description of drm properties in armada, exynos, i2c/ch7006, novea

Re: [Intel-gfx] [PATCH v7 1/1] Documentation: drm: describing drm properties exposed by various drivers

2014-03-11 Thread Laurent Pinchart
Hi Sagar, Thank you for the patch. On Tuesday 11 March 2014 19:55:29 sagar.a.kam...@intel.com wrote: > From: Sagar Kamble > > Started documenting drm properties for drm drivers. This patch provides > information about properties in drm, i915, psb and cdv/gma-500. Information > about other prope

Re: [Intel-gfx] [PATCH 07/16] drm/i915: remove an indirection level on PC8 functions

2014-03-11 Thread Daniel Vetter
On Tue, Mar 11, 2014 at 08:20:24AM +, Chris Wilson wrote: > On Fri, Mar 07, 2014 at 08:08:10PM -0300, Paulo Zanoni wrote: > > From: Paulo Zanoni > > > > After the latest changes, the indirection is useless. > > > > Reviewed-by: Jesse Barnes > > Signed-off-by: Paulo Zanoni > > --- > > driv

[Intel-gfx] [PATCH i-g-t 1/2] Add API documentation support

2014-03-11 Thread Thomas Wood
Add optional support for building API documentation using gtk-doc. Signed-off-by: Thomas Wood --- .gitignore | 3 + Makefile.am| 2 +- NEWS | 2 + autogen.sh

[Intel-gfx] [PATCH i-g-t 2/2] drmtest: reformat the API documentation

2014-03-11 Thread Thomas Wood
Make the existing documentation compatible with gtk-doc. Signed-off-by: Thomas Wood --- lib/drmtest.c | 19 - lib/drmtest.h | 65 +-- 2 files changed, 60 insertions(+), 24 deletions(-) diff --git a/lib/drmtest.c b/lib/drmte

Re: [Intel-gfx] [PATCH v6 1/1] Documentation: drm: describing drm properties exposed by various drivers

2014-03-11 Thread Deucher, Alexander
> -Original Message- > From: sagar.a.kam...@intel.com [mailto:sagar.a.kam...@intel.com] > Sent: Tuesday, March 11, 2014 6:38 AM > To: intel-gfx@lists.freedesktop.org > Cc: Sagar Kamble; Rob Landley; Dave Airlie; Daniel Vetter; Laurent Pinchart; > David Herrmann; Deucher, Alexander; Ville

Re: [Intel-gfx] New and original LED components from manufacturers

2014-03-11 Thread MIT electronics
Dear all purchasers, Glad to know you ! This is Vio from MIT INTERNATIONAL LTD. We are professional stock supplier of electronic components for over 11 years, especially LED parts. All of our stock parts are from original manufacturers and OEM factories which involve in Civilian,

[Intel-gfx] [PATCH i-g-t 0/3] Various small changes

2014-03-11 Thread Thomas Wood
The following patches contain two small fixes and one enhancement for intel-gpu-tools. Thomas Wood (3): tests: add missing assertion lib: print the name of the currently running subtest lib: Add i915_pciids.h to Makefile.sources lib/Makefile.sources | 1 + lib/drmtest.c| 5 - t

[Intel-gfx] [PATCH i-g-t 3/3] lib: Add missing header to Makefile.sources

2014-03-11 Thread Thomas Wood
i915_pciids.h was missing from Makefile.sources, which caused distcheck to fail. Signed-off-by: Thomas Wood --- lib/Makefile.sources | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/Makefile.sources b/lib/Makefile.sources index 5072057..cac9d12 100644 --- a/lib/Makefile.sources +++ b/lib/

[Intel-gfx] [PATCH i-g-t 1/3] tests: add missing assertion

2014-03-11 Thread Thomas Wood
Signed-off-by: Thomas Wood --- tests/pm_psr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/pm_psr.c b/tests/pm_psr.c index def8e12..5d28c7a 100644 --- a/tests/pm_psr.c +++ b/tests/pm_psr.c @@ -57,6 +57,7 @@ static int get_perf(const char *path) igt_assert(ret != 0); e

[Intel-gfx] [PATCH i-g-t 2/3] lib: print the name of the currently running subtest

2014-03-11 Thread Thomas Wood
Signed-off-by: Thomas Wood --- lib/drmtest.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/drmtest.c b/lib/drmtest.c index 9f6e701..b8d3542 100644 --- a/lib/drmtest.c +++ b/lib/drmtest.c @@ -1007,6 +1007,9 @@ bool __igt_run_subtest(const char *subtest_name)

Re: [Intel-gfx] [PATCH 1/2] drm/i915/bdw: Use scratch page table for GEN8 PPGTT

2014-03-11 Thread Ben Widawsky
On Tue, Mar 11, 2014 at 5:24 AM, Chris Wilson wrote: > On Sat, Mar 08, 2014 at 11:59:42AM -0800, Ben Widawsky wrote: >> On Sat, Mar 08, 2014 at 11:58:16AM -0800, Ben Widawsky wrote: >> > I'm not clear if the hardware is still subject to the same prefetching >> > issues that made us use a scratch p

Re: [Intel-gfx] [PATCH 1/2] drm/i915/bdw: Use scratch page table for GEN8 PPGTT

2014-03-11 Thread Chris Wilson
On Tue, Mar 11, 2014 at 09:39:30AM -0700, Ben Widawsky wrote: > On Tue, Mar 11, 2014 at 5:24 AM, Chris Wilson > wrote: > > On Sat, Mar 08, 2014 at 11:59:42AM -0800, Ben Widawsky wrote: > >> On Sat, Mar 08, 2014 at 11:58:16AM -0800, Ben Widawsky wrote: > >> > I'm not clear if the hardware is still

Re: [Intel-gfx] [PATCH 1/2] drm/i915/bdw: Use scratch page table for GEN8 PPGTT

2014-03-11 Thread Ben Widawsky
Way more coming in terms of sharing code. If you feel like looking into the future: http://cgit.freedesktop.org/~bwidawsk/drm-intel/log/?h=dynamic_pt_alloc I've hoped, and continue to hope to kill insert/clear_entires entirely. Still debugging some gen7 crap though for now. On Tue, Mar 11, 2014 a

[Intel-gfx] [PATCH 1/4] drm/i915: Reduce the time we hold struct mutex in intel_pipe_set_base()

2014-03-11 Thread ville . syrjala
From: Ville Syrjälä We don't need to hold struct_mutex all through intel_pipe_set_base(), just need to hold it while pinning/unpinning the buffers. So reduce the struct_mutext usage in intel_pipe_set_base() just like we did for the sprite code in: commit 82284b6becdbef6d8cd3fb43e8698510833a5129

[Intel-gfx] [PATCH 2/4] drm/i915: Fix mmio vs. CS flip race on ILK+

2014-03-11 Thread ville . syrjala
From: Ville Syrjälä Starting from ILK, mmio flips also cause a flip done interrupt to be signalled. This means if we first do a set_base and follow it immediately with the CS flip, we might mistake the flip done interrupt caused by the set_base as the flip done interrupt caused by the CS flip. T

[Intel-gfx] [PATCH 3/4] drm/i915: Drop the excessive vblank waits from modeset codepaths

2014-03-11 Thread ville . syrjala
From: Ville Syrjälä Now that we've plugged the mmio vs. ring flip race, we shouldn't need these vblank waits in the modeset codepaths anymore. So get rid of them. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 12 1 file changed, 12 deletions(-) diff --gi

[Intel-gfx] [PATCH 0/4] drm/i915: mmio vs. CS flip race fix

2014-03-11 Thread ville . syrjala
From: Ville Syrjälä Starting from ILK mmio flips can interfere with the detection of CS flip completion. This is due to the fact that mmio flips also cause the flip done interrupt to be raised. This series tries to make sure we don't mistake a flip done interrupt caused by an mmio flip as the fl

[Intel-gfx] [PATCH 4/4] drm/i915: Wait for vblank in hsw_enable_ips()

2014-03-11 Thread ville . syrjala
From: Ville Syrjälä Now that the vblank wait is gone from intel_enable_primary_plane(), hsw_enable_ips() needs to do the vblank wait itself. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 12 ++-- drivers/gpu/drm/i915/intel_sprite.c | 5 + 2 files changed

[Intel-gfx] [PATCH] gtk-doc: Document the docs

2014-03-11 Thread Daniel Vetter
- configure output to easily see whether docs are built or not - small blurb in README Signed-off-by: Daniel Vetter --- README | 6 ++ configure.ac | 2 ++ 2 files changed, 8 insertions(+) diff --git a/README b/README index 79653f5cb27f..66462c8a9bda 100644 --- a/README +++ b/README @

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Correct PPGTT total size

2014-03-11 Thread Daniel Vetter
On Tue, Mar 11, 2014 at 12:21:12PM +, Chris Wilson wrote: > On Sat, Mar 08, 2014 at 11:58:17AM -0800, Ben Widawsky wrote: > > Our code allows have a PPGTT that is smaller than the maximum size for > > GEN6-GEN7. Though I don't think this actually ever occurs, the code may > > as well work prope

Re: [Intel-gfx] [PATCH i-g-t 2/2] drmtest: reformat the API documentation

2014-03-11 Thread Daniel Vetter
On Tue, Mar 11, 2014 at 04:04:29PM +, Thomas Wood wrote: > Make the existing documentation compatible with gtk-doc. > > Signed-off-by: Thomas Wood Both patches merged, with a little patch on top to pimp the configure output and README. Thanks, Daniel > --- > lib/drmtest.c | 19 ---

Re: [Intel-gfx] [PATCH i-g-t 2/3] lib: print the name of the currently running subtest

2014-03-11 Thread Daniel Vetter
On Tue, Mar 11, 2014 at 04:18:49PM +, Thomas Wood wrote: > Signed-off-by: Thomas Wood > --- > lib/drmtest.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/lib/drmtest.c b/lib/drmtest.c > index 9f6e701..b8d3542 100644 > --- a/lib/drmtest.c > +++ b/lib/drmtest.c >

[Intel-gfx] [PATCH v1 0/2] disable rings before sync flush

2014-03-11 Thread naresh . kumar . kachhi
From: Naresh Kumar Kachhi initial version: stop rings before sync flush v1: address the comments from Chris Wilson on http://www.spinics.net/lists/intel-gfx/msg41025.html. Rather than adding stop and start ring, we are moving ring disable before hw_status_page_setup (sync flush). Naresh Kumar K

[Intel-gfx] [PATCH v1 1/2] drm/i915: disable rings before HW status page setup

2014-03-11 Thread naresh . kumar . kachhi
From: Naresh Kumar Kachhi Rings should be idle before issuing sync_flush (in intel_ring_setup_status_page). This patch moves the ring disabling before doing the HW status page setup. Signed-off-by: Naresh Kumar Kachhi --- drivers/gpu/drm/i915/intel_ringbuffer.c | 10 +- 1 file changed,

[Intel-gfx] [PATCH v1 2/2] drm/i915: warn if ring is active before sync flush

2014-03-11 Thread naresh . kumar . kachhi
From: Naresh Kumar Kachhi Based on Bspec the command parser must be stopped prior to issuing sync flush. This should be done by the caller of intel_ring_setup_status_page. Patch adds a warning if it is not done. Signed-off-by: Naresh Kumar Kachhi --- drivers/gpu/drm/i915/i915_reg.h | 2