Re: [Intel-gfx] [PATCH 2/9] drm/i915: Reduce clutter by using the local plane pointer

2015-03-12 Thread Jesse Barnes
On 03/10/2015 04:15 AM, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > No need to go dig throguh intel_crtc->base.cursor when we already have > the same thing as 'plane' local variable. > > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/intel_display.c | 2 +- > 1 fi

Re: [Intel-gfx] [PATCH 0/2] drm/i915: Try to sort out ironlake_check_fdi_lanes()

2015-03-12 Thread Ander Conselvan De Oliveira
On Wed, 2015-03-11 at 18:52 +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > So these on top of Ander's latest FDI bifurcation patch [1] should hopefully > result in something sane. Didn't test them though, but assuming Ander > has that test somewhere maybe some of the proble

Re: [Intel-gfx] [PATCH 3/9] drm/i915: Use plane->state->fb instead of plane->fb in intel_plane_restore()

2015-03-12 Thread Daniel Vetter
On Wed, Mar 11, 2015 at 10:41:30AM +0100, Daniel Vetter wrote: > On Tue, Mar 10, 2015 at 07:48:39PM +0200, Ville Syrjälä wrote: > > On Tue, Mar 10, 2015 at 10:01:47AM -0700, Matt Roper wrote: > > > On Tue, Mar 10, 2015 at 01:15:23PM +0200, ville.syrj...@linux.intel.com > > > wrote: > > > > From: V

Re: [Intel-gfx] [PATCH 9/9] drm/i915: Don't re-enable an explicitly disabled primary plane due to sprite coverage changes

2015-03-12 Thread Daniel Vetter
On Tue, Mar 10, 2015 at 01:15:29PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > When the sprite is covering the entire pipe (and color keying is not > enabled) we currently try to automagically disable the primary plane > which is fully covered by the sprite. > > Now tha

Re: [Intel-gfx] [PATCH v2] drm/i915: Modifying RC6 Promotion timer for Media workloads.

2015-03-12 Thread Deepak S
On Friday 06 March 2015 10:10 PM, Daniel Vetter wrote: On Thu, Mar 05, 2015 at 09:27:59PM +0530, deepa...@linux.intel.com wrote: From: Deepak S In normal cases, RC6 promotion timer is 1700us/500us. This will result in more time spent in C1 state. For more residency in C6 in case of media wor

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Rewrite IVB FDI bifurcation conflict checks

2015-03-12 Thread Ander Conselvan De Oliveira
(for the series) Reviewed-by: Ander Conselvan de Oliveira On Wed, 2015-03-11 at 18:52 +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Ignore the current state of the pipe and just check crtc_state->enable > and the number of FDI lanes required. This means we don't accident

Re: [Intel-gfx] [PATCH 5/9] drm/i915: Pass primary plane size to .update_primary_plane()

2015-03-12 Thread Matt Roper
On Tue, Mar 10, 2015 at 01:15:25PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > In preparation to movable/resizable primary planes pass the clipped > plane size to .update_primary_plane(). Personally I feel like it would make more sense to just completely kill off .updat

[Intel-gfx] [PATCH] drm/i915: Remove the preliminary_hw_support shackles from CHV

2015-03-12 Thread ville . syrjala
From: Ville Syrjälä CHV should be in a good enough shape now, so let's drop the .is_preliminary flag. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_drv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index 15f5

Re: [Intel-gfx] [PATCH 5/9] drm/i915: Pass primary plane size to .update_primary_plane()

2015-03-12 Thread Ville Syrjälä
On Tue, Mar 10, 2015 at 10:10:40AM -0700, Matt Roper wrote: > On Tue, Mar 10, 2015 at 01:15:25PM +0200, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > In preparation to movable/resizable primary planes pass the clipped > > plane size to .update_primary_plane(). > > Personal

Re: [Intel-gfx] [PATCH 4/9] drm/i915: Make derived plane state correct after crtc_enable

2015-03-12 Thread Ville Syrjälä
On Tue, Mar 10, 2015 at 10:01:51AM -0700, Matt Roper wrote: > On Tue, Mar 10, 2015 at 01:15:24PM +0200, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > We need to call the plane .atomic_check() hook when enabling the crtc > > to make sure all the derived state (eg. visible, c

Re: [Intel-gfx] [Beignet] [PATCH i-g-t 2/2] configure: Bump required libdrm version to 2.4.60

2015-03-12 Thread Jeff McGee
On Tue, Mar 10, 2015 at 01:58:52PM -0400, Rob Clark wrote: > On Tue, Mar 10, 2015 at 12:59 PM, Jeff McGee wrote: > > On Tue, Mar 10, 2015 at 08:37:30AM +0100, Daniel Vetter wrote: > >> On Mon, Mar 09, 2015 at 04:41:02PM -0700, jeff.mc...@intel.com wrote: > >> > From: Jeff McGee > >> > > >> > test

Re: [Intel-gfx] [Beignet] [PATCH i-g-t 2/2] configure: Bump required libdrm version to 2.4.60

2015-03-12 Thread Jeff McGee
On Tue, Mar 10, 2015 at 07:47:03PM +0100, Daniel Vetter wrote: > On Tue, Mar 10, 2015 at 01:58:52PM -0400, Rob Clark wrote: > > On Tue, Mar 10, 2015 at 12:59 PM, Jeff McGee wrote: > > > On Tue, Mar 10, 2015 at 08:37:30AM +0100, Daniel Vetter wrote: > > >> On Mon, Mar 09, 2015 at 04:41:02PM -0700,

[Intel-gfx] [PATCH i-g-t 2/2] tests/pm_sseu: Create new test pm_sseu

2015-03-12 Thread jeff . mcgee
From: Jeff McGee New test pm_sseu is intended for any subtest related to the slice/subslice/EU power gating feature. The sole initial subtest, 'full-enable', confirms that the slice/subslice/EU state is at full enablement when the render engine is active. Starting with Gen9 SKL, the render power

[Intel-gfx] [PATCH i-g-t 1/2] lib: Add media spin

2015-03-12 Thread jeff . mcgee
From: Jeff McGee The media spin utility is derived from media fill. The purpose is to create a simple means to keep the render engine (media pipeline) busy for a controlled amount of time. It does so by emitting a batch with a single execution thread that spins in a tight loop the requested numbe

Re: [Intel-gfx] [PATCH] drm/i915: Add polish to VLV WM shift+mask operations

2015-03-12 Thread Jesse Barnes
On 03/10/2015 07:16 AM, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Wrap the FW register value shift+mask operations into a macro to hide > the ugliness a bit. Also might avoid bugs due to typos. > > Also rename all the primary/sprite plane low order bit masks to have the > _V

Re: [Intel-gfx] [PATCH 7/9] drm/i915: Update watermarks after the derived plane state is uptodate

2015-03-12 Thread Daniel Vetter
On Tue, Mar 10, 2015 at 10:13:52AM -0700, Matt Roper wrote: > On Tue, Mar 10, 2015 at 01:15:27PM +0200, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > When enabling planes during .crtc_enable() we currently want to update > > the watermarks before enabling the planes. We alr

Re: [Intel-gfx] [PATCH 4/9] drm/i915: Make derived plane state correct after crtc_enable

2015-03-12 Thread Daniel Vetter
On Wed, Mar 11, 2015 at 10:52:29AM +0100, Daniel Vetter wrote: > On Tue, Mar 10, 2015 at 07:57:13PM +0200, Ville Syrjälä wrote: > > On Tue, Mar 10, 2015 at 10:01:51AM -0700, Matt Roper wrote: > > > On Tue, Mar 10, 2015 at 01:15:24PM +0200, ville.syrj...@linux.intel.com > > > wrote: > > > > From: V

Re: [Intel-gfx] [PATCH 4/9] drm/i915: Make derived plane state correct after crtc_enable

2015-03-12 Thread Ville Syrjälä
On Wed, Mar 11, 2015 at 10:52:29AM +0100, Daniel Vetter wrote: > On Tue, Mar 10, 2015 at 07:57:13PM +0200, Ville Syrjälä wrote: > > On Tue, Mar 10, 2015 at 10:01:51AM -0700, Matt Roper wrote: > > > On Tue, Mar 10, 2015 at 01:15:24PM +0200, ville.syrj...@linux.intel.com > > > wrote: > > > > From: V

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix BUG in i915_gem.c when switch to console

2015-03-12 Thread Jani Nikula
On Thu, 12 Mar 2015, Xi Ruoyao wrote: > In intel_crtc_page_flip, intel_display.c, the code changed the framebuffer > assigned to plane crtc->primary by > > crtc->primary->fb = fb; > > However, it forgot to change crtc->primary->state->fb. However, when we > switch to console, some kernel code will

[Intel-gfx] [PULL] drm-intel-fixes

2015-03-12 Thread Jani Nikula
Hi Dave - More i915 fixes, three out of four are fixes to old bugs, cc: stable. BR, Jani. The following changes since commit 9eccca0843205f87c00404b663188b88eb248051: Linux 4.0-rc3 (2015-03-08 16:09:09 -0700) are available in the git repository at: git://anongit.freedesktop.org/drm-intel

Re: [Intel-gfx] [PATCH 4/9] drm/i915: Make derived plane state correct after crtc_enable

2015-03-12 Thread Ville Syrjälä
On Wed, Mar 11, 2015 at 05:23:27PM +0100, Daniel Vetter wrote: > On Wed, Mar 11, 2015 at 02:19:38PM +0200, Ville Syrjälä wrote: > > On Wed, Mar 11, 2015 at 11:24:34AM +0100, Daniel Vetter wrote: > > > On Wed, Mar 11, 2015 at 12:05:39PM +0200, Ville Syrjälä wrote: > > > > On Wed, Mar 11, 2015 at 10:

Re: [Intel-gfx] [PATCH v2] drm/i915: Optimistically spin for the request completion

2015-03-12 Thread Chris Wilson
On Wed, Mar 11, 2015 at 09:18:19PM +, Chris Wilson wrote: > Arguably busy-spinning on an idle system isn't totally evil, but it > certainly is likely to come at a power cost. On the other hand, spinning > is relatively rare outside of benchmarks. Rare enough to be useful? As a counterpoint, I

Re: [Intel-gfx] [PATCH 11/11] drm/i915/skl: Enable the RPS interrupts programming

2015-03-12 Thread Daniel Vetter
On Wed, Mar 11, 2015 at 02:12:02PM -0700, Jesse Barnes wrote: > On 03/05/2015 09:37 PM, akash.g...@intel.com wrote: > > From: Akash Goel > > > > Enable the RPS interrupts programming(enable/disable/reset) for GEN9, > > as missing changes to enable the RPS support on GEN9 have been added. > > > >

Re: [Intel-gfx] [PATCH v2] drm/i915: Optimistically spin for the request completion

2015-03-12 Thread Daniel Vetter
On Wed, Mar 11, 2015 at 09:18:19PM +, Chris Wilson wrote: > On Wed, Mar 11, 2015 at 03:29:19PM +, Chris Wilson wrote: > > + while (!need_resched()) { > > + if (i915_gem_request_completed(req, true)) { > > + ret = 0; > > + goto out; > > +

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Rewrite IVB FDI bifurcation conflict checks

2015-03-12 Thread Daniel Vetter
On Thu, Mar 12, 2015 at 09:35:33AM +0200, Ander Conselvan De Oliveira wrote: > (for the series) > Reviewed-by: Ander Conselvan de Oliveira Both merged to dinq, thanks. -Daniel > > On Wed, 2015-03-11 at 18:52 +0200, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Ignore th

Re: [Intel-gfx] [PATCH] drm/i915: Read CHV_PLL_DW8 from the correct offset

2015-03-12 Thread Daniel Vetter
On Wed, Mar 11, 2015 at 08:20:44PM -0700, Todd Previte wrote: > On 3/11/2015 1:52 PM, ville.syrj...@linux.intel.com wrote: > >From: Ville Syrjälä > > > >We accidentally pass 'pipe' instead of 'port' to CHV_PLL_DW8() and > >with PIPE_C we end up at register offset 0x8320 which isn't the > >0x8020 w

Re: [Intel-gfx] [PATCH 07/11] drm/i915/skl: Updated the gen9_enable_rps function

2015-03-12 Thread Chris Wilson
On Wed, Mar 11, 2015 at 12:27:59PM -0700, Jesse Barnes wrote: > On 03/05/2015 09:37 PM, akash.g...@intel.com wrote: > > + /* Leaning on the below call to gen6_set_rps to program/setup the > > +* Up/Down EI & threshold registers, as well as the RP_CONTROL, > > +* RP_INTERRUPT_LIMITS & RPNS

Re: [Intel-gfx] [PATCH 07/11] drm/i915/skl: Updated the gen9_enable_rps function

2015-03-12 Thread Jesse Barnes
On 03/11/2015 12:46 PM, Chris Wilson wrote: > On Wed, Mar 11, 2015 at 12:27:59PM -0700, Jesse Barnes wrote: >> On 03/05/2015 09:37 PM, akash.g...@intel.com wrote: >>> + /* Leaning on the below call to gen6_set_rps to program/setup the >>> +* Up/Down EI & threshold registers, as well as the RP

Re: [Intel-gfx] [PATCH] drm/i915: Remove the preliminary_hw_support shackles from CHV

2015-03-12 Thread Daniel Vetter
On Wed, Mar 11, 2015 at 10:52:28PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > CHV should be in a good enough shape now, so let's drop the > .is_preliminary flag. > > Signed-off-by: Ville Syrjälä Yay! Queued for -next, thanks for the patch. -Daniel > --- > drivers/gp

[Intel-gfx] [PATCH] drm/i915: redefine WARN_ON_ONCE to include the condition

2015-03-12 Thread Jani Nikula
Same as commit c883ef1b1c998d2d66866772fd0fc34afa45641e Author: Mika Kuoppala Date: Tue Oct 28 17:32:30 2014 +0200 drm/i915: Redefine WARN_ON to include the condition but for WARN_ON_ONCE. Since the kernel WARN_ON_ONCE actually picks up *our* version of WARN_ON, we end up with messages li

[Intel-gfx] [PATCH v2] drm/i915: Do not use ggtt_view with (aliasing) PPGTT

2015-03-12 Thread Joonas Lahtinen
GGTT views are only applicable when dealing with GGTT. Change the code to reject ggtt_view where it should not be used and require it when it should be. v2: - Dropped _ppgtt_ infixes, allow both types to be passed - Disregard other but normal views when no view is specified - More checks that vali

[Intel-gfx] [PATCH v3] drm/i915: Optimistically spin for the request completion

2015-03-12 Thread Chris Wilson
This provides a nice boost to mesa in swap bound scenarios (as mesa throttles itself to the previous frame and given the scenario that will complete shortly). It will also provide a good boost to systems running with semaphores disabled and so frequently waiting on the GPU as it switches rings. In

Re: [Intel-gfx] [PATCH v3] drm/i915: Optimistically spin for the request completion

2015-03-12 Thread Chris Wilson
On Thu, Mar 12, 2015 at 11:11:17AM +, Chris Wilson wrote: > This provides a nice boost to mesa in swap bound scenarios (as mesa > throttles itself to the previous frame and given the scenario that will > complete shortly). It will also provide a good boost to systems running > with semaphores d

Re: [Intel-gfx] [PATCH i-g-t 2/2] tests/pm_sseu: Create new test pm_sseu

2015-03-12 Thread Thomas Wood
On 10 March 2015 at 21:17, wrote: > From: Jeff McGee > > New test pm_sseu is intended for any subtest related to the > slice/subslice/EU power gating feature. The sole initial subtest, > 'full-enable', confirms that the slice/subslice/EU state is at > full enablement when the render engine is ac

Re: [Intel-gfx] [PATCH v2] drm/i915: Do not use ggtt_view with (aliasing) PPGTT

2015-03-12 Thread Tvrtko Ursulin
Hi, Much more likeable in general, some comments inline: On 03/12/2015 11:10 AM, Joonas Lahtinen wrote: GGTT views are only applicable when dealing with GGTT. Change the code to reject ggtt_view where it should not be used and require it when it should be. v2: - Dropped _ppgtt_ infixes, allow

Re: [Intel-gfx] [PATCH 05/23] drm/i915: Allocate a drm_atomic_state for the legacy modeset code

2015-03-12 Thread Ander Conselvan De Oliveira
On Mon, 2015-03-09 at 16:19 -0700, Matt Roper wrote: > On Wed, Mar 04, 2015 at 04:33:17PM +0100, Daniel Vetter wrote: > > On Tue, Mar 03, 2015 at 03:21:59PM +0200, Ander Conselvan de Oliveira wrote: > > > For the atomic conversion, the mode set paths need to be changed to rely > > > on an atomic st

Re: [Intel-gfx] [PATCH] drm/i915: Ensure plane->state->fb stays in sync with plane->fb

2015-03-12 Thread Jani Nikula
Matt, please review or suggest an alternative for v4.0-rc. Thanks, Jani. On Thu, 12 Mar 2015, Xi Ruoyao wrote: > plane->state->fb and plane->fb should always reference the same FB so > that atomic and legacy codepaths have the same view of display state. > However, there are some places in ker

[Intel-gfx] [PATCH] drm/i915: Ensure plane->state->fb stays in sync with plane->fb

2015-03-12 Thread Xi Ruoyao
plane->state->fb and plane->fb should always reference the same FB so that atomic and legacy codepaths have the same view of display state. However, there are some places in kernel code that directly set plane->fb and neglect to update plane->state->fb. If we never do a successful update through th

[Intel-gfx] [PATCH 1/1] drm/i915: Fix BUG in i915_gem.c when switch to console

2015-03-12 Thread Xi Ruoyao
In intel_crtc_page_flip, intel_display.c, the code changed the framebuffer assigned to plane crtc->primary by crtc->primary->fb = fb; However, it forgot to change crtc->primary->state->fb. However, when we switch to console, some kernel code will read crtc->primary->state->fb to get the framebuf

Re: [Intel-gfx] [PATCH 1/2] gpio/crystalcove: Export Panel and backlight en/disable signals as GPIO

2015-03-12 Thread Linus Walleij
On Fri, Mar 6, 2015 at 5:23 PM, Kumar, Shobhit wrote: > There are actually two lines for Panel Power control and Backlight > enable/disable. I have already moved towards adding a new Cell device > for PWM child device and a new pwm driver for the same. That will take > care of backlight thingy. B

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix BUG in i915_gem.c when switch to console

2015-03-12 Thread Xi Ruoyao
On 03/12/2015 04:28 PM, Jani Nikula wrote: On Thu, 12 Mar 2015, Xi Ruoyao wrote: In intel_crtc_page_flip, intel_display.c, the code changed the framebuffer assigned to plane crtc->primary by crtc->primary->fb = fb; However, it forgot to change crtc->primary->state->fb. However, when we switc

[Intel-gfx] [PATCH] drm/i915: Spelling s/auxilliary/auxiliary/

2015-03-12 Thread Geert Uytterhoeven
Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/i915/intel_runtime_pm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c index 6d8e29abbc333c87..74fdd8ca2cb2a347 100644 --- a/drivers/

Re: [Intel-gfx] [PATCH 1/2] gpio/crystalcove: Export Panel and backlight en/disable signals as GPIO

2015-03-12 Thread Linus Walleij
On Wed, Feb 18, 2015 at 1:18 PM, Shobhit Kumar wrote: > Export Panel BACKLIGHT_EN(offset 0x51) and PANEL_EN(offset 0x52) as two > additional GPIOs. Needed by display driver to enable the DSI panel on > BYT platform where the Panel EN/Disable and Backlight control are > routed thorugh CRC PMIC > >

[Intel-gfx] [PATCH v2] drm/i915: Fix BUG in i915_gem.c when switch to console

2015-03-12 Thread Xi Ruoyao
In intel_crtc_page_flip, intel_display.c, the code changed the framebuffer assigned to plane crtc->primary by crtc->primary->fb = fb; However, it forgot to change crtc->primary->state->fb. However, when we switch to console, some kernel code will read crtc->primary->state->fb to get the framebuff

Re: [Intel-gfx] [PATCH v3] drm/i915: Optimistically spin for the request completion

2015-03-12 Thread Tvrtko Ursulin
On 03/12/2015 11:11 AM, Chris Wilson wrote: This provides a nice boost to mesa in swap bound scenarios (as mesa throttles itself to the previous frame and given the scenario that will complete shortly). It will also provide a good boost to systems running with semaphores disabled and so frequentl

Re: [Intel-gfx] [PATCH v3] drm/i915: Optimistically spin for the request completion

2015-03-12 Thread Chris Wilson
On Thu, Mar 12, 2015 at 01:14:30PM +, Tvrtko Ursulin wrote: > On 03/12/2015 11:11 AM, Chris Wilson wrote: > >This provides a nice boost to mesa in swap bound scenarios (as mesa > >throttles itself to the previous frame and given the scenario that will > >complete shortly). It will also provide

Re: [Intel-gfx] [PATCH i-g-t 06/15] lib: s/IGT_DEBUG_INTERACTIVE/--interactive-debug=var

2015-03-12 Thread Damien Lespiau
On Tue, Jan 20, 2015 at 11:36:03AM +0100, Daniel Vetter wrote: > On Mon, Jan 12, 2015 at 10:21:58AM -0800, Rodrigo Vivi wrote: > > Use cmdline variable for interactive debug instead of env var. > > > > v2: Make interactive-debug domain optional and use "all" when not set. > > > > Signed-off-by: R

Re: [Intel-gfx] [PATCH i-g-t v3 00/13] Testing the Y tiled display

2015-03-12 Thread Damien Lespiau
On Tue, Mar 03, 2015 at 02:10:53PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Starting with Skylake the display engine can scan out Y tiled objects. (Both > legacy Y tiled, and the new Yf format.) > > This series takes the original work by Damien Lespiau and converts it to use > th

[Intel-gfx] [PATCH i-g-t] lib/fb: Use PRIx64 for uint64_t in format string

2015-03-12 Thread Damien Lespiau
Fix the following warning: igt_fb.c: In function 'igt_create_fb_with_bo_size': igt_fb.c:414:2: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 9 has type 'uint64_t' [-Wformat=] igt_debug("%s(width=%d, height=%d, format=0x%x [bpp=%d], tiling=%llx,

[Intel-gfx] [PATCH 11/13] drm/i915: Avoid overflowing the DP link rate arrays

2015-03-12 Thread ville . syrjala
From: Ville Syrjälä Complain loudly if we ever attempt to overflow the the supported_rates[] array. This should never happen since the sink_rates[] array will always be smaller or of equal size. But should someone change that we want to catch it without scribblign over the stack. Signed-off-by:

[Intel-gfx] [PATCH 03/13] drm/i915: Don't copy the DP source rates arrays

2015-03-12 Thread ville . syrjala
From: Ville Syrjälä The source rates don't change, so we can just point the caller at the const arrays. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_dp.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.

[Intel-gfx] [PATCH 07/13] drm/i915: Hide the source vs. sink rate handling from intel_dp_compute_config()

2015-03-12 Thread ville . syrjala
From: Ville Syrjälä intel_dp_compute_config() only really needs to know the rates supported by both source and sink, so hide the raw source and sink arrays from it. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_dp.c | 37 +++-- 1 file changed, 23 i

[Intel-gfx] [PATCH 10/13] drm/i915: Fix MST link rate handling

2015-03-12 Thread ville . syrjala
From: Ville Syrjälä Now that intel_dp_max_link_bw() no longer considers the source restrictions we may try to enable MST with 5.4GHz even when the source doesn't support it. To fix that switch the code over to handle the link rate in the same way as the SST code handles it. Signed-off-by: Ville

[Intel-gfx] [PATCH 05/13] drm/i915: Remove special case from intel_supported_rates()

2015-03-12 Thread ville . syrjala
From: Ville Syrjälä Now that both source and sink rates are always filled in there's no need for any special cases in intel_supported_rates(). Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_dp.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_

[Intel-gfx] [PATCH 02/13] drm/i915: Store the converted link rates in intel_dp->supported_rates[]

2015-03-12 Thread ville . syrjala
From: Ville Syrjälä No point in converting from hardware format every single time, just store the rates in the final format under intel_dp. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_dp.c | 33 +++-- drivers/gpu/drm/i915/intel_drv.h | 3 ++- 2 fil

[Intel-gfx] [PATCH 06/13] drm/i915: Fully separate source vs. sink rates

2015-03-12 Thread ville . syrjala
From: Ville Syrjälä Remove the sink vs. source limit mess from intel_dp_max_link_bw() and just move the source restriction checks to intel_dp_source_rates(). Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_dp.c | 22 -- 1 file changed, 8 insertions(+), 14 deleti

Re: [Intel-gfx] [PATCH 1/2] gpio/crystalcove: Export Panel and backlight en/disable signals as GPIO

2015-03-12 Thread Kumar, Shobhit
On Mon, 2015-03-09 at 18:15 +0100, Linus Walleij wrote: > On Fri, Mar 6, 2015 at 5:23 PM, Kumar, Shobhit > wrote: > > > There are actually two lines for Panel Power control and Backlight > > enable/disable. I have already moved towards adding a new Cell device > > for PWM child device and a new

[Intel-gfx] [PATCH 00/13] drm/i915: Clean up the DP link rate code

2015-03-12 Thread ville . syrjala
From: Ville Syrjälä We have a bit of a mess with the source vs. sink link rate handling, so I went ahead and tried to clean it up. So now we keep the source and sink rates neatly in their own corners and compute the intersection when needed. I considered storing the intersection itself under int

[Intel-gfx] [PATCH 01/13] drm/i915: Make the DP rates int instead of uint32_t

2015-03-12 Thread ville . syrjala
From: Ville Syrjälä No point in using uint32_t here, just plain old int will do. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_dp.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i91

Re: [Intel-gfx] [PATCH v3] drm/i915: Optimistically spin for the request completion

2015-03-12 Thread Tvrtko Ursulin
On 03/12/2015 01:18 PM, Chris Wilson wrote: On Thu, Mar 12, 2015 at 01:14:30PM +, Tvrtko Ursulin wrote: On 03/12/2015 11:11 AM, Chris Wilson wrote: This provides a nice boost to mesa in swap bound scenarios (as mesa throttles itself to the previous frame and given the scenario that will co

[Intel-gfx] [PATCH 08/13] drm/i915: Fix max link rate in intel_dp_mode_valid()

2015-03-12 Thread ville . syrjala
From: Ville Syrjälä Consider the link rates reported by the sink via DP_SUPPORTED_LINK_RATES when checking modes against the max link rate. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_dp.c | 15 ++- drivers/gpu/drm/i915/intel_drv.h | 1 + 2 files changed, 15 inser

[Intel-gfx] [PATCH 13/13] drm/i915: Include the sink/source/supported rates in debug output

2015-03-12 Thread ville . syrjala
From: Ville Syrjälä TODO: Is there an actually nice way to print an array of ints? Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_dp.c | 43 + 1 file changed, 43 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i

[Intel-gfx] [PATCH 09/13] drm/i915: Use DP_LINK_RATE_SET whenever possible

2015-03-12 Thread ville . syrjala
From: Ville Syrjälä Drop the gen9 checks from the code and issue DP_LINK_RATE_SET whenever the sink reports to support it. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_dp.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/int

[Intel-gfx] [PATCH 12/13] drm/i915: Add eDP intermediate frequencies for CHV

2015-03-12 Thread ville . syrjala
From: Ville Syrjälä "P1273_DPLL_Programming Spreadsheet.xlsm" lists a boatload of frequencies for eDP. Try to use them all. For now I've decided not to add hardcoded DPLL dividers for these cases since chv_find_best_dpll() works just fine. I've not actually tested any of these since I don't hav

[Intel-gfx] [PATCH 04/13] drm/i915: Don't copy sink rates either

2015-03-12 Thread ville . syrjala
From: Ville Syrjälä Once we've read the rates from the sink we don't have to mess with them, so the caller can just look at the stored rates without doing extra copies. If the sink doesn't support the new link rate stuff, we just point the caller at the default_rates[] array. Signed-off-by: Vill

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix BUG in i915_gem.c when switch to console

2015-03-12 Thread Matt Roper
On Thu, Mar 12, 2015 at 10:28:56AM +0200, Jani Nikula wrote: > On Thu, 12 Mar 2015, Xi Ruoyao wrote: > > In intel_crtc_page_flip, intel_display.c, the code changed the framebuffer > > assigned to plane crtc->primary by > > > > crtc->primary->fb = fb; > > > > However, it forgot to change crtc->prim

[Intel-gfx] [PATCH i-g-t] lib: move igt_interactive_debug into igt_core.c

2015-03-12 Thread Thomas Wood
igt_interactive_debug should be defined in igt_core.c, rather than the header, to avoid it being defined more than once. Reported-by: Damien Lespiau Signed-off-by: Thomas Wood --- lib/igt_core.c | 1 + lib/igt_core.h | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/igt_

Re: [Intel-gfx] [PATCH] drm/i915: Ensure plane->state->fb stays in sync with plane->fb

2015-03-12 Thread Matt Roper
On Thu, Mar 12, 2015 at 02:45:31PM +0200, Jani Nikula wrote: > > Matt, please review or suggest an alternative for v4.0-rc. > > Thanks, > Jani. Yep, this looks good to me. So Reviewed-by: Matt Roper Matt > > > On Thu, 12 Mar 2015, Xi Ruoyao wrote: > > plane->state->fb and plane->fb shou

Re: [Intel-gfx] [PATCH v3] drm/i915: Optimistically spin for the request completion

2015-03-12 Thread Chris Wilson
On Thu, Mar 12, 2015 at 03:18:01PM +, Tvrtko Ursulin wrote: > On 03/12/2015 01:18 PM, Chris Wilson wrote: > >1ms. I was just thinking of doing USECS_PER_SEC / HZ, then realised that > >was a jiffie, hence the confusion. At any rate, it is still the minimum > >we can trivially wait for (without

[Intel-gfx] [RFC v5 8/9] drivers/mfd: ADD PWM lookup table for CRC PMIC based PWM

2015-03-12 Thread Shobhit Kumar
On some BYT PLatform the PWM is controlled using CRC PMIC. Add a lookup entry for the same to be used by the consumer (Intel GFX) CC: Samuel Ortiz Cc: Linus Walleij Cc: Alexandre Courbot Cc: Thierry Reding Signed-off-by: Shobhit Kumar --- drivers/mfd/intel_soc_pmic_core.c | 9 + 1 fi

[Intel-gfx] [RFC v5 5/9] drivers/mfd: Add PWM cell device for Crystalcove PMIC

2015-03-12 Thread Shobhit Kumar
Needed for PWM control suuported by the PMIC CC: Samuel Ortiz Cc: Linus Walleij Cc: Alexandre Courbot Cc: Thierry Reding Signed-off-by: Shobhit Kumar --- drivers/mfd/intel_soc_pmic_crc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mfd/intel_soc_pmic_crc.c b/drivers/mfd/int

[Intel-gfx] [RFC v5 6/9] drivers/pwm: Add Crystalcove (CRC) PWM driver

2015-03-12 Thread Shobhit Kumar
The Crystalcove PMIC controls PWM signals and this driver exports that capability as a PWM chip driver. This is platform device implementtaion of the drivers/mfd cell device for CRC PMIC CC: Samuel Ortiz Cc: Linus Walleij Cc: Alexandre Courbot Cc: Thierry Reding Signed-off-by: Shobhit Kumar -

[Intel-gfx] [RFC v5 3/9] drm/i915: Use the CRC gpio for panel enable/disable

2015-03-12 Thread Shobhit Kumar
The CRC (Crystal Cove) PMIC, controls the panel enable and disable signals for BYT for dsi panels. This is indicated in the VBT fields. Use that to initialize and use GPIO based control for these signals. v2: Use the newer gpiod interface(Alexandre) CC: Samuel Ortiz Cc: Linus Walleij Cc: Alexan

[Intel-gfx] [RFC v5 7/9] drivers/pwm: Remove __init initializer for pwm_add_table

2015-03-12 Thread Shobhit Kumar
For platforms where there are DT, some early MFD modules can reguster lookup tables. Remove __init initializer so that this works. This is similar to gpio_add_lookup_table which allows later initializations CC: Samuel Ortiz Cc: Linus Walleij Cc: Alexandre Courbot Cc: Thierry Reding Signed-off-

[Intel-gfx] [RFC v5 1/9] drivers/mfd: Add lookup table for Panel Control as GPIO signal

2015-03-12 Thread Shobhit Kumar
On some Intel SoC platforms, the panel enable/disable signals are controlled by CRC PMIC. Add those control as a new GPIO in a lookup table for gpio-crystalcove chip during CRC driver load CC: Samuel Ortiz Cc: Linus Walleij Cc: Alexandre Courbot Cc: Thierry Reding Signed-off-by: Shobhit Kumar

[Intel-gfx] [RFC v5 4/9] drivers/pwm: Add helper to configure pwm using clock divisor and duty percent

2015-03-12 Thread Shobhit Kumar
Some chips instead of using period_ns and duty_ns can be configured using the clock divisor and duty percent. Adds an alternative configuration method for such chips CC: Samuel Ortiz Cc: Linus Walleij Cc: Alexandre Courbot Cc: Thierry Reding Signed-off-by: Shobhit Kumar --- drivers/pwm/core.

[Intel-gfx] [RFC v5 2/9] gpio/crystalcove: Add additional GPIO for Panel control

2015-03-12 Thread Shobhit Kumar
Export PANEL_EN/DISABLE (offset 0x52) as additional GPIO. Needed by display driver to enable the DSI panel on BYT platform where the Panel EN/Disable control is routed thorugh CRC PMIC CC: Samuel Ortiz Cc: Linus Walleij Cc: Alexandre Courbot Cc: Thierry Reding Signed-off-by: Shobhit Kumar ---

[Intel-gfx] [RFC v5 0/9] Crystalcove (CRC) PMIC based panel and pwm control

2015-03-12 Thread Shobhit Kumar
Hi All, These patches try to enable panel control as a new GPIO via lookup table during pmic core driver loading. Code is modifed to use generic gpiod_* routines which will take care of ownership issues. Also a new PWM cell device is added to the PMIC MFD. New PWM driver pwm-crc is used to do pwm

[Intel-gfx] [RFC v5 9/9] drm/i915: Backlight control using CRC PMIC based PWM driver

2015-03-12 Thread Shobhit Kumar
CC: Samuel Ortiz Cc: Linus Walleij Cc: Alexandre Courbot Cc: Thierry Reding Signed-off-by: Shobhit Kumar --- drivers/gpu/drm/i915/intel_dsi.c | 25 + drivers/gpu/drm/i915/intel_dsi.h | 3 +++ 2 files changed, 28 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_d

Re: [Intel-gfx] [PATCH v3] drm/i915: Optimistically spin for the request completion

2015-03-12 Thread Tvrtko Ursulin
On 03/12/2015 04:28 PM, Chris Wilson wrote: On Thu, Mar 12, 2015 at 03:18:01PM +, Tvrtko Ursulin wrote: On 03/12/2015 01:18 PM, Chris Wilson wrote: 1ms. I was just thinking of doing USECS_PER_SEC / HZ, then realised that was a jiffie, hence the confusion. At any rate, it is still the minim

Re: [Intel-gfx] [PATCH v3] drm/i915: Optimistically spin for the request completion

2015-03-12 Thread Chris Wilson
On Thu, Mar 12, 2015 at 04:41:10PM +, Tvrtko Ursulin wrote: > Yes I didn't mean that - but to have a boolean spinning-wait=on/off. > Maybe default to "on" on HZ=1000 with preemption, or the opposite, > something like that. I don't see the point in having the complication, until someone complai

Re: [Intel-gfx] [PATCH] drm/i915: redefine WARN_ON_ONCE to include the condition

2015-03-12 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5940 -Summary- Platform Delta drm-intel-nightly Series Applied PNV -6 274/274

[Intel-gfx] [ANNOUNCE] intel-gpu-tools 1.10

2015-03-12 Thread Thomas Wood
A new intel-gpu-tools quarterly release is available with the following changes: - New frequency manipulation tool (intel_gpu_frequency) - Adjustments for the Solaris port (Alan Coopersmith). - Remove tests/NAMING-CONVENTION since it's all in the docbook now, to avoid divergent conventions. -

Re: [Intel-gfx] [PATCH v3] drm/i915: Optimistically spin for the request completion

2015-03-12 Thread Tvrtko Ursulin
On 03/12/2015 04:50 PM, Chris Wilson wrote: On Thu, Mar 12, 2015 at 04:41:10PM +, Tvrtko Ursulin wrote: Yes I didn't mean that - but to have a boolean spinning-wait=on/off. Maybe default to "on" on HZ=1000 with preemption, or the opposite, something like that. I don't see the point in hav

[Intel-gfx] [PATCH i-g-t 1/2 v2] lib: Add media spin

2015-03-12 Thread jeff . mcgee
From: Jeff McGee The media spin utility is derived from media fill. The purpose is to create a simple means to keep the render engine (media pipeline) busy for a controlled amount of time. It does so by emitting a batch with a single execution thread that spins in a tight loop the requested numbe

[Intel-gfx] [PATCH i-g-t 2/2 v2] tests/pm_sseu: Create new test pm_sseu

2015-03-12 Thread jeff . mcgee
From: Jeff McGee New test pm_sseu is intended for any subtest related to the slice/subslice/EU power gating feature. The sole initial subtest, 'full-enable', confirms that the slice/subslice/EU state is at full enablement when the render engine is active. Starting with Gen9 SKL, the render power

Re: [Intel-gfx] [PATCH v2] drm/i915/skl: Implement WaDisableHBR2

2015-03-12 Thread Jesse Barnes
On 02/11/2015 09:43 AM, Damien Lespiau wrote: > v2: Use the recently introduced INTEL_REVID() and SKL_REVID defines > (Nick Hoath) > > Signed-off-by: Damien Lespiau > --- > drivers/gpu/drm/i915/intel_dp.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/g

Re: [Intel-gfx] [PATCH v2] drm/i915/skl: Implement WaDisableHBR2

2015-03-12 Thread Jani Nikula
On Thu, 12 Mar 2015, Jesse Barnes wrote: > On 02/11/2015 09:43 AM, Damien Lespiau wrote: >> v2: Use the recently introduced INTEL_REVID() and SKL_REVID defines >> (Nick Hoath) >> >> Signed-off-by: Damien Lespiau >> --- >> drivers/gpu/drm/i915/intel_dp.c | 5 - >> 1 file changed, 4 inser

Re: [Intel-gfx] [PATCH v2] drm/i915/skl: Implement WaDisableHBR2

2015-03-12 Thread Jesse Barnes
On 03/12/2015 11:36 AM, Jani Nikula wrote: > On Thu, 12 Mar 2015, Jesse Barnes wrote: >> On 02/11/2015 09:43 AM, Damien Lespiau wrote: >>> v2: Use the recently introduced INTEL_REVID() and SKL_REVID defines >>> (Nick Hoath) >>> >>> Signed-off-by: Damien Lespiau >>> --- >>> drivers/gpu/drm/i9

Re: [Intel-gfx] [PATCH v3] drm/i915: Optimistically spin for the request completion

2015-03-12 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5941 -Summary- Platform Delta drm-intel-nightly Series Applied PNV -7 274/274

Re: [Intel-gfx] [PATCH 13/13] drm/i915: Include the sink/source/supported rates in debug output

2015-03-12 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5942 -Summary- Platform Delta drm-intel-nightly Series Applied PNV -2 275/275

[Intel-gfx] [PATCH i-g-t v2] tests/core_getparams: Create new test core_getparams

2015-03-12 Thread jeff . mcgee
From: Jeff McGee New test core_getparams consists of 2 subtests, each one testing the ability of userspace to query the correct value of a GT config attribute: subslice total or EU total. drm/i915 implementation of these queries is required for Cherryview and Gen9+ devices (non- simulated). v2:

Re: [Intel-gfx] [Beignet] [PATCH i-g-t 2/2] configure: Bump required libdrm version to 2.4.60

2015-03-12 Thread Jeff McGee
On Wed, Mar 11, 2015 at 08:21:36AM +0100, Daniel Vetter wrote: > On Tue, Mar 10, 2015 at 01:06:44PM -0700, Jeff McGee wrote: > > On Tue, Mar 10, 2015 at 07:47:03PM +0100, Daniel Vetter wrote: > > > On Tue, Mar 10, 2015 at 01:58:52PM -0400, Rob Clark wrote: > > > > On Tue, Mar 10, 2015 at 12:59 PM,

Re: [Intel-gfx] [Beignet] [PATCH 2/2 v2] Query the driver directly for compute units and subslice

2015-03-12 Thread Jeff McGee
On Thu, Mar 12, 2015 at 10:08:54AM +0800, Zhigang Gong wrote: > LGTM, > > Reviewed-by: Zhigang Gong > > Thanks. > Thanks for the review, Zhigang. With beignet portion reviewed, review should be able to proceed for the i915, libdrm, and igt parts. These are all quite simple. Can someone(s) ple

Re: [Intel-gfx] [PATCH v4 00/11] Added missing changes for Turbo feature on SKL

2015-03-12 Thread Jesse Barnes
On 03/05/2015 09:37 PM, akash.g...@intel.com wrote: > From: Akash Goel > > This patch series add the missing changes, required for proper > functioning of the Turbo feature on SKL. Most of the changes are > mainly due to the fact that on SKL, the frequency has to be programmed > in units of 16.66

[Intel-gfx] [PATCH i-g-t v3] tests/core_getparams: Create new test core_getparams

2015-03-12 Thread jeff . mcgee
From: Jeff McGee New test core_getparams consists of 2 subtests, each one testing the ability of userspace to query the correct value of a GT config attribute: subslice total or EU total. drm/i915 implementation of these queries is required for Cherryview and Gen9+ devices (non- simulated). v2: