[Intel-gfx] [PATCH] dim: Update before pushing a new drm-intel-next

2015-12-07 Thread Daniel Vetter
With mutliple people pushing my branch doesn't necessarily match upstream, so be more careful. Signed-off-by: Daniel Vetter --- dim | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/dim b/dim index 78b3f3048a18..295e42ce39cc 100755 --- a/dim +++ b/dim @@ -868,7 +868,8 @@ c

[Intel-gfx] [PATCH 03/10] i915: Replace "hweight8(dev_priv->info.subslice_7eu[i]) != 1" with "!is_power_of_2(dev_priv->info.subslice_7eu[i])"

2015-12-07 Thread Zhaoxiu Zeng
From: Zeng Zhaoxiu Signed-off-by: Zeng Zhaoxiu --- drivers/gpu/drm/i915/intel_ringbuffer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c index 9461a23..16c8cf1 100644 --- a/drivers/gpu/drm

Re: [Intel-gfx] [PATCH 00/29] dev->struct_mutex crusade, once more

2015-12-07 Thread Daniel Vetter
On Mon, Nov 23, 2015 at 10:32:33AM +0100, Daniel Vetter wrote: > Hi all, > > Since Daniel Stone pointed out in the last round that I fumbled one locked vs. > unlocked case I audited all the drivers once more and uprooted a bunch more > offenders. They're mostly in error paths, but in case anyone w

Re: [Intel-gfx] [PATCH] Always mark GEM objects as dirty when written by the CPU

2015-12-07 Thread Daniel Vetter
On Fri, Dec 04, 2015 at 05:28:29PM +, Dave Gordon wrote: > On 04/12/15 09:57, Daniel Vetter wrote: > >On Tue, Dec 01, 2015 at 01:21:07PM +, Dave Gordon wrote: > >>On 01/12/15 13:04, Chris Wilson wrote: > >>>On Tue, Dec 01, 2015 at 12:42:02PM +, Dave Gordon wrote: > In various places

Re: [Intel-gfx] [PATCH v2] drm/i915: Avoid writing relocs with addresses in non-canonical form

2015-12-07 Thread Daniel Vetter
On Fri, Dec 04, 2015 at 05:41:11PM +, Winiarski, Michal wrote: > On Fri, 2015-12-04 at 17:18 +0100, Daniel Vetter wrote: > > On Fri, Dec 04, 2015 at 04:20:43PM +0100, Michał Winiarski wrote: > > > According to bspec, some parts of HW expect the addresses to be in > > > a canonical form, where b

Re: [Intel-gfx] [PATCH i-g-t v2 2/2] tests/kms_force_connector_basic: Add prune-stale-modes subtest

2015-12-07 Thread Daniel Vetter
On Fri, Dec 04, 2015 at 08:10:29PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Add a new subtest that makes sure old stale modes get pruned from the > connector's mode list when the EDID changes. > > v2: s/drmModeGetConnector/drmModeGetConnectorCurrent/ since > kmst

Re: [Intel-gfx] [PATCH 03/10] i915: Replace "hweight8(dev_priv->info.subslice_7eu[i]) != 1" with "!is_power_of_2(dev_priv->info.subslice_7eu[i])"

2015-12-07 Thread Jani Nikula
On Sun, 06 Dec 2015, Zhaoxiu Zeng wrote: > From: Zeng Zhaoxiu > > Signed-off-by: Zeng Zhaoxiu I'd like to see a commit message describing what is done and why, even for trivial changes. Now the subject line is essentially the diff in plain English, which adds no information to the patch itself.

Re: [Intel-gfx] [PATCH v3 1/4] drm/i915: Add get_eld audio component

2015-12-07 Thread Daniel Vetter
On Fri, Dec 04, 2015 at 06:12:46PM +0100, Takashi Iwai wrote: > Implement a new i915_audio_component_ops, get_eld(). It's called by > the audio driver to fetch the current audio status and ELD of the > given HDMI/DP port. It returns the size of expected ELD bytes if it's > valid, zero if no valid

Re: [Intel-gfx] [PATCH v3 2/4] drm/i915: Add reverse mapping between port and intel_encoder

2015-12-07 Thread Daniel Vetter
On Fri, Dec 04, 2015 at 06:12:47PM +0100, Takashi Iwai wrote: > This patch adds a reverse mapping from a digital port number to > intel_encoder object containing the corresponding intel_digital_port. > It simplifies the query of the encoder a lot. > > Signed-off-by: Takashi Iwai > --- > v2->v3: >

Re: [Intel-gfx] [PATCH v3 2/4] drm/i915: Add reverse mapping between port and intel_encoder

2015-12-07 Thread Takashi Iwai
On Mon, 07 Dec 2015 09:44:45 +0100, Daniel Vetter wrote: > > On Fri, Dec 04, 2015 at 06:12:47PM +0100, Takashi Iwai wrote: > > This patch adds a reverse mapping from a digital port number to > > intel_encoder object containing the corresponding intel_digital_port. > > It simplifies the query of th

Re: [Intel-gfx] [PATCH 2/3] drm/atomic: Add __drm_atomic_helper_connector_reset.

2015-12-07 Thread Thierry Reding
On Tue, Nov 24, 2015 at 02:35:33PM +0100, Maarten Lankhorst wrote: > This is useful for drivers that subclass connector_state, like tegra. > > Signed-off-by: Maarten Lankhorst > --- > drivers/gpu/drm/drm_atomic_helper.c | 30 ++ > include/drm/drm_atomic_helper.h |

Re: [Intel-gfx] [PATCH 2/3] drm/atomic: Add __drm_atomic_helper_connector_reset.

2015-12-07 Thread Thierry Reding
On Tue, Nov 24, 2015 at 02:35:33PM +0100, Maarten Lankhorst wrote: > This is useful for drivers that subclass connector_state, like tegra. One more nit: s/tegra/Tegra/ Thierry signature.asc Description: PGP signature ___ Intel-gfx mailing list Intel-g

Re: [Intel-gfx] [PATCH 3/3] drm/tegra: Use __drm_atomic_helper_reset_connector for subclassing connector state.

2015-12-07 Thread Thierry Reding
On Tue, Nov 24, 2015 at 02:35:34PM +0100, Maarten Lankhorst wrote: > Signed-off-by: Maarten Lankhorst > --- > drivers/gpu/drm/tegra/dsi.c | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/tegra/dsi.c b/drivers/gpu/drm/tegra/dsi.c > index f0a138ef68

Re: [Intel-gfx] [PATCH 5/9] drm/atomic: add connector mask to drm_crtc_state.

2015-12-07 Thread Thierry Reding
On Tue, Nov 24, 2015 at 10:34:32AM +0100, Maarten Lankhorst wrote: > Signed-off-by: Maarten Lankhorst > --- > drivers/gpu/drm/drm_atomic.c | 11 +++ > include/drm/drm_crtc.h | 3 +++ > 2 files changed, 14 insertions(+) I think this could use a proper commit message. As it is, it's

Re: [Intel-gfx] [PATCH v3 2/4] drm/i915: Add reverse mapping between port and intel_encoder

2015-12-07 Thread Jani Nikula
On Fri, 04 Dec 2015, Takashi Iwai wrote: > This patch adds a reverse mapping from a digital port number to > intel_encoder object containing the corresponding intel_digital_port. > It simplifies the query of the encoder a lot. > > Signed-off-by: Takashi Iwai > --- > v2->v3: > * Squashed previousl

Re: [Intel-gfx] [PATCH 8/9] drm/atomic: Remove drm_atomic_connectors_for_crtc.

2015-12-07 Thread Thierry Reding
On Tue, Nov 24, 2015 at 10:34:35AM +0100, Maarten Lankhorst wrote: [...] > diff --git a/drivers/gpu/drm/drm_atomic_helper.c > b/drivers/gpu/drm/drm_atomic_helper.c > index cee31d43cd1c..fb79c54b2aed 100644 > --- a/drivers/gpu/drm/drm_atomic_helper.c > +++ b/drivers/gpu/drm/drm_atomic_helper.c > @@

Re: [Intel-gfx] [PATCH 6/9] drm/i915: Update connector_mask during readout.

2015-12-07 Thread Thierry Reding
On Tue, Nov 24, 2015 at 10:34:33AM +0100, Maarten Lankhorst wrote: > Signed-off-by: Maarten Lankhorst > --- > drivers/gpu/drm/i915/intel_display.c | 11 --- > 1 file changed, 8 insertions(+), 3 deletions(-) Reviewed-by: Thierry Reding signature.asc Description: PGP signature _

Re: [Intel-gfx] [PATCH v3 2/4] drm/i915: Add reverse mapping between port and intel_encoder

2015-12-07 Thread Takashi Iwai
On Mon, 07 Dec 2015 11:30:05 +0100, Jani Nikula wrote: > > On Fri, 04 Dec 2015, Takashi Iwai wrote: > > This patch adds a reverse mapping from a digital port number to > > intel_encoder object containing the corresponding intel_digital_port. > > It simplifies the query of the encoder a lot. > > >

Re: [Intel-gfx] [PATCH 01/28] drm: Polish fbdev helper struct docs

2015-12-07 Thread Thierry Reding
On Fri, Dec 04, 2015 at 09:45:42AM +0100, Daniel Vetter wrote: > Mostly this is just adding extensive docs for the callbacks, but also > a few other additions. > > v2: Use FIXME comments to annotate helper hooks that should be > replaced. > > Signed-off-by: Daniel Vetter > --- > include/drm/drm

Re: [Intel-gfx] [PATCH 03/28] drm: Reorganize helper vtables and their docs

2015-12-07 Thread Thierry Reding
On Fri, Dec 04, 2015 at 09:45:44AM +0100, Daniel Vetter wrote: [...] > diff --git a/drivers/gpu/drm/drm_crtc_helper.c > b/drivers/gpu/drm/drm_crtc_helper.c > index 10d0989db273..077e48d3cac2 100644 > --- a/drivers/gpu/drm/drm_crtc_helper.c > +++ b/drivers/gpu/drm/drm_crtc_helper.c > @@ -62,6 +62,1

Re: [Intel-gfx] [PATCH 02/28] drm: Move LEAVE/ENTER_ATOMIC_MODESET to fbdev helpers

2015-12-07 Thread Thierry Reding
On Fri, Dec 04, 2015 at 09:45:43AM +0100, Daniel Vetter wrote: > This is only used for kgdb (and previously panic) handlers in > the fbdev emulation, so belongs there. > > Note that this means we'll leave behind a forward declaration, but > once all the helper vtables are consolidated (in the next

Re: [Intel-gfx] [PATCH 04/28] drm: Make helper vtable pointers type-safe

2015-12-07 Thread Thierry Reding
On Fri, Dec 04, 2015 at 09:45:45AM +0100, Daniel Vetter wrote: > Originally the idea behind void* was to allow different sets of > helpers. But now we have that (with probe, plane, crtc and atomic > helpers) and we still just use the same set of vtables. That's the > only way to make the individual

Re: [Intel-gfx] [PATCH 05/28] drm: Merge helper docbook into kerneldoc comments

2015-12-07 Thread Thierry Reding
On Fri, Dec 04, 2015 at 09:45:46AM +0100, Daniel Vetter wrote: [...] > diff --git a/drivers/gpu/drm/drm_crtc_helper.c > b/drivers/gpu/drm/drm_crtc_helper.c > index 077e48d3cac2..c4fbcf8e6664 100644 > --- a/drivers/gpu/drm/drm_crtc_helper.c > +++ b/drivers/gpu/drm/drm_crtc_helper.c > @@ -51,6 +51,1

Re: [Intel-gfx] [PATCH 06/28] drm/bridge: Improve kerneldoc

2015-12-07 Thread Thierry Reding
On Fri, Dec 04, 2015 at 09:45:47AM +0100, Daniel Vetter wrote: > Especially document the assumptions and semantics of the callbacks > carefully. Just a warm-up excercise really. > > v2: Spelling fixes (Eric). > > v3: Consolidate more with existing docs: > > - Remove the overview section explaini

Re: [Intel-gfx] [PATCH 07/28] drm: Update drm_plane_funcs kerneldoc

2015-12-07 Thread Thierry Reding
On Fri, Dec 04, 2015 at 09:45:48AM +0100, Daniel Vetter wrote: > diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h [...] > + /** > + * @destroy: > + * > + * Clean up CRTC resources. This is only called at driver unload time Perhaps drop "only" because there are more t

Re: [Intel-gfx] [PATCH 08/28] drm/noveau: Ditch NULL save/restore hook assignments

2015-12-07 Thread Thierry Reding
On Fri, Dec 04, 2015 at 09:45:49AM +0100, Daniel Vetter wrote: > gcc does this for us, and these hooks will be gone soon. In the subject: s/noveau/nouveau/, otherwise: Reviewed-by: Thierry Reding signature.asc Description: PGP signature ___ Intel-gfx

Re: [Intel-gfx] [PATCH 09/28] drm/qxl: Drop dummy save/restore hooks

2015-12-07 Thread Thierry Reding
On Fri, Dec 04, 2015 at 09:45:50AM +0100, Daniel Vetter wrote: > These hooks will be gone soon. > > Cc: Dave Airlie > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/qxl/qxl_display.c | 12 > 1 file changed, 12 deletions(-) Reviewed-by: Thierry Reding signature.asc Descrip

Re: [Intel-gfx] [PATCH 10/28] drm/virtio: Drop dummy save/restore functions

2015-12-07 Thread Thierry Reding
On Fri, Dec 04, 2015 at 09:45:51AM +0100, Daniel Vetter wrote: > These hooks will be gone soon. > > Cc: Dave Airlie > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/virtio/virtgpu_display.c | 12 > 1 file changed, 12 deletions(-) Reviewed-by: Thierry Reding signature.asc

Re: [Intel-gfx] [PATCH 11/28] drm/vmwgfx: Drop dummy save/restore hooks

2015-12-07 Thread Thierry Reding
On Fri, Dec 04, 2015 at 09:45:52AM +0100, Daniel Vetter wrote: > These hooks will be gone soon. > > Cc: Thomas Hellstrom > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 16 > drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c | 4 > drivers/gpu/drm/vmwgfx/

Re: [Intel-gfx] [PATCH 01/28] drm: Polish fbdev helper struct docs

2015-12-07 Thread Daniel Vetter
On Mon, Dec 07, 2015 at 11:45:22AM +0100, Thierry Reding wrote: > On Fri, Dec 04, 2015 at 09:45:42AM +0100, Daniel Vetter wrote: > > Mostly this is just adding extensive docs for the callbacks, but also > > a few other additions. > > > > v2: Use FIXME comments to annotate helper hooks that should

Re: [Intel-gfx] [PATCH 12/28] drm/gma500: Move to private save/restore hooks

2015-12-07 Thread Thierry Reding
On Fri, Dec 04, 2015 at 09:45:53AM +0100, Daniel Vetter wrote: > I want to remove the core ones since with atomic drivers system > suspend/resume is solved much differently. And there's only 2 drivers > (nouveau besides gma500) really using them. > > Cc: Patrik Jakobsson > Signed-off-by: Daniel V

Re: [Intel-gfx] [PATCH] drm/nouveau: Use private save/restore hooks for CRTCs

2015-12-07 Thread Thierry Reding
On Fri, Dec 04, 2015 at 05:13:38PM +0100, Daniel Vetter wrote: > I want to remove the core ones since with atomic drivers system > suspend/resume is solved much differently. And there's only 2 drivers > (gma500 besides nouveau) really using them. > > v2: Fixup bugs Ilia spotted. > > Cc: Ben Skegg

Re: [Intel-gfx] [PATCH 01/28] drm: Polish fbdev helper struct docs

2015-12-07 Thread Thierry Reding
On Mon, Dec 07, 2015 at 12:50:24PM +0100, Daniel Vetter wrote: > On Mon, Dec 07, 2015 at 11:45:22AM +0100, Thierry Reding wrote: > > On Fri, Dec 04, 2015 at 09:45:42AM +0100, Daniel Vetter wrote: > > > Mostly this is just adding extensive docs for the callbacks, but also > > > a few other additions

Re: [Intel-gfx] [PATCH 14/28] drm: Remove crtc/connector->save/restore hooks

2015-12-07 Thread Thierry Reding
On Fri, Dec 04, 2015 at 09:45:55AM +0100, Daniel Vetter wrote: > They're not how system suspend/resume should be done with atomic > (there's new helpers for that developed by Thierry Redding), and for s/Redding/Reding/ =) > legacy drivers this really should be a helper hook and not a core one. >

Re: [Intel-gfx] [PATCH 03/28] drm: Reorganize helper vtables and their docs

2015-12-07 Thread Daniel Vetter
On Mon, Dec 07, 2015 at 12:00:09PM +0100, Thierry Reding wrote: > On Fri, Dec 04, 2015 at 09:45:44AM +0100, Daniel Vetter wrote: > [...] > > diff --git a/drivers/gpu/drm/drm_crtc_helper.c > > b/drivers/gpu/drm/drm_crtc_helper.c > > index 10d0989db273..077e48d3cac2 100644 > > --- a/drivers/gpu/drm/

Re: [Intel-gfx] [PATCH] drm: Move encoder->save/restore into nouveau

2015-12-07 Thread Thierry Reding
On Fri, Dec 04, 2015 at 05:14:07PM +0100, Daniel Vetter wrote: > Nouveau is the only user, and atomic drivers should do state > save/restoring differently. So move it into noveau. > > Saves me typing some kerneldoc, too ;-) > > v2: Move misplaced hunk into earlier nouveau patch. > > Cc: Ilia Mir

Re: [Intel-gfx] [PATCH 16/28] drm: Document drm_atomic_*_get_property

2015-12-07 Thread Thierry Reding
On Fri, Dec 04, 2015 at 09:45:57AM +0100, Daniel Vetter wrote: > Yes these are internal functions and not exported and we generally > don't document them. But for symmetry with the _set_property functions > (which are exported for the atomic helpers) I'd like to document them. > Upcoming vtable ker

Re: [Intel-gfx] [PATCH] Always mark GEM objects as dirty when written by the CPU

2015-12-07 Thread Dave Gordon
On 07/12/15 08:29, Daniel Vetter wrote: On Fri, Dec 04, 2015 at 05:28:29PM +, Dave Gordon wrote: On 04/12/15 09:57, Daniel Vetter wrote: On Tue, Dec 01, 2015 at 01:21:07PM +, Dave Gordon wrote: On 01/12/15 13:04, Chris Wilson wrote: On Tue, Dec 01, 2015 at 12:42:02PM +, Dave Gordo

Re: [Intel-gfx] [PATCH 17/28] drm: Document drm_connector_funcs

2015-12-07 Thread Thierry Reding
On Fri, Dec 04, 2015 at 09:45:58AM +0100, Daniel Vetter wrote: > The special case here is that both ->detect and ->force are actually > functions only called by the probe helpers and hence really shouldn't > be here. But since they've used by pretty much every driver I figured > it's better to just

Re: [Intel-gfx] [PATCH 18/28] drm: connector->dpms is not optional

2015-12-07 Thread Thierry Reding
On Fri, Dec 04, 2015 at 09:45:59AM +0100, Daniel Vetter wrote: > We always register the DPMS property, it's really a fundamental > part of a display driver. So don't check whether the vfunc is there, > it's non-optional > > Yes I've audited all the almost 100 drm_connector_funcs we have, no > one

Re: [Intel-gfx] [PATCH 19/28] drm: document drm_crtc_funcs

2015-12-07 Thread Thierry Reding
On Fri, Dec 04, 2015 at 09:46:00AM +0100, Daniel Vetter wrote: [...] > diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h > index fbfe617bc492..72a7e096dd42 100644 > --- a/include/drm/drm_crtc.h > +++ b/include/drm/drm_crtc.h > @@ -320,12 +320,6 @@ struct drm_crtc_state { > > /** > *

Re: [Intel-gfx] [PATCH 03/28] drm: Reorganize helper vtables and their docs

2015-12-07 Thread Thierry Reding
On Mon, Dec 07, 2015 at 12:59:33PM +0100, Daniel Vetter wrote: > On Mon, Dec 07, 2015 at 12:00:09PM +0100, Thierry Reding wrote: > > On Fri, Dec 04, 2015 at 09:45:44AM +0100, Daniel Vetter wrote: > > [...] > > > diff --git a/drivers/gpu/drm/drm_crtc_helper.c > > > b/drivers/gpu/drm/drm_crtc_helper

Re: [Intel-gfx] [PATCH 07/28] drm: Update drm_plane_funcs kerneldoc

2015-12-07 Thread Daniel Vetter
On Mon, Dec 07, 2015 at 12:46:38PM +0100, Thierry Reding wrote: > On Fri, Dec 04, 2015 at 09:45:48AM +0100, Daniel Vetter wrote: > > diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h > [...] > > + /** > > +* @destroy: > > +* > > +* Clean up CRTC resources. This is only call

Re: [Intel-gfx] [PATCH 20/28] drm: Add kerneldoc for drm_framebuffer_funcs

2015-12-07 Thread Thierry Reding
On Fri, Dec 04, 2015 at 09:46:01AM +0100, Daniel Vetter wrote: > While typing these I noticed that ->dirty is a bit a can of worms > and even supports blt/fill semantics ... shocked me a bit. > > Oh well it's defined in a way that nothing bad (just a bit of inefficiency) > will happen for drivers

Re: [Intel-gfx] [PATCH 07/28] drm: Update drm_plane_funcs kerneldoc

2015-12-07 Thread Thierry Reding
On Mon, Dec 07, 2015 at 01:34:16PM +0100, Daniel Vetter wrote: > On Mon, Dec 07, 2015 at 12:46:38PM +0100, Thierry Reding wrote: > > On Fri, Dec 04, 2015 at 09:45:48AM +0100, Daniel Vetter wrote: > > > diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h > > [...] > > > + /** > > > + * @de

Re: [Intel-gfx] [PATCH 16/28] drm: Document drm_atomic_*_get_property

2015-12-07 Thread Daniel Vetter
On Mon, Dec 07, 2015 at 01:01:35PM +0100, Thierry Reding wrote: > On Fri, Dec 04, 2015 at 09:45:57AM +0100, Daniel Vetter wrote: > > Yes these are internal functions and not exported and we generally > > don't document them. But for symmetry with the _set_property functions > > (which are exported

Re: [Intel-gfx] [PATCH] Always mark GEM objects as dirty when written by the CPU

2015-12-07 Thread Dave Gordon
On 01/12/15 12:42, Dave Gordon wrote: In various places, one or more pages of a GEM object are mapped into CPU address space and updated. In each such case, the object should be marked dirty, to ensure that the modifications are not discarded if the object is evicted under memory pressure. This

Re: [Intel-gfx] [PATCH 07/28] drm: Update drm_plane_funcs kerneldoc

2015-12-07 Thread Daniel Vetter
On Mon, Dec 07, 2015 at 01:43:49PM +0100, Thierry Reding wrote: > On Mon, Dec 07, 2015 at 01:34:16PM +0100, Daniel Vetter wrote: > > On Mon, Dec 07, 2015 at 12:46:38PM +0100, Thierry Reding wrote: > > > On Fri, Dec 04, 2015 at 09:45:48AM +0100, Daniel Vetter wrote: > > > > diff --git a/include/drm/

Re: [Intel-gfx] [PATCH 21/28] drm: Kerneldoc for drm_mode_config_funcs

2015-12-07 Thread Thierry Reding
On Fri, Dec 04, 2015 at 09:46:02AM +0100, Daniel Vetter wrote: [...] > diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h [...] > struct drm_mode_config_funcs { > + /** > + * @fb_create: > + * > + * Create a new framebuffer object. The core does basic checks on the > +

Re: [Intel-gfx] [PATCH 22/28] drm/atomic-helper: Reject attempts at re-stealing encoders

2015-12-07 Thread Thierry Reding
On Fri, Dec 04, 2015 at 09:46:03AM +0100, Daniel Vetter wrote: > This can happen when we run out of encoders for a multi-crtc modeset, > or also when userspace is silly and tries to clone multiple connectors > that need the same encoder on the same crtc. > > Reported-and-Tested-and-Reviewed-by: Ma

Re: [Intel-gfx] [maintainer-tools PATCH 2/2] dim: add a QUICKSTART section to dim.rst

2015-12-07 Thread Zanoni, Paulo R
Em Sex, 2015-12-04 às 10:40 +0200, Jani Nikula escreveu: > On Thu, 03 Dec 2015, Paulo Zanoni wrote: > > Because just running dim help doesn't give you the greater picture > > of > > the workflow. All the text here is based on an email written by > > Daniel > > Vetter, so the credits go to him. Any

Re: [Intel-gfx] [PATCH 21/28] drm: Kerneldoc for drm_mode_config_funcs

2015-12-07 Thread Daniel Vetter
On Mon, Dec 07, 2015 at 02:14:48PM +0100, Thierry Reding wrote: > On Fri, Dec 04, 2015 at 09:46:02AM +0100, Daniel Vetter wrote: > > +* This list is exhaustive. Specifically this hook is not allowed to > > +* return -EINVAL (any invalid requests should be caught in > > +* @atomic_check)

Re: [Intel-gfx] [PATCH 22/28] drm/atomic-helper: Reject attempts at re-stealing encoders

2015-12-07 Thread Daniel Vetter
On Mon, Dec 07, 2015 at 02:26:04PM +0100, Thierry Reding wrote: > On Fri, Dec 04, 2015 at 09:46:03AM +0100, Daniel Vetter wrote: > > This can happen when we run out of encoders for a multi-crtc modeset, > > or also when userspace is silly and tries to clone multiple connectors > > that need the sam

Re: [Intel-gfx] [PATCH 26/28] drm: Move drm_display_mode an related docs into kerneldoc

2015-12-07 Thread Ville Syrjälä
On Fri, Dec 04, 2015 at 09:46:07AM +0100, Daniel Vetter wrote: > This was in the documentation for modeset helper hooks, where it is a > bit misplaced. > > v2: Reindent the drm_mode_status enum, inspired by Ville. > > Cc: ville.syrj...@linux.intel.com > Signed-off-by: Daniel Vetter > --- > Docu

Re: [Intel-gfx] [PATCH 28/28] drm/atomic-helper: Reject legacy flips on a disabled pipe

2015-12-07 Thread Ville Syrjälä
On Fri, Dec 04, 2015 at 09:46:09AM +0100, Daniel Vetter wrote: > We want this for consistency with existing page_flip semantics. > > Since this spurred quite a discussion on IRC also document why we > reject even generation when the pipe is off: It's not that it's hard > to implement, but userspac

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Support for creating Stolen memory backed objects

2015-12-07 Thread Tvrtko Ursulin
Hi, On 11/11/15 10:36, ankitprasad.r.sha...@intel.com wrote: From: Ankitprasad Sharma Extend the drm_i915_gem_create structure to add support for creating Stolen memory backed objects. Added a new flag through which user can specify the preference to allocate the object from stolen memory, wh

Re: [Intel-gfx] [PATCH igt 2/2] kms_frontbuffer_tracking: standardize the used FB sizes

2015-12-07 Thread Zanoni, Paulo R
Em Sex, 2015-12-04 às 16:28 +0100, Daniel Vetter escreveu: > On Wed, Dec 02, 2015 at 10:47:01AM -0200, Paulo Zanoni wrote: > > We want to make sure that both tiled and untiled buffers have the > > same > > size for the same width/height/format. This will allow better > > control > > over the failur

Re: [Intel-gfx] [PATCH 23/28] drm: Document drm_plane_helper_funcs

2015-12-07 Thread Thierry Reding
On Fri, Dec 04, 2015 at 09:46:04AM +0100, Daniel Vetter wrote: > Plus related hooks used to do atomic plane updates since they only > really make sense as a package. > > Signed-off-by: Daniel Vetter > --- > include/drm/drm_modeset_helper_vtables.h | 209 > +-- > 1 fi

Re: [Intel-gfx] [PATCH] drm/i915: vlv: clamp minimum RPS frequency to what Punit allows

2015-12-07 Thread Ville Syrjälä
On Fri, Dec 05, 2014 at 11:23:29PM +0200, Ville Syrjälä wrote: > On Thu, Dec 04, 2014 at 06:39:35PM +0200, Imre Deak wrote: > > As described in the code comment, I couldn't set the minimum RPS > > frequency on my BYT-M B0 to the minimum allowed as reported by Punit. > > Fix this by clamping the min

Re: [Intel-gfx] [PATCH 24/28] drm: Document drm_connector_helper_funcs

2015-12-07 Thread Thierry Reding
On Fri, Dec 04, 2015 at 09:46:05AM +0100, Daniel Vetter wrote: > Nothing special, except the somewhat awkard split in probe helper "awkward" > callbacks between here and drm_crtc_funcs. > > Signed-off-by: Daniel Vetter > --- > include/drm/drm_modeset_helper_vtables.h | 106 > +

Re: [Intel-gfx] [PATCH 23/28] drm: Document drm_plane_helper_funcs

2015-12-07 Thread Daniel Vetter
On Mon, Dec 07, 2015 at 03:27:59PM +0100, Thierry Reding wrote: > On Fri, Dec 04, 2015 at 09:46:04AM +0100, Daniel Vetter wrote: > > +* mus ensure that drm_atomic_helper_check_modeset() has been called > > +* beforehand. > > Perhaps mention that the default drm_atomic_helper_check() > impl

Re: [Intel-gfx] [PATCH 25/28] drm/atomic-helper: Mention the new system/resume helpers the docs

2015-12-07 Thread Thierry Reding
On Fri, Dec 04, 2015 at 09:46:06AM +0100, Daniel Vetter wrote: > They have pretty kerneldoc already, but better to link to that in > one of the overview sections. > > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/drm_atomic_helper.c | 6 ++ > 1 file changed, 6 insertions(+) Reviewed-

Re: [Intel-gfx] [PATCH 24/28] drm: Document drm_connector_helper_funcs

2015-12-07 Thread Daniel Vetter
On Mon, Dec 07, 2015 at 03:42:22PM +0100, Thierry Reding wrote: > On Fri, Dec 04, 2015 at 09:46:05AM +0100, Daniel Vetter wrote: > > Nothing special, except the somewhat awkard split in probe helper > > "awkward" > > > callbacks between here and drm_crtc_funcs. > > > > Signed-off-by: Daniel Vett

Re: [Intel-gfx] [PATCH 26/28] drm: Move drm_display_mode an related docs into kerneldoc

2015-12-07 Thread Thierry Reding
On Fri, Dec 04, 2015 at 09:46:07AM +0100, Daniel Vetter wrote: [...] > diff --git a/include/drm/drm_modes.h b/include/drm/drm_modes.h [...] > @@ -96,17 +141,124 @@ enum drm_mode_status { > > #define DRM_MODE_FLAG_3D_MAX DRM_MODE_FLAG_3D_SIDE_BY_SIDE_HALF > > +/** > + * struct drm_display_mode

Re: [Intel-gfx] [PATCH v7] drm/i915: Slaughter the thundering i915_wait_request herd

2015-12-07 Thread Tvrtko Ursulin
Hi, On 03/12/15 16:22, Chris Wilson wrote: One particularly stressful scenario consists of many independent tasks all competing for GPU time and waiting upon the results (e.g. realtime transcoding of many, many streams). One bottleneck in particular is that each client waits on its own results,

Re: [Intel-gfx] [PATCH 2/2] igt/pm_rps: Add checks for freq = idle (RPn) in specific cases.

2015-12-07 Thread Imre Deak
On pe, 2015-12-04 at 14:41 -0800, Bob Paauwe wrote: > On Fri, 4 Dec 2015 22:58:50 +0200 > Imre Deak wrote: > [...] > So we want the policy to be that we'll only drop below min to idle > when > the GPU transitions from not idle to idle.  Without that transition, > we'll stay at the user specified m

[Intel-gfx] [drm-intel:topic/drm-misc 48/56] drivers/gpu/drm/i2c/tda998x_drv.c:1354:2: error: unknown field 'save' specified in initializer

2015-12-07 Thread kbuild test robot
tree: git://anongit.freedesktop.org/drm-intel topic/drm-misc head: 559f5ad9457a9cf36c82762db5f17f7e665e7897 commit: 3cf66463f01d91553758bb0d820f6c7dfbf708af [48/56] drm: Move encoder->save/restore into nouveau config: x86_64-rhel (attached as .config) reproduce: git checkout 3cf66463f0

Re: [Intel-gfx] [PATCH 27/28] drm: Document drm_encoder/crtc_helper_funcs

2015-12-07 Thread Thierry Reding
On Fri, Dec 04, 2015 at 09:46:08AM +0100, Daniel Vetter wrote: > Mostly this is about all the callbacks used to modesets by both legacy "used for modesets"? > CRTC helpers and atomic helpers and I figured it doesn't make all that > much sense to split this up. > > Signed-off-by: Daniel Vetter >

[Intel-gfx] [PATCH i-g-t v2] tests: update .gitignore and add a Makefile rule to create it

2015-12-07 Thread Thomas Wood
v2: generate the .gitignore file with the default target Signed-off-by: Thomas Wood --- tests/.gitignore | 13 +++-- tests/Makefile.am | 4 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/tests/.gitignore b/tests/.gitignore index 6377007..f127bfc 100644 --- a/tests

Re: [Intel-gfx] [PATCH 28/28] drm/atomic-helper: Reject legacy flips on a disabled pipe

2015-12-07 Thread Thierry Reding
On Fri, Dec 04, 2015 at 09:46:09AM +0100, Daniel Vetter wrote: > We want this for consistency with existing page_flip semantics. > > Since this spurred quite a discussion on IRC also document why we > reject even generation when the pipe is off: It's not that it's hard > to implement, but userspac

Re: [Intel-gfx] [PATCH 24/28] drm: Document drm_connector_helper_funcs

2015-12-07 Thread Thierry Reding
On Mon, Dec 07, 2015 at 03:48:37PM +0100, Daniel Vetter wrote: > On Mon, Dec 07, 2015 at 03:42:22PM +0100, Thierry Reding wrote: > > On Fri, Dec 04, 2015 at 09:46:05AM +0100, Daniel Vetter wrote: > > > Nothing special, except the somewhat awkard split in probe helper > > > > "awkward" > > > > > c

Re: [Intel-gfx] [PATCH 28/28] drm/atomic-helper: Reject legacy flips on a disabled pipe

2015-12-07 Thread Daniel Stone
Hi, On 4 December 2015 at 08:46, Daniel Vetter wrote: > + /* > +* Reject event generation for when a CRTC is off and stays off. It > +* wouldn't be hard to implement this, but userspace has a track > record > +* of happily burning through 100% cpu (or worse, crash)

Re: [Intel-gfx] [PATCH 26/28] drm: Move drm_display_mode an related docs into kerneldoc

2015-12-07 Thread Daniel Vetter
On Mon, Dec 07, 2015 at 04:02:38PM +0100, Thierry Reding wrote: > On Fri, Dec 04, 2015 at 09:46:07AM +0100, Daniel Vetter wrote: > > @@ -140,12 +352,48 @@ struct drm_display_mode { > > int crtc_vsync_end; > > int crtc_vtotal; > > > > - /* Driver private mode info */ > > + /** > > +

[Intel-gfx] [drm-intel:topic/drm-misc 45/56] drivers/gpu/drm/gma500/mdfld_dsi_output.c:564:11: error: 'struct drm_connector' has no member named 'save'

2015-12-07 Thread kbuild test robot
tree: git://anongit.freedesktop.org/drm-intel topic/drm-misc head: 559f5ad9457a9cf36c82762db5f17f7e665e7897 commit: 6e83aa2691e9d2f20a45eb9406650ef1f0fd5e68 [45/56] drm/gma500: Move to private save/restore hooks config: i386-allmodconfig (attached as .config) reproduce: git checkout 6e

[Intel-gfx] [PATCH 1/2] drm/i915/skl: Disable coarse power gating up until F0

2015-12-07 Thread Mika Kuoppala
There is conflicting info between E0 and F0 steppings for this workarounds. Trust more authoritative source and be conservative and extend also for F0. This prevents numerous (>50) gpu hangs with SKL GT4e during piglit run. References: HSD: gen9lp/2134184 Cc: Sagar Arun Kamble Signed-off-by: Mik

[Intel-gfx] [PATCH 2/2] drm/i915/skl: Double RC6 WRL always on

2015-12-07 Thread Mika Kuoppala
WaRsDoubleRc6WrlWithCoarsePowerGating should be enabled for all Skylakes. Make it so. Cc: Sagar Arun Kamble Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/intel_pm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i9

Re: [Intel-gfx] [PATCH i-g-t 1/2] lib/kms: Turn the based_edid into a template

2015-12-07 Thread Thomas Wood
based_edid should be "base edid"? On 4 December 2015 at 14:08, wrote: > From: Ville Syrjälä > > Signed-off-by: Ville Syrjälä > --- > lib/Makefile.sources| 1 + > lib/igt_edid_template.h | 74 > lib/igt_kms.c | 90 > +++-

Re: [Intel-gfx] [PATCH v2 1/2] mm: Export nr_swap_pages

2015-12-07 Thread Johannes Weiner
On Mon, Dec 07, 2015 at 02:48:12PM +0100, Michal Hocko wrote: > On Fri 04-12-15 15:58:53, Chris Wilson wrote: > > Some modules, like i915.ko, use swappable objects and may try to swap > > them out under memory pressure (via the shrinker). Before doing so, they > > want to check using get_nr_swap_pa

[Intel-gfx] [drm-intel:topic/drm-misc 58/59] DockBook: include/drm/drm_modes.h:398: warning: No description found for parameter 'crtc_hblank_start'

2015-12-07 Thread kbuild test robot
tree: git://anongit.freedesktop.org/drm-intel topic/drm-misc head: b6cfbed3ba1964b54b684fd3f8854f28fc4fefa4 commit: dcf5f60f41acb45ce8f348a067afafba4c87e4dd [58/59] drm: Move drm_display_mode an related docs into kerneldoc reproduce: make htmldocs All warnings (new ones prefixed by >>): d

Re: [Intel-gfx] [PATCH v2 05/10] drm/i915: Disable CLKOUT_DP bending on LPT/WPT as needed

2015-12-07 Thread Paulo Zanoni
2015-12-04 18:19 GMT-02:00 : > From: Ville Syrjälä > > When we want to use SPLL for FDI we want SSC, which means we have to > disable clock bending for the PCH SSC reference (bend and spread are > mutually exclusive). So let's turn off bending when we want spread. > In case the BIOS enabled clock

[Intel-gfx] [PATCH v8] drm/i915: Extend LRC pinning to cover GPU context writeback

2015-12-07 Thread Nick Hoath
Use the first retired request on a new context to unpin the old context. This ensures that the hw context remains bound until it has been written back to by the GPU. Now that the context is pinned until later in the request/context lifecycle, it no longer needs to be pinned from context_queue to re

Re: [Intel-gfx] [PATCH] drm/i915: Restore waitboost credit to the synchronous waiter

2015-12-07 Thread Jesse Barnes
On 12/01/2015 02:48 PM, Chris Wilson wrote: > Ideally, we want to automagically have the GPU respond to the > instantaneous load by reclocking itself. However, reclocking occurs > relatively slowly, and to the client waiting for a result from the GPU, > too late. To compensate and reduce the client

Re: [Intel-gfx] [PATCH 4/4] fbdev: Debug knob to register without holding console_lock

2015-12-07 Thread Tomi Valkeinen
On 25/08/15 16:45, Daniel Vetter wrote: > When the usual fbcon legacy options are enabled we have > ->register_framebuffer > ->fb notifier chain calls into fbcon > ->fbcon sets up console on new fbi > ->fbi->set_par > ->drm_fb_helper_set_par exercises full kms api > > And beca

Re: [Intel-gfx] [PATCH v2 07/10] drm/i915: Disable FDI after the CRT port on LPT-H

2015-12-07 Thread Paulo Zanoni
2015-12-04 18:20 GMT-02:00 : > From: Ville Syrjälä > > Bspec modeset sequence tells us to disable the PCH transcoder and > FDI after the CRT port on LPT-H, so let's do that. And the CRT port > should be disabled after the pipe, as we do on other PCH platforms > too since > commit 1ea56e269e13 ("d

Re: [Intel-gfx] [PATCH v2 1/2] mm: Export nr_swap_pages

2015-12-07 Thread Johannes Weiner
On Mon, Dec 07, 2015 at 06:04:35PM +0100, Michal Hocko wrote: > Yes but the counter is an internal thing to the MM and the outside code > should have no business in manipulating it directly. The counter has been global scope forever. If you want to encapsulate it, send a patch yourself and make yo

Re: [Intel-gfx] [PATCH] drm/i915: Add BXT Sprite plane fractional scalings

2015-12-07 Thread Nabendu Maiti
On 11/27/2015 01:00 AM, Ville Syrjälä wrote: On Thu, Nov 26, 2015 at 08:33:42PM +0200, Ville Syrjälä wrote: On Thu, Nov 26, 2015 at 11:49:43PM +0530, Nabendu Maiti wrote: On 11/18/2015 06:49 PM, Ville Syrjälä wrote: On Wed, Nov 18, 2015 at 06:37:17PM +0530, Maiti, Nabendu Bikash wrote: On

Re: [Intel-gfx] [PATCH] drm/i915/bxt: Fix uninitialized variables in intel_check_sprite_plane

2015-12-07 Thread Nabendu Maiti
On 11/26/2015 11:33 PM, Nabendu Maiti wrote: On 11/18/2015 10:56 PM, Ville Syrjälä wrote: On Wed, Nov 18, 2015 at 10:33:55PM +0530, Maiti, Nabendu Bikash wrote: On 11/18/2015 7:00 PM, Ville Syrjälä wrote: On Wed, Nov 18, 2015 at 06:48:37PM +0530, Maiti, Nabendu Bikash wrote: On 11/18/20

[Intel-gfx] [PATCH i-g-t 2/2] kms_psr_sink_crc: Add basic check for PSR active.

2015-12-07 Thread Rodrigo Vivi
It takes from 2 to 5 seconds to run. Cc: Daniel Vetter Signed-off-by: Rodrigo Vivi --- tests/kms_psr_sink_crc.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c index 28ba5c2..4baf131 100644 --- a/tests/kms_psr_sink_crc.c +++ b/tests/k

[Intel-gfx] [PATCH i-g-t 1/2] kms_psr_sink_crc: Introduce PSR BAT test.

2015-12-07 Thread Rodrigo Vivi
This simple test checks if PSR is enabled when it should. Minimal and fastest check possible. To make it faster for BAT we first check if it is enabled and return Success. We just do the dpms_on in case psr is not enabled. So it was probably because display went off maybe in idle. Even for this ca

Re: [Intel-gfx] [PATCH v2 1/2] mm: Export nr_swap_pages

2015-12-07 Thread Dave Gordon
On 07/12/15 16:48, Johannes Weiner wrote: On Mon, Dec 07, 2015 at 02:48:12PM +0100, Michal Hocko wrote: On Fri 04-12-15 15:58:53, Chris Wilson wrote: Some modules, like i915.ko, use swappable objects and may try to swap them out under memory pressure (via the shrinker). Before doing so, they wa

Re: [Intel-gfx] [PATCH] drm/i915: Correcting proper src & dst height - width comparision for 90/270 rotation.

2015-12-07 Thread Nabendu Maiti
On 11/27/2015 12:10 AM, Nabendu Maiti wrote: On 11/18/2015 05:44 PM, Ville Syrjälä wrote: On Wed, Nov 18, 2015 at 05:19:26PM +0530, Nabendu Maiti wrote: On 90/270 rotation case source width and height was not compared properly with destination height and width check plane.Which added errone

[Intel-gfx] [PATCH 4/5] drm/i915: Only set gem object L3 cache level for IVB devices

2015-12-07 Thread Wayne Boyer
Do some further clean up based on the initial review of drm/i915: Separate cherryview from valleyview. In this case, in i915_gem_alloc_context_obj() only call i915_gem_object_set_cache_level() for Ivy Bridge devices since later platforms don't have L3 control bits in the PTE. Cc: Ville Syrjälä C

[Intel-gfx] [PATCH 3/5] drm/i915: Remove VLV A0 hack

2015-12-07 Thread Wayne Boyer
Do some further clean up based on the initial review of drm/i915: Separate cherryview from valleyview. In this case remove a hack for VLV A0. Cc: Ville Syrjälä Cc: Rodrigo Vivi Signed-off-by: Wayne Boyer --- drivers/gpu/drm/i915/i915_gem.c | 8 1 file changed, 8 deletions(-) diff --

[Intel-gfx] [PATCH 1/5] drm/i915: Separate cherryview from valleyview

2015-12-07 Thread Wayne Boyer
The cherryview device shares many characteristics with the valleyview device. When support was added to the driver for cherryview, the corresponding device info structure included .is_valleyview = 1. This is not correct and leads to some confusion. This patch changes .is_valleyview to .is_cherryv

[Intel-gfx] [PATCH 0/5] CHV and VLV separation and clean up

2015-12-07 Thread Wayne Boyer
The cherryview device shares many characteristics with the valleyview device. When support was added to the driver for cherryview, the corresponding device info structure included .is_valleyview = 1. This is not correct and leads to some confusion. In addition to separating cherryview from valley

[Intel-gfx] [PATCH 2/5] drm/i915: Use HAS_PCH_SPLIT to determine correct devices

2015-12-07 Thread Wayne Boyer
Do some further clean up based on the initial review of drm/i915: Separate cherryview from valleyview. In this case check for '(GEN7 || GEN8) && HAS_PCH_SPLIT' since we're reading FUSE_STRAP and SFUSE_STRAP which live in the PCH. Cc: Ville Syrjälä Cc: Rodrigo Vivi Signed-off-by: Wayne Boyer --

[Intel-gfx] [PATCH 5/5] drm/i915: Remove BUG_ON call in vlv_enable_pll

2015-12-07 Thread Wayne Boyer
Do some further clean up based on the initial review of drm/i915: Separate cherryview from valleyview. In this case remove the BUG_ON call in vlv_enable_pll(). Cc: Ville Syrjälä Cc: Rodrigo Vivi Signed-off-by: Wayne Boyer --- drivers/gpu/drm/i915/intel_display.c | 3 --- 1 file changed, 3 del

Re: [Intel-gfx] [PATCH v2 07/10] drm/i915: Disable FDI after the CRT port on LPT-H

2015-12-07 Thread Ville Syrjälä
On Mon, Dec 07, 2015 at 03:51:06PM -0200, Paulo Zanoni wrote: > 2015-12-04 18:20 GMT-02:00 : > > From: Ville Syrjälä > > > > Bspec modeset sequence tells us to disable the PCH transcoder and > > FDI after the CRT port on LPT-H, so let's do that. And the CRT port > > should be disabled after the p

[Intel-gfx] [PATCH] drm/i915: Fix random aux transactions failures.

2015-12-07 Thread Rodrigo Vivi
Mainly aux communications on sink_crc were failing a lot randomly on recent platforms. The first solution was to try to use intel_dp_dpcd_read_wake, but then it was suggested to move retries to drm level. Since drm level was already taking care of retries and didn't want to through random retries

Re: [Intel-gfx] [PATCH v2 1/2] mm: Export nr_swap_pages

2015-12-07 Thread Johannes Weiner
On Mon, Dec 07, 2015 at 06:10:00PM +, Dave Gordon wrote: > Exporting random uncontrolled variables from the kernel to loaded modules is > not really considered best practice. It would be preferable to provide an > accessor function - which is just what the declaration says we have; the > implem

  1   2   >