On Thu, 03 Dec 2015 22:25:48 +0100,
Ville Syrjälä wrote:
>
> On Thu, Dec 03, 2015 at 10:08:05PM +0100, Takashi Iwai wrote:
> > On Thu, 03 Dec 2015 21:33:29 +0100,
> > Ville Syrjälä wrote:
> > >
> > > On Thu, Dec 03, 2015 at 09:00:55PM +0100, Takashi Iwai wrote:
> > > > Hi,
> > > >
> > > > I've e
Reviewed-by: Sagar Arun Kamble
On 12/7/2015 9:59 PM, Mika Kuoppala wrote:
WaRsDoubleRc6WrlWithCoarsePowerGating should
be enabled for all Skylakes. Make it so.
Cc: Sagar Arun Kamble
Signed-off-by: Mika Kuoppala
---
drivers/gpu/drm/i915/intel_pm.c | 3 +--
1 file changed, 1 insertion(+), 2
5:2: error: unknown field 'restore'
specified in initializer
.restore = tda998x_encoder_restore,
^
Caused by commit
79f13ad5d8e0 ("drm: Move encoder->save/restore into nouveau")
I have used the drm-misc tree from next-20151207 for today.
--
Cheers,
Stephen R
tree: git://anongit.freedesktop.org/drm-intel topic/drm-misc
head: 267dce842ac00f8120bd81cd82e30b4ce651fe2d
commit: 79f13ad5d8e07bab735e257639a68539b7974948 [15/26] drm: Move
encoder->save/restore into nouveau
config: x86_64-rhel (attached as .config)
reproduce:
git checkout 79f13ad5d8
Do some further clean up based on the initial review of
drm/i915: Separate cherryview from valleyview.
In this case remove the BUG_ON call in vlv_enable_pll().
v2: Also remove the BUG_ON call in chv_enable_pll(). (Ville)
Cc: Ville Syrjälä
Cc: Rodrigo Vivi
Signed-off-by: Wayne Boyer
---
drive
On 12/7/15, 11:56 AM, "Deak, Imre" wrote:
>On Mon, 2015-12-07 at 21:28 +0200, Ville Syrjälä wrote:
>> On Mon, Dec 07, 2015 at 10:51:09AM -0800, Wayne Boyer wrote:
>> > Do some further clean up based on the initial review of
>> > drm/i915: Separate cherryview from valleyview.
>> >
>> > In this c
This is for Chrome os perspective which is using upstream kernel. We have S3
suspend and resume time limit of 1sec.
Currently suspend of i915 driver takes 280ms and resume takes 600ms. To make
resume faster and also follow edp spec this patch will move
Half of t12 time from resume path to su
On Mon, 7 Dec 2015 17:00:20 +0200
Imre Deak wrote:
> On pe, 2015-12-04 at 14:41 -0800, Bob Paauwe wrote:
> > On Fri, 4 Dec 2015 22:58:50 +0200
> > Imre Deak wrote:
> > [...]
> > So we want the policy to be that we'll only drop below min to idle
> > when
> > the GPU transitions from not idle to i
When changing the sysfs GT min frequency, the kernel won't
automatcilly drop the GT frequency to idle unless the GPU
transitions from busy to idle.
Load the GPU after increasing the GT min frequency to force
a busy to idle transition. This matches the behavior when
decreasing the GT min frequency.
From: Ville Syrjälä
Atomic changes broke check_digital_port_conflicts(). It needs to look
at the global situation instead of just trying to find a conflict
within the current atomic state.
This bug made my HSW explode spectacularly after I had split the DDI
encoders into separate DP and HDMI enc
2015-12-07 18:28 GMT-02:00 :
> From: Abhay Kumar
>
> Moving 250ms from T12 timing to suspend path so that
> resume path will be faster.
Can you please elaborate more on your motivation for this patch? I'm a
little confused. You're trying to make resume faster by making suspend
slower? What are y
From: Abhay Kumar
Moving 250ms from T12 timing to suspend path so that
resume path will be faster.
Signed-off-by: Abhay Kumar
---
drivers/gpu/drm/i915/intel_ddi.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index
Mainly aux communications on sink_crc
were failing a lot randomly on recent platforms.
The first solution was to try to use intel_dp_dpcd_read_wake, but then
it was suggested to move retries to drm level.
Since drm level was already taking care of retries and didn't want
to through random retries
On Mon, 2015-12-07 at 21:28 +0200, Ville Syrjälä wrote:
> On Mon, Dec 07, 2015 at 10:51:09AM -0800, Wayne Boyer wrote:
> > Do some further clean up based on the initial review of
> > drm/i915: Separate cherryview from valleyview.
> >
> > In this case, in i915_gem_alloc_context_obj() only call
> >
On Mon, Dec 07, 2015 at 09:29:32PM +0200, Ville Syrjälä wrote:
> On Mon, Dec 07, 2015 at 10:51:10AM -0800, Wayne Boyer wrote:
> > Do some further clean up based on the initial review of
> > drm/i915: Separate cherryview from valleyview.
> >
> > In this case remove the BUG_ON call in vlv_enable_pll
On Mon, Dec 07, 2015 at 10:51:10AM -0800, Wayne Boyer wrote:
> Do some further clean up based on the initial review of
> drm/i915: Separate cherryview from valleyview.
>
> In this case remove the BUG_ON call in vlv_enable_pll().
Yeah, BUG_ONs aren't very nice.
Reviewed-by: Ville Syrjälä
>
> C
On Mon, Dec 07, 2015 at 10:51:09AM -0800, Wayne Boyer wrote:
> Do some further clean up based on the initial review of
> drm/i915: Separate cherryview from valleyview.
>
> In this case, in i915_gem_alloc_context_obj() only call
> i915_gem_object_set_cache_level() for Ivy Bridge devices
> since lat
[53834.386369] traps: gnome-session-b[2308] general protection
ip:7f10efc1fc2b sp:7ffdfde31880 error:0 in
libc-2.22.so[7f10efba1000+1b7000]
[53834.687584] [ cut here ]
[53834.687607] WARNING: CPU: 0 PID: 23730 at
drivers/gpu/drm/i915/i915_gem_context.c:144
i915_gem_context_f
On Mon, Dec 07, 2015 at 10:51:08AM -0800, Wayne Boyer wrote:
> Do some further clean up based on the initial review of
> drm/i915: Separate cherryview from valleyview.
>
> In this case remove a hack for VLV A0.
>
> Cc: Ville Syrjälä
> Cc: Rodrigo Vivi
> Signed-off-by: Wayne Boyer
> ---
> driv
On Mon, Dec 07, 2015 at 10:51:07AM -0800, Wayne Boyer wrote:
> Do some further clean up based on the initial review of
> drm/i915: Separate cherryview from valleyview.
>
> In this case check for '(GEN7 || GEN8) && HAS_PCH_SPLIT' since we're
> reading FUSE_STRAP and SFUSE_STRAP which live in the PC
On Mon, Dec 07, 2015 at 06:10:00PM +, Dave Gordon wrote:
> Exporting random uncontrolled variables from the kernel to loaded modules is
> not really considered best practice. It would be preferable to provide an
> accessor function - which is just what the declaration says we have; the
> implem
Mainly aux communications on sink_crc
were failing a lot randomly on recent platforms.
The first solution was to try to use intel_dp_dpcd_read_wake, but then
it was suggested to move retries to drm level.
Since drm level was already taking care of retries and didn't want
to through random retries
On Mon, Dec 07, 2015 at 03:51:06PM -0200, Paulo Zanoni wrote:
> 2015-12-04 18:20 GMT-02:00 :
> > From: Ville Syrjälä
> >
> > Bspec modeset sequence tells us to disable the PCH transcoder and
> > FDI after the CRT port on LPT-H, so let's do that. And the CRT port
> > should be disabled after the p
Do some further clean up based on the initial review of
drm/i915: Separate cherryview from valleyview.
In this case remove the BUG_ON call in vlv_enable_pll().
Cc: Ville Syrjälä
Cc: Rodrigo Vivi
Signed-off-by: Wayne Boyer
---
drivers/gpu/drm/i915/intel_display.c | 3 ---
1 file changed, 3 del
Do some further clean up based on the initial review of
drm/i915: Separate cherryview from valleyview.
In this case check for '(GEN7 || GEN8) && HAS_PCH_SPLIT' since we're
reading FUSE_STRAP and SFUSE_STRAP which live in the PCH.
Cc: Ville Syrjälä
Cc: Rodrigo Vivi
Signed-off-by: Wayne Boyer
--
The cherryview device shares many characteristics with the valleyview
device. When support was added to the driver for cherryview, the
corresponding device info structure included .is_valleyview = 1.
This is not correct and leads to some confusion.
This patch changes .is_valleyview to .is_cherryv
Do some further clean up based on the initial review of
drm/i915: Separate cherryview from valleyview.
In this case remove a hack for VLV A0.
Cc: Ville Syrjälä
Cc: Rodrigo Vivi
Signed-off-by: Wayne Boyer
---
drivers/gpu/drm/i915/i915_gem.c | 8
1 file changed, 8 deletions(-)
diff --
The cherryview device shares many characteristics with the valleyview
device. When support was added to the driver for cherryview, the
corresponding device info structure included .is_valleyview = 1.
This is not correct and leads to some confusion.
In addition to separating cherryview from valley
Do some further clean up based on the initial review of
drm/i915: Separate cherryview from valleyview.
In this case, in i915_gem_alloc_context_obj() only call
i915_gem_object_set_cache_level() for Ivy Bridge devices
since later platforms don't have L3 control bits in the PTE.
Cc: Ville Syrjälä
C
On 11/27/2015 12:10 AM, Nabendu Maiti wrote:
On 11/18/2015 05:44 PM, Ville Syrjälä wrote:
On Wed, Nov 18, 2015 at 05:19:26PM +0530, Nabendu Maiti wrote:
On 90/270 rotation case source width and height was not compared
properly with destination height and width check plane.Which added
errone
On 07/12/15 16:48, Johannes Weiner wrote:
On Mon, Dec 07, 2015 at 02:48:12PM +0100, Michal Hocko wrote:
On Fri 04-12-15 15:58:53, Chris Wilson wrote:
Some modules, like i915.ko, use swappable objects and may try to swap
them out under memory pressure (via the shrinker). Before doing so, they
wa
This simple test checks if PSR is enabled when it should.
Minimal and fastest check possible.
To make it faster for BAT we first check if it is enabled and return
Success. We just do the dpms_on in case psr is not enabled. So it was
probably because display went off maybe in idle. Even for this ca
It takes from 2 to 5 seconds to run.
Cc: Daniel Vetter
Signed-off-by: Rodrigo Vivi
---
tests/kms_psr_sink_crc.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c
index 28ba5c2..4baf131 100644
--- a/tests/kms_psr_sink_crc.c
+++ b/tests/k
On 11/26/2015 11:33 PM, Nabendu Maiti wrote:
On 11/18/2015 10:56 PM, Ville Syrjälä wrote:
On Wed, Nov 18, 2015 at 10:33:55PM +0530, Maiti, Nabendu Bikash wrote:
On 11/18/2015 7:00 PM, Ville Syrjälä wrote:
On Wed, Nov 18, 2015 at 06:48:37PM +0530, Maiti, Nabendu Bikash wrote:
On 11/18/20
On 11/27/2015 01:00 AM, Ville Syrjälä wrote:
On Thu, Nov 26, 2015 at 08:33:42PM +0200, Ville Syrjälä wrote:
On Thu, Nov 26, 2015 at 11:49:43PM +0530, Nabendu Maiti wrote:
On 11/18/2015 06:49 PM, Ville Syrjälä wrote:
On Wed, Nov 18, 2015 at 06:37:17PM +0530, Maiti, Nabendu Bikash wrote:
On
On Mon, Dec 07, 2015 at 06:04:35PM +0100, Michal Hocko wrote:
> Yes but the counter is an internal thing to the MM and the outside code
> should have no business in manipulating it directly.
The counter has been global scope forever. If you want to encapsulate
it, send a patch yourself and make yo
2015-12-04 18:20 GMT-02:00 :
> From: Ville Syrjälä
>
> Bspec modeset sequence tells us to disable the PCH transcoder and
> FDI after the CRT port on LPT-H, so let's do that. And the CRT port
> should be disabled after the pipe, as we do on other PCH platforms
> too since
> commit 1ea56e269e13 ("d
On 25/08/15 16:45, Daniel Vetter wrote:
> When the usual fbcon legacy options are enabled we have
> ->register_framebuffer
> ->fb notifier chain calls into fbcon
> ->fbcon sets up console on new fbi
> ->fbi->set_par
> ->drm_fb_helper_set_par exercises full kms api
>
> And beca
On 12/01/2015 02:48 PM, Chris Wilson wrote:
> Ideally, we want to automagically have the GPU respond to the
> instantaneous load by reclocking itself. However, reclocking occurs
> relatively slowly, and to the client waiting for a result from the GPU,
> too late. To compensate and reduce the client
Use the first retired request on a new context to unpin
the old context. This ensures that the hw context remains
bound until it has been written back to by the GPU.
Now that the context is pinned until later in the request/context
lifecycle, it no longer needs to be pinned from context_queue to
re
2015-12-04 18:19 GMT-02:00 :
> From: Ville Syrjälä
>
> When we want to use SPLL for FDI we want SSC, which means we have to
> disable clock bending for the PCH SSC reference (bend and spread are
> mutually exclusive). So let's turn off bending when we want spread.
> In case the BIOS enabled clock
tree: git://anongit.freedesktop.org/drm-intel topic/drm-misc
head: b6cfbed3ba1964b54b684fd3f8854f28fc4fefa4
commit: dcf5f60f41acb45ce8f348a067afafba4c87e4dd [58/59] drm: Move
drm_display_mode an related docs into kerneldoc
reproduce: make htmldocs
All warnings (new ones prefixed by >>):
d
On Mon, Dec 07, 2015 at 02:48:12PM +0100, Michal Hocko wrote:
> On Fri 04-12-15 15:58:53, Chris Wilson wrote:
> > Some modules, like i915.ko, use swappable objects and may try to swap
> > them out under memory pressure (via the shrinker). Before doing so, they
> > want to check using get_nr_swap_pa
based_edid should be "base edid"?
On 4 December 2015 at 14:08, wrote:
> From: Ville Syrjälä
>
> Signed-off-by: Ville Syrjälä
> ---
> lib/Makefile.sources| 1 +
> lib/igt_edid_template.h | 74
> lib/igt_kms.c | 90
> +++-
WaRsDoubleRc6WrlWithCoarsePowerGating should
be enabled for all Skylakes. Make it so.
Cc: Sagar Arun Kamble
Signed-off-by: Mika Kuoppala
---
drivers/gpu/drm/i915/intel_pm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i9
There is conflicting info between E0 and F0 steppings
for this workarounds. Trust more authoritative source and
be conservative and extend also for F0.
This prevents numerous (>50) gpu hangs with SKL GT4e
during piglit run.
References: HSD: gen9lp/2134184
Cc: Sagar Arun Kamble
Signed-off-by: Mik
tree: git://anongit.freedesktop.org/drm-intel topic/drm-misc
head: 559f5ad9457a9cf36c82762db5f17f7e665e7897
commit: 6e83aa2691e9d2f20a45eb9406650ef1f0fd5e68 [45/56] drm/gma500: Move to
private save/restore hooks
config: i386-allmodconfig (attached as .config)
reproduce:
git checkout 6e
On Mon, Dec 07, 2015 at 04:02:38PM +0100, Thierry Reding wrote:
> On Fri, Dec 04, 2015 at 09:46:07AM +0100, Daniel Vetter wrote:
> > @@ -140,12 +352,48 @@ struct drm_display_mode {
> > int crtc_vsync_end;
> > int crtc_vtotal;
> >
> > - /* Driver private mode info */
> > + /**
> > +
Hi,
On 4 December 2015 at 08:46, Daniel Vetter wrote:
> + /*
> +* Reject event generation for when a CRTC is off and stays off. It
> +* wouldn't be hard to implement this, but userspace has a track
> record
> +* of happily burning through 100% cpu (or worse, crash)
On Mon, Dec 07, 2015 at 03:48:37PM +0100, Daniel Vetter wrote:
> On Mon, Dec 07, 2015 at 03:42:22PM +0100, Thierry Reding wrote:
> > On Fri, Dec 04, 2015 at 09:46:05AM +0100, Daniel Vetter wrote:
> > > Nothing special, except the somewhat awkard split in probe helper
> >
> > "awkward"
> >
> > > c
On Fri, Dec 04, 2015 at 09:46:09AM +0100, Daniel Vetter wrote:
> We want this for consistency with existing page_flip semantics.
>
> Since this spurred quite a discussion on IRC also document why we
> reject even generation when the pipe is off: It's not that it's hard
> to implement, but userspac
v2: generate the .gitignore file with the default target
Signed-off-by: Thomas Wood
---
tests/.gitignore | 13 +++--
tests/Makefile.am | 4
2 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/tests/.gitignore b/tests/.gitignore
index 6377007..f127bfc 100644
--- a/tests
On Fri, Dec 04, 2015 at 09:46:08AM +0100, Daniel Vetter wrote:
> Mostly this is about all the callbacks used to modesets by both legacy
"used for modesets"?
> CRTC helpers and atomic helpers and I figured it doesn't make all that
> much sense to split this up.
>
> Signed-off-by: Daniel Vetter
>
tree: git://anongit.freedesktop.org/drm-intel topic/drm-misc
head: 559f5ad9457a9cf36c82762db5f17f7e665e7897
commit: 3cf66463f01d91553758bb0d820f6c7dfbf708af [48/56] drm: Move
encoder->save/restore into nouveau
config: x86_64-rhel (attached as .config)
reproduce:
git checkout 3cf66463f0
On pe, 2015-12-04 at 14:41 -0800, Bob Paauwe wrote:
> On Fri, 4 Dec 2015 22:58:50 +0200
> Imre Deak wrote:
> [...]
> So we want the policy to be that we'll only drop below min to idle
> when
> the GPU transitions from not idle to idle. Without that transition,
> we'll stay at the user specified m
Hi,
On 03/12/15 16:22, Chris Wilson wrote:
One particularly stressful scenario consists of many independent tasks
all competing for GPU time and waiting upon the results (e.g. realtime
transcoding of many, many streams). One bottleneck in particular is that
each client waits on its own results,
On Fri, Dec 04, 2015 at 09:46:07AM +0100, Daniel Vetter wrote:
[...]
> diff --git a/include/drm/drm_modes.h b/include/drm/drm_modes.h
[...]
> @@ -96,17 +141,124 @@ enum drm_mode_status {
>
> #define DRM_MODE_FLAG_3D_MAX DRM_MODE_FLAG_3D_SIDE_BY_SIDE_HALF
>
> +/**
> + * struct drm_display_mode
On Mon, Dec 07, 2015 at 03:42:22PM +0100, Thierry Reding wrote:
> On Fri, Dec 04, 2015 at 09:46:05AM +0100, Daniel Vetter wrote:
> > Nothing special, except the somewhat awkard split in probe helper
>
> "awkward"
>
> > callbacks between here and drm_crtc_funcs.
> >
> > Signed-off-by: Daniel Vett
On Fri, Dec 04, 2015 at 09:46:06AM +0100, Daniel Vetter wrote:
> They have pretty kerneldoc already, but better to link to that in
> one of the overview sections.
>
> Signed-off-by: Daniel Vetter
> ---
> drivers/gpu/drm/drm_atomic_helper.c | 6 ++
> 1 file changed, 6 insertions(+)
Reviewed-
On Mon, Dec 07, 2015 at 03:27:59PM +0100, Thierry Reding wrote:
> On Fri, Dec 04, 2015 at 09:46:04AM +0100, Daniel Vetter wrote:
> > +* mus ensure that drm_atomic_helper_check_modeset() has been called
> > +* beforehand.
>
> Perhaps mention that the default drm_atomic_helper_check()
> impl
On Fri, Dec 04, 2015 at 09:46:05AM +0100, Daniel Vetter wrote:
> Nothing special, except the somewhat awkard split in probe helper
"awkward"
> callbacks between here and drm_crtc_funcs.
>
> Signed-off-by: Daniel Vetter
> ---
> include/drm/drm_modeset_helper_vtables.h | 106
> +
On Fri, Dec 05, 2014 at 11:23:29PM +0200, Ville Syrjälä wrote:
> On Thu, Dec 04, 2014 at 06:39:35PM +0200, Imre Deak wrote:
> > As described in the code comment, I couldn't set the minimum RPS
> > frequency on my BYT-M B0 to the minimum allowed as reported by Punit.
> > Fix this by clamping the min
On Fri, Dec 04, 2015 at 09:46:04AM +0100, Daniel Vetter wrote:
> Plus related hooks used to do atomic plane updates since they only
> really make sense as a package.
>
> Signed-off-by: Daniel Vetter
> ---
> include/drm/drm_modeset_helper_vtables.h | 209
> +--
> 1 fi
Em Sex, 2015-12-04 às 16:28 +0100, Daniel Vetter escreveu:
> On Wed, Dec 02, 2015 at 10:47:01AM -0200, Paulo Zanoni wrote:
> > We want to make sure that both tiled and untiled buffers have the
> > same
> > size for the same width/height/format. This will allow better
> > control
> > over the failur
On Fri, Dec 04, 2015 at 09:46:09AM +0100, Daniel Vetter wrote:
> We want this for consistency with existing page_flip semantics.
>
> Since this spurred quite a discussion on IRC also document why we
> reject even generation when the pipe is off: It's not that it's hard
> to implement, but userspac
Hi,
On 11/11/15 10:36, ankitprasad.r.sha...@intel.com wrote:
From: Ankitprasad Sharma
Extend the drm_i915_gem_create structure to add support for
creating Stolen memory backed objects. Added a new flag through
which user can specify the preference to allocate the object from
stolen memory, wh
On Fri, Dec 04, 2015 at 09:46:07AM +0100, Daniel Vetter wrote:
> This was in the documentation for modeset helper hooks, where it is a
> bit misplaced.
>
> v2: Reindent the drm_mode_status enum, inspired by Ville.
>
> Cc: ville.syrj...@linux.intel.com
> Signed-off-by: Daniel Vetter
> ---
> Docu
On Mon, Dec 07, 2015 at 02:26:04PM +0100, Thierry Reding wrote:
> On Fri, Dec 04, 2015 at 09:46:03AM +0100, Daniel Vetter wrote:
> > This can happen when we run out of encoders for a multi-crtc modeset,
> > or also when userspace is silly and tries to clone multiple connectors
> > that need the sam
On Mon, Dec 07, 2015 at 02:14:48PM +0100, Thierry Reding wrote:
> On Fri, Dec 04, 2015 at 09:46:02AM +0100, Daniel Vetter wrote:
> > +* This list is exhaustive. Specifically this hook is not allowed to
> > +* return -EINVAL (any invalid requests should be caught in
> > +* @atomic_check)
Em Sex, 2015-12-04 às 10:40 +0200, Jani Nikula escreveu:
> On Thu, 03 Dec 2015, Paulo Zanoni wrote:
> > Because just running dim help doesn't give you the greater picture
> > of
> > the workflow. All the text here is based on an email written by
> > Daniel
> > Vetter, so the credits go to him. Any
On Fri, Dec 04, 2015 at 09:46:03AM +0100, Daniel Vetter wrote:
> This can happen when we run out of encoders for a multi-crtc modeset,
> or also when userspace is silly and tries to clone multiple connectors
> that need the same encoder on the same crtc.
>
> Reported-and-Tested-and-Reviewed-by: Ma
On Fri, Dec 04, 2015 at 09:46:02AM +0100, Daniel Vetter wrote:
[...]
> diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
[...]
> struct drm_mode_config_funcs {
> + /**
> + * @fb_create:
> + *
> + * Create a new framebuffer object. The core does basic checks on the
> +
On Mon, Dec 07, 2015 at 01:43:49PM +0100, Thierry Reding wrote:
> On Mon, Dec 07, 2015 at 01:34:16PM +0100, Daniel Vetter wrote:
> > On Mon, Dec 07, 2015 at 12:46:38PM +0100, Thierry Reding wrote:
> > > On Fri, Dec 04, 2015 at 09:45:48AM +0100, Daniel Vetter wrote:
> > > > diff --git a/include/drm/
On 01/12/15 12:42, Dave Gordon wrote:
In various places, one or more pages of a GEM object are mapped into CPU
address space and updated. In each such case, the object should be
marked dirty, to ensure that the modifications are not discarded if the
object is evicted under memory pressure.
This
On Mon, Dec 07, 2015 at 01:01:35PM +0100, Thierry Reding wrote:
> On Fri, Dec 04, 2015 at 09:45:57AM +0100, Daniel Vetter wrote:
> > Yes these are internal functions and not exported and we generally
> > don't document them. But for symmetry with the _set_property functions
> > (which are exported
On Mon, Dec 07, 2015 at 01:34:16PM +0100, Daniel Vetter wrote:
> On Mon, Dec 07, 2015 at 12:46:38PM +0100, Thierry Reding wrote:
> > On Fri, Dec 04, 2015 at 09:45:48AM +0100, Daniel Vetter wrote:
> > > diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
> > [...]
> > > + /**
> > > + * @de
On Fri, Dec 04, 2015 at 09:46:01AM +0100, Daniel Vetter wrote:
> While typing these I noticed that ->dirty is a bit a can of worms
> and even supports blt/fill semantics ... shocked me a bit.
>
> Oh well it's defined in a way that nothing bad (just a bit of inefficiency)
> will happen for drivers
On Mon, Dec 07, 2015 at 12:46:38PM +0100, Thierry Reding wrote:
> On Fri, Dec 04, 2015 at 09:45:48AM +0100, Daniel Vetter wrote:
> > diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
> [...]
> > + /**
> > +* @destroy:
> > +*
> > +* Clean up CRTC resources. This is only call
On Mon, Dec 07, 2015 at 12:59:33PM +0100, Daniel Vetter wrote:
> On Mon, Dec 07, 2015 at 12:00:09PM +0100, Thierry Reding wrote:
> > On Fri, Dec 04, 2015 at 09:45:44AM +0100, Daniel Vetter wrote:
> > [...]
> > > diff --git a/drivers/gpu/drm/drm_crtc_helper.c
> > > b/drivers/gpu/drm/drm_crtc_helper
On Fri, Dec 04, 2015 at 09:46:00AM +0100, Daniel Vetter wrote:
[...]
> diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
> index fbfe617bc492..72a7e096dd42 100644
> --- a/include/drm/drm_crtc.h
> +++ b/include/drm/drm_crtc.h
> @@ -320,12 +320,6 @@ struct drm_crtc_state {
>
> /**
> *
On Fri, Dec 04, 2015 at 09:45:59AM +0100, Daniel Vetter wrote:
> We always register the DPMS property, it's really a fundamental
> part of a display driver. So don't check whether the vfunc is there,
> it's non-optional
>
> Yes I've audited all the almost 100 drm_connector_funcs we have, no
> one
On Fri, Dec 04, 2015 at 09:45:58AM +0100, Daniel Vetter wrote:
> The special case here is that both ->detect and ->force are actually
> functions only called by the probe helpers and hence really shouldn't
> be here. But since they've used by pretty much every driver I figured
> it's better to just
On 07/12/15 08:29, Daniel Vetter wrote:
On Fri, Dec 04, 2015 at 05:28:29PM +, Dave Gordon wrote:
On 04/12/15 09:57, Daniel Vetter wrote:
On Tue, Dec 01, 2015 at 01:21:07PM +, Dave Gordon wrote:
On 01/12/15 13:04, Chris Wilson wrote:
On Tue, Dec 01, 2015 at 12:42:02PM +, Dave Gordo
On Fri, Dec 04, 2015 at 09:45:57AM +0100, Daniel Vetter wrote:
> Yes these are internal functions and not exported and we generally
> don't document them. But for symmetry with the _set_property functions
> (which are exported for the atomic helpers) I'd like to document them.
> Upcoming vtable ker
On Mon, Dec 07, 2015 at 12:00:09PM +0100, Thierry Reding wrote:
> On Fri, Dec 04, 2015 at 09:45:44AM +0100, Daniel Vetter wrote:
> [...]
> > diff --git a/drivers/gpu/drm/drm_crtc_helper.c
> > b/drivers/gpu/drm/drm_crtc_helper.c
> > index 10d0989db273..077e48d3cac2 100644
> > --- a/drivers/gpu/drm/
On Fri, Dec 04, 2015 at 05:14:07PM +0100, Daniel Vetter wrote:
> Nouveau is the only user, and atomic drivers should do state
> save/restoring differently. So move it into noveau.
>
> Saves me typing some kerneldoc, too ;-)
>
> v2: Move misplaced hunk into earlier nouveau patch.
>
> Cc: Ilia Mir
On Fri, Dec 04, 2015 at 09:45:55AM +0100, Daniel Vetter wrote:
> They're not how system suspend/resume should be done with atomic
> (there's new helpers for that developed by Thierry Redding), and for
s/Redding/Reding/ =)
> legacy drivers this really should be a helper hook and not a core one.
>
On Mon, Dec 07, 2015 at 12:50:24PM +0100, Daniel Vetter wrote:
> On Mon, Dec 07, 2015 at 11:45:22AM +0100, Thierry Reding wrote:
> > On Fri, Dec 04, 2015 at 09:45:42AM +0100, Daniel Vetter wrote:
> > > Mostly this is just adding extensive docs for the callbacks, but also
> > > a few other additions
On Fri, Dec 04, 2015 at 05:13:38PM +0100, Daniel Vetter wrote:
> I want to remove the core ones since with atomic drivers system
> suspend/resume is solved much differently. And there's only 2 drivers
> (gma500 besides nouveau) really using them.
>
> v2: Fixup bugs Ilia spotted.
>
> Cc: Ben Skegg
On Fri, Dec 04, 2015 at 09:45:53AM +0100, Daniel Vetter wrote:
> I want to remove the core ones since with atomic drivers system
> suspend/resume is solved much differently. And there's only 2 drivers
> (nouveau besides gma500) really using them.
>
> Cc: Patrik Jakobsson
> Signed-off-by: Daniel V
On Mon, Dec 07, 2015 at 11:45:22AM +0100, Thierry Reding wrote:
> On Fri, Dec 04, 2015 at 09:45:42AM +0100, Daniel Vetter wrote:
> > Mostly this is just adding extensive docs for the callbacks, but also
> > a few other additions.
> >
> > v2: Use FIXME comments to annotate helper hooks that should
On Fri, Dec 04, 2015 at 09:45:52AM +0100, Daniel Vetter wrote:
> These hooks will be gone soon.
>
> Cc: Thomas Hellstrom
> Signed-off-by: Daniel Vetter
> ---
> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 16
> drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c | 4
> drivers/gpu/drm/vmwgfx/
On Fri, Dec 04, 2015 at 09:45:50AM +0100, Daniel Vetter wrote:
> These hooks will be gone soon.
>
> Cc: Dave Airlie
> Signed-off-by: Daniel Vetter
> ---
> drivers/gpu/drm/qxl/qxl_display.c | 12
> 1 file changed, 12 deletions(-)
Reviewed-by: Thierry Reding
signature.asc
Descrip
On Fri, Dec 04, 2015 at 09:45:51AM +0100, Daniel Vetter wrote:
> These hooks will be gone soon.
>
> Cc: Dave Airlie
> Signed-off-by: Daniel Vetter
> ---
> drivers/gpu/drm/virtio/virtgpu_display.c | 12
> 1 file changed, 12 deletions(-)
Reviewed-by: Thierry Reding
signature.asc
On Fri, Dec 04, 2015 at 09:45:49AM +0100, Daniel Vetter wrote:
> gcc does this for us, and these hooks will be gone soon.
In the subject: s/noveau/nouveau/, otherwise:
Reviewed-by: Thierry Reding
signature.asc
Description: PGP signature
___
Intel-gfx
On Fri, Dec 04, 2015 at 09:45:48AM +0100, Daniel Vetter wrote:
> diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
[...]
> + /**
> + * @destroy:
> + *
> + * Clean up CRTC resources. This is only called at driver unload time
Perhaps drop "only" because there are more t
On Fri, Dec 04, 2015 at 09:45:47AM +0100, Daniel Vetter wrote:
> Especially document the assumptions and semantics of the callbacks
> carefully. Just a warm-up excercise really.
>
> v2: Spelling fixes (Eric).
>
> v3: Consolidate more with existing docs:
>
> - Remove the overview section explaini
On Fri, Dec 04, 2015 at 09:45:46AM +0100, Daniel Vetter wrote:
[...]
> diff --git a/drivers/gpu/drm/drm_crtc_helper.c
> b/drivers/gpu/drm/drm_crtc_helper.c
> index 077e48d3cac2..c4fbcf8e6664 100644
> --- a/drivers/gpu/drm/drm_crtc_helper.c
> +++ b/drivers/gpu/drm/drm_crtc_helper.c
> @@ -51,6 +51,1
On Fri, Dec 04, 2015 at 09:45:45AM +0100, Daniel Vetter wrote:
> Originally the idea behind void* was to allow different sets of
> helpers. But now we have that (with probe, plane, crtc and atomic
> helpers) and we still just use the same set of vtables. That's the
> only way to make the individual
On Fri, Dec 04, 2015 at 09:45:43AM +0100, Daniel Vetter wrote:
> This is only used for kgdb (and previously panic) handlers in
> the fbdev emulation, so belongs there.
>
> Note that this means we'll leave behind a forward declaration, but
> once all the helper vtables are consolidated (in the next
1 - 100 of 120 matches
Mail list logo
