[Intel-gfx] ✓ Fi.CI.BAT: success for Enable Gen 7 Observation Architecture (rev2)

2016-02-03 Thread Patchwork
== Summary == Series 3024v2 Enable Gen 7 Observation Architecture http://patchwork.freedesktop.org/api/1.0/series/3024/revisions/2/mbox/ bdw-nuci7total:156 pass:147 dwarn:0 dfail:0 fail:0 skip:9 bdw-ultratotal:159 pass:147 dwarn:0 dfail:0 fail:0 skip:12 bsw-nuc

[Intel-gfx] [PULL] drm-intel-fixes

2016-02-03 Thread Jani Nikula
Hi Dave - Intel fixes for 4.5. BR, Jani. The following changes since commit 92e963f50fc74041b5e9e744c330dca48e04f08d: Linux 4.5-rc1 (2016-01-24 13:06:47 -0800) are available in the git repository at: git://anongit.freedesktop.org/drm-intel tags/drm-intel-fixes-2016-02-04 for you to fetc

[Intel-gfx] [PATCH] drm/i915: Fix to allow render compression on primary plane of PIPEB

2016-02-03 Thread Mayuresh Gharpure
Currently, a flip with render compression enabled is failing on primary plane of HDMI panel which is driven by PIPEB, this issue is fixed with this patch Change-Id: I197fe61faffad9da58733ed3f0e8cf6ef8640af7 Signed-off-by: Mayuresh Gharpure --- Please note that this patch depends on following patc

Re: [Intel-gfx] [PATCH] drm/i915/bxt: Save/restore HOTPLUG_CTL during suspend/resume.

2016-02-03 Thread Thulasimani, Sivakumar
On 2/4/2016 7:29 AM, Thulasimani, Sivakumar wrote: On 2/4/2016 7:21 AM, Matt Roper wrote: On Thu, Feb 04, 2016 at 07:17:08AM +0530, Thulasimani, Sivakumar wrote: On 2/4/2016 6:19 AM, Matt Roper wrote: From: Bob Paauwe Broxton has some additional bits in the HOTPLUG_CTL register that ind

Re: [Intel-gfx] [PATCH] drm/i915/bxt: Save/restore HOTPLUG_CTL during suspend/resume.

2016-02-03 Thread Matt Roper
On Thu, Feb 04, 2016 at 07:17:08AM +0530, Thulasimani, Sivakumar wrote: > > > On 2/4/2016 6:19 AM, Matt Roper wrote: > >From: Bob Paauwe > > > >Broxton has some additional bits in the HOTPLUG_CTL register that > >indicate whether the HPD sense lines need to be inverted or not for the > >current

Re: [Intel-gfx] regression bisected: display sync drops after 7221fc33

2016-02-03 Thread dann frazier
On Tue, Feb 02, 2016 at 06:04:32PM -0800, Matt Roper wrote: > On Tue, Feb 02, 2016 at 05:35:49PM -0700, dann frazier wrote: > > On Tue, Feb 02, 2016 at 02:51:20PM -0800, Matt Roper wrote: > > > On Tue, Feb 02, 2016 at 03:21:30PM -0700, dann frazier wrote: > > > > On Tue, Jan 26, 2016 at 09:40:27AM

Re: [Intel-gfx] [PATCH] drm/i915: Protect fbdev across slow or failed initialisation

2016-02-03 Thread Li, Weinan Z
Thanks for your quick response. Yes it is not easily be reproduced in native. In iVGT we startup several VMs simultaneously, it can be reproduced in several cycles, upon 1/10 fail rate. Need to use GUI mode but not text mode to reproduce this issue. BRs, Weinan Li From: Gustav Fägerlind [mail

Re: [Intel-gfx] [PATCH] drm/i915/bxt: Save/restore HOTPLUG_CTL during suspend/resume.

2016-02-03 Thread Thulasimani, Sivakumar
On 2/4/2016 7:21 AM, Matt Roper wrote: On Thu, Feb 04, 2016 at 07:17:08AM +0530, Thulasimani, Sivakumar wrote: On 2/4/2016 6:19 AM, Matt Roper wrote: From: Bob Paauwe Broxton has some additional bits in the HOTPLUG_CTL register that indicate whether the HPD sense lines need to be inverted

Re: [Intel-gfx] [PATCH] drm/i915/bxt: Save/restore HOTPLUG_CTL during suspend/resume.

2016-02-03 Thread Thulasimani, Sivakumar
On 2/4/2016 6:19 AM, Matt Roper wrote: From: Bob Paauwe Broxton has some additional bits in the HOTPLUG_CTL register that indicate whether the HPD sense lines need to be inverted or not for the current platform. The BIOS sets these bits to an appropriate value at boot time, but the value is

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Add i915 perf infrastructure

2016-02-03 Thread Emil Velikov
On 3 February 2016 at 18:39, Robert Bragg wrote: > index a5524cc..68ca26e 100644 > --- a/include/uapi/drm/i915_drm.h > +++ b/include/uapi/drm/i915_drm.h > @@ -1170,4 +1172,71 @@ struct drm_i915_gem_context_param { > __u64 value; > }; > > +#define I915_PERF_FLAG_FD_CLOEXEC (1<<0) >

Re: [Intel-gfx] [PATCH] drm/i915/bxt: Save/restore HOTPLUG_CTL during suspend/resume.

2016-02-03 Thread Matt Roper
On Wed, Feb 03, 2016 at 04:49:07PM -0800, Matt Roper wrote: > From: Bob Paauwe > > Broxton has some additional bits in the HOTPLUG_CTL register that > indicate whether the HPD sense lines need to be inverted or not for the > current platform. The BIOS sets these bits to an appropriate value at >

[Intel-gfx] [PATCH] drm/i915/bxt: Save/restore HOTPLUG_CTL during suspend/resume.

2016-02-03 Thread Matt Roper
From: Bob Paauwe Broxton has some additional bits in the HOTPLUG_CTL register that indicate whether the HPD sense lines need to be inverted or not for the current platform. The BIOS sets these bits to an appropriate value at boot time, but the value is lost across suspend/resume. We need to sav

[Intel-gfx] [PATCH igt 7/9] igt: Add a helper function for creating VC4 BOs.

2016-02-03 Thread Eric Anholt
Signed-off-by: Eric Anholt --- lib/igt_vc4.c | 21 +++-- lib/igt_vc4.h | 1 + tests/vc4_wait_bo.c | 10 ++ 3 files changed, 18 insertions(+), 14 deletions(-) diff --git a/lib/igt_vc4.c b/lib/igt_vc4.c index 15804e9..0233f2b 100644 --- a/lib/igt_vc4.c +++ b/li

[Intel-gfx] [PATCH igt 3/9] igt/vc4_wait_seqno: Add a test for VC4's wait-for-seqno ioctl.

2016-02-03 Thread Eric Anholt
Signed-off-by: Eric Anholt --- tests/Makefile.am | 6 + tests/Makefile.sources | 4 +++ tests/vc4_wait_seqno.c | 69 ++ 3 files changed, 79 insertions(+) create mode 100644 tests/vc4_wait_seqno.c diff --git a/tests/Makefile.am b/tests/M

[Intel-gfx] [PATCH igt 1/9] configure.ac: Test for libdrm_vc4 and build vc4 tests based on it.

2016-02-03 Thread Eric Anholt
Signed-off-by: Eric Anholt --- configure.ac | 12 1 file changed, 12 insertions(+) diff --git a/configure.ac b/configure.ac index ecbfacd..cfbcbf3 100644 --- a/configure.ac +++ b/configure.ac @@ -149,6 +149,18 @@ if test "x$NOUVEAU" = xyes; then fi AM_CONDITIONAL(HAVE_NOUVEAU, [te

[Intel-gfx] [PATCH igt 2/9] igt: Add support for DRIVER_VC4 flags on tests.

2016-02-03 Thread Eric Anholt
Signed-off-by: Eric Anholt --- lib/drmtest.c | 16 ++-- lib/drmtest.h | 1 + 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/lib/drmtest.c b/lib/drmtest.c index 2896af0..7b2227f 100644 --- a/lib/drmtest.c +++ b/lib/drmtest.c @@ -100,6 +100,16 @@ static bool is_i915_de

[Intel-gfx] [PATCH igt 4/9] igt/vc4_wait_bo: Add a test for VC4's wait-for-BO ioctl.

2016-02-03 Thread Eric Anholt
The pad subtest fails currently. Signed-off-by: Eric Anholt --- tests/Makefile.am | 2 ++ tests/Makefile.sources | 1 + tests/vc4_wait_bo.c| 93 ++ 3 files changed, 96 insertions(+) create mode 100644 tests/vc4_wait_bo.c diff --git a/t

[Intel-gfx] [PATCH igt 5/9] igt: Add a helper function for getting a VC4 BO that's been drawn to.

2016-02-03 Thread Eric Anholt
Signed-off-by: Eric Anholt --- lib/Makefile.sources | 2 + lib/igt_vc4.c| 106 +++ lib/igt_vc4.h| 29 ++ 3 files changed, 137 insertions(+) create mode 100644 lib/igt_vc4.c create mode 100644 lib/igt_vc4.h diff --gi

[Intel-gfx] [PATCH igt 8/9] igt/vc4_create_bo: Test various paths in BO creation.

2016-02-03 Thread Eric Anholt
create-bo-0 fails on the current kernel, and it's something I want to fix. Signed-off-by: Eric Anholt --- tests/Makefile.am | 2 ++ tests/Makefile.sources | 1 + tests/vc4_create_bo.c | 91 ++ 3 files changed, 94 insertions(+) create mode

[Intel-gfx] [PATCH igt 9/9] igt/vc4_wait_bo: Add tests with rendering performed.

2016-02-03 Thread Eric Anholt
These caught an unexpected bug with clear colors (we'd get the last executed clear's color in our new BO), while failing to catch the bug I'd been hoping to find all along. Signed-off-by: Eric Anholt --- tests/vc4_wait_bo.c | 41 + 1 file changed, 41 inser

[Intel-gfx] [PATCH igt 6/9] igt: Add a helper function for mapping VC4 BOs.

2016-02-03 Thread Eric Anholt
Signed-off-by: Eric Anholt --- lib/igt_vc4.c | 20 lib/igt_vc4.h | 1 + 2 files changed, 21 insertions(+) diff --git a/lib/igt_vc4.c b/lib/igt_vc4.c index 62e1345..15804e9 100644 --- a/lib/igt_vc4.c +++ b/lib/igt_vc4.c @@ -25,6 +25,7 @@ #include #include #include +#in

Re: [Intel-gfx] [RFC 00/22] Add support for GuC-based SLPC

2016-02-03 Thread Zanoni, Paulo R
Em Qua, 2016-01-20 às 18:26 -0800, tom.orou...@intel.com escreveu: > From: Tom O'Rourke > > SLPC (Single Loop Power Controller) is a replacement for > some host-based power management features.  The SLPC > implemenation runs in firmware on GuC. > > This series is a first request for comments.  T

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Allow i915_gem_object_get_page() on userptr as well

2016-02-03 Thread Jani Nikula
On Fri, 29 Jan 2016, Chris Wilson wrote: > commit 033908aed5a596f6202c848c6bbc8a40fb1a8490 > Author: Dave Gordon > Date: Thu Dec 10 18:51:23 2015 + > > drm/i915: mark GEM object pages dirty when mapped & written by the CPU > > introduced a check into i915_gem_object_get_dirty_pages() th

[Intel-gfx] [PATCH 3/8] drm/i915: Add 'render basic' Haswell OA unit config

2016-02-03 Thread Robert Bragg
Adds a static OA unit, MUX + B Counter configuration for basic render metrics on Haswell. This is autogenerated from an internal XML description of metric sets. Signed-off-by: Robert Bragg --- drivers/gpu/drm/i915/Makefile | 3 +- drivers/gpu/drm/i915/i915_drv.h| 14 drivers/gpu

[Intel-gfx] [PATCH 5/8] drm/i915: advertise available metrics via sysfs

2016-02-03 Thread Robert Bragg
Each metric set is given a sysfs entry like: /sys/class/drm/card0/metrics//id This allows userspace to enumerate the specific sets that are available for the current system. The 'id' file contains an unsigned integer that can be used to open the associated metric set via DRM_IOCTL_I915_PERF_OPEN.

[Intel-gfx] [PATCH 2/8] drm/i915: rename OACONTROL GEN7_OACONTROL

2016-02-03 Thread Robert Bragg
OACONTROL changes quite a bit for gen8, with some bits split out into a per-context OACTXCONTROL register. Rename now before add more gen7 OA registers Signed-off-by: Robert Bragg --- drivers/gpu/drm/i915/i915_cmd_parser.c | 4 ++-- drivers/gpu/drm/i915/i915_reg.h| 2 +- 2 files changed,

[Intel-gfx] [PATCH 7/8] drm/i915: add oa_event_min_timer_exponent sysctl

2016-02-03 Thread Robert Bragg
The minimal sampling period is now configurable via a dev.i915.oa_min_timer_exponent sysctl parameter. Following the precedent set by perf, the default is the minimum that won't (on its own) exceed the default kernel.perf_event_max_sample_rate default of 10 samples/s. Signed-off-by: Robert Br

[Intel-gfx] [PATCH 4/8] drm/i915: Add i915 perf event for Haswell OA unit

2016-02-03 Thread Robert Bragg
Gen graphics hardware can be set up to periodically write snapshots of performance counters into a circular buffer via its Observation Architecture and this patch exposes that capability to userspace via the i915 perf interface. Cc: Chris Wilson Signed-off-by: Robert Bragg Signed-off-by: Zhenyu

[Intel-gfx] [PATCH 8/8] drm/i915: Add more Haswell OA metric sets

2016-02-03 Thread Robert Bragg
This adds 'compute', 'compute extended', 'memory reads', 'memory writes' and 'sampler balance' metric sets for Haswell. Signed-off-by: Robert Bragg --- drivers/gpu/drm/i915/i915_oa_hsw.c | 513 +++-- 1 file changed, 497 insertions(+), 16 deletions(-) diff --git a

[Intel-gfx] [PATCH 1/8] drm/i915: Add i915 perf infrastructure

2016-02-03 Thread Robert Bragg
Adds base i915 perf infrastructure for Gen performance metrics. This adds a DRM_IOCTL_I915_PERF_OPEN ioctl that takes an array of uint64 properties to configure a stream of metrics and returns a new fd usable with standard VFS system calls including read() to read typed and sized records; ioctl()

[Intel-gfx] [PATCH 6/8] drm/i915: Add dev.i915.perf_event_paranoid sysctl option

2016-02-03 Thread Robert Bragg
Consistent with the kernel.perf_event_paranoid sysctl option that can allow non-root users to access system wide cpu metrics, this can optionally allow non-root users to access system wide OA counter metrics from Gen graphics hardware. Signed-off-by: Robert Bragg --- drivers/gpu/drm/i915/i915_dr

[Intel-gfx] [PATCH 0/8] Enable Gen 7 Observation Architecture

2016-02-03 Thread Robert Bragg
Compared to the last revision, this is just rebased on drm-intel-nightly Robert Bragg (8): drm/i915: Add i915 perf infrastructure drm/i915: rename OACONTROL GEN7_OACONTROL drm/i915: Add 'render basic' Haswell OA unit config drm/i915: Add i915 perf event for Haswell OA unit drm/i915: adve

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Allow i915_gem_object_get_page() on userptr as well

2016-02-03 Thread Rodrigo Vivi
Apparently this patch was blocking other teams that were pinging us at irc and with 2 rv-b, 2 tested-by and ci success I merged this patch. However other 2 patches in this series are still pending review so not merged. On Fri, Jan 29, 2016 at 8:49 AM Chris Wilson wrote: > commit 033908aed5a596f6

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Remove atomic.pre_disable_primary.

2016-02-03 Thread Ville Syrjälä
On Wed, Feb 03, 2016 at 06:23:13PM +0100, Maarten Lankhorst wrote: > Op 03-02-16 om 17:07 schreef Ville Syrjälä: > > On Wed, Feb 03, 2016 at 04:53:24PM +0100, Maarten Lankhorst wrote: > >> This can be derived from the atomic state in pre_plane_update, > >> which makes it more clear when it's suppos

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Remove atomic.pre_disable_primary.

2016-02-03 Thread Maarten Lankhorst
Op 03-02-16 om 17:07 schreef Ville Syrjälä: > On Wed, Feb 03, 2016 at 04:53:24PM +0100, Maarten Lankhorst wrote: >> This can be derived from the atomic state in pre_plane_update, >> which makes it more clear when it's supposed to be called. >> >> Reviewed-by: Ander Conselvan de Oliveira >> Signed-

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Support HDMI EDID injection (rev2)

2016-02-03 Thread Patchwork
== Summary == Series 3007v2 drm/i915: Support HDMI EDID injection http://patchwork.freedesktop.org/api/1.0/series/3007/revisions/2/mbox/ Test kms_flip: Subgroup basic-flip-vs-modeset: pass -> DMESG-WARN (skl-i7k-2) Test kms_pipe_crc_basic: Subgroup nonblockin

Re: [Intel-gfx] [PATCH 1/1] drm/i915/skl: fix RC6 residency time calculation

2016-02-03 Thread Imre Deak
On ke, 2016-02-03 at 11:29 +0530, Sagar Arun Kamble wrote: > The RC6 residency time unit is 1.33us on SKL according to the > specification, so update the calculation accordingly. > > Cc: Imre Deak > Signed-off-by: Sagar Arun Kamble > --- >  drivers/gpu/drm/i915/i915_sysfs.c | 3 ++- >  1 file cha

[Intel-gfx] [PATCH v2] drm/i915: Support HDMI EDID injection

2016-02-03 Thread Marius Vlad
Make a copy of drm_property_blob data for user-supplied EDID blobs. v2: Allocate and memcopy drm_property_blob->data instead of pointing to it. Signed-off-by: Marius Vlad --- drivers/gpu/drm/i915/intel_hdmi.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/i915/i

Re: [Intel-gfx] [PATCH v2 1/6] drm/i915: Use atomic state to obtain load detection crtc, v2.

2016-02-03 Thread Ville Syrjälä
On Wed, Feb 03, 2016 at 09:57:55AM +0100, Maarten Lankhorst wrote: > Op 02-02-16 om 18:32 schreef Ville Syrjälä: > > On Tue, Feb 02, 2016 at 01:48:17PM +0100, Maarten Lankhorst wrote: > >> drm/i915: Use atomic state to obtain load detection crtc, v2. > >> > >> Instead of restoring dpms and a flag f

Re: [Intel-gfx] [PATCH] drm/i915: Support HDMI EDID injection

2016-02-03 Thread Marius Vlad
On Tue, Feb 02, 2016 at 05:32:21PM +0200, Jani Nikula wrote: > On Tue, 02 Feb 2016, Marius Vlad wrote: > > Use the drm_property_blob data for user-supplied EDID blobs. > > > > Signed-off-by: Marius Vlad > > --- > > drivers/gpu/drm/i915/intel_hdmi.c | 6 +- > > 1 file changed, 5 insertions(+)

[Intel-gfx] ✗ Fi.CI.BAT: failure for Fix cxsr warning spew.

2016-02-03 Thread Patchwork
== Summary == Series 3053v1 Fix cxsr warning spew. http://patchwork.freedesktop.org/api/1.0/series/3053/revisions/1/mbox/ Test gem_sync: Subgroup basic-blt: pass -> INCOMPLETE (skl-i7k-2) Test kms_pipe_crc_basic: Subgroup nonblocking-crc-pipe-c-frame-sequence

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Do not disable cxsr when crtc is disabled.

2016-02-03 Thread Ville Syrjälä
On Wed, Feb 03, 2016 at 04:53:25PM +0100, Maarten Lankhorst wrote: > It's safe to assume cxsr is already disabled when the crtc is off. Hmm. Yeah, looks like that's how we set it up currently. I thought we might leave it on with 0 active pipes, but I guess not. Reviewed-by: Ville Syrjälä > This

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Remove atomic.pre_disable_primary.

2016-02-03 Thread Ville Syrjälä
On Wed, Feb 03, 2016 at 04:53:24PM +0100, Maarten Lankhorst wrote: > This can be derived from the atomic state in pre_plane_update, > which makes it more clear when it's supposed to be called. > > Reviewed-by: Ander Conselvan de Oliveira > Signed-off-by: Maarten Lankhorst > --- > drivers/gpu/dr

[Intel-gfx] [PATCH 1/3] drm/i915: Remove intel_crtc->atomic.disable_ips.

2016-02-03 Thread Maarten Lankhorst
This is a revert of commit 066cf55b9ce3 "drm/i915: Fix IPS related flicker". intel_pre_disable_primary already handles this, and now everything goes through the atomic path there's no need to try to disable ips twice. Signed-off-by: Maarten Lankhorst Reviewed-by: Ander Conselvan de Oliveira ---

[Intel-gfx] [PATCH 2/3] drm/i915: Remove atomic.pre_disable_primary.

2016-02-03 Thread Maarten Lankhorst
This can be derived from the atomic state in pre_plane_update, which makes it more clear when it's supposed to be called. Reviewed-by: Ander Conselvan de Oliveira Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_display.c | 25 +++-- drivers/gpu/drm/i915/intel

[Intel-gfx] [PATCH 0/3] Fix cxsr warning spew.

2016-02-03 Thread Maarten Lankhorst
First 2 patches from the remove intel_crtc->atomic series. They were already reviewed when part of a different series which I had slightly adjusted. I put them in the series because I need to pass old_crtc_state to pre_plane_update, and those patches were reviewed anyway. Maarten Lankhorst (3):

[Intel-gfx] [PATCH 3/3] drm/i915: Do not disable cxsr when crtc is disabled.

2016-02-03 Thread Maarten Lankhorst
It's safe to assume cxsr is already disabled when the crtc is off. This prevents an unclaimed register warning when the required power wells are not enabled. [ 262.864984] [ cut here ] [ 262.865025] WARNING: CPU: 1 PID: 6799 at drivers/gpu/drm/i915/intel_uncore.c:638 __u

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915: resize the GuC WOPCM for rc6

2016-02-03 Thread Dave Gordon
On 21/01/16 21:41, Jeff McGee wrote: On Thu, Jan 21, 2016 at 06:11:01PM +, Peter Antoine wrote: This patch resizes the GuC WOPCM to so that the GuC and the RC6 memory spaces do not overlap. Issue: https://jira01.devtools.intel.com/browse/VIZ-6638 Signed-off-by: Peter Antoine --- drivers/

[Intel-gfx] ✓ Fi.CI.BAT: success for kernel/cpu: Distinctive name for cpu_hotplug.dep_map

2016-02-03 Thread Patchwork
== Summary == Series 3049v1 kernel/cpu: Distinctive name for cpu_hotplug.dep_map http://patchwork.freedesktop.org/api/1.0/series/3049/revisions/1/mbox/ Test kms_pipe_crc_basic: Subgroup nonblocking-crc-pipe-c-frame-sequence: dmesg-warn -> PASS (skl-i7k-2) bdw-nuci7

[Intel-gfx] [PATCH] kernel/cpu: Distinctive name for cpu_hotplug.dep_map

2016-02-03 Thread Joonas Lahtinen
Use distinctive name for cpu_hotplug.dep_map to avoid the actual cpu_hotplug.lock appearing as cpu_hotplug.lock#2 in lockdep splats. Cc: Gautham R. Shenoy Cc: Rafael J. Wysocki Cc: Intel graphics driver community testing & development Signed-off-by: Joonas Lahtinen --- kernel/cpu.c | 2 +- 1

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/bxt: Added identifier for MIPI transcoder.

2016-02-03 Thread Patchwork
== Summary == Series 3046v1 drm/i915/bxt: Added identifier for MIPI transcoder. http://patchwork.freedesktop.org/api/1.0/series/3046/revisions/1/mbox/ Test kms_pipe_crc_basic: Subgroup suspend-read-crc-pipe-c: incomplete -> PASS (hsw-gt2) bdw-nuci7total:156

Re: [Intel-gfx] [PATCH] drm/i915: Pretend cursor is always on for ILK-style WM calculations (v2)

2016-02-03 Thread Matt Roper
On Wed, Feb 03, 2016 at 01:16:38PM +0200, Ville Syrjälä wrote: > On Tue, Feb 02, 2016 at 10:06:51PM -0800, Matt Roper wrote: > > Due to our lack of two-step watermark programming, our driver has > > historically pretended that the cursor plane is always on for the > > purpose of watermark calculati

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/BXT: Configure DSI after enabling DSI pll (rev2)

2016-02-03 Thread Patchwork
== Summary == Series 3016v2 drm/i915/BXT: Configure DSI after enabling DSI pll http://patchwork.freedesktop.org/api/1.0/series/3016/revisions/2/mbox/ Test kms_pipe_crc_basic: Subgroup nonblocking-crc-pipe-b: pass -> INCOMPLETE (hsw-gt2) Subgroup read-crc-pipe

[Intel-gfx] [PATCH] drm/i915/bxt: Added identifier for MIPI transcoder.

2016-02-03 Thread Animesh Manna
Changes done: - Added identifier for Mipi transcoder A and C. - Added power domain identifier for newly added mipi trancoder. - Initialized transcoder for mipi during compute config. v1: Initial RFC version. v2: Rebased on tot. Cc: Jani Nikula Signed-off-by: Animesh Manna --- drivers/gpu/drm/

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: add enable_guc_loading parameter

2016-02-03 Thread Patchwork
== Summary == Series 3045v1 drm/i915: add enable_guc_loading parameter http://patchwork.freedesktop.org/api/1.0/series/3045/revisions/1/mbox/ Test kms_pipe_crc_basic: Subgroup suspend-read-crc-pipe-c: incomplete -> PASS (hsw-gt2) bdw-nuci7total:156 pass:147

Re: [Intel-gfx] [PATCH] drm/i915: Protect fbdev across slow or failed initialisation

2016-02-03 Thread Lukas Wunner
Hi, On Wed, Feb 03, 2016 at 09:17:37AM +, Chris Wilson wrote: > If the initialisation fails, we may be left with a dangling pointer with > an incomplete fbdev structure. This shouldn't happen with 4.5, the fbdev is now clobbered if initialization fails, the existing "if (dev_priv->fbdev)" che

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Using the bpp value wrt the pixel format (rev2)

2016-02-03 Thread Patchwork
== Summary == Series 3017v2 Series without cover letter http://patchwork.freedesktop.org/api/1.0/series/3017/revisions/2/mbox/ Test kms_pipe_crc_basic: Subgroup suspend-read-crc-pipe-c: incomplete -> PASS (hsw-gt2) bdw-nuci7total:156 pass:147 dwarn:0 dfa

[Intel-gfx] [PATCH] drm/i915/BXT: Configure DSI after enabling DSI pll

2016-02-03 Thread Ramalingam C
We need to enable DSI PLL before configuring the DSI registers. Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/intel_dsi.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c index 91cef35..378f879 10064

Re: [Intel-gfx] [PATCH] drm/i915/BXT: Configure DSI after enabling DSI pll

2016-02-03 Thread Mika Kahola
On Wed, 2016-02-03 at 11:28 +0200, Jani Nikula wrote: > On Tue, 02 Feb 2016, Ramalingam C wrote: > > We need to enable DSI PLL before configuring the DSI registers. > > > > Signed-off-by: Ramalingam C > > --- > > drivers/gpu/drm/i915/intel_dsi.c |2 +- > > 1 file changed, 1 insertion(+), 1 d

[Intel-gfx] [PATCH] drm/i915: add enable_guc_loading parameter

2016-02-03 Thread Dave Gordon
Split the function of "enable_guc_submission" into two separate options. The new one "enable_guc_loading" controls only the *fetching and loading* of the GuC firmware image. The existing one is redefined to control only the *use* of the GuC for batch submission once the firmware is loaded. In addi

Re: [Intel-gfx] [PATCH v3 5/5] drm/atomic: Add encoder_mask to crtc_state, v3.

2016-02-03 Thread Gustavo Padovan
Hi Maarten, 2016-01-28 Maarten Lankhorst : > This allows iteration over encoders without requiring connection_mutex. > > Changes since v1: > - Add a set_best_encoder helper function and update encoder_mask inside > it. > Changes since v2: > - Relax the WARN_ON(!crtc), with explanation. > - Cal

Re: [Intel-gfx] [PATCH 4/5] drm/atomic: Do not unset crtc when an encoder is stolen

2016-02-03 Thread Gustavo Padovan
Hi Maarten, 2016-01-07 Maarten Lankhorst : > While we steal the encoder away from the connector the connector may > be updated to use a different encoder. > > Without this change if 2 connectors swap encoders one of them will > end up without a crtc. > > Signed-off-by: Maarten Lankhorst > ---

Re: [Intel-gfx] [PATCH 2/5] drm/core: Add drm_for_each_encoder_mask, v2.

2016-02-03 Thread Gustavo Padovan
Hi Maarten, 2016-01-07 Maarten Lankhorst : > This is similar to the other drm_for_each_*_mask functions. > > Changes since v1: > - Use for_each_if > > Signed-off-by: Maarten Lankhorst > --- > include/drm/drm_crtc.h | 11 +++ > 1 file changed, 11 insertions(+) Reviewed-by: Gustavo Pad

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Do not touch best_encoder for load detect.

2016-02-03 Thread Gustavo Padovan
Hi Maarten, 2016-01-07 Maarten Lankhorst : > This should only be touched by drm_atomic_helper. > > Signed-off-by: Maarten Lankhorst > --- > drivers/gpu/drm/i915/intel_display.c | 2 -- > 1 file changed, 2 deletions(-) Reviewed-by: Gustavo Padovan Gustavo

Re: [Intel-gfx] [PATCH 1/5] drm/core: Add drm_encoder_index.

2016-02-03 Thread Gustavo Padovan
Hi Maarten, 2016-01-07 Maarten Lankhorst : > This is useful for adding encoder_mask in crtc_state. > > Signed-off-by: Maarten Lankhorst > --- > drivers/gpu/drm/drm_crtc.c | 23 +++ > include/drm/drm_crtc.h | 1 + > 2 files changed, 24 insertions(+) Reviewed-by: Gustav

Re: [Intel-gfx] [PATCH] drm/i915/BXT: Configure DSI after enabling DSI pll

2016-02-03 Thread Ramalingam C
On Wednesday 03 February 2016 05:25 PM, Jani Nikula wrote: On Wed, 03 Feb 2016, Jani Nikula wrote: On Wed, 03 Feb 2016, Mika Kahola wrote: On Wed, 2016-02-03 at 11:27 +0200, Jani Nikula wrote: On Wed, 03 Feb 2016, "Thulasimani, Sivakumar" wrote: just realized that intel_dsi_init is not c

[Intel-gfx] [PATCH 1/2] drm/i915: Using the bpp value wrt the pixel format

2016-02-03 Thread Ramalingam C
From: Deepak M The bpp value which is used while calulating the txbyteclkhs values should be wrt the pixel format value. Currently bpp is coming from pipe config to calculate txbyteclkhs. Fix it in this patch. Signed-off-by: Deepak M Signed-off-by: Yogesh Mohan Marimuthu Signed-off-by: Ramalin

[Intel-gfx] [PATCH 2/2] drm/i915/BXT: Fixed COS blanking issue

2016-02-03 Thread Ramalingam C
From: Uma Shankar During Charging OS mode, mipi display was blanking.This is because during driver load, though encoder, connector were active but crtc returned inactive. This caused sanitize function to disable the DSI panel. In AOS, this is fine since HWC will do a modeset and crtc, connector,

Re: [Intel-gfx] [PATCH 1/2] drm/i915/BXT: Fixed COS blanking issue

2016-02-03 Thread Ramalingam C
On Wednesday 03 February 2016 07:19 AM, Thulasimani, Sivakumar wrote: On 2/2/2016 11:24 PM, Ramalingam C wrote: From: Uma Shankar During Charging OS mode, mipi display was blanking.This is because during driver load, though encoder, connector were active but crtc returned inactive. This cau

Re: [Intel-gfx] [PATCH 1/2] drm/i915/BXT: Fixed COS blanking issue

2016-02-03 Thread Ramalingam C
Hi, On Wednesday 03 February 2016 03:14 PM, Jani Nikula wrote: On Tue, 02 Feb 2016, Ramalingam C wrote: From: Uma Shankar During Charging OS mode, mipi display was blanking.This is because during driver load, though encoder, connector were active but crtc returned inactive. This caused sanit

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Protect fbdev across slow or failed initialisation

2016-02-03 Thread Patchwork
== Summary == Series 3040v1 drm/i915: Protect fbdev across slow or failed initialisation http://patchwork.freedesktop.org/api/1.0/series/3040/revisions/1/mbox/ Test drv_module_reload_basic: pass -> INCOMPLETE (bsw-nuc-2) bdw-nuci7total:156 pass:147 dwarn:0 dfail

Re: [Intel-gfx] [PATCH] drm/i915/BXT: Configure DSI after enabling DSI pll

2016-02-03 Thread Jani Nikula
On Wed, 03 Feb 2016, Jani Nikula wrote: > On Wed, 03 Feb 2016, Mika Kahola wrote: >> On Wed, 2016-02-03 at 11:27 +0200, Jani Nikula wrote: >>> On Wed, 03 Feb 2016, "Thulasimani, Sivakumar" >>> wrote: >>> > just realized that intel_dsi_init is not called from setup outputs for >>> > BXT. is thi

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Protect fbdev across slow or failed initialisation

2016-02-03 Thread Patchwork
== Summary == Series 3040v1 drm/i915: Protect fbdev across slow or failed initialisation http://patchwork.freedesktop.org/api/1.0/series/3040/revisions/1/mbox/ Test drv_module_reload_basic: pass -> INCOMPLETE (bsw-nuc-2) bdw-nuci7total:156 pass:147 dwarn:0 dfail

Re: [Intel-gfx] Video glitches E3845 ATOM, Fedora 21

2016-02-03 Thread Jani Nikula
On Tue, 02 Feb 2016, "Rogers, Martin" wrote: > I'm seeing weird video glitches on the Intel BayLey Bay -i CRB board, > with Fedora 21, XFCE, and I hope someone can help. Please file a bug at https://bugs.freedesktop.org/enter_bug.cgi?product=DRI&component=DRM/Intel Add drm.debug=14 module parame

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Protect fbdev across slow or failed initialisation

2016-02-03 Thread Patchwork
== Summary == Series 3040v1 drm/i915: Protect fbdev across slow or failed initialisation http://patchwork.freedesktop.org/api/1.0/series/3040/revisions/1/mbox/ byt-nuc total:159 pass:136 dwarn:0 dfail:0 fail:0 skip:23 hsw-brixbox total:159 pass:146 dwarn:0 dfail:0 fa

Re: [Intel-gfx] [PATCH] drm/i915: Pretend cursor is always on for ILK-style WM calculations (v2)

2016-02-03 Thread Ville Syrjälä
On Tue, Feb 02, 2016 at 10:06:51PM -0800, Matt Roper wrote: > Due to our lack of two-step watermark programming, our driver has > historically pretended that the cursor plane is always on for the > purpose of watermark calculations; this helps avoid serious flickering > when the cursor turns off/on

Re: [Intel-gfx] [PATCH] drm/i915/BXT: Configure DSI after enabling DSI pll

2016-02-03 Thread Jani Nikula
On Wed, 03 Feb 2016, Mika Kahola wrote: > On Wed, 2016-02-03 at 11:27 +0200, Jani Nikula wrote: >> On Wed, 03 Feb 2016, "Thulasimani, Sivakumar" >> wrote: >> > just realized that intel_dsi_init is not called from setup outputs for >> > BXT. is this expected ? >> > if so when is it expected to b

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Pretend cursor is always on for ILK-style WM calculations (rev3)

2016-02-03 Thread Patchwork
== Summary == Series 2975v3 drm/i915: Pretend cursor is always on for ILK-style WM calculations http://patchwork.freedesktop.org/api/1.0/series/2975/revisions/3/mbox/ Test kms_pipe_crc_basic: Subgroup suspend-read-crc-pipe-c: incomplete -> PASS (hsw-gt2) bdw-nuci7

Re: [Intel-gfx] [PATCH] drm/i915/BXT: Configure DSI after enabling DSI pll

2016-02-03 Thread Mika Kahola
On Wed, 2016-02-03 at 11:27 +0200, Jani Nikula wrote: > On Wed, 03 Feb 2016, "Thulasimani, Sivakumar" > wrote: > > just realized that intel_dsi_init is not called from setup outputs for > > BXT. is this expected ? > > if so when is it expected to be added ? > > > > Again, the current code in int

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/1] drm/i915/skl: fix RC6 residency time calculation

2016-02-03 Thread Patchwork
== Summary == Series 3036v1 Series without cover letter http://patchwork.freedesktop.org/api/1.0/series/3036/revisions/1/mbox/ Test gem_sync: Subgroup basic-blt: pass -> INCOMPLETE (skl-i5k-2) Test kms_pipe_crc_basic: Subgroup suspend-read-crc-pipe-c:

Re: [Intel-gfx] [PATCH 2/2] drm/i915/dsi: Add audio reference in dsi encoder

2016-02-03 Thread Jani Nikula
On Wed, 03 Feb 2016, Ramalingam C wrote: > On Wednesday 03 February 2016 02:27 PM, Jani Nikula wrote: >> On Tue, 02 Feb 2016, Ramalingam C wrote: >>> From: "Kumar, Mahesh" >>> >>> We are re-using Mipi encoder enabled by GOP driver, but not incrementing >>> reference count for Audio Power domain,

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/bxt: Additional MIPI clock divider form B0 stepping onwards (rev2)

2016-02-03 Thread Patchwork
== Summary == Series 3034v2 drm/i915/bxt: Additional MIPI clock divider form B0 stepping onwards http://patchwork.freedesktop.org/api/1.0/series/3034/revisions/2/mbox/ Test drv_module_reload_basic: pass -> INCOMPLETE (bdw-nuci7) Test kms_pipe_crc_basic: Subgroup sus

Re: [Intel-gfx] [PATCH 1/2] drm/i915/BXT: Fixed COS blanking issue

2016-02-03 Thread Jani Nikula
On Tue, 02 Feb 2016, Ramalingam C wrote: > From: Uma Shankar > > During Charging OS mode, mipi display was blanking.This is > because during driver load, though encoder, connector were > active but crtc returned inactive. This caused sanitize > function to disable the DSI panel. In AOS, this is f

Re: [Intel-gfx] [PATCH 2/2] drm/i915/dsi: Add audio reference in dsi encoder

2016-02-03 Thread Ramalingam C
On Wednesday 03 February 2016 02:27 PM, Jani Nikula wrote: On Tue, 02 Feb 2016, Ramalingam C wrote: From: "Kumar, Mahesh" We are re-using Mipi encoder enabled by GOP driver, but not incrementing reference count for Audio Power domain, so audio was not working. This patch increments the refer

Re: [Intel-gfx] [PATCH] drm/i915/BXT: Configure DSI after enabling DSI pll

2016-02-03 Thread Jani Nikula
On Tue, 02 Feb 2016, Ramalingam C wrote: > We need to enable DSI PLL before configuring the DSI registers. > > Signed-off-by: Ramalingam C > --- > drivers/gpu/drm/i915/intel_dsi.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_dsi.c > b/dr

Re: [Intel-gfx] [PATCH] drm/i915/BXT: Configure DSI after enabling DSI pll

2016-02-03 Thread Jani Nikula
On Wed, 03 Feb 2016, "Thulasimani, Sivakumar" wrote: > just realized that intel_dsi_init is not called from setup outputs for > BXT. is this expected ? > if so when is it expected to be added ? > > Again, the current code in intel_setup_outputs calls intel_dsi_init from > vlv/chv section so plea

[Intel-gfx] [PATCH] drm/i915: Protect fbdev across slow or failed initialisation

2016-02-03 Thread Chris Wilson
If the initialisation fails, we may be left with a dangling pointer with an incomplete fbdev structure. Here we want to disable internal calls into fbdev. Similarly, the initialisation may be slow and we haven't yet enabled the fbdev (e.g. quick suspend or last-close before the async init completes

[Intel-gfx] ✗ Fi.CI.BAT: failure for Enable Gen 7 Observation Architecture

2016-02-03 Thread Patchwork
== Summary == Series 3024v1 Enable Gen 7 Observation Architecture 2016-02-02T21:31:17.176759 http://patchwork.freedesktop.org/api/1.0/series/3024/revisions/1/mbox/ Applying: drm/i915: Add i915 perf infrastructure Using index info to reconstruct a base tree... M drivers/gpu/drm/i915/Makefile

Re: [Intel-gfx] [PATCH v2 1/6] drm/i915: Use atomic state to obtain load detection crtc, v2.

2016-02-03 Thread Maarten Lankhorst
Op 02-02-16 om 18:32 schreef Ville Syrjälä: > On Tue, Feb 02, 2016 at 01:48:17PM +0100, Maarten Lankhorst wrote: >> drm/i915: Use atomic state to obtain load detection crtc, v2. >> >> Instead of restoring dpms and a flag for whether a temp fb is allocated >> duplicate >> an atomic state before the

Re: [Intel-gfx] [PATCH 2/2] drm/i915/dsi: Add audio reference in dsi encoder

2016-02-03 Thread Jani Nikula
On Tue, 02 Feb 2016, Ramalingam C wrote: > From: "Kumar, Mahesh" > > We are re-using Mipi encoder enabled by GOP driver, but not incrementing > reference count for Audio Power domain, so audio was not working. This > patch increments the reference count during DSI init and Adds get/put in > DSI e

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v7,1/1] drm/i915/bxt: Check BIOS RC6 setup before enabling RC6 (rev4)

2016-02-03 Thread Patchwork
== Summary == Series 2497v4 Series without cover letter http://patchwork.freedesktop.org/api/1.0/series/2497/revisions/4/mbox/ Test kms_pipe_crc_basic: Subgroup suspend-read-crc-pipe-c: incomplete -> PASS (hsw-gt2) bdw-nuci7total:156 pass:147 dwarn:0 dfa

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/BXT: Fixed COS blanking issue

2016-02-03 Thread Patchwork
== Summary == ^ drivers/gpu/drm/i915/intel_display.c:7862:36: error: dereferencing pointer to incomplete type for_each_dsi_port(port, intel_dsi->ports) { ^ drivers/gpu/drm/i915/intel_display.c:7862:45: error: expected ';' before '{' token for_each_dsi