Re: [Intel-gfx] [PATCH] drm/i915/: DMC 1.04 for Geminilake

2017-03-06 Thread Ander Conselvan De Oliveira
On Wed, 2017-02-22 at 11:55 -0800, Anusha Srivatsa wrote: > There is a nre version of DMC available for GLK. > > The release notes mentions: > This FW has the fix to remove the hang conditions due to > some debug related issues. > > Cc: Rodrigo Vivi > Signed-off-by: Anusha Srivatsa Reviewed-by

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Use pagecache write to prepopulate shmemfs from pwrite-ioctl

2017-03-06 Thread Tvrtko Ursulin
On 06/03/2017 21:49, Chris Wilson wrote: On Mon, Mar 06, 2017 at 04:32:45PM +, Tvrtko Ursulin wrote: On 06/03/2017 14:14, Chris Wilson wrote: Remember when I said that nobody would touch pages without using them, (and so could defer the update for the shrinker until we had the struct_mute

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: No need to save/restore irq status in __i915_request_irq_complete

2017-03-06 Thread Tvrtko Ursulin
On 06/03/2017 17:18, Patchwork wrote: == Series Details == Series: series starting with [1/3] drm/i915: No need to save/restore irq status in __i915_request_irq_complete URL : https://patchwork.freedesktop.org/series/20769/ State : success == Summary == Series 20769v1 Series without cover

Re: [Intel-gfx] [PATCH 3/3] drm/i915: No need to save/restore irq status in intel_engine_wakeup

2017-03-06 Thread Tvrtko Ursulin
On 06/03/2017 15:11, Chris Wilson wrote: On Mon, Mar 06, 2017 at 03:03:21PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin It is called from either the process or timer context so it is correct to always disable interrupts. Signed-off-by: Tvrtko Ursulin Cc: Chris Wilson All 3 look ok

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/1] drm/i915: Initialize pm_intr_keep during intel_irq_init for GuC

2017-03-06 Thread Patchwork
== Series Details == Series: series starting with [1/1] drm/i915: Initialize pm_intr_keep during intel_irq_init for GuC URL : https://patchwork.freedesktop.org/series/20812/ State : success == Summary == Series 20812v1 Series without cover letter https://patchwork.freedesktop.org/api/1.0/seri

[Intel-gfx] [PATCH 1/1] drm/i915: Initialize pm_intr_keep during intel_irq_init for GuC

2017-03-06 Thread Sagar Arun Kamble
Driver needs to ensure that it doesn't mask the PM interrupts, which are unmasked/needed by GuC firmware. For that, Driver maintains a bitmask of interrupts to be kept unmasked, pm_intr_keep. pm_intr_keep was determined across GuC load. GuC gets loaded in different scenarios and it is not going to

Re: [Intel-gfx] Implementing Miracast

2017-03-06 Thread Daniel Kasak
Any news on this? I'm also interested :) Dan On Wed, Jan 4, 2017 at 7:50 AM, Martin Peres wrote: > On 03/01/17 22:47, Jani Nikula wrote: > >> On Fri, 23 Dec 2016, norbert wrote: >> >>> Hello, >>> about a year ago there was a discussion about Implementing Miracast on >>> this list: >>> >>> http

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: initial support for huge gtt pages

2017-03-06 Thread Patchwork
== Series Details == Series: drm/i915: initial support for huge gtt pages URL : https://patchwork.freedesktop.org/series/20789/ State : success == Summary == Series 20789v1 drm/i915: initial support for huge gtt pages https://patchwork.freedesktop.org/api/1.0/series/20789/revisions/1/mbox/ Te

[Intel-gfx] [PULL] drm-intel-next

2017-03-06 Thread Daniel Vetter
1a67375839bc: drm/i915: Update DRIVER_DATE to 20170306 (2017-03-06 08:34:44 +0100) 4 weeks worth of stuff since I was traveling&lazy: - lspcon improvements (Imre) - proper atomic state for cdclk handling (Ville) - gpu reset improvem

[Intel-gfx] linux-next: build failure after merge of the sunxi tree

2017-03-06 Thread Stephen Rothwell
Hi all, After merging the sunxi tree, today's linux-next build (arm multi_v7_defconfig) failed like this: drivers/gpu/drm/sun4i/sun4i_crtc.c: In function 'sun4i_crtc_enable_vblank': drivers/gpu/drm/sun4i/sun4i_crtc.c:109:31: error: 'struct sun4i_crtc' has no member named 'drv' struct sun4i_drv

[Intel-gfx] linux-next: manual merge of the drm-misc tree with the drm-intel tree

2017-03-06 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: drivers/gpu/drm/i915/i915_debugfs.c between commits: 418e3cd80051 ("drm/i915: Show the current i915_params in debugfs/i915_capabilites") 317eaa95081b ("drm/i915/debugfs: Add i915_hpd_storm_ctl") from the drm-intel

[Intel-gfx] linux-next: manual merge of the sunxi tree with the drm-misc tree

2017-03-06 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the sunxi tree got a conflict in: drivers/gpu/drm/sun4i/sun4i_drv.c between commit: 50480a78e282 ("drm: sun4i: use vblank hooks in struct drm_crtc_funcs") from the drm-misc tree and commit: 1c313a69e3ea ("drm/sun4i: Move layers from sun4i_drv to sun4i

[Intel-gfx] [PATCH 07/15] drm/i915: s/i915_gtt_color_adjust/i915_cache_color_adjust

2017-03-06 Thread Matthew Auld
Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/i915_gem_gtt.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c index 9274974956b3..6b70332cafac 100644 --- a/drivers/gpu/drm/i915/i915_gem

[Intel-gfx] [PATCH 13/15] drm/i915: support inserting 1G pages in the ppgtt

2017-03-06 Thread Matthew Auld
Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/i915_gem_gtt.c | 45 + 1 file changed, 45 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c index f71a6320ae1b..ecc63bc1fcc1 100644 --- a/drivers/gpu/drm/i

[Intel-gfx] [PATCH 05/15] drm/i915: introduce drm_i915_gem_object page_size member

2017-03-06 Thread Matthew Auld
Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/i915_gem.c| 2 ++ drivers/gpu/drm/i915/i915_gem_object.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 7c20601fe1de..0a6ed2c54629 100644 --- a/drivers/gpu/

[Intel-gfx] [PATCH 14/15] drm/i915/selftests: exercise 4K and 64K mm insertion

2017-03-06 Thread Matthew Auld
Mock test filling an address space with 4K and 64K objects, in the hope of exercising the page color adjust fun. Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 68 +++ 1 file changed, 68 insertions(+) diff --git a/drivers/gpu/drm/i915/sel

[Intel-gfx] [PATCH 11/15] drm/i915: support inserting 64K pages in the ppgtt

2017-03-06 Thread Matthew Auld
Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/i915_gem_gtt.c | 70 + 1 file changed, 70 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c index 0fb67941ba6b..4d863de6473d 100644 --- a/drivers/gpu/drm/i

[Intel-gfx] [PATCH 04/15] drm/i915: add page_size_mask to dev_info

2017-03-06 Thread Matthew Auld
Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_gem_gtt.h | 14 ++ drivers/gpu/drm/i915/i915_pci.c | 23 ++- 3 files changed, 37 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/d

[Intel-gfx] [PATCH 09/15] drm/i915: export color_differs

2017-03-06 Thread Matthew Auld
Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/i915_vma.c | 9 ++--- drivers/gpu/drm/i915/i915_vma.h | 6 ++ 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c index 31e2327492ba..0d289cbc0123 100644 --- a

[Intel-gfx] [PATCH 08/15] drm/i915: clean up cache coloring

2017-03-06 Thread Matthew Auld
To keep the next patch simple, rid the code of any mm.color_adjust assumptions to allow adding another flavour of coloring. Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/i915_gem.c | 3 ++- drivers/gpu/drm/i915/i915_gem_evict.c | 12 ++

[Intel-gfx] [PATCH 15/15] drm/i915/selftests: modify the gtt tests to also exercise huge pages

2017-03-06 Thread Matthew Auld
Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 123 ++ drivers/gpu/drm/i915/selftests/mock_gtt.c | 3 + 2 files changed, 89 insertions(+), 37 deletions(-) diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c b/drivers/gpu/drm/

[Intel-gfx] [PATCH 01/15] drm/i915/selftests: don't leak the gem object

2017-03-06 Thread Matthew Auld
For our fake dma objects we can leak the underlying gem object if we fail to pin our "backing storage". [ 39.952618] = [ 39.952625] BUG mock_object (Tainted: G U ): Objects remaining in mock_object on __k

[Intel-gfx] [PATCH 06/15] drm/i915: pass page_size to insert_entries

2017-03-06 Thread Matthew Auld
Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/i915_gem_gtt.c | 32 ++- drivers/gpu/drm/i915/i915_gem_gtt.h | 1 + drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 3 ++- drivers/gpu/drm/i915/selftests/mock_gtt.c | 1 + 4 files changed, 30 i

[Intel-gfx] [RFC PATCH 00/15] drm/i915: initial support for huge gtt pages

2017-03-06 Thread Matthew Auld
This series adds support for huge-pages for the gtt, where "huge" is 64K, 2M and 1G. This isn't everything I have and there are still some things which I have yet to implement, like handling evict-for-node with the 64K/4K trickiness, but the hope here is to get some early feedback if possible. One

[Intel-gfx] [PATCH 12/15] drm/i915: support inserting 2M pages in the ppgtt

2017-03-06 Thread Matthew Auld
Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/i915_gem_gtt.c | 53 + 1 file changed, 53 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c index 4d863de6473d..f71a6320ae1b 100644 --- a/drivers/gpu/drm/i

[Intel-gfx] [PATCH 03/15] drm/i915/selftests: exercise cache domain eviction

2017-03-06 Thread Matthew Auld
v2: add a peppering of comments Signed-off-by: Matthew Auld Cc: Chris Wilson --- drivers/gpu/drm/i915/selftests/i915_gem_evict.c | 89 + 1 file changed, 89 insertions(+) diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_evict.c b/drivers/gpu/drm/i915/selftests/i915_

[Intel-gfx] [PATCH 02/15] drm/i915: use correct node for handling cache domain eviction

2017-03-06 Thread Matthew Auld
It looks like we were incorrectly comparing vma->node against itself instead of the target node, when evicting for a node on systems where we need guard pages between regions with different cache domains. As a consequence we can end up trying to needlessly evict neighbouring nodes, even if they hav

[Intel-gfx] [PATCH 10/15] drm/i915: introduce ppgtt page coloring

2017-03-06 Thread Matthew Auld
To enable 64K pages we need to set the intermediate-page-size(IPS) bit of the pde, therefore a page table is said to be either operating in 64K or 4K mode. To accommodate this vm placement restriction we introduce a color for pages and corresponding color_adjust callback. Currently this only consid

[Intel-gfx] [PATCH i-g-t] lib/igt_gt: Remove duplicated PARAM_NO_ERROR_CAPTURE define

2017-03-06 Thread Michel Thierry
LOCAL_CONTEXT_PARAM_NO_ERROR_CAPTURE exists in lib/ioctl_wrappers.h since commit 171b21d9f761 ("igt/gem_ctx_param: Update invalid parma number"). Cc: Chris Wilson Signed-off-by: Michel Thierry --- lib/igt_gt.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/igt_gt.c b/lib/igt_gt.c inde

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Use pagecache write to prepopulate shmemfs from pwrite-ioctl

2017-03-06 Thread Chris Wilson
On Mon, Mar 06, 2017 at 04:32:45PM +, Tvrtko Ursulin wrote: > > On 06/03/2017 14:14, Chris Wilson wrote: > >Remember when I said that nobody would touch pages without using them, > >(and so could defer the update for the shrinker until we had the > >struct_mutex) and certainly not 16GiB of wri

Re: [Intel-gfx] [PATCH] drm/i915: Avoid clearing the base drm_crtc_state

2017-03-06 Thread Chris Wilson
On Mon, Mar 06, 2017 at 06:46:16PM +0100, Daniel Vetter wrote: > On Fri, Mar 03, 2017 at 03:46:44PM +, Chris Wilson wrote: > > @@ -11289,9 +11287,9 @@ clear_intel_crtc_state(struct intel_crtc_state > > *crtc_state) > > if (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv)) > >

Re: [Intel-gfx] [PATCH v2] drm/i915: Flush idle work when changing missed-irq fault injection

2017-03-06 Thread Chris Wilson
On Mon, Mar 06, 2017 at 05:45:30PM +, Tvrtko Ursulin wrote: > > On 06/03/2017 10:15, Chris Wilson wrote: > > static int > >+fault_irq_set(struct drm_i915_private *i915, unsigned long *irq, u64 val) > >+{ > >+int err; > >+ > >+err = mutex_lock_interruptible(&i915->drm.struct_mutex); > >

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Use pagecache write to prepopulate shmemfs from pwrite-ioctl

2017-03-06 Thread Joonas Lahtinen
On ma, 2017-03-06 at 09:29 +, Chris Wilson wrote: > Before we instantiate/pin the backing store for our use, we > can prepopulate the shmemfs filp efficiently using the a > write into the pagecache. We avoid the penalty of instantiating > all the pages, important if the user is just writing to

Re: [Intel-gfx] [PATCH 0/7] drm/i915/dsi: stop using drm_panel, refactor

2017-03-06 Thread Bob Paauwe
On Mon, 6 Mar 2017 16:31:23 +0200 Jani Nikula wrote: > This is pretty natural continuation to what Hans started. We haven't > made use of the drm_panel framework much at all, and there's no need in > sight, really. It was good for ensuring a certain amount of separation > between the core and the

Re: [Intel-gfx] [PATCH 1/2] drm/i915: use correct node for handling cache domain eviction

2017-03-06 Thread Joonas Lahtinen
On pe, 2017-03-03 at 18:18 +, Chris Wilson wrote: > On Fri, Mar 03, 2017 at 06:03:34PM +, Matthew Auld wrote: > > > > It looks like we were incorrectly comparing vma->node against itself > > instead of the target node, when evicting for a node on systems where we > > need guard pages betwe

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/userptr: Disallow wrapping GTT into a userptr

2017-03-06 Thread Patchwork
== Series Details == Series: drm/i915/userptr: Disallow wrapping GTT into a userptr URL : https://patchwork.freedesktop.org/series/20771/ State : success == Summary == Series 20771v1 drm/i915/userptr: Disallow wrapping GTT into a userptr https://patchwork.freedesktop.org/api/1.0/series/20771/r

Re: [Intel-gfx] [PATCH 5/7] drm/i915/dsi: rename intel_dsi_pre_disable to intel_dsi_disable

2017-03-06 Thread Daniel Vetter
On Mon, Mar 06, 2017 at 04:41:05PM +0200, Ville Syrjälä wrote: > On Mon, Mar 06, 2017 at 04:31:28PM +0200, Jani Nikula wrote: > > The hook names reflect more the phase in the mode set sequence the hooks > > are called in than what they actually do in terms of the specific > > encoder. Stick to that

Re: [Intel-gfx] [PATCH 4/7] drm/i915/dsi: rename intel_dsi_exec_vbt_sequence to intel_dsi_vbt_exec_sequence

2017-03-06 Thread Daniel Vetter
On Mon, Mar 06, 2017 at 04:31:27PM +0200, Jani Nikula wrote: > Use the prefix intel_dsi_vbt for all the DSI VBT functions. No > functional changes. > > Cc: Madhav Chauhan > Cc: Hans de Goede > Cc: Bob Paauwe > Signed-off-by: Jani Nikula Patches 1-4: Reviewed-by: Daniel Vetter > --- > drive

[Intel-gfx] [drm-tip:drm-tip 613/621] drivers/gpu/drm/drm_dp_helper.c:1029:13: error: 'struct drm_crtc' has no member named 'crc'

2017-03-06 Thread kbuild test robot
tree: git://anongit.freedesktop.org/drm/drm-tip drm-tip head: fefda0d99ee9245f0d4032eedb3b18cc690d8194 commit: 79c1da7c3bf74be9b1dae9450ef79f32dd22def6 [613/621] drm/dp: add helpers for capture of frame CRCs config: x86_64-randconfig-x010-201710 (attached as .config) compiler: gcc-6 (Debian 6.

Re: [Intel-gfx] [PATCH] drm/i915: Avoid clearing the base drm_crtc_state

2017-03-06 Thread Daniel Vetter
On Fri, Mar 03, 2017 at 03:46:44PM +, Chris Wilson wrote: > To prevent having to preserve the drm_crtc_state as we clear the > intel_crtc_state, only memset our extended state. > > Fixes: > drivers/gpu/drm/i915/intel_display.c: In function ‘clear_intel_crtc_state’: > drivers/gpu/drm/i915/intel

Re: [Intel-gfx] [PATCH v2] drm/i915: Flush idle work when changing missed-irq fault injection

2017-03-06 Thread Tvrtko Ursulin
On 06/03/2017 10:15, Chris Wilson wrote: In order for the missed-irq update to take effect, the device must be idle. So when the user updates the fault injection via debugfs, idle the device. v2: Idle is explicitly required for setting test_irq, and good behaviour for clearing the missed_irq.

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: No need to save/restore irq status in __i915_request_irq_complete

2017-03-06 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: No need to save/restore irq status in __i915_request_irq_complete URL : https://patchwork.freedesktop.org/series/20769/ State : success == Summary == Series 20769v1 Series without cover letter https://patchwork.freedesktop.org/

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dsi: stop using drm_panel, refactor

2017-03-06 Thread Patchwork
== Series Details == Series: drm/i915/dsi: stop using drm_panel, refactor URL : https://patchwork.freedesktop.org/series/20767/ State : success == Summary == Series 20767v1 drm/i915/dsi: stop using drm_panel, refactor https://patchwork.freedesktop.org/api/1.0/series/20767/revisions/1/mbox/ Te

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Use pagecache write to prepopulate shmemfs from pwrite-ioctl

2017-03-06 Thread Tvrtko Ursulin
On 06/03/2017 14:14, Chris Wilson wrote: On Mon, Mar 06, 2017 at 01:49:33PM +, Tvrtko Ursulin wrote: On 06/03/2017 12:48, Chris Wilson wrote: For the moment, yes :) This was a quick hack to hide a regression - the Oh it was a real regression and not just an optimisation for a strange cl

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Flush idle work when changing missed-irq fault injection (rev2)

2017-03-06 Thread Patchwork
== Series Details == Series: drm/i915: Flush idle work when changing missed-irq fault injection (rev2) URL : https://patchwork.freedesktop.org/series/20752/ State : success == Summary == Series 20752v2 drm/i915: Flush idle work when changing missed-irq fault injection https://patchwork.freed

Re: [Intel-gfx] [PATCH 5/7] drm/i915/dsi: rename intel_dsi_pre_disable to intel_dsi_disable

2017-03-06 Thread Jani Nikula
On Mon, 06 Mar 2017, Ville Syrjälä wrote: > On Mon, Mar 06, 2017 at 04:31:28PM +0200, Jani Nikula wrote: >> The hook names reflect more the phase in the mode set sequence the hooks >> are called in than what they actually do in terms of the specific >> encoder. Stick to that scheme, and rename int

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Enable atomic for VLV/CHV

2017-03-06 Thread Patchwork
== Series Details == Series: drm/i915: Enable atomic for VLV/CHV URL : https://patchwork.freedesktop.org/series/20634/ State : failure == Summary == Series 20634v1 drm/i915: Enable atomic for VLV/CHV https://patchwork.freedesktop.org/api/1.0/series/20634/revisions/1/mbox/ Test kms_cursor_lega

[Intel-gfx] [PATCH] drm/i915/userptr: Disallow wrapping GTT into a userptr

2017-03-06 Thread Chris Wilson
If we allow the user to convert a GTT mmap address into a userptr, we may end up in recursion hell, where currently we hit a mutex deadlock but other possibilities include use-after-free during the unbind/cancel_userptr. Signed-off-by: Chris Wilson Cc: Michał Winiarski Cc: Tvrtko Ursulin --- d

Re: [Intel-gfx] [PATCH 0/7] drm/i915/dsi: stop using drm_panel, refactor

2017-03-06 Thread Hans de Goede
Hi, On 06-03-17 15:31, Jani Nikula wrote: This is pretty natural continuation to what Hans started. We haven't made use of the drm_panel framework much at all, and there's no need in sight, really. It was good for ensuring a certain amount of separation between the core and the VBT stuff. Let's

Re: [Intel-gfx] [PATCH 3/3] drm/i915: No need to save/restore irq status in intel_engine_wakeup

2017-03-06 Thread Chris Wilson
On Mon, Mar 06, 2017 at 03:11:47PM +, Chris Wilson wrote: > On Mon, Mar 06, 2017 at 03:03:21PM +, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > > > It is called from either the process or timer context so it is > > correct to always disable interrupts. > > > > Signed-off-by: Tvrtko

Re: [Intel-gfx] [PATCH 3/3] drm/i915: No need to save/restore irq status in intel_engine_wakeup

2017-03-06 Thread Chris Wilson
On Mon, Mar 06, 2017 at 03:03:21PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > It is called from either the process or timer context so it is > correct to always disable interrupts. > > Signed-off-by: Tvrtko Ursulin > Cc: Chris Wilson All 3 look ok to me, I was uncertain about the

[Intel-gfx] [PATCH 1/3] drm/i915: No need to save/restore irq status in __i915_request_irq_complete

2017-03-06 Thread Tvrtko Ursulin
From: Tvrtko Ursulin It is always called from thread context. Signed-off-by: Tvrtko Ursulin Cc: Chris Wilson --- drivers/gpu/drm/i915/i915_drv.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 1fd

[Intel-gfx] [PATCH 3/3] drm/i915: No need to save/restore irq status in intel_engine_wakeup

2017-03-06 Thread Tvrtko Ursulin
From: Tvrtko Ursulin It is called from either the process or timer context so it is correct to always disable interrupts. Signed-off-by: Tvrtko Ursulin Cc: Chris Wilson --- drivers/gpu/drm/i915/intel_breadcrumbs.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/driver

[Intel-gfx] [PATCH 2/3] drm/i915: No need to save/restore irq status in intel_breadcrumbs_fake_irq

2017-03-06 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Timer callback is a known context so it is correct to always disable interrupts. Signed-off-by: Tvrtko Ursulin Cc: Chris Wilson --- drivers/gpu/drm/i915/intel_breadcrumbs.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Signal the request submission after updating hw

2017-03-06 Thread Patchwork
== Series Details == Series: drm/i915: Signal the request submission after updating hw URL : https://patchwork.freedesktop.org/series/20757/ State : failure == Summary == Series 20757v1 drm/i915: Signal the request submission after updating hw https://patchwork.freedesktop.org/api/1.0/series/2

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Take rpm wakelock for releasing the fence on unbind

2017-03-06 Thread Chris Wilson
On Mon, Mar 06, 2017 at 02:03:26PM +, Tvrtko Ursulin wrote: > > On 06/03/2017 09:29, Chris Wilson wrote: > >Unbind the vma may happen at any time, outside of the normal GT wakeref. > >As such it relies on having a wakeref of its own. However, we can forgo > >clearing the register whilst the de

Re: [Intel-gfx] [PATCH 5/7] drm/i915/dsi: rename intel_dsi_pre_disable to intel_dsi_disable

2017-03-06 Thread Ville Syrjälä
On Mon, Mar 06, 2017 at 04:31:28PM +0200, Jani Nikula wrote: > The hook names reflect more the phase in the mode set sequence the hooks > are called in than what they actually do in terms of the specific > encoder. Stick to that scheme, and rename intel_dsi_pre_disable to > intel_dsi_disable. Unify

[Intel-gfx] [PATCH 3/7] drm/i915/dsi: stop using the drm_panel framework completely

2017-03-06 Thread Jani Nikula
Now that we've stopped using the drm_panel hooks, there aren't any benefits left with using the drm_panel framework. Remove the rest of the drm_panel use. No functional changes. Cc: Madhav Chauhan Cc: Hans de Goede Cc: Bob Paauwe Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_dsi.c

[Intel-gfx] [PATCH 5/7] drm/i915/dsi: rename intel_dsi_pre_disable to intel_dsi_disable

2017-03-06 Thread Jani Nikula
The hook names reflect more the phase in the mode set sequence the hooks are called in than what they actually do in terms of the specific encoder. Stick to that scheme, and rename intel_dsi_pre_disable to intel_dsi_disable. Unify the comments around this while at it. No functional changes. Cc: Ma

[Intel-gfx] [PATCH 2/7] drm/i915/dsi: call vbt_panel_get_modes directly instead of via drm_panel

2017-03-06 Thread Jani Nikula
Commit 18a00095a5f3 ("drm/i915/dsi: Make intel_dsi_enable/disable directly exec VBT sequences") started calling the VBT sequence functions directly instead of using the drm_panel hooks. Remove the last drm_panel hook by calling vbt_panel_get_modes() directly. No functional changes. Cc: Madhav Chau

[Intel-gfx] [PATCH 0/7] drm/i915/dsi: stop using drm_panel, refactor

2017-03-06 Thread Jani Nikula
This is pretty natural continuation to what Hans started. We haven't made use of the drm_panel framework much at all, and there's no need in sight, really. It was good for ensuring a certain amount of separation between the core and the VBT stuff. Let's keep things that way, but without the interfa

[Intel-gfx] [PATCH 6/7] drm/i915/dsi: rename intel_dsi_panel_vbt.c to intel_dsi_vbt.c

2017-03-06 Thread Jani Nikula
Emphasize that the VBT file is nowadays more about initializing and running stuff based on the VBT contents, not so much about being a "panel driver". No functional changes. Cc: Madhav Chauhan Cc: Hans de Goede Cc: Bob Paauwe Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile

[Intel-gfx] [PATCH 1/7] drm/i915/dsi: remove support for more than one panel driver

2017-03-06 Thread Jani Nikula
Fact is, there are no other panel drivers except the VBT based one. Simplify the code and maintenance. No functional changes. Cc: Madhav Chauhan Cc: Hans de Goede Cc: Bob Paauwe Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_dsi.c | 19 +-- drivers/gpu/drm

[Intel-gfx] [PATCH 7/7] drm/i915/dsi: arrange intel_dsi.h according to relevant files

2017-03-06 Thread Jani Nikula
No functional changes. Cc: Madhav Chauhan Cc: Hans de Goede Cc: Bob Paauwe Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_dsi.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_dsi.h b/drivers/gpu/drm/i915/intel_dsi.h index d395f6de

[Intel-gfx] [PATCH 4/7] drm/i915/dsi: rename intel_dsi_exec_vbt_sequence to intel_dsi_vbt_exec_sequence

2017-03-06 Thread Jani Nikula
Use the prefix intel_dsi_vbt for all the DSI VBT functions. No functional changes. Cc: Madhav Chauhan Cc: Hans de Goede Cc: Bob Paauwe Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_dsi.c | 24 drivers/gpu/drm/i915/intel_dsi.h | 5 ++---

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Use pagecache write to prepopulate shmemfs from pwrite-ioctl

2017-03-06 Thread Chris Wilson
On Mon, Mar 06, 2017 at 01:49:33PM +, Tvrtko Ursulin wrote: > > On 06/03/2017 12:48, Chris Wilson wrote: > >For the moment, yes :) This was a quick hack to hide a regression - the > > Oh it was a real regression and not just an optimisation for a > strange client behaviour? You should add a F

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Take rpm wakelock for releasing the fence on unbind

2017-03-06 Thread Tvrtko Ursulin
On 06/03/2017 09:29, Chris Wilson wrote: Unbind the vma may happen at any time, outside of the normal GT wakeref. As such it relies on having a wakeref of its own. However, we can forgo clearing the register whilst the device is asleep and just mark it as unused - so that when we do wake up the

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Flush idle work when changing missed-irq fault injection (rev2)

2017-03-06 Thread Patchwork
== Series Details == Series: drm/i915: Flush idle work when changing missed-irq fault injection (rev2) URL : https://patchwork.freedesktop.org/series/20752/ State : failure == Summary == Series 20752v2 drm/i915: Flush idle work when changing missed-irq fault injection https://patchwork.freed

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Use pagecache write to prepopulate shmemfs from pwrite-ioctl

2017-03-06 Thread Tvrtko Ursulin
On 06/03/2017 12:48, Chris Wilson wrote: On Mon, Mar 06, 2017 at 12:24:46PM +, Tvrtko Ursulin wrote: On 06/03/2017 09:29, Chris Wilson wrote: Before we instantiate/pin the backing store for our use, we can prepopulate the shmemfs filp efficiently using the a write into the pagecache. We a

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Wake up all waiters before idling

2017-03-06 Thread Chris Wilson
On Mon, Mar 06, 2017 at 11:02:03AM +, Chris Wilson wrote: > On Mon, Mar 06, 2017 at 09:29:15AM +, Chris Wilson wrote: > > void intel_engine_disarm_breadcrumbs(struct intel_engine_cs *engine) > > { > > struct intel_breadcrumbs *b = &engine->breadcrumbs; > > - unsigned long flags; > >

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Use pagecache write to prepopulate shmemfs from pwrite-ioctl

2017-03-06 Thread Chris Wilson
On Mon, Mar 06, 2017 at 12:24:46PM +, Tvrtko Ursulin wrote: > > On 06/03/2017 09:29, Chris Wilson wrote: > >Before we instantiate/pin the backing store for our use, we > >can prepopulate the shmemfs filp efficiently using the a > >write into the pagecache. We avoid the penalty of instantiating

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/3] drm/i915: Use pagecache write to prepopulate shmemfs from pwrite-ioctl

2017-03-06 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Use pagecache write to prepopulate shmemfs from pwrite-ioctl URL : https://patchwork.freedesktop.org/series/20747/ State : failure == Summary == Series 20747v1 Series without cover letter https://patchwork.freedesktop.org/api/1

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Use pagecache write to prepopulate shmemfs from pwrite-ioctl

2017-03-06 Thread Tvrtko Ursulin
On 06/03/2017 09:29, Chris Wilson wrote: Before we instantiate/pin the backing store for our use, we can prepopulate the shmemfs filp efficiently using the a write into the pagecache. We avoid the penalty of instantiating all the pages, important if the user is just writing to a few and never us

Re: [Intel-gfx] [regression] Re: 4.11-rc0, thinkpad x220: GPU hang

2017-03-06 Thread Chris Wilson
On Mon, Mar 06, 2017 at 01:10:48PM +0100, Pavel Machek wrote: > On Mon 2017-03-06 11:15:28, Chris Wilson wrote: > > On Mon, Mar 06, 2017 at 12:01:51AM +0100, Pavel Machek wrote: > > > Hi! > > > > > > > > mplayer stopped working after a while. Dmesg says: > > > > > > > > > > [ 3000.266533] cdc_eth

Re: [Intel-gfx] [regression] Re: 4.11-rc0, thinkpad x220: GPU hang

2017-03-06 Thread Pavel Machek
On Mon 2017-03-06 11:15:28, Chris Wilson wrote: > On Mon, Mar 06, 2017 at 12:01:51AM +0100, Pavel Machek wrote: > > Hi! > > > > > > mplayer stopped working after a while. Dmesg says: > > > > > > > > [ 3000.266533] cdc_ether 2-1.2:1.0 usb0: register 'cdc_ether' at > > > > Now I'm pretty sure it i

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Complain if we take too long under vblank evasion.

2017-03-06 Thread Maarten Lankhorst
Op 01-03-17 om 16:40 schreef Ville Syrjälä: > On Tue, Feb 28, 2017 at 03:28:48PM +0100, Maarten Lankhorst wrote: >> Signed-off-by: Maarten Lankhorst >> --- >> drivers/gpu/drm/i915/intel_sprite.c | 12 ++-- >> 1 file changed, 10 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/

Re: [Intel-gfx] [PATCH] drm/i915: Signal the request submission after updating hw

2017-03-06 Thread Chris Wilson
On Mon, Mar 06, 2017 at 11:23:04AM +, Chris Wilson wrote: > As we may queue addition requests from the submit fence, we may recurse > into i9xx_submit_request() and write a future request's TAIL only to be > then overwritten by the parent. Reorder the hw write before the signal > so that any ch

Re: [Intel-gfx] [regression] Re: 4.11-rc0, thinkpad x220: GPU hang

2017-03-06 Thread Chris Wilson
On Mon, Mar 06, 2017 at 11:15:28AM +, Chris Wilson wrote: > On Mon, Mar 06, 2017 at 12:01:51AM +0100, Pavel Machek wrote: > > Hi! > > > > > > mplayer stopped working after a while. Dmesg says: > > > > > > > > [ 3000.266533] cdc_ether 2-1.2:1.0 usb0: register 'cdc_ether' at > > > > Now I'm pr

Re: [Intel-gfx] [PATCH] drm/i915: Signal the request submission after updating hw

2017-03-06 Thread Chris Wilson
On Mon, Mar 06, 2017 at 11:23:04AM +, Chris Wilson wrote: > As we may queue addition requests from the submit fence, we may recurse > into i9xx_submit_request() and write a future request's TAIL only to be > then overwritten by the parent. Reorder the hw write before the signal > so that any ch

[Intel-gfx] [PATCH] drm/i915: Signal the request submission after updating hw

2017-03-06 Thread Chris Wilson
As we may queue addition requests from the submit fence, we may recurse into i9xx_submit_request() and write a future request's TAIL only to be then overwritten by the parent. Reorder the hw write before the signal so that any child fences that then submit fences are ordered correctly. Reported-by

Re: [Intel-gfx] [regression] Re: 4.11-rc0, thinkpad x220: GPU hang

2017-03-06 Thread Chris Wilson
On Mon, Mar 06, 2017 at 12:01:51AM +0100, Pavel Machek wrote: > Hi! > > > > mplayer stopped working after a while. Dmesg says: > > > > > > [ 3000.266533] cdc_ether 2-1.2:1.0 usb0: register 'cdc_ether' at > > Now I'm pretty sure it is a regression in v4.11-rc0. Any ideas what to > try? Bisect wil

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Wake up all waiters before idling

2017-03-06 Thread Chris Wilson
On Mon, Mar 06, 2017 at 09:29:15AM +, Chris Wilson wrote: > void intel_engine_disarm_breadcrumbs(struct intel_engine_cs *engine) > { > struct intel_breadcrumbs *b = &engine->breadcrumbs; > - unsigned long flags; > + struct intel_wait *wait, *n; > > if (!b->irq_armed) >

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/glk: Remove MODULE_FIRMWARE() tag from Geminilake's DMC

2017-03-06 Thread Ander Conselvan De Oliveira
On Mon, 2017-03-06 at 10:24 +, Patchwork wrote: > == Series Details == > > Series: drm/i915/glk: Remove MODULE_FIRMWARE() tag from Geminilake's DMC > URL : https://patchwork.freedesktop.org/series/20744/ > State : success Pushed to drm-intel-next-queued. Thanks, Ander > > == Summary == >

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Clear the VBT defaults for unused ports (rev2)

2017-03-06 Thread Patchwork
== Series Details == Series: drm/i915: Clear the VBT defaults for unused ports (rev2) URL : https://patchwork.freedesktop.org/series/20619/ State : failure == Summary == Series 20619v2 drm/i915: Clear the VBT defaults for unused ports https://patchwork.freedesktop.org/api/1.0/series/20619/revi

Re: [Intel-gfx] [PATCH] drm/i915: Wake up all waiters before idling

2017-03-06 Thread Mika Kuoppala
Chris Wilson writes: > When we idle, we wakeup the first waiter (checking to see if it missed > an earlier wakeup) and disarm the breadcrumbs. However, we now assert > that there are no waiter when the interrupt is disabled, triggering an > assert if there were multiple waiters when we idled. > >

Re: [Intel-gfx] [RFC 05/11] drm/i915/preempt: Handle preemption event in guc tasklet

2017-03-06 Thread Chris Wilson
On Wed, Mar 01, 2017 at 12:57:15PM +, Chris Wilson wrote: > On Thu, Feb 23, 2017 at 08:14:15PM +0100, Michał Winiarski wrote: > > +static void unsubmit_inflight_requests(struct intel_engine_cs *engine, > > +struct list_head *resubmit) > > +{ > > + struct dr

Re: [Intel-gfx] [PATCH] drm/i915: Wake up all waiters before idling

2017-03-06 Thread Chris Wilson
On Mon, Mar 06, 2017 at 12:30:17PM +0200, Mika Kuoppala wrote: > Chris Wilson writes: > > + spin_lock_irq(&b->rb_lock); > > + rbtree_postorder_for_each_entry_safe(wait, n, &b->waiters, node) { > > + RB_CLEAR_NODE(&wait->node); > > + if (wake_up_process(wait->tsk) && wait ==

Re: [Intel-gfx] [PATCH] drm/i915: Wake up all waiters before idling

2017-03-06 Thread Mika Kuoppala
Chris Wilson writes: > When we idle, we wakeup the first waiter (checking to see if it missed > an earlier wakeup) and disarm the breadcrumbs. However, we now assert > that there are no waiter when the interrupt is disabled, triggering an > assert if there were multiple waiters when we idled. > >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/glk: Remove MODULE_FIRMWARE() tag from Geminilake's DMC

2017-03-06 Thread Patchwork
== Series Details == Series: drm/i915/glk: Remove MODULE_FIRMWARE() tag from Geminilake's DMC URL : https://patchwork.freedesktop.org/series/20744/ State : success == Summary == Series 20744v1 drm/i915/glk: Remove MODULE_FIRMWARE() tag from Geminilake's DMC https://patchwork.freedesktop.org/ap

[Intel-gfx] [PATCH v2] drm/i915: Flush idle work when changing missed-irq fault injection

2017-03-06 Thread Chris Wilson
In order for the missed-irq update to take effect, the device must be idle. So when the user updates the fault injection via debugfs, idle the device. v2: Idle is explicitly required for setting test_irq, and good behaviour for clearing the missed_irq. Testcase: igt/drv_missed_irq Signed-off-by:

[Intel-gfx] [PATCH] drm/i915: Flush idle work when changing missed-irq fault injection

2017-03-06 Thread Chris Wilson
In order for the missed-irq update to take effect, the device must be idle. So when the user updates the fault injection via debugfs, idle the device. Testcase: igt/drv_missed_irq Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_debugfs.c | 29 - 1 file chang

[Intel-gfx] [PULL] drm-misc-next

2017-03-06 Thread Daniel Vetter
Hi Dave, drm-misc-next-2017-03-06: First slice of drm-misc-next for 4.12: Core/subsystem-wide: - link status core patch from Manasi, for signalling link train fail to userspace. I also had the i915 patch in here, but that had a small buglet in our CI, so reverted. - more debugfs_remove remova

[Intel-gfx] Updated drm-intel-testing

2017-03-06 Thread Daniel Vetter
Hi all, 4 weeks worth of stuff since I was traveling&lazy: - lspcon improvements (Imre) - proper atomic state for cdclk handling (Ville) - gpu reset improvements (Chris) - lots and lots of polish around fences, requests, waiting and everything related all over (both gem and modeset code), from

[Intel-gfx] [PULL] drm-misc-fixes

2017-03-06 Thread Daniel Vetter
Hi Dave, drm-misc-fixes-2017-03-06: Just 1 8bpc quirk from Ville, cc: stable I somehow lost this patch for 2 weeks despite that my status script showed me that there's something pending. Oh well, here it is :( Cheers, Daniel The following changes since commit c1ae3cfa0e89fa1a7ecc4c99031f5e9ae9

[Intel-gfx] [PATCH 3/3] drm/i915: Take rpm wakelock for releasing the fence on unbind

2017-03-06 Thread Chris Wilson
Unbind the vma may happen at any time, outside of the normal GT wakeref. As such it relies on having a wakeref of its own. However, we can forgo clearing the register whilst the device is asleep and just mark it as unused - so that when we do wake up the device, we will clear the unused fence regis

[Intel-gfx] [PATCH 2/3] drm/i915: Wake up all waiters before idling

2017-03-06 Thread Chris Wilson
When we idle, we wakeup the first waiter (checking to see if it missed an earlier wakeup) and disarm the breadcrumbs. However, we now assert that there are no waiter when the interrupt is disabled, triggering an assert if there were multiple waiters when we idled. [ 420.842275] invalid opcode: 00

[Intel-gfx] [PATCH 1/3] drm/i915: Use pagecache write to prepopulate shmemfs from pwrite-ioctl

2017-03-06 Thread Chris Wilson
Before we instantiate/pin the backing store for our use, we can prepopulate the shmemfs filp efficiently using the a write into the pagecache. We avoid the penalty of instantiating all the pages, important if the user is just writing to a few and never uses the object on the GPU, and using a direct

[Intel-gfx] [PATCH 3.12 014/113] drm/i915: Don't leak edid in intel_crt_detect_ddc()

2017-03-06 Thread Jiri Slaby
From: Ander Conselvan de Oliveira 3.12-stable review patch. If anyone has any objections, please let me know. === commit c34f078675f505c4437919bb1897b1351f16a050 upstream. In the path where intel_crt_detect_ddc() detects a CRT, if would return true without freeing the edid. Fixes

Re: [Intel-gfx] [PATCH] drm/i915/glk: Remove MODULE_FIRMWARE() tag from Geminilake's DMC

2017-03-06 Thread Jani Nikula
On Mon, 06 Mar 2017, Ander Conselvan de Oliveira wrote: > Geminilake's DMC is not yet available in the linux-firmware repository. > To prevent userspace tools such as mkinitramfs to complain about > missing firmware, remove the MODULE_FIRMWARE() tag for now. > > Fixes: dbb28b5c3d3c ("drm/i915/DMC

[Intel-gfx] [PATCH v2] drm/i915: Clear the VBT defaults for unused ports

2017-03-06 Thread Manasi Navare
If during VBT parsing we find that the port is unused, the driver code just bails out without clearing the defaults for that port. This can cause failures down the path through link training for unused Port. This patch fixes this issue by clearing the defaults before bailing out from the VBT parsin

  1   2   >