[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Rework sdvo proxy i2c locking

2017-07-25 Thread Patchwork
== Series Details == Series: drm/i915: Rework sdvo proxy i2c locking URL : https://patchwork.freedesktop.org/series/27907/ State : success == Summary == Series 27907v1 drm/i915: Rework sdvo proxy i2c locking https://patchwork.freedesktop.org/api/1.0/series/27907/revisions/1/mbox/ Test kms_pip

[Intel-gfx] linux-next: unsigned commits in the drm-misc tree

2017-07-25 Thread Stephen Rothwell
Hi all, I noticed a set of commits that have no Signed-off-by from their committer: d9864a1d2dfc ("drm/stm: drv: Rename platform driver name") to ed34d261a12a ("drm/stm: dsi: Constify phy ops structure") -- Cheers, Stephen Rothwell ___ Intel-gfx

[Intel-gfx] [PATCH] drm/i915: Rework sdvo proxy i2c locking

2017-07-25 Thread Daniel Vetter
lockdep complaints about a locking recursion for the i2c bus lock because both the sdvo ddc proxy bus and the gmbus nested within use the same locking class. It's not really a deadlock since we never nest the other way round, but it's annoying. Fix it by pulling the gmbus locking into the i2c lock

Re: [Intel-gfx] [PATCH] drm/i915: Handle msr read failure gracefully

2017-07-25 Thread Gabriel Krisman Bertazi
Chris Wilson writes: > Quoting Gabriel Krisman Bertazi (2017-07-25 19:19:22) >> power = (power & 0x1f00) >> 8; >> units = 100 / (1 << power); /* convert to uJ */ >> power = I915_READ(MCH_SECP_NRG_STTS); > > Just after this is a useless cast. Though it will be neater to

Re: [Intel-gfx] [PATCH 18/20] drm/i915/selftests: Retarget igt_render_engine_reset_fallback()

2017-07-25 Thread Michel Thierry
On 7/21/2017 5:32 AM, Chris Wilson wrote: The purpose of the test was to check per-engine resets would fallback to the global reset when required, but first we actually need a test for a basic i915_handle_error()! Cc: Mika Kuoppala Cc: Michel Thierry Signed-off-by: Chris Wilson --- drivers/

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Eliminate dead code in intel_sanitize_enable_ppgtt() (rev2)

2017-07-25 Thread Patchwork
== Series Details == Series: drm/i915: Eliminate dead code in intel_sanitize_enable_ppgtt() (rev2) URL : https://patchwork.freedesktop.org/series/8105/ State : success == Summary == Series 8105v2 drm/i915: Eliminate dead code in intel_sanitize_enable_ppgtt() https://patchwork.freedesktop.org/a

[Intel-gfx] [PATCH] drm/i915: Eliminate dead code in intel_sanitize_enable_ppgtt()

2017-07-25 Thread Imre Deak
From: Damien Lespiau We exit early if has_aliasing_ppgtt is 0, so towards the end of the function has_aliasing_ppgtt can only be 1. Also: if (foo) return 1; else return 0; when foo is already a bool is really just: return foo; v2: - Sim

Re: [Intel-gfx] [PATCH 11/21] drm/i915: support 1G pages for the 48b PPGTT

2017-07-25 Thread Chris Wilson
Quoting Matthew Auld (2017-07-25 20:21:23) > Support inserting 1G gtt pages into the 48b PPGTT. > > v2: sanity check sg->length against page_size > > Signed-off-by: Matthew Auld > Cc: Joonas Lahtinen > Cc: Chris Wilson > --- > drivers/gpu/drm/i915/i915_gem_gtt.c | 73 > ++

[Intel-gfx] ✓ Fi.CI.BAT: success for huge gtt pages (rev5)

2017-07-25 Thread Patchwork
== Series Details == Series: huge gtt pages (rev5) URL : https://patchwork.freedesktop.org/series/25118/ State : success == Summary == Series 25118v5 huge gtt pages https://patchwork.freedesktop.org/api/1.0/series/25118/revisions/5/mbox/ Test kms_flip: Subgroup basic-flip-vs-modeset:

Re: [Intel-gfx] [PATCH 06/21] drm/i915: introduce vm set_pages/clear_pages

2017-07-25 Thread Chris Wilson
Quoting Matthew Auld (2017-07-25 20:21:18) > @@ -471,25 +473,31 @@ i915_vma_insert(struct i915_vma *vma, u64 size, u64 > alignment, u64 flags) > if (ret) > return ret; > GEM_BUG_ON(vma->pages); > + if (!vma->pages) { > + ret = vma->vm->set_pages(vma)

[Intel-gfx] [PATCH 20/21] drm/i915: enable platform support for 2M pages

2017-07-25 Thread Matthew Auld
For gen8+ platforms which support the 48b PPGTT, enable platform level support for 2M pages. Also enable for mock testing. Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Chris Wilson --- drivers/gpu/drm/i915/i915_pci.c | 6 -- drivers/gpu/drm/i915/selftests/mock_gem_d

[Intel-gfx] [PATCH 14/21] drm/i915: accurate page size tracking for the ppgtt

2017-07-25 Thread Matthew Auld
Now that we support multiple page sizes for the ppgtt, it would be useful to track the real usage for debugging purposes. Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_gtt.c| 10 ++ drivers/gpu/drm/i915/i915_gem_object.h | 10 +++

[Intel-gfx] [PATCH 19/21] drm/i915: enable platform support for 64K pages

2017-07-25 Thread Matthew Auld
For gen9+ enable platform level support for 64K pages. Also enable for mock testing. Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Chris Wilson --- drivers/gpu/drm/i915/i915_pci.c | 3 ++- drivers/gpu/drm/i915/selftests/mock_gem_device.c | 3 ++- 2 files changed, 4 inser

[Intel-gfx] [PATCH 15/21] drm/i915/debugfs: include some gtt page size metrics

2017-07-25 Thread Matthew Auld
Good to know, mostly for debugging purposes. Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Chris Wilson --- drivers/gpu/drm/i915/i915_debugfs.c | 42 + 1 file changed, 38 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c

[Intel-gfx] [PATCH 16/21] drm/i915/selftests: huge page tests

2017-07-25 Thread Matthew Auld
v2: mock test page support configurations and add MI_STORE_DWORD test v3: run all mockable huge page tests on all platforms via the mock_device v4: add pin_update regression test various improvements suggested by Chris Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Chris Wilson ---

[Intel-gfx] [PATCH 21/21] drm/i915: enable platform support for 1G pages

2017-07-25 Thread Matthew Auld
For gen8+ enable platforms which support the 48b PPGTT, enable support for 1G pages. Also enable for mock testing. Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Chris Wilson --- drivers/gpu/drm/i915/i915_pci.c | 6 -- drivers/gpu/drm/i915/selftests/mock_gem_device.c

[Intel-gfx] [PATCH 18/21] drm/i915: disable platform support for vGPU huge gtt pages

2017-07-25 Thread Matthew Auld
Currently gvt gtt handling doesn't support huge page entries, so disable for now. Suggested-by: Zhenyu Wang Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Zhenyu Wang --- drivers/gpu/drm/i915/i915_gem.c | 9 + 1 file changed, 9 insertions(+) diff --git a/driver

[Intel-gfx] [PATCH 17/21] drm/i915/selftests: mix huge pages

2017-07-25 Thread Matthew Auld
Try to mix sg page sizes for 4K, 64K and 2M pages. v2: s/BIT(x) >> 12/BIT(x) >> PAGE_SHIFT/ Suggested-by: Chris Wilson Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Chris Wilson --- drivers/gpu/drm/i915/selftests/scatterlist.c | 15 +++ 1 file changed, 15 insertions(+) dif

[Intel-gfx] [PATCH 12/21] drm/i915: support 2M pages for the 48b PPGTT

2017-07-25 Thread Matthew Auld
Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_gtt.c | 8 drivers/gpu/drm/i915/i915_gem_gtt.h | 2 ++ 2 files changed, 10 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c index acd

[Intel-gfx] [PATCH 11/21] drm/i915: support 1G pages for the 48b PPGTT

2017-07-25 Thread Matthew Auld
Support inserting 1G gtt pages into the 48b PPGTT. v2: sanity check sg->length against page_size Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_gtt.c | 73 +++-- drivers/gpu/drm/i915/i915_gem_gtt.h | 2 + 2 f

[Intel-gfx] [PATCH 08/21] drm/i915: align 64K objects to 2M

2017-07-25 Thread Matthew Auld
We can't mix 64K and 4K pte's in the same page-table, so for now we align 64K objects to 2M to avoid any potential mixing. This is potentially wasteful but in reality shouldn't be too bad since this only applies to the virtual address space of a 48b PPGTT. v2: don't separate logically connected op

[Intel-gfx] [PATCH 06/21] drm/i915: introduce vm set_pages/clear_pages

2017-07-25 Thread Matthew Auld
Move the setting/clearing of the vma->pages to a vm operation. Doing so neatens things up a little, but more importantly gives us a sane place to also set/clear the vma->pages_sizes, which we introduce later in preparation for supporting huge-pages. Suggested-by: Chris Wilson Signed-off-by: Matth

[Intel-gfx] [PATCH 13/21] drm/i915: support 64K pages for the 48b PPGTT

2017-07-25 Thread Matthew Auld
Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_gtt.c | 26 ++ drivers/gpu/drm/i915/i915_gem_gtt.h | 1 + 2 files changed, 27 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_

[Intel-gfx] [PATCH 10/21] drm/i915: disable GTT cache for 2M/1G pages

2017-07-25 Thread Matthew Auld
When SW enables the use of 2M/1G pages, it must disable the GTT cache. v2: don't disable for Cherryview which doesn't even support 48b PPGTT! v3: explicitly check that the system does support 2M/1G pages Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Chris Wilson --- drivers/gpu/drm/i91

[Intel-gfx] [PATCH 09/21] drm/i915: enable IPS bit for 64K pages

2017-07-25 Thread Matthew Auld
Before we can enable 64K pages through the IPS bit, we must first enable it through MMIO, otherwise the page-walker will simply ignore it. Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Chris Wilson --- drivers/gpu/drm/i915/i915_gem.c | 11 +++ drivers/gpu/drm/i915/i915_reg.h | 3

[Intel-gfx] [PATCH 05/21] drm/i915: introduce page_size members

2017-07-25 Thread Matthew Auld
In preparation for supporting huge gtt pages for the ppgtt, we introduce page size members for gem objects. We fill in the page sizes by scanning the sg table. v2: pass the sg_mask to set_pages v3: calculate the sg_mask inline with populating the sg_table where possible, and pass to set_pages al

[Intel-gfx] [PATCH 03/21] drm/i915/gemfs: enable THP

2017-07-25 Thread Matthew Auld
Enable transparent-huge-pages through gemfs by mounting with huge=within_size. Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Chris Wilson --- drivers/gpu/drm/i915/i915_gemfs.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_gemfs.c b/driver

[Intel-gfx] [PATCH 07/21] drm/i915: align the vma start to the largest gtt page size

2017-07-25 Thread Matthew Auld
For the 48b PPGTT try to align the vma start address to the required page size boundary to guarantee we use said page size in the gtt. If we are dealing with multiple page sizes, we can't guarantee anything and just align to the largest. For soft pinning and objects which need to be tightly packed

[Intel-gfx] [PATCH 04/21] drm/i915: introduce page_size_mask to dev_info

2017-07-25 Thread Matthew Auld
In preparation for huge gtt pages expose a page_size_mask as part of the device info, to indicate the page sizes supported by the HW. Currently only 4K is supported. Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Mika Kuoppala Cc: Chris Wilson Reviewed-by: Joonas Lahtinen --- drivers/g

[Intel-gfx] [PATCH 00/21] huge gtt pages

2017-07-25 Thread Matthew Auld
Some updates to the kselftests as per Chris' comments. Matthew Auld (21): mm/shmem: introduce shmem_file_setup_with_mnt drm/i915: introduce simple gemfs drm/i915/gemfs: enable THP drm/i915: introduce page_size_mask to dev_info drm/i915: introduce page_size members drm/i915: introduce v

[Intel-gfx] [PATCH 01/21] mm/shmem: introduce shmem_file_setup_with_mnt

2017-07-25 Thread Matthew Auld
We are planning to use our own tmpfs mnt in i915 in place of the shm_mnt, such that we can control the mount options, in particular huge=, which we require to support huge-gtt-pages. So rather than roll our own version of __shmem_file_setup, it would be preferred if we could just give shmem our mnt

[Intel-gfx] [PATCH 02/21] drm/i915: introduce simple gemfs

2017-07-25 Thread Matthew Auld
Not a fully blown gemfs, just our very own tmpfs kernel mount. Doing so moves us away from the shmemfs shm_mnt, and gives us the much needed flexibility to do things like set our own mount options, namely huge= which should allow us to enable the use of transparent-huge-pages for our shmem backed o

Re: [Intel-gfx] [PATCH] drm/i915: Handle msr read failure gracefully

2017-07-25 Thread Chris Wilson
Quoting Gabriel Krisman Bertazi (2017-07-25 19:19:22) > When reading the i915_energy_uJ debugfs file, it tries to fetch > MSR_RAPL_POWER_UNIT, which might not be available, like in a vm > environment, causing the exception shown below. > > We can easily prevent it by doing a rdmsrl_safe read inste

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Handle msr read failure gracefully

2017-07-25 Thread Patchwork
== Series Details == Series: drm/i915: Handle msr read failure gracefully URL : https://patchwork.freedesktop.org/series/27884/ State : success == Summary == Series 27884v1 drm/i915: Handle msr read failure gracefully https://patchwork.freedesktop.org/api/1.0/series/27884/revisions/1/mbox/ Te

Re: [Intel-gfx] [PATCH v5] drm/i915: Fix FBC cfb stride programming for non X-tiled FB

2017-07-25 Thread Paulo Zanoni
Em Qua, 2017-07-19 às 00:27 +0530, Praveen Paneri escreveu: > When FBC is enabled for linear, legacy Y-tiled and Yf-tiled > surfaces on gen9, the cfb stride must be programmed by SW as > > cfb_stride = ceiling[(at least plane width in pixels)/ >  (32 * compression limit factor)]

Re: [Intel-gfx] [PATCH] drm/i915/cnl: Fix loadgen select programming on ddi vswing sequence

2017-07-25 Thread Navare, Manasi D
Thanks for the review ! Manasi Em Seg, 2017-07-17 às 15:05 -0700, Manasi Navare escreveu: > The condition for setting the Loadgen Select bit of > PORT_TX_DW4 register during DDI Vswing Sequence should be Bit rate <=6 > GHz whereas the existing code checks only Bit Rate < 6GHz. This patch > fix

[Intel-gfx] [PATCH] drm/i915: Handle msr read failure gracefully

2017-07-25 Thread Gabriel Krisman Bertazi
When reading the i915_energy_uJ debugfs file, it tries to fetch MSR_RAPL_POWER_UNIT, which might not be available, like in a vm environment, causing the exception shown below. We can easily prevent it by doing a rdmsrl_safe read instead, which will handle the exception, allowing us to abort the de

Re: [Intel-gfx] [PATCH] drm/i915/cnl: Fix loadgen select programming on ddi vswing sequence

2017-07-25 Thread Paulo Zanoni
Em Seg, 2017-07-17 às 15:05 -0700, Manasi Navare escreveu: > The condition for setting the Loadgen Select bit of > PORT_TX_DW4 register during DDI Vswing Sequence should be > Bit rate <=6 GHz whereas the existing code checks only > Bit Rate < 6GHz. This patch fixes this condition. > While at it als

[Intel-gfx] ✗ Fi.CI.BAT: failure for Kernel PSR Fix-ups

2017-07-25 Thread Patchwork
== Series Details == Series: Kernel PSR Fix-ups URL : https://patchwork.freedesktop.org/series/27879/ State : failure == Summary == Series 27879v1 Kernel PSR Fix-ups https://patchwork.freedesktop.org/api/1.0/series/27879/revisions/1/mbox/ Test core_auth: Subgroup basic-auth:

Re: [Intel-gfx] [PATCH v4 RESEND 0/4] Kernel PSR Fix-ups

2017-07-25 Thread David Weinehall
On Tue, Jul 25, 2017 at 09:48:07AM -0700, Jim Bride wrote: > These patches, along with an upcoming series for IGT, enable our > PSR IGT tests to run reliably once again on HSW, BDW, and SKL. > The first change enables us to run the PSR tests on some RVP platforms > whose panels have too slow of a s

Re: [Intel-gfx] [PATCH i-g-t 2/3] configure.ac: Disable chamelium by default and add enable argument

2017-07-25 Thread Lyude Paul
I like this patch, however there's a mistake in it: On Tue, 2017-07-25 at 15:48 +0300, Paul Kocialkowski wrote: > Since the chamelium is not a very usual piece of hardware and > requires > pulling-in lots of specific dependencies, it makes sense to keep it > disabled by default. > > An explicit -

Re: [Intel-gfx] [PATCH i-g-t 3/3] README: Add information about chamelium dependencies

2017-07-25 Thread Lyude Paul
R-b'd and pushed, thanks! On Tue, 2017-07-25 at 15:48 +0300, Paul Kocialkowski wrote: > This adds a list of dependencies required to build chamelium support, > so that what needs to be installed to get it going is more obvious. > > As done previously in the file, the list is relevant for Debian a

Re: [Intel-gfx] [PATCH i-g-t 1/3] configure.ac: Make udev a dependency for chamelium

2017-07-25 Thread Lyude Paul
R-b'd and pushed, thanks! On Tue, 2017-07-25 at 15:48 +0300, Paul Kocialkowski wrote: > Chamelium testing has a hard dependency on udev. This makes this > dependency explicit in configure instead of failing the build when it > is missing. > > Signed-off-by: Paul Kocialkowski > --- > configure.a

[Intel-gfx] [PATCH v4 RESEND 1/4] drm/i915/psr: Clean-up intel_enable_source_psr1()

2017-07-25 Thread Jim Bride
On SKL+ there is a bit in SRD_CTL that software is not supposed to modify, but we currently clobber that bit when we enable PSR. In order to preserve the value of that bit, go ahead and read SRD_CTL and do a field-wise setting of the various bits that we need to initialize before writing the regis

[Intel-gfx] [PATCH v4 RESEND 3/4] drm/i915/edp: Be less aggressive about changing link config on eDP

2017-07-25 Thread Jim Bride
This set of changes has some history to them. There were several attempts to add what was called "fast link training" to i915, which actually wasn't fast link training as per the DP spec. These changes were 5fa836a9d859 ("drm/i915: DP link training optimization") 4e96c97742f4 ("drm/i915: eDP lin

[Intel-gfx] [PATCH v4 RESEND 2/4] drm/i915/psr: Account for sink CRC raciness on some panels

2017-07-25 Thread Jim Bride
According to the eDP spec, when the count field in TEST_SINK_MISC increments then the six bytes of sink CRC information in the DPCD should be valid. Unfortunately, this doesn't seem to be the case on some panels, and as a result we get some incorrect and inconsistent values from the sink CRC DPCD

[Intel-gfx] [PATCH v4 RESEND 0/4] Kernel PSR Fix-ups

2017-07-25 Thread Jim Bride
These patches, along with an upcoming series for IGT, enable our PSR IGT tests to run reliably once again on HSW, BDW, and SKL. The first change enables us to run the PSR tests on some RVP platforms whose panels have too slow of a setup time when running in their preferred mode. The second fixes a

[Intel-gfx] [PATCH v4 RESEND 4/4] drm/i915/edp: Allow alternate fixed mode for eDP if available.

2017-07-25 Thread Jim Bride
Some fixed resolution panels actually support more than one mode, with the only thing different being the refresh rate. Having this alternate mode available to us is desirable, because it allows us to test PSR on panels whose setup time at the preferred mode is too long. With this patch we allow t

Re: [Intel-gfx] [PATCH v7 3/3] drm/i915: Implement I915_PERF_ADD/REMOVE_CONFIG interface

2017-07-25 Thread Lionel Landwerlin
On 25/07/17 12:30, Datczuk, Andrzej wrote: I think you looked only at the changes prepared previously by Matthew and just ported by me. I made a change on top of it in a third patch to alight the whitelist with MDAPI needs. The change you're looking for is "Subject: [PATCH 3/3] drm/i915: extend

Re: [Intel-gfx] [PATCH 1/2] drm/edid: Add helper to detect whether EDID changed

2017-07-25 Thread Daniel Vetter
On Tue, Jul 25, 2017 at 03:18:04PM +0300, Paul Kocialkowski wrote: > On Tue, 2017-07-25 at 10:16 +0200, Daniel Vetter wrote: > > On Tue, Jul 25, 2017 at 10:58:55AM +0300, Paul Kocialkowski wrote: > > > On Tue, 2017-07-25 at 09:34 +0200, Daniel Vetter wrote: > > > > On Tue, Jul 25, 2017 at 9:25 AM,

Re: [Intel-gfx] [PATCH i-g-t 2/2] tests/drv_suspend: Add subtests to check that forcewake is kept after resume

2017-07-25 Thread Chris Wilson
Quoting Ewelina Musial (2017-07-25 16:26:09) > In some cases we observed that forcewake isn't kept after > resume and checking RC6 residency is a simple way to verify that. > If forcewake is kept after resume residency should be constant. > > Cc: Lukasz Fiedorowicz > Cc: Radoslaw Szwichtenberg >

Re: [Intel-gfx] [PATCH i-g-t v3 0/5] Add Y-tiling support into IGTs

2017-07-25 Thread Praveen Paneri
On Tuesday 25 July 2017 08:48 PM, Paulo Zanoni wrote: Em Ter, 2017-07-18 às 22:52 +0530, Praveen Paneri escreveu: This series adds Y-tiled buffer creation support into IGT libraries and goes on to use this capability to add support into FBC tests to use Y-tiled buffers. Everything reviewed &

[Intel-gfx] [PATCH i-g-t 2/2] tests/drv_suspend: Add subtests to check that forcewake is kept after resume

2017-07-25 Thread Ewelina Musial
In some cases we observed that forcewake isn't kept after resume and checking RC6 residency is a simple way to verify that. If forcewake is kept after resume residency should be constant. Cc: Lukasz Fiedorowicz Cc: Radoslaw Szwichtenberg Cc: Michal Winiarski Signed-off-by: Ewelina Musial ---

[Intel-gfx] [PATCH i-g-t 1/2] igt: Move read_rc6_residency function to lib

2017-07-25 Thread Ewelina Musial
Gem_mocs_settings and pm_rc6_residency tests are defining the same functionality to read residency from sysfs. Moving that function to lib/igt_aux and updating tests. Signed-off-by: Ewelina Musial --- lib/igt_aux.c | 8 lib/igt_aux.h | 5 + tests/gem_mocs_s

Re: [Intel-gfx] [PATCH i-g-t v3 0/5] Add Y-tiling support into IGTs

2017-07-25 Thread Paulo Zanoni
Em Ter, 2017-07-18 às 22:52 +0530, Praveen Paneri escreveu: > This series adds Y-tiled buffer creation support into IGT libraries > and > goes on to use this capability to add support into FBC tests to use > Y-tiled buffers. Everything reviewed & merged. Thanks for the patches. Patch 5 contained

Re: [Intel-gfx] [PATCH 7/8] drm: Nuke drm_atomic_helper_connector_dpms

2017-07-25 Thread Shawn Guo
On Tue, Jul 25, 2017 at 10:01:21AM +0200, Daniel Vetter wrote: > It's dead code, the core handles all this directly now. > > The only special case is nouveau and tda988x which used one function > for both legacy modeset code and -nv50 atomic world instead of 2 > vtables. But amounts to exactly the

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Fix kbuild error

2017-07-25 Thread Chris Wilson
Quoting Chris Wilson (2017-07-25 13:53:36) > After rebasing af2788925ae0 ("drm/i915: Squelch reset messages during > selftests"), I missed fixing up a call to i915_reset(). > > Reported-by: kbuild test robot > Fixes: af2788925ae0 ("drm/i915: Squelch reset messages during selftests") > Signed-off-

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Fix kbuild error

2017-07-25 Thread David Weinehall
On Tue, Jul 25, 2017 at 01:53:36PM +0100, Chris Wilson wrote: > After rebasing af2788925ae0 ("drm/i915: Squelch reset messages during > selftests"), I missed fixing up a call to i915_reset(). > > Reported-by: kbuild test robot > Fixes: af2788925ae0 ("drm/i915: Squelch reset messages during selfte

[Intel-gfx] [PATCH i-g-t] igt: Move read_rc6_residency function to lib

2017-07-25 Thread Ewelina Musial
Gem_mocs_settings and pm_rc6_residency tests are defining the same functionality to read residency from sysfs. Moving that function to lib/igt_aux and updating tests. Signed-off-by: Ewelina Musial --- lib/igt_aux.c | 8 lib/igt_aux.h | 5 + tests/gem_mocs_s

Re: [Intel-gfx] [PATCH 7/8] drm: Nuke drm_atomic_helper_connector_dpms

2017-07-25 Thread Laurent Pinchart
Hi Daniel, Thank you for the patch. On Tuesday 25 Jul 2017 10:01:21 Daniel Vetter wrote: > It's dead code, the core handles all this directly now. > > The only special case is nouveau and tda988x which used one function > for both legacy modeset code and -nv50 atomic world instead of 2 > vtables

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/sdvo: Shut up state checker with hdmi cards on gen3

2017-07-25 Thread Patchwork
== Series Details == Series: drm/i915/sdvo: Shut up state checker with hdmi cards on gen3 URL : https://patchwork.freedesktop.org/series/27860/ State : failure == Summary == CHK include/config/kernel.release CHK include/generated/uapi/linux/version.h CHK include/generated/uts

[Intel-gfx] [PATCH] drm/i915/sdvo: Shut up state checker with hdmi cards on gen3

2017-07-25 Thread Daniel Vetter
The hdmi bits simply don't exist, so nerf them. I think audio doesn't work on gen3 at all, and for the limited color range we should probably use the colorimetry sdvo paramater instead of the bit in the port. But fixing sdvo isn't my goal, I just want to get the backtrace out of the way, and this

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Fix kbuild error

2017-07-25 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Fix kbuild error URL : https://patchwork.freedesktop.org/series/27856/ State : success == Summary == Series 27856v1 drm/i915/selftests: Fix kbuild error https://patchwork.freedesktop.org/api/1.0/series/27856/revisions/1/mbox/ Test kms_cursor_le

Re: [Intel-gfx] [PATCH] drm/i915: Use AUX for backlight only if eDP 1.4 or later

2017-07-25 Thread David Weinehall
On Tue, Jul 25, 2017 at 03:41:46PM +0300, David Weinehall wrote: > On 2017-07-25 02:15, Puthikorn Voravootivat wrote: > > I saw a DP 1.3 panel that advertise AUX backlight brightness control > > but not working properly. So it should work but not in real world. > > I think that is good reason enoug

Re: [Intel-gfx] [PATCH] drm/i915: Enforce that CS packets are qword aligned

2017-07-25 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-07-24 09:06:28) > > > On 21/07/2017 17:11, Chris Wilson wrote: > > We require the caller to ensure that the packets they wish to emit into > > the CS ring are qword aligned (i.e. have an even number of dwords). > > Double check this. > > > > Signed-off-by: Chris Wils

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Fix kbuild error

2017-07-25 Thread Chris Wilson
Quoting Chris Wilson (2017-07-25 13:53:36) > After rebasing af2788925ae0 ("drm/i915: Squelch reset messages during > selftests"), I missed fixing up a call to i915_reset(). s/rebasing/applying patches out of order due to review timing/ > Reported-by: kbuild test robot > Fixes: af2788925ae0 ("drm

[Intel-gfx] [PATCH] drm/i915/selftests: Fix kbuild error

2017-07-25 Thread Chris Wilson
After rebasing af2788925ae0 ("drm/i915: Squelch reset messages during selftests"), I missed fixing up a call to i915_reset(). Reported-by: kbuild test robot Fixes: af2788925ae0 ("drm/i915: Squelch reset messages during selftests") Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/selftests/i

[Intel-gfx] [PATCH i-g-t 2/3] configure.ac: Disable chamelium by default and add enable argument

2017-07-25 Thread Paul Kocialkowski
Since the chamelium is not a very usual piece of hardware and requires pulling-in lots of specific dependencies, it makes sense to keep it disabled by default. An explicit --enable-chamelium argument is provided to enable it when necessary. This also leads to more predictable results than automati

[Intel-gfx] [PATCH i-g-t 1/3] configure.ac: Make udev a dependency for chamelium

2017-07-25 Thread Paul Kocialkowski
Chamelium testing has a hard dependency on udev. This makes this dependency explicit in configure instead of failing the build when it is missing. Signed-off-by: Paul Kocialkowski --- configure.ac | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configure.ac b/configure.ac index dec3e923..

[Intel-gfx] [PATCH i-g-t 3/3] README: Add information about chamelium dependencies

2017-07-25 Thread Paul Kocialkowski
This adds a list of dependencies required to build chamelium support, so that what needs to be installed to get it going is more obvious. As done previously in the file, the list is relevant for Debian and its derivatives but should provide a template for other systems as well. Signed-off-by: Pau

Re: [Intel-gfx] [PATCH] drm/i915: Use AUX for backlight only if eDP 1.4 or later

2017-07-25 Thread David Weinehall
On 2017-07-25 02:15, Puthikorn Voravootivat wrote: I saw a DP 1.3 panel that advertise AUX backlight brightness control but not working properly. So it should work but not in real world. I think that is good reason enough to add this as a heuristic. Either key it on eDP 1.4 and hope that it's

Re: [Intel-gfx] [RFC v3] drm/hdcp: drm enum property for CP State

2017-07-25 Thread Sean Paul
On Mon, Jul 24, 2017 at 2:12 PM, Ramalingam C wrote: > DRM connector property is created to represent the content protection > state of the connector and to configure the same. > > Content protection states defined: > DRM_MODE_CONTENT_PROTECTION_UNSUPPORTED - Unsupported >

[Intel-gfx] [drm-intel:for-linux-next 4/4] drivers/gpu/drm/i915/selftests/intel_hangcheck.c:845:3: error: too few arguments to function 'i915_reset'

2017-07-25 Thread kbuild test robot
tree: git://anongit.freedesktop.org/drm-intel for-linux-next head: af2788925ae0b83737ee847c5b2e9f19c5bf3630 commit: af2788925ae0b83737ee847c5b2e9f19c5bf3630 [4/4] drm/i915: Squelch reset messages during selftests config: i386-randconfig-x013-201730 (attached as .config) compiler: gcc-6 (Debian

Re: [Intel-gfx] [PATCH 1/2] drm/edid: Add helper to detect whether EDID changed

2017-07-25 Thread Paul Kocialkowski
On Tue, 2017-07-25 at 10:16 +0200, Daniel Vetter wrote: > On Tue, Jul 25, 2017 at 10:58:55AM +0300, Paul Kocialkowski wrote: > > On Tue, 2017-07-25 at 09:34 +0200, Daniel Vetter wrote: > > > On Tue, Jul 25, 2017 at 9:25 AM, Paul Kocialkowski > > > wrote: > > > > On Tue, 2017-07-25 at 08:53 +0200,

Re: [Intel-gfx] [PATCH i-g-t] lib/drmtest: Decode driver flags on failure

2017-07-25 Thread Daniel Vetter
On Tue, Jul 25, 2017 at 12:49:11PM +0100, Chris Wilson wrote: > Quoting Daniel Vetter (2017-07-25 12:37:08) > > I spent too much time going wtf why does this test not run until > > realizing that vgem is missing. This should help a lot for tests that > > need multiple different drm drivers. > > >

[Intel-gfx] ✗ Fi.CI.BAT: failure for acquire ctx for everyone! (rev3)

2017-07-25 Thread Patchwork
== Series Details == Series: acquire ctx for everyone! (rev3) URL : https://patchwork.freedesktop.org/series/27835/ State : failure == Summary == CHK include/config/kernel.release CHK include/generated/uapi/linux/version.h CHK include/generated/utsrelease.h CHK include/

[Intel-gfx] [PATCH] drm: Handle properties in the core for atomic drivers

2017-07-25 Thread Daniel Vetter
The reason behind the original indirection through the helper functions was to allow existing drivers to overwrite how they handle properties. For example when a vendor-specific userspace had expectations that didn't match atomic. That seemed likely, since atomic is standardizing a _lot_ more of th

[Intel-gfx] [PATCH] drm: Don't update property values for atomic drivers

2017-07-25 Thread Daniel Vetter
Atomic drivers only use the property value store for immutable (i.e. can't be set by userspace, but the kernel can still adjust it) properties. The only tricky part is the removal of the update in drm_atomic_helper_update_legacy_modeset_state(). This was added in commit 8c10342cb48f3140d9abeadcfd

Re: [Intel-gfx] [PATCH i-g-t] lib/drmtest: Decode driver flags on failure

2017-07-25 Thread Chris Wilson
Quoting Daniel Vetter (2017-07-25 12:37:08) > I spent too much time going wtf why does this test not run until > realizing that vgem is missing. This should help a lot for tests that > need multiple different drm drivers. > > Signed-off-by: Daniel Vetter > --- > lib/drmtest.c | 21 ++

[Intel-gfx] [PATCH i-g-t] lib/drmtest: Decode driver flags on failure

2017-07-25 Thread Daniel Vetter
I spent too much time going wtf why does this test not run until realizing that vgem is missing. This should help a lot for tests that need multiple different drm drivers. Signed-off-by: Daniel Vetter --- lib/drmtest.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-)

Re: [Intel-gfx] [PATCH v7 3/3] drm/i915: Implement I915_PERF_ADD/REMOVE_CONFIG interface

2017-07-25 Thread Datczuk, Andrzej
I think you looked only at the changes prepared previously by Matthew and just ported by me. I made a change on top of it in a third patch to alight the whitelist with MDAPI needs. The change you're looking for is "Subject: [PATCH 3/3] drm/i915: extended oa reg addresses whitelist". To make it

Re: [Intel-gfx] [PATCH 15/20] drm/i915: Don't touch fence->error when resetting an innocent request

2017-07-25 Thread Chris Wilson
Quoting Michel Thierry (2017-07-24 20:32:21) > On 7/24/2017 6:32 AM, Chris Wilson wrote: > > Quoting Chris Wilson (2017-07-21 13:32:33) > >> If the request has been completed before the reset took effect, we don't > >> need to mark it up as being a victim. Touching fence->error after the > >> fence

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915: Add perf property support for context HW id

2017-07-25 Thread Lionel Landwerlin
On 25/07/17 05:26, Zhenyu Wang wrote: On 2017.07.21 14:01:01 +0100, Lionel Landwerlin wrote: I think Chris' comments show this isn't actually tested. It turned out that's true...so currently Pengyuan just tried to filter by exposed vGPU ctx_hw_id with global mode in gputop. Would that be ok wit

Re: [Intel-gfx] [PATCH v7 3/3] drm/i915: Implement I915_PERF_ADD/REMOVE_CONFIG interface

2017-07-25 Thread Lionel Landwerlin
Hi Andrzej, Thanks for the feedback. Can you tell me if that following changes are correct? Cheers, - Lionel On 25/07/17 10:06, Datczuk, Andrzej wrote: Hi Lionel, What about the corrected whitelist I sent you before? Without allowing those registers the patch for MDAPI is basically useles

Re: [Intel-gfx] [PATCH v2 2/7] drm/atomic: Clean up drm_atomic_helper_async_check

2017-07-25 Thread Maarten Lankhorst
Op 25-07-17 om 11:27 schreef Daniel Vetter: > On Tue, Jul 25, 2017 at 11:11 AM, Maarten Lankhorst > wrote: >> Op 25-07-17 om 10:23 schreef Daniel Vetter: >>> On Wed, Jul 19, 2017 at 04:39:15PM +0200, Maarten Lankhorst wrote: /* - * Don't do an async update if there is an outstan

Re: [Intel-gfx] [PATCH 0/4] [v2] Blobifiers (FKA GET_PLANE2)

2017-07-25 Thread Philippe CORNU
On 07/24/2017 05:46 AM, Ben Widawsky wrote: > Second attempt (although most patches are much further along than that) and > the > blob property for modifiers. > > This small series adds the DRM blob property that allows clients to be made > aware of per plane modifiers and the formats which are

Re: [Intel-gfx] [PATCH 7/8] drm: Nuke drm_atomic_helper_connector_dpms

2017-07-25 Thread Philippe CORNU
On 07/25/2017 10:01 AM, Daniel Vetter wrote: > It's dead code, the core handles all this directly now. > > The only special case is nouveau and tda988x which used one function > for both legacy modeset code and -nv50 atomic world instead of 2 > vtables. But amounts to exactly the same. > > v2:

Re: [Intel-gfx] [PATCH 4/8] drm: Nuke drm_atomic_helper_crtc_set_property

2017-07-25 Thread Philippe CORNU
On 07/25/2017 10:01 AM, Daniel Vetter wrote: > It's dead code because this is now handled in the core. > > Signed-off-by: Daniel Vetter > Cc: Boris Brezillon > Cc: Daniel Vetter > Cc: Jani Nikula > Cc: Sean Paul > Cc: David Airlie > Cc: Ben Skeggs > Cc: Tomi Valkeinen > Cc: Laurent Pinch

Re: [Intel-gfx] [PATCH 5/8] drm: Nuke drm_atomic_helper_plane_set_property

2017-07-25 Thread Philippe CORNU
On 07/25/2017 10:01 AM, Daniel Vetter wrote: > It's dead code, the core handles all this directly now. This also > allows us to unexport drm_atomic_helper_plane_set_property. > > Signed-off-by: Daniel Vetter > Cc: Liviu Dudau > Cc: Brian Starkey > Cc: Mali DP Maintainers > Cc: Boris Brezillo

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/gvt: Dma-buf support for GVT-g

2017-07-25 Thread Patchwork
== Series Details == Series: drm/i915/gvt: Dma-buf support for GVT-g URL : https://patchwork.freedesktop.org/series/27844/ State : warning == Summary == Series 27844v1 drm/i915/gvt: Dma-buf support for GVT-g https://patchwork.freedesktop.org/api/1.0/series/27844/revisions/1/mbox/ Test gem_rin

Re: [Intel-gfx] [PATCH 5/8] drm: Nuke drm_atomic_helper_plane_set_property

2017-07-25 Thread Archit Taneja
On 07/25/2017 01:31 PM, Daniel Vetter wrote: It's dead code, the core handles all this directly now. This also allows us to unexport drm_atomic_helper_plane_set_property. Reviewed-by: Archit Taneja Signed-off-by: Daniel Vetter Cc: Liviu Dudau Cc: Brian Starkey Cc: Mali DP Maintainers

Re: [Intel-gfx] [PATCH 4/8] drm: Nuke drm_atomic_helper_crtc_set_property

2017-07-25 Thread Archit Taneja
On 07/25/2017 01:31 PM, Daniel Vetter wrote: It's dead code because this is now handled in the core. Reviewed-by: Archit Taneja Signed-off-by: Daniel Vetter Cc: Boris Brezillon Cc: Daniel Vetter Cc: Jani Nikula Cc: Sean Paul Cc: David Airlie Cc: Ben Skeggs Cc: Tomi Valkeinen Cc: L

[Intel-gfx] [PATCH v13 7/7] drm/i915/gvt: Dmabuf support for GVT-g

2017-07-25 Thread Tina Zhang
This patch introduces a guest's framebuffer sharing mechanism based on dma-buf subsystem. With this sharing mechanism, guest's framebuffer can be shared between guest VM and host. Signed-off-by: Tina Zhang --- drivers/gpu/drm/i915/gvt/Makefile | 2 +- drivers/gpu/drm/i915/gvt/dmabuf.c

Re: [Intel-gfx] [PATCH 3/8] drm: Handle properties in the core for atomic drivers

2017-07-25 Thread Archit Taneja
On 07/25/2017 01:31 PM, Daniel Vetter wrote: The reason behind the original indirection through the helper functions was to allow existing drivers to overwrite how they handle properties. For example when a vendor-specific userspace had expectations that didn't match atomic. That seemed likely,

[Intel-gfx] [PATCH v13 5/7] vfio: ABI for mdev display dma-buf operation

2017-07-25 Thread Tina Zhang
Add VFIO_DEVICE_QUERY_GFX_PLANE ioctl command to let user mode query and get the plan and its related information. The dma-buf's life cycle is handled by user mode and tracked by kernel. The returned fd in struct vfio_device_query_gfx_plane can be a new fd or an old fd of a re-exported dma-buf. Ho

Re: [Intel-gfx] [PATCH 8/8] drm: Nuke drm_atomic_legacy_backoff

2017-07-25 Thread Maarten Lankhorst
Op 25-07-17 om 10:01 schreef Daniel Vetter: > Finally all users are gone! > > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/drm_atomic.c | 32 > include/drm/drm_atomic.h | 2 -- > 2 files changed, 34 deletions(-) > > diff --git a/drivers/gpu/drm/drm_at

[Intel-gfx] [PATCH v13 6/7] drm/i915: Introduce GEM proxy

2017-07-25 Thread Tina Zhang
GEM proxy is a kind of GEM, whose backing physical memory is pinned and produced by guest VM and is used by host as read only. With GEM proxy, host is able to access guest physical memory through GEM object interface. As GEM proxy is such a special kind of GEM, a new flag I915_GEM_OBJECT_IS_PROXY i

[Intel-gfx] [PATCH v13 4/7] drm/i915/gvt: Add opregion support

2017-07-25 Thread Tina Zhang
Windows guest UPT driver can use operegion to configure the setting for display. Without the opregion support, the display registers won't be set and this blocks display model to get the correct information of the guest display plane. Signed-off-by: Bing Niu Signed-off-by: Xiaoguang Chen Signed-

[Intel-gfx] [PATCH v13 3/7] drm/i915/gvt: Add RGB 64-bit 16:16:16:16 float format support

2017-07-25 Thread Tina Zhang
The RGB 64-bit 16:16:16:16 float pixel format is needed by windows 10 guest VM. This patch is to add this pixel format support to gvt device model. Without this patch, some Apps, e.g. "DXGIGammaVM.exe", will crash and make guest screen black. Signed-off-by: Xiaoguang Chen Signed-off-by: Tina Zhan

[Intel-gfx] [PATCH v13 2/7] drm: Introduce RGB 64-bit 16:16:16:16 float format

2017-07-25 Thread Tina Zhang
The RGB 64-bit 16:16:16:16 float pixel format is needed by windows guest VM. This patch is to introduce the format to drm. v1: Suggested by Ville to submit this patch to dri-devel. Signed-off-by: Xiaoguang Chen Signed-off-by: Tina Zhang --- include/uapi/drm/drm_fourcc.h | 4 1 file change

  1   2   >