Re: [Intel-gfx] [PATCH v3 i-g-t] tests/kms: increase max threshold time for edid read

2017-08-10 Thread Lofstedt, Marta
With this tweak the test pass: --- a/tests/kms_sysfs_edid_timing.c +++ b/tests/kms_sysfs_edid_timing.c @@ -99,7 +99,7 @@ int main(int argc, char **argv) edid_size = read(fd_edid, edid, 512); threshold = THRESHOLD_PER_EDID_BLOCK * (edid_size / 128); -

Re: [Intel-gfx] [maintainer-tools PATCH 5/5] doc: use Sphinx bizstyle builtin html theme

2017-08-10 Thread Jani Nikula
On Thu, 10 Aug 2017, Rodrigo Vivi wrote: > On Wed, Aug 9, 2017 at 2:08 PM, Jani Nikula wrote: >> Matter of taste, but looks better than the default alabaster, > > not sure which one I preferred... > alabaster goes better with 01.org... but it indeed is not very good... > >> and is >> less trouble

Re: [Intel-gfx] [PATCH 2/2] drm/i915/perf: Drop lockdep assert for i915_oa_init_reg_state()

2017-08-10 Thread Lionel Landwerlin
On 10/08/17 00:13, Chris Wilson wrote: Quoting Lionel Landwerlin (2017-08-09 23:47:20) On 09/08/17 16:38, Chris Wilson wrote: This is called from execlist context init which we need to be unlocked. Commit f89823c21224 ("drm/i915/perf: Implement I915_PERF_ADD/REMOVE_CONFIG interface") added a lo

Re: [Intel-gfx] [PATCH 2/2] drm/i915/perf: Drop lockdep assert for i915_oa_init_reg_state()

2017-08-10 Thread Lionel Landwerlin
On 10/08/17 00:13, Chris Wilson wrote: Quoting Lionel Landwerlin (2017-08-09 23:47:20) On 09/08/17 16:38, Chris Wilson wrote: This is called from execlist context init which we need to be unlocked. Commit f89823c21224 ("drm/i915/perf: Implement I915_PERF_ADD/REMOVE_CONFIG interface") added a lo

Re: [Intel-gfx] [PATCH i-g-t 1/2] Add support for subtest-specific documentation

2017-08-10 Thread Petri Latvala
On Wed, Aug 09, 2017 at 01:18:55PM -0700, Belgaumkar, Vinay wrote: > > @@ -710,6 +721,8 @@ static int common_init(int *argc, char **argv, > > static struct option long_options[] = { > > {"list-subtests", 0, 0, OPT_LIST_SUBTESTS}, > > {"run-subtest", 1, 0, OPT_RUN_SUBTEST

Re: [Intel-gfx] [RFC i-g-t] tests/gem_exec_basic: Documentation for subtests

2017-08-10 Thread Arkadiusz Hiler
On Wed, Aug 09, 2017 at 10:00:16AM -0700, Belgaumkar, Vinay wrote: > > > On 8/9/2017 7:32 AM, Arkadiusz Hiler wrote: > > On Tue, Aug 08, 2017 at 03:09:00PM -0700, Vinay Belgaumkar wrote: > > > This is an RFC for adding documentation to IGT subtests. Each subtest can > > > have > > > something si

Re: [Intel-gfx] [maintainer-tools PATCH 3/5] doc: use window.onload to call WaveDrom.ProcessAll()

2017-08-10 Thread Jani Nikula
On Thu, 10 Aug 2017, Rodrigo Vivi wrote: > I don't know WaveDrom much... but it works so > > Acked-by: Rodrigo Vivi Thanks, pushed the first three. BR, Jani. > > On Wed, Aug 9, 2017 at 2:08 PM, Jani Nikula wrote: >> Simplify the build by doing the WaveDrom processing from the rst file >> (alb

[Intel-gfx] [PATCH i-g-t 1/5] Add support for subtest-specific documentation

2017-08-10 Thread Petri Latvala
The current documentation for tests is limited to a single string per test binary. This patch adds support for documenting individual subtests. The syntax for subtest documentation is: igt_document_subtest("Frob knobs to see if one of the " "crossbeams will go out of sk

[Intel-gfx] [PATCH i-g-t 2/5] README: Describe the subtest documentation command line flags

2017-08-10 Thread Petri Latvala
Signed-off-by: Petri Latvala --- README | 5 + 1 file changed, 5 insertions(+) diff --git a/README b/README index d1ea952..5b6cb00 100644 --- a/README +++ b/README @@ -32,6 +32,11 @@ tests/ be run. Some tests have futher options and these are detailed by using the --help opti

[Intel-gfx] [PATCH i-g-t v3 0/5] Subtest documentation

2017-08-10 Thread Petri Latvala
New ever-growing series with some fixes and additions. Petri Latvala (5): Add support for subtest-specific documentation README: Describe the subtest documentation command line flags docs: Include subtest documentation testdisplay: Handle subtest documentation flags igt_command_line.sh:

[Intel-gfx] [PATCH i-g-t 4/5] testdisplay: Handle subtest documentation flags

2017-08-10 Thread Petri Latvala
testdisplay has no subtests so hook them to existing subtest handling. Signed-off-by: Petri Latvala --- TODO: Make testdisplay use igt_simple_init_parse_opts... tests/testdisplay.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/testdisplay.c b/tests/testdisplay.c index f2a41fa..85

[Intel-gfx] [PATCH i-g-t 5/5] igt_command_line.sh: Test subtest documentation flag handling

2017-08-10 Thread Petri Latvala
Signed-off-by: Petri Latvala --- tests/igt_command_line.sh | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/tests/igt_command_line.sh b/tests/igt_command_line.sh index 7f80fc8..b3a794c 100755 --- a/tests/igt_command_line.sh +++ b/tests/igt_command_line.sh @@ -102,7

[Intel-gfx] [PATCH i-g-t 3/5] docs: Include subtest documentation

2017-08-10 Thread Petri Latvala
A simple and naive format: Double newline denotes paragraph change, otherwise insert subtest documentation into the generated docs as-is. Signed-off-by: Petri Latvala --- Still not sure whether inside is kosher. docs/reference/intel-gpu-tools/Makefile.am | 6 ++ 1 file changed, 6 inserti

Re: [Intel-gfx] [PATCH 8/8] drm/i915/skl+: debugfs entry to control IPC

2017-08-10 Thread Mahesh Kumar
Hi, On Wednesday 09 August 2017 03:16 PM, Maarten Lankhorst wrote: Op 18-07-17 om 14:49 schreef Mahesh Kumar: From: "Kumar, Mahesh" This patch creates an entry in debugfs to check the status of IPC. This can also be used to enable/disable IPC in supported platforms. Signed-off-by: Mahesh Ku

Re: [Intel-gfx] [PATCH libdrm] drm: Remove create_handle() drm_framebuffer "virtual".

2017-08-10 Thread Daniel Vetter
On Wed, Aug 09, 2017 at 04:13:05PM -0700, Joe Kniss wrote: > On Wed, Aug 9, 2017 at 12:14 PM, Noralf Trønnes wrote: > > > > Den 09.08.2017 01.42, skrev Joe Kniss: > >> > >> Because all drivers currently use gem objects for framebuffer planes, > >> the virtual create_handle() is not required. This

[Intel-gfx] ✗ Fi.CI.BAT: failure for Subtest documentation

2017-08-10 Thread Patchwork
== Series Details == Series: Subtest documentation URL : https://patchwork.freedesktop.org/series/28605/ State : failure == Summary == IGT patchset tested on top of latest successful build c129026622accef6f54c0cfb0dc55e930cfa60b5 igt: add syncobj_basic. with latest DRM-Tip kernel build CI_DRM

Re: [Intel-gfx] [PATCH i-g-t 4/4] tests/syncobj: Add some wait and reset tests (v5)

2017-08-10 Thread Chris Wilson
Quoting Jason Ekstrand (2017-08-10 06:35:43) > +igt_main > +{ > + int fd; > + > + igt_fixture { > + fd = drm_open_driver(DRIVER_ANY); DRIVER_ANY | DRIVER_VGEM (ANY really means KMS) > + igt_require(has_syncobj_wait(fd)); > + igt_require_sw_sy

Re: [Intel-gfx] [PATCH 8/8] drm/i915/skl+: debugfs entry to control IPC

2017-08-10 Thread Maarten Lankhorst
Op 10-08-17 om 10:56 schreef Mahesh Kumar: > Hi, > > > On Wednesday 09 August 2017 03:16 PM, Maarten Lankhorst wrote: >> Op 18-07-17 om 14:49 schreef Mahesh Kumar: >>> From: "Kumar, Mahesh" >>> >>> This patch creates an entry in debugfs to check the status of IPC. >>> This can also be used to enab

Re: [Intel-gfx] [PATCH 6/8] dmi: Move memdev_dmi_entry definition to dmi.h (v2)

2017-08-10 Thread Jean Delvare
On mer., 2017-08-09 at 09:18 -0700, Matt Roper wrote: > On Mon, Jul 31, 2017 at 10:36:05AM +0200, Jean Delvare wrote: > > > > Hi Matt, Mauro, > > > > On Thu, 17 Mar 2016 15:18:20 +0100, Jean Delvare wrote: > > > > > > On Tue, 8 Mar 2016 10:32:37 -0800, Matt Roper wrote: > > > > > > > > A coupl

[Intel-gfx] [PATCH] drm/i915: Add SW_SYNC to our recommend testing Kconfig

2017-08-10 Thread Chris Wilson
Since we do use the SW_SYNC in igt for validating dma-fence and sync_file, and wish to expand usage to cover driver independent portions of syncobj interaction, ensure SW_SYNC is included in our testing Kconfig. Signed-off-by: Chris Wilson Cc: Jason Ekstrand Cc: Joonas Lahtinen --- drivers/gpu

Re: [Intel-gfx] [PATCH i-g-t 4/4] tests/syncobj: Add some wait and reset tests (v5)

2017-08-10 Thread Chris Wilson
Quoting Jason Ekstrand (2017-08-10 06:35:43) > This adds both trivial error-checking tests as well as more complex > tests which actually test whether or not waits do what they're supposed > to do. They only currently work on i915 but it should be simple to hook > them up for other drivers by simp

Re: [Intel-gfx] [PATCH i-g-t 4/4] tests/syncobj: Add some wait and reset tests (v5)

2017-08-10 Thread Chris Wilson
Quoting Jason Ekstrand (2017-08-10 06:35:43) > +static void > +test_single_wait(int fd, uint32_t test_flags, int expect) > +{ > + uint32_t syncobj = syncobj_create(fd); > + uint32_t flags = 0; > + int timeline; > + > + if (test_flags & WAIT_FOR_SUBMIT) > + flag

[Intel-gfx] [maintainer-tools PATCH v2 1/4] doc: load WaveDrom scripts directly from CDN instead of bundling

2017-08-10 Thread Jani Nikula
Way back when the WaveDrom stuff was added, the scripts could only be accessed over http. This caused issues with sites served over https and modern browsers rightly complaining about mixed content. This was worked around by downloading the WaveDrom scripts over http at build time, and bundling the

[Intel-gfx] [maintainer-tools PATCH v2 4/4] doc: build documentation using Sphinx

2017-08-10 Thread Jani Nikula
Based on Sphinx-quickstart, with existing and generated Makefiles merged together. This makes the rst2html and Sphinx builds work side by side. Plain 'make' continues to use rst2html, and 'make html' and friends use Sphinx. The intention is to keep both for a transition period so that we can have

[Intel-gfx] [maintainer-tools PATCH v2 0/4] add Sphinx doc build to maintainer tools

2017-08-10 Thread Jani Nikula
v2 of [1], with sphinx_rtd_theme and some tweaks to make it nicer. BR, Jani. [1] cover.1502312576.git.jani.nikula@intel.com">http://mid.mail-archive.com/cover.1502312576.git.jani.nikula@intel.com Jani Nikula (4): doc: load WaveDrom scripts directly from CDN instead of bundling doc: provide

[Intel-gfx] [maintainer-tools PATCH v2 3/4] doc: include .svg using the image directive, not raw html

2017-08-10 Thread Jani Nikula
I have no idea what I was thinking when I added them as raw html. Using the image directive should allow browsers to handle the page layout better. Signed-off-by: Jani Nikula --- drm-intel.rst | 4 +--- drm-misc.rst | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drm-in

[Intel-gfx] [maintainer-tools PATCH v2 2/4] doc: provide scrollbars for overflowing wavedrom timeline content

2017-08-10 Thread Jani Nikula
Wrap wavedrom timelines in (idea copied from the wavedrom sphinx extension) to provide scrollbars for overflowing content. This is useful even with rst2html. Signed-off-by: Jani Nikula --- drm-intel-timeline.rst | 2 ++ drm-misc-timeline.rst | 2 ++ 2 files changed, 4 insertions(+) diff --git

[Intel-gfx] [PATCH] drm/i915: Keep IPS disabled during CRC collection

2017-08-10 Thread Maarten Lankhorst
We need to look at crtc->state->active for the legacy crc to match the drm crc api. Even though the drm api explictily checks it, there's no harm in doing the same there so keep it for both. Introduce a intel_crtc->ips_disabled flag for CRC, which is protected by crtc->mutex and set it to true whi

Re: [Intel-gfx] [maintainer-tools PATCH v2 0/4] add Sphinx doc build to maintainer tools

2017-08-10 Thread Jani Nikula
On Thu, 10 Aug 2017, Jani Nikula wrote: > v2 of [1], with sphinx_rtd_theme and some tweaks to make it nicer. And sample output at https://people.freedesktop.org/~jani/html/ J. > > BR, > Jani. > > > [1] cover.1502312576.git.jani.nikula@intel.com">http://mid.mail-archive.com/cover.1502312576.git.

Re: [Intel-gfx] [PATCH 1/3] drm/i915/cnl: Add allowed DP rates for Cannonlake.

2017-08-10 Thread Mika Kahola
On Thu, 2017-07-06 at 13:54 -0700, Rodrigo Vivi wrote: > One warning is that in order to get DPLL Link rates > 3240 and 4050 that allows 648000 and 81 is that: > "Some SKUs may require elevated I/O voltage to support > this." I also found a mention in BSpec  "Frequencies over 5.4 GHz only supp

[Intel-gfx] [PATCH i-g-t 4/5] testdisplay: Handle subtest documentation flags

2017-08-10 Thread Petri Latvala
testdisplay has no subtests so hook them to existing subtest handling. Signed-off-by: Petri Latvala --- tests/testdisplay.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/testdisplay.c b/tests/testdisplay.c index f2a41fa..85b118f 100644 --- a/tests/testdisplay.c +++ b/tests/testdisp

[Intel-gfx] [PATCH i-g-t 5/5] igt_command_line.sh: Test subtest documentation flag handling

2017-08-10 Thread Petri Latvala
Signed-off-by: Petri Latvala --- tests/igt_command_line.sh | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/tests/igt_command_line.sh b/tests/igt_command_line.sh index 7f80fc8..b3a794c 100755 --- a/tests/igt_command_line.sh +++ b/tests/igt_command_line.sh @@ -102,7

[Intel-gfx] [PATCH i-g-t v4 0/5] Subtest documentation

2017-08-10 Thread Petri Latvala
Changes: 1/5 Fix a brainfart that I thought I tested for. Thanks, CI! Petri Latvala (5): Add support for subtest-specific documentation README: Describe the subtest documentation command line flags docs: Include subtest documentation testdisplay: Handle subtest documentation flags igt_

[Intel-gfx] [PATCH i-g-t 2/5] README: Describe the subtest documentation command line flags

2017-08-10 Thread Petri Latvala
Signed-off-by: Petri Latvala --- README | 5 + 1 file changed, 5 insertions(+) diff --git a/README b/README index d1ea952..5b6cb00 100644 --- a/README +++ b/README @@ -32,6 +32,11 @@ tests/ be run. Some tests have futher options and these are detailed by using the --help opti

[Intel-gfx] [PATCH i-g-t 1/5] Add support for subtest-specific documentation

2017-08-10 Thread Petri Latvala
The current documentation for tests is limited to a single string per test binary. This patch adds support for documenting individual subtests. The syntax for subtest documentation is: igt_document_subtest("Frob knobs to see if one of the " "crossbeams will go out of sk

[Intel-gfx] [PATCH i-g-t 3/5] docs: Include subtest documentation

2017-08-10 Thread Petri Latvala
A simple and naive format: Double newline denotes paragraph change, otherwise insert subtest documentation into the generated docs as-is. Signed-off-by: Petri Latvala --- docs/reference/intel-gpu-tools/Makefile.am | 6 ++ 1 file changed, 6 insertions(+) diff --git a/docs/reference/intel-gpu

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add SW_SYNC to our recommend testing Kconfig

2017-08-10 Thread Patchwork
== Series Details == Series: drm/i915: Add SW_SYNC to our recommend testing Kconfig URL : https://patchwork.freedesktop.org/series/28608/ State : success == Summary == Series 28608v1 drm/i915: Add SW_SYNC to our recommend testing Kconfig https://patchwork.freedesktop.org/api/1.0/series/28608/r

[Intel-gfx] ✓ Fi.CI.BAT: success for Subtest documentation (rev2)

2017-08-10 Thread Patchwork
== Series Details == Series: Subtest documentation (rev2) URL : https://patchwork.freedesktop.org/series/28605/ State : success == Summary == IGT patchset tested on top of latest successful build c129026622accef6f54c0cfb0dc55e930cfa60b5 igt: add syncobj_basic. with latest DRM-Tip kernel build

[Intel-gfx] [PATCH] drm/i915/gen9: Send all components in VF state

2017-08-10 Thread Mika Kuoppala
Update gen9 renderstate to account the, long overdue, changes for igt commit 5c07135b7bd2 ("tools/null_state/gen9: Send all components in VF state"). Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/intel_renderstate_gen9.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --g

Re: [Intel-gfx] [PATCH 2/2] drm/i915/perf: Drop lockdep assert for i915_oa_init_reg_state()

2017-08-10 Thread Chris Wilson
Quoting Lionel Landwerlin (2017-08-10 08:23:20) > On 10/08/17 00:13, Chris Wilson wrote: > > Quoting Lionel Landwerlin (2017-08-09 23:47:20) > >> On 09/08/17 16:38, Chris Wilson wrote: > >>> This is called from execlist context init which we need to be unlocked. > >>> Commit f89823c21224 ("drm/i915

Re: [Intel-gfx] [PATCH] drm/i915: Supply the engine-id for our mock_engine()

2017-08-10 Thread Mika Kuoppala
Chris Wilson writes: > In the initial selftest, we didn't care what the engine->id was, just > that it could uniquely identify it. Later though, we started tracking in > the fixed size arrays around the drm_i915_private and so we now require > it to be appropriate. This becomes an issue when usin

Re: [Intel-gfx] [PATCH] drm/i915: Supply the engine-id for our mock_engine()

2017-08-10 Thread Chris Wilson
Quoting Mika Kuoppala (2017-08-10 12:13:14) > Chris Wilson writes: > > > In the initial selftest, we didn't care what the engine->id was, just > > that it could uniquely identify it. Later though, we started tracking in > > the fixed size arrays around the drm_i915_private and so we now require >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gen9: Send all components in VF state

2017-08-10 Thread Patchwork
== Series Details == Series: drm/i915/gen9: Send all components in VF state URL : https://patchwork.freedesktop.org/series/28619/ State : success == Summary == Series 28619v1 drm/i915/gen9: Send all components in VF state https://patchwork.freedesktop.org/api/1.0/series/28619/revisions/1/mbox/

Re: [Intel-gfx] [PATCH] drm/i915: Add SW_SYNC to our recommend testing Kconfig

2017-08-10 Thread Joonas Lahtinen
On to, 2017-08-10 at 10:40 +0100, Chris Wilson wrote: > Since we do use the SW_SYNC in igt for validating dma-fence and > sync_file, and wish to expand usage to cover driver independent portions > of syncobj interaction, ensure SW_SYNC is included in our testing > Kconfig. > > Signed-off-by: Chris

Re: [Intel-gfx] [PATCH] drm/i915/cnl: Add slice and subslice information to debugfs.

2017-08-10 Thread Joonas Lahtinen
On ke, 2017-08-09 at 13:07 -0700, Rodrigo Vivi wrote: > A missing part to EU slice power gating is the > debugfs interface. This patch actually should have been > squashed to the initial EU slice power gating one. > > v2: Initial patch was merged without this part. > > Fixes: c7ae7e9ab207 ("drm/i

Re: [Intel-gfx] [PATCH 2/3] drm/i915/cnl: Dump the right pll registers when dumping pipe config.

2017-08-10 Thread Mika Kahola
On Thu, 2017-07-06 at 13:54 -0700, Rodrigo Vivi wrote: > Different from SKL we don't need ctrl1 and cfgcr2, but > we need to dump cfgcr0 amd cfgcr1 instead. With minor typo fixed in commit message, this is Reviewed-by: Mika Kahola > > v2: rebase and commit message > > Cc: Clint Taylor > Cc:

Re: [Intel-gfx] [PATCH] drm/i915: Keep IPS disabled during CRC collection

2017-08-10 Thread Lofstedt, Marta
Tested-by: Marta Lofstedt > -Original Message- > From: Maarten Lankhorst [mailto:maarten.lankho...@linux.intel.com] > Sent: Thursday, August 10, 2017 12:55 PM > To: intel-gfx@lists.freedesktop.org > Cc: Lofstedt, Marta ; Maarten Lankhorst > > Subject: [PATCH] drm/i915: Keep IPS disabled

[Intel-gfx] [PATCH v2 00/29] DRM API Conversions

2017-08-10 Thread Cihangir Akturk
Changes since v1: - This time patches were generated with coccinelle instead of my own script, as suggested by Daniel Vetter. - Fixed the typo in commit messages. s/adn/and Note: I've included r-b, a-b tags, as these patches are identical to v1 except for the file: drivers/gpu/drm/i915/i915_gem

[Intel-gfx] [PATCH v2 12/29] drm/i915: switch to drm_*_get(), drm_*_put() helpers

2017-08-10 Thread Cihangir Akturk
Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference() and drm_*_unreference() helpers. drm_*_reference() and drm_*_unreference() functions are just compatibility alias for drm_*_get() and drm_*_put() and should not be used by new code. So convert all users of compatibility functions

[Intel-gfx] [PATCH v2 0/3] drm/i915: add register macro definition style guide

2017-08-10 Thread Jani Nikula
This is v2 of [1], with minor tweaks and bolting the document into the Sphinx build. BR, Jani. [1] http://patchwork.freedesktop.org/patch/msgid/20170804103836.17629-1-jani.nik...@intel.com Jani Nikula (3): Documentation/i915: remove sphinx conversion artefact drm/i915: enum i915_power_wel

[Intel-gfx] [PATCH v2 1/3] Documentation/i915: remove sphinx conversion artefact

2017-08-10 Thread Jani Nikula
Remove old warning about docproc directive that's not supported in the Sphinx toolchain. Signed-off-by: Jani Nikula --- Documentation/gpu/i915.rst | 2 -- 1 file changed, 2 deletions(-) diff --git a/Documentation/gpu/i915.rst b/Documentation/gpu/i915.rst index 46875c2bcc31..32c32b89e2e5 100644

[Intel-gfx] [PATCH v2 3/3] drm/i915: add register macro definition style guide

2017-08-10 Thread Jani Nikula
This is not to try to force a new style; this is my interpretation of what the most common existing style is. With hopes I don't need to answer so many questions about style going forward. Start a new style section in the i915 document to bolt the register style guide into. v2: vertical alignmen

[Intel-gfx] [PATCH v2 2/3] drm/i915: enum i915_power_well_id is not proper kernel-doc

2017-08-10 Thread Jani Nikula
Revert to a normal comment, as the enum isn't properly documented anyway. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_reg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 56df86ef5a4d..3b42b

[Intel-gfx] [PATCH i-g-t] tests/kms_mmap_write_crc: Add drmModeDirtyFB after dirtying fb

2017-08-10 Thread Maarten Lankhorst
The test shows the need for coherency through the dma-buf sync ioctl's, but forgets to call dirtyfb, without this the FB Is never updated and we will fail anyway. Solve this by adding a drmModeDirtyFB, I've confirmed by adding -n that the test will still faill without prime_sync_end anyway, so the

Re: [Intel-gfx] [PATCH 6/6] drm/i915/cnl: Reuse skl_wm_get_hw_state on Cannonlake.

2017-08-10 Thread Maarten Lankhorst
Op 09-08-17 om 22:52 schreef Rodrigo Vivi: > Otherwise it reuses the ilk that has a completely different > wm. > > Cc: Mahesh Kumar > Cc: Maarten Lankhorst > Cc: Paulo Zanoni > Signed-off-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/intel_display.c | 2 +- > 1 file changed, 1 insertion(+), 1

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: add register macro definition style guide (rev2)

2017-08-10 Thread Patchwork
== Series Details == Series: drm/i915: add register macro definition style guide (rev2) URL : https://patchwork.freedesktop.org/series/28370/ State : failure == Summary == Series 28370v2 drm/i915: add register macro definition style guide https://patchwork.freedesktop.org/api/1.0/series/28370/

[Intel-gfx] [PATCH i-g-t] pm_rps: Extended testcases with checking PMINTRMSK register value

2017-08-10 Thread Katarzyna Dec
In addition to checking whether the frequency is in correct range for certain scenario, we can also verify whether PM interrupts are masked correctly. Few test cases were extended with such checks. While I'm here, let'a apply some minor coding style cleanup to the rest of the code. We can also beco

[Intel-gfx] ✗ Fi.CI.BAT: warning for tests/kms_mmap_write_crc: Add drmModeDirtyFB after dirtying fb

2017-08-10 Thread Patchwork
== Series Details == Series: tests/kms_mmap_write_crc: Add drmModeDirtyFB after dirtying fb URL : https://patchwork.freedesktop.org/series/28624/ State : warning == Summary == IGT patchset tested on top of latest successful build c129026622accef6f54c0cfb0dc55e930cfa60b5 igt: add syncobj_basic.

Re: [Intel-gfx] [PATCH v6] drm/i915/edp: Allow alternate fixed mode for eDP if available.

2017-08-10 Thread Jani Nikula
On Wed, 09 Aug 2017, Jim Bride wrote: > Some fixed resolution panels actually support more than one mode, > with the only thing different being the refresh rate. Having this > alternate mode available to us is desirable, because it allows us to > test PSR on panels whose setup time at the preferr

Re: [Intel-gfx] [PATCH i-g-t 05/11] tests/perf: rework oa-exponent test

2017-08-10 Thread Matthew Auld
On 4 August 2017 at 12:20, Lionel Landwerlin wrote: > New issues that were discovered while making the tests work on Gen8+ : > > - we need to measure timings between periodic reports and discard all >other kind of reports > > - it seems periodicity of the reports can be affected outside of R

Re: [Intel-gfx] [PATCH i-g-t] pm_rps: Extended testcases with checking PMINTRMSK register value

2017-08-10 Thread Chris Wilson
Quoting Katarzyna Dec (2017-08-10 14:06:15) > In addition to checking whether the frequency is in correct range > for certain scenario, we can also verify whether PM interrupts are > masked correctly. What does correctly mean? It was a recommendation not a requirement. You are checking internal k

Re: [Intel-gfx] [PATCH i-g-t 08/11] tests/perf: load gt_boost_freq_mhz as max gt frequency

2017-08-10 Thread Szwichtenberg, Radoslaw
On Fri, 2017-08-04 at 12:20 +0100, Lionel Landwerlin wrote: > We want the absolute max the hardware can do, not the max value > set by a previous application/user. > > Signed-off-by: Lionel Landwerlin > --- >  tests/perf.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/

[Intel-gfx] ✗ Fi.CI.BAT: failure for pm_rps: Extended testcases with checking PMINTRMSK register value

2017-08-10 Thread Patchwork
== Series Details == Series: pm_rps: Extended testcases with checking PMINTRMSK register value URL : https://patchwork.freedesktop.org/series/28625/ State : failure == Summary == IGT patchset tested on top of latest successful build c129026622accef6f54c0cfb0dc55e930cfa60b5 igt: add syncobj_bas

[Intel-gfx] [maintainer-tools PATCH 0/4] dim: shellcheck fixes

2017-08-10 Thread Jani Nikula
Thou shalt not push dim patches before passing 'make check'. Cc: Daniel Vetter Cc: Maarten Lankhorst Cc: Benjamin Gaignard Jani Nikula (4): dim: Fix shellcheck SC1083 dim: Fix shellcheck SC2162 and SC2166 dim: Fix shellcheck SC2153 dim: Fix shellcheck SC2053 dim | 16 +--

[Intel-gfx] [maintainer-tools PATCH 2/4] dim: Fix shellcheck SC2162 and SC2166

2017-08-10 Thread Jani Nikula
Fixes: 809748225c4e ("dim: Add add-missing-cc command") Cc: Maarten Lankhorst Signed-off-by: Jani Nikula --- dim | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/dim b/dim index 28a137221535..070b199c699b 100755 --- a/dim +++ b/dim @@ -1959,7 +1959,9 @@ function dim

[Intel-gfx] [maintainer-tools PATCH 3/4] dim: Fix shellcheck SC2153

2017-08-10 Thread Jani Nikula
The fix is a bit artificial, but mute the warning. Fixes: 809748225c4e ("dim: Add add-missing-cc command") Cc: Maarten Lankhorst Signed-off-by: Jani Nikula --- dim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dim b/dim index 070b199c699b..f614533c5b09 100755 --- a/dim +++

[Intel-gfx] [maintainer-tools PATCH 1/4] dim: Fix shellcheck SC1083

2017-08-10 Thread Jani Nikula
Fixes: 7968b1c836f6 ("dim: Enforce review requirements") Cc: Daniel Vetter Signed-off-by: Jani Nikula --- dim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dim b/dim index f576fca0488a..28a137221535 100755 --- a/dim +++ b/dim @@ -707,7 +707,7 @@ function dim_push_branch

[Intel-gfx] [maintainer-tools PATCH 4/4] dim: Fix shellcheck SC2053

2017-08-10 Thread Jani Nikula
Fixes: 3cb0514bf1ca ("dim: add checks for author and committer sign-off-by") Cc: Benjamin Gaignard Cc: Daniel Vetter Signed-off-by: Jani Nikula --- dim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dim b/dim index f614533c5b09..2b377cb3a3f3 100755 --- a/dim +++ b/dim @@ -6

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_mmap_write_crc: Add drmModeDirtyFB after dirtying fb

2017-08-10 Thread Chris Wilson
Quoting Maarten Lankhorst (2017-08-10 13:41:56) > The test shows the need for coherency through the dma-buf sync ioctl's, > but forgets to call dirtyfb, without this the FB Is never updated and we > will fail anyway. > > Solve this by adding a drmModeDirtyFB, I've confirmed by adding -n > that the

[Intel-gfx] [PATCH] drm/i915: Avoid null dereference if mst_port is unset.

2017-08-10 Thread Rodrigo Vivi
I'm not sure if this is really the case and I don't believe this is the real fix for the bug mentioned here, but since I don't see a reliable path when mst_port is set and when mode_valid is requested I believe it is worth to have this protection here. Bugzilla: https://bugs.freedesktop.org/show_b

Re: [Intel-gfx] [PATCH] drm/i915/vbt: Assume port A is connected to eDP when there's no VBT

2017-08-10 Thread Jani Nikula
On Thu, 10 Aug 2017, rodrigo.v...@gmail.com wrote: >> On Aug 9, 2017, at 8:20 PM, Dhinakaran Pandiyan wrote: >> >> We currently assume port A is connected to a DP sink when VBT is absent, >> instead assume it is connected to an eDP sink, which seems like a more >> common configuration. Although I

Re: [Intel-gfx] [PATCH] drm/i915/vbt: Assume port A is connected to eDP when there's no VBT

2017-08-10 Thread Jani Nikula
On Thu, 10 Aug 2017, "Navare, Manasi D" wrote: > We currently assume port A is connected to a DP sink when VBT is absent, > instead assume it is connected to an eDP sink, which seems like a more common > configuration. Although I don't have data to back this up, it is still just > as valid as a

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Avoid null dereference if mst_port is unset.

2017-08-10 Thread Patchwork
== Series Details == Series: drm/i915: Avoid null dereference if mst_port is unset. URL : https://patchwork.freedesktop.org/series/28633/ State : success == Summary == Series 28633v1 drm/i915: Avoid null dereference if mst_port is unset. https://patchwork.freedesktop.org/api/1.0/series/28633/r

Re: [Intel-gfx] [maintainer-tools PATCH 5/5] doc: use Sphinx bizstyle builtin html theme

2017-08-10 Thread Rodrigo Vivi
On Thu, Aug 10, 2017 at 12:22 AM, Jani Nikula wrote: > On Thu, 10 Aug 2017, Rodrigo Vivi wrote: >> On Wed, Aug 9, 2017 at 2:08 PM, Jani Nikula wrote: >>> Matter of taste, but looks better than the default alabaster, >> >> not sure which one I preferred... >> alabaster goes better with 01.org...

Re: [Intel-gfx] [maintainer-tools PATCH v2 3/4] doc: include .svg using the image directive, not raw html

2017-08-10 Thread Rodrigo Vivi
It is indeed much better. Reviewed-by: Rodrigo Vivi On Thu, Aug 10, 2017 at 2:39 AM, Jani Nikula wrote: > I have no idea what I was thinking when I added them as raw html. Using > the image directive should allow browsers to handle the page layout > better. > > Signed-off-by: Jani Nikula > ---

Re: [Intel-gfx] [PATCH v2 2/3] drm/i915: enum i915_power_well_id is not proper kernel-doc

2017-08-10 Thread Rodrigo Vivi
On Thu, Aug 10, 2017 at 5:29 AM, Jani Nikula wrote: > Revert to a normal comment, as the enum isn't properly documented > anyway. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/i915_reg.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i

Re: [Intel-gfx] [PATCH v2 1/3] Documentation/i915: remove sphinx conversion artefact

2017-08-10 Thread Rodrigo Vivi
On Thu, Aug 10, 2017 at 5:29 AM, Jani Nikula wrote: > Remove old warning about docproc directive that's not supported in the > Sphinx toolchain. I got confused... the warning is not supported by sphinx or docproc? > > Signed-off-by: Jani Nikula > --- > Documentation/gpu/i915.rst | 2 -- > 1 fi

Re: [Intel-gfx] [PATCH i-g-t 4/4] tests/syncobj: Add some wait and reset tests (v5)

2017-08-10 Thread Jason Ekstrand
On Thu, Aug 10, 2017 at 2:40 AM, Chris Wilson wrote: > Quoting Jason Ekstrand (2017-08-10 06:35:43) > > This adds both trivial error-checking tests as well as more complex > > tests which actually test whether or not waits do what they're supposed > > to do. They only currently work on i915 but

Re: [Intel-gfx] [PATCH] drm/i915/vbt: Assume port A is connected to eDP when there's no VBT

2017-08-10 Thread Manasi Navare
On Thu, Aug 10, 2017 at 05:56:52PM +0300, Jani Nikula wrote: > On Thu, 10 Aug 2017, "Navare, Manasi D" wrote: > > We currently assume port A is connected to a DP sink when VBT is absent, > > instead assume it is connected to an eDP sink, which seems like a more > > common configuration. Although

Re: [Intel-gfx] [PATCH i-g-t 07/11] tests/perf: make buffer-fill more reliable

2017-08-10 Thread Matthew Auld
On 4 August 2017 at 12:20, Lionel Landwerlin wrote: > Filling rate of the buffer must discard context switch reports as they > do not depend upon the periodicity, instead they're a factor on the > amount of different applications concurrently running on the system. > > Signed-off-by: Lionel Landwe

Re: [Intel-gfx] [PATCH v2 1/3] Documentation/i915: remove sphinx conversion artefact

2017-08-10 Thread Jani Nikula
On Thu, 10 Aug 2017, Rodrigo Vivi wrote: > On Thu, Aug 10, 2017 at 5:29 AM, Jani Nikula wrote: >> Remove old warning about docproc directive that's not supported in the >> Sphinx toolchain. > > I got confused... the warning is not supported by sphinx or docproc? There used to be a docproc direct

[Intel-gfx] [PATCH] drm/i915: Split obj->cache_coherent to track r/w

2017-08-10 Thread Chris Wilson
Another month, another story in the cache coherency saga. This time, we come to the realisation that i915_gem_object_is_coherent() has been reporting whether we can read from the target without requiring a cache invalidate; but we were using it in places for testing whether we could write into the

Re: [Intel-gfx] [PATCH 06/16] drm/i915: Move dev_priv->mm.[un]bound_list to its own lock

2017-08-10 Thread Joonas Lahtinen
On ke, 2017-07-26 at 14:26 +0100, Chris Wilson wrote: > Remove the struct_mutex requirement around dev_priv->mm.bound_list and > dev_priv->mm.unbound_list by giving it its own spinlock. This reduces > one more requirement for struct_mutex and in the process gives us > slightly more accurate unbound

Re: [Intel-gfx] [PATCH] drm/i915: Avoid null dereference if mst_port is unset.

2017-08-10 Thread Chris Wilson
Quoting Rodrigo Vivi (2017-08-10 15:50:43) > I'm not sure if this is really the case and I don't believe > this is the real fix for the bug mentioned here, but since > I don't see a reliable path when mst_port is set and when > mode_valid is requested I believe it is worth to have this > protection

Re: [Intel-gfx] [PATCH i-g-t 10/11] tests/perf: add Kabylake support

2017-08-10 Thread Matthew Auld
On 4 August 2017 at 12:20, Lionel Landwerlin wrote: > Signed-off-by: Lionel Landwerlin Reviewed-by: Matthew Auld ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 05/16] drm/i915: Refactor testing obj->mm.pages

2017-08-10 Thread Joonas Lahtinen
On ke, 2017-07-26 at 14:25 +0100, Chris Wilson wrote: > Since we occasionally stuff an error pointer into obj->mm.pages for a > semi-permanent or even permanent failure, we have to be more careful and > not just test against NULL when deciding if the object has a complete > set of its concurrent pa

[Intel-gfx] [PATCH i-g-t] tests/igt_command_line: Ignore subtest list for kms_ccs

2017-08-10 Thread Arkadiusz Hiler
Temporary workaround for "make check" to pass despite the issue with kms_ccs which do not list any subtests, even though it should. TO BE REVERTED by Daniel Stone Cc: Daniel Stone Cc: Daniel Vetter Signed-off-by: Arkadiusz Hiler --- tests/igt_command_line.sh | 5 - 1 file changed, 4 inser

Re: [Intel-gfx] [PATCH i-g-t 11/11] tests/perf: add Geminilake support

2017-08-10 Thread Matthew Auld
On 4 August 2017 at 12:20, Lionel Landwerlin wrote: > Signed-off-by: Lionel Landwerlin Reviewed-by: Matthew Auld ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v3 i-g-t] tests/kms: increase max threshold time for edid read

2017-08-10 Thread Clint Taylor
On 08/10/2017 12:00 AM, Lofstedt, Marta wrote: With this tweak the test pass: --- a/tests/kms_sysfs_edid_timing.c +++ b/tests/kms_sysfs_edid_timing.c @@ -99,7 +99,7 @@ int main(int argc, char **argv) edid_size = read(fd_edid, edid, 512); threshold = THRESHO

Re: [Intel-gfx] [maintainer-tools PATCH v2 2/4] doc: provide scrollbars for overflowing wavedrom timeline content

2017-08-10 Thread Sean Paul
On Thu, Aug 10, 2017 at 5:39 AM, Jani Nikula wrote: > Wrap wavedrom timelines in (idea copied > from the wavedrom sphinx extension) to provide scrollbars for > overflowing content. This is useful even with rst2html. > > Signed-off-by: Jani Nikula Reviewed-by: Sean Paul > --- > drm-intel-tim

Re: [Intel-gfx] [maintainer-tools PATCH v2 3/4] doc: include .svg using the image directive, not raw html

2017-08-10 Thread Sean Paul
On Thu, Aug 10, 2017 at 5:39 AM, Jani Nikula wrote: > I have no idea what I was thinking when I added them as raw html. Using > the image directive should allow browsers to handle the page layout > better. > > Signed-off-by: Jani Nikula TIL! Thanks for the patches. Reviewed-by: Sean Paul > -

Re: [Intel-gfx] [PATCH i-g-t] tests/igt_command_line: Ignore subtest list for kms_ccs

2017-08-10 Thread Arkadiusz Hiler
On Thu, Aug 10, 2017 at 07:26:37PM +0300, Arkadiusz Hiler wrote: > Temporary workaround for "make check" to pass despite the issue with > kms_ccs which do not list any subtests, even though it should. > > TO BE REVERTED by Daniel Stone > > Cc: Daniel Stone > Cc: Daniel Vetter > Signed-off-by: A

Re: [Intel-gfx] [PATCH v6] drm/i915/edp: Allow alternate fixed mode for eDP if available.

2017-08-10 Thread Jim Bride
On Thu, Aug 10, 2017 at 04:13:44PM +0300, Jani Nikula wrote: > On Wed, 09 Aug 2017, Jim Bride wrote: > > Some fixed resolution panels actually support more than one mode, > > with the only thing different being the refresh rate. Having this > > alternate mode available to us is desirable, because

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Split obj->cache_coherent to track r/w

2017-08-10 Thread Patchwork
== Series Details == Series: drm/i915: Split obj->cache_coherent to track r/w URL : https://patchwork.freedesktop.org/series/28641/ State : success == Summary == Series 28641v1 drm/i915: Split obj->cache_coherent to track r/w https://patchwork.freedesktop.org/api/1.0/series/28641/revisions/1/m

Re: [Intel-gfx] [PATCH v6] drm/i915/edp: Allow alternate fixed mode for eDP if available.

2017-08-10 Thread Vivi, Rodrigo
On Thu, 2017-08-10 at 09:37 -0700, Jim Bride wrote: > On Thu, Aug 10, 2017 at 04:13:44PM +0300, Jani Nikula wrote: > > On Wed, 09 Aug 2017, Jim Bride wrote: > > > Some fixed resolution panels actually support more than one mode, > > > with the only thing different being the refresh rate. Having t

[Intel-gfx] ✓ Fi.CI.BAT: success for tests/igt_command_line: Ignore subtest list for kms_ccs

2017-08-10 Thread Patchwork
== Series Details == Series: tests/igt_command_line: Ignore subtest list for kms_ccs URL : https://patchwork.freedesktop.org/series/28642/ State : success == Summary == IGT patchset tested on top of latest successful build c129026622accef6f54c0cfb0dc55e930cfa60b5 igt: add syncobj_basic. with

Re: [Intel-gfx] [PATCH] drm/i915/gen9: Send all components in VF state

2017-08-10 Thread Chris Wilson
Quoting Mika Kuoppala (2017-08-10 12:04:51) > Update gen9 renderstate to account the, long overdue, changes for > igt commit 5c07135b7bd2 ("tools/null_state/gen9: Send all > components in VF state"). > > Signed-off-by: Mika Kuoppala Does what it says on the tin, Reviewed-by: Chris Wilson -Chris

Re: [Intel-gfx] [PATCH] drm/i915: Avoid null dereference if mst_port is unset.

2017-08-10 Thread Stefan Assmann
On 2017-08-10 07:50, Rodrigo Vivi wrote: > I'm not sure if this is really the case and I don't believe > this is the real fix for the bug mentioned here, but since > I don't see a reliable path when mst_port is set and when > mode_valid is requested I believe it is worth to have this > protection h

[Intel-gfx] [PATCH v4 i-g-t] tests/kms: increase max threshold time for edid read

2017-08-10 Thread clinton . a . taylor
From: Clint Taylor Current 50ms max threshold timing for an EDID read is very close to the actual time for a 2 block HDMI EDID read. Adjust the timings base on connector type as DP reads are at 1 MBit and HDMI at 100K bit. If an LSPcon is connected to device under test the -l option should be pas

[Intel-gfx] [PATCH 1/3] drm/i915/perf: Initialise dynamic sysfs group before creation

2017-08-10 Thread Chris Wilson
Another case where we need to call sysfs_attr_init() to setup the internal lockdep class prior to use: [9.325229] BUG: key 880168bc7bb0 not in .data! [9.325240] DEBUG_LOCKS_WARN_ON(1) [9.325250] [ cut here ] [9.325280] WARNING: CPU: 1 PID: 275 at kernel/

  1   2   >