Re: [Intel-gfx] [PATCH i-g-t v3 2/7] lib/igt_kms: Fix off-by-one bug on skip of missing pipe

2017-08-31 Thread Maarten Lankhorst
Op 31-08-17 om 08:18 schreef Gabriel Krisman Bertazi: > display->n_pipes is zero-indexed, so N returned in > igt_display_get_n_pipes is already not a valid pipe. This patch > prevents kms_ccs from going nuts when testing the first unxesting pipe. > > Signed-off-by: Gabriel Krisman Bertazi > --- >

Re: [Intel-gfx] [PATCH i-g-t v3 2/7] lib/igt_kms: Fix off-by-one bug on skip of missing pipe

2017-08-31 Thread Maarten Lankhorst
Op 31-08-17 om 09:06 schreef Maarten Lankhorst: > Op 31-08-17 om 08:18 schreef Gabriel Krisman Bertazi: >> display->n_pipes is zero-indexed, so N returned in >> igt_display_get_n_pipes is already not a valid pipe. This patch >> prevents kms_ccs from going nuts when testing the first unxesting pipe

[Intel-gfx] ✗ Fi.CI.IGT: warning for drm/i915: Skip waking the device to service pwrite

2017-08-31 Thread Patchwork
== Series Details == Series: drm/i915: Skip waking the device to service pwrite URL : https://patchwork.freedesktop.org/series/29560/ State : warning == Summary == Test kms_plane_multiple: Subgroup legacy-pipe-C-tiling-none: pass -> SKIP (shard-hsw) Test kms

Re: [Intel-gfx] [PATCH i-g-t] lib/tests: Add audio selftest

2017-08-31 Thread Paul Kocialkowski
On Wed, 2017-08-30 at 16:44 +0100, Chris Wilson wrote: > Quoting Paul Kocialkowski (2017-08-30 15:45:14) > > This introduces a selftest for the audio library. > > > > It consists of generating a signal from a list of frequencies and > > ensuring that the integrity checking function does detect the

[Intel-gfx] [PATCH i-g-t v8] pm_rps: Changes in waitboost scenario

2017-08-31 Thread Katarzyna Dec
CI is observing sporadical failures in pm_rps subtests. There are a couple of reasons. One of them is the fact that on gen6, gen7 and gen7.5, max frequency (as in the HW limit) is not set to RP0, but the value obtaind from PCODE (which may be different from RP0). Thus the test is operating under wr

Re: [Intel-gfx] [RFC v2 3/3] drm/i915/pmu: deny perf driver level sampling of i915 PMU

2017-08-31 Thread Peter Zijlstra
On Wed, Aug 23, 2017 at 11:43:13PM +, Rogozhkin, Dmitry V wrote: > Hi Chris, > > Why we had event->hw->hrtimer in i915 PMU? Was there any particular > reason? You had some use case which did not work? Some uncore drivers have a hrtimer to poll the counter to deal with counter overflow. This i

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Introduce HAS_2PPC.

2017-08-31 Thread Daniel Vetter
On Wed, Aug 30, 2017 at 09:40:06PM -0700, Rodrigo Vivi wrote: > On Wed, Aug 30, 2017 at 7:58 PM, Pandiyan, Dhinakaran > wrote: > > On Wed, 2017-08-30 at 20:32 +0100, Chris Wilson wrote: > >> Quoting Pandiyan, Dhinakaran (2017-08-30 20:12:52) > >> > On Wed, 2017-08-16 at 17:54 -0700, Rodrigo Vivi w

Re: [Intel-gfx] [PATCH i-g-t] lib/tests: Add audio selftest

2017-08-31 Thread Paul Kocialkowski
Hi, On Wed, 2017-08-30 at 14:53 -0400, Lyude Paul wrote: > On Wed, 2017-08-30 at 17:45 +0300, Paul Kocialkowski wrote: > > This introduces a selftest for the audio library. > > > > It consists of generating a signal from a list of frequencies and > > ensuring that the integrity checking function

[Intel-gfx] [PATCH i-g-t v2] lib/tests: Add audio selftest

2017-08-31 Thread Paul Kocialkowski
This introduces a selftest for the audio library. It consists of generating a signal from a list of frequencies and ensuring that the integrity checking function does detect these frequencies (and only these frequencies). Signed-off-by: Paul Kocialkowski --- lib/tests/.gitignore | 1 + l

Re: [Intel-gfx] [PATCH] drm/i915: Always wake the device to flush the GTT

2017-08-31 Thread Daniel Vetter
On Wed, Aug 30, 2017 at 04:13:41PM +0100, Chris Wilson wrote: > Quoting Daniel Vetter (2017-08-30 14:59:32) > > On Wed, Aug 30, 2017 at 01:56:40PM +0100, Chris Wilson wrote: > > > Quoting Daniel Vetter (2017-08-30 13:23:56) > > > > Or just the need to add a pile more tests to pm_rpm? > > > > > > N

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Make own struct for execlist items (rev2)

2017-08-31 Thread Mika Kuoppala
Patchwork writes: > == Series Details == > > Series: series starting with [1/2] drm/i915: Make own struct for execlist > items (rev2) > URL : https://patchwork.freedesktop.org/series/29533/ > State : failure > > == Summary == > > Series 29533v2 series starting with [1/2] drm/i915: Make own str

Re: [Intel-gfx] [RFCv6 2/2] drm/i915: Introduce private PAT management

2017-08-31 Thread Joonas Lahtinen
On Thu, 2017-08-31 at 12:49 +0800, Zhi Wang wrote: > Hi Vivi: > Thanks for the reply! The register are written in ppat->update_hw() > now. Could we do like I already asked and not simultaneously change the code organization and register values? Just have this patch write exactly the same val

Re: [Intel-gfx] [PATCH] drm/i915/cnl: Avoid ioremap_wc on Cannonlake as well.

2017-08-31 Thread Joonas Lahtinen
On Wed, 2017-08-30 at 17:58 +, Vivi, Rodrigo wrote: > On Wed, 2017-08-30 at 14:38 +0300, Joonas Lahtinen wrote: > > On Wed, 2017-08-30 at 12:26 +0100, Chris Wilson wrote: > > > Quoting Joonas Lahtinen (2017-08-30 12:13:29) > > > > On Tue, 2017-08-29 at 16:09 -0700, Rodrigo Vivi wrote: > > > > >

Re: [Intel-gfx] [RFCv6 2/2] drm/i915: Introduce private PAT management

2017-08-31 Thread Wang, Zhi A
Do you mean I still keep I915_WRITE(x) in _setup_private_pat() like before? Then changed them in a new patch? Thanks, Zhi. -Original Message- From: Joonas Lahtinen [mailto:joonas.lahti...@linux.intel.com] Sent: Thursday, August 31, 2017 11:26 AM To: Wang, Zhi A ; Vivi, Rodrigo

[Intel-gfx] [PATCH] drm/i915: Keep the device awake whilst in the GTT write domain

2017-08-31 Thread Chris Wilson
Since runtime suspend is very harsh on GTT mmappings (they all get zapped on suspend) keep the device awake while we the buffer remains in the GTT write domain (as we expect subsequent writes). We special case writes here, as the write domain is more bounded than the read domains; a buffer may rema

[Intel-gfx] [PATCH i-g-t v5 08/11] tests/perf: make buffer-fill more reliable

2017-08-31 Thread Lionel Landwerlin
Filling rate of the buffer must discard context switch reports as they do not depend upon the periodicity, instead they're a factor on the amount of different applications concurrently running on the system. Signed-off-by: Lionel Landwerlin Tested-by: Matthew Auld Reviewed-by: Matthew Auld ---

[Intel-gfx] [PATCH i-g-t v5 07/11] tests/perf: make enable-disable more reliable

2017-08-31 Thread Lionel Landwerlin
Estimation of the amount of reports can only refer to periodic ones, as context switch reports completely depend on what happens on the system. Also generate some load to prevent clock frequency changes to impact our measurement. Signed-off-by: Lionel Landwerlin --- tests/perf.c | 96 +++

[Intel-gfx] [PATCH i-g-t v5 03/11] tests/perf: update max buffer size for reading reports

2017-08-31 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- tests/perf.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/perf.c b/tests/perf.c index 8644e252..bd139bde 100644 --- a/tests/perf.c +++ b/tests/perf.c @@ -1298,9 +1298,7 @@ read_2_oa_reports(int format_id, /* Note: w

[Intel-gfx] [PATCH i-g-t v5 01/11] tests/perf: make stream_fd a global variable

2017-08-31 Thread Lionel Landwerlin
When debugging unstable tests on new platforms we currently we don't cleanup everything well in between different tests. Since only a single OA stream fd can be opened at a time, having the stream_fd as a global variable helps us cleanup the state between tests. Signed-off-by: Lionel Landwerlin -

[Intel-gfx] [PATCH i-g-t v5 04/11] tests/perf: rc6: try to guess when rc6 is disabled

2017-08-31 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- tests/perf.c | 13 + 1 file changed, 13 insertions(+) diff --git a/tests/perf.c b/tests/perf.c index bd139bde..5fe0a332 100644 --- a/tests/perf.c +++ b/tests/perf.c @@ -3463,6 +3463,17 @@ gen8_test_single_ctx_render_target_writes_a_counter(void)

[Intel-gfx] [PATCH i-g-t v5 11/11] tests/perf: add support for Coffeelake

2017-08-31 Thread Lionel Landwerlin
Using the same timestamp frequency as Skylake/Kabylake. Signed-off-by: Lionel Landwerlin --- tests/perf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/perf.c b/tests/perf.c index 070dee97..a4d3f663 100644 --- a/tests/perf.c +++ b/tests/perf.c @@ -1145,6 +1145,9 @@ init_sys_info(v

[Intel-gfx] [PATCH i-g-t v5 10/11] tests/perf: prevent power management to kick in when necessary

2017-08-31 Thread Lionel Landwerlin
Some of our tests measure that the OA unit produces reports at expected time intervals (as configured through the PERF_OPEN ioctl). It turns out the power management plays a role in the decision of the OA unit to write reports to memory. Under normal circumstances we don't really mind if the unit m

[Intel-gfx] [PATCH i-g-t v5 06/11] tests/perf: rework oa-exponent test

2017-08-31 Thread Lionel Landwerlin
New issues that were discovered while making the tests work on Gen8+ : - we need to measure timings between periodic reports and discard all other kind of reports - it seems periodicity of the reports can be affected outside of RC6 (frequency change), we can detect this by looking at the

[Intel-gfx] [PATCH i-g-t v5 02/11] tests/perf: add per context filtering test for gen8+

2017-08-31 Thread Lionel Landwerlin
From: Robert Bragg Signed-off-by: Robert Bragg Signed-off-by: Lionel Landwerlin --- tests/perf.c | 777 --- 1 file changed, 745 insertions(+), 32 deletions(-) diff --git a/tests/perf.c b/tests/perf.c index f89a235e..8644e252 100644 --- a

[Intel-gfx] [PATCH i-g-t v5 00/11] Improve robustness of the i915 perf tests

2017-08-31 Thread Lionel Landwerlin
Hi, I pushed the couple of patches that I could and that had a Rb by Matthew (Kabylake/Geminilake support). Here is pretty much the same series as v4 only adding Coffeelake support. Cheers, Lionel Landwerlin (10): tests/perf: make stream_fd a global variable tests/perf: update max buffer siz

[Intel-gfx] [PATCH i-g-t v5 09/11] tests/perf: estimate number of blocking/polling based on time spent

2017-08-31 Thread Lionel Landwerlin
Blocking & polling tests define an amount of time to spend in the test and then estimate the number of syscalls that should successfully return. The problem is that while running the test we might spend slightly more time than initiallly planned. This change estimates the number of syscalls based o

[Intel-gfx] [PATCH i-g-t v5 05/11] tests/perf: remove frequency related changes

2017-08-31 Thread Lionel Landwerlin
Experience shows that most of the issues we face with periodicity of the reports produced by the OA unit are related to power management, not frequency. Signed-off-by: Lionel Landwerlin --- tests/perf.c | 141 --- 1 file changed, 9 insertio

[Intel-gfx] [PATCH v2] drm/i915: Keep the device awake whilst in the GTT write domain

2017-08-31 Thread Chris Wilson
Since runtime suspend is very harsh on GTT mmappings (they all get zapped on suspend) keep the device awake while we the buffer remains in the GTT write domain (as we expect subsequent writes). We special case writes here, as the write domain is more bounded than the read domains; a buffer may rema

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: implement NOA mux reprogramming at ctx-switch

2017-08-31 Thread Patchwork
== Series Details == Series: drm/i915: implement NOA mux reprogramming at ctx-switch URL : https://patchwork.freedesktop.org/series/29564/ State : success == Summary == Series 29564v1 drm/i915: implement NOA mux reprogramming at ctx-switch https://patchwork.freedesktop.org/api/1.0/series/29564

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Add a default case in gen7 hwsp switch-case (rev2)

2017-08-31 Thread Patchwork
== Series Details == Series: drm/i915: Add a default case in gen7 hwsp switch-case (rev2) URL : https://patchwork.freedesktop.org/series/29494/ State : failure == Summary == Test kms_ccs: Subgroup pipe-D-crc-primary-basic: skip -> INCOMPLETE (shard-hsw) Test perf:

[Intel-gfx] [PATCH i-g-t 1/2] lib: rename to libigt

2017-08-31 Thread Daniel Vetter
Just for ocd. Signed-off-by: Daniel Vetter --- benchmarks/Makefile.am | 2 +- debugger/Makefile.am | 2 +- demos/Makefile.am | 2 +- lib/Makefile.am| 10 +- lib/tests/Makefile.am | 2 +- tests/Makefile.am | 2 +- tools/Makefile.am | 6 +++--- 7 files chang

[Intel-gfx] [PATCH i-g-t 2/2] lib: Attemp at .so libraries

2017-08-31 Thread Daniel Vetter
I managed to get it built, but none of the executables is using it. At least one version of this also needed the alsa lib/flags added, so it'll build properly as an .so. No idea why it doesn't go boom when only building the .la. Signed-off-by: Daniel Vetter --- configure.ac| 2 ++ lib/Makef

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v4,1/2] drm/i915: Track minimum acceptable cdclk instead of "minimum dotclock" (rev2)

2017-08-31 Thread Patchwork
== Series Details == Series: series starting with [v4,1/2] drm/i915: Track minimum acceptable cdclk instead of "minimum dotclock" (rev2) URL : https://patchwork.freedesktop.org/series/27078/ State : success == Summary == Series 27078v2 series starting with [v4,1/2] drm/i915: Track minimum acc

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/cnl: Fix DP max voltage (rev2)

2017-08-31 Thread Patchwork
== Series Details == Series: drm/i915/cnl: Fix DP max voltage (rev2) URL : https://patchwork.freedesktop.org/series/27076/ State : failure == Summary == CHK include/config/kernel.release CHK include/generated/uapi/linux/version.h CHK include/generated/utsrelease.h CHK i

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Disable DRRS when PSR is enabled

2017-08-31 Thread Patchwork
== Series Details == Series: drm/i915: Disable DRRS when PSR is enabled URL : https://patchwork.freedesktop.org/series/29577/ State : success == Summary == Series 29577v1 drm/i915: Disable DRRS when PSR is enabled https://patchwork.freedesktop.org/api/1.0/series/29577/revisions/1/mbox/ Test k

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/cnp: Wa 1181: Fix Backlight issue (rev2)

2017-08-31 Thread Patchwork
== Series Details == Series: drm/i915/cnp: Wa 1181: Fix Backlight issue (rev2) URL : https://patchwork.freedesktop.org/series/29452/ State : success == Summary == Series 29452v2 drm/i915/cnp: Wa 1181: Fix Backlight issue https://patchwork.freedesktop.org/api/1.0/series/29452/revisions/2/mbox/

Re: [Intel-gfx] [RFC v2 2/3] drm/i915/pmu: serve global events and support perf stat

2017-08-31 Thread Peter Zijlstra
On Wed, Aug 30, 2017 at 05:24:30PM +, Rogozhkin, Dmitry V wrote: > I figured out how to track cpus online/offline status in PMU. Here is a > question however. What is the reason for uncore PMUs (cstate.c for > example) to register for cpus other than cpu0? I see it registers for > first thread

Re: [Intel-gfx] [RFC v2 2/3] drm/i915/pmu: serve global events and support perf stat

2017-08-31 Thread Peter Zijlstra
On Wed, Aug 30, 2017 at 05:24:30PM +, Rogozhkin, Dmitry V wrote: > Ok... but they could register for just cpu0. Besides, it looks like on > Linux cpu0 can't go offline at all at least of x86 architecture. Peter, > could you, please, clarify the reasoning to register designated readers > of unco

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Keep the device awake whilst in the GTT write domain (rev2)

2017-08-31 Thread Patchwork
== Series Details == Series: drm/i915: Keep the device awake whilst in the GTT write domain (rev2) URL : https://patchwork.freedesktop.org/series/29594/ State : failure == Summary == Series 29594v2 drm/i915: Keep the device awake whilst in the GTT write domain https://patchwork.freedesktop.org

[Intel-gfx] ✓ Fi.CI.BAT: success for tests/perf_pmu: test i915 RFC PMU (rev2)

2017-08-31 Thread Patchwork
== Series Details == Series: tests/perf_pmu: test i915 RFC PMU (rev2) URL : https://patchwork.freedesktop.org/series/29313/ State : success == Summary == IGT patchset tested on top of latest successful build c2159678d283fea5615ec8e846a51cf4954ac82d tests/perf: add Geminilake support with late

Re: [Intel-gfx] [PATCH] drm/i915/cnl: Fix DP max voltage

2017-08-31 Thread Ville Syrjälä
On Wed, Aug 30, 2017 at 05:00:50PM -0700, Rodrigo Vivi wrote: > From: "Vivi, Rodrigo" > > On clock recovery this function is called to find out > the max voltage swing level that we could go. > > However gen 9 functions use the old buffer translation tables > to figure that out. That table is no

[Intel-gfx] ✓ Fi.CI.BAT: success for kms_ccs testcase improvements

2017-08-31 Thread Patchwork
== Series Details == Series: kms_ccs testcase improvements URL : https://patchwork.freedesktop.org/series/29585/ State : success == Summary == IGT patchset tested on top of latest successful build c2159678d283fea5615ec8e846a51cf4954ac82d tests/perf: add Geminilake support with latest DRM-Tip

Re: [Intel-gfx] [PATCH i-g-t v2] lib/tests: Add audio selftest

2017-08-31 Thread Paul Kocialkowski
On Thu, 2017-08-31 at 11:02 +0300, Paul Kocialkowski wrote: > This introduces a selftest for the audio library. > > It consists of generating a signal from a list of frequencies and > ensuring that the integrity checking function does detect these > frequencies (and only these frequencies). Looks

[Intel-gfx] ✗ Fi.CI.BAT: failure for pm_rps: Changes in waitboost scenario (rev10)

2017-08-31 Thread Patchwork
== Series Details == Series: pm_rps: Changes in waitboost scenario (rev10) URL : https://patchwork.freedesktop.org/series/28966/ State : failure == Summary == IGT patchset tested on top of latest successful build c2159678d283fea5615ec8e846a51cf4954ac82d tests/perf: add Geminilake support with

[Intel-gfx] [PATCH i-g-t 1/1] chamelium: Add work in progress test for HDMI audio integrity testing

2017-08-31 Thread Paul Kocialkowski
This adds preliminary support for testing HDMI audio integrity with the Chamelium. It aims to use the ALSA and audio IGT libraries to generate a signal with a list of given frequencies, output it through HDMI and check that the correct frequencies (and only those) are detected. The test is current

[Intel-gfx] [PATCH i-g-t 0/1] chamelium: Add work in progress test for HDMI audio

2017-08-31 Thread Paul Kocialkowski
This patch contains a work in progress test for HDMI audio integrity testing. It is currently not working and should not be merged. It is sent as-is for reference, in hope that work in this area will be resumed later on. It is the latest version at the time of my final summer internship day at Int

[Intel-gfx] ✓ Fi.CI.BAT: success for lib/tests: Add audio selftest (rev2)

2017-08-31 Thread Patchwork
== Series Details == Series: lib/tests: Add audio selftest (rev2) URL : https://patchwork.freedesktop.org/series/29550/ State : success == Summary == IGT patchset tested on top of latest successful build c2159678d283fea5615ec8e846a51cf4954ac82d tests/perf: add Geminilake support with latest D

[Intel-gfx] ✓ Fi.CI.BAT: success for Improve robustness of the i915 perf tests (rev3)

2017-08-31 Thread Patchwork
== Series Details == Series: Improve robustness of the i915 perf tests (rev3) URL : https://patchwork.freedesktop.org/series/28373/ State : success == Summary == IGT patchset tested on top of latest successful build c2159678d283fea5615ec8e846a51cf4954ac82d tests/perf: add Geminilake support w

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] lib: rename to libigt

2017-08-31 Thread Patchwork
== Series Details == Series: series starting with [1/2] lib: rename to libigt URL : https://patchwork.freedesktop.org/series/29603/ State : failure == Summary == IGT patchset build failed on latest successful build c2159678d283fea5615ec8e846a51cf4954ac82d tests/perf: add Geminilake support ma

[Intel-gfx] ✗ Fi.CI.BAT: failure for chamelium: Add work in progress test for HDMI audio

2017-08-31 Thread Patchwork
== Series Details == Series: chamelium: Add work in progress test for HDMI audio URL : https://patchwork.freedesktop.org/series/29609/ State : failure == Summary == IGT patchset build failed on latest successful build c2159678d283fea5615ec8e846a51cf4954ac82d tests/perf: add Geminilake support

Re: [Intel-gfx] [PATCH 00/13] mmu_notifier kill invalidate_page callback

2017-08-31 Thread Jerome Glisse
[Adding Intel folks as they might be interested in this discussion] On Wed, Aug 30, 2017 at 05:51:52PM -0400, Felix Kuehling wrote: > Hi Jérôme, > > I have some questions about the potential range-start-end race you > mentioned. > > On 2017-08-29 07:54 PM, Jérôme Glisse wrote: > > Note that a lo

[Intel-gfx] ✗ Fi.CI.IGT: warning for drm/i915: implement NOA mux reprogramming at ctx-switch

2017-08-31 Thread Patchwork
== Series Details == Series: drm/i915: implement NOA mux reprogramming at ctx-switch URL : https://patchwork.freedesktop.org/series/29564/ State : warning == Summary == Test kms_setmode: Subgroup basic: pass -> FAIL (shard-hsw) fdo#99912 Test kms_atomic_tran

[Intel-gfx] [PATCH v3] drm/i915: Keep the device awake whilst in the GTT domain

2017-08-31 Thread Chris Wilson
Since runtime suspend is very harsh on GTT mmappings (they all get zapped on suspend) keep the device awake while the buffer remains in the GTT domain. However, userspace can control the domain and although there is a soft contract that writes must be flushed (for e.g. flushing scanouts and fbc), w

Re: [Intel-gfx] [RFCv6 2/2] drm/i915: Introduce private PAT management

2017-08-31 Thread Joonas Lahtinen
On Thu, 2017-08-31 at 08:28 +, Wang, Zhi A wrote: > Do you mean I still keep I915_WRITE(x) in _setup_private_pat() like > before? Then changed them in a new patch? No, I mean use the new code structure, but make sure all register writes are equal to what they were before (and please

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for pm_rps: Changes in waitboost scenario (rev10)

2017-08-31 Thread Arkadiusz Hiler
On Thu, Aug 31, 2017 at 01:03:24PM +, Patchwork wrote: > == Series Details == > > Series: pm_rps: Changes in waitboost scenario (rev10) > URL : https://patchwork.freedesktop.org/series/28966/ > State : failure > > == Summary == > > IGT patchset tested on top of latest successful build > c2

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Keep the device awake whilst in the GTT write domain (rev3)

2017-08-31 Thread Patchwork
== Series Details == Series: drm/i915: Keep the device awake whilst in the GTT write domain (rev3) URL : https://patchwork.freedesktop.org/series/29594/ State : failure == Summary == Series 29594v3 drm/i915: Keep the device awake whilst in the GTT write domain https://patchwork.freedesktop.org

[Intel-gfx] [PATCH] drm/i915/cnl: Fix DP max voltage

2017-08-31 Thread Rodrigo Vivi
From: "Vivi, Rodrigo" On clock recovery this function is called to find out the max voltage swing level that we could go. However gen 9 functions use the old buffer translation tables to figure that out. That table is not valid for CNL causing an invalid number of entries and an invalid selectio

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v4,1/2] drm/i915: Track minimum acceptable cdclk instead of "minimum dotclock" (rev2)

2017-08-31 Thread Patchwork
== Series Details == Series: series starting with [v4,1/2] drm/i915: Track minimum acceptable cdclk instead of "minimum dotclock" (rev2) URL : https://patchwork.freedesktop.org/series/27078/ State : success == Summary == Test kms_setmode: Subgroup basic: pass ->

Re: [Intel-gfx] [PATCH] drm/i915/cnl: Fix DP max voltage

2017-08-31 Thread Ville Syrjälä
On Thu, Aug 31, 2017 at 07:53:56AM -0700, Rodrigo Vivi wrote: > From: "Vivi, Rodrigo" > > On clock recovery this function is called to find out > the max voltage swing level that we could go. > > However gen 9 functions use the old buffer translation tables > to figure that out. That table is no

Re: [Intel-gfx] [RFC PATCH 1/5] drm/i915: Always wait for flip_done

2017-08-31 Thread Maarten Lankhorst
Op 30-08-17 om 15:40 schreef Daniel Vetter: > On Wed, Aug 30, 2017 at 02:54:28PM +0200, Maarten Lankhorst wrote: >> Op 30-08-17 om 14:43 schreef Daniel Vetter: >>> On Wed, Aug 30, 2017 at 02:17:48PM +0200, Maarten Lankhorst wrote: The next commit removes the wait for flip_done in in drm_a

Re: [Intel-gfx] [RFCv6 2/2] drm/i915: Introduce private PAT management

2017-08-31 Thread Wang, Zhi A
I see. Thanks for the explanation! :) -Original Message- From: Joonas Lahtinen [mailto:joonas.lahti...@linux.intel.com] Sent: Thursday, August 31, 2017 5:20 PM To: Wang, Zhi A ; Vivi, Rodrigo Cc: intel-gfx@lists.freedesktop.org; zhen...@linux.intel.com; intel-gvt-...@lists.freedesktop.o

Re: [Intel-gfx] [PATCH 00/13] mmu_notifier kill invalidate_page callback

2017-08-31 Thread Christian König
Am 31.08.2017 um 15:59 schrieb Jerome Glisse: [Adding Intel folks as they might be interested in this discussion] On Wed, Aug 30, 2017 at 05:51:52PM -0400, Felix Kuehling wrote: Hi Jérôme, I have some questions about the potential range-start-end race you mentioned. On 2017-08-29 07:54 PM, Jé

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Disable DRRS when PSR is enabled

2017-08-31 Thread Patchwork
== Series Details == Series: drm/i915: Disable DRRS when PSR is enabled URL : https://patchwork.freedesktop.org/series/29577/ State : success == Summary == Test kms_setmode: Subgroup basic: pass -> FAIL (shard-hsw) fdo#99912 Test perf: Subgroup block

[Intel-gfx] [PATCH] drm/i915: Fix the missing PPAT cache attributes on CNL

2017-08-31 Thread Zhi Wang
Add back the GEN8_PPAT_WB cache attributes in cnl_setup_private_ppat(), which are missed on CNL. Signed-off-by: Zhi Wang --- drivers/gpu/drm/i915/i915_gem_gtt.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Fix the missing PPAT cache attributes on CNL

2017-08-31 Thread Patchwork
== Series Details == Series: drm/i915: Fix the missing PPAT cache attributes on CNL URL : https://patchwork.freedesktop.org/series/29618/ State : warning == Summary == Series 29618v1 drm/i915: Fix the missing PPAT cache attributes on CNL https://patchwork.freedesktop.org/api/1.0/series/29618/r

Re: [Intel-gfx] [PATCH] drm/i915/cnl: Avoid ioremap_wc on Cannonlake as well.

2017-08-31 Thread Vivi, Rodrigo
On Thu, 2017-08-31 at 11:27 +0300, Joonas Lahtinen wrote: > On Wed, 2017-08-30 at 17:58 +, Vivi, Rodrigo wrote: > > On Wed, 2017-08-30 at 14:38 +0300, Joonas Lahtinen wrote: > > > On Wed, 2017-08-30 at 12:26 +0100, Chris Wilson wrote: > > > > Quoting Joonas Lahtinen (2017-08-30 12:13:29) > > >

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/cnp: Wa 1181: Fix Backlight issue (rev2)

2017-08-31 Thread Patchwork
== Series Details == Series: drm/i915/cnp: Wa 1181: Fix Backlight issue (rev2) URL : https://patchwork.freedesktop.org/series/29452/ State : success == Summary == Test perf: Subgroup blocking: pass -> FAIL (shard-hsw) fdo#102252 Test kms_setmode: Sub

Re: [Intel-gfx] [PATCH] drm/i915/cnl: Fix DP max voltage

2017-08-31 Thread Vivi, Rodrigo
On Thu, 2017-08-31 at 18:06 +0300, Ville Syrjälä wrote: > On Thu, Aug 31, 2017 at 07:53:56AM -0700, Rodrigo Vivi wrote: > > From: "Vivi, Rodrigo" > > > > On clock recovery this function is called to find out > > the max voltage swing level that we could go. > > > > However gen 9 functions use th

[Intel-gfx] ✓ Fi.CI.IGT: success for tests/perf_pmu: test i915 RFC PMU (rev2)

2017-08-31 Thread Patchwork
== Series Details == Series: tests/perf_pmu: test i915 RFC PMU (rev2) URL : https://patchwork.freedesktop.org/series/29313/ State : success == Summary == Test perf: Subgroup blocking: pass -> FAIL (shard-hsw) fdo#102252 Test kms_flip: Subgroup plain-

Re: [Intel-gfx] [PATCH] drm/i915: Disable DRRS when PSR is enabled

2017-08-31 Thread Sripada, Radhakrishna
> -Original Message- > From: Vivi, Rodrigo > Sent: Wednesday, August 30, 2017 5:59 PM > To: Sripada, Radhakrishna > Cc: intel-gfx@lists.freedesktop.org; Pandiyan, Dhinakaran > ; Nikula, Jani ; > Taylor, Clinton A ; nicholas.stom...@gmail.com > Subject: Re: [PATCH] drm/i915: Disable DRRS

[Intel-gfx] ✓ Fi.CI.IGT: success for kms_ccs testcase improvements

2017-08-31 Thread Patchwork
== Series Details == Series: kms_ccs testcase improvements URL : https://patchwork.freedesktop.org/series/29585/ State : success == Summary == Test kms_setmode: Subgroup basic: pass -> FAIL (shard-hsw) fdo#99912 Test kms_flip: Subgroup plain-flip-fb-

Re: [Intel-gfx] [RFCv6 2/2] drm/i915: Introduce private PAT management

2017-08-31 Thread Wang, Zhi A
I see why that is going wrong. I take Chris' comments directly like: __alloc_ppat_entry(ppat, PPAT_CACHE_PDE_INDEX,), but 0 != PPAT_CACHE_PDE_INDEX actually. Wait my update. Thanks, Zhi. -Original Message- From: Rodrigo Vivi [mailto:rodrigo.v...@gmail.com] Sent: Thursday, August 31

Re: [Intel-gfx] [PATCH] drm/i915/edp: Increase T12 panel delay to 900 ms to fix DP AUX CH timeouts

2017-08-31 Thread Ville Syrjälä
On Tue, Aug 15, 2017 at 11:59:51AM -0700, Manasi Navare wrote: > This patch fixes the DP AUX CH timeouts observed during CI runs causing > CI Failures on a specific PCI device. This issue was fixed previously > by adding a quirk but looks like we need to increase this delay even more > in order to

Re: [Intel-gfx] [PATCH v4 1/2] drm/i915: Track minimum acceptable cdclk instead of "minimum dotclock"

2017-08-31 Thread Ville Syrjälä
On Wed, Aug 30, 2017 at 09:57:03PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Make the min_pixclk thing less confusing by changing it to track > the minimum acceptable cdclk frequency instead. This means moving > the application of the guardbands to a slightly higher le

Re: [Intel-gfx] [PATCH 4/7] drm/i915: Pass proper old/new states to intel_plane_atomic_check_with_state()

2017-08-31 Thread Ville Syrjälä
On Wed, Aug 23, 2017 at 06:22:23PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Eliminate plane->state and crtc->state usage from > intel_plane_atomic_check_with_state() and its callers. Instead pass the > proper states in or dig them up from the top level atomic state. >

Re: [Intel-gfx] [PATCH 00/13] mmu_notifier kill invalidate_page callback

2017-08-31 Thread Jerome Glisse
On Thu, Aug 31, 2017 at 02:39:17PM -0400, Felix Kuehling wrote: > On 2017-08-31 09:59 AM, Jerome Glisse wrote: > > [Adding Intel folks as they might be interested in this discussion] > > > > On Wed, Aug 30, 2017 at 05:51:52PM -0400, Felix Kuehling wrote: > >> Hi Jérôme, > >> > >> I have some questi

[Intel-gfx] ✗ Fi.CI.IGT: failure for lib/tests: Add audio selftest (rev2)

2017-08-31 Thread Patchwork
== Series Details == Series: lib/tests: Add audio selftest (rev2) URL : https://patchwork.freedesktop.org/series/29550/ State : failure == Summary == Test kms_setmode: Subgroup basic: pass -> FAIL (shard-hsw) fdo#99912 Test kms_flip: Subgroup plain-f

[Intel-gfx] [PATCH 3/4] drm/i915: Introduce private PAT management

2017-08-31 Thread Zhi Wang
The private PAT management is to support PPAT entry manipulation. Two APIs are introduced for dynamically managing PPAT entries: intel_ppat_get and intel_ppat_put. intel_ppat_get will search for an existing PPAT entry which perfectly matches the required PPAT value. If not, it will try to allocate

[Intel-gfx] [PATCH 1/4] drm/i915: Fix the missing PPAT cache attributes on CNL

2017-08-31 Thread Zhi Wang
Add back the GEN8_PPAT_WB cache attributes in cnl_setup_private_ppat(), which are missed on CNL. Fixes: e34935 ("drm/i915/cnl: Setup PAT Index") Cc: Ben Widawsky Cc: Rodrigo Vivi Cc: Chris Wilson Suggested-by: Joonas Lahtinen Signed-off-by: Zhi Wang --- drivers/gpu/drm/i915/i915_gem_gtt.c |

[Intel-gfx] [PATCH 2/4] drm/i915: Factor out setup_private_pat()

2017-08-31 Thread Zhi Wang
Factor out setup_private_pat() for introducing the following patches. Cc: Ben Widawsky Cc: Rodrigo Vivi Cc: Chris Wilson Cc: Joonas Lahtinen Signed-off-by: Zhi Wang --- drivers/gpu/drm/i915/i915_gem_gtt.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git

[Intel-gfx] [PATCH 4/4] drm/i915: Do not allocate unused PPAT entries

2017-08-31 Thread Zhi Wang
Only PPAT entries 0/2/3/4 are using. Remove extra PPAT entry allocation during initialization. Cc: Ben Widawsky Cc: Rodrigo Vivi Cc: Chris Wilson Suggested-by: Joonas Lahtinen Signed-off-by: Zhi Wang --- drivers/gpu/drm/i915/i915_gem_gtt.c | 46 - drivers/

[Intel-gfx] [PATCH 1/2] drm: Fix example comment of format modifier blob

2017-08-31 Thread Gabriel Krisman Bertazi
To represent formats 98-102, the supported formats mask must be 0x7c and not 0x3c. Signed-off-by: Gabriel Krisman Bertazi --- include/uapi/drm/drm_mode.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mod

[Intel-gfx] [PATCH 2/2] drm/i915: Fail addfb ioctl if color and CCS buffers overlap

2017-08-31 Thread Gabriel Krisman Bertazi
With this patch the new testcase igt@kms_ccs@pipe-X-invalid-ccs-offset succeeds. Signed-off-by: Gabriel Krisman Bertazi --- drivers/gpu/drm/i915/intel_display.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c i

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915: Fix the missing PPAT cache attributes on CNL

2017-08-31 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Fix the missing PPAT cache attributes on CNL URL : https://patchwork.freedesktop.org/series/29625/ State : success == Summary == Series 29625v1 series starting with [1/4] drm/i915: Fix the missing PPAT cache attributes on CNL

Re: [Intel-gfx] [PATCH 1/2] drm: Fix example comment of format modifier blob

2017-08-31 Thread Ben Widawsky
On 17-08-31 16:52:14, Gabriel Krisman Bertazi wrote: To represent formats 98-102, the supported formats mask must be 0x7c and not 0x3c. Signed-off-by: Gabriel Krisman Bertazi --- include/uapi/drm/drm_mode.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/i

[Intel-gfx] ✓ Fi.CI.IGT: success for Improve robustness of the i915 perf tests (rev3)

2017-08-31 Thread Patchwork
== Series Details == Series: Improve robustness of the i915 perf tests (rev3) URL : https://patchwork.freedesktop.org/series/28373/ State : success == Summary == Test perf: Subgroup polling: fail -> PASS (shard-hsw) fdo#102252 Subgroup oa-exponents:

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Fail addfb ioctl if color and CCS buffers overlap

2017-08-31 Thread Ben Widawsky
On 17-08-31 16:52:15, Gabriel Krisman Bertazi wrote: With this patch the new testcase igt@kms_ccs@pipe-X-invalid-ccs-offset succeeds. Signed-off-by: Gabriel Krisman Bertazi --- drivers/gpu/drm/i915/intel_display.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/inte

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm: Fix example comment of format modifier blob

2017-08-31 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm: Fix example comment of format modifier blob URL : https://patchwork.freedesktop.org/series/29627/ State : success == Summary == Series 29627v1 series starting with [1/2] drm: Fix example comment of format modifier blob https://patc

[Intel-gfx] [PATCH v2] drm/i915: Disable DRRS when PSR is enabled

2017-08-31 Thread Radhakrishna Sripada
Some platforms donot support PSR and DRRS simultaneously. Visual artifacts and flickering were reported on BDW HP Spectre x360 Convertible. Deferring to PSR when both PSR and DRRS are supported by the panel. V2: Minor code-style changes suggested by Rodrigo Bugzilla: https://bugs.freedesktop.org/

[Intel-gfx] [PATCH v2 0/4] drm/i915: implement NOA mux reprogramming at ctx-switch

2017-08-31 Thread Lionel Landwerlin
Some pertinent changes suggested by Chris. The most important one being using the indirect-ctx batchbuffer. Cheers, Lionel Landwerlin (4): drm/i915: don't specify pinned size for wa_bb pin/allocation drm/i915: extract per-ctx/indirect bb programming drm/i915: pass wa_ctx as argument drm/i

[Intel-gfx] [PATCH v2 1/4] drm/i915: don't specify pinned size for wa_bb pin/allocation

2017-08-31 Thread Lionel Landwerlin
We can rely on the i915_vma_pin() to use vma->size instead. v2: Actually set the pin size to 0 to vma->size is used implicitly (Chris) Signed-off-by: Lionel Landwerlin --- drivers/gpu/drm/i915/intel_lrc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i9

[Intel-gfx] [PATCH v2 3/4] drm/i915: pass wa_ctx as argument

2017-08-31 Thread Lionel Landwerlin
Rather than accessing it from the engine structure. This will be used for reprogramming later. Signed-off-by: Lionel Landwerlin --- drivers/gpu/drm/i915/intel_lrc.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/dr

[Intel-gfx] [PATCH v2 2/4] drm/i915: extract per-ctx/indirect bb programming

2017-08-31 Thread Lionel Landwerlin
Let's put this in its own function to reuse it later. v2: Pull in condition in the extracted function (Chris) Signed-off-by: Lionel Landwerlin --- drivers/gpu/drm/i915/intel_lrc.c | 37 +++-- 1 file changed, 23 insertions(+), 14 deletions(-) diff --git a/drivers

[Intel-gfx] [PATCH v2 4/4] drm/i915: reprogram NOA muxes on context switch when using perf

2017-08-31 Thread Lionel Landwerlin
If some of the contexts submitting workloads to the GPU have been configured to shutdown slices/subslices, we might loose the NOA configurations written in the NOA muxes. We need to reprogram them at context switch. v2: Do reprogramming in indirect-ctx batchbuffer (Chris) Simplify emission by

[Intel-gfx] [PATCH i-g-t v2] tests/gem_flink_basic: Add documentation for subtests

2017-08-31 Thread Vinay Belgaumkar
Added the missing IGT_TEST_DESCRIPTION and some subtest descriptions. Trying to establish a method to document subtests, it should describe the feature being tested rather than how. The HOW part can, if needed, be described in the test code. Documenting subtests will give us a good way to trace fe

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Disable DRRS when PSR is enabled (rev2)

2017-08-31 Thread Patchwork
== Series Details == Series: drm/i915: Disable DRRS when PSR is enabled (rev2) URL : https://patchwork.freedesktop.org/series/29577/ State : success == Summary == Series 29577v2 drm/i915: Disable DRRS when PSR is enabled https://patchwork.freedesktop.org/api/1.0/series/29577/revisions/2/mbox/

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: implement NOA mux reprogramming at ctx-switch (rev2)

2017-08-31 Thread Patchwork
== Series Details == Series: drm/i915: implement NOA mux reprogramming at ctx-switch (rev2) URL : https://patchwork.freedesktop.org/series/29564/ State : success == Summary == Series 29564v2 drm/i915: implement NOA mux reprogramming at ctx-switch https://patchwork.freedesktop.org/api/1.0/serie

[Intel-gfx] ✓ Fi.CI.BAT: success for tests/gem_flink_basic: Add documentation for subtests (rev2)

2017-08-31 Thread Patchwork
== Series Details == Series: tests/gem_flink_basic: Add documentation for subtests (rev2) URL : https://patchwork.freedesktop.org/series/29499/ State : success == Summary == IGT patchset tested on top of latest successful build 5ce65a9a51f17e0183e3e4f8943981ee7b96cadd pm_rps: Changes in waitbo

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/4] drm/i915: Fix the missing PPAT cache attributes on CNL

2017-08-31 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Fix the missing PPAT cache attributes on CNL URL : https://patchwork.freedesktop.org/series/29625/ State : success == Summary == Test perf: Subgroup polling: fail -> PASS (shard-hsw) fdo#1022

Re: [Intel-gfx] [PATCH 00/13] mmu_notifier kill invalidate_page callback

2017-08-31 Thread Jerome Glisse
On Thu, Aug 31, 2017 at 07:19:19PM -0400, Felix Kuehling wrote: > On 2017-08-31 03:00 PM, Jerome Glisse wrote: > > I was not saying you should not use mmu_notifier. For achieving B you need > > mmu_notifier. Note that if you do like ODP/KVM then you do not need to > > pin page. > I would like that.

  1   2   >