Re: [Intel-gfx] [PATCH 10/10] drm/i915/cnl: Fix DP max rate for Cannonlake with port F.

2018-01-29 Thread Jani Nikula
On Mon, 29 Jan 2018, Rodrigo Vivi wrote: > On CNL SKUs that uses port F, max DP rate is 8.1G for all > ports when we have the elevated voltage (higher than 0.85V). > > v2: Make commit message more generic. > v3: Move conditions to a helper to get easier to read. (Ville). > v4: Add a mention to th

Re: [Intel-gfx] [PATCH v2] drm/i915/edp: Do not do link training fallback or prune modes on EDP

2018-01-29 Thread Jani Nikula
On Tue, 23 Jan 2018, Imre Deak wrote: > On Tue, Jan 23, 2018 at 11:48:22AM +0200, Jani Nikula wrote: >> On Mon, 22 Jan 2018, Imre Deak wrote: >> > On Fri, Jan 19, 2018 at 05:45:16PM +0200, Imre Deak wrote: >> >> On Thu, Oct 12, 2017 at 12:13:38PM -0700, Manasi Navare wrote: >> >> > In case of eDP

Re: [Intel-gfx] [PATCH v2] drm/i915: Check for fused or unused pipes

2018-01-29 Thread Jani Nikula
On Mon, 29 Jan 2018, Chris Wilson wrote: > Quoting Jani Nikula (2018-01-19 14:22:49) >> On Mon, 18 Dec 2017, Mika Kahola wrote: >> > We may have fused or unused pipes in our system. Let's check that the pipe >> > in question is within limits of accessible pipes. In case, that we are not >> > able

Re: [Intel-gfx] [PATCH 15/15] drm/i915: Add NV12 support to intel_framebuffer_init

2018-01-29 Thread Kumar, Mahesh
Hi, On 1/30/2018 9:35 AM, Srinivas, Vidya wrote: -Original Message- From: Maarten Lankhorst [mailto:maarten.lankho...@linux.intel.com] Sent: Monday, January 29, 2018 10:47 PM To: Srinivas, Vidya ; intel- g...@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH 15/15] drm/i915: Add NV

Re: [Intel-gfx] [PATCH 15/15] drm/i915: Add NV12 support to intel_framebuffer_init

2018-01-29 Thread Srinivas, Vidya
> -Original Message- > From: Maarten Lankhorst [mailto:maarten.lankho...@linux.intel.com] > Sent: Monday, January 29, 2018 5:12 PM > To: Srinivas, Vidya ; intel- > g...@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH 15/15] drm/i915: Add NV12 support to > intel_framebuffer_init >

Re: [Intel-gfx] [PATCH 15/15] drm/i915: Add NV12 support to intel_framebuffer_init

2018-01-29 Thread Srinivas, Vidya
> -Original Message- > From: Maarten Lankhorst [mailto:maarten.lankho...@linux.intel.com] > Sent: Monday, January 29, 2018 10:47 PM > To: Srinivas, Vidya ; intel- > g...@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH 15/15] drm/i915: Add NV12 support to > intel_framebuffer_init >

[Intel-gfx] ✗ Fi.CI.IGT: warning for series starting with [01/10] drm/i915/cnl: Add Cannonlake PCI IDs for another SKU.

2018-01-29 Thread Patchwork
== Series Details == Series: series starting with [01/10] drm/i915/cnl: Add Cannonlake PCI IDs for another SKU. URL : https://patchwork.freedesktop.org/series/37309/ State : warning == Summary == Test kms_frontbuffer_tracking: Subgroup fbc-1p-primscrn-pri-shrfb-draw-render:

Re: [Intel-gfx] [igt-dev] [PATCH igt] igt/prime_mmap_coherency: Close dmabuf after use

2018-01-29 Thread Antonio Argenziano
On 29/01/18 06:28, Chris Wilson wrote: As we loop over the coherency tests many times, we need to close the dmabufs opened on every pass to prevent a fd leak and the test exploding when it hits the process limit. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103649 Signed-off-by: Chri

Re: [Intel-gfx] [PATCH] drm/i915: Only allocate preempt context when required

2018-01-29 Thread Daniele Ceraolo Spurio
@@ -979,17 +979,19 @@ static int guc_clients_create(struct intel_guc *guc) } guc->execbuf_client = client; - client = guc_client_alloc(dev_priv, - INTEL_INFO(dev_priv)->ring_mask, - GUC_CLIENT_PRIORITY_KMD_HIGH,

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [01/10] drm/i915/cnl: Add Cannonlake PCI IDs for another SKU.

2018-01-29 Thread Patchwork
== Series Details == Series: series starting with [01/10] drm/i915/cnl: Add Cannonlake PCI IDs for another SKU. URL : https://patchwork.freedesktop.org/series/37309/ State : success == Summary == Series 37309v1 series starting with [01/10] drm/i915/cnl: Add Cannonlake PCI IDs for another SKU

Re: [Intel-gfx] [PATCH] drm/i915: Always run hangcheck while the GPU is busy

2018-01-29 Thread Antonio Argenziano
On 29/01/18 06:41, Chris Wilson wrote: Previously, we relied on only running the hangcheck while somebody was waiting on the GPU, in order to minimise the amount of time hangcheck had to run. (If nobody was watching the GPU, nobody would notice if the GPU wasn't responding -- eventually somebod

Re: [Intel-gfx] [PATCH 06/17] drm/i915/icl: Do not fix dbuf block size to 512

2018-01-29 Thread James Ausmus
On Mon, Jan 29, 2018 at 09:07:30PM -0200, Paulo Zanoni wrote: > From: Mahesh Kumar > > GEN9/10 had fixed DBuf block size of 512. Dbuf block size is not a > fixed number anymore in GEN11, it varies according to bits per pixel > and tiling. If 8bpp & Yf-tile surface, block size = 256 else block > s

[Intel-gfx] ✗ Fi.CI.BAT: failure for ICL display initialization and some plane bits (rev2)

2018-01-29 Thread Patchwork
== Series Details == Series: ICL display initialization and some plane bits (rev2) URL : https://patchwork.freedesktop.org/series/36993/ State : failure == Summary == Series 36993v2 ICL display initialization and some plane bits https://patchwork.freedesktop.org/api/1.0/series/36993/revisions/

[Intel-gfx] [PATCH 04/10] drm/i915/cnl: Fix _CNL_PORT_TX_DW2_LN0_F definition.

2018-01-29 Thread Rodrigo Vivi
This was wrong since its introduction on commit '04416108ccea ("drm/i915/cnl: Add registers related to voltage swing sequences.")' But since no Port F was needed so far we don't need to propagate fixes back there. Cc: Lucas De Marchi Cc: Manasi Navare Signed-off-by: Rodrigo Vivi Reviewed-by: D

[Intel-gfx] [PATCH 08/10] drm/i915/cnl: Add HPD support for Port F.

2018-01-29 Thread Rodrigo Vivi
On CNP boards that are using DDI F, bit 25 (SDE_PORTE_HOTPLUG_SPT) is representing the Digital Port F hotplug line when the Digital Port F hotplug detect input is enabled. v2: Reuse all existent structure instead of adding a new HPD_PORT_F pointing to pin of port E. v3: Use IS_CNL_WITH_PORT_F so w

[Intel-gfx] [PATCH 09/10] drm/i915/cnl: Enable DDI-F on Cannonlake.

2018-01-29 Thread Rodrigo Vivi
Now let's finish the Port-F support by adding the proper port F detection, irq and power well support. v2: Rebase v3: Use BIT_ULL v4: Cover missed case on ddi init. v5: Update commit message. v6: Rebase on top of display headers rework. v7: Squash power-well handling related to DDI F to this p

[Intel-gfx] [PATCH 10/10] drm/i915/cnl: Fix DP max rate for Cannonlake with port F.

2018-01-29 Thread Rodrigo Vivi
On CNL SKUs that uses port F, max DP rate is 8.1G for all ports when we have the elevated voltage (higher than 0.85V). v2: Make commit message more generic. v3: Move conditions to a helper to get easier to read. (Ville). v4: Add a mention to the numerical voltage on commit message per Manasi

[Intel-gfx] [PATCH 06/10] drm/i915/cnl: Add right GMBUS pin number for HDMI on Port F.

2018-01-29 Thread Rodrigo Vivi
On CNP Pin 3 is for misc of Port F usage depending on the configuration. For CNL that uses Port F, pin 3 is the one. v2: Make it more generic and update commit message. Cc: Anusha Srivatsa Cc: Lucas De Marchi Cc: Manasi Navare Signed-off-by: Rodrigo Vivi Reviewed-by: Paulo Zanoni --- driver

[Intel-gfx] [PATCH 02/10] drm/i915/cnl: Add AUX-F support

2018-01-29 Thread Rodrigo Vivi
On some Cannonlake SKUs we have a dedicated Aux for port F, that is only the full split between port A and port E. There is still no Aux E for Port E, as in previous platforms, because port_E still means shared lanes with port A. v2: Rebase. v3: Add couple missed PORT_F cases on intel_dp. v4: Reb

[Intel-gfx] [PATCH 07/10] drm/i915: For HPD connected port use hpd_pin instead of port.

2018-01-29 Thread Rodrigo Vivi
Let's try to simplify this mapping to hpd_pin -> bit instead using port. So for CNL with port F where we have this port using hdp_pin and bits of other ports we don't need to duplicated the mapping. But for now this is only a re-org with no functional change expected. v2: Add missing lines and nu

[Intel-gfx] [PATCH 05/10] drm/i915: Fix DPLCLKA_CFGCR0 bits for Port F.

2018-01-29 Thread Rodrigo Vivi
Since when it got introduced with commit '555e38d27317 ("drm/i915/cnl: DDI - PLL mapping")' the support for Port F was wrong, because Port F bits are far from bits used for A to E. Since Port F is not used so far we don't need to propagate Fixes back there. v2: Reuse _SHIFT definition to avoid co

[Intel-gfx] [PATCH 01/10] drm/i915/cnl: Add Cannonlake PCI IDs for another SKU.

2018-01-29 Thread Rodrigo Vivi
The only difference is that this SKUs has the full Port A/E split named as Port F. But since SKUs differences don't matter on the platform definition group and ids, let's merge all off them together. v2: Really include the PCI IDs to the picidlist[]; v3: Add the PCI Id for another SKU (Anusha). v

[Intel-gfx] [PATCH 03/10] drm/i915/cnl: Extend Wa 1178 to Aux F.

2018-01-29 Thread Rodrigo Vivi
We also need to extend this WA to Aux F. Cc: Dhinakaran Pandiyan Cc: Lucas De Marchi Signed-off-by: Rodrigo Vivi Reviewed-by: Lucas De Marchi --- drivers/gpu/drm/i915/i915_reg.h | 4 +++- drivers/gpu/drm/i915/intel_runtime_pm.c | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-)

[Intel-gfx] [PATCH 07/13] drm/i915/icl: Fail flip if ddb allocated are less than min display buffer needed

2018-01-29 Thread Paulo Zanoni
From: Mahesh Kumar ICL require DDB allocation of plane to be more than "minimum display buffer needed" for each level in order to enable WM level. This patch implements and consider the same while allocating DDB and enabling WM. Changes Since V1: - rebase Changes Since V2: - Remove extra pare

[Intel-gfx] [PATCH 06/17] drm/i915/icl: Do not fix dbuf block size to 512

2018-01-29 Thread Paulo Zanoni
From: Mahesh Kumar GEN9/10 had fixed DBuf block size of 512. Dbuf block size is not a fixed number anymore in GEN11, it varies according to bits per pixel and tiling. If 8bpp & Yf-tile surface, block size = 256 else block size = 512 This patch addresses the same. v2 (from Paulo): - Make it co

Re: [Intel-gfx] [PATCH 16/17] drm/i915/icl: enable SAGV for ICL platform

2018-01-29 Thread Paulo Zanoni
Em Ter, 2018-01-23 às 17:05 -0200, Paulo Zanoni escreveu: > From: Mahesh Kumar > > Enable SAGV for ICL platform. The requirements for enabling SAGV on ICL are different. We need to implement them. While we don't have them, perhaps the best option is to add ICL to intel_has_sagv() but then always

Re: [Intel-gfx] [PATCH] drm/i915/cnp: Properly handle VBT ddc pin out of bounds.

2018-01-29 Thread Rodrigo Vivi
On Mon, Jan 29, 2018 at 05:42:53AM +, Kai Heng Feng wrote: > > > On 26 Jan 2018, at 6:25 AM, Rodrigo Vivi wrote: > > > > If the table result is out of bounds on the array map > > there is something really wrong with VBT pin so we don't > > return that vbt_pin, but only return 0 instead. > >

Re: [Intel-gfx] [PATCH] drm/i915/cnl: Enable DDI-F on Cannonlake.

2018-01-29 Thread Pandiyan, Dhinakaran
On Fri, 2018-01-26 at 17:33 -0800, Rodrigo Vivi wrote: > Now let's finish the Port-F support by adding the > proper port F detection, irq and power well support. > > v2: Rebase > v3: Use BIT_ULL > v4: Cover missed case on ddi init. > v5: Update commit message. > v6: Rebase on top of display hea

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: expose RCS topology to userspace

2018-01-29 Thread Patchwork
== Series Details == Series: drm/i915: expose RCS topology to userspace URL : https://patchwork.freedesktop.org/series/37290/ State : failure == Summary == Test gem_gpgpu_fill: pass -> FAIL (shard-hsw) pass -> FAIL (shard-apl) Test kms_fl

Re: [Intel-gfx] [PATCH] drm/i915: Remove Firmware URL.

2018-01-29 Thread Rodrigo Vivi
On Mon, Jan 29, 2018 at 08:45:24PM +, Chris Wilson wrote: > Quoting Srivatsa, Anusha (2018-01-29 20:17:25) > > > > > > >-Original Message- > > >From: Vivi, Rodrigo > > >Sent: Friday, January 26, 2018 10:22 AM > > >To: intel-gfx@lists.freedesktop.org > > >Cc: Vivi, Rodrigo ; Srivatsa,

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915: Free memdup-ed bios data structures on driver_unload

2018-01-29 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Free memdup-ed bios data structures on driver_unload URL : https://patchwork.freedesktop.org/series/37282/ State : failure == Summary == Test kms_frontbuffer_tracking: Subgroup fbc-rgb565-draw-mmap-cpu:

Re: [Intel-gfx] [PATCH] drm/i915: Simplify guard logic for setup_scratch_page()

2018-01-29 Thread Chris Wilson
Quoting Matthew Auld (2018-01-29 10:54:35) > On 29 January 2018 at 10:28, Chris Wilson wrote: > > Older gcc is complaining it can't follow the guards and thinks that > > addr may be used uninitialised > > > > In the process, we can simplify down to one loop, > > add/remove: 0/0 grow/shrink: 0/1 up

Re: [Intel-gfx] [PATCH] drm/i915: Assert the engine has finished the seqno on unsubmission

2018-01-29 Thread Chris Wilson
Quoting Michał Winiarski (2018-01-29 11:10:42) > On Mon, Jan 29, 2018 at 09:49:12AM +, Chris Wilson wrote: > > Assert that we do not try to unsubmit a completed request, as should we > > try to resubmit it later, the ring is already past the request's > > breadcrumb and the breadcrumb will not

Re: [Intel-gfx] [PATCH] drm/i915: Remove Firmware URL.

2018-01-29 Thread Chris Wilson
Quoting Srivatsa, Anusha (2018-01-29 20:17:25) > > > >-Original Message- > >From: Vivi, Rodrigo > >Sent: Friday, January 26, 2018 10:22 AM > >To: intel-gfx@lists.freedesktop.org > >Cc: Vivi, Rodrigo ; Srivatsa, Anusha > > > >Subject: [PATCH] drm/i915: Remove Firmware URL. > > > >The right

Re: [Intel-gfx] [PATCH v2] drm/i915: Check for fused or unused pipes

2018-01-29 Thread Chris Wilson
Quoting Jani Nikula (2018-01-19 14:22:49) > On Mon, 18 Dec 2017, Mika Kahola wrote: > > We may have fused or unused pipes in our system. Let's check that the pipe > > in question is within limits of accessible pipes. In case, that we are not > > able to access the pipe, we return early with a warn

Re: [Intel-gfx] [PATCH] drm/i915/cnl: Add AUX-F support

2018-01-29 Thread Pandiyan, Dhinakaran
On Fri, 2018-01-26 at 17:27 -0800, Rodrigo Vivi wrote: > On some Cannonlake SKUs we have a dedicated Aux for port F, > that is only the full split between port A and port E. > > There is still no Aux E for Port E, as in previous platforms, > because port_E still means shared lanes with port A. >

Re: [Intel-gfx] [PATCH 01/10] drm/i915/cnl: Add Cannonlake PCI IDs for another SKU.

2018-01-29 Thread Jani Nikula
On Mon, 29 Jan 2018, "Pandiyan, Dhinakaran" wrote: > On Sat, 2018-01-27 at 11:05 +0200, Jani Nikula wrote: >> On Fri, 26 Jan 2018, Rodrigo Vivi wrote: >> > On Fri, Jan 26, 2018 at 10:12:00AM +, Jani Nikula wrote: >> >> On Thu, 25 Jan 2018, Rodrigo Vivi wrote: >> >> > The only difference is

Re: [Intel-gfx] [PATCH] drm/i915: Remove Firmware URL.

2018-01-29 Thread Srivatsa, Anusha
>-Original Message- >From: Vivi, Rodrigo >Sent: Friday, January 26, 2018 10:22 AM >To: intel-gfx@lists.freedesktop.org >Cc: Vivi, Rodrigo ; Srivatsa, Anusha > >Subject: [PATCH] drm/i915: Remove Firmware URL. > >The right place for the firmware is linux-firmware.git. >We shouldn't advertis

Re: [Intel-gfx] [PATCH 00/10] drm/uapi: Validate mode flags/type, and deprecate some of them

2018-01-29 Thread Ville Syrjälä
On Tue, Nov 14, 2017 at 08:32:48PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > I recently realized that we're not validating the mode flags/type > passed in from userspace. Let's try to fix that. > > I'd also like to entirely eliminate some of the more crazy mode flags. > PIXMUX and BC

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915: Add display WA #1175 for planes ending close to right screen edge

2018-01-29 Thread Ville Syrjälä
On Tue, Jan 16, 2018 at 01:24:14PM +0200, Imre Deak wrote: > As described in the WA on GLK and CNL planes on the right edge of the > screen that have less than 4 pixels visible from the beginning of the > plane to the edge of the screen can cause FIFO underflow and display > corruption. > > On GLK

[Intel-gfx] ✗ Fi.CI.IGT: warning for drm/i915: Tracking waiters for execution wrt hangcheck

2018-01-29 Thread Patchwork
== Series Details == Series: drm/i915: Tracking waiters for execution wrt hangcheck URL : https://patchwork.freedesktop.org/series/37276/ State : warning == Summary == Test kms_frontbuffer_tracking: Subgroup fbc-1p-shrfb-fliptrack: fail -> PASS (shard-apl) f

[Intel-gfx] [PULL] Backlight helpers from tinydrm

2018-01-29 Thread Sean Paul
Hi Lee, Here's the pull request for Meghana's patch set. It's based on 4.15, and just contains the backlight portion of the set. I couldn't include the rest as it depends on patches that only exist in drm-misc-next atm. Thanks for coordinating with me on this! topic/backlight_for_lag-2018-01-29

Re: [Intel-gfx] [PATCH 01/10] drm/i915/cnl: Add Cannonlake PCI IDs for another SKU.

2018-01-29 Thread Pandiyan, Dhinakaran
On Sat, 2018-01-27 at 11:05 +0200, Jani Nikula wrote: > On Fri, 26 Jan 2018, Rodrigo Vivi wrote: > > On Fri, Jan 26, 2018 at 10:12:00AM +, Jani Nikula wrote: > >> On Thu, 25 Jan 2018, Rodrigo Vivi wrote: > >> > The only difference is that this SKUs has the full > >> > Port A/E split named

Re: [Intel-gfx] [PATCH] drm/i915: Fix Limited Range Color Handling

2018-01-29 Thread Ville Syrjälä
On Fri, Dec 29, 2017 at 08:29:11PM +0530, Uma Shankar wrote: > From: Johnson Lin > > Some panels support limited range output (16-235) compared > to full range RGB values (0-255). Also userspace can control > the RGB range using "Broadcast RGB" property. Currently the > code to handle full range

Re: [Intel-gfx] [PATCH 07/17] drm/i915/icl: Fail flip if ddb allocated are less than min display buffer needed

2018-01-29 Thread Paulo Zanoni
Em Sex, 2018-01-26 às 15:50 -0800, James Ausmus escreveu: > On Tue, Jan 23, 2018 at 05:05:26PM -0200, Paulo Zanoni wrote: > > From: Mahesh Kumar > > > > ICL require DDB allocation of plane to be more than "minimum > > display > > buffer needed" for each level in order to enable WM level. > > > >

Re: [Intel-gfx] [PATCH 04/17] drm/i915/icl: Enable both DBuf slices during init

2018-01-29 Thread Paulo Zanoni
Em Sex, 2018-01-26 às 18:50 -0200, Paulo Zanoni escreveu: > Em Ter, 2018-01-23 às 16:49 -0800, James Ausmus escreveu: > > On Tue, Jan 23, 2018 at 05:05:23PM -0200, Paulo Zanoni wrote: > > > From: Mahesh Kumar > > > > > > ICL has 2 slices of DBuf, enable both the slices during display > > > init.

Re: [Intel-gfx] [PATCH] drm/i915: Only allocate preempt context when required

2018-01-29 Thread Daniele Ceraolo Spurio
On 27/01/18 12:28, Chris Wilson wrote: If we remove some hardcoded assumptions about the preempt context having a fixed id, reserved from use by normal user contexts, we may only allocate the i915_gem_context when required. Then the subsequent decisions on using preemption reduce to having the

Re: [Intel-gfx] [PATCH v3] drm: Warn if plane/crtc/encoder/connector index exceeds our 32bit bitmasks

2018-01-29 Thread Ville Syrjälä
On Thu, Jan 25, 2018 at 10:12:52AM -0500, Harry Wentland wrote: > On 2018-01-25 08:30 AM, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > We use 32bit bitmasks to track planes/crtcs/encoders/connectors. > > Naturally we can only do that if the index of those objects stays > > below 32. Issue

Re: [Intel-gfx] [PATCH 15/15] drm/i915: Add NV12 support to intel_framebuffer_init

2018-01-29 Thread Maarten Lankhorst
Op 20-01-18 om 22:45 schreef Vidya Srinivas: > From: Chandra Konduru > > This patch adds NV12 as supported format > to intel_framebuffer_init and performs various checks. > > v2: > -Fix an issue in checks added (Chandra Konduru) > > v3: rebased (me) > > v4: Review comments by Ville addressed > Add

Re: [Intel-gfx] [PATCH] drm/i915: Remove unused IRQ chip data of HDMI LPE audio

2018-01-29 Thread Ville Syrjälä
On Wed, Dec 13, 2017 at 03:06:55PM +0100, Thomas Gleixner wrote: > On Wed, 13 Dec 2017, Takashi Iwai wrote: > > On Wed, 13 Dec 2017 12:35:54 +0100, > > Thomas Gleixner wrote: > > > > > > > > On Mon, 11 Dec 2017, Anand, Jerome wrote: > > > > > > > On Fri, 8 Dec 2017, Ville Syrjälä wrote: > > > > >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: expose RCS topology to userspace

2018-01-29 Thread Patchwork
== Series Details == Series: drm/i915: expose RCS topology to userspace URL : https://patchwork.freedesktop.org/series/37290/ State : success == Summary == Series 37290v1 drm/i915: expose RCS topology to userspace https://patchwork.freedesktop.org/api/1.0/series/37290/revisions/1/mbox/ Test d

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm: Warn if plane/crtc/encoder/connector index exceeds our 32bit bitmasks (rev3)

2018-01-29 Thread Ville Syrjälä
On Thu, Jan 25, 2018 at 03:17:21PM -, Patchwork wrote: > == Series Details == > > Series: drm: Warn if plane/crtc/encoder/connector index exceeds our 32bit > bitmasks (rev3) > URL : https://patchwork.freedesktop.org/series/37058/ > State : failure > > == Summary == > > Test drv_suspend: >

[Intel-gfx] [PATCH v12 7/8] RFC: drm/i915: expose chipset/driver properties through query uAPI

2018-01-29 Thread Lionel Landwerlin
The purpose of this is to give the ability to userspace to query a bunch of properties in 1 ioctl rather than a series of successive GETPARAM ioctl(). This loosely divides the properties in 2 groups, one being hardware focused and the other being rather driver features. The structures defined in

[Intel-gfx] [PATCH v12 6/8] drm/i915: expose rcs topology through query uAPI

2018-01-29 Thread Lionel Landwerlin
With the introduction of asymmetric slices in CNL, we cannot rely on the previous SUBSLICE_MASK getparam to tell userspace what subslices are available. Here we introduce a more detailed way of querying the Gen's GPU topology that doesn't aggregate numbers. This is essential for monitoring parts o

[Intel-gfx] [PATCH v12 3/8] drm/i915/debugfs: add rcs topology entry

2018-01-29 Thread Lionel Landwerlin
While the end goal is to make this information available to userspace through a new ioctl, there is no reason we can't display it in a human readable fashion through debugfs. slice0: 3 subslice(s) (0x7): subslice0: 8 EUs (0xff) subslice1: 8 EUs (0xff) subslice2: 8 EUs (0xff

[Intel-gfx] [PATCH v12 4/8] drm/i915: add rcs topology to error state

2018-01-29 Thread Lionel Landwerlin
This might be useful information for developers looking at an error state. v2: Place topology towards the end of the error state (Chris) v3: Reuse common printing code (Michal) v4: Make this a one-liner (Chris) Signed-off-by: Lionel Landwerlin Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/

[Intel-gfx] [PATCH v12 1/8] drm/i915: store all subslice masks

2018-01-29 Thread Lionel Landwerlin
Up to now, subslice mask was assumed to be uniform across slices. But starting with Cannonlake, slices can be asymmetric (for example slice0 has different number of subslices as slice1+). This change stores all subslices masks for all slices rather than having a single mask that applies to all slic

[Intel-gfx] [PATCH v12 5/8] drm/i915: add query uAPI

2018-01-29 Thread Lionel Landwerlin
There are a number of information that are readable from hardware registers and that we would like to make accessible to userspace. One particular example is the topology of the execution units (how are execution units grouped in subslices and slices and also which ones have been fused off for die

[Intel-gfx] [PATCH v12 2/8] drm/i915/debugfs: reuse max slice/subslices already stored in sseu

2018-01-29 Thread Lionel Landwerlin
Now that we have that information in topology fields, let's just reused it. v2: Style tweaks (Tvrtko) Signed-off-by: Lionel Landwerlin Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_debugfs.c | 27 +++ 1 file changed, 11 insertions(+), 16 deletions(-) diff -

[Intel-gfx] [PATCH v12 8/8] RFC: drm/i915: reuse new chipset/driver query in getparam

2018-01-29 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- drivers/gpu/drm/i915/i915_drv.c | 212 ++-- 1 file changed, 119 insertions(+), 93 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index ebb2e4241cf7..cc0342e8a400 100644 --- a/dri

[Intel-gfx] [PATCH v12 0/8] drm/i915: expose RCS topology to userspace

2018-01-29 Thread Lionel Landwerlin
Hi, There is almost no changes from the previous series. I just put the i915_query_ioctl() declaration in its own header file (like Joonas suggested, if I remember correctly). Adding a couple of patches for discussion on how to have a userspace query all of the information it needs from the devic

[Intel-gfx] ✗ Fi.CI.IGT: warning for drm/i915: Simplify guard logic for setup_scratch_page()

2018-01-29 Thread Patchwork
== Series Details == Series: drm/i915: Simplify guard logic for setup_scratch_page() URL : https://patchwork.freedesktop.org/series/37265/ State : warning == Summary == Test kms_frontbuffer_tracking: Subgroup fbc-suspend: skip -> PASS (shard-snb) fdo#101623

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Assert the engine has finished the seqno on unsubmission

2018-01-29 Thread Patchwork
== Series Details == Series: drm/i915: Assert the engine has finished the seqno on unsubmission URL : https://patchwork.freedesktop.org/series/37263/ State : failure == Summary == Test syncobj_wait: Subgroup wait-any-snapshot: fail -> PASS (shard-apl) Test p

Re: [Intel-gfx] [PATCH v11 5/6] drm/i915: add query uAPI

2018-01-29 Thread Lionel Landwerlin
On 24/01/18 15:14, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-01-24 12:03:46) On 23/01/2018 14:17, Lionel Landwerlin wrote: Hi all, I've been trying to expose some information to userspace about the fused parts of the GPU. This is the 4th attempt at getting this upstream, here are the pr

Re: [Intel-gfx] [PATCH] drm/atomic: Fix memleak on ERESTARTSYS during non-blocking commits

2018-01-29 Thread Leo Li
Updated IGT results seem sane: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7698/shards.html Would someone be able to apply this patch? Thanks, Leo On 2018-01-17 03:18 PM, Sean Paul wrote: On Wed, Jan 17, 2018 at 10:39 AM, Maarten Lankhorst wrote: Op 17-01-18 om 19:29 schreef Sean Paul

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Free memdup-ed bios data structures on driver_unload

2018-01-29 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Free memdup-ed bios data structures on driver_unload URL : https://patchwork.freedesktop.org/series/37282/ State : success == Summary == Series 37282v1 series starting with [1/2] drm/i915: Free memdup-ed bios data structures o

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Always run hangcheck while the GPU is busy

2018-01-29 Thread Patchwork
== Series Details == Series: drm/i915: Always run hangcheck while the GPU is busy URL : https://patchwork.freedesktop.org/series/37281/ State : success == Summary == Series 37281v1 drm/i915: Always run hangcheck while the GPU is busy https://patchwork.freedesktop.org/api/1.0/series/37281/revis

[Intel-gfx] [PATCH 2/2] drm/i915: Fix DSI panels with v1 MIPI sequences without a DEASSERT sequence v3

2018-01-29 Thread Hans de Goede
So far models of the Dell Venue 8 Pro, with a panel with MIPI panel index = 3, one of which has been kindly provided to me by Jan Brummer, where not working with the i915 driver, giving a black screen on the first modeset. The problem with at least these Dells is that their VBT defines a MIPI ASSE

[Intel-gfx] [PATCH 1/2] drm/i915: Free memdup-ed bios data structures on driver_unload

2018-01-29 Thread Hans de Goede
Add a new intel_bios_cleanup function to free memdup-ed bios data structures and call it from i915_driver_unload(). Signed-off-by: Hans de Goede --- drivers/gpu/drm/i915/i915_drv.c | 2 ++ drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/intel_bios.c | 11 +++ 3 files ch

[Intel-gfx] [PATCH] drm/i915: Always run hangcheck while the GPU is busy

2018-01-29 Thread Chris Wilson
Previously, we relied on only running the hangcheck while somebody was waiting on the GPU, in order to minimise the amount of time hangcheck had to run. (If nobody was watching the GPU, nobody would notice if the GPU wasn't responding -- eventually somebody would care and so kick hangcheck into act

[Intel-gfx] [PATCH igt] igt/prime_mmap_coherency: Close dmabuf after use

2018-01-29 Thread Chris Wilson
As we loop over the coherency tests many times, we need to close the dmabufs opened on every pass to prevent a fd leak and the test exploding when it hits the process limit. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103649 Signed-off-by: Chris Wilson --- tests/prime_mmap_coherency.c

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Tracking waiters for execution wrt hangcheck

2018-01-29 Thread Patchwork
== Series Details == Series: drm/i915: Tracking waiters for execution wrt hangcheck URL : https://patchwork.freedesktop.org/series/37276/ State : success == Summary == Series 37276v1 drm/i915: Tracking waiters for execution wrt hangcheck https://patchwork.freedesktop.org/api/1.0/series/37276/r

Re: [Intel-gfx] [PATCH] drm/i915: Tracking waiters for execution wrt hangcheck

2018-01-29 Thread Chris Wilson
Quoting Chris Wilson (2018-01-29 13:50:13) > Hangcheck wants to turn itself off when no one is listening (to save > needless wakeups). However, we now may have waiters that are not waiting > for requests already on the GPU, but waiting for requests deep in the > queue for execution, and do not have

[Intel-gfx] [PATCH] drm/i915: Tracking waiters for execution wrt hangcheck

2018-01-29 Thread Chris Wilson
Hangcheck wants to turn itself off when no one is listening (to save needless wakeups). However, we now may have waiters that are not waiting for requests already on the GPU, but waiting for requests deep in the queue for execution, and do not have an irq alloted. Therefore, inside hangcheck we can

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Simplify guard logic for setup_scratch_page()

2018-01-29 Thread Patchwork
== Series Details == Series: drm/i915: Simplify guard logic for setup_scratch_page() URL : https://patchwork.freedesktop.org/series/37265/ State : success == Summary == Series 37265v1 drm/i915: Simplify guard logic for setup_scratch_page() https://patchwork.freedesktop.org/api/1.0/series/37265

Re: [Intel-gfx] [PATCH 15/15] drm/i915: Add NV12 support to intel_framebuffer_init

2018-01-29 Thread Maarten Lankhorst
Op 20-01-18 om 22:45 schreef Vidya Srinivas: > From: Chandra Konduru > > This patch adds NV12 as supported format > to intel_framebuffer_init and performs various checks. > > v2: > -Fix an issue in checks added (Chandra Konduru) > > v3: rebased (me) > > v4: Review comments by Ville addressed > Add

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Assert the engine has finished the seqno on unsubmission

2018-01-29 Thread Patchwork
== Series Details == Series: drm/i915: Assert the engine has finished the seqno on unsubmission URL : https://patchwork.freedesktop.org/series/37263/ State : success == Summary == Series 37263v1 drm/i915: Assert the engine has finished the seqno on unsubmission https://patchwork.freedesktop.o

Re: [Intel-gfx] [PATCH] drm/i915: Assert the engine has finished the seqno on unsubmission

2018-01-29 Thread Michał Winiarski
On Mon, Jan 29, 2018 at 09:49:12AM +, Chris Wilson wrote: > Assert that we do not try to unsubmit a completed request, as should we > try to resubmit it later, the ring is already past the request's > breadcrumb and the breadcrumb will not be updated. "Assert that we do not try to unsubmit a c

Re: [Intel-gfx] [PATCH] drm/i915: Simplify guard logic for setup_scratch_page()

2018-01-29 Thread Matthew Auld
On 29 January 2018 at 10:28, Chris Wilson wrote: > Older gcc is complaining it can't follow the guards and thinks that > addr may be used uninitialised > > In the process, we can simplify down to one loop, > add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-131 (-131) > Function

Re: [Intel-gfx] [PATCH 01/17] drm/i915/icl: add the main CDCLK functions

2018-01-29 Thread Imre Deak
On Tue, Jan 23, 2018 at 05:05:20PM -0200, Paulo Zanoni wrote: > This commit adds the basic CDCLK functions, but it's still missing > pieces of the display initialization sequence. > > v2: > - Implement the voltage levels. > - Rebase. > > Signed-off-by: Paulo Zanoni > --- > drivers/gpu/drm/i91

Re: [Intel-gfx] [PATCH] Revert "drm/i915: mark all device info struct with __initconst"

2018-01-29 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-01-29 10:34:05) > > On 29/01/2018 09:00, Chris Wilson wrote: > > Quoting Lionel Landwerlin (2018-01-29 08:33:46) > >> This reverts commit 5b54eddd3920e9f6f1a6d972454baf350cbae77e. > >> > >> Conflicts: > >> drivers/gpu/drm/i915/i915_pci.c > >> > >> Bugzilla:

Re: [Intel-gfx] [PATCH] Revert "drm/i915: mark all device info struct with __initconst"

2018-01-29 Thread Tvrtko Ursulin
On 29/01/2018 09:00, Chris Wilson wrote: Quoting Lionel Landwerlin (2018-01-29 08:33:46) This reverts commit 5b54eddd3920e9f6f1a6d972454baf350cbae77e. Conflicts: drivers/gpu/drm/i915/i915_pci.c Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104805 Signed-off-by: Lionel Land

[Intel-gfx] ✗ Fi.CI.IGT: failure for Revert "drm/i915: mark all device info struct with __initconst"

2018-01-29 Thread Patchwork
== Series Details == Series: Revert "drm/i915: mark all device info struct with __initconst" URL : https://patchwork.freedesktop.org/series/37260/ State : failure == Summary == Warning: bzip CI_DRM_3686/shard-glkb6/results14.json.bz2 wasn't in correct JSON format Test kms_sysfs_edid_timing:

Re: [Intel-gfx] [PATCH] drm/i915: Simplify guard logic for setup_scratch_page()

2018-01-29 Thread Chris Wilson
Quoting Chris Wilson (2018-01-29 10:28:40) > Older gcc is complaining it can't follow the guards and thinks that > addr may be used uninitialised > > In the process, we can simplify down to one loop, > add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-131 (-131) > Function

[Intel-gfx] [PATCH] drm/i915: Simplify guard logic for setup_scratch_page()

2018-01-29 Thread Chris Wilson
Older gcc is complaining it can't follow the guards and thinks that addr may be used uninitialised In the process, we can simplify down to one loop, add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-131 (-131) Function old new delta setup_scratch_page

Re: [Intel-gfx] [PATCH] Revert "drm/i915: mark all device info struct with __initconst"

2018-01-29 Thread Lukas Wunner
On Mon, Jan 29, 2018 at 09:27:39AM +, Lionel Landwerlin wrote: > On 29/01/18 09:02, Chris Wilson wrote: > > Quoting Lionel Landwerlin (2018-01-29 08:33:46) > > > This reverts commit 5b54eddd3920e9f6f1a6d972454baf350cbae77e. > > > > > > Conflicts: > > > drivers/gpu/drm/i915/i915_pci.

Re: [Intel-gfx] [PATCH] Revert "drm/i915: mark all device info struct with __initconst"

2018-01-29 Thread Jani Nikula
On Mon, 29 Jan 2018, Lionel Landwerlin wrote: > On 29/01/18 09:02, Chris Wilson wrote: >> Quoting Lionel Landwerlin (2018-01-29 08:33:46) >>> This reverts commit 5b54eddd3920e9f6f1a6d972454baf350cbae77e. >>> >>> Conflicts: >>> drivers/gpu/drm/i915/i915_pci.c >>> >>> Bugzilla: https://bu

Re: [Intel-gfx] [PATCH] drm/i915: Assert the engine has finished the seqno on unsubmission

2018-01-29 Thread Chris Wilson
s/has/has not/ Quoting Chris Wilson (2018-01-29 09:49:12) > Assert that we do not try to unsubmit a completed request, as should we > try to resubmit it later, the ring is already past the request's > breadcrumb and the breadcrumb will not be updated. > > Signed-off-by: Chris Wilson > --- > dri

[Intel-gfx] [PATCH] drm/i915: Assert the engine has finished the seqno on unsubmission

2018-01-29 Thread Chris Wilson
Assert that we do not try to unsubmit a completed request, as should we try to resubmit it later, the ring is already past the request's breadcrumb and the breadcrumb will not be updated. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_request.c | 2 ++ 1 file changed, 2 insertions

Re: [Intel-gfx] [PATCH] Revert "drm/i915: mark all device info struct with __initconst"

2018-01-29 Thread Lionel Landwerlin
On 29/01/18 09:02, Chris Wilson wrote: Quoting Lionel Landwerlin (2018-01-29 08:33:46) This reverts commit 5b54eddd3920e9f6f1a6d972454baf350cbae77e. Conflicts: drivers/gpu/drm/i915/i915_pci.c Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104805 Fixes: 5b54eddd3920 ("drm/i9

Re: [Intel-gfx] [Bug 104805] regression in 4.15 unable to reboot/poweroff, vgaswitcheroo doesn't work, RIP: 0010:i915_pci_probe+0x11/0x70 [i915]

2018-01-29 Thread Chris Murphy
On Sun, Jan 28, 2018 at 2:37 PM, Lukas Wunner wrote: > On Sat, Jan 27, 2018 at 10:42:45AM +, bugzilla-dae...@freedesktop.org > wrote: >> https://bugs.freedesktop.org/show_bug.cgi?id=104805 >> >> --- Comment #6 from Chris Wilson --- >> Sigh. Revert then solve the bloat another way. I think we

Re: [Intel-gfx] [PATCH] Revert "drm/i915: mark all device info struct with __initconst"

2018-01-29 Thread Chris Wilson
Quoting Lionel Landwerlin (2018-01-29 08:33:46) > This reverts commit 5b54eddd3920e9f6f1a6d972454baf350cbae77e. > > Conflicts: > drivers/gpu/drm/i915/i915_pci.c > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104805 Fixes: 5b54eddd3920 ("drm/i915: mark all device info struct w

Re: [Intel-gfx] [PATCH] Revert "drm/i915: mark all device info struct with __initconst"

2018-01-29 Thread Chris Wilson
Quoting Lionel Landwerlin (2018-01-29 08:33:46) > This reverts commit 5b54eddd3920e9f6f1a6d972454baf350cbae77e. > > Conflicts: > drivers/gpu/drm/i915/i915_pci.c > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104805 > Signed-off-by: Lionel Landwerlin Mea culpa, completely di

[Intel-gfx] ✓ Fi.CI.BAT: success for Revert "drm/i915: mark all device info struct with __initconst"

2018-01-29 Thread Patchwork
== Series Details == Series: Revert "drm/i915: mark all device info struct with __initconst" URL : https://patchwork.freedesktop.org/series/37260/ State : success == Summary == Series 37260v1 Revert "drm/i915: mark all device info struct with __initconst" https://patchwork.freedesktop.org/api/

[Intel-gfx] [PATCH] Revert "drm/i915: mark all device info struct with __initconst"

2018-01-29 Thread Lionel Landwerlin
This reverts commit 5b54eddd3920e9f6f1a6d972454baf350cbae77e. Conflicts: drivers/gpu/drm/i915/i915_pci.c Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104805 Signed-off-by: Lionel Landwerlin --- drivers/gpu/drm/i915/i915_pci.c | 96 - 1

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Enable debugobjects for request validation (rev2)

2018-01-29 Thread Patchwork
== Series Details == Series: drm/i915: Enable debugobjects for request validation (rev2) URL : https://patchwork.freedesktop.org/series/37240/ State : failure == Summary == Warning: bzip CI_DRM_3686/shard-glkb6/results14.json.bz2 wasn't in correct JSON format Test gem_exec_schedule: S