Re: [Intel-gfx] [PATCH 2/2] drm/i915: Make MG phy macros semantically consistent

2019-02-13 Thread Lucas De Marchi
On Tue, Feb 12, 2019 at 3:57 PM Manasi Navare wrote: > > On Mon, Jan 28, 2019 at 02:00:12PM -0800, Aditya Swarup wrote: > > Macros to be organized semantically by dword, lane and > > port(in this order). > > > > Cc: Clint Taylor > > Cc: Imre Deak > > Cc: Jani Nikula > > Signed-off-by: Aditya Sw

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Move dsc rate params compute into drm

2019-02-13 Thread kbuild test robot
Hi David, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.0-rc4 next-20190213] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci

[Intel-gfx] [PATCH v3 4/6] drm/i915: Watchdog timeout: DRM kernel interface to set the timeout

2019-02-13 Thread Carlos Santa
From: Michel Thierry Final enablement patch for GPU hang detection using watchdog timeout. Using the gem_context_setparam ioctl, users can specify the desired timeout value in microseconds, and the driver will do the conversion to 'timestamps'. The recommended default watchdog threshold for vide

[Intel-gfx] [PATCH v3 3/6] drm/i915: Watchdog timeout: Ringbuffer command emission for gen8+

2019-02-13 Thread Carlos Santa
From: Michel Thierry Emit the required commands into the ring buffer for starting and stopping the watchdog timer before/after batch buffer start during batch buffer submission. v2: Support watchdog threshold per context engine, merge lri commands, and move watchdog commands emission to emit_bb_

[Intel-gfx] [PATCH v3 2/6] drm/i915: Watchdog timeout: IRQ handler for gen8+

2019-02-13 Thread Carlos Santa
From: Michel Thierry *** General *** Watchdog timeout (or "media engine reset") is a feature that allows userland applications to enable hang detection on individual batch buffers. The detection mechanism itself is mostly bound to the hardware and the only thing that the driver needs to do to su

[Intel-gfx] [PATCH v3 6/6] drm/i915: Watchdog timeout: Blindly trust watchdog timeout for reset?

2019-02-13 Thread Carlos Santa
From: Michel Thierry XXX: What to do when the watchdog irq fired twice but our hangcheck logic thinks the engine is not hung? For example, what if the active-head moved since the irq handler? One option is to just ignore the watchdog, if the engine is really hung, then the driver will detect the

[Intel-gfx] [PATCH v3 0/6] GEN8+ GPU Watchdog Reset Support

2019-02-13 Thread Carlos Santa
This is a rebased on the original patch series from Michel Thierry that can be found here: https://patchwork.freedesktop.org/series/21868 Note that this series is only limited to the GPU Watchdog timeout for execlists as it leaves out support for GuC based submission for a later time. PATCH v3 o

[Intel-gfx] [PATCH v3 1/6] drm/i915: Add engine reset count in get-reset-stats ioctl

2019-02-13 Thread Carlos Santa
From: Michel Thierry Users/tests relying on the total reset count will start seeing a smaller number since most of the hangs can be handled by engine reset. Note that if reset engine x, context a running on engine y will be unaware and unaffected. To start the discussion, include just a total en

[Intel-gfx] [PATCH v3 5/6] drm/i915: Watchdog timeout: Include threshold value in error state

2019-02-13 Thread Carlos Santa
From: Michel Thierry Save the watchdog threshold (in us) as part of the engine state. v2: Only do it for gen8+ (and prevent a missing-case warn). v3: use ctx->__engine. v4: Rebase. v5: Rebase. Cc: Antonio Argenziano Cc: Tvrtko Ursulin Signed-off-by: Michel Thierry Signed-off-by: Carlos Santa

[Intel-gfx] [PATCH 4/4] drm/i915: Enable PSR2 by default

2019-02-13 Thread José Roberto de Souza
The support for PSR2 was polished, IGT tests for PSR2 was added and it was tested performing regular user workloads like browsing, editing documents and compiling Linux, so it is time to enable it by default and enjoy even more power-savings. Cc: Rodrigo Vivi Cc: Dhinakaran Pandiyan Signed-off-b

[Intel-gfx] [PATCH 2/4] drm/i915: Disable PSR2 while getting pipe CRC

2019-02-13 Thread José Roberto de Souza
As stated in CRC_CTL spec, after PSR entry state CRC will not be calculated anymore what is not a problem as IGT tests do some screen change and then request the pipe CRC right after the change so PSR will go to idle state and only will entry again after at least 6 idles frames. But for PSR2 it is

[Intel-gfx] [PATCH 3/4] drm/i915/psr: Remove PSR2 FIXME

2019-02-13 Thread José Roberto de Souza
Now we are checking sink capabilities when probing PSR DPCD register and then dynamically checking in if new state is compatible with PSR in, so this FIXME can be dropped. Reviewed-by: Dhinakaran Pandiyan Cc: Dhinakaran Pandiyan Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/int

[Intel-gfx] [PATCH 1/4] drm/i915/psr: Only lookup for enabled CRTCs when forcing a fastset

2019-02-13 Thread José Roberto de Souza
Forcing a specific CRTC to the eDP connector was causing the intel_psr_fastset_force() to mark mode_chaged in the wrong and disabled CRTC causing no update in the PSR state. Looks like our internal state track do not clear output_types and has_psr in the disabled CRTCs, not sure if this is the exp

Re: [Intel-gfx] [PATCH v5 0/3] Support 64 bpp half float formats

2019-02-13 Thread Strasser, Kevin
Maarten Lankhorst wrote: > Op 13-02-2019 om 16:53 schreef Ville Syrjälä: > > On Fri, Feb 08, 2019 at 01:49:40PM -0800, Kevin Strasser wrote: > >> This series defines new formats and adds implementation to the i915 driver. > >> Since posting v1 I have removed the pixel normalize property, as it's no

Re: [Intel-gfx] [PATCH 4/6] drm/i915/psr: Remove PSR2 FIXME

2019-02-13 Thread Dhinakaran Pandiyan
On Thu, 2019-02-07 at 14:24 -0800, José Roberto de Souza wrote: > Now we are checking sink capabilities when probing PSR DPCD register > and then dynamically checking in if new state is compatible with PSR > in, so this FIXME can be dropped. Right, this was fixed a while ago. Reviewed-by: Dhinaka

[Intel-gfx] [PATCH] drm/i915: Only try to stop engines after a failed reset

2019-02-13 Thread Chris Wilson
Currently we try to stop the engine by programming the ring registers to be disabled before we perform the reset. Sometimes, we see the context image also have invalid ring registers, which one presumes may be actually caused by us doing so. Lets risk not doing programming the ring to zero on the f

[Intel-gfx] [PATCH] drm/i915/selftests: Always use an active engine while resetting

2019-02-13 Thread Chris Wilson
Currently, we only try to reset a live engine for checking the whitelist retention across a per-engine reset. For safety, it appears we need to prime the system with a hanging spinner before performing a full-device reset. (Figuring out the root cause behind the instability with handling a reset du

Re: [Intel-gfx] [PATCH] snd/hda, drm/i915: Track the display_power_status using a cookie

2019-02-13 Thread Chris Wilson
Quoting Takashi Iwai (2019-02-13 21:48:50) > On Wed, 13 Feb 2019 16:21:09 +0100, > Chris Wilson wrote: > > > > drm/i915 is tracking all wakeref owners with a cookie in order to > > identify leaks. To that end, each rpm acquisition ops->get_power is > > assigned a cookie which should be passed to o

Re: [Intel-gfx] [PATCH] snd/hda, drm/i915: Track the display_power_status using a cookie

2019-02-13 Thread Takashi Iwai
On Wed, 13 Feb 2019 16:21:09 +0100, Chris Wilson wrote: > > drm/i915 is tracking all wakeref owners with a cookie in order to > identify leaks. To that end, each rpm acquisition ops->get_power is > assigned a cookie which should be passed to ops->put_power to signify > its release (and removal fro

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Implement new w/a for underruns with wm1+ disabled

2019-02-13 Thread Clinton Taylor
Tested with dual CRTC configuration shows many FIFO underruns even with this code. Single CRTC has not produced a FIFO underrun yet. [ 7037.510737] [drm:intel_cpu_fifo_underrun_irq_handler] *ERROR* CPU pipe A FIFO underrun [ 7040.769741] [drm:intel_cpu_fifo_underrun_irq_handler] *ERROR* CPU pi

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Include "ignore lines" in skl+ wm state

2019-02-13 Thread Ville Syrjälä
On Wed, Feb 13, 2019 at 11:44:44AM -0800, Clinton Taylor wrote: > > On 2/13/19 8:54 AM, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > We'll need to poke at the "ignore lines" bit in the skl+ > > watermark registers for a w/a. Include that bit in the wm > > state. > > > > Signed-off-by: Vil

Re: [Intel-gfx] [PATCH 3/3] drm/dsc: Change infoframe_pack to payload_pack

2019-02-13 Thread Manasi Navare
On Wed, Feb 13, 2019 at 09:45:36AM -0500, David Francis wrote: > The function drm_dsc_pps_infoframe_pack only > packed the payload portion of the infoframe. > Change the input struct to the PPS payload > to clarify the function's purpose and allow > for drivers with their own handling of sdp. > (e.

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Implement new w/a for underruns with wm1+ disabled

2019-02-13 Thread Clinton Taylor
Reviewed-by: Clint Taylor -Clint On 2/13/19 8:54 AM, Ville Syrjala wrote: From: Ville Syrjälä The new workaround from the hw team involves programming the leaving WM1 still disabled but programming the blocks value identically to WM0, and we also need to set the "ignore lines watermark" bit

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Include "ignore lines" in skl+ wm state

2019-02-13 Thread Clinton Taylor
On 2/13/19 8:54 AM, Ville Syrjala wrote: From: Ville Syrjälä We'll need to poke at the "ignore lines" bit in the skl+ watermark registers for a w/a. Include that bit in the wm state. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_reg.h |

Re: [Intel-gfx] [PATCH 1/3] Revert "drm/i915: W/A for underruns with WM1+ disabled on icl"

2019-02-13 Thread Clinton Taylor
Reviewed-by: Clint Taylor -Clint On 2/13/19 8:54 AM, Ville Syrjala wrote: From: Ville Syrjälä This reverts commit bf002c100740f4ae01d0d86b44f65a712ee14031. The hw team has come up with a better workaround. So let's get rid of this one. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i

Re: [Intel-gfx] [PATCH 2/3] drm/dsc: Add native 420 and 422 support to compute_rc_params

2019-02-13 Thread Manasi Navare
On Wed, Feb 13, 2019 at 09:45:35AM -0500, David Francis wrote: > Native 420 and 422 transfer modes are new in DSC1.2 > > In these modes, each two pixels of a slice are treated as one > pixel, so the slice width is half as large (round down) for > the purposes of calucating the groups per line and

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Move dsc rate params compute into drm

2019-02-13 Thread Manasi Navare
On Wed, Feb 13, 2019 at 09:45:34AM -0500, David Francis wrote: > The function intel_compute_rc_parameters is part of the dsc spec > and is not driver-specific. Other drm drivers might like to use > it. The function is not changed; just moved and renamed. > Yes this sounds fair since its DSC spec

[Intel-gfx] [PATCH] drm/i915: Defer application of request banning to submission

2019-02-13 Thread Chris Wilson
As we currently do not check on submission whether the context is banned in a timely manner it is possible for some requests to escape cancellation after their parent context is banned. By moving the ban into the request submission under the engine->timeline.lock, we serialise it with the reset and

[Intel-gfx] [PATCH] drm/i915: Defer application of request banning to submission

2019-02-13 Thread Chris Wilson
As we currently do not check on submission whether the context is banned in a timely manner it is possible for some requests to escape cancellation after their parent context is banned. By moving the ban into the request submission under the engine->timeline.lock, we serialise it with the reset and

[Intel-gfx] ✗ Fi.CI.IGT: failure for snd/hda, drm/i915: Track the display_power_status using a cookie

2019-02-13 Thread Patchwork
== Series Details == Series: snd/hda, drm/i915: Track the display_power_status using a cookie URL : https://patchwork.freedesktop.org/series/56615/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5598_full -> Patchwork_12213_full =

Re: [Intel-gfx] [PATCH v12 21/38] mei: me: add ice lake point device id.

2019-02-13 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed because it contains a -stable tag. The stable tag indicates that it's relevant for the following trees: all The bot has tested the following trees: v4.20.7, v4.19.20, v4.14.98, v4.9.155, v4.4.173, v3.18.134. v4.20.7: Build OK! v4.

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Wrap plane update/disable hook calls

2019-02-13 Thread Rodrigo Vivi
On Wed, Feb 06, 2019 at 10:49:10PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Wrap the .update_plane()/.update_slave()/.disable_plane() vfunc > calls into helpers which also take care to emit the appropriate > tracepoint. > > Signed-off-by: Ville Syrjälä Reviewed-by: Rodrigo Vivi

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Add overlooked plane disable tracepoint into intel_crtc_disable_planes()

2019-02-13 Thread Rodrigo Vivi
On Wed, Feb 06, 2019 at 10:49:09PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > intel_crtc_disable_planes() disables the planes so it should > trigger the appropriate tracepoint. > > Signed-off-by: Ville Syrjälä Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/intel_display.c

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Add pipe crc tracepoint

2019-02-13 Thread Rodrigo Vivi
On Wed, Feb 06, 2019 at 10:49:07PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Add a tracepoint for pipe crc. Makes life much simpler when staring at > traces when hunting for fifo underruns and other issues which cause > corrupted frames. We'll add the tracepoint before filtering out a

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Add pipe enable/disable tracepoints

2019-02-13 Thread Rodrigo Vivi
On Wed, Feb 06, 2019 at 10:49:08PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Add tracepoints for pipe enable/disable. We'll include the > frame/scanline counters for all pipes in these tracepoints to > help in diagnosing underruns and whatnot when enabling/disabling > pipes in paralle

[Intel-gfx] [PATCH 1/3] Revert "drm/i915: W/A for underruns with WM1+ disabled on icl"

2019-02-13 Thread Ville Syrjala
From: Ville Syrjälä This reverts commit bf002c100740f4ae01d0d86b44f65a712ee14031. The hw team has come up with a better workaround. So let's get rid of this one. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_reg.h | 1 - drivers/gpu/drm/i915/intel_display.c | 6 -- 2 fil

[Intel-gfx] [PATCH 3/3] drm/i915: Implement new w/a for underruns with wm1+ disabled

2019-02-13 Thread Ville Syrjala
From: Ville Syrjälä The new workaround from the hw team involves programming the leaving WM1 still disabled but programming the blocks value identically to WM0, and we also need to set the "ignore lines watermark" bit for WM1. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_pm.c |

[Intel-gfx] [PATCH 2/3] drm/i915: Include "ignore lines" in skl+ wm state

2019-02-13 Thread Ville Syrjala
From: Ville Syrjälä We'll need to poke at the "ignore lines" bit in the skl+ watermark registers for a w/a. Include that bit in the wm state. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_pm.c | 44 ++

Re: [Intel-gfx] [PATCH] drm/i915/psr: Bump vblank evasion time for seamless updates

2019-02-13 Thread Chris Wilson
Quoting Ville Syrjälä (2019-02-13 16:30:10) > On Wed, Feb 13, 2019 at 04:21:42PM +, Chris Wilson wrote: > > Each set of registers we need to rewrite during a pageflip/modeset > > increases the required evasion window. Modesets with PSR enabled > > empirically take up to 350us to complete the re

Re: [Intel-gfx] [PATCH] drm/i915/psr: Bump vblank evasion time for seamless updates

2019-02-13 Thread Ville Syrjälä
On Wed, Feb 13, 2019 at 04:21:42PM +, Chris Wilson wrote: > Each set of registers we need to rewrite during a pageflip/modeset > increases the required evasion window. Modesets with PSR enabled > empirically take up to 350us to complete the register programming, so > provide a corresponding boo

[Intel-gfx] [PATCH] drm/i915/psr: Bump vblank evasion time for seamless updates

2019-02-13 Thread Chris Wilson
Each set of registers we need to rewrite during a pageflip/modeset increases the required evasion window. Modesets with PSR enabled empirically take up to 350us to complete the register programming, so provide a corresponding boost to the evasion window. Bugzilla: https://bugs.freedesktop.org/show

[Intel-gfx] ✓ Fi.CI.BAT: success for snd/hda, drm/i915: Track the display_power_status using a cookie

2019-02-13 Thread Patchwork
== Series Details == Series: snd/hda, drm/i915: Track the display_power_status using a cookie URL : https://patchwork.freedesktop.org/series/56615/ State : success == Summary == CI Bug Log - changes from CI_DRM_5598 -> Patchwork_12213 Summa

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for snd/hda, drm/i915: Track the display_power_status using a cookie

2019-02-13 Thread Patchwork
== Series Details == Series: snd/hda, drm/i915: Track the display_power_status using a cookie URL : https://patchwork.freedesktop.org/series/56615/ State : warning == Summary == $ dim checkpatch origin/drm-tip 3b218178e779 snd/hda, drm/i915: Track the display_power_status using a cookie -:107:

Re: [Intel-gfx] [PATCH v5 0/3] Support 64 bpp half float formats

2019-02-13 Thread Maarten Lankhorst
Op 13-02-2019 om 16:53 schreef Ville Syrjälä: > On Fri, Feb 08, 2019 at 01:49:40PM -0800, Kevin Strasser wrote: >> This series defines new formats and adds implementation to the i915 driver. >> Since posting v1 I have removed the pixel normalize property, as it's not >> needed >> for basic functio

Re: [Intel-gfx] [PATCH v5 0/3] Support 64 bpp half float formats

2019-02-13 Thread Ville Syrjälä
On Fri, Feb 08, 2019 at 01:49:40PM -0800, Kevin Strasser wrote: > This series defines new formats and adds implementation to the i915 driver. > Since posting v1 I have removed the pixel normalize property, as it's not > needed > for basic functionality. Also, I have been working on adding support

[Intel-gfx] ✗ Fi.CI.BAT: failure for Make DRM DSC helpers more generally usable

2019-02-13 Thread Patchwork
== Series Details == Series: Make DRM DSC helpers more generally usable URL : https://patchwork.freedesktop.org/series/56608/ State : failure == Summary == Applying: drm/i915: Move dsc rate params compute into drm Applying: drm/dsc: Add native 420 and 422 support to compute_rc_params error: sh

Re: [Intel-gfx] [PATCH 3/3] drm/dsc: Change infoframe_pack to payload_pack

2019-02-13 Thread Wentland, Harry
On 2019-02-13 9:45 a.m., David Francis wrote: > The function drm_dsc_pps_infoframe_pack only > packed the payload portion of the infoframe. > Change the input struct to the PPS payload > to clarify the function's purpose and allow > for drivers with their own handling of sdp. > (e.g. drivers with t

Re: [Intel-gfx] [PATCH 2/3] drm/dsc: Add native 420 and 422 support to compute_rc_params

2019-02-13 Thread Wentland, Harry
On 2019-02-13 9:45 a.m., David Francis wrote: > Native 420 and 422 transfer modes are new in DSC1.2 > > In these modes, each two pixels of a slice are treated as one > pixel, so the slice width is half as large (round down) for > the purposes of calucating the groups per line and chunk size > in b

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Move dsc rate params compute into drm

2019-02-13 Thread Wentland, Harry
On 2019-02-13 9:45 a.m., David Francis wrote: > The function intel_compute_rc_parameters is part of the dsc spec > and is not driver-specific. Other drm drivers might like to use > it. The function is not changed; just moved and renamed. > > Signed-off-by: David Francis Reviewed-by: Harry Wentl

[Intel-gfx] [PATCH] snd/hda, drm/i915: Track the display_power_status using a cookie

2019-02-13 Thread Chris Wilson
drm/i915 is tracking all wakeref owners with a cookie in order to identify leaks. To that end, each rpm acquisition ops->get_power is assigned a cookie which should be passed to ops->put_power to signify its release (and removal from the list of wakeref owners). As snd/hda is already using a bool t

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Assert that VED and ISP are power gated

2019-02-13 Thread Imre Deak
On Thu, Nov 29, 2018 at 07:55:04PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > As there are no upstream drivers for VED or ISP let's just > assert that they are power gated. Otherwise they would > prevent s0ix entry. > > For ISP this is only relevant when it is not exposed as a > PCI d

[Intel-gfx] [PATCH 3/3] drm/dsc: Change infoframe_pack to payload_pack

2019-02-13 Thread David Francis
The function drm_dsc_pps_infoframe_pack only packed the payload portion of the infoframe. Change the input struct to the PPS payload to clarify the function's purpose and allow for drivers with their own handling of sdp. (e.g. drivers with their own struct for all SDP transactions) Signed-off-by:

[Intel-gfx] [PATCH 1/3] drm/i915: Move dsc rate params compute into drm

2019-02-13 Thread David Francis
The function intel_compute_rc_parameters is part of the dsc spec and is not driver-specific. Other drm drivers might like to use it. The function is not changed; just moved and renamed. Signed-off-by: David Francis --- drivers/gpu/drm/drm_dsc.c | 133 ++ driv

[Intel-gfx] [PATCH 2/3] drm/dsc: Add native 420 and 422 support to compute_rc_params

2019-02-13 Thread David Francis
Native 420 and 422 transfer modes are new in DSC1.2 In these modes, each two pixels of a slice are treated as one pixel, so the slice width is half as large (round down) for the purposes of calucating the groups per line and chunk size in bytes In native 422 mode, each pixel has four components,

[Intel-gfx] [PATCH 0/3] Make DRM DSC helpers more generally usable

2019-02-13 Thread David Francis
drm_dsc could use some work so that drm drivers other than i915 can make use of it their own DSC implementations Move rc compute, a function that forms part of the DSC spec, into drm. Update it to DSC 1.2. Also change the packing function to operate only on the packing struct, to allow for drivers

Re: [Intel-gfx] [PATCH 1/2] drm/i915: s/PUNIT_REG_DSPFREQ/PUNIT_REG_DSPSSPM/

2019-02-13 Thread Imre Deak
On Thu, Nov 29, 2018 at 07:55:03PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Rename the punit display power register to match the spec. > > Signed-off-by: Ville Syrjälä Reviewed-by: Imre Deak > --- > drivers/gpu/drm/i915/i915_reg.h | 2 +- > drivers/gpu/drm/i915/intel_c

Re: [Intel-gfx] [PATCH i-g-t] i915/gem_ctx_sseu: Fix 32-bit build

2019-02-13 Thread Chris Wilson
Quoting Chris Wilson (2019-02-13 14:08:02) > Quoting Guillaume Tucker (2019-02-13 09:31:37) > > This fixes a compiler warning treated as an error when building for > > 32-bit architectures since their pointer size does not match the size > > of drm_i915_gem_context_param.value which is 64 bits: > >

Re: [Intel-gfx] [PATCH i-g-t] i915/gem_ctx_sseu: Fix 32-bit build

2019-02-13 Thread Chris Wilson
Quoting Guillaume Tucker (2019-02-13 09:31:37) > This fixes a compiler warning treated as an error when building for > 32-bit architectures since their pointer size does not match the size > of drm_i915_gem_context_param.value which is 64 bits: > > CC i915/gem_ctx_sseu.o > i915/gem_ctx_s

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Enable P0xx (planar), Y2xx/Y4xx (packed) pixel formats

2019-02-13 Thread Patchwork
== Series Details == Series: Enable P0xx (planar), Y2xx/Y4xx (packed) pixel formats URL : https://patchwork.freedesktop.org/series/56606/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Add P010, P012, P016 plane control definitions Okay! Com

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable P0xx (planar), Y2xx/Y4xx (packed) pixel formats

2019-02-13 Thread Patchwork
== Series Details == Series: Enable P0xx (planar), Y2xx/Y4xx (packed) pixel formats URL : https://patchwork.freedesktop.org/series/56606/ State : warning == Summary == $ dim checkpatch origin/drm-tip cb165e09561e drm/i915: Add P010, P012, P016 plane control definitions faf842adb452 drm/i915: P

[Intel-gfx] [PATCH 3/6] drm/i915: Enable P010, P012, P016 formats for primary and sprite planes

2019-02-13 Thread Swati Sharma
From: Juha-Pekka Heikkila Enabling of P010, P012 and P016 formats. These formats will extend NV12 for larger bit depths. Signed-off-by: Juha-Pekka Heikkila Signed-off-by: Swati Sharma Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_sprite.c | 28 ++-- 1

[Intel-gfx] [PATCH 6/6] drm/i915/icl: Enabling Y2xx and Y4xx (xx:10/12/16) formats for universal planes

2019-02-13 Thread Swati Sharma
Signed-off-by: Swati Sharma Signed-off-by: Vidya Srinivas Reviewed-by: Juha-Pekka Heikkila Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_display.c | 30 ++ drivers/gpu/drm/i915/intel_sprite.c | 60 +++- 2 files changed, 89 insert

[Intel-gfx] [PATCH 1/6] drm/i915: Add P010, P012, P016 plane control definitions

2019-02-13 Thread Swati Sharma
From: Juha-Pekka Heikkila Add needed plane control flag definitions for P010, P012 and P016 formats. Signed-off-by: Juha-Pekka Heikkila Signed-off-by: Swati Sharma Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/i915/i915_reg.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/driver

[Intel-gfx] [PATCH 2/6] drm/i915: Preparations for enabling P010, P012, P016 formats

2019-02-13 Thread Swati Sharma
From: Juha-Pekka Heikkila Preparations for enabling P010, P012 and P016 formats. These formats will extend NV12 for larger bit depths. Signed-off-by: Juha-Pekka Heikkila Signed-off-by: Swati Sharma Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_atomic_plane.c | 2 +- drivers/

[Intel-gfx] [PATCH 5/6] drm/i915/icl: Add Y2xx and Y4xx (xx:10/12/16) plane control definitions

2019-02-13 Thread Swati Sharma
Added needed plane control flag definitions for Y2xx and Y4xx (10, 12 and 16 bits) Signed-off-by: Swati Sharma Signed-off-by: Vidya Srinivas Reviewed-by: Juha-Pekka Heikkila Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/i915/i915_reg.h | 6 ++ 1 file changed, 6 insertions(+) diff --

[Intel-gfx] [PATCH 0/6] Enable P0xx (planar), Y2xx/Y4xx (packed) pixel formats

2019-02-13 Thread Swati Sharma
This patch series is for enabling P0xx, Y2xx and Y4xx pixel formats for intel's i915 driver. In this patch series, Juha Pekka's patch series Gen10+ P0xx formats https://patchwork.freedesktop.org/series/56053/ is combined with Swati's https://patchwork.freedesktop.org/series/55035/ for Gen11+ pixel

[Intel-gfx] [PATCH 4/6] drm: Add Y2xx and Y4xx (xx:10/12/16) format definitions and fourcc

2019-02-13 Thread Swati Sharma
The following pixel formats are packed format that follows 4:2:2 chroma sampling. For memory represenation each component is allocated 16 bits each. Thus each pixel occupies 32bit. Y210: For each component, valid data occupies MSB 10 bits. LSB 6 bits are filled with zeroes. Y212: For e

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] i915/gem_exec_big: Add a single shot test

2019-02-13 Thread Chris Wilson
Quoting Daniel Vetter (2019-02-13 13:08:32) > On Wed, Feb 13, 2019 at 2:05 PM Chris Wilson wrote: > > > > Quoting Daniel Vetter (2019-02-13 13:02:29) > > > On Wed, Feb 13, 2019 at 11:15 AM Chris Wilson > > > wrote: > > > > Quoting Daniel Vetter (2019-02-13 10:11:27) > > > > > On Tue, Feb 12, 201

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] i915/gem_exec_big: Add a single shot test

2019-02-13 Thread Daniel Vetter
On Wed, Feb 13, 2019 at 2:05 PM Chris Wilson wrote: > > Quoting Daniel Vetter (2019-02-13 13:02:29) > > On Wed, Feb 13, 2019 at 11:15 AM Chris Wilson > > wrote: > > > Quoting Daniel Vetter (2019-02-13 10:11:27) > > > > On Tue, Feb 12, 2019 at 10:43:41PM +, Chris Wilson wrote: > > > > > CI co

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] i915/gem_exec_big: Add a single shot test

2019-02-13 Thread Chris Wilson
Quoting Daniel Vetter (2019-02-13 13:02:29) > On Wed, Feb 13, 2019 at 11:15 AM Chris Wilson > wrote: > > Quoting Daniel Vetter (2019-02-13 10:11:27) > > > On Tue, Feb 12, 2019 at 10:43:41PM +, Chris Wilson wrote: > > > > CI complains that the exhaustive test of trying every size up to the > >

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] i915/gem_exec_big: Add a single shot test

2019-02-13 Thread Daniel Vetter
On Wed, Feb 13, 2019 at 11:15 AM Chris Wilson wrote: > Quoting Daniel Vetter (2019-02-13 10:11:27) > > On Tue, Feb 12, 2019 at 10:43:41PM +, Chris Wilson wrote: > > > CI complains that the exhaustive test of trying every size up to the > > > limit is too slow, so add a simple test that tries t

[Intel-gfx] [PATCH i-g-t] i915/gem_exec_big: Add a single shot test

2019-02-13 Thread Chris Wilson
CI complains that the exhaustive test of trying every size up to the limit is too slow, so add a simple test that tries to submit one extreme batch buffer and check all the relocations land. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=10 Signed-off-by: Chris Wilson --- Continue the

[Intel-gfx] ✓ Fi.CI.IGT: success for i915/gem_exec_big: Add a single shot test

2019-02-13 Thread Patchwork
== Series Details == Series: i915/gem_exec_big: Add a single shot test URL : https://patchwork.freedesktop.org/series/56595/ State : success == Summary == CI Bug Log - changes from CI_DRM_5596_full -> IGTPW_2390_full Summary --- **SU

[Intel-gfx] [PULL] drm-intel-fixes

2019-02-13 Thread Jani Nikula
Hi Dave and Daniel, perhaps slightly more than I'd like at this stage, but didn't really want to drop anything either... BR, Jani. The following changes since commit d13937116f1e82bf508a6325111b322c30c85eb9: Linux 5.0-rc6 (2019-02-10 14:42:20 -0800) are available in the Git repository at:

Re: [Intel-gfx] [v15 3/4] drm: Add colorspace info to AVI Infoframe

2019-02-13 Thread Shankar, Uma
>-Original Message- >From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] >Sent: Wednesday, February 13, 2019 4:34 PM >To: Shankar, Uma >Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; Syrjala, >Ville >; emil.l.veli...@gmail.com; Lankhorst, Maarten > >Subject

Re: [Intel-gfx] [v15 3/4] drm: Add colorspace info to AVI Infoframe

2019-02-13 Thread Ville Syrjälä
On Tue, Feb 12, 2019 at 09:30:50PM +, Shankar, Uma wrote: > > > >-Original Message- > >From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] > >Sent: Tuesday, February 12, 2019 10:35 PM > >To: Shankar, Uma > >Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org;

Re: [Intel-gfx] [v9 5/5] drm/i915/icl: Add degamma and gamma lut size to gen11 caps

2019-02-13 Thread Maarten Lankhorst
Op 11-02-2019 om 14:50 schreef Uma Shankar: > Add the degamma and gamma lut sizes to gen11 capability > structure. > > Note: Currently this doesn't account for the extended range gamma > entries and this will be addressed with new segmented gamma ABI > in a future patch. > > v2: Reorder the patch a

[Intel-gfx] [PATCH 3/4] drm/i915: Remove access to global seqno in the HWSP

2019-02-13 Thread Chris Wilson
Stop accessing the HWSP to read the global seqno, and stop tracking the mirror in the engine's execution timeline -- it is unused. Signed-off-by: Chris Wilson Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_gpu_error.c | 4 -- drivers/gpu/drm/i915/i915_gpu_error.h |

[Intel-gfx] [PATCH 1/4] drm/i915/pmu: Always sample an active ringbuffer

2019-02-13 Thread Chris Wilson
As we no longer have a precise indication of requests queued to an engine, make no presumptions and just sample the ring registers to see if the engine is busy. v2: Report busy while the ring is idling on a semaphore/event. v3: Give the struct a name! v4: Always 0 outside the powerwell; trusting t

[Intel-gfx] [PATCH 4/4] drm/i915: Remove i915_request.global_seqno

2019-02-13 Thread Chris Wilson
Having weaned the interrupt handling off using a single global execution queue, we no longer need to emit a global_seqno. Note that we still have a few assumptions about execution order along engine timelines, but this removes the most obvious artefact! Signed-off-by: Chris Wilson --- drivers/gp

[Intel-gfx] [PATCH 2/4] drm/i915: Replace global_seqno with a hangcheck heartbeat seqno

2019-02-13 Thread Chris Wilson
To determine whether an engine has 'stuck', we simply check whether or not is still on the same seqno for several seconds. To keep this simple mechanism intact over the loss of a global seqno, we can simply add a new global heartbeat seqno instead. As we cannot know the sequence in which requests w

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] i915/gem_exec_big: Add a single shot test

2019-02-13 Thread Chris Wilson
Quoting Daniel Vetter (2019-02-13 10:11:27) > On Tue, Feb 12, 2019 at 10:43:41PM +, Chris Wilson wrote: > > CI complains that the exhaustive test of trying every size up to the > > limit is too slow, so add a simple test that tries to submit one > > extreme batch buffer and check all the reloca

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] i915/gem_exec_big: Add a single shot test

2019-02-13 Thread Daniel Vetter
On Tue, Feb 12, 2019 at 10:43:41PM +, Chris Wilson wrote: > CI complains that the exhaustive test of trying every size up to the > limit is too slow, so add a simple test that tries to submit one > extreme batch buffer and check all the relocations land. > > Bugzilla: https://bugs.freedesktop.

[Intel-gfx] [PULL] drm-misc-fixes

2019-02-13 Thread Maarten Lankhorst
Hi Dave, Daniel, Just a single fix to a license inconsistency in vkms. :) drm-misc-fixes-2019-02-13: drm-misc-fixes for v5.0: - Fix license inconsistency in vkms. The following changes since commit 6297388e1eddd2f1345cea5892156223995bcf2d: drm/omap: dsi: Hack-fix DSI bus flags (2019-02-06 13:3

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Apply rps waitboosting for dma_fence_wait_timeout()

2019-02-13 Thread Patchwork
== Series Details == Series: drm/i915: Apply rps waitboosting for dma_fence_wait_timeout() URL : https://patchwork.freedesktop.org/series/56597/ State : success == Summary == CI Bug Log - changes from CI_DRM_5596 -> Patchwork_12209 Summary

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Apply rps waitboosting for dma_fence_wait_timeout()

2019-02-13 Thread Patchwork
== Series Details == Series: drm/i915: Apply rps waitboosting for dma_fence_wait_timeout() URL : https://patchwork.freedesktop.org/series/56597/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Apply rps waitboosting for dma_fence_wait_timeout(

[Intel-gfx] [PATCH i-g-t] i915/gem_ctx_sseu: Fix 32-bit build

2019-02-13 Thread Guillaume Tucker
This fixes a compiler warning treated as an error when building for 32-bit architectures since their pointer size does not match the size of drm_i915_gem_context_param.value which is 64 bits: CC i915/gem_ctx_sseu.o i915/gem_ctx_sseu.c: In function ‘test_ggtt_args’: i915/gem_ctx_sseu.c:

[Intel-gfx] ✓ Fi.CI.BAT: success for i915/gem_exec_big: Add a single shot test

2019-02-13 Thread Patchwork
== Series Details == Series: i915/gem_exec_big: Add a single shot test URL : https://patchwork.freedesktop.org/series/56595/ State : success == Summary == CI Bug Log - changes from CI_DRM_5596 -> IGTPW_2390 Summary --- **SUCCESS**

[Intel-gfx] [PATCH] drm/i915: Apply rps waitboosting for dma_fence_wait_timeout()

2019-02-13 Thread Chris Wilson
As time goes by, usage of generic ioctls such as drm_syncobj and sync_file are on the increase bypassing i915-specific ioctls like GEM_WAIT. Currently, we only apply waitboosting to our driver ioctls as we track the file/client and account the waitboosting to them. However, since commit 7b92c1bd054

[Intel-gfx] [PATCH i-g-t] i915/gem_exec_big: Add a single shot test

2019-02-13 Thread Chris Wilson
CI complains that the exhaustive test of trying every size up to the limit is too slow, so add a simple test that tries to submit one extreme batch buffer and check all the relocations land. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=10 Signed-off-by: Chris Wilson --- tests/i915/

Re: [Intel-gfx] [PULL] topic/component-typed

2019-02-13 Thread Joonas Lahtinen
Quoting Rodrigo Vivi (2019-02-12 01:51:18) > On Mon, Feb 11, 2019 at 06:15:20PM +0100, Daniel Vetter wrote: > > Hi all, > > > > Here's the typed component topic branch. > > > > drm-intel maintainers: Please pull, I need this for the mei hdcp work from > > Ram. > > I'm about to handle dinq to Jo

[Intel-gfx] ✓ Fi.CI.IGT: success for Add Colorspace connector property interface (rev15)

2019-02-13 Thread Patchwork
== Series Details == Series: Add Colorspace connector property interface (rev15) URL : https://patchwork.freedesktop.org/series/47132/ State : success == Summary == CI Bug Log - changes from CI_DRM_5596_full -> Patchwork_12208_full Summary