[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Only reset the pinned kernel contexts on resume

2019-03-26 Thread Patchwork
== Series Details == Series: drm/i915: Only reset the pinned kernel contexts on resume URL : https://patchwork.freedesktop.org/series/58589/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5818_full -> Patchwork_12603_full

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Do not enable FEC without DSC

2019-03-26 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Do not enable FEC without DSC URL : https://patchwork.freedesktop.org/series/58588/ State : success == Summary == CI Bug Log - changes from CI_DRM_5818_full -> Patchwork_12602_full

[Intel-gfx] linux-next: build failure after merge of the drm-intel tree

2019-03-26 Thread Stephen Rothwell
Hi all, After merging the drm-intel tree, today's linux-next build (i386 defconfig) failed like this: In file included from drivers/gpu/drm/i915/intel_guc.h:28:0, from drivers/gpu/drm/i915/intel_uc.h:27, from drivers/gpu/drm/i915/intel_uc.c:25:

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v2,1/6] drm/i915: Add broadcast RGB property for DP MST

2019-03-26 Thread Patchwork
== Series Details == Series: series starting with [v2,1/6] drm/i915: Add broadcast RGB property for DP MST URL : https://patchwork.freedesktop.org/series/58585/ State : success == Summary == CI Bug Log - changes from CI_DRM_5818_full -> Patchwork_12601_full

Re: [Intel-gfx] [PATCH v5 2/5] drm/i915: Watchdog timeout: IRQ handler for gen8+

2019-03-26 Thread Carlos Santa
On Mon, 2019-03-25 at 10:00 +, Tvrtko Ursulin wrote: > On 22/03/2019 23:41, Carlos Santa wrote: > > From: Michel Thierry > > > > *** General *** > > > > Watchdog timeout (or "media engine reset") is a feature that allows > > userland applications to enable hang detection on individual batch

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [01/21] drm/fb-helper: Add fill_info() functions

2019-03-26 Thread Patchwork
== Series Details == Series: series starting with [01/21] drm/fb-helper: Add fill_info() functions URL : https://patchwork.freedesktop.org/series/58578/ State : success == Summary == CI Bug Log - changes from CI_DRM_5818_full -> Patchwork_12600_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: fix i386 build of 64b raw_uncore functions

2019-03-26 Thread Patchwork
== Series Details == Series: drm/i915: fix i386 build of 64b raw_uncore functions URL : https://patchwork.freedesktop.org/series/58611/ State : success == Summary == CI Bug Log - changes from CI_DRM_5819 -> Patchwork_12610 Summary ---

Re: [Intel-gfx] [PATCH] drm/i915: fix i386 build of 64b raw_uncore functions

2019-03-26 Thread Chris Wilson
Quoting Daniele Ceraolo Spurio (2019-03-26 23:38:17) > When building with ARCH=i386, readq and writeq are not defined, > resulting in: > > intel_uncore.h: In function ‘__raw_uncore_read64’: > intel_uncore.h:257:9: error: implicit declaration of function ‘readq’; > did you mean ‘readl’?

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/icl: Fix VEBOX mismatch BUG_ON()

2019-03-26 Thread Patchwork
== Series Details == Series: drm/i915/icl: Fix VEBOX mismatch BUG_ON() URL : https://patchwork.freedesktop.org/series/58609/ State : success == Summary == CI Bug Log - changes from CI_DRM_5819 -> Patchwork_12609 Summary ---

[Intel-gfx] [PATCH] drm/i915: fix i386 build of 64b raw_uncore functions

2019-03-26 Thread Daniele Ceraolo Spurio
When building with ARCH=i386, readq and writeq are not defined, resulting in: intel_uncore.h: In function ‘__raw_uncore_read64’: intel_uncore.h:257:9: error: implicit declaration of function ‘readq’; did you mean ‘readl’? [-Werror=implicit-function-declaration] return

Re: [Intel-gfx] [PATCH] drm/i915/icl: Fix VEBOX mismatch BUG_ON()

2019-03-26 Thread Chris Wilson
Quoting José Roberto de Souza (2019-03-26 23:02:23) > GT VEBOX DISABLE is only 4 bits wide but it was using a 8 bits wide > mask, the remaning reserved bits is set to 0 causing 4 more > nonexistent VEBOX engines being detected as enabled, triggering the > BUG_ON() because of mismatch between

[Intel-gfx] ✗ Fi.CI.IGT: failure for Device id consolidation

2019-03-26 Thread Patchwork
== Series Details == Series: Device id consolidation URL : https://patchwork.freedesktop.org/series/58561/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5817_full -> Patchwork_12599_full Summary --- **FAILURE**

[Intel-gfx] [PATCH] drm/i915/icl: Fix VEBOX mismatch BUG_ON()

2019-03-26 Thread José Roberto de Souza
GT VEBOX DISABLE is only 4 bits wide but it was using a 8 bits wide mask, the remaning reserved bits is set to 0 causing 4 more nonexistent VEBOX engines being detected as enabled, triggering the BUG_ON() because of mismatch between vebox_mask and newly added VEBOX_MASK(). [ 64.081621]

Re: [Intel-gfx] [PATCH 3/4] drm: Kill drm_display_info.name

2019-03-26 Thread Sam Ravnborg
Hi Ville. On Tue, Mar 26, 2019 at 07:34:00PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > drm_display_info.name is only ever set by a few panel drveirs but drivers Nice clean-up! Sam

Re: [Intel-gfx] [PATCH 2/9] drm/i915: add HAS_FORCEWAKE flag to uncore

2019-03-26 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-03-26 12:47:00) > On Mon, 25 Mar 2019 22:49:33 +0100, Daniele Ceraolo Spurio > wrote: > > > We have several cases where we don't have forcewake (older gens, GVT and > > planned display-only uncore), so, instead of checking every time against > > the various

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/9] drm/i915: rename raw reg access functions

2019-03-26 Thread Patchwork
== Series Details == Series: series starting with [CI,1/9] drm/i915: rename raw reg access functions URL : https://patchwork.freedesktop.org/series/58604/ State : success == Summary == CI Bug Log - changes from CI_DRM_5818 -> Patchwork_12608

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,1/9] drm/i915: rename raw reg access functions

2019-03-26 Thread Patchwork
== Series Details == Series: series starting with [CI,1/9] drm/i915: rename raw reg access functions URL : https://patchwork.freedesktop.org/series/58604/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: rename raw reg access functions

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/9] drm/i915: rename raw reg access functions

2019-03-26 Thread Patchwork
== Series Details == Series: series starting with [CI,1/9] drm/i915: rename raw reg access functions URL : https://patchwork.freedesktop.org/series/58604/ State : warning == Summary == $ dim checkpatch origin/drm-tip 518022b1d8c7 drm/i915: rename raw reg access functions -:302:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Adding missing '; ' to ENGINE_INSTANCES

2019-03-26 Thread Patchwork
== Series Details == Series: drm/i915: Adding missing '; ' to ENGINE_INSTANCES URL : https://patchwork.freedesktop.org/series/58599/ State : success == Summary == CI Bug Log - changes from CI_DRM_5818 -> Patchwork_12606 Summary ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/fb-helper: Move modesetting code to drm_client

2019-03-26 Thread Patchwork
== Series Details == Series: drm/fb-helper: Move modesetting code to drm_client URL : https://patchwork.freedesktop.org/series/58597/ State : failure == Summary == Applying: drm/fb-helper: Remove unused gamma_size variable Applying: drm/fb-helper: dpms_legacy(): Only set on connectors in use

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Adding missing '; ' to ENGINE_INSTANCES

2019-03-26 Thread Patchwork
== Series Details == Series: drm/i915: Adding missing '; ' to ENGINE_INSTANCES URL : https://patchwork.freedesktop.org/series/58599/ State : warning == Summary == $ dim checkpatch origin/drm-tip c8194aaa11bd drm/i915: Adding missing '; ' to ENGINE_INSTANCES -:10: WARNING:BAD_SIGN_OFF: Use a

Re: [Intel-gfx] [PATCH 03/16] drm/atomic: Move __drm_atomic_helper_disable_plane/set_config()

2019-03-26 Thread Daniel Vetter
On Tue, Mar 26, 2019 at 06:55:33PM +0100, Noralf Trønnes wrote: > Prepare for moving drm_fb_helper modesetting code to drm_client. > drm_client will be linked to drm.ko, so move > __drm_atomic_helper_disable_plane() and __drm_atomic_helper_set_config() > out of drm_kms_helper.ko. > > While at it,

Re: [Intel-gfx] [PATCH 3/8] drm/i915/psr: Make all PSR register relative to mmio base

2019-03-26 Thread Souza, Jose
On Fri, 2019-03-22 at 10:27 -0700, Dhinakaran Pandiyan wrote: > On Fri, 2019-03-22 at 11:15 +0200, Jani Nikula wrote: > > On Thu, 21 Mar 2019, José Roberto de Souza > > wrote: > > > Right now it have a mix of PSR registers that are relative to PSR > > > mmio base and other register with a

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] drm: Nuke unused drm_display_info.pixel_clock

2019-03-26 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm: Nuke unused drm_display_info.pixel_clock URL : https://patchwork.freedesktop.org/series/58595/ State : success == Summary == CI Bug Log - changes from CI_DRM_5818 -> Patchwork_12605

Re: [Intel-gfx] [PATCH 16/16] drm/vc4: Call drm_dev_register() after all setup is done

2019-03-26 Thread Daniel Vetter
On Tue, Mar 26, 2019 at 06:55:46PM +0100, Noralf Trønnes wrote: > drm_dev_register() initializes internal clients like bootsplash as the > last thing it does, so all setup needs to be done at this point. > > Fix by calling vc4_kms_load() before registering. > Also check the error code returned

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Update size upon return from GEM_CREATE (rev2)

2019-03-26 Thread Patchwork
== Series Details == Series: drm/i915: Update size upon return from GEM_CREATE (rev2) URL : https://patchwork.freedesktop.org/series/58592/ State : success == Summary == CI Bug Log - changes from CI_DRM_5818 -> Patchwork_12604 Summary

[Intel-gfx] [CI 5/9] drm/i915: switch uncore mmio funcs to use intel_uncore

2019-03-26 Thread Chris Wilson
From: Daniele Ceraolo Spurio The full read/write ops can now work on the intel_uncore struct. Introduce intel_uncore_read/write functions working on intel_uncore and switch the I915_READ/WRITE macro to internally call those. v2: no change v3: add intel_uncore_read/write functions (Chris),

[Intel-gfx] [CI 9/9] drm/i915: take a reference to uncore in the engine and use it

2019-03-26 Thread Chris Wilson
From: Daniele Ceraolo Spurio A few advantages: - Prepares us for the planned split of display uncore from GT uncore - Improves our engine-centric view of the world in the engine code and allows us to avoid jumping back to dev_priv. - Allows us to wrap accesses to engine register in nice

[Intel-gfx] [CI 3/9] drm/i915: add uncore flags for unclaimed mmio

2019-03-26 Thread Chris Wilson
From: Daniele Ceraolo Spurio Save the HW capabilities to avoid having to jump back to dev_priv every time. Signed-off-by: Daniele Ceraolo Spurio Cc: Paulo Zanoni Cc: Chris Wilson Reviewed-by: Paulo Zanoni Signed-off-by: Chris Wilson Link:

[Intel-gfx] [CI 6/9] drm/i915: switch intel_uncore_forcewake_for_reg to intel_uncore

2019-03-26 Thread Chris Wilson
From: Daniele Ceraolo Spurio The intel_uncore structure is the owner of FW, so subclass the function to it. While at it, use a local uncore var and switch to the new read/write functions where it makes sense. Signed-off-by: Daniele Ceraolo Spurio Cc: Paulo Zanoni Cc: Chris Wilson

[Intel-gfx] [CI 2/9] drm/i915: add HAS_FORCEWAKE flag to uncore

2019-03-26 Thread Chris Wilson
From: Daniele Ceraolo Spurio We have several cases where we don't have forcewake (older gens, GVT and planned display-only uncore), so, instead of checking every time against the various condition, save the info in a flag and use that. Note that this patch also change the behavior for gen5 with

[Intel-gfx] [CI 8/9] drm/i915: switch intel_wait_for_register to uncore

2019-03-26 Thread Chris Wilson
From: Daniele Ceraolo Spurio The intel_uncore structure is the owner of register access, so subclass the function to it. While at it, use a local uncore var and switch to the new read/write functions where it makes sense. Signed-off-by: Daniele Ceraolo Spurio Cc: Paulo Zanoni Cc: Chris

[Intel-gfx] [CI 7/9] drm/i915: intel_wait_for_register_fw to uncore

2019-03-26 Thread Chris Wilson
From: Daniele Ceraolo Spurio The intel_uncore structure is the owner of register access, so subclass the function to it. While at it, use a local uncore var and switch to the new read/write functions where it makes sense. Signed-off-by: Daniele Ceraolo Spurio Cc: Paulo Zanoni Cc: Chris

[Intel-gfx] [CI 4/9] drm/i915: take a ref to the rpm in the uncore structure

2019-03-26 Thread Chris Wilson
From: Daniele Ceraolo Spurio Remove a bit of pointer dancing in the reg access path. Signed-off-by: Daniele Ceraolo Spurio Cc: Paulo Zanoni Cc: Chris Wilson Signed-off-by: Chris Wilson Link:

[Intel-gfx] [CI 1/9] drm/i915: rename raw reg access functions

2019-03-26 Thread Chris Wilson
From: Daniele Ceraolo Spurio They now work on uncore, so use raw_uncore_ prefix. Also move them to uncore.h Signed-off-by: Daniele Ceraolo Spurio Cc: Paulo Zanoni Cc: Chris Wilson Reviewed-by: Paulo Zanoni Signed-off-by: Chris Wilson Link:

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/selftests: Fix an IS_ERR() vs NULL check

2019-03-26 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Fix an IS_ERR() vs NULL check URL : https://patchwork.freedesktop.org/series/58557/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5815_full -> Patchwork_12598_full Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Update size upon return from GEM_CREATE (rev2)

2019-03-26 Thread Patchwork
== Series Details == Series: drm/i915: Update size upon return from GEM_CREATE (rev2) URL : https://patchwork.freedesktop.org/series/58592/ State : warning == Summary == $ dim checkpatch origin/drm-tip 6fac14bf9f60 drm/i915: Update size upon return from GEM_CREATE -:15:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Only reset the pinned kernel contexts on resume

2019-03-26 Thread Patchwork
== Series Details == Series: drm/i915: Only reset the pinned kernel contexts on resume URL : https://patchwork.freedesktop.org/series/58589/ State : success == Summary == CI Bug Log - changes from CI_DRM_5818 -> Patchwork_12603 Summary

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Only reset the pinned kernel contexts on resume

2019-03-26 Thread Patchwork
== Series Details == Series: drm/i915: Only reset the pinned kernel contexts on resume URL : https://patchwork.freedesktop.org/series/58589/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Only reset the pinned kernel contexts on resume

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Do not enable FEC without DSC

2019-03-26 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Do not enable FEC without DSC URL : https://patchwork.freedesktop.org/series/58588/ State : success == Summary == CI Bug Log - changes from CI_DRM_5818 -> Patchwork_12602

Re: [Intel-gfx] [PATCH 8/9] drm/i915: switch intel_wait_for_register to uncore

2019-03-26 Thread kbuild test robot
Hi Daniele, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on next-20190326] [cannot apply to v5.1-rc2] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/6] drm/i915: Add broadcast RGB property for DP MST

2019-03-26 Thread Patchwork
== Series Details == Series: series starting with [v2,1/6] drm/i915: Add broadcast RGB property for DP MST URL : https://patchwork.freedesktop.org/series/58585/ State : success == Summary == CI Bug Log - changes from CI_DRM_5818 -> Patchwork_12601

[Intel-gfx] [PATCH i-g-t] i915/gem_exec_big: 128MiB not enough slack? Let out the rope!

2019-03-26 Thread Chris Wilson
Even with 128MiB reserved for other use, a single pass of gem_exec_big runs out of memory. Give in and halve our batch size, that has to be enough slack! As to why it keeps on failing, is left as an exercise to the reader -- we have to solve the mm/ mystery one day, as eventually it will be our

[Intel-gfx] ✗ Fi.CI.IGT: failure for Do not re-read dpll registers (rev3)

2019-03-26 Thread Patchwork
== Series Details == Series: Do not re-read dpll registers (rev3) URL : https://patchwork.freedesktop.org/series/58382/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5815_full -> Patchwork_12597_full Summary ---

Re: [Intel-gfx] [PATCH 02/16] drm/fb-helper: dpms_legacy(): Only set on connectors in use

2019-03-26 Thread Daniel Vetter
On Tue, Mar 26, 2019 at 06:55:32PM +0100, Noralf Trønnes wrote: > For each enabled crtc the functions sets dpms on all registered connectors. > Limit this to only doing it once and on the connectors actually in use. > > Signed-off-by: Noralf Trønnes Fixes: 023eb571a1d0 ("drm: correctly update

Re: [Intel-gfx] [PATCH 01/16] drm/fb-helper: Remove unused gamma_size variable

2019-03-26 Thread Daniel Vetter
On Tue, Mar 26, 2019 at 06:55:31PM +0100, Noralf Trønnes wrote: > The gamma_size variable has not been used since > commit 4abe35204af8 ("drm/kms/fb: use slow work mechanism for normal hotplug > also.") > > While in the area move a comment back to its code block. > They got separated by > commit

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v2,1/6] drm/i915: Add broadcast RGB property for DP MST

2019-03-26 Thread Patchwork
== Series Details == Series: series starting with [v2,1/6] drm/i915: Add broadcast RGB property for DP MST URL : https://patchwork.freedesktop.org/series/58585/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Add broadcast RGB property for

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [01/21] drm/fb-helper: Add fill_info() functions

2019-03-26 Thread Patchwork
== Series Details == Series: series starting with [01/21] drm/fb-helper: Add fill_info() functions URL : https://patchwork.freedesktop.org/series/58578/ State : success == Summary == CI Bug Log - changes from CI_DRM_5818 -> Patchwork_12600

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/6] drm/i915: Add broadcast RGB property for DP MST

2019-03-26 Thread Patchwork
== Series Details == Series: series starting with [v2,1/6] drm/i915: Add broadcast RGB property for DP MST URL : https://patchwork.freedesktop.org/series/58585/ State : warning == Summary == $ dim checkpatch origin/drm-tip 18c4bad008ca drm/i915: Add broadcast RGB property for DP MST

Re: [Intel-gfx] [PATCH] drm/i915: Adding missing '; ' to ENGINE_INSTANCES

2019-03-26 Thread Tvrtko Ursulin
On 26/03/2019 18:00, Chris Wilson wrote: Tvrtko spotted that I left off the trailing ';'. It went unnoticed by CI because despite adding the macro, we didn't add a user, so include one as well (a simple debug print). Reported-by: Tvrtko Ursulin Fixes: 97ee6e925552 ("drm/i915: stop storing

Re: [Intel-gfx] [PATCH 4/4] drm/uapi: Remove unused DRM_DISPLAY_INFO_LEN

2019-03-26 Thread Daniel Vetter
On Tue, Mar 26, 2019 at 07:34:01PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Remove the unused DRM_DISPLAY_INFO_LEN from the uapi headers. > I presume the original plan was to expose the display name > via getconnector, but looks like that never happened. So we have > the define for

Re: [Intel-gfx] [PATCH 3/4] drm: Kill drm_display_info.name

2019-03-26 Thread Daniel Vetter
On Tue, Mar 26, 2019 at 07:34:00PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > drm_display_info.name is only ever set by a few panel drveirs but > never actually used anywhere except in i915 debugfs code. Trash it. > > Signed-off-by: Ville Syrjälä Huh, nice find. Reviewed-by:

Re: [Intel-gfx] [PATCH 2/4] drm: Fix tabs vs. spaces

2019-03-26 Thread Daniel Vetter
On Tue, Mar 26, 2019 at 07:33:59PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > A set of 8 spaces has snuck in. Replace with a tab, and > toss in an extra newline while at it. > > Signed-off-by: Ville Syrjälä > --- > include/drm/drm_connector.h | 3 ++- > 1 file changed, 2

Re: [Intel-gfx] [PATCH 1/4] drm: Nuke unused drm_display_info.pixel_clock

2019-03-26 Thread Daniel Vetter
On Tue, Mar 26, 2019 at 07:33:58PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > drm_display_info.pixel_clock is unused. Let's get rid of it. > > Signed-off-by: Ville Syrjälä > --- > include/drm/drm_connector.h | 6 -- > 1 file changed, 6 deletions(-) > > diff --git

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Do not enable FEC without DSC

2019-03-26 Thread Manasi Navare
On Tue, Mar 26, 2019 at 06:16:57PM +0200, Ville Syrjälä wrote: > On Tue, Mar 26, 2019 at 09:00:27AM -0700, Manasi Navare wrote: > > On Tue, Mar 26, 2019 at 04:49:02PM +0200, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Currently we enable FEC even when DSC is no used. While that is

[Intel-gfx] [PATCH 15/16] drm/client: Hack: Add bootsplash example

2019-03-26 Thread Noralf Trønnes
An example to showcase the client API. TODO: A bootsplash client needs a way to tell drm_fb_helper to stay away, otherwise it will chime in on setup and hotplug. Most DRM drivers register fbdev before calling drm_dev_register() (the generic emulation is an exception). This have to be reversed for

[Intel-gfx] [PATCH 16/16] drm/vc4: Call drm_dev_register() after all setup is done

2019-03-26 Thread Noralf Trønnes
drm_dev_register() initializes internal clients like bootsplash as the last thing it does, so all setup needs to be done at this point. Fix by calling vc4_kms_load() before registering. Also check the error code returned from that function. Cc: Eric Anholt Signed-off-by: Noralf Trønnes ---

[Intel-gfx] [PATCH 14/16] drm/client: Add display abstraction

2019-03-26 Thread Noralf Trønnes
Add display abstraction and helpers to probe for displays and commit modesets. TODO: If the bootsplash client doesn't need to subclass drm_client_display, the callbacks can be removed. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_client.c | 415 +++

[Intel-gfx] [PATCH 12/16] drm/fb-helper: Move out modeset config code

2019-03-26 Thread Noralf Trønnes
No functional changes, just moving code as-is and fixing includes. There is one addition and that is exporting drm_client_modesets_probe(). Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_client.c| 698 drivers/gpu/drm/drm_fb_helper.c | 697

[Intel-gfx] [PATCH 13/16] drm/fb-helper: Avoid race with DRM userspace

2019-03-26 Thread Noralf Trønnes
drm_fb_helper_is_bound() is used to check if DRM userspace is in control. This is done by looking at the fb on the primary plane. By the time fb-helper gets around to committing, it's possible that the facts have changed. Avoid this race by holding the drm_device->master_mutex lock while

[Intel-gfx] [PATCH 10/16] drm/fb-helper: Remove drm_fb_helper_connector

2019-03-26 Thread Noralf Trønnes
All drivers add all their connectors so there's no need to keep around an array of available connectors. Rename functions which signature is changed since they will be moved to drm_client in a later patch. Signed-off-by: Noralf Trønnes --- checkpatch complains, but I'm unable to satisfy it:

[Intel-gfx] [PATCH 11/16] drm/fb-helper: Prepare to move out modeset config code

2019-03-26 Thread Noralf Trønnes
This prepares the modeset code so it can be moved out as-is in the next patch. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_fb_helper.c | 75 + include/drm/drm_fb_helper.h | 4 -- 2 files changed, 57 insertions(+), 22 deletions(-) diff --git

[Intel-gfx] [PATCH] drm/i915: Adding missing '; ' to ENGINE_INSTANCES

2019-03-26 Thread Chris Wilson
Tvrtko spotted that I left off the trailing ';'. It went unnoticed by CI because despite adding the macro, we didn't add a user, so include one as well (a simple debug print). Reported-by: Tvrtko Ursulin Fixes: 97ee6e925552 ("drm/i915: stop storing the media fuse") Signed-off-by: Chris Wilson

[Intel-gfx] [PATCH 06/16] drm/i915/fbdev: Move intel_fb_initial_config() to fbdev helper

2019-03-26 Thread Noralf Trønnes
It is generic code and having it in the helper will let other drivers benefit from it. One change was necessary assuming this to be true: INTEL_INFO(dev_priv)->num_pipes == dev->mode_config.num_crtc Suggested-by: Daniel Vetter Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc:

[Intel-gfx] [PATCH 08/16] drm/fb-helper: Prepare to move out commit code

2019-03-26 Thread Noralf Trønnes
This makes the necessary changes so the commit code can be moved out to drm_client as-is in the next patch. It's split up to ease review. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_fb_helper.c | 93 + 1 file changed, 59 insertions(+), 34 deletions(-)

[Intel-gfx] [PATCH 03/16] drm/atomic: Move __drm_atomic_helper_disable_plane/set_config()

2019-03-26 Thread Noralf Trønnes
Prepare for moving drm_fb_helper modesetting code to drm_client. drm_client will be linked to drm.ko, so move __drm_atomic_helper_disable_plane() and __drm_atomic_helper_set_config() out of drm_kms_helper.ko. While at it, fix two checkpatch complaints: - WARNING: Block comments use a trailing */

[Intel-gfx] [PATCH 02/16] drm/fb-helper: dpms_legacy(): Only set on connectors in use

2019-03-26 Thread Noralf Trønnes
For each enabled crtc the functions sets dpms on all registered connectors. Limit this to only doing it once and on the connectors actually in use. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_fb_helper.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git

[Intel-gfx] [PATCH 09/16] drm/fb-helper: Move out commit code

2019-03-26 Thread Noralf Trønnes
Move the modeset commit code to drm_client. No changes except exporting API. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_client.c| 236 drivers/gpu/drm/drm_fb_helper.c | 232 --- include/drm/drm_client.h| 3 +

[Intel-gfx] [PATCH 07/16] drm/fb-helper: Remove drm_fb_helper_crtc

2019-03-26 Thread Noralf Trønnes
It now only contains the modeset so use that directly instead. The modeset code will be moved to drm_client, so add code there. The modeset connector array size is hardcoded for the cloned case to avoid having to pass in a value from the driver. A value of 8 is chosen to err on the safe side.

[Intel-gfx] [PATCH 04/16] drm/fb-helper: No need to cache rotation and sw_rotations

2019-03-26 Thread Noralf Trønnes
Getting rotation info is cheap so we can do it on demand. This is done in preparation for the removal of struct drm_fb_helper_crtc. Cc: Hans de Goede Signed-off-by: Noralf Trønnes --- Hans, You had this comment inline in restore_fbdev_mode_atomic() the last time I sent this out: We want

[Intel-gfx] [PATCH 01/16] drm/fb-helper: Remove unused gamma_size variable

2019-03-26 Thread Noralf Trønnes
The gamma_size variable has not been used since commit 4abe35204af8 ("drm/kms/fb: use slow work mechanism for normal hotplug also.") While in the area move a comment back to its code block. They got separated by commit d50ba256b5f1 ("drm/kms: start adding command line interface using fb.").

[Intel-gfx] [PATCH 00/16] drm/fb-helper: Move modesetting code to drm_client

2019-03-26 Thread Noralf Trønnes
This moves the modesetting code from drm_fb_helper to drm_client so it can be shared by all internal clients. I have also added a client display abstraction and a bootsplash example client to show where this might be heading. Hopefully Max Staudt will be able to pick up his bootsplash work now.

[Intel-gfx] [PATCH 05/16] drm/fb-helper: Remove drm_fb_helper_crtc->{x, y, desired_mode}

2019-03-26 Thread Noralf Trønnes
The values are already present in the modeset. This is done in preparation for the removal of struct drm_fb_helper_crtc. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_fb_helper.c | 12 include/drm/drm_fb_helper.h | 2 -- 2 files changed, 4 insertions(+), 10

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [01/21] drm/fb-helper: Add fill_info() functions

2019-03-26 Thread Patchwork
== Series Details == Series: series starting with [01/21] drm/fb-helper: Add fill_info() functions URL : https://patchwork.freedesktop.org/series/58578/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/fb-helper: Add fill_info() functions Okay!

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/21] drm/fb-helper: Add fill_info() functions

2019-03-26 Thread Patchwork
== Series Details == Series: series starting with [01/21] drm/fb-helper: Add fill_info() functions URL : https://patchwork.freedesktop.org/series/58578/ State : warning == Summary == $ dim checkpatch origin/drm-tip 14d8e1994710 drm/fb-helper: Add fill_info() functions -:17:

[Intel-gfx] [PATCH 4/4] drm/uapi: Remove unused DRM_DISPLAY_INFO_LEN

2019-03-26 Thread Ville Syrjala
From: Ville Syrjälä Remove the unused DRM_DISPLAY_INFO_LEN from the uapi headers. I presume the original plan was to expose the display name via getconnector, but looks like that never happened. So we have the define for the length of the string but no string anywhere. A quick scan didn't seem

[Intel-gfx] [PATCH 1/4] drm: Nuke unused drm_display_info.pixel_clock

2019-03-26 Thread Ville Syrjala
From: Ville Syrjälä drm_display_info.pixel_clock is unused. Let's get rid of it. Signed-off-by: Ville Syrjälä --- include/drm/drm_connector.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h index bb3bd8e1633a..fcdca46e0c24

[Intel-gfx] [PATCH 3/4] drm: Kill drm_display_info.name

2019-03-26 Thread Ville Syrjala
From: Ville Syrjälä drm_display_info.name is only ever set by a few panel drveirs but never actually used anywhere except in i915 debugfs code. Trash it. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_debugfs.c| 1 - drivers/gpu/drm/panel/panel-arm-versatile.c

[Intel-gfx] [PATCH 2/4] drm: Fix tabs vs. spaces

2019-03-26 Thread Ville Syrjala
From: Ville Syrjälä A set of 8 spaces has snuck in. Replace with a tab, and toss in an extra newline while at it. Signed-off-by: Ville Syrjälä --- include/drm/drm_connector.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/drm/drm_connector.h

Re: [Intel-gfx] [PATCH v2] drm/i915: Update size upon return from GEM_CREATE

2019-03-26 Thread Chris Wilson
Quoting Vanshidhar Konda (2019-03-26 17:29:07) > On Tue, Mar 26, 2019 at 06:02:18PM +0100, Michał Winiarski wrote: > >Since GEM_CREATE is trying to outsmart the user by rounding up unaligned > >objects, we used to update the size returned to userspace. > >This update seems to have been lost

Re: [Intel-gfx] [PATCH v2] drm/i915: Update size upon return from GEM_CREATE

2019-03-26 Thread Vanshidhar Konda
On Tue, Mar 26, 2019 at 06:02:18PM +0100, Michał Winiarski wrote: Since GEM_CREATE is trying to outsmart the user by rounding up unaligned objects, we used to update the size returned to userspace. This update seems to have been lost throughout the history. v2: Use round_up(), reorder locals

Re: [Intel-gfx] [PATCH 2/3] iris: Create a composite context for both compute and render pipelines

2019-03-26 Thread Chris Wilson
Quoting Kenneth Graunke (2019-03-26 17:01:57) > On Tuesday, March 26, 2019 12:16:20 AM PDT Chris Wilson wrote: > > Quoting Kenneth Graunke (2019-03-26 05:52:10) > > > On Monday, March 25, 2019 3:58:59 AM PDT Chris Wilson wrote: > > > > iris currently uses two distinct GEM contexts to have distinct

Re: [Intel-gfx] [PATCH 2/3] iris: Create a composite context for both compute and render pipelines

2019-03-26 Thread Kenneth Graunke
On Tuesday, March 26, 2019 12:16:20 AM PDT Chris Wilson wrote: > Quoting Kenneth Graunke (2019-03-26 05:52:10) > > On Monday, March 25, 2019 3:58:59 AM PDT Chris Wilson wrote: > > > iris currently uses two distinct GEM contexts to have distinct logical > > > HW contexts for the compute and render

[Intel-gfx] [PATCH v2] drm/i915: Update size upon return from GEM_CREATE

2019-03-26 Thread Michał Winiarski
Since GEM_CREATE is trying to outsmart the user by rounding up unaligned objects, we used to update the size returned to userspace. This update seems to have been lost throughout the history. v2: Use round_up(), reorder locals (Chris) References: ff72145badb8 ("drm: dumb scanout create/mmap for

[Intel-gfx] ✓ Fi.CI.IGT: success for more uncore rework

2019-03-26 Thread Patchwork
== Series Details == Series: more uncore rework URL : https://patchwork.freedesktop.org/series/58550/ State : success == Summary == CI Bug Log - changes from CI_DRM_5814_full -> Patchwork_12596_full Summary --- **SUCCESS** No

Re: [Intel-gfx] [PATCH] drm/i915: Update size upon return from GEM_CREATE

2019-03-26 Thread Chris Wilson
Quoting Michał Winiarski (2019-03-26 16:33:45) > Since GEM_CREATE is trying to outsmart the user by rounding up unaligned > objects, we used to update the size returned to userspace. > This update seems to have been lost throughout the history. > > References: ff72145badb8 ("drm: dumb scanout

[Intel-gfx] [PATCH] drm/i915: Update size upon return from GEM_CREATE

2019-03-26 Thread Michał Winiarski
Since GEM_CREATE is trying to outsmart the user by rounding up unaligned objects, we used to update the size returned to userspace. This update seems to have been lost throughout the history. References: ff72145badb8 ("drm: dumb scanout create/mmap for intel/radeon (v3)") Signed-off-by: Michał

[Intel-gfx] ✓ Fi.CI.BAT: success for Device id consolidation

2019-03-26 Thread Patchwork
== Series Details == Series: Device id consolidation URL : https://patchwork.freedesktop.org/series/58561/ State : success == Summary == CI Bug Log - changes from CI_DRM_5817 -> Patchwork_12599 Summary --- **SUCCESS** No

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Do not enable FEC without DSC

2019-03-26 Thread Ville Syrjälä
On Tue, Mar 26, 2019 at 09:00:27AM -0700, Manasi Navare wrote: > On Tue, Mar 26, 2019 at 04:49:02PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Currently we enable FEC even when DSC is no used. While that is > > theoretically valid supposedly there isn't much of a benefit from >

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Device id consolidation

2019-03-26 Thread Patchwork
== Series Details == Series: Device id consolidation URL : https://patchwork.freedesktop.org/series/58561/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Split Pineview device info into desktop and mobile

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Clean up DSC vs. not bpp handling

2019-03-26 Thread Manasi Navare
On Tue, Mar 26, 2019 at 04:49:03PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > No point in duplicating all this code when we can just > use a variable top hold the output bpp (the only thing > that differs between the two branches). > > Cc: Anusha Srivatsa > Cc: Manasi Navare >

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Device id consolidation

2019-03-26 Thread Patchwork
== Series Details == Series: Device id consolidation URL : https://patchwork.freedesktop.org/series/58561/ State : warning == Summary == $ dim checkpatch origin/drm-tip caf40a504a05 drm/i915: Split Pineview device info into desktop and mobile 1a9cbf3aa2a4 drm/i915: Remove redundant device id

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Do not enable FEC without DSC

2019-03-26 Thread Manasi Navare
On Tue, Mar 26, 2019 at 04:49:02PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Currently we enable FEC even when DSC is no used. While that is > theoretically valid supposedly there isn't much of a benefit from > this. But more importantly we do not account for the FEC link > bandwidth

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: stop storing the media fuse (rev2)

2019-03-26 Thread Patchwork
== Series Details == Series: drm/i915: stop storing the media fuse (rev2) URL : https://patchwork.freedesktop.org/series/58387/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5814_full -> Patchwork_12595_full Summary

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 17/24] i915: Add gem_ctx_clone

2019-03-26 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-03-26 15:44:35) > > On 22/03/2019 09:21, Chris Wilson wrote: > > +static void clone_vm(int i915) > > +{ > > + struct drm_i915_gem_context_create_ext_setparam set = { > > + { .name = I915_CONTEXT_CREATE_EXT_SETPARAM }, > > + { .param =

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 17/24] i915: Add gem_ctx_clone

2019-03-26 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-03-26 15:44:35) > > On 22/03/2019 09:21, Chris Wilson wrote: > > +static void clone_engines(int i915) > > +{ > > + struct drm_i915_gem_context_create_ext_setparam set = { > > + { .name = I915_CONTEXT_CREATE_EXT_SETPARAM }, > > + { .param =

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 17/24] i915: Add gem_ctx_clone

2019-03-26 Thread Tvrtko Ursulin
On 22/03/2019 09:21, Chris Wilson wrote: Exercise cloning contexts, an extension of merely creating one. Signed-off-by: Chris Wilson --- tests/Makefile.sources | 1 + tests/i915/gem_ctx_clone.c | 421 + tests/meson.build | 1 + 3 files

[Intel-gfx] [PATCH] drm/i915: Only reset the pinned kernel contexts on resume

2019-03-26 Thread Chris Wilson
On resume, we know that the only pinned contexts in danger of seeing corruption are the kernel context, and so we do not need to walk the list of all GEM contexts as we tracked them on each engine. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_drv.h| 1 -

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Fix an IS_ERR() vs NULL check

2019-03-26 Thread Dan Carpenter
On Tue, Mar 26, 2019 at 02:53:49PM +, Chris Wilson wrote: > Quoting Mika Kuoppala (2019-03-26 09:30:57) > > Dan Carpenter writes: > > > > > The live_context() function returns error pointers. It never returns > > > NULL. > > > > > > Fixes: 9c1477e83e62 ("drm/i915/selftests: Exercise adding

Re: [Intel-gfx] [PATCH] drm/fbdev: Make skip_vt_switch the default

2019-03-26 Thread Daniel Vetter
On Wed, Nov 28, 2018 at 8:17 AM Maarten Lankhorst wrote: > > Op 27-11-18 om 18:34 schreef Daniel Vetter: > > KMS drivers really should all be able to restore their display state > > on resume without fbcon helping out. So make this the default. > > > > Since I'm not entirely foolish, make it only

  1   2   3   >