[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v2,1/5] drm/i915/psr: Add bits per pixel limitation (rev3)

2019-11-28 Thread Patchwork
== Series Details == Series: series starting with [v2,1/5] drm/i915/psr: Add bits per pixel limitation (rev3) URL : https://patchwork.freedesktop.org/series/70002/ State : success == Summary == CI Bug Log - changes from CI_DRM_7434_full -> Patchwork_15479_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display: Suspend MST topology manager before destroy fbdev (rev3)

2019-11-28 Thread Patchwork
== Series Details == Series: drm/i915/display: Suspend MST topology manager before destroy fbdev (rev3) URL : https://patchwork.freedesktop.org/series/70081/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7434_full -> Patchwork_15477_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [CI,1/3] drm/i915: Handle SDEISR according to PCH rather than platform

2019-11-28 Thread Patchwork
== Series Details == Series: series starting with [CI,1/3] drm/i915: Handle SDEISR according to PCH rather than platform URL : https://patchwork.freedesktop.org/series/70130/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7434_full -> Patchwork_15476_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dsb: fix cmd_buf being wrongly set

2019-11-28 Thread Patchwork
== Series Details == Series: drm/i915/dsb: fix cmd_buf being wrongly set URL : https://patchwork.freedesktop.org/series/70129/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7434_full -> Patchwork_15475_full Summary ---

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Cleanups around pre/post plane update

2019-11-28 Thread Patchwork
== Series Details == Series: drm/i915: Cleanups around pre/post plane update URL : https://patchwork.freedesktop.org/series/70125/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7434_full -> Patchwork_15473_full Summary

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gen7: Re-enable full-ppgtt for ivb & hsw

2019-11-28 Thread Patchwork
== Series Details == Series: drm/i915/gen7: Re-enable full-ppgtt for ivb & hsw URL : https://patchwork.freedesktop.org/series/70184/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7439 -> Patchwork_15504 Summary ---

[Intel-gfx] [CI] drm/i915/gen7: Re-enable full-ppgtt for ivb & hsw

2019-11-28 Thread Chris Wilson
After much hair pulling, resort to preallocating the ppGTT entries on init to circumvent the apparent lack of PD invalidate following the write to PP_DCLV upon switching mm between contexts (and here the same context after binding new objects). However, the details of that PP_DCLV invalidate are

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Use sgt_iter for huge_pages_free

2019-11-28 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Use sgt_iter for huge_pages_free URL : https://patchwork.freedesktop.org/series/70183/ State : success == Summary == CI Bug Log - changes from CI_DRM_7439 -> Patchwork_15503 Summary ---

[Intel-gfx] ✗ Fi.CI.IGT: failure for Enable second DBuf slice for ICL and TGL (rev2)

2019-11-28 Thread Patchwork
== Series Details == Series: Enable second DBuf slice for ICL and TGL (rev2) URL : https://patchwork.freedesktop.org/series/70059/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7434_full -> Patchwork_15469_full Summary

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gem: Unbind all current vma on changing cache-level

2019-11-28 Thread Patchwork
== Series Details == Series: drm/i915/gem: Unbind all current vma on changing cache-level URL : https://patchwork.freedesktop.org/series/70182/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7439 -> Patchwork_15502 Summary

[Intel-gfx] [PATCH] drm/i915/selftests: Use sgt_iter for huge_pages_free

2019-11-28 Thread Chris Wilson
Use the normal sgt_iter to walk the pages scatterlist on free so that we handle the error path correctly. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gem/selftests/huge_gem_object.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gen7: Re-enable full-ppgtt for ivb, byt, hsw (rev6)

2019-11-28 Thread Patchwork
== Series Details == Series: drm/i915/gen7: Re-enable full-ppgtt for ivb, byt, hsw (rev6) URL : https://patchwork.freedesktop.org/series/70089/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7439 -> Patchwork_15501 Summary

[Intel-gfx] [PATCH] drm/i915/gem: Unbind all current vma on changing cache-level

2019-11-28 Thread Chris Wilson
Avoid dangerous race handling of destroyed vma by unbinding all vma instead. Unfortunately, this stops us from trying to be clever and only doing the minimal change required, so on first use of scanout we may encounter an annoying stall as it transitions to a new cache level. Bugzilla:

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET (rev4)

2019-11-28 Thread Patchwork
== Series Details == Series: drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET (rev4) URL : https://patchwork.freedesktop.org/series/70164/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7439 -> Patchwork_15500 Summary ---

[Intel-gfx] [CI] drm/i915/gen7: Re-enable full-ppgtt for ivb, byt, hsw

2019-11-28 Thread Chris Wilson
After much hair pulling, resort to preallocating the ppGTT entries on init to circumvent the apparent lack of PD invalidate following the write to PP_DCLV upon switching mm between contexts (and here the same context after binding new objects). However, the details of that PP_DCLV invalidate are

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET (rev4)

2019-11-28 Thread Patchwork
== Series Details == Series: drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET (rev4) URL : https://patchwork.freedesktop.org/series/70164/ State : warning == Summary == $ dim checkpatch origin/drm-tip 10bf09ee7e6e drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET -:466: WARNING:UNNECESSARY_ELSE: else

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,1/2] drm/i915/selftests: Drop local vm reference!

2019-11-28 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915/selftests: Drop local vm reference! URL : https://patchwork.freedesktop.org/series/70177/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7438 -> Patchwork_15499

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Drop local vm reference!

2019-11-28 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Drop local vm reference! URL : https://patchwork.freedesktop.org/series/70176/ State : success == Summary == CI Bug Log - changes from CI_DRM_7438 -> Patchwork_15498 Summary ---

[Intel-gfx] ✗ Fi.CI.IGT: failure for adding gamma state checker for icl+ platforms (rev7)

2019-11-28 Thread Patchwork
== Series Details == Series: adding gamma state checker for icl+ platforms (rev7) URL : https://patchwork.freedesktop.org/series/66811/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7432_full -> Patchwork_15468_full

[Intel-gfx] [CI] drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET

2019-11-28 Thread Chris Wilson
From: Abdiel Janulgue This is really just an alias of mmap_gtt. The 'mmap offset' nomenclature comes from the value returned by this ioctl which is the offset into the device fd which userpace uses with mmap(2). mmap_gtt was our initial mmap_offset implementation, this extends our CPU mmap

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Use the correct PCH transcoder for LPT/WPT in intel_sanitize_frame_start_delay()

2019-11-28 Thread Patchwork
== Series Details == Series: drm/i915: Use the correct PCH transcoder for LPT/WPT in intel_sanitize_frame_start_delay() URL : https://patchwork.freedesktop.org/series/70175/ State : success == Summary == CI Bug Log - changes from CI_DRM_7438 -> Patchwork_15496

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET (rev3)

2019-11-28 Thread Patchwork
== Series Details == Series: drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET (rev3) URL : https://patchwork.freedesktop.org/series/70164/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7438 -> Patchwork_15495 Summary ---

Re: [Intel-gfx] [CI 1/2] drm/i915/selftests: Drop local vm reference!

2019-11-28 Thread Matthew Auld
On Thu, 28 Nov 2019 at 18:54, Chris Wilson wrote: > > After obtaining a local reference to the vm from the context, remember > to drop it before it goes out of scope! > > Signed-off-by: Chris Wilson > Cc: Matthew Auld Reviewed-by: Matthew Auld ___

Re: [Intel-gfx] [PATCH 06/11] drm/i915: Enable big joiner support in enable and disable sequences.

2019-11-28 Thread Ville Syrjälä
On Thu, Nov 14, 2019 at 05:05:17PM +0100, Maarten Lankhorst wrote: > Make vdsc work when no output is enabled. The big joiner needs VDSC > on the slave, so enable it and set the appropriate bits. > Also update timestamping constants, because slave crtc's are not > updated in

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET (rev3)

2019-11-28 Thread Patchwork
== Series Details == Series: drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET (rev3) URL : https://patchwork.freedesktop.org/series/70164/ State : warning == Summary == $ dim checkpatch origin/drm-tip 43e747a40343 drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET -:465: WARNING:UNNECESSARY_ELSE: else

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pmu: Report frequency as zero while GPU is sleeping

2019-11-28 Thread Patchwork
== Series Details == Series: drm/i915/pmu: Report frequency as zero while GPU is sleeping URL : https://patchwork.freedesktop.org/series/70168/ State : success == Summary == CI Bug Log - changes from CI_DRM_7438 -> Patchwork_15494 Summary

Re: [Intel-gfx] [PATCH 05/11] drm/i915: Try to make bigjoiner work in atomic check, v3.

2019-11-28 Thread Ville Syrjälä
On Thu, Nov 14, 2019 at 05:05:16PM +0100, Maarten Lankhorst wrote: > When the clock is higher than the dotclock, try with 2 pipes enabled. > If we can enable 2, then we will go into big joiner mode, and steal > the adjacent crtc. > > This only links the crtc's in software, no hardware or plane >

Re: [Intel-gfx] [PATCH 04/11] drm/i915/dp: Allow big joiner modes in intel_dp_mode_valid(), v3.

2019-11-28 Thread Ville Syrjälä
On Thu, Nov 14, 2019 at 05:05:15PM +0100, Maarten Lankhorst wrote: > Small changes to intel_dp_mode_valid(), allow listing modes that > can only be supported in the bigjoiner configuration, which is > not supported yet. > > eDP does not support bigjoiner, so do not expose bigjoiner only > modes

[Intel-gfx] [CI 2/2] drm/i915/gen7: Re-enable full-ppgtt for ivb, byt, hsw

2019-11-28 Thread Chris Wilson
After much hair pulling, resort to preallocating the ppGTT entries on init to circumvent the apparent lack of PD invalidate following the write to PP_DCLV upon switching mm between contexts (and here the same context after binding new objects). However, the details of that PP_DCLV invalidate are

[Intel-gfx] [CI 1/2] drm/i915/selftests: Drop local vm reference!

2019-11-28 Thread Chris Wilson
After obtaining a local reference to the vm from the context, remember to drop it before it goes out of scope! Signed-off-by: Chris Wilson Cc: Matthew Auld --- .../drm/i915/gem/selftests/i915_gem_context.c | 34 --- 1 file changed, 15 insertions(+), 19 deletions(-) diff --git

[Intel-gfx] [PATCH] drm/i915/selftests: Drop local vm reference!

2019-11-28 Thread Chris Wilson
After obtaining a local reference to the vm from the context, remember to drop it before it goes out of scope! Signed-off-by: Chris Wilson Cc: Matthew Auld --- .../drm/i915/gem/selftests/i915_gem_context.c | 34 --- 1 file changed, 15 insertions(+), 19 deletions(-) diff --git

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gt: Defer breadcrumb processing to after the irq handler

2019-11-28 Thread Patchwork
== Series Details == Series: drm/i915/gt: Defer breadcrumb processing to after the irq handler URL : https://patchwork.freedesktop.org/series/70109/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7432_full -> Patchwork_15465_full

Re: [Intel-gfx] [PATCH v6 1/4] drm/i915: Remove skl_ddl_allocation struct

2019-11-28 Thread Ville Syrjälä
On Thu, Nov 28, 2019 at 05:39:55PM +, Lisovskiy, Stanislav wrote: > On Thu, 2019-11-28 at 18:13 +0200, Ville Syrjälä wrote: > > On Wed, Nov 27, 2019 at 04:41:25PM +0200, Stanislav Lisovskiy wrote: > > > Current consensus that it is redundant as > > > we already have skl_ddb_values struct out

Re: [Intel-gfx] [PATCH 6/7] drm/i915/display/tgl: Fix the order of the step to turn transcoder clock off

2019-11-28 Thread Ville Syrjälä
On Fri, Nov 22, 2019 at 04:54:58PM -0800, José Roberto de Souza wrote: > For TGL the step to turn off the transcoder clock was moved to after > the complete shutdown of DDI. Only the MST slave transcoders should > disable the clock before that. > > BSpec: 49190 > Signed-off-by: José Roberto de

Re: [Intel-gfx] [PATCH 5/7] drm/i915/display/mst: Move DPMS_OFF call to post_disable

2019-11-28 Thread Ville Syrjälä
On Fri, Nov 22, 2019 at 04:54:57PM -0800, José Roberto de Souza wrote: > Moving just to simplify handling as there is no change in behavior. lgtm Reviewed-by: Ville Syrjälä > > Cc: Lucas De Marchi > Signed-off-by: José Roberto de Souza > --- > drivers/gpu/drm/i915/display/intel_ddi.c|

Re: [Intel-gfx] [PATCH 4/7] drm/i915/dp: Power down sink before disable pipe/transcoder clock

2019-11-28 Thread Ville Syrjälä
On Thu, Nov 28, 2019 at 01:08:36AM +, Souza, Jose wrote: > On Wed, 2019-11-27 at 21:24 +0200, Ville Syrjälä wrote: > > On Tue, Nov 26, 2019 at 10:12:52PM +, Souza, Jose wrote: > > > On Tue, 2019-11-26 at 22:15 +0200, Ville Syrjälä wrote: > > > > On Fri, Nov 22, 2019 at 04:54:56PM -0800,

[Intel-gfx] [PATCH] drm/i915: Use the correct PCH transcoder for LPT/WPT in intel_sanitize_frame_start_delay()

2019-11-28 Thread Ville Syrjala
From: Ville Syrjälä LPT/WPT only have PCH transcoder A. Make sure we poke at its chicken register instead of some non-existent register when FDI is being driven by pipe B or C. Cc: Uma Shankar Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 3 ++- 1 file

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,1/3] drm/i915/selftests: Count the number of engines used (rev3)

2019-11-28 Thread Patchwork
== Series Details == Series: series starting with [CI,1/3] drm/i915/selftests: Count the number of engines used (rev3) URL : https://patchwork.freedesktop.org/series/70131/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7438 -> Patchwork_15493

[Intel-gfx] [PATCH i-g-t] overlay: Believe in 0MHz

2019-11-28 Thread Chris Wilson
Tvrtko proposed reporting 0MHz when idle, but the overlay didn't believe that would be possible and stripped from its graphs! Signed-off-by: Chris Wilson --- overlay/overlay.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/overlay/overlay.c b/overlay/overlay.c

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/fbc: Fix FBC for glk+ (rev5)

2019-11-28 Thread Patchwork
== Series Details == Series: drm/i915/fbc: Fix FBC for glk+ (rev5) URL : https://patchwork.freedesktop.org/series/70062/ State : success == Summary == CI Bug Log - changes from CI_DRM_7438 -> Patchwork_15492 Summary --- **SUCCESS**

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/3] drm/i915/selftests: Count the number of engines used (rev3)

2019-11-28 Thread Patchwork
== Series Details == Series: series starting with [CI,1/3] drm/i915/selftests: Count the number of engines used (rev3) URL : https://patchwork.freedesktop.org/series/70131/ State : warning == Summary == $ dim checkpatch origin/drm-tip 26c994148fba drm/i915/selftests: Flush fput after running

Re: [Intel-gfx] [PATCH v6 1/4] drm/i915: Remove skl_ddl_allocation struct

2019-11-28 Thread Lisovskiy, Stanislav
On Thu, 2019-11-28 at 18:13 +0200, Ville Syrjälä wrote: > On Wed, Nov 27, 2019 at 04:41:25PM +0200, Stanislav Lisovskiy wrote: > > Current consensus that it is redundant as > > we already have skl_ddb_values struct out there, > > also this struct contains only single member > > which makes it

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Report frequency as zero while GPU is sleeping

2019-11-28 Thread Tvrtko Ursulin
On 28/11/2019 16:22, Chris Wilson wrote: Quoting Chris Wilson (2019-11-28 16:19:49) Quoting Tvrtko Ursulin (2019-11-28 16:10:51) From: Tvrtko Ursulin We used to report the minimum possible frequency as both requested and active while GPU was in sleep state. This was a consequence of

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Provide ddc symlink in hdmi connector sysfs directory (rev2)

2019-11-28 Thread Patchwork
== Series Details == Series: drm/i915: Provide ddc symlink in hdmi connector sysfs directory (rev2) URL : https://patchwork.freedesktop.org/series/70161/ State : success == Summary == CI Bug Log - changes from CI_DRM_7438 -> Patchwork_15491

Re: [Intel-gfx] [PATCH] drm/i915/dsb: fix cmd_buf being wrongly set

2019-11-28 Thread Animesh Manna
On 11/28/2019 3:41 AM, Lucas De Marchi wrote: The "err" label is not really "err", but rather "out" since the return path is shared between error condition and normal path. This broke when commit 03cea61076f0 ("drm/i915/dsb: fix extra warning on error path handling") added a "dsb->cmd_buf =

[Intel-gfx] [CI] drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET

2019-11-28 Thread Chris Wilson
From: Abdiel Janulgue This is really just an alias of mmap_gtt. The 'mmap offset' nomenclature comes from the value returned by this ioctl which is the offset into the device fd which userpace uses with mmap(2). mmap_gtt was our initial mmap_offset implementation, this extends our CPU mmap

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Report frequency as zero while GPU is sleeping

2019-11-28 Thread Chris Wilson
Quoting Chris Wilson (2019-11-28 16:19:49) > Quoting Tvrtko Ursulin (2019-11-28 16:10:51) > > From: Tvrtko Ursulin > > > > We used to report the minimum possible frequency as both requested and > > active while GPU was in sleep state. This was a consequence of sampling > > the value from the

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET

2019-11-28 Thread Patchwork
== Series Details == Series: drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET URL : https://patchwork.freedesktop.org/series/70164/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7438 -> Patchwork_15490 Summary ---

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Report frequency as zero while GPU is sleeping

2019-11-28 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-11-28 16:10:51) > From: Tvrtko Ursulin > > We used to report the minimum possible frequency as both requested and > active while GPU was in sleep state. This was a consequence of sampling > the value from the "current frequency" field in our software tracking. > >

Re: [Intel-gfx] [PATCH v6 1/4] drm/i915: Remove skl_ddl_allocation struct

2019-11-28 Thread Ville Syrjälä
On Wed, Nov 27, 2019 at 04:41:25PM +0200, Stanislav Lisovskiy wrote: > Current consensus that it is redundant as > we already have skl_ddb_values struct out there, > also this struct contains only single member > which makes it unnecessary. > > Signed-off-by: Stanislav Lisovskiy > --- >

[Intel-gfx] [PATCH] drm/i915/pmu: Report frequency as zero while GPU is sleeping

2019-11-28 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We used to report the minimum possible frequency as both requested and active while GPU was in sleep state. This was a consequence of sampling the value from the "current frequency" field in our software tracking. This was strictly speaking wrong, but given that until

[Intel-gfx] [CI] drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET

2019-11-28 Thread Chris Wilson
From: Abdiel Janulgue This is really just an alias of mmap_gtt. The 'mmap offset' nomenclature comes from the value returned by this ioctl which is the offset into the device fd which userpace uses with mmap(2). mmap_gtt was our initial mmap_offset implementation, this extends our CPU mmap

[Intel-gfx] [PATCH] drm/i915/selftests: Flush fput after running selftests

2019-11-28 Thread Chris Wilson
Use an rcu_barrier() to flush any mock files used by the selftests as the deferred cleanup may be holding resources that we need to cleanup. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_gtt.c| 2 +- drivers/gpu/drm/i915/selftests/i915_selftest.c | 10 -- 2

Re: [Intel-gfx] [PATCH v2 14/14] drm/i915/fbc: Reallocate cfb if we need more of it

2019-11-28 Thread Ville Syrjälä
On Thu, Nov 28, 2019 at 04:48:04PM +0100, Maarten Lankhorst wrote: > Op 27-11-2019 om 21:12 schreef Ville Syrjala: > > From: Ville Syrjälä > > > > The code assumes we can omit the cfb allocation once fbc > > has been enabled once. That's nonsense. Let's try to > > reallocate it if we need to. > >

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET

2019-11-28 Thread Patchwork
== Series Details == Series: drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET URL : https://patchwork.freedesktop.org/series/70164/ State : warning == Summary == $ dim checkpatch origin/drm-tip 11ae1f7889b6 drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET -:416: CHECK:PARENTHESIS_ALIGNMENT: Alignment

Re: [Intel-gfx] [PATCH v2 14/14] drm/i915/fbc: Reallocate cfb if we need more of it

2019-11-28 Thread Maarten Lankhorst
Op 27-11-2019 om 21:12 schreef Ville Syrjala: > From: Ville Syrjälä > > The code assumes we can omit the cfb allocation once fbc > has been enabled once. That's nonsense. Let's try to > reallocate it if we need to. > > The code is still a mess, but maybe this is enough to get > fbc going in some

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,1/2] drm/i915: Allow i915 to manage the vma offset nodes instead of drm core

2019-11-28 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915: Allow i915 to manage the vma offset nodes instead of drm core URL : https://patchwork.freedesktop.org/series/70163/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7438 -> Patchwork_15489

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Copy across scheduler behaviour flags across submit fences

2019-11-28 Thread Patchwork
== Series Details == Series: drm/i915: Copy across scheduler behaviour flags across submit fences URL : https://patchwork.freedesktop.org/series/70107/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7431_full -> Patchwork_15463_full

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/2] drm/i915: Allow i915 to manage the vma offset nodes instead of drm core

2019-11-28 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915: Allow i915 to manage the vma offset nodes instead of drm core URL : https://patchwork.freedesktop.org/series/70163/ State : warning == Summary == $ dim checkpatch origin/drm-tip 01596f98bffb drm/i915: Allow i915 to manage

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/dp: fix DP infoframe init for PORT_A on gen12+

2019-11-28 Thread Kai Vehmanen
Hi, On Tue, 26 Nov 2019, Matt Roper wrote: > On Mon, Nov 25, 2019 at 02:53:13PM +0200, Kai Vehmanen wrote: > > Starting with gen12, PORT_A can be also connected to DP > > transcoder. Update code in intel_dp_init() to take this > > into account. > > I don't think this function gets called on

[Intel-gfx] [PATCH v3 12/14] drm/i915/fbc: Wait for vblank after FBC disable on glk+

2019-11-28 Thread Ville Syrjala
From: Ville Syrjälä On glk+ the hardware gets confused if we disable FBC while it's recompressing and we perform a plane update during the same frame. The result is that top of the screen gets corrupted. We can avoid that by giving the hardware enough time to finish the FBC disable before we

[Intel-gfx] [PATCH] drm/i915: Provide ddc symlink in hdmi connector sysfs directory

2019-11-28 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz Acked-by: Sam Ravnborg Reviewed-by: Emil Velikov --- Rebased onto drm-intel-next-queued. drivers/gpu/drm/i915/display/intel_hdmi.c | 12 1 file changed, 8 insertions(+), 4 deletions(-)

[Intel-gfx] [CI] drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET

2019-11-28 Thread Chris Wilson
From: Abdiel Janulgue This is really just an alias of mmap_gtt. The 'mmap offset' nomenclature comes from the value returned by this ioctl which is the offset into the device fd which userpace uses with mmap(2). mmap_gtt was our initial mmap_offset implementation, this extends our CPU mmap

Re: [Intel-gfx] [CI 2/2] drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET

2019-11-28 Thread Chris Wilson
Quoting Chris Wilson (2019-11-28 14:52:11) > From: Abdiel Janulgue > > This is really just an alias of mmap_gtt. The 'mmap offset' nomenclature > comes from the value returned by this ioctl which is the offset into the > device fd which userpace uses with mmap(2). > > mmap_gtt was our initial

[Intel-gfx] [CI 1/2] drm/i915: Allow i915 to manage the vma offset nodes instead of drm core

2019-11-28 Thread Chris Wilson
From: Abdiel Janulgue Have i915 replace the core drm_gem_mmap implementation to overcome its limitation in having only a single mmap offset node per gem object. This change allows us to have multiple mmap offsets per object and enables a mmapping instance to use unique fault-handlers per user

[Intel-gfx] [CI 2/2] drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET

2019-11-28 Thread Chris Wilson
From: Abdiel Janulgue This is really just an alias of mmap_gtt. The 'mmap offset' nomenclature comes from the value returned by this ioctl which is the offset into the device fd which userpace uses with mmap(2). mmap_gtt was our initial mmap_offset implementation, this extends our CPU mmap

Re: [Intel-gfx] [PATCH] drm/i915/display/tgl: Do not program clockgating

2019-11-28 Thread Jani Nikula
On Tue, 26 Nov 2019, José Roberto de Souza wrote: > Talked with HW team and this is a left over, driver should not > program clockgating, dekel firmware will be reponsible for any > clockgating programing. > > BSpec issue: 20885 > BSpec: 49292 > > Cc: Lucas De Marchi > Cc: Matt Roper >

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,1/3] drm/i915: Allow i915 to manage the vma offset nodes instead of drm core

2019-11-28 Thread Patchwork
== Series Details == Series: series starting with [CI,1/3] drm/i915: Allow i915 to manage the vma offset nodes instead of drm core URL : https://patchwork.freedesktop.org/series/70160/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7438 -> Patchwork_15487

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: Provide ddc symlink in hdmi connector sysfs directory

2019-11-28 Thread Patchwork
== Series Details == Series: drm/i915: Provide ddc symlink in hdmi connector sysfs directory URL : https://patchwork.freedesktop.org/series/70161/ State : failure == Summary == Applying: drm/i915: Provide ddc symlink in hdmi connector sysfs directory Using index info to reconstruct a base

Re: [Intel-gfx] [PATCH v6 3/3] drm/i915: Predictive governor to control slice/subslice/eu

2019-11-28 Thread Jani Nikula
Cc: Joonas On Tue, 26 Nov 2019, Ankit Navik wrote: > High resolution timer is used for predictive governor to control > eu/slice/subslice based on workloads. > > param is provided to enable/disable/update timer configuration > > V2: > * Fix code style. > * Move predictive_load_timer into a

Re: [Intel-gfx] [PATCH v3 5/5] drm/i915/vbt: Parse power conservation features block

2019-11-28 Thread Jani Nikula
On Wed, 27 Nov 2019, José Roberto de Souza wrote: > From VBT 228+ this is block that PSR and other power saving > features configuration should be read from. > > v3: > Using DRRS from this new block > > Cc: Matt Roper > Cc: Gwan-gyeong Mun > Signed-off-by: José Roberto de Souza > --- >

Re: [Intel-gfx] [PATCH 01/13] drm/i915/fbc: Disable fbc by default on all glk+

2019-11-28 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed because it contains a -stable tag. The stable tag indicates that it's relevant for the following trees: all The bot has tested the following trees: v5.3.13, v4.19.86, v4.14.156, v4.9.203, v4.4.203. v5.3.13: Build OK! v4.19.86:

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dsi: enable DSC (rev4)

2019-11-28 Thread Patchwork
== Series Details == Series: drm/i915/dsi: enable DSC (rev4) URL : https://patchwork.freedesktop.org/series/69540/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7431_full -> Patchwork_15462_full Summary ---

[Intel-gfx] [PULL] drm-intel-next-fixes

2019-11-28 Thread Joonas Lahtinen
Hi Dave & Daniel, Most importantly we have the fix to power regression that was introduced by the security fixes. Then fix for query uAPI and increase in request pre-emption timeout to accommodate super heavy benchmarks. Couple of display voltage programming fixes too. Thanks to Chris for

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/3] drm/i915: Allow i915 to manage the vma offset nodes instead of drm core

2019-11-28 Thread Patchwork
== Series Details == Series: series starting with [CI,1/3] drm/i915: Allow i915 to manage the vma offset nodes instead of drm core URL : https://patchwork.freedesktop.org/series/70160/ State : warning == Summary == $ dim checkpatch origin/drm-tip 81215832dc10 drm/i915: Allow i915 to manage

Re: [Intel-gfx] [PATCH] i915: Expose panel power cycle delay to i915_panel_timings

2019-11-28 Thread Jani Nikula
On Mon, 18 Nov 2019, Anshuman Gupta wrote: > Putting down the AUX power domain reference count in > edp vdd off async sequence takes too much of time > (relative to panel power cycle delay) therefore it make sense > to expose the panel power cycle delay to i915_panel_timings > along with other

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/gem: Excise the per-batch whitelist from the context (rev2)

2019-11-28 Thread Patchwork
== Series Details == Series: drm/i915/gem: Excise the per-batch whitelist from the context (rev2) URL : https://patchwork.freedesktop.org/series/70040/ State : failure == Summary == Applying: drm/i915/gem: Excise the per-batch whitelist from the context Using index info to reconstruct a base

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Try to show where the pulse went

2019-11-28 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Try to show where the pulse went URL : https://patchwork.freedesktop.org/series/70155/ State : failure == Summary == Applying: drm/i915/selftests: Try to show where the pulse went Using index info to reconstruct a base tree... M

Re: [Intel-gfx] [PATCH 02/13] drm/fb-helper: don't preserve fb_ops across deferred IO use

2019-11-28 Thread Noralf Trønnes
Den 28.11.2019 13.05, skrev Jani Nikula: > On Thu, 28 Nov 2019, Noralf Trønnes wrote: >> Den 27.11.2019 17.31, skrev Jani Nikula: >>> Deferred IO now preserves the fb_ops. >>> >>> Cc: Noralf Trønnes >>> Cc: dri-de...@lists.freedesktop.org >>> Signed-off-by: Jani Nikula >>> --- >>>

[Intel-gfx] ✗ Fi.CI.BUILD: failure for video, drm: constify fbops in struct fb_info (rev2)

2019-11-28 Thread Patchwork
== Series Details == Series: video, drm: constify fbops in struct fb_info (rev2) URL : https://patchwork.freedesktop.org/series/70119/ State : failure == Summary == Applying: video: fb_defio: preserve user fb_ops Applying: drm/fb-helper: don't preserve fb_ops across deferred IO use Applying:

Re: [Intel-gfx] [PATCH] drm/i915: Provide ddc symlink in hdmi connector sysfs directory

2019-11-28 Thread Jani Nikula
On Thu, 28 Nov 2019, Andrzej Pietrasiewicz wrote: > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz > Acked-by: Sam Ravnborg > Reviewed-by: Emil Velikov > --- > Rebased onto drm-misc-next as of 28 Nov 2019 The conflict is in

[Intel-gfx] [PATCH] drm/i915: Provide ddc symlink in hdmi connector sysfs directory

2019-11-28 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz Acked-by: Sam Ravnborg Reviewed-by: Emil Velikov --- Rebased onto drm-misc-next as of 28 Nov 2019 drivers/gpu/drm/i915/display/intel_hdmi.c | 12 1 file changed, 8 insertions(+), 4

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] tests/i915/gem_mmap_offset: Add new API test for gem_mmap_offset

2019-11-28 Thread Petri Latvala
On Thu, Nov 28, 2019 at 12:55:02PM +, Chris Wilson wrote: > From: Lukasz Kalamarz > > Few simple tests which tries to create / mmap buffer objects > using GEM_MMAP_OFFSET uAPI. > > v2: change from WC -> WB (according to Chris review comment) > v3: add mmap-offset-close-race test > >

[Intel-gfx] [CI 2/3] drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET

2019-11-28 Thread Chris Wilson
From: Abdiel Janulgue This is really just an alias of mmap_gtt. The 'mmap offset' nomenclature comes from the value returned by this ioctl which is the offset into the device fd which userpace uses with mmap(2). mmap_gtt was our initial mmap_offset implementation, this extends our CPU mmap

[Intel-gfx] [CI 3/3] drm/i915: Add cpu fault handler for mmap_offset

2019-11-28 Thread Chris Wilson
From: Abdiel Janulgue Fault handler to handle missing pages for shmem-backed objects. v2: bail out of inserting PTEs when failing to insert the fault address v3: has struct page check v4: Add self-test for validating CPU fault handler to ensure PTEs are revoked when an object is

[Intel-gfx] [CI 1/3] drm/i915: Allow i915 to manage the vma offset nodes instead of drm core

2019-11-28 Thread Chris Wilson
From: Abdiel Janulgue Have i915 replace the core drm_gem_mmap implementation to overcome its limitation in having only a single mmap offset node per gem object. This change allows us to have multiple mmap offsets per object and enables a mmapping instance to use unique fault-handlers per user

[Intel-gfx] [PATCH i-g-t] tests/i915/gem_mmap_offset: Add new API test for gem_mmap_offset

2019-11-28 Thread Chris Wilson
From: Lukasz Kalamarz Few simple tests which tries to create / mmap buffer objects using GEM_MMAP_OFFSET uAPI. v2: change from WC -> WB (according to Chris review comment) v3: add mmap-offset-close-race test Signed-off-by: Lukasz Kalamarz Signed-off-by: Zbigniew Kempczyński Cc: Chris Wilson

[Intel-gfx] [PATCH i-g-t] tests/i915/gem_mmap_offset: Add new API test for gem_mmap_offset

2019-11-28 Thread Chris Wilson
From: Lukasz Kalamarz Few simple tests which tries to create / mmap buffer objects using GEM_MMAP_OFFSET uAPI. v2: change from WC -> WB (according to Chris review comment) v3: add mmap-offset-close-race test Signed-off-by: Lukasz Kalamarz Signed-off-by: Zbigniew Kempczyński Cc: Chris Wilson

Re: [Intel-gfx] [PATCH i-g-t] tests/i915/gem_mmap_offset: Add new API test for gem_mmap_offset

2019-11-28 Thread Chris Wilson
Quoting Chris Wilson (2019-11-28 12:55:02) > +static void isolation(int i915) > +{ > + for_each_mmap_offset_type(t) { > + struct drm_i915_gem_mmap_offset mmap_arg = { > + .flags = t->type > + }; > + int A =

[Intel-gfx] [PATCH i-g-t] tests/i915/gem_mmap_offset: Add new API test for gem_mmap_offset

2019-11-28 Thread Chris Wilson
From: Lukasz Kalamarz Few simple tests which tries to create / mmap buffer objects using GEM_MMAP_OFFSET uAPI. v2: change from WC -> WB (according to Chris review comment) v3: add mmap-offset-close-race test Signed-off-by: Lukasz Kalamarz Signed-off-by: Zbigniew Kempczyński Cc: Chris Wilson

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/tgl: Drop preemption to see if that helps

2019-11-28 Thread Chris Wilson
Quoting Patchwork (2019-11-28 12:06:45) > == Series Details == > > Series: drm/i915/tgl: Drop preemption to see if that helps > URL : https://patchwork.freedesktop.org/series/70153/ > State : success > > == Summary == > > CI Bug Log - changes from CI_DRM_7436 -> Patchwork_15483 >

Re: [Intel-gfx] [RFC 03/13] drm/i915/svm: Runtime (RT) allocator support

2019-11-28 Thread Joonas Lahtinen
Quoting Niranjan Vishwanathapura (2019-11-27 21:23:56) > >We should try to have the uAPI as final as early as possible. The > >change process is harder the later it is done, even for RFC :) > > > >On the same note, I'm inclined to have I915_SVM_MIGRATE called > >I915_GEM_VM_PREFAULT from the

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/tgl: Drop preemption to see if that helps

2019-11-28 Thread Patchwork
== Series Details == Series: drm/i915/tgl: Drop preemption to see if that helps URL : https://patchwork.freedesktop.org/series/70153/ State : success == Summary == CI Bug Log - changes from CI_DRM_7436 -> Patchwork_15483 Summary ---

Re: [Intel-gfx] [PATCH 3/7] drm/i915/tgl: Select master trasconder for MST stream

2019-11-28 Thread Ville Syrjälä
On Thu, Nov 28, 2019 at 01:14:37AM +, Souza, Jose wrote: > On Wed, 2019-11-27 at 21:59 +0200, Ville Syrjälä wrote: > > On Tue, Nov 26, 2019 at 08:30:31PM +, Souza, Jose wrote: > > > On Tue, 2019-11-26 at 22:05 +0200, Ville Syrjälä wrote: > > > > On Fri, Nov 22, 2019 at 04:54:55PM -0800,

Re: [Intel-gfx] [PATCH 02/13] drm/fb-helper: don't preserve fb_ops across deferred IO use

2019-11-28 Thread Jani Nikula
On Thu, 28 Nov 2019, Noralf Trønnes wrote: > Den 27.11.2019 17.31, skrev Jani Nikula: >> Deferred IO now preserves the fb_ops. >> >> Cc: Noralf Trønnes >> Cc: dri-de...@lists.freedesktop.org >> Signed-off-by: Jani Nikula >> --- >> drivers/gpu/drm/drm_fb_helper.c | 18 ++ >> 1

Re: [Intel-gfx] [PATCH 4/7] drm/i915: Clean up intel_{pre, post}_plane_update()

2019-11-28 Thread Ville Syrjälä
On Wed, Nov 27, 2019 at 11:25:07PM +, Souza, Jose wrote: > On Wed, 2019-11-27 at 21:05 +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Change the calling convention to just pass the state+crtc and > > switch to intel_ types throughout. > > > > Signed-off-by: Ville Syrjälä > >

Re: [Intel-gfx] [PATCH 3/7] drm/i915: s/pipe_config/new_crtc_state/ intel_{pre, post}_plane_update()

2019-11-28 Thread Ville Syrjälä
On Wed, Nov 27, 2019 at 11:11:15PM +, Souza, Jose wrote: > On Wed, 2019-11-27 at 23:09 +, Souza, Jose wrote: > > On Wed, 2019-11-27 at 21:05 +0200, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Replace the old world 'pipe_config' variable name with the new > > > thing. > > >

Re: [Intel-gfx] [CI 1/3] drm/i915/selftests: Count the number of engines used

2019-11-28 Thread Tvrtko Ursulin
On 27/11/2019 22:32, Chris Wilson wrote: Don't rely on the RUNTIME_INFO() when we loop over a particular context and only run on a filtered set of engines. Signed-off-by: Chris Wilson --- .../drm/i915/gem/selftests/i915_gem_context.c | 25 --- 1 file changed, 16

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/tgl: Drop preemption to see if that helps

2019-11-28 Thread Patchwork
== Series Details == Series: drm/i915/tgl: Drop preemption to see if that helps URL : https://patchwork.freedesktop.org/series/70153/ State : warning == Summary == $ dim checkpatch origin/drm-tip e9e31facbaae drm/i915/tgl: Drop preemption to see if that helps -:8: WARNING:COMMIT_MESSAGE:

Re: [Intel-gfx] [PATCH v3 1/2] drm: call drm_gem_object_funcs.mmap with fake offset

2019-11-28 Thread Gerd Hoffmann
On Wed, Nov 27, 2019 at 10:25:22AM +0100, Gerd Hoffmann wrote: > The fake offset is going to stay, so change the calling convention for > drm_gem_object_funcs.mmap to include the fake offset. Update all users > accordingly. > > Note that this reverts 83b8a6f242ea ("drm/gem: Fix mmap fake offset

  1   2   >