[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/tgl: Add definitions for VRR registers and bits

2020-03-06 Thread Patchwork
== Series Details == Series: drm/i915/tgl: Add definitions for VRR registers and bits URL : https://patchwork.freedesktop.org/series/74410/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8088 -> Patchwork_16872 Summary

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/tgl: Add definitions for VRR registers and bits

2020-03-06 Thread Patchwork
== Series Details == Series: drm/i915/tgl: Add definitions for VRR registers and bits URL : https://patchwork.freedesktop.org/series/74410/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_dpll_mgr.h:285: warning: Function

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dgfx: avoid opregion calls and messages

2020-03-06 Thread Patchwork
== Series Details == Series: drm/i915/dgfx: avoid opregion calls and messages URL : https://patchwork.freedesktop.org/series/74408/ State : success == Summary == CI Bug Log - changes from CI_DRM_8088 -> Patchwork_16871 Summary ---

[Intel-gfx] [PATCH v3] drm/i915/tgl: Add definitions for VRR registers and bits

2020-03-06 Thread Aditya Swarup
Add definitions for registers grouped under Transcoder VRR function with necessary bitfields. Bspec: 49268 v2: Use REG_GENMASK, correct tabs/space indentation and move the definitions near the transcoder section.(Jani) v3: Remove unnecessary prefix from bit/mask definitions.(Manasi) Cc: Manasi

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/dgfx: avoid opregion calls and messages

2020-03-06 Thread Patchwork
== Series Details == Series: drm/i915/dgfx: avoid opregion calls and messages URL : https://patchwork.freedesktop.org/series/74408/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_dpll_mgr.h:285: warning: Function parameter or

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm: avoid spurious EBUSY due to nonblocking atomic modesets (rev5)

2020-03-06 Thread Patchwork
== Series Details == Series: drm: avoid spurious EBUSY due to nonblocking atomic modesets (rev5) URL : https://patchwork.freedesktop.org/series/45968/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8088 -> Patchwork_16870

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm: avoid spurious EBUSY due to nonblocking atomic modesets (rev5)

2020-03-06 Thread Patchwork
== Series Details == Series: drm: avoid spurious EBUSY due to nonblocking atomic modesets (rev5) URL : https://patchwork.freedesktop.org/series/45968/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_dpll_mgr.h:285: warning:

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v4,1/2] drm/edid: Name the detailed monitor range flags

2020-03-06 Thread Patchwork
== Series Details == Series: series starting with [v4,1/2] drm/edid: Name the detailed monitor range flags URL : https://patchwork.freedesktop.org/series/74364/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8074_full -> Patchwork_16855_full

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: avoid spurious EBUSY due to nonblocking atomic modesets (rev5)

2020-03-06 Thread Patchwork
== Series Details == Series: drm: avoid spurious EBUSY due to nonblocking atomic modesets (rev5) URL : https://patchwork.freedesktop.org/series/45968/ State : warning == Summary == $ dim checkpatch origin/drm-tip bca7a2e764c5 drm: avoid spurious EBUSY due to nonblocking atomic modesets -:35:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: allow setting generic data pointer (rev4)

2020-03-06 Thread Patchwork
== Series Details == Series: drm/i915/gt: allow setting generic data pointer (rev4) URL : https://patchwork.freedesktop.org/series/74360/ State : success == Summary == CI Bug Log - changes from CI_DRM_8088 -> Patchwork_16869 Summary

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/gt: allow setting generic data pointer (rev4)

2020-03-06 Thread Patchwork
== Series Details == Series: drm/i915/gt: allow setting generic data pointer (rev4) URL : https://patchwork.freedesktop.org/series/74360/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_dpll_mgr.h:285: warning: Function

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm/i915/display: Deactive FBC in fastsets when disabled by parameter

2020-03-06 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915/display: Deactive FBC in fastsets when disabled by parameter URL : https://patchwork.freedesktop.org/series/74401/ State : success == Summary == CI Bug Log - changes from CI_DRM_8088 -> Patchwork_16868

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/2] drm/i915: Add mechanism to submit a context WA on ring submission

2020-03-06 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915: Add mechanism to submit a context WA on ring submission URL : https://patchwork.freedesktop.org/series/74363/ State : success == Summary == CI Bug Log - changes from CI_DRM_8074_full -> Patchwork_16853_full

[Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [v2,1/2] drm/i915/display: Deactive FBC in fastsets when disabled by parameter

2020-03-06 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915/display: Deactive FBC in fastsets when disabled by parameter URL : https://patchwork.freedesktop.org/series/74401/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/2] drm/i915/display: Deactive FBC in fastsets when disabled by parameter

2020-03-06 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915/display: Deactive FBC in fastsets when disabled by parameter URL : https://patchwork.freedesktop.org/series/74401/ State : warning == Summary == $ dim checkpatch origin/drm-tip 55685d37ef4e drm/i915/display: Deactive FBC in

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/tgl: Don't treat unslice registers as masked (rev2)

2020-03-06 Thread Patchwork
== Series Details == Series: drm/i915/tgl: Don't treat unslice registers as masked (rev2) URL : https://patchwork.freedesktop.org/series/74351/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8088 -> Patchwork_16867 Summary

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/tgl: Don't treat unslice registers as masked (rev2)

2020-03-06 Thread Patchwork
== Series Details == Series: drm/i915/tgl: Don't treat unslice registers as masked (rev2) URL : https://patchwork.freedesktop.org/series/74351/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_dpll_mgr.h:285: warning: Function

[Intel-gfx] [PATCH] drm/i915/dgfx: avoid opregion calls and messages

2020-03-06 Thread Lucas De Marchi
This avoids the annoying message "Failed to get panel details from OpRegion (-19)" while initializing. On DGFX there is no access to OpRegion, so just avoid any calls related to it. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_opregion.c | 4 1 file changed, 4

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Gamma cleanups (rev4)

2020-03-06 Thread Patchwork
== Series Details == Series: drm/i915: Gamma cleanups (rev4) URL : https://patchwork.freedesktop.org/series/69136/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8087 -> Patchwork_16866 Summary --- **FAILURE**

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: allow setting generic data pointer

2020-03-06 Thread Patchwork
== Series Details == Series: drm/i915/gt: allow setting generic data pointer URL : https://patchwork.freedesktop.org/series/74360/ State : success == Summary == CI Bug Log - changes from CI_DRM_8074_full -> Patchwork_16852_full Summary

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915: Gamma cleanups (rev4)

2020-03-06 Thread Patchwork
== Series Details == Series: drm/i915: Gamma cleanups (rev4) URL : https://patchwork.freedesktop.org/series/69136/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_dpll_mgr.h:285: warning: Function parameter or member 'get_freq'

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Gamma cleanups (rev4)

2020-03-06 Thread Patchwork
== Series Details == Series: drm/i915: Gamma cleanups (rev4) URL : https://patchwork.freedesktop.org/series/69136/ State : warning == Summary == $ dim checkpatch origin/drm-tip ca6d5d42a01b drm/i915: Polish CHV CGM CSC loading 97e95a526dd1 drm/i915: Clean up i9xx_load_luts_internal()

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Close race between cacheline_retire and free

2020-03-06 Thread Patchwork
== Series Details == Series: drm/i915/gt: Close race between cacheline_retire and free URL : https://patchwork.freedesktop.org/series/74397/ State : success == Summary == CI Bug Log - changes from CI_DRM_8087 -> Patchwork_16865 Summary

[Intel-gfx] [PATCH v4] drm/i915/gt: allow setting generic data pointer

2020-03-06 Thread Andi Shyti
From: Andi Shyti When registering debugfs files the intel gt debugfs library forces a 'struct *gt' private data on the caller. To be open to different usages make the new "intel_gt_debugfs_register_files()"[*] function more generic by converting the 'struct *gt' pointer to a 'void *' type. I

Re: [Intel-gfx] 5.6 DP-MST regression: 1 of 2 monitors on TB3 (DP-MST) dock no longer light up

2020-03-06 Thread Lyude Paul
On Wed, 2020-02-26 at 18:52 +0100, Hans de Goede wrote: > Hi, > > On 2/26/20 5:05 PM, Alex Deucher wrote: > > On Wed, Feb 26, 2020 at 10:43 AM Hans de Goede > > wrote: > > > Hi, > > > > > > On 2/26/20 4:29 PM, Alex Deucher wrote: > > > > On Wed, Feb 26, 2020 at 10:16 AM Hans de Goede > > > >

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/gt: Close race between cacheline_retire and free

2020-03-06 Thread Patchwork
== Series Details == Series: drm/i915/gt: Close race between cacheline_retire and free URL : https://patchwork.freedesktop.org/series/74397/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_dpll_mgr.h:285: warning: Function

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/phys: unconditionally call release_memory_region

2020-03-06 Thread Patchwork
== Series Details == Series: drm/i915/phys: unconditionally call release_memory_region URL : https://patchwork.freedesktop.org/series/74354/ State : success == Summary == CI Bug Log - changes from CI_DRM_8074_full -> Patchwork_16849_full

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm: avoid spurious EBUSY due to nonblocking atomic modesets (rev4)

2020-03-06 Thread Patchwork
== Series Details == Series: drm: avoid spurious EBUSY due to nonblocking atomic modesets (rev4) URL : https://patchwork.freedesktop.org/series/45968/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8086 -> Patchwork_16864

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: be more solid in checking the alignment

2020-03-06 Thread Patchwork
== Series Details == Series: drm/i915: be more solid in checking the alignment URL : https://patchwork.freedesktop.org/series/74353/ State : success == Summary == CI Bug Log - changes from CI_DRM_8074_full -> Patchwork_16848_full Summary

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm: avoid spurious EBUSY due to nonblocking atomic modesets (rev4)

2020-03-06 Thread Patchwork
== Series Details == Series: drm: avoid spurious EBUSY due to nonblocking atomic modesets (rev4) URL : https://patchwork.freedesktop.org/series/45968/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_dpll_mgr.h:285: warning:

[Intel-gfx] [PATCH v3] drm/i915/gt: allow setting generic data pointer

2020-03-06 Thread Andi Shyti
From: Andi Shyti When registering debugfs files the intel gt debugfs library forces a 'struct *gt' private data on the caller. There might be different needs, therefore make it generic by adding one more argument to the "debugfs_register_files()" function which gets the generic void private

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/tgl: Make wa_1606700617 permanent (rev2)

2020-03-06 Thread Souza, Jose
On Fri, 2020-03-06 at 20:03 +, Patchwork wrote: > == Series Details == > > Series: drm/i915/tgl: Make wa_1606700617 permanent (rev2) > URL : https://patchwork.freedesktop.org/series/74240/ > State : success > > == Summary == > > CI Bug Log - changes from CI_DRM_8073_full ->

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: avoid spurious EBUSY due to nonblocking atomic modesets (rev4)

2020-03-06 Thread Patchwork
== Series Details == Series: drm: avoid spurious EBUSY due to nonblocking atomic modesets (rev4) URL : https://patchwork.freedesktop.org/series/45968/ State : warning == Summary == $ dim checkpatch origin/drm-tip 6cecc5b22da8 drm: avoid spurious EBUSY due to nonblocking atomic modesets -:35:

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/hotplug: Use phy to get the hpd_pin instead of the port (rev6)

2020-03-06 Thread Souza, Jose
On Fri, 2020-03-06 at 03:01 +, Patchwork wrote: > == Series Details == > > Series: drm/i915/hotplug: Use phy to get the hpd_pin instead of the > port (rev6) > URL : https://patchwork.freedesktop.org/series/72747/ > State : success > > == Summary == > > CI Bug Log - changes from

Re: [Intel-gfx] [PATCH v3] drm/i915/gt: allow setting generic data pointer

2020-03-06 Thread Daniele Ceraolo Spurio
On 3/6/20 2:14 PM, Andi Shyti wrote: From: Andi Shyti When registering debugfs files the intel gt debugfs library forces a 'struct *gt' private data on the caller. There might be different needs, therefore make it generic by adding one more argument to the "debugfs_register_files()"

Re: [Intel-gfx] [PATCH] drm/i915/tgl: Make wa_1606700617 permanent

2020-03-06 Thread Souza, Jose
On Thu, 2020-03-05 at 10:12 -0800, Swathi Dhanavanthri wrote: > This workaround is to disable FF DOP Clock gating. The fix > in B0 was backed out due to timing reasons and decided to > be made permanent. > Bspec: 52890 Reviewed-by: José Roberto de Souza > > Signed-off-by: Swathi Dhanavanthri

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Do not poison i915_request.link on removal

2020-03-06 Thread Patchwork
== Series Details == Series: drm/i915: Do not poison i915_request.link on removal URL : https://patchwork.freedesktop.org/series/74393/ State : success == Summary == CI Bug Log - changes from CI_DRM_8086 -> Patchwork_16863 Summary ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [01/17] drm/i915/selftests: Apply a heavy handed flush to i915_active

2020-03-06 Thread Patchwork
== Series Details == Series: series starting with [01/17] drm/i915/selftests: Apply a heavy handed flush to i915_active URL : https://patchwork.freedesktop.org/series/74392/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8086 -> Patchwork_16862

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915: Do not poison i915_request.link on removal

2020-03-06 Thread Patchwork
== Series Details == Series: drm/i915: Do not poison i915_request.link on removal URL : https://patchwork.freedesktop.org/series/74393/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_dpll_mgr.h:285: warning: Function parameter

Re: [Intel-gfx] [PATCH v2] drm/i915/gt: allow setting generic data pointer

2020-03-06 Thread Andi Shyti
Hi Daniele, > > diff --git a/drivers/gpu/drm/i915/gt/debugfs_gt.c > > b/drivers/gpu/drm/i915/gt/debugfs_gt.c > > index 75255aaacaed..24099fb157be 100644 > > --- a/drivers/gpu/drm/i915/gt/debugfs_gt.c > > +++ b/drivers/gpu/drm/i915/gt/debugfs_gt.c > > @@ -26,15 +26,14 @@ void

[Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [01/17] drm/i915/selftests: Apply a heavy handed flush to i915_active

2020-03-06 Thread Patchwork
== Series Details == Series: series starting with [01/17] drm/i915/selftests: Apply a heavy handed flush to i915_active URL : https://patchwork.freedesktop.org/series/74392/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/17] drm/i915/selftests: Apply a heavy handed flush to i915_active

2020-03-06 Thread Patchwork
== Series Details == Series: series starting with [01/17] drm/i915/selftests: Apply a heavy handed flush to i915_active URL : https://patchwork.freedesktop.org/series/74392/ State : warning == Summary == $ dim checkpatch origin/drm-tip 982908c93abd drm/i915/selftests: Apply a heavy handed

Re: [Intel-gfx] [PATCH v2] drm/i915/gt: allow setting generic data pointer

2020-03-06 Thread Daniele Ceraolo Spurio
On 3/6/20 12:06 PM, Andi Shyti wrote: From: Andi Shyti When registering debugfs files the intel gt debugfs library forces a 'struct *gt' private data on the caller. There might be different needs, therefore make it generic by adding one more argument to the "debugfs_register_files()"

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Add support for HDCP 1.4 over MST connectors (rev5)

2020-03-06 Thread Patchwork
== Series Details == Series: drm/i915: Add support for HDCP 1.4 over MST connectors (rev5) URL : https://patchwork.freedesktop.org/series/70393/ State : success == Summary == CI Bug Log - changes from CI_DRM_8073_full -> Patchwork_16845_full

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [01/17] drm/i915: Add an implementation for i915_gem_ww_ctx locking, v2.

2020-03-06 Thread Patchwork
== Series Details == Series: series starting with [01/17] drm/i915: Add an implementation for i915_gem_ww_ctx locking, v2. URL : https://patchwork.freedesktop.org/series/74387/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8085 -> Patchwork_16861

Re: [Intel-gfx] [PATCH 20/51] drm: Handle dev->unique with drmm_

2020-03-06 Thread Sam Ravnborg
On Mon, Mar 02, 2020 at 11:26:00PM +0100, Daniel Vetter wrote: > We need to add a drmm_kstrdup for this, but let's start somewhere. > > This is not exactly perfect onion unwinding, but it's jsut a kfree so > doesn't really matter at all. > > Signed-off-by: Daniel Vetter Reluctanlyt... But

[Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [01/17] drm/i915: Add an implementation for i915_gem_ww_ctx locking, v2.

2020-03-06 Thread Patchwork
== Series Details == Series: series starting with [01/17] drm/i915: Add an implementation for i915_gem_ww_ctx locking, v2. URL : https://patchwork.freedesktop.org/series/74387/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915

Re: [Intel-gfx] [PATCH] drm: Cleanups after drmm_add_final_kfree rollout

2020-03-06 Thread Sam Ravnborg
On Tue, Mar 03, 2020 at 09:45:20AM +0100, Daniel Vetter wrote: > A few things: > - Update the example driver in the documentation. > - We can drop the old kfree in drm_dev_release. > - Add a WARN_ON check in drm_dev_register to make sure everyone calls > drmm_add_final_kfree and there's no

Re: [Intel-gfx] [PATCH 19/51] drm: Cleanups after drmm_add_final_kfree rollout

2020-03-06 Thread Sam Ravnborg
On Mon, Mar 02, 2020 at 11:25:59PM +0100, Daniel Vetter wrote: > A few things: > - Update the example driver in the documentation. > - We can drop the old kfree in drm_dev_release. > - Add a WARN_ON check in drm_dev_register to make sure everyone calls > drmm_add_final_kfree and there's no

Re: [Intel-gfx] [PATCH 18/51] drm/: Use drmm_add_final_kfree

2020-03-06 Thread Sam Ravnborg
On Mon, Mar 02, 2020 at 11:25:58PM +0100, Daniel Vetter wrote: > These are the leftover drivers that didn't have a ->release hook that > needed to be updated. > > Acked-by: Liviu Dudau > Signed-off-by: Daniel Vetter > Cc: "James (Qian) Wang" > Cc: Liviu Dudau > Cc: Mihail Atanassov > Cc:

Re: [Intel-gfx] [PATCH 17/51] drm/gm12u320: Use drmm_add_final_kfree

2020-03-06 Thread Sam Ravnborg
On Mon, Mar 02, 2020 at 11:25:57PM +0100, Daniel Vetter wrote: > With this we can drop the final kfree from the release function. > > Reviewed-by: Hans de Goede > Signed-off-by: Daniel Vetter > Cc: Hans de Goede Acked-by: Sam Ravnborg > --- > drivers/gpu/drm/tiny/gm12u320.c | 3 ++- > 1

Re: [Intel-gfx] [PATCH 16/51] drm/ingenic: Use drmm_add_final_kfree

2020-03-06 Thread Sam Ravnborg
On Mon, Mar 02, 2020 at 11:25:56PM +0100, Daniel Vetter wrote: > With this we can drop the final kfree from the release function. > > Reviewed-by: Paul Cercueil > Signed-off-by: Daniel Vetter > Cc: Paul Cercueil Acked-by: Sam Ravnborg > --- > drivers/gpu/drm/ingenic/ingenic-drm.c | 5 ++---

Re: [Intel-gfx] [PATCH 15/51] drm/repaper: Use drmm_add_final_kfree

2020-03-06 Thread Sam Ravnborg
On Mon, Mar 02, 2020 at 11:25:55PM +0100, Daniel Vetter wrote: > With this we can drop the final kfree from the release function. > > Reviewed-by: Noralf Trønnes > Signed-off-by: Daniel Vetter > Cc: "Noralf Trønnes" Acked-by: Sam Ravnborg > --- > drivers/gpu/drm/tiny/repaper.c | 5 ++--- >

[Intel-gfx] [PATCH v2] drm/i915/gt: allow setting generic data pointer

2020-03-06 Thread Andi Shyti
From: Andi Shyti When registering debugfs files the intel gt debugfs library forces a 'struct *gt' private data on the caller. There might be different needs, therefore make it generic by adding one more argument to the "debugfs_register_files()" function which gets the generic void private

Re: [Intel-gfx] [PATCH 32/51] drm/mcde: Drop explicit drm_mode_config_cleanup call

2020-03-06 Thread Sam Ravnborg
On Mon, Mar 02, 2020 at 11:26:12PM +0100, Daniel Vetter wrote: > Allows us to drop the drm_driver.release callback. > > This is made possible by a preceeding patch which added a drmm_ > cleanup action to drm_mode_config_init(), hence all we need to do to > ensure that drm_mode_config_cleanup() is

Re: [Intel-gfx] [PATCH 31/51] drm/ingenic: Drop explicit drm_mode_config_cleanup call

2020-03-06 Thread Sam Ravnborg
On Mon, Mar 02, 2020 at 11:26:11PM +0100, Daniel Vetter wrote: > Allows us to drop the drm_driver.release callback. > > This is made possible by a preceeding patch which added a drmm_ > cleanup action to drm_mode_config_init(), hence all we need to do to > ensure that drm_mode_config_cleanup() is

Re: [Intel-gfx] [PATCH 28/51] drm/bochs: Drop explicit drm_mode_config_cleanup

2020-03-06 Thread Sam Ravnborg
On Mon, Mar 02, 2020 at 11:26:08PM +0100, Daniel Vetter wrote: > Instead rely on the automatic clean, for which we just need to check > that drm_mode_config_init succeeded. To avoid an inversion in the > cleanup we also have to move the dev_private allocation over to > drmm_kzalloc. > > This is

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/17] drm/i915: Add an implementation for i915_gem_ww_ctx locking, v2.

2020-03-06 Thread Patchwork
== Series Details == Series: series starting with [01/17] drm/i915: Add an implementation for i915_gem_ww_ctx locking, v2. URL : https://patchwork.freedesktop.org/series/74387/ State : warning == Summary == $ dim checkpatch origin/drm-tip eb9b1e99590c drm/i915: Add an implementation for

[Intel-gfx] ✗ Fi.CI.BAT: failure for Asynchronous flip implementation for i915

2020-03-06 Thread Patchwork
== Series Details == Series: Asynchronous flip implementation for i915 URL : https://patchwork.freedesktop.org/series/74386/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8085 -> Patchwork_16860 Summary ---

Re: [Intel-gfx] [PATCH 26/51] drm: Manage drm_mode_config_init with drmm_

2020-03-06 Thread Sam Ravnborg
Hi Daniel. On Mon, Mar 02, 2020 at 11:26:06PM +0100, Daniel Vetter wrote: > drm_mode_config_cleanup is idempotent, so no harm in calling this > twice. This allows us to gradually switch drivers over by removing > explicit drm_mode_config_cleanup calls. > > With this step it's now also possible

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/tgl: Make wa_1606700617 permanent (rev2)

2020-03-06 Thread Patchwork
== Series Details == Series: drm/i915/tgl: Make wa_1606700617 permanent (rev2) URL : https://patchwork.freedesktop.org/series/74240/ State : success == Summary == CI Bug Log - changes from CI_DRM_8073_full -> Patchwork_16844_full Summary

[Intel-gfx] ✗ Fi.CI.DOCS: warning for Asynchronous flip implementation for i915

2020-03-06 Thread Patchwork
== Series Details == Series: Asynchronous flip implementation for i915 URL : https://patchwork.freedesktop.org/series/74386/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_dpll_mgr.h:285: warning: Function parameter or member

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Asynchronous flip implementation for i915

2020-03-06 Thread Patchwork
== Series Details == Series: Asynchronous flip implementation for i915 URL : https://patchwork.freedesktop.org/series/74386/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.6.0 Commit: drm/i915: Define flip done functions and enable IER Okay! Commit: drm/i915:

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Asynchronous flip implementation for i915

2020-03-06 Thread Patchwork
== Series Details == Series: Asynchronous flip implementation for i915 URL : https://patchwork.freedesktop.org/series/74386/ State : warning == Summary == $ dim checkpatch origin/drm-tip acc147186833 drm/i915: Define flip done functions and enable IER -:41: CHECK:BRACES: Blank lines aren't

Re: [Intel-gfx] [PATCH] drm: add managed resources tied to drm_device

2020-03-06 Thread Sam Ravnborg
Hi Daniel. > v2: Do all the kerneldoc at the end, to avoid lots of fairly pointless > shuffling while getting everything into shape. > > v3: Add static to add/del_dr (Neil) > Move typo fix to the right patch (Neil) > > v4: Enforce contract for drmm_add_final_kfree: > > Use ksize() to check

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fix crtc nv12 etc. plane bitmasks for DPMS off

2020-03-06 Thread Patchwork
== Series Details == Series: drm/i915: Fix crtc nv12 etc. plane bitmasks for DPMS off URL : https://patchwork.freedesktop.org/series/74346/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8073_full -> Patchwork_16843_full

[Intel-gfx] [PATCH v2 1/2] drm/i915/display: Deactive FBC in fastsets when disabled by parameter

2020-03-06 Thread José Roberto de Souza
Most of the kms_frontbuffer_tracking tests disables the feature being tested, draw, get the CRC then enable the feature, draw again, get the CRC and check if it matches. Some times it is able to do that with a fastset, so intel_pre_plane_update() is executed but intel_fbc_can_flip_nuke() was not

[Intel-gfx] [PATCH v2 2/2] drm/i915/display: Do not write in removed FBC fence registers

2020-03-06 Thread José Roberto de Souza
From: Radhakrishna Sripada Platforms without fences don't have FBC host tracking and those registers are marked as reserved in those platforms. v2: checking num_fences to write to FBC fence registers (Ville) Cc: Rodrigo Vivi Cc: Matt Roper Cc: Dhinakaran Pandiyan Cc: Ville Syrjälä

Re: [Intel-gfx] [PATCH v4 2/2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2020-03-06 Thread Mario Kleiner
Just as a comment, u8 for max_vfreq in struct drm_adaptive_sync_info might be not very future proof? I just read that ASUS announced a "TUF Gaming VG259QM" monitor which seems to have an adaptive sync range of 48 Hz to 280 Hz, exceeding the max 255 Hz of u8? -mario On Fri, Mar 6, 2020 at 4:02

Re: [Intel-gfx] [PATCH v4 1/2] drm/edid: Name the detailed monitor range flags

2020-03-06 Thread Manasi Navare
On Fri, Mar 06, 2020 at 12:30:46PM +0200, Jani Nikula wrote: > On Thu, 05 Mar 2020, Manasi Navare wrote: > > This patch adds defines for the detailed monitor > > range flags as per the EDID specification. > > > > Suggested-by: Ville Syrjälä > > Cc: Ville Syrjälä > > Cc: Harry Wentland > > Cc:

Re: [Intel-gfx] [PATCH v6 i-g-t 2/2] tests/kms_getfb: Add getfb2 tests

2020-03-06 Thread Ville Syrjälä
On Fri, Mar 06, 2020 at 05:46:45PM +, Li, Juston wrote: > On Tue, 2020-02-11 at 13:22 -0800, Juston Li wrote: > > From: Daniel Stone > > > > Mirroring addfb2, add tests for the new ioctl which will return us > > information about framebuffers containing multiple buffers, as well > > as > >

Re: [Intel-gfx] [PATCH v6 i-g-t 2/2] tests/kms_getfb: Add getfb2 tests

2020-03-06 Thread Li, Juston
On Tue, 2020-02-11 at 13:22 -0800, Juston Li wrote: > From: Daniel Stone > > Mirroring addfb2, add tests for the new ioctl which will return us > information about framebuffers containing multiple buffers, as well > as > modifiers. > > Changes since v5: > - Add documentation > > Changes since

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/3] drm/i915/execlists: Enable timeslice on partial virtual engine dequeue

2020-03-06 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/execlists: Enable timeslice on partial virtual engine dequeue URL : https://patchwork.freedesktop.org/series/74384/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8084 -> Patchwork_16859

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v4,1/3] drm/i915/perf: remove generated code

2020-03-06 Thread Patchwork
== Series Details == Series: series starting with [v4,1/3] drm/i915/perf: remove generated code URL : https://patchwork.freedesktop.org/series/74379/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8084 -> Patchwork_16858

[Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [1/3] drm/i915/execlists: Enable timeslice on partial virtual engine dequeue

2020-03-06 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/execlists: Enable timeslice on partial virtual engine dequeue URL : https://patchwork.freedesktop.org/series/74384/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915

[Intel-gfx] [PATCH v2] drm/i915/tgl: Don't treat unslice registers as masked

2020-03-06 Thread Matt Roper
The UNSLICE_UNIT_LEVEL_CLKGATE and UNSLICE_UNIT_LEVEL_CLKGATE2 registers that we update in a few engine workarounds are not masked registers (i.e., we don't have to write a mask bit in the top 16 bits when updating one of the lower 16 bits). As such, these workarounds should be applied via

[Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [v4,1/3] drm/i915/perf: remove generated code

2020-03-06 Thread Patchwork
== Series Details == Series: series starting with [v4,1/3] drm/i915/perf: remove generated code URL : https://patchwork.freedesktop.org/series/74379/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_dpll_mgr.h:285: warning:

Re: [Intel-gfx] [PATCH v2] drm/i915: Limit audio CDCLK>=2*BCLK constraint back to GLK only

2020-03-06 Thread Kai Vehmanen
Hi folks, [+Takashi from ALSA] On Mon, 6 Jan 2020, Matt Roper wrote: >>> On Tue, Dec 31, 2019 at 04:00:07PM +0200, Kai Vehmanen wrote: Revert changes done in commit f6ec9483091f ("drm/i915: extend audio CDCLK>=2*BCLK constraint to more platforms"). Audio drivers > > Agreed; GLK's

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v4,1/3] drm/i915/perf: remove generated code

2020-03-06 Thread Patchwork
== Series Details == Series: series starting with [v4,1/3] drm/i915/perf: remove generated code URL : https://patchwork.freedesktop.org/series/74379/ State : warning == Summary == $ dim checkpatch origin/drm-tip d4ffbb0b3484 drm/i915/perf: remove generated code -:24:

Re: [Intel-gfx] [PATCH] drm/i915/gt: Close race between cacheline_retire and free

2020-03-06 Thread Mika Kuoppala
Chris Wilson writes: > If the cacheline may still be busy, atomically mark it for future > release, and only if we can determine that it will never be used again, > immediately free it. > > Closes: https://gitlab.freedesktop.org/drm/intel/issues/1392 > Signed-off-by: Chris Wilson > Cc: Tvrtko

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/execlists: Show the "switch priority hint" in dumps

2020-03-06 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Show the "switch priority hint" in dumps URL : https://patchwork.freedesktop.org/series/74340/ State : success == Summary == CI Bug Log - changes from CI_DRM_8070_full -> Patchwork_16841_full

[Intel-gfx] [PATCH] drm/i915/gt: Close race between cacheline_retire and free

2020-03-06 Thread Chris Wilson
If the cacheline may still be busy, atomically mark it for future release, and only if we can determine that it will never be used again, immediately free it. Closes: https://gitlab.freedesktop.org/drm/intel/issues/1392 Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Cc: Mika Kuoppala Cc:

Re: [Intel-gfx] [PATCH v2 0/9] drm/i915: Gamma cleanups

2020-03-06 Thread Sharma, Swati2
On 03-Mar-20 11:03 PM, Ville Syrjala wrote: From: Ville Syrjälä Remainder of my earlier gamma cleanups, rebased due to hw vs. uapi split and intel_de_{read,write}(). I didn't get patch#8. Everything looks good to me. There is BAT failure https://patchwork.freedesktop.org/series/69136/

Re: [Intel-gfx] [PATCH v2 9/9] drm/i915: Pass the crtc to the low level read_lut() funcs

2020-03-06 Thread Sharma, Swati2
On 03-Mar-20 11:03 PM, Ville Syrjala wrote: From: Ville Syrjälä The low level read_lut() functions don't need the entire crtc state as they know exactly what they're reading. Just need to pass in the crtc to get at the pipe. This now neatly mirrors the load_lut() direction. Signed-off-by:

Re: [Intel-gfx] [PATCH v2 5/9] drm/i915: s/chv_read_cgm_lut/chv_read_cgm_gamma/

2020-03-06 Thread Ville Syrjälä
On Fri, Mar 06, 2020 at 08:48:42PM +0530, Sharma, Swati2 wrote: > > > On 03-Mar-20 11:03 PM, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > chv_read_cgm_lut() specifically reads the CGM _gamma_ LUT so > > let's rename it to reflect that fact. This also mirrors > > the other direction's

Re: [Intel-gfx] [PATCH v2 7/9] drm/i915: Refactor LUT read functions

2020-03-06 Thread Sharma, Swati2
On 03-Mar-20 11:03 PM, Ville Syrjala wrote: From: Ville Syrjälä Extract all the 'hw value -> LUT entry' stuff into small helpers to make the main 'read out the entire LUT' loop less bogged down by such mundane details. Wow! Signed-off-by: Ville Syrjälä Reviewed-by: Swati Sharma ---

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: HDCP: fix Ri prime and R0 checks during auth (rev2)

2020-03-06 Thread Patchwork
== Series Details == Series: drm/i915: HDCP: fix Ri prime and R0 checks during auth (rev2) URL : https://patchwork.freedesktop.org/series/74271/ State : success == Summary == CI Bug Log - changes from CI_DRM_8070_full -> Patchwork_16840_full

Re: [Intel-gfx] [PATCH v2 6/9] drm/i915: Clean up integer types in color code

2020-03-06 Thread Sharma, Swati2
On 03-Mar-20 11:03 PM, Ville Syrjala wrote: From: Ville Syrjälä A variable called 'i' having an unsigned type is just looking for trouble, and using a sized type generally makes no sense either. Change all of them to just plain old int. And do the same for some 'lut_size' variables which

Re: [Intel-gfx] [PATCH v2 5/9] drm/i915: s/chv_read_cgm_lut/chv_read_cgm_gamma/

2020-03-06 Thread Sharma, Swati2
On 03-Mar-20 11:03 PM, Ville Syrjala wrote: From: Ville Syrjälä chv_read_cgm_lut() specifically reads the CGM _gamma_ LUT so let's rename it to reflect that fact. This also mirrors the other direction's chv_load_cgm_gamma(). At present, since all the readouts are only gamma luts so should

Re: [Intel-gfx] [PATCH] drm/i915: Do not poison i915_request.link on removal

2020-03-06 Thread Mika Kuoppala
Chris Wilson writes: > Do not poison the timeline link on the i915_request to allow both > forward/backward list traversal under RCU. > > [ 9759.139229] RIP: 0010:active_request+0x2a/0x90 [i915] > [ 9759.139240] Code: 41 56 41 55 41 54 55 48 89 fd 53 48 89 f3 48 83 c5 60 e8 > 49 de dc e0 48 8b

Re: [Intel-gfx] [PATCH v2 4/9] drm/i915: s/blob_data/lut/

2020-03-06 Thread Sharma, Swati2
On 03-Mar-20 11:03 PM, Ville Syrjala wrote: From: Ville Syrjälä We're talking about LUT contents here so let's call the thing 'lut' rather than 'blob_data'. This is the name the load_lut() code used before already. Signed-off-by: Ville Syrjälä Reviewed-by: Swati Sharma ---

Re: [Intel-gfx] [PATCH v4 2/2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2020-03-06 Thread Kazlauskas, Nicholas
On 2020-03-05 8:42 p.m., Manasi Navare wrote: Adaptive Sync is a VESA feature so add a DRM core helper to parse the EDID's detailed descritors to obtain the adaptive sync monitor range. Store this info as part fo drm_display_info so it can be used across all drivers. This part of the code is

Re: [Intel-gfx] [PATCH v2 3/9] drm/i915: Split i9xx_read_lut_8() to gmch vs. ilk variants

2020-03-06 Thread Sharma, Swati2
On 03-Mar-20 11:03 PM, Ville Syrjala wrote: From: Ville Syrjälä To mirror the load_luts path let's clone an ilk+ version from i9xx_read_lut_8(). I guess the extra branch isn't a huge issue but feels better to make a clean split. Signed-off-by: Ville Syrjälä Reviewed-by: Swati Sharma

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Return early for await_start on same timeline

2020-03-06 Thread Patchwork
== Series Details == Series: drm/i915: Return early for await_start on same timeline URL : https://patchwork.freedesktop.org/series/74338/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8070_full -> Patchwork_16839_full

Re: [Intel-gfx] [PATCH v2 2/9] drm/i915: Clean up i9xx_load_luts_internal()

2020-03-06 Thread Ville Syrjälä
On Fri, Mar 06, 2020 at 08:12:22PM +0530, Sharma, Swati2 wrote: > > > On 03-Mar-20 11:03 PM, Ville Syrjala wrote: > > +static void i9xx_load_luts(const struct intel_crtc_state *crtc_state) > > +{ > > + struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc); > > + struct

Re: [Intel-gfx] [PATCH 05/17] drm/i915: Wrap i915_active in a simple kreffed struct

2020-03-06 Thread Mika Kuoppala
Chris Wilson writes: > For conveniences of callers that just want to use an i915_active to > track a wide array of concurrent timelines, wrap the base i915_active > struct inside a kref. This i915_active will self-destruct after use. > Found the user, Reviewed-by: Mika Kuoppala >

Re: [Intel-gfx] [PATCH v2 2/9] drm/i915: Clean up i9xx_load_luts_internal()

2020-03-06 Thread Sharma, Swati2
On 03-Mar-20 11:03 PM, Ville Syrjala wrote: +static void i9xx_load_luts(const struct intel_crtc_state *crtc_state) +{ + struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc); + struct drm_i915_private *dev_priv = to_i915(crtc->base.dev); + const struct

[Intel-gfx] [PATCH i-g-t 2/2] gem_wsim: Mark contexts as non-persistent

2020-03-06 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We want to mark workload contexts as non-persistent if possible so that we do not have to worry about leaving long (or infinite!) batches running post exit. Signed-off-by: Tvrtko Ursulin --- benchmarks/gem_wsim.c | 50 --- 1 file

[Intel-gfx] [PATCH i-g-t 1/2] gem_wsim: Fix calibration for special VCS engine name

2020-03-06 Thread Tvrtko Ursulin
From: Tvrtko Ursulin VCS is a special (non-physical) engine id/name which means load-balancing in legacy workloads. As such when i915 balancing is not enabled it needs to have a calibration as well. Signed-off-by: Tvrtko Ursulin --- benchmarks/gem_wsim.c | 2 ++ 1 file changed, 2

Re: [Intel-gfx] [PATCH 01/17] drm/i915/selftests: Apply a heavy handed flush to i915_active

2020-03-06 Thread Mika Kuoppala
Chris Wilson writes: > Due to the ordering of cmpxchg()/dma_fence_signal() inside node_retire(), > we must also use the xchg() as our primary memory barrier to flush the > outstanding callbacks after expected completion of the i915_active. > > Signed-off-by: Chris Wilson Reviewed-by: Mika

  1   2   >