Re: [Intel-gfx] [PATCH 02/44] drm: Add devm_drm_dev_alloc macro

2020-04-07 Thread Sam Ravnborg
Hi Daniel. Finally managed to dive into this.. Maybe I need more coffee, it is still morning here. But alas this patch triggered a few comments. Sam On Fri, Apr 03, 2020 at 03:57:46PM +0200, Daniel Vetter wrote: > The kerneldoc is only added for this new function. Existing kerneldoc > a

Re: [Intel-gfx] [PATCH 08/44] drm/vboxvideo: Stop using drm_device->dev_private

2020-04-07 Thread Thomas Zimmermann
Hi Am 07.04.20 um 09:24 schrieb Daniel Vetter: > On Mon, Apr 6, 2020 at 7:27 PM Thomas Zimmermann wrote: >> >> Hi >> >> Am 03.04.20 um 15:57 schrieb Daniel Vetter: >>> We use the baseclass pattern here, so lets to the proper (and more >>> typesafe) upcasting. >>> >>> Signed-off-by: Daniel Vetter

[Intel-gfx] ✗ Fi.CI.BUILD: failure for sna: Fix double-free crashes.

2020-04-07 Thread Patchwork
== Series Details == Series: sna: Fix double-free crashes. URL : https://patchwork.freedesktop.org/series/75647/ State : failure == Summary == Applying: sna: Fix double-free crashes. error: sha1 information is lacking or useless (src/sna/kgem.c). error: could not build fake ancestor hint: Use

[Intel-gfx] [PATCH xf86-video-intel] sna: Fix double-free crashes.

2020-04-07 Thread Alexei Podtelezhnikov
Fix double-free crashes. See https://bugzilla.redhat.com/show_bug.cgi?id=1808767 Signed-off-by: Alexei Podtelezhnikov --- src/sna/kgem.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/sna/kgem.c b/src/sna/kgem.c index 6a35067c..76bb1599 100644 --- a/src/sna/kgem.c +++ b/src/sna/kgem

[Intel-gfx] ✗ Fi.CI.BUILD: failure for sna: Fix double-free crashes

2020-04-07 Thread Patchwork
== Series Details == Series: sna: Fix double-free crashes URL : https://patchwork.freedesktop.org/series/75646/ State : failure == Summary == Applying: sna: Fix double-free crashes error: sha1 information is lacking or useless (src/sna/kgem.c). error: could not build fake ancestor hint: Use 'g

[Intel-gfx] [PATCH xf86-video-intel] sna: Fix double-free crashes

2020-04-07 Thread Alexei Podtelezhnikov
Fix double-free crashes. See https://bugzilla.redhat.com/show_bug.cgi?id=1808767 Signed-off-by: Alexei Podtelezhnikov --- src/sna/kgem.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/sna/kgem.c b/src/sna/kgem.c index 6a35067c..9865a912 100644 --- a/src/sna/kgem.c +++ b/src/sna/kgem

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Drop vestigal timeslicing assert

2020-04-07 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Drop vestigal timeslicing assert URL : https://patchwork.freedesktop.org/series/75640/ State : success == Summary == CI Bug Log - changes from CI_DRM_8270 -> Patchwork_17245 Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Mark up racy read of intel_ring.head

2020-04-07 Thread Patchwork
== Series Details == Series: drm/i915/gt: Mark up racy read of intel_ring.head URL : https://patchwork.freedesktop.org/series/75639/ State : success == Summary == CI Bug Log - changes from CI_DRM_8270 -> Patchwork_17244 Summary --- *

Re: [Intel-gfx] [PATCH 3/6] i915/gvt: remove unused xen bits

2020-04-07 Thread Zhenyu Wang
On 2020.04.04 11:40:58 +0200, Christoph Hellwig wrote: > No Xen support anywhere here. Remove a dead declaration and an unused > include. > > Signed-off-by: Christoph Hellwig > --- We'll keep that off-tree. Acked-by: Zhenyu Wang Thanks > drivers/gpu/drm/i915/gvt/gvt.c | 1 - > driver

[Intel-gfx] ✓ Fi.CI.BAT: success for debugfs cleanup and gt depenencies.

2020-04-07 Thread Patchwork
== Series Details == Series: debugfs cleanup and gt depenencies. URL : https://patchwork.freedesktop.org/series/75635/ State : success == Summary == CI Bug Log - changes from CI_DRM_8269 -> Patchwork_17243 Summary --- **SUCCESS**

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for debugfs cleanup and gt depenencies.

2020-04-07 Thread Patchwork
== Series Details == Series: debugfs cleanup and gt depenencies. URL : https://patchwork.freedesktop.org/series/75635/ State : warning == Summary == $ dim checkpatch origin/drm-tip 95bc256f9b08 drm/i915: remove broken i915_sseu_status interface 1e192f84ccd9 drm/i915/gt: move remaining debugfs

Re: [Intel-gfx] [PULL] gvt-next-fixes

2020-04-07 Thread Zhenyu Wang
On 2020.04.07 16:53:19 +0300, Jani Nikula wrote: > On Tue, 07 Apr 2020, Rodrigo Vivi wrote: > > On Tue, Apr 07, 2020 at 04:02:56PM +0800, Zhenyu Wang wrote: > >> On 2020.04.03 10:50:33 -0700, Rodrigo Vivi wrote: > >> > > >> > +Dave and Daniel, > >> > > >> > > > >> > > I forgot to mention one th

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for Adding YUV444 packed format support for skl+ (rev5)

2020-04-07 Thread Paauwe, Bob J
I don't see how the patch would have any effect on execlist selftest. This seems to be some random machine error. Bob -- Bob Paauwe   bob.j.paa...@intel.com IOTG / Platform Software Engineering Intel Corp.  Folsom, CA (916) 356-6193 (530) 409-0831 (cell) > -Original Messa

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: move remaining debugfs interfaces into gt (rev6)

2020-04-07 Thread Patchwork
== Series Details == Series: drm/i915/gt: move remaining debugfs interfaces into gt (rev6) URL : https://patchwork.freedesktop.org/series/75333/ State : success == Summary == CI Bug Log - changes from CI_DRM_8269 -> Patchwork_17242 Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt: move remaining debugfs interfaces into gt (rev6)

2020-04-07 Thread Patchwork
== Series Details == Series: drm/i915/gt: move remaining debugfs interfaces into gt (rev6) URL : https://patchwork.freedesktop.org/series/75333/ State : warning == Summary == $ dim checkpatch origin/drm-tip 18e6d48db278 drm/i915/gt: move remaining debugfs interfaces into gt -:131: WARNING:FILE

[Intel-gfx] ✗ Fi.CI.BAT: failure for Adding YUV444 packed format support for skl+ (rev5)

2020-04-07 Thread Patchwork
== Series Details == Series: Adding YUV444 packed format support for skl+ (rev5) URL : https://patchwork.freedesktop.org/series/73020/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8269 -> Patchwork_17241 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Adding YUV444 packed format support for skl+ (rev5)

2020-04-07 Thread Patchwork
== Series Details == Series: Adding YUV444 packed format support for skl+ (rev5) URL : https://patchwork.freedesktop.org/series/73020/ State : warning == Summary == $ dim checkpatch origin/drm-tip 6c533ea6ac21 drm/i915: Adding YUV444 packed format support for skl+ (V15) -:9: WARNING:COMMIT_LOG

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v3,1/8] drm/i915/display: Move out code to return the digital_port of the aux ch

2020-04-07 Thread Patchwork
== Series Details == Series: series starting with [v3,1/8] drm/i915/display: Move out code to return the digital_port of the aux ch URL : https://patchwork.freedesktop.org/series/75634/ State : success == Summary == CI Bug Log - changes from CI_DRM_8269 -> Patchwork_17240

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Enable DP Display Audio WA (rev4)

2020-04-07 Thread Patchwork
== Series Details == Series: drm/i915/display: Enable DP Display Audio WA (rev4) URL : https://patchwork.freedesktop.org/series/75582/ State : success == Summary == CI Bug Log - changes from CI_DRM_8265_full -> Patchwork_17239_full Summary

Re: [Intel-gfx] [PATCH v3 4/8] drm/i915/tc/icl: Implement TC cold sequences

2020-04-07 Thread Imre Deak
On Wed, Apr 08, 2020 at 01:20:02AM +0300, Souza, Jose wrote: > [...] > > > + drm_dbg_kms(&i915->drm, "TC cold block %s\n", ret ? "failed" : > > > + "succeeded"); > > > > You missed turning this to an error. > > Can we postpone this at least for ICL? > > The ICL machines in CI don't h

Re: [Intel-gfx] [PATCH v3 8/8] drm/i915/tc: Do not warn when aux power well of static TC ports timeout

2020-04-07 Thread Imre Deak
On Tue, Apr 07, 2020 at 02:40:00PM -0700, José Roberto de Souza wrote: > This is a expected timeout of static TC ports not conneceted, so > not throwing warnings that would taint CI. > > v3: > - moved checks to tc_phy_aux_timeout_expected() > > Signed-off-by: José Roberto de Souza > --- > .../d

[Intel-gfx] [PATCH] drm/i915/selftests: Drop vestigal timeslicing assert

2020-04-07 Thread Chris Wilson
Since the semaphore interrupt may cause us to yield the timeslice immediately, we may cancel the timer before we notice the submission is complete. The assertion is no longer valid due to the race with the interrupt. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/selftest_lrc.c | 1 - 1

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v3,1/8] drm/i915/display: Move out code to return the digital_port of the aux ch

2020-04-07 Thread Patchwork
== Series Details == Series: series starting with [v3,1/8] drm/i915/display: Move out code to return the digital_port of the aux ch URL : https://patchwork.freedesktop.org/series/75634/ State : warning == Summary == $ dim checkpatch origin/drm-tip 22b6e464a90d drm/i915/display: Move out code

Re: [Intel-gfx] [PATCH v3 4/8] drm/i915/tc/icl: Implement TC cold sequences

2020-04-07 Thread Souza, Jose
On Wed, 2020-04-08 at 01:03 +0300, Imre Deak wrote: > On Tue, Apr 07, 2020 at 02:39:56PM -0700, José Roberto de Souza > wrote: > > This is required for legacy/static TC ports as IOM is not aware of > > the connection and will not trigger the TC cold exit. > > > > Just request PCODE to exit TCCOLD

[Intel-gfx] [PATCH v7 2/2] drm/i915/gt: move remaining debugfs interfaces into gt

2020-04-07 Thread Andi Shyti
From: Andi Shyti The following interfaces: i915_wedged i915_forcewake_user i915_gem_interrupt i915_rcs_topology i915_sseu_status are dependent on gt values. Put them inside gt/ and drop the "i915_" prefix name. This would be the new structure: dri/0/gt | +-- forcewake_user |

[Intel-gfx] [PATCH v7 0/2] debugfs cleanup and gt depenencies.

2020-04-07 Thread Andi Shyti
From: Andi Shyti Hi, In this 7th version I removed in a separate patch the sseu interface which is broken and therefore useless. Thanks Tvrtko and Chris for the review, Andi Changelog = v7: - add a preliminary patch that removes completely the i915_sseu_status interface. v6: - i91

[Intel-gfx] [PATCH] drm/i915/gt: Mark up racy read of intel_ring.head

2020-04-07 Thread Chris Wilson
The intel_ring.head is updated as the requests are retired, but is sampled at any time as we submit requests. Furthermore, it tracks RING_HEAD which is inherently asynchronous. [ 148.630314] BUG: KCSAN: data-race in execlists_dequeue [i915] / i915_request_retire [i915] [ 148.630349] [ 148.6303

[Intel-gfx] [PATCH v6] drm/i915/gt: move remaining debugfs interfaces into gt

2020-04-07 Thread Andi Shyti
From: Andi Shyti The following interfaces: i915_wedged i915_forcewake_user i915_gem_interrupt i915_rcs_topology i915_sseu_status are dependent on gt values. Put them inside gt/ and drop the "i915_" prefix name. This would be the new structure: dri/0/gt | +-- forcewake_user |

Re: [Intel-gfx] [PATCH v3 6/8] drm/i915/tc/tgl: Implement TC cold sequences

2020-04-07 Thread Imre Deak
On Tue, Apr 07, 2020 at 02:39:58PM -0700, José Roberto de Souza wrote: > TC ports can enter in TCCOLD to save power and is required to request > to PCODE to exit this state before use or read to TC registers. > > For TGL there is a new MBOX command to do that with a parameter to ask > PCODE to exi

Re: [Intel-gfx] [PATCH v6] drm/i915/gt: move remaining debugfs interfaces into gt

2020-04-07 Thread Andi Shyti
Please ignore... wrong patch! :/ Andi On Wed, Apr 08, 2020 at 12:43:50AM +0300, Andi Shyti wrote: > From: Andi Shyti > > The following interfaces: > > i915_wedged > i915_forcewake_user > i915_gem_interrupt > i915_rcs_topology > i915_sseu_status > > are dependent on gt values. Put th

Re: [Intel-gfx] [PATCH v8 00/12] Introduce CAP_PERFMON to secure system performance monitoring and observability

2020-04-07 Thread Arnaldo Carvalho de Melo
Em Tue, Apr 07, 2020 at 07:52:56PM +0300, Alexey Budankov escreveu: > > On 07.04.2020 19:36, Arnaldo Carvalho de Melo wrote: > > Em Tue, Apr 07, 2020 at 05:54:27PM +0300, Alexey Budankov escreveu: > >> Could makes sense adding cap_ipc_lock to the binary to isolate from this: > >> kernel/events/co

Re: [Intel-gfx] [PATCH v8 00/12] Introduce CAP_PERFMON to secure system performance monitoring and observability

2020-04-07 Thread Arnaldo Carvalho de Melo
Em Tue, Apr 07, 2020 at 01:56:43PM -0300, Arnaldo Carvalho de Melo escreveu: > > But then, even with that attr.exclude_kernel set to 1 we _still_ get > kernel samples, which looks like another bug, now trying with strace, > which leads us to another rabbit hole: > > [perf@five ~]$ strace -e perf_

Re: [Intel-gfx] [PATCH v3 4/8] drm/i915/tc/icl: Implement TC cold sequences

2020-04-07 Thread Imre Deak
On Tue, Apr 07, 2020 at 02:39:56PM -0700, José Roberto de Souza wrote: > This is required for legacy/static TC ports as IOM is not aware of > the connection and will not trigger the TC cold exit. > > Just request PCODE to exit TCCOLD is not enough as it could enter > again before driver makes use

[Intel-gfx] [PATCH v7 1/2] drm/i915: remove broken i915_sseu_status interface

2020-04-07 Thread Andi Shyti
From: Andi Shyti The i915_sseu_status is broken and the tests on this interface are disabled. There is no reason to drag it along. Remove it! Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/i915_debugfs.c | 257 1 file changed, 257 deletions(-) diff --git a/dr

Re: [Intel-gfx] [PATCH v3 1/8] drm/i915/display: Move out code to return the digital_port of the aux ch

2020-04-07 Thread Imre Deak
On Tue, Apr 07, 2020 at 02:39:53PM -0700, José Roberto de Souza wrote: > Moving the code to return the digital port of the aux channel also > removing the intel_phy_is_tc() to make it generic. > digital_port will be needed in icl_tc_phy_aux_power_well_enable() > so adding it as a parameter to icl_t

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v2,1/8] drm/i915/display: Move out code to return the digital_port of the aux ch

2020-04-07 Thread Souza, Jose
On Tue, 2020-04-07 at 10:28 +, Patchwork wrote: > == Series Details == > > Series: series starting with [v2,1/8] drm/i915/display: Move out code > to return the digital_port of the aux ch > URL : https://patchwork.freedesktop.org/series/75576/ > State : failure > > == Summary == > > CI Bug

[Intel-gfx] [PATCH 0/1] Adding YUV444 packed format support for skl+

2020-04-07 Thread Bob Paauwe
Test-with: <20200407215146.5331-1-bob.j.paa...@intel.com> Stanislav Lisovskiy (1): drm/i915: Adding YUV444 packed format support for skl+ (V15) drivers/gpu/drm/i915/display/intel_display.c | 5 + drivers/gpu/drm/i915/display/intel_sprite.c | 8 drivers/gpu/drm/i915/i915_reg.h

[Intel-gfx] [PATCH 1/1] drm/i915: Adding YUV444 packed format support for skl+ (V15)

2020-04-07 Thread Bob Paauwe
From: Stanislav Lisovskiy PLANE_CTL_FORMAT_AYUV is already supported, according to hardware specification. v2: Edited commit message, removed redundant whitespaces. v3: Fixed fallthrough logic for the format switch cases. v4: Yet again fixed fallthrough logic, to reuse code from other case

Re: [Intel-gfx] [PATCH v2 4/8] drm/i915/tc/icl: Implement TC cold sequences

2020-04-07 Thread Imre Deak
On Tue, Apr 07, 2020 at 11:01:14PM +0300, Souza, Jose wrote: > [...] > > > + } while (ret == -EAGAIN); > > > > Let's protect against an endless loop. > > const ktime_t timeout = ktime_add_ms(ktime_get_raw(), 3); > int ret; > > do { > ret = sandybridge_pcode_write_timeout(i915, >

[Intel-gfx] [PATCH v3 6/8] drm/i915/tc/tgl: Implement TC cold sequences

2020-04-07 Thread José Roberto de Souza
TC ports can enter in TCCOLD to save power and is required to request to PCODE to exit this state before use or read to TC registers. For TGL there is a new MBOX command to do that with a parameter to ask PCODE to exit and block TCCOLD entry or unblock TCCOLD entry. So adding a new power domain t

[Intel-gfx] [PATCH v3 1/8] drm/i915/display: Move out code to return the digital_port of the aux ch

2020-04-07 Thread José Roberto de Souza
Moving the code to return the digital port of the aux channel also removing the intel_phy_is_tc() to make it generic. digital_port will be needed in icl_tc_phy_aux_power_well_enable() so adding it as a parameter to icl_tc_port_assert_ref_held(). While at at removing the duplicated call to icl_tc_p

[Intel-gfx] [PATCH v3 4/8] drm/i915/tc/icl: Implement TC cold sequences

2020-04-07 Thread José Roberto de Souza
This is required for legacy/static TC ports as IOM is not aware of the connection and will not trigger the TC cold exit. Just request PCODE to exit TCCOLD is not enough as it could enter again before driver makes use of the port, to prevent it BSpec states that aux powerwell should be held. So he

[Intel-gfx] [PATCH v3 7/8] drm/i915/tc: Catch TC users accessing FIA registers without enable aux

2020-04-07 Thread José Roberto de Souza
As described in "drm/i915/tc/icl: Implement TC cold sequences" users of TC functions should held aux power well during access to avoid read garbage due HW in TC cold state. v3: - renamed is_tc_cold_blocked() to assert_tc_cold_blocked() - restored the removed 0x checks Reviewed-by: Imre De

[Intel-gfx] [PATCH v3 2/8] drm/i915/display: Add intel_legacy_aux_to_power_domain()

2020-04-07 Thread José Roberto de Souza
This is a similar function to intel_aux_power_domain() but it do not care about TBT ports, this will be needed by ICL TC sequences. v2: - renamed to intel_legacy_aux_to_power_domain() Cc: Imre Deak Cc: Cooper Chiou Cc: Kai-Heng Feng Reviewed-by: Imre Deak Tested-by: You-Sheng Yang Signed-off

[Intel-gfx] [PATCH v3 3/8] drm/i915/display: Split hsw_power_well_enable() into two

2020-04-07 Thread José Roberto de Souza
This is a preparation for ICL TC cold exit sequences. v2: - renamed new functions to hsw_power_well_enable_prepare()/complete() Signed-off-by: José Roberto de Souza Reviewed-by: Imre Deak Tested-by: You-Sheng Yang --- .../drm/i915/display/intel_display_power.c| 39 +++ 1 f

[Intel-gfx] [PATCH v3 5/8] drm/i915/tc: Skip ref held check for TC legacy aux power wells

2020-04-07 Thread José Roberto de Souza
As part of ICL TC cold exit sequences we need to request aux power well before lock the access to TC ports, so skiping the intel_tc_port_ref_held() check for TC legacy ports. Reviewed-by: Imre Deak Tested-by: You-Sheng Yang Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/

[Intel-gfx] [PATCH v3 8/8] drm/i915/tc: Do not warn when aux power well of static TC ports timeout

2020-04-07 Thread José Roberto de Souza
This is a expected timeout of static TC ports not conneceted, so not throwing warnings that would taint CI. v3: - moved checks to tc_phy_aux_timeout_expected() Signed-off-by: José Roberto de Souza --- .../drm/i915/display/intel_display_power.c| 50 +-- 1 file changed, 34 ins

Re: [Intel-gfx] [PATCH v2 6/8] drm/i915/tc/tgl: Implement TC cold sequences

2020-04-07 Thread Souza, Jose
On Tue, 2020-04-07 at 19:02 +0300, Imre Deak wrote: > On Mon, Apr 06, 2020 at 06:11:55PM -0700, José Roberto de Souza > wrote: > > TC ports can enter in TCCOLD to save power and is required to > > request > > to PCODE to exit this state before use or read to TC registers. > > > > For TGL there is

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Yield the timeslice if caught waiting on a user semaphore (rev4)

2020-04-07 Thread Patchwork
== Series Details == Series: drm/i915/gt: Yield the timeslice if caught waiting on a user semaphore (rev4) URL : https://patchwork.freedesktop.org/series/72724/ State : success == Summary == CI Bug Log - changes from CI_DRM_8264_full -> Patchwork_17237_full ===

[Intel-gfx] ✓ Fi.CI.IGT: success for Consider DBuf bandwidth when calculating CDCLK (rev8)

2020-04-07 Thread Patchwork
== Series Details == Series: Consider DBuf bandwidth when calculating CDCLK (rev8) URL : https://patchwork.freedesktop.org/series/74739/ State : success == Summary == CI Bug Log - changes from CI_DRM_8264_full -> Patchwork_17235_full Summar

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Consider DBuf bandwidth when calculating CDCLK (rev8)

2020-04-07 Thread Vudum, Lakshminarayana
Hi Stan, Yes we have a bug. I have re-reported the results. Lakshmi. -Original Message- From: Lisovskiy, Stanislav Sent: Tuesday, April 7, 2020 11:29 PM To: intel-gfx@lists.freedesktop.org; Vudum, Lakshminarayana ; Peres, Martin Subject: Re: ✗ Fi.CI.IGT: failure for Consider DBuf ban

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Consider DBuf bandwidth when calculating CDCLK (rev8)

2020-04-07 Thread Lisovskiy, Stanislav
Hi, gem_ctx_persistence is a gem issue, do we have a bug for this? Best Regards, Lisovskiy Stanislav Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo From: Patchwork Sent: Tuesday, April 7, 2020 10:51:39 PM To: Lisovskiy, S

Re: [Intel-gfx] [PATCH v2 4/8] drm/i915/tc/icl: Implement TC cold sequences

2020-04-07 Thread Souza, Jose
On Tue, 2020-04-07 at 18:42 +0300, Imre Deak wrote: > On Mon, Apr 06, 2020 at 06:11:53PM -0700, José Roberto de Souza > wrote: > > This is required for legacy/static TC ports as IOM is not aware of > > the connection and will not trigger the TC cold exit. > > > > Just request PCODE to exit TCCOLD

[Intel-gfx] ✗ Fi.CI.IGT: failure for Consider DBuf bandwidth when calculating CDCLK (rev8)

2020-04-07 Thread Patchwork
== Series Details == Series: Consider DBuf bandwidth when calculating CDCLK (rev8) URL : https://patchwork.freedesktop.org/series/74739/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8264_full -> Patchwork_17235_full Summar

Re: [Intel-gfx] [PATCH v2 15/17] drm/gma500: Stop using mode->private_flags

2020-04-07 Thread Sam Ravnborg
On Tue, Apr 07, 2020 at 10:08:00PM +0300, Ville Syrjälä wrote: > On Tue, Apr 07, 2020 at 08:56:53PM +0200, Sam Ravnborg wrote: > > Hi Ville. > > > > On Fri, Apr 03, 2020 at 11:40:06PM +0300, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > gma500 only uses mode->private_flags to convey

Re: [Intel-gfx] Regression in i915

2020-04-07 Thread Larry Finger
On 4/7/20 12:35 PM, Chris Wilson wrote: 2 possible causes for 2 very different symptoms are in flight. But neither would strictly be a hang; the most blatant one would be the display server triggering an EFAULT. The patches are currently sitting in the drm-intel-next-fixes queue; a quick test of

Re: [Intel-gfx] [PATCH v2 10/17] drm: Shrink mode->private_flags

2020-04-07 Thread Ville Syrjälä
On Tue, Apr 07, 2020 at 08:52:05PM +0200, Sam Ravnborg wrote: > On Fri, Apr 03, 2020 at 11:40:01PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > gma500 needs 4 bits (to store a pixel multiplier) in the > > mode->private_flags, i915 currently has three bits defined. > > No one else u

Re: [Intel-gfx] [PATCH v2 15/17] drm/gma500: Stop using mode->private_flags

2020-04-07 Thread Ville Syrjälä
On Tue, Apr 07, 2020 at 08:56:53PM +0200, Sam Ravnborg wrote: > Hi Ville. > > On Fri, Apr 03, 2020 at 11:40:06PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > gma500 only uses mode->private_flags to convey the sdvo pixel > > multiplier from the encoder .mode_fixup() hook to the enc

Re: [Intel-gfx] [PATCH v21 05/10] drm/i915: Extract gen specific functions from intel_can_enable_sagv

2020-04-07 Thread Ville Syrjälä
On Fri, Apr 03, 2020 at 09:20:03AM +0300, Stanislav Lisovskiy wrote: > Addressing one of the comments, recommending to extract platform > specific code from intel_can_enable_sagv as a preparation, before > we are going to add support for tgl+. > > Current code in intel_can_enable_sagv is valid onl

Re: [Intel-gfx] [PATCH v2 16/17] drm: Nuke mode->private_flags

2020-04-07 Thread Sam Ravnborg
On Fri, Apr 03, 2020 at 11:40:07PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > The last two uses of mode->private_flags (in i915 and gma500) > are now gone. So let's remove mode->private_flags entirely. > > CC: Sam Ravnborg > Cc: Daniel Vetter > Cc: Emil Velikov > Signed-off-by: Vil

Re: [Intel-gfx] [PATCH v2 15/17] drm/gma500: Stop using mode->private_flags

2020-04-07 Thread Sam Ravnborg
Hi Ville. On Fri, Apr 03, 2020 at 11:40:06PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > gma500 only uses mode->private_flags to convey the sdvo pixel > multiplier from the encoder .mode_fixup() hook to the encoder > .mode_set() hook. Those always seems get called as a pair so > let's

Re: [Intel-gfx] [PATCH v2 12/17] drm/mcde: Use mode->clock instead of reverse calculating it from the vrefresh

2020-04-07 Thread Sam Ravnborg
On Fri, Apr 03, 2020 at 11:40:03PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > htotal*vtotal*vrefresh ~= clock. So just say "clock" when we mean it. > > Cc: Linus Walleij > Cc: Sam Ravnborg > Signed-off-by: Ville Syrjälä Reviewed-by: Sam Ravnborg > --- > drivers/gpu/drm/mcde/mcde_

Re: [Intel-gfx] [PATCH v2 10/17] drm: Shrink mode->private_flags

2020-04-07 Thread Sam Ravnborg
On Fri, Apr 03, 2020 at 11:40:01PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > gma500 needs 4 bits (to store a pixel multiplier) in the > mode->private_flags, i915 currently has three bits defined. > No one else uses this. Reduce the size to u8. > > Reviewed-by: Emil Velikov > Signed-

Re: [Intel-gfx] [PATCH v2 09/17] drm: Flatten drm_mode_vrefresh()

2020-04-07 Thread Sam Ravnborg
On Fri, Apr 03, 2020 at 11:40:00PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Remove the pointless whole-function indentation. Also don't > need to worry about negative values anymore since we switched > everything to u16. > > Reviewed-by: Emil Velikov > Signed-off-by: Ville Syrjälä

Re: [Intel-gfx] [PATCH v2 08/17] drm: Shrink drm_display_mode timings

2020-04-07 Thread Sam Ravnborg
On Fri, Apr 03, 2020 at 11:39:59PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Store the timings (apart from the clock) as u16. The uapi mode > struct already uses u16 for everything so using something bigger > internally doesn't really help us. > > Reviewed-by: Emil Velikov > Reviewe

Re: [Intel-gfx] [PATCH v2 06/17] drm: Shrink mode->type to u8

2020-04-07 Thread Sam Ravnborg
On Fri, Apr 03, 2020 at 11:39:57PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > We only have 7 bits defined for mode->type. Shrink the storage to u8. > > Reviewed-by: Emil Velikov > Reviewed-by: Daniel Vetter > Signed-off-by: Ville Syrjälä Reviewed-by: Sam Ravnborg > --- > include/

Re: [Intel-gfx] [PATCH v2 07/17] drm: Make mode->flags u32

2020-04-07 Thread Sam Ravnborg
On Fri, Apr 03, 2020 at 11:39:58PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > The mode flags are direclty exposed in the uapi as u32. Use the > same size type to store them internally. > > Reviewed-by: Emil Velikov > Signed-off-by: Ville Syrjälä Reviewed-by: Sam Ravnborg > --- > i

Re: [Intel-gfx] [PATCH v2 05/17] drm: Shrink {width, height}_mm to u16

2020-04-07 Thread Sam Ravnborg
On Fri, Apr 03, 2020 at 11:39:56PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Instead of supporting ~2000km wide displayes let's limit ourselves > to ~65m. That seems plenty big enough to me. > > Even with EDID_QUIRK_DETAILED_IN_CM EDIDs seem to be limited to > 10*0xfff which fits int

Re: [Intel-gfx] [PATCH v2 01/17] drm: Nuke mode->hsync

2020-04-07 Thread Sam Ravnborg
On Fri, Apr 03, 2020 at 11:39:52PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Let's just calculate the hsync rate on demand. No point in wasting > space storing it and risking the cached value getting out of sync > with reality. > > v2: Move drm_mode_hsync() next to its only users >

Re: [Intel-gfx] [PATCH v2 7/8] drm/i915/tc: Catch TC users accessing FIA registers without enable aux

2020-04-07 Thread Imre Deak
On Tue, Apr 07, 2020 at 07:04:55PM +0300, Imre Deak wrote: > On Mon, Apr 06, 2020 at 06:11:56PM -0700, José Roberto de Souza wrote: > > As described in "drm/i915/tc/icl: Implement TC cold sequences" users > > of TC functions should held aux power well during access to avoid > > read garbage due HW

Re: [Intel-gfx] [PATCH v8 00/12] Introduce CAP_PERFMON to secure system performance monitoring and observability

2020-04-07 Thread Alexey Budankov
On 07.04.2020 20:02, Arnaldo Carvalho de Melo wrote: > Em Tue, Apr 07, 2020 at 07:52:56PM +0300, Alexey Budankov escreveu: >> >> On 07.04.2020 19:36, Arnaldo Carvalho de Melo wrote: >>> Em Tue, Apr 07, 2020 at 05:54:27PM +0300, Alexey Budankov escreveu: Could makes sense adding cap_ipc_lock

Re: [Intel-gfx] Regression in i915

2020-04-07 Thread Chris Wilson
Quoting Larry Finger (2020-04-07 18:27:52) > Chris, > > With a recent pull of kernel head, my Toshiba laptop with an i915 graphics > card > fails to boot. It hangs at the point where it should switch to a graphics > screen. I bisected the problem to > > commit 7dc8f1143778a35b190f9413f228b3cf2

Re: [Intel-gfx] [PATCH v3 1/5] drm: Introduce plane and CRTC scaling filter properties

2020-04-07 Thread Ville Syrjälä
On Tue, Mar 31, 2020 at 12:08:53AM +0530, Pankaj Bharadiya wrote: > Introduce per-plane and per-CRTC scaling filter properties to allow > userspace to select the driver's default scaling filter or > Nearest-neighbor(NN) filter for upscaling operations on CRTC and > plane. > > Drivers can set up th

[Intel-gfx] Regression in i915

2020-04-07 Thread Larry Finger
Chris, With a recent pull of kernel head, my Toshiba laptop with an i915 graphics card fails to boot. It hangs at the point where it should switch to a graphics screen. I bisected the problem to commit 7dc8f1143778a35b190f9413f228b3cf28f67f8d Author: Chris Wilson Date: Wed Mar 11 16:03:10

Re: [Intel-gfx] [PATCH v8 00/12] Introduce CAP_PERFMON to secure system performance monitoring and observability

2020-04-07 Thread Alexey Budankov
On 07.04.2020 19:40, Arnaldo Carvalho de Melo wrote: > Em Tue, Apr 07, 2020 at 01:36:54PM -0300, Arnaldo Carvalho de Melo escreveu: >> Em Tue, Apr 07, 2020 at 05:54:27PM +0300, Alexey Budankov escreveu: >>> On 07.04.2020 17:35, Arnaldo Carvalho de Melo wrote: Em Tue, Apr 07, 2020 at 11:30:14

Re: [Intel-gfx] [PATCH v8 00/12] Introduce CAP_PERFMON to secure system performance monitoring and observability

2020-04-07 Thread Arnaldo Carvalho de Melo
Em Tue, Apr 07, 2020 at 01:36:54PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Tue, Apr 07, 2020 at 05:54:27PM +0300, Alexey Budankov escreveu: > > On 07.04.2020 17:35, Arnaldo Carvalho de Melo wrote: > > > Em Tue, Apr 07, 2020 at 11:30:14AM -0300, Arnaldo Carvalho de Melo > > > escreveu: > > >

Re: [Intel-gfx] [PATCH v8 00/12] Introduce CAP_PERFMON to secure system performance monitoring and observability

2020-04-07 Thread Arnaldo Carvalho de Melo
Em Thu, Apr 02, 2020 at 11:42:05AM +0300, Alexey Budankov escreveu: > This patch set introduces CAP_PERFMON capability designed to secure > system performance monitoring and observability operations so that > CAP_PERFMON would assist CAP_SYS_ADMIN capability in its governing role > for performance

Re: [Intel-gfx] [PATCH v8 00/12] Introduce CAP_PERFMON to secure system performance monitoring and observability

2020-04-07 Thread Arnaldo Carvalho de Melo
Em Tue, Apr 07, 2020 at 11:30:14AM -0300, Arnaldo Carvalho de Melo escreveu: > [perf@five ~]$ type perf > perf is hashed (/home/perf/bin/perf) > [perf@five ~]$ getcap /home/perf/bin/perf > /home/perf/bin/perf = cap_sys_ptrace,cap_syslog,38+ep > [perf@five ~]$ groups > perf perf_users > [perf@five ~

Re: [Intel-gfx] [PATCH v8 00/12] Introduce CAP_PERFMON to secure system performance monitoring and observability

2020-04-07 Thread Arnaldo Carvalho de Melo
Em Tue, Apr 07, 2020 at 01:36:54PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Tue, Apr 07, 2020 at 05:54:27PM +0300, Alexey Budankov escreveu: > > On 07.04.2020 17:35, Arnaldo Carvalho de Melo wrote: > > > Em Tue, Apr 07, 2020 at 11:30:14AM -0300, Arnaldo Carvalho de Melo > > > escreveu: > > >

Re: [Intel-gfx] [PATCH v8 00/12] Introduce CAP_PERFMON to secure system performance monitoring and observability

2020-04-07 Thread Arnaldo Carvalho de Melo
Em Tue, Apr 07, 2020 at 05:54:27PM +0300, Alexey Budankov escreveu: > On 07.04.2020 17:35, Arnaldo Carvalho de Melo wrote: > > Em Tue, Apr 07, 2020 at 11:30:14AM -0300, Arnaldo Carvalho de Melo escreveu: > >> [perf@five ~]$ type perf > >> perf is hashed (/home/perf/bin/perf) > >> [perf@five ~]$ get

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Enable DP Display Audio WA (rev4)

2020-04-07 Thread Patchwork
== Series Details == Series: drm/i915/display: Enable DP Display Audio WA (rev4) URL : https://patchwork.freedesktop.org/series/75582/ State : success == Summary == CI Bug Log - changes from CI_DRM_8265 -> Patchwork_17239 Summary ---

Re: [Intel-gfx] [PATCH v8 00/12] Introduce CAP_PERFMON to secure system performance monitoring and observability

2020-04-07 Thread Alexey Budankov
On 07.04.2020 19:36, Arnaldo Carvalho de Melo wrote: > Em Tue, Apr 07, 2020 at 05:54:27PM +0300, Alexey Budankov escreveu: >> On 07.04.2020 17:35, Arnaldo Carvalho de Melo wrote: >>> Em Tue, Apr 07, 2020 at 11:30:14AM -0300, Arnaldo Carvalho de Melo escreveu: [perf@five ~]$ type perf p

Re: [Intel-gfx] [PATCH v4 2/3] drm/i915/perf: prepare driver to receive multiple ctx handles

2020-04-07 Thread Lionel Landwerlin
On 07/04/2020 19:22, Chris Wilson wrote: Quoting Lionel Landwerlin (2020-04-07 13:35:39) -static struct intel_context *oa_context(struct i915_perf_stream *stream) -{ - return stream->pinned_ctx ?: stream->engine->kernel_context; -} Idle thought: create a stream->context = intel_context_c

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gem: Promote 'remain' to unsigned long

2020-04-07 Thread Patchwork
== Series Details == Series: drm/i915/gem: Promote 'remain' to unsigned long URL : https://patchwork.freedesktop.org/series/75600/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8264_full -> Patchwork_17231_full Summary

Re: [Intel-gfx] [PATCH v3 4/5] drm/i915: Adjust CDCLK accordingly to our DBuf bw needs

2020-04-07 Thread Ville Syrjälä
On Mon, Mar 30, 2020 at 09:16:49PM +0300, Lisovskiy, Stanislav wrote: > On Mon, Mar 30, 2020 at 08:07:31PM +0300, Ville Syrjälä wrote: > > On Mon, Mar 30, 2020 at 03:23:53PM +0300, Stanislav Lisovskiy wrote: > > > According to BSpec max BW per slice is calculated using formula > > > Max BW = CDCLK

Re: [Intel-gfx] [PATCH v4 2/3] drm/i915/perf: prepare driver to receive multiple ctx handles

2020-04-07 Thread Chris Wilson
Quoting Lionel Landwerlin (2020-04-07 13:35:39) > -static struct intel_context *oa_context(struct i915_perf_stream *stream) > -{ > - return stream->pinned_ctx ?: stream->engine->kernel_context; > -} Idle thought: create a stream->context = intel_context_create(stream->engine); so I can sto

Re: [Intel-gfx] [PATCH v2 8/8] drm/i915/tc: Do not warn when aux power well of static TC ports timeout

2020-04-07 Thread Imre Deak
On Mon, Apr 06, 2020 at 06:11:57PM -0700, José Roberto de Souza wrote: > This is a expected timeout of static TC ports not conneceted, so > not throwing warnings that would taint CI. > > Signed-off-by: José Roberto de Souza > --- > .../drm/i915/display/intel_display_power.c| 37 +++--

Re: [Intel-gfx] [PATCH v4 1/5] drm/i915: Decouple cdclk calculation from modeset checks

2020-04-07 Thread Ville Syrjälä
On Tue, Apr 07, 2020 at 10:33:56AM +0300, Stanislav Lisovskiy wrote: > We need to calculate cdclk after watermarks/ddb has been calculated > as with recent hw CDCLK needs to be adjusted accordingly to DBuf > requirements, which is not possible with current code organization. > > Setting CDCLK acco

Re: [Intel-gfx] [PATCH v2 7/8] drm/i915/tc: Catch TC users accessing FIA registers without enable aux

2020-04-07 Thread Imre Deak
On Mon, Apr 06, 2020 at 06:11:56PM -0700, José Roberto de Souza wrote: > As described in "drm/i915/tc/icl: Implement TC cold sequences" users > of TC functions should held aux power well during access to avoid > read garbage due HW in TC cold state. > > Signed-off-by: José Roberto de Souza > ---

Re: [Intel-gfx] [PATCH v2 6/8] drm/i915/tc/tgl: Implement TC cold sequences

2020-04-07 Thread Imre Deak
On Mon, Apr 06, 2020 at 06:11:55PM -0700, José Roberto de Souza wrote: > TC ports can enter in TCCOLD to save power and is required to request > to PCODE to exit this state before use or read to TC registers. > > For TGL there is a new MBOX command to do that with a parameter to ask > PCODE to exi

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Enable DP Display Audio WA (rev2)

2020-04-07 Thread Patchwork
== Series Details == Series: drm/i915/display: Enable DP Display Audio WA (rev2) URL : https://patchwork.freedesktop.org/series/75582/ State : success == Summary == CI Bug Log - changes from CI_DRM_8264_full -> Patchwork_17230_full Summary

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/hdmi: remove unused intel_hdmi_hdcp2_protocol() (rev2)

2020-04-07 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/hdmi: remove unused intel_hdmi_hdcp2_protocol() (rev2) URL : https://patchwork.freedesktop.org/series/75608/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8264 -> Patchwork_17238

Re: [Intel-gfx] [PATCH 07/17] drm/i915/bw: use struct drm_device based logging

2020-04-07 Thread Wambui Karuga
On Thu, 2 Apr 2020, Jani Nikula wrote: Convert all the DRM_* logging macros to the struct drm_device based macros to provide device specific logging. No functional changes. Cc: Wambui Karuga Signed-off-by: Jani Nikula Reviewed-by: Wambui Karuga --- drivers/gpu/drm/i915/display/intel_

[Intel-gfx] [PATCH v4] drm/i915/display: Enable DP Display Audio WA

2020-04-07 Thread Uma Shankar
For certain DP VDSC bpp settings, hblank asserts before hblank_early, leading to a bad audio state. Driver need to program "hblank early enable" and "samples per line" parameters in AUDIO_CONFIG_BE register. This is Display Audio WA #1406928334 for 4k+VDSC usecase applicable on DP encoders. Implem

Re: [Intel-gfx] [PATCH v2 5/8] drm/i915/tc: Skip ref held check for TC legacy aux power wells

2020-04-07 Thread Imre Deak
On Mon, Apr 06, 2020 at 06:11:54PM -0700, José Roberto de Souza wrote: > As part of ICL TC cold exit sequences we need to request aux power > well before lock the access to TC ports, so skiping the > intel_tc_port_ref_held() check for TC legacy ports. > > Signed-off-by: José Roberto de Souza Rev

Re: [Intel-gfx] [PATCH v2 4/8] drm/i915/tc/icl: Implement TC cold sequences

2020-04-07 Thread Imre Deak
On Mon, Apr 06, 2020 at 06:11:53PM -0700, José Roberto de Souza wrote: > This is required for legacy/static TC ports as IOM is not aware of > the connection and will not trigger the TC cold exit. > > Just request PCODE to exit TCCOLD is not enough as it could enter > again before driver makes use

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/5] drm: report dp downstream port type as a subconnector property

2020-04-07 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm: report dp downstream port type as a subconnector property URL : https://patchwork.freedesktop.org/series/75585/ State : success == Summary == CI Bug Log - changes from CI_DRM_8264_full -> Patchwork_17228_full ===

Re: [Intel-gfx] [PATCH v3] drm/i915/display: Enable DP Display Audio WA

2020-04-07 Thread Shankar, Uma
> -Original Message- > From: Jani Nikula > Sent: Tuesday, April 7, 2020 7:26 PM > To: Shankar, Uma ; intel-gfx@lists.freedesktop.org > Cc: Vehmanen, Kai ; Gupta, Anshuman > ; Shankar, Uma > Subject: Re: [PATCH v3] drm/i915/display: Enable DP Display Audio WA > > On Tue, 07 Apr 2020, U

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Enable DP Display Audio WA

2020-04-07 Thread Patchwork
== Series Details == Series: drm/i915/display: Enable DP Display Audio WA URL : https://patchwork.freedesktop.org/series/75582/ State : success == Summary == CI Bug Log - changes from CI_DRM_8264_full -> Patchwork_17227_full Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Yield the timeslice if caught waiting on a user semaphore (rev4)

2020-04-07 Thread Patchwork
== Series Details == Series: drm/i915/gt: Yield the timeslice if caught waiting on a user semaphore (rev4) URL : https://patchwork.freedesktop.org/series/72724/ State : success == Summary == CI Bug Log - changes from CI_DRM_8264 -> Patchwork_17237 =

  1   2   >